dongnelibrary 0.2.1 → 0.2.2

package/package.json

@@ -3,7 +3,7 @@
   "engines": {
     "node": ">=16.0.0"
   },
-  "version": "0.2.1",
+  "version": "0.2.2",
   "description": "책을 빌릴 수 있는지 확인한다.",
   "main": "src/dongnelibrary.js",
   "bin": {

package/src/library/gg.js

@@ -70,7 +70,7 @@ function search(opt, getBook) {
     } else {
       const dom = new JSDOM(body);
       const $counter = dom.window.document.querySelector('#search_result > div.research-box > div.search-info > b')
-      const count = Number($counter.innerHTML)
+      const count = $counter ? Number($counter.innerHTML) : 0;
       // const $row = dom.window.document.querySelectorAll('.row .book-title')
       const $ = jquery(dom.window)
       const booklist = []
@@ -78,12 +78,14 @@ function search(opt, getBook) {
         const title = $(a).find('.book-title > span').text().trim()
         const rented = $(a).find('.state.typeC').text().trim()
         const libraryName = $(a).find("span:contains('도서관')").next().text().split('|')[0].trim()
-        booklist.push({
-          libraryName,
-          title,
-          maxoffset: count,
-          exist: rented === '대출가능'
-        });
+        if (title) {
+          booklist.push({
+            libraryName,
+            title,
+            maxoffset: count,
+            exist: rented === '대출가능'
+          });
+        }
       })
       getBook(null, {
         startPage: opt.startPage,

package/src/library/osan.js

@@ -68,13 +68,16 @@ function search(opt, getBook) {
       $('.resultList > li').each((_, a) => {
         const title = $(a).find('.tit a').text().trim()
         const rented = $(a).find('.bookStateBar .txt b').text().trim()
-        const libraryName = $(a).find('.site > span:first-child').text().split(']')[1].trim()
-        booklist.push({
-          libraryName,
-          title,
-          maxoffset: count,
-          exist: rented.includes('대출가능')
-        });
+        const b = $(a).find('.site > span:first-child').text().split(']')
+        const libraryName =  b && b[1] ? b[1].trim() : ''
+        if (title) {
+          booklist.push({
+            libraryName,
+            title,
+            maxoffset: count,
+            exist: rented.includes('대출가능')
+          });
+        }
       })
       getBook(null, {
         startPage: opt.startPage,

package/test/gg.spec.js

@@ -4,11 +4,55 @@ const util = require('../src/util.js');
 
 describe('경기도 도서관 (제한시간 20초)', function () {
   this.timeout(20000);
+
   it('Show library list', function (done) {
     assert.ok(lib.getLibraryNames().length > 1);
     done();
   });
 
+  it('Use empty book title', function (done) {
+    lib.search({
+      title: '',
+      libraryName: '경기평택교육도서관',
+      startPage: 1
+    }, function (err) {
+      if(err) {
+        assert.ok(err.msg === 'Need a book name');
+      } else {
+        assert.fail('Need a error msg')
+      }
+      done();
+    });
+  });
+
+  it('Use invalid book title', function (done) {
+    lib.search({
+      title: 'zyxwvutsrqponmlkjihgfedcbaabcdefghijklmnopqrstuvwxyz',
+      libraryName: '경기평택교육도서관',
+      startPage: 1
+    }, function (err, book) {
+      if(err) {
+        assert.fail('must have an empty booklist');
+      }
+      assert.equal(book.booklist.length, 0)
+      done();
+    });
+  });
+
+  it('Use empty library name', function (done) {
+    lib.search({
+      title: '자바스크립트',
+      libraryName: '',
+      startPage: 1
+    }, function (err, book) {
+      if(err) {
+        assert.ok(err.msg === 'Need a library name');
+      }
+      assert.equal(book, undefined)
+      done();
+    });
+  });
+
   it('Show book list of one library', function (done) {
     lib.search({
       title: 'javascript',
@@ -28,4 +72,5 @@ describe('경기도 도서관 (제한시간 20초)', function () {
       done();
     });
   });
+
 });

package/test/osan.spec.js

@@ -4,11 +4,41 @@ const util = require('../src/util.js');
 
 describe('오산시 도서관 (제한시간 20초)', function () {
   this.timeout(20000);
+
   it('Show library list', function (done) {
     assert.ok(lib.getLibraryNames().length > 1);
     done();
   });
 
+  it('Use empty book title', function (done) {
+    lib.search({
+      title: '',
+      libraryName: '양산도서관',
+      startPage: 1
+    }, function (err) {
+      if(err) {
+        assert.ok(err.msg === 'Need a book name');
+      } else {
+        assert.fail('Need a error msg')
+      }
+      done();
+    });
+  });
+
+  it('Use invalid book title', function (done) {
+    lib.search({
+      title: 'zyxwvutsrqponmlkjihgfedcbaabcdefghijklmnopqrstuvwxyz',
+      libraryName: '양산도서관',
+      startPage: 1
+    }, function (err, book) {
+      if(err) {
+        assert.fail('must have an empty booklist');
+      }
+      assert.equal(book.booklist.length, 0)
+      done();
+    });
+  });
+
   it('Show book list of one library', function (done) {
     lib.search({
       title: 'javascript',
@@ -29,7 +59,6 @@ describe('오산시 도서관 (제한시간 20초)', function () {
     });
   });
 
-
   it('Show book list of all libraries', function (done) {
     lib.search({
       title: 'javascript',