docpouch-client 1.1.0 → 1.1.2

package/dist/index.d.ts

@@ -414,6 +414,7 @@ export interface I_OidcUserInfo {
 export interface I_OidcClientRegistration {
     client_name: string;
     redirect_uris: string[];
+    post_logout_redirect_uris?: string[];
     grant_types?: string[];
     response_types?: string[];
     scope?: string;
@@ -433,6 +434,7 @@ export interface I_OidcClientResponse {
     registration_client_uri?: string;
     client_name?: string;
     redirect_uris?: string[];
+    post_logout_redirect_uris?: string[];
     grant_types?: string[];
     response_types?: string[];
     scope?: string;

package/dist/index.js

@@ -491,19 +491,19 @@ export default class docPouchClient {
         const wasOidc = this.authMethod === 'oidc';
         // For OIDC, redirect to /end_session endpoint
         if (wasOidc && this.oidcConfig && typeof window !== 'undefined') {
-            const redirectUri = options?.redirectUri || this.oidcConfig.redirectUri || window.location.origin;
+            // Use postLogoutRedirectUri if available, otherwise fallback to redirectUri
+            const redirectUri = options?.redirectUri || this.oidcConfig.postLogoutRedirectUri || this.oidcConfig.redirectUri || window.location.origin;
             let url = `${this.oidcConfig.issuer}/end_session?post_logout_redirect_uri=${encodeURIComponent(redirectUri)}`;
             // Add id_token_hint if available
             const idToken = options?.idTokenHint || this.oidcIdToken;
             if (idToken) {
                 url += `&id_token_hint=${idToken}`;
             }
-            // Clear tokens before redirect
-            this.authToken = null;
-            this.clearOidcTokens();
-            this.authMethod = 'none';
-            if (this.socket.connected)
-                this.socket.disconnect();
+            // DO NOT clear tokens before redirect - wait for redirect back to determine actual logout status
+            // Instead, set a flag to indicate we're in logout process
+            if (typeof window !== 'undefined' && window.sessionStorage) {
+                sessionStorage.setItem('docpouch_logout_in_progress', 'true');
+            }
             // Redirect to OIDC logout endpoint
             window.location.href = url;
             return;
@@ -543,7 +543,7 @@ export default class docPouchClient {
         if (!this.oidcConfig?.issuer) {
             throw new Error('OIDC issuer not configured');
         }
-        const { redirectUri = this.oidcConfig.redirectUri || window.location.origin, idTokenHint } = options || {};
+        const { redirectUri = this.oidcConfig.postLogoutRedirectUri || this.oidcConfig.redirectUri || window.location.origin, idTokenHint } = options || {};
         let url = `${this.oidcConfig.issuer}/end_session?post_logout_redirect_uri=${encodeURIComponent(redirectUri)}`;
         if (idTokenHint) {
             url += `&id_token_hint=${idTokenHint}`;
@@ -551,12 +551,11 @@ export default class docPouchClient {
         else if (this.oidcIdToken) {
             url += `&id_token_hint=${this.oidcIdToken}`;
         }
-        // Clear tokens before redirect
-        this.authToken = null;
-        this.clearOidcTokens();
-        this.authMethod = 'none';
-        if (this.socket.connected)
-            this.socket.disconnect();
+        // DO NOT clear tokens before redirect - wait for redirect back to determine actual logout status
+        // Instead, set a flag to indicate we're in logout process
+        if (typeof window !== 'undefined' && window.sessionStorage) {
+            sessionStorage.setItem('docpouch_logout_in_progress', 'true');
+        }
         // Emit OIDC logout event
         this.emit('oidc-logout');
         this.emit('logout');
@@ -612,18 +611,71 @@ export default class docPouchClient {
      * @returns {boolean} True if user was just logged out
      */
     wasJustLoggedOut() {
-        // Check URL query parameter
+        // Check if we're in the middle of a logout process
+        const logoutInProgress = typeof window !== 'undefined' && window.sessionStorage
+            ? sessionStorage.getItem('docpouch_logout_in_progress') === 'true'
+            : false;
+        if (!logoutInProgress) {
+            return false;
+        }
+        // Check URL query parameters for logout confirmation
         const urlParams = new URLSearchParams(window.location.search);
-        if (urlParams.get('logout') === 'true') {
-            return true;
+        const logoutParam = urlParams.get('logout');
+        // If logout parameter is explicitly 'no', user cancelled
+        if (logoutParam === 'no') {
+            // Clear the logout in progress flag
+            if (typeof window !== 'undefined' && window.sessionStorage) {
+                sessionStorage.removeItem('docpouch_logout_in_progress');
+            }
+            return false;
         }
-        // Check localStorage flag
-        const lastAuthMethod = localStorage.getItem('lastAuthMethod');
-        const currentAuthMethod = localStorage.getItem('authMethod');
-        // If last was OIDC/JWT but current is none, was logged out
-        if (lastAuthMethod && currentAuthMethod === null) {
+        // If logout parameter is 'yes' or 'true', user confirmed logout
+        if (logoutParam === 'yes' || logoutParam === 'true') {
+            // Clear the logout in progress flag
+            if (typeof window !== 'undefined' && window.sessionStorage) {
+                sessionStorage.removeItem('docpouch_logout_in_progress');
+            }
+            // Clear tokens as user confirmed logout
+            this.authToken = null;
+            this.clearOidcTokens();
+            this.authMethod = 'none';
+            if (this.socket.connected)
+                this.socket.disconnect();
             return true;
         }
+        // If no logout parameter but we were in logout process, 
+        // check if OIDC provider sent us back without confirmation
+        // This could happen if there was an error or user cancelled in another way
+        if (logoutParam === null) {
+            // Check if this is a post-logout redirect - assume logout was successful
+            // unless there's an error parameter
+            const errorParam = urlParams.get('error');
+            if (!errorParam) {
+                // Clear the logout in progress flag
+                if (typeof window !== 'undefined' && window.sessionStorage) {
+                    sessionStorage.removeItem('docpouch_logout_in_progress');
+                }
+                // Clear tokens
+                this.authToken = null;
+                this.clearOidcTokens();
+                this.authMethod = 'none';
+                if (this.socket.connected)
+                    this.socket.disconnect();
+                return true;
+            }
+            else {
+                // There was an error, assume logout was cancelled
+                // Clear the logout in progress flag
+                if (typeof window !== 'undefined' && window.sessionStorage) {
+                    sessionStorage.removeItem('docpouch_logout_in_progress');
+                }
+                return false;
+            }
+        }
+        // Default case - clear the flag to prevent stuck state
+        if (typeof window !== 'undefined' && window.sessionStorage) {
+            sessionStorage.removeItem('docpouch_logout_in_progress');
+        }
         return false;
     }
     // OIDC Dynamic Client Registration Methods

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "docpouch-client",
-  "version": "1.1.0",
+  "version": "1.1.2",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "exports": {

package/test-post-logout.js

@@ -0,0 +1,24 @@
+// Test script to verify post_logout_redirect_uris functionality
+const fs = require('fs');
+
+// Read the built client to verify the changes
+const clientCode = fs.readFileSync('dist/index.js', 'utf8');
+
+console.log('Checking for post_logout_redirect_uris support...');
+
+// Check if the interfaces include post_logout_redirect_uris
+const hasRegistrationInterface = clientCode.includes('post_logout_redirect_uris?: string[]');
+const hasResponseInterface = clientCode.includes('post_logout_redirect_uris?: string[]');
+
+// Check if logout methods use postLogoutRedirectUri
+const usesPostLogoutUri = clientCode.includes('this.oidcConfig.postLogoutRedirectUri');
+
+console.log('I_OidcClientRegistration has post_logout_redirect_uris:', hasRegistrationInterface);
+console.log('I_OidcClientResponse has post_logout_redirect_uris:', hasResponseInterface);
+console.log('Logout methods use postLogoutRedirectUri:', usesPostLogoutUri);
+
+if (hasRegistrationInterface && hasResponseInterface && usesPostLogoutUri) {
+    console.log('✅ All post_logout_redirect_uris functionality is properly implemented!');
+} else {
+    console.log('❌ Some post_logout_redirect_uris functionality is missing');
+}