dockview 4.3.1 → 4.4.1

package/dist/cjs/dockview/defaultTab.d.ts

@@ -1,6 +1,6 @@
 import React from 'react';
 import { IDockviewPanelHeaderProps } from 'dockview-core';
-export type IDockviewDefaultTabProps = IDockviewPanelHeaderProps & React.DOMAttributes<HTMLDivElement> & {
+export type IDockviewDefaultTabProps = IDockviewPanelHeaderProps & React.HtmlHTMLAttributes<HTMLDivElement> & {
     hideClose?: boolean;
     closeActionOverride?: () => void;
 };

package/dist/dockview.amd.js

@@ -1,6 +1,6 @@
 /**
  * dockview
- * @version 4.3.1
+ * @version 4.4.1
  * @link https://github.com/mathuo/dockview
  * @license MIT
  */
@@ -3652,6 +3652,9 @@ define(['exports', 'react', 'react-dom'], (function (exports, React, ReactDOM) {
       get onDidPopoutGroupPositionChange() {
           return this.component.onDidPopoutGroupPositionChange;
       }
+      get onDidOpenPopoutWindowFail() {
+          return this.component.onDidOpenPopoutWindowFail;
+      }
       /**
        * All panel objects.
        */
@@ -5020,7 +5023,7 @@ define(['exports', 'react', 'react-dom'], (function (exports, React, ReactDOM) {
           this._element = document.createElement('div');
           this._element.className = 'dv-tab';
           this._element.tabIndex = 0;
-          this._element.draggable = true;
+          this._element.draggable = !this.accessor.options.disableDnd;
           toggleClass(this.element, 'dv-inactive-tab', true);
           const dragHandler = new TabDragHandler(this._element, this.accessor, this.group, this.panel);
           this.dropTarget = new Droptarget(this._element, {
@@ -5068,6 +5071,9 @@ define(['exports', 'react', 'react-dom'], (function (exports, React, ReactDOM) {
           this.content = part;
           this._element.appendChild(this.content.element);
       }
+      updateDragAndDropState() {
+          this._element.draggable = !this.accessor.options.disableDnd;
+      }
       dispose() {
           super.dispose();
       }
@@ -5139,7 +5145,7 @@ define(['exports', 'react', 'react-dom'], (function (exports, React, ReactDOM) {
           this.onDragStart = this._onDragStart.event;
           this._element = document.createElement('div');
           this._element.className = 'dv-void-container';
-          this._element.draggable = true;
+          this._element.draggable = !this.accessor.options.disableDnd;
           this.addDisposables(this._onDrop, this._onDragStart, addDisposableListener(this._element, 'pointerdown', () => {
               this.accessor.doSetGroupActive(this.group);
           }));
@@ -5162,6 +5168,9 @@ define(['exports', 'react', 'react-dom'], (function (exports, React, ReactDOM) {
               this._onDrop.fire(event);
           }), this.dropTarget);
       }
+      updateDragAndDropState() {
+          this._element.draggable = !this.accessor.options.disableDnd;
+      }
   }
 
   class Scrollbar extends CompositeDisposable {
@@ -5422,6 +5431,11 @@ define(['exports', 'react', 'react-dom'], (function (exports, React, ReactDOM) {
                   .map((x) => x.value.panel.id);
           this._onOverflowTabsChange.fire({ tabs, reset: options.reset });
       }
+      updateDragAndDropState() {
+          for (const tab of this._tabs) {
+              tab.value.updateDragAndDropState();
+          }
+      }
   }
 
   const createSvgElementFromPath = (params) => {
@@ -5694,6 +5708,10 @@ define(['exports', 'react', 'react-dom'], (function (exports, React, ReactDOM) {
               });
           }));
       }
+      updateDragAndDropState() {
+          this.tabs.updateDragAndDropState();
+          this.voidContainer.updateDragAndDropState();
+      }
   }
 
   class DockviewUnhandledDragOverEvent extends AcceptableEvent {
@@ -6399,6 +6417,9 @@ define(['exports', 'react', 'react-dom'], (function (exports, React, ReactDOM) {
               }));
           }
       }
+      updateDragAndDropState() {
+          this.tabsContainer.updateDragAndDropState();
+      }
       dispose() {
           var _a, _b, _c;
           super.dispose();
@@ -8231,6 +8252,8 @@ define(['exports', 'react', 'react-dom'], (function (exports, React, ReactDOM) {
           this.onDidPopoutGroupSizeChange = this._onDidPopoutGroupSizeChange.event;
           this._onDidPopoutGroupPositionChange = new Emitter();
           this.onDidPopoutGroupPositionChange = this._onDidPopoutGroupPositionChange.event;
+          this._onDidOpenPopoutWindowFail = new Emitter();
+          this.onDidOpenPopoutWindowFail = this._onDidOpenPopoutWindowFail.event;
           this._onDidLayoutFromJSON = new Emitter();
           this.onDidLayoutFromJSON = this._onDidLayoutFromJSON.event;
           this._onDidActivePanelChange = new Emitter({ replay: true });
@@ -8295,7 +8318,7 @@ define(['exports', 'react', 'react-dom'], (function (exports, React, ReactDOM) {
           if (options.debug) {
               this.addDisposables(new StrictEventsSequencing(this));
           }
-          this.addDisposables(this.rootDropTargetContainer, this.overlayRenderContainer, this._onWillDragPanel, this._onWillDragGroup, this._onWillShowOverlay, this._onDidActivePanelChange, this._onDidAddPanel, this._onDidRemovePanel, this._onDidLayoutFromJSON, this._onDidDrop, this._onWillDrop, this._onDidMovePanel, this._onDidAddGroup, this._onDidRemoveGroup, this._onDidActiveGroupChange, this._onUnhandledDragOverEvent, this._onDidMaximizedGroupChange, this._onDidOptionsChange, this._onDidPopoutGroupSizeChange, this._onDidPopoutGroupPositionChange, this.onDidViewVisibilityChangeMicroTaskQueue(() => {
+          this.addDisposables(this.rootDropTargetContainer, this.overlayRenderContainer, this._onWillDragPanel, this._onWillDragGroup, this._onWillShowOverlay, this._onDidActivePanelChange, this._onDidAddPanel, this._onDidRemovePanel, this._onDidLayoutFromJSON, this._onDidDrop, this._onWillDrop, this._onDidMovePanel, this._onDidAddGroup, this._onDidRemoveGroup, this._onDidActiveGroupChange, this._onUnhandledDragOverEvent, this._onDidMaximizedGroupChange, this._onDidOptionsChange, this._onDidPopoutGroupSizeChange, this._onDidPopoutGroupPositionChange, this._onDidOpenPopoutWindowFail, this.onDidViewVisibilityChangeMicroTaskQueue(() => {
               this.updateWatermark();
           }), this.onDidAdd((event) => {
               if (!this._moving) {
@@ -8441,13 +8464,6 @@ define(['exports', 'react', 'react-dom'], (function (exports, React, ReactDOM) {
               if (_window.isDisposed) {
                   return false;
               }
-              if (popoutContainer === null) {
-                  popoutWindowDisposable.dispose();
-                  return false;
-              }
-              const gready = document.createElement('div');
-              gready.className = 'dv-overlay-render-container';
-              const overlayRenderContainer = new OverlayRenderContainer(gready, this);
               const referenceGroup = (options === null || options === void 0 ? void 0 : options.referenceGroup)
                   ? options.referenceGroup
                   : itemToPopout instanceof DockviewPanel
@@ -8455,7 +8471,7 @@ define(['exports', 'react', 'react-dom'], (function (exports, React, ReactDOM) {
                       : itemToPopout;
               const referenceLocation = itemToPopout.api.location.type;
               /**
-               * The group that is being added doesn't already exist within the DOM, the most likely occurance
+               * The group that is being added doesn't already exist within the DOM, the most likely occurrence
                * of this case is when being called from the `fromJSON(...)` method
                */
               const isGroupAddedToDom = referenceGroup.element.parentElement !== null;
@@ -8468,8 +8484,28 @@ define(['exports', 'react', 'react-dom'], (function (exports, React, ReactDOM) {
               }
               else {
                   group = this.createGroup({ id: groupId });
-                  this._onDidAddGroup.fire(group);
+                  if (popoutContainer) {
+                      this._onDidAddGroup.fire(group);
+                  }
+              }
+              if (popoutContainer === null) {
+                  console.error('dockview: failed to create popout. perhaps you need to allow pop-ups for this website');
+                  popoutWindowDisposable.dispose();
+                  this._onDidOpenPopoutWindowFail.fire();
+                  // if the popout window was blocked, we need to move the group back to the reference group
+                  // and set it to visible
+                  this.movingLock(() => moveGroupWithoutDestroying({
+                      from: group,
+                      to: referenceGroup,
+                  }));
+                  if (!referenceGroup.api.isVisible) {
+                      referenceGroup.api.setVisible(true);
+                  }
+                  return false;
               }
+              const gready = document.createElement('div');
+              gready.className = 'dv-overlay-render-container';
+              const overlayRenderContainer = new OverlayRenderContainer(gready, this);
               group.model.renderContainer = overlayRenderContainer;
               group.layout(_window.window.innerWidth, _window.window.innerHeight);
               let floatingBox;
@@ -8626,7 +8662,7 @@ define(['exports', 'react', 'react-dom'], (function (exports, React, ReactDOM) {
               return true;
           })
               .catch((err) => {
-              console.error('dockview: failed to create popout window', err);
+              console.error('dockview: failed to create popout.', err);
               return false;
           });
       }
@@ -8833,7 +8869,12 @@ define(['exports', 'react', 'react-dom'], (function (exports, React, ReactDOM) {
               }
           }
           this.updateDropTargetModel(options);
+          const oldDisableDnd = this.options.disableDnd;
           this._options = Object.assign(Object.assign({}, this.options), options);
+          const newDisableDnd = this.options.disableDnd;
+          if (oldDisableDnd !== newDisableDnd) {
+              this.updateDragAndDropState();
+          }
           if ('theme' in options) {
               this.updateTheme();
           }
@@ -8848,6 +8889,12 @@ define(['exports', 'react', 'react-dom'], (function (exports, React, ReactDOM) {
               }
           }
       }
+      updateDragAndDropState() {
+          // Update draggable state for all tabs and void containers
+          for (const group of this.groups) {
+              group.model.updateDragAndDropState();
+          }
+      }
       focus() {
           var _a;
           (_a = this.activeGroup) === null || _a === void 0 ? void 0 : _a.focus();