dockview 3.0.1 → 3.0.2

package/dist/dockview.js

@@ -1,6 +1,6 @@
 /**
  * dockview
- * @version 3.0.1
+ * @version 3.0.2
  * @link https://github.com/mathuo/dockview
  * @license MIT
  */
@@ -884,7 +884,7 @@
           this._margin = value;
       }
       constructor(container, options) {
-          var _a;
+          var _a, _b;
           this.container = container;
           this.viewItems = [];
           this.sashes = [];
@@ -982,9 +982,9 @@
               //
               return delta;
           };
-          this._orientation = options.orientation;
+          this._orientation = (_a = options.orientation) !== null && _a !== void 0 ? _a : exports.Orientation.VERTICAL;
           this.element = this.createContainer();
-          this.margin = (_a = options.margin) !== null && _a !== void 0 ? _a : 0;
+          this.margin = (_b = options.margin) !== null && _b !== void 0 ? _b : 0;
           this.proportionalLayout =
               options.proportionalLayout === undefined
                   ? true
@@ -2803,9 +2803,9 @@
       set locked(value) {
           this.gridview.locked = value;
       }
-      constructor(parentElement, options) {
+      constructor(container, options) {
           var _a;
-          super(parentElement, options.disableAutoResizing);
+          super(document.createElement('div'), options.disableAutoResizing);
           this._id = nextLayoutId$1.next();
           this._groups = new Map();
           this._onDidRemove = new Emitter();
@@ -2824,6 +2824,8 @@
           this.element.style.width = '100%';
           this._classNames = new Classnames(this.element);
           this._classNames.setClassNames((_a = options.className) !== null && _a !== void 0 ? _a : '');
+          // the container is owned by the third-party, do not modify/delete it
+          container.appendChild(this.element);
           this.gridview = new Gridview(!!options.proportionalLayout, options.styles, options.orientation, options.locked, options.margin);
           this.gridview.locked = !!options.locked;
           this.element.appendChild(this.gridview.element);
@@ -7520,9 +7522,9 @@
       get floatingGroups() {
           return this._floatingGroups;
       }
-      constructor(parentElement, options) {
+      constructor(container, options) {
           var _a;
-          super(parentElement, {
+          super(container, {
               proportionalLayout: true,
               orientation: exports.Orientation.HORIZONTAL,
               styles: options.hideBorders
@@ -7878,6 +7880,16 @@
                       group.model.renderContainer =
                           this.overlayRenderContainer;
                       returnedGroup = group;
+                      const alreadyRemoved = !this._popoutGroups.find((p) => p.popoutGroup === group);
+                      if (alreadyRemoved) {
+                          /**
+                           * If this popout group was explicitly removed then we shouldn't run the additional
+                           * steps. To tell if the running of this disposable is the result of this popout group
+                           * being explicitly removed we can check if this popout group is still referenced in
+                           * the `this._popoutGroups` list.
+                           */
+                          return;
+                      }
                       if (floatingBox) {
                           this.addFloatingGroup(group, {
                               height: floatingBox.height,
@@ -9054,9 +9066,9 @@
       set deserializer(value) {
           this._deserializer = value;
       }
-      constructor(parentElement, options) {
+      constructor(container, options) {
           var _a;
-          super(parentElement, {
+          super(container, {
               proportionalLayout: (_a = options.proportionalLayout) !== null && _a !== void 0 ? _a : true,
               orientation: options.orientation,
               styles: options.hideBorders
@@ -9345,9 +9357,9 @@
               ? this.splitview.size
               : this.splitview.orthogonalSize;
       }
-      constructor(parentElement, options) {
+      constructor(container, options) {
           var _a;
-          super(parentElement, options.disableAutoResizing);
+          super(document.createElement('div'), options.disableAutoResizing);
           this._splitviewChangeDisposable = new MutableDisposable();
           this._panels = new Map();
           this._onDidLayoutfromJSON = new Emitter();
@@ -9358,8 +9370,12 @@
           this.onDidRemoveView = this._onDidRemoveView.event;
           this._onDidLayoutChange = new Emitter();
           this.onDidLayoutChange = this._onDidLayoutChange.event;
+          this.element.style.height = '100%';
+          this.element.style.width = '100%';
           this._classNames = new Classnames(this.element);
           this._classNames.setClassNames((_a = options.className) !== null && _a !== void 0 ? _a : '');
+          // the container is owned by the third-party, do not modify/delete it
+          container.appendChild(this.element);
           this._options = options;
           this.splitview = new Splitview(this.element, options);
           this.addDisposables(this._onDidAddView, this._onDidLayoutfromJSON, this._onDidRemoveView, this._onDidLayoutChange);
@@ -9669,9 +9685,9 @@
       get options() {
           return this._options;
       }
-      constructor(parentElement, options) {
+      constructor(container, options) {
           var _a;
-          super(parentElement, options.disableAutoResizing);
+          super(document.createElement('div'), options.disableAutoResizing);
           this._id = nextLayoutId.next();
           this._disposable = new MutableDisposable();
           this._viewDisposables = new Map();
@@ -9687,9 +9703,13 @@
           this.onDidRemoveView = this._onDidRemoveView.event;
           this._onUnhandledDragOverEvent = new Emitter();
           this.onUnhandledDragOverEvent = this._onUnhandledDragOverEvent.event;
+          this.element.style.height = '100%';
+          this.element.style.width = '100%';
           this.addDisposables(this._onDidLayoutChange, this._onDidLayoutfromJSON, this._onDidDrop, this._onDidAddView, this._onDidRemoveView, this._onUnhandledDragOverEvent);
           this._classNames = new Classnames(this.element);
           this._classNames.setClassNames((_a = options.className) !== null && _a !== void 0 ? _a : '');
+          // the container is owned by the third-party, do not modify/delete it
+          container.appendChild(this.element);
           this._options = options;
           this.paneview = new Paneview(this.element, {
               // only allow paneview in the vertical orientation for now
@@ -10509,7 +10529,7 @@
               createPrefixHeaderActionComponent: createGroupControlElement(props.prefixHeaderActionsComponent, { addPortal }),
           });
       }, [props.prefixHeaderActionsComponent]);
-      return (React.createElement("div", { className: props.className, style: { height: '100%', width: '100%' }, ref: domRef }, portals));
+      return (React.createElement("div", { style: { height: '100%', width: '100%' }, ref: domRef }, portals));
   });
   DockviewReact.displayName = 'DockviewComponent';
 
@@ -10669,7 +10689,7 @@
               },
           });
       }, [props.components]);
-      return (React.createElement("div", { className: props.className, style: { height: '100%', width: '100%' }, ref: domRef }, portals));
+      return (React.createElement("div", { style: { height: '100%', width: '100%' }, ref: domRef }, portals));
   });
   SplitviewReact.displayName = 'SplitviewComponent';
 
@@ -10752,7 +10772,7 @@
               },
           });
       }, [props.components]);
-      return (React.createElement("div", { className: props.className, style: { height: '100%', width: '100%' }, ref: domRef }, portals));
+      return (React.createElement("div", { style: { height: '100%', width: '100%' }, ref: domRef }, portals));
   });
   GridviewReact.displayName = 'GridviewComponent';
 
@@ -10884,7 +10904,7 @@
               disposable.dispose();
           };
       }, [props.onDidDrop]);
-      return (React.createElement("div", { className: props.className, style: { height: '100%', width: '100%' }, ref: domRef }, portals));
+      return (React.createElement("div", { style: { height: '100%', width: '100%' }, ref: domRef }, portals));
   });
   PaneviewReact.displayName = 'PaneviewComponent';