dockview 1.13.1 → 1.14.1

package/dist/dockview.noStyle.js

@@ -1,6 +1,6 @@
 /**
  * dockview
- * @version 1.13.1
+ * @version 1.14.1
  * @link https://github.com/mathuo/dockview
  * @license MIT
  */
@@ -129,7 +129,7 @@
             this.value = value;
         }
         print() {
-            console.warn(this.value);
+            console.warn('dockview: stacktrace', this.value);
         }
     }
     class Listener {
@@ -194,7 +194,7 @@
                             var _a;
                             // don't check until stack of execution is completed to allow for out-of-order disposals within the same execution block
                             for (const listener of this._listeners) {
-                                console.warn((_a = listener.stacktrace) === null || _a === void 0 ? void 0 : _a.print());
+                                console.warn('dockview: stacktrace', (_a = listener.stacktrace) === null || _a === void 0 ? void 0 : _a.print());
                             }
                         });
                     }
@@ -274,7 +274,7 @@
         }
     }
 
-    var Disposable;
+    exports.DockviewDisposable = void 0;
     (function (Disposable) {
         Disposable.NONE = {
             dispose: () => {
@@ -289,7 +289,7 @@
             };
         }
         Disposable.from = from;
-    })(Disposable || (Disposable = {}));
+    })(exports.DockviewDisposable || (exports.DockviewDisposable = {}));
     class CompositeDisposable {
         get isDisposed() {
             return this._isDisposed;
@@ -312,7 +312,7 @@
     }
     class MutableDisposable {
         constructor() {
-            this._disposable = Disposable.NONE;
+            this._disposable = exports.DockviewDisposable.NONE;
         }
         set value(disposable) {
             if (this._disposable) {
@@ -323,7 +323,7 @@
         dispose() {
             if (this._disposable) {
                 this._disposable.dispose();
-                this._disposable = Disposable.NONE;
+                this._disposable = exports.DockviewDisposable.NONE;
             }
         }
     }
@@ -1750,7 +1750,7 @@
             this.orientation = orientation;
             this.proportionalLayout = proportionalLayout;
             this.styles = styles;
-            this._childrenDisposable = Disposable.NONE;
+            this._childrenDisposable = exports.DockviewDisposable.NONE;
             this.children = [];
             this._onDidChange = new Emitter();
             this.onDidChange = this._onDidChange.event;
@@ -1898,7 +1898,7 @@
                         this.setChildVisible(i, visible);
                     });
                 }
-                return Disposable.NONE;
+                return exports.DockviewDisposable.NONE;
             }));
         }
         dispose() {
@@ -2599,7 +2599,7 @@
             this.gridview.locked = !!options.locked;
             this.element.appendChild(this.gridview.element);
             this.layout(0, 0, true); // set some elements height/widths
-            this.addDisposables(Disposable.from(() => {
+            this.addDisposables(exports.DockviewDisposable.from(() => {
                 var _a;
                 (_a = this.element.parentElement) === null || _a === void 0 ? void 0 : _a.removeChild(this.element);
             }), this.gridview.onDidChange(() => {
@@ -5744,8 +5744,7 @@
         }
     }
 
-    // TODO find a better way to initialize and avoid needing null checks
-    const NOT_INITIALIZED_MESSAGE = 'DockviewGroupPanelApiImpl not initialized';
+    const NOT_INITIALIZED_MESSAGE = 'dockview: DockviewGroupPanelApiImpl not initialized';
     class DockviewGroupPanelApiImpl extends GridviewPanelApiImpl {
         get location() {
             if (!this._group) {
@@ -5818,14 +5817,14 @@
             }
         }
         initialize(group) {
-            this._group = group;
             /**
-             * TODO: Annoying initialization order caveat
+             * TODO: Annoying initialization order caveat, find a better way to initialize and avoid needing null checks
              *
              * Due to the order on initialization we know that the model isn't defined until later in the same stack-frame of setup.
              * By queuing a microtask we can ensure the setup is completed within the same stack-frame, but after everything else has
              * finished ensuring the `model` is defined.
              */
+            this._group = group;
             queueMicrotask(() => {
                 this._mutableDisposable.value =
                     this._group.model.onDidActivePanelChange((event) => {
@@ -5979,12 +5978,10 @@
             var _a;
             let _trackGroupActive = (_a = previousGroup === null || previousGroup === void 0 ? void 0 : previousGroup.isActive) !== null && _a !== void 0 ? _a : false; // prevent duplicate events with same state
             this.groupEventsDisposable.value = new CompositeDisposable(this.group.api.onDidVisibilityChange((event) => {
-                if (!event.isVisible && this.isVisible) {
-                    this._onDidVisibilityChange.fire(event);
-                }
-                else if (event.isVisible &&
-                    !this.isVisible &&
-                    this.group.model.isPanelActive(this.panel)) {
+                const hasBecomeHidden = !event.isVisible && this.isVisible;
+                const hasBecomeVisible = event.isVisible && !this.isVisible;
+                const isActivePanel = this.group.model.isPanelActive(this.panel);
+                if (hasBecomeHidden || (hasBecomeVisible && isActivePanel)) {
                     this._onDidVisibilityChange.fire(event);
                 }
             }), this.group.api.onDidLocationChange((event) => {
@@ -6070,12 +6067,6 @@
             const didTitleChange = title !== this.title;
             if (didTitleChange) {
                 this._title = title;
-                this.view.update({
-                    params: {
-                        params: this._params,
-                        title: this.title,
-                    },
-                });
                 this.api._onDidTitleChange.fire({ title });
             }
         }
@@ -6103,10 +6094,7 @@
             }
             // update the view with the updated props
             this.view.update({
-                params: {
-                    params: this._params,
-                    title: this.title,
-                },
+                params: this._params,
             });
         }
         updateParentGroup(group, options) {
@@ -6719,7 +6707,7 @@
             this.element = element;
             this.map = {};
             this._disposed = false;
-            this.addDisposables(Disposable.from(() => {
+            this.addDisposables(exports.DockviewDisposable.from(() => {
                 for (const value of Object.values(this.map)) {
                     value.disposable.dispose();
                     value.destroy.dispose();
@@ -6744,8 +6732,8 @@
                 element.className = 'dv-render-overlay';
                 this.map[panel.api.id] = {
                     panel,
-                    disposable: Disposable.NONE,
-                    destroy: Disposable.NONE,
+                    disposable: exports.DockviewDisposable.NONE,
+                    destroy: exports.DockviewDisposable.NONE,
                     element,
                 };
             }
@@ -6809,7 +6797,7 @@
                 }
                 resize();
             }));
-            this.map[panel.api.id].destroy = Disposable.from(() => {
+            this.map[panel.api.id].destroy = exports.DockviewDisposable.from(() => {
                 var _a;
                 if (panel.view.content.element.parentElement === focusContainer) {
                     focusContainer.removeChild(panel.view.content.element);
@@ -7106,7 +7094,7 @@
                 this.updateWatermark();
             }), exports.DockviewEvent.any(this.onDidAddPanel, this.onDidRemovePanel, this.onDidActivePanelChange)(() => {
                 this._bufferOnDidLayoutChange.fire();
-            }), Disposable.from(() => {
+            }), exports.DockviewDisposable.from(() => {
                 // iterate over a copy of the array since .dispose() mutates the original array
                 for (const group of [...this._floatingGroups]) {
                     group.dispose();
@@ -7221,7 +7209,7 @@
                 return element.getBoundingClientRect();
             }
             const box = getBox();
-            const groupId = (_b = (_a = options === null || options === void 0 ? void 0 : options.overridePopoutGroup) === null || _a === void 0 ? void 0 : _a.id) !== null && _b !== void 0 ? _b : this.getNextGroupId(); //item.id;
+            const groupId = (_b = (_a = options === null || options === void 0 ? void 0 : options.overridePopoutGroup) === null || _a === void 0 ? void 0 : _a.id) !== null && _b !== void 0 ? _b : this.getNextGroupId();
             if (itemToPopout.api.location.type === 'grid') {
                 itemToPopout.api.setVisible(false);
             }
@@ -7322,7 +7310,7 @@
                  */
                 addDisposableWindowListener(_window.window, 'resize', () => {
                     group.layout(window.innerWidth, window.innerHeight);
-                }), overlayRenderContainer, Disposable.from(() => {
+                }), overlayRenderContainer, exports.DockviewDisposable.from(() => {
                     if (this.getPanel(referenceGroup.id)) {
                         this.movingLock(() => moveGroupWithoutDestroying({
                             from: group,
@@ -7337,24 +7325,22 @@
                             });
                         }
                     }
-                    else {
-                        if (this.getPanel(group.id)) {
-                            const removedGroup = this.doRemoveGroup(group, {
-                                skipDispose: true,
-                                skipActive: true,
-                            });
-                            removedGroup.model.renderContainer =
-                                this.overlayRenderContainer;
-                            removedGroup.model.location = { type: 'grid' };
-                            returnedGroup = removedGroup;
-                        }
+                    else if (this.getPanel(group.id)) {
+                        const removedGroup = this.doRemoveGroup(group, {
+                            skipDispose: true,
+                            skipActive: true,
+                        });
+                        removedGroup.model.renderContainer =
+                            this.overlayRenderContainer;
+                        removedGroup.model.location = { type: 'grid' };
+                        returnedGroup = removedGroup;
                     }
                 }));
                 this._popoutGroups.push(value);
                 this.updateWatermark();
             })
                 .catch((err) => {
-                console.error(err);
+                console.error('dockview: failed to create popout window', err);
             });
         }
         addFloatingGroup(item, coord, options) {
@@ -7397,7 +7383,7 @@
                         this.doRemoveGroup(item, {
                             skipDispose: true,
                             skipPopoutReturn: true,
-                            skipPopoutAssociated: !!popoutReferenceGroup,
+                            skipPopoutAssociated: false,
                         });
                     }
                 }
@@ -7757,7 +7743,6 @@
         clear() {
             const groups = Array.from(this._groups.values()).map((_) => _.value);
             const hasActiveGroup = !!this.activeGroup;
-            !!this.activePanel;
             for (const group of groups) {
                 // remove the group will automatically remove the panels
                 this.removeGroup(group, { skipActive: true });
@@ -8263,7 +8248,7 @@
             }
             let id = options === null || options === void 0 ? void 0 : options.id;
             if (id && this._groups.has(options.id)) {
-                console.warn(`Duplicate group id ${options === null || options === void 0 ? void 0 : options.id}. reassigning group id to avoid errors`);
+                console.warn(`dockview: Duplicate group id ${options === null || options === void 0 ? void 0 : options.id}. reassigning group id to avoid errors`);
                 id = undefined;
             }
             if (!id) {
@@ -9430,15 +9415,13 @@
         const addPortal = React.useCallback((portal) => {
             setPortals((existingPortals) => [...existingPortals, portal]);
             let disposed = false;
-            return {
-                dispose: () => {
-                    if (disposed) {
-                        throw new Error('invalid operation: resource already disposed');
-                    }
-                    disposed = true;
-                    setPortals((existingPortals) => existingPortals.filter((p) => p !== portal));
-                },
-            };
+            return exports.DockviewDisposable.from(() => {
+                if (disposed) {
+                    throw new Error('invalid operation: resource already disposed');
+                }
+                disposed = true;
+                setPortals((existingPortals) => existingPortals.filter((p) => p !== portal));
+            });
         }, []);
         return [portals, addPortal];
     };
@@ -9480,7 +9463,7 @@
         }
         update(event) {
             var _a;
-            (_a = this.part) === null || _a === void 0 ? void 0 : _a.update(event.params);
+            (_a = this.part) === null || _a === void 0 ? void 0 : _a.update({ params: event.params });
         }
         layout(_width, _height) {
             // noop
@@ -9518,7 +9501,7 @@
         }
         update(event) {
             var _a;
-            (_a = this.part) === null || _a === void 0 ? void 0 : _a.update(event.params);
+            (_a = this.part) === null || _a === void 0 ? void 0 : _a.update({ params: event.params });
         }
         layout(_width, _height) {
             // noop - retrieval from api