dockview 1.13.1 → 1.14.0

package/dist/dockview.esm.js

@@ -1,6 +1,6 @@
 /**
  * dockview
- * @version 1.13.1
+ * @version 1.14.0
  * @link https://github.com/mathuo/dockview
  * @license MIT
  */
@@ -156,7 +156,7 @@ class Stacktrace {
         this.value = value;
     }
     print() {
-        console.warn(this.value);
+        console.warn('dockview: stacktrace', this.value);
     }
 }
 class Listener {
@@ -221,7 +221,7 @@ class Emitter {
                         var _a;
                         // don't check until stack of execution is completed to allow for out-of-order disposals within the same execution block
                         for (const listener of this._listeners) {
-                            console.warn((_a = listener.stacktrace) === null || _a === void 0 ? void 0 : _a.print());
+                            console.warn('dockview: stacktrace', (_a = listener.stacktrace) === null || _a === void 0 ? void 0 : _a.print());
                         }
                     });
                 }
@@ -5771,8 +5771,7 @@ class GridviewPanel extends BasePanelView {
     }
 }
 
-// TODO find a better way to initialize and avoid needing null checks
-const NOT_INITIALIZED_MESSAGE = 'DockviewGroupPanelApiImpl not initialized';
+const NOT_INITIALIZED_MESSAGE = 'dockview: DockviewGroupPanelApiImpl not initialized';
 class DockviewGroupPanelApiImpl extends GridviewPanelApiImpl {
     get location() {
         if (!this._group) {
@@ -5845,14 +5844,14 @@ class DockviewGroupPanelApiImpl extends GridviewPanelApiImpl {
         }
     }
     initialize(group) {
-        this._group = group;
         /**
-         * TODO: Annoying initialization order caveat
+         * TODO: Annoying initialization order caveat, find a better way to initialize and avoid needing null checks
          *
          * Due to the order on initialization we know that the model isn't defined until later in the same stack-frame of setup.
          * By queuing a microtask we can ensure the setup is completed within the same stack-frame, but after everything else has
          * finished ensuring the `model` is defined.
          */
+        this._group = group;
         queueMicrotask(() => {
             this._mutableDisposable.value =
                 this._group.model.onDidActivePanelChange((event) => {
@@ -6006,12 +6005,10 @@ class DockviewPanelApiImpl extends GridviewPanelApiImpl {
         var _a;
         let _trackGroupActive = (_a = previousGroup === null || previousGroup === void 0 ? void 0 : previousGroup.isActive) !== null && _a !== void 0 ? _a : false; // prevent duplicate events with same state
         this.groupEventsDisposable.value = new CompositeDisposable(this.group.api.onDidVisibilityChange((event) => {
-            if (!event.isVisible && this.isVisible) {
-                this._onDidVisibilityChange.fire(event);
-            }
-            else if (event.isVisible &&
-                !this.isVisible &&
-                this.group.model.isPanelActive(this.panel)) {
+            const hasBecomeHidden = !event.isVisible && this.isVisible;
+            const hasBecomeVisible = event.isVisible && !this.isVisible;
+            const isActivePanel = this.group.model.isPanelActive(this.panel);
+            if (hasBecomeHidden || (hasBecomeVisible && isActivePanel)) {
                 this._onDidVisibilityChange.fire(event);
             }
         }), this.group.api.onDidLocationChange((event) => {
@@ -6097,12 +6094,6 @@ class DockviewPanel extends CompositeDisposable {
         const didTitleChange = title !== this.title;
         if (didTitleChange) {
             this._title = title;
-            this.view.update({
-                params: {
-                    params: this._params,
-                    title: this.title,
-                },
-            });
             this.api._onDidTitleChange.fire({ title });
         }
     }
@@ -6130,10 +6121,7 @@ class DockviewPanel extends CompositeDisposable {
         }
         // update the view with the updated props
         this.view.update({
-            params: {
-                params: this._params,
-                title: this.title,
-            },
+            params: this._params,
         });
     }
     updateParentGroup(group, options) {
@@ -7248,7 +7236,7 @@ class DockviewComponent extends BaseGrid {
             return element.getBoundingClientRect();
         }
         const box = getBox();
-        const groupId = (_b = (_a = options === null || options === void 0 ? void 0 : options.overridePopoutGroup) === null || _a === void 0 ? void 0 : _a.id) !== null && _b !== void 0 ? _b : this.getNextGroupId(); //item.id;
+        const groupId = (_b = (_a = options === null || options === void 0 ? void 0 : options.overridePopoutGroup) === null || _a === void 0 ? void 0 : _a.id) !== null && _b !== void 0 ? _b : this.getNextGroupId();
         if (itemToPopout.api.location.type === 'grid') {
             itemToPopout.api.setVisible(false);
         }
@@ -7364,24 +7352,22 @@ class DockviewComponent extends BaseGrid {
                         });
                     }
                 }
-                else {
-                    if (this.getPanel(group.id)) {
-                        const removedGroup = this.doRemoveGroup(group, {
-                            skipDispose: true,
-                            skipActive: true,
-                        });
-                        removedGroup.model.renderContainer =
-                            this.overlayRenderContainer;
-                        removedGroup.model.location = { type: 'grid' };
-                        returnedGroup = removedGroup;
-                    }
+                else if (this.getPanel(group.id)) {
+                    const removedGroup = this.doRemoveGroup(group, {
+                        skipDispose: true,
+                        skipActive: true,
+                    });
+                    removedGroup.model.renderContainer =
+                        this.overlayRenderContainer;
+                    removedGroup.model.location = { type: 'grid' };
+                    returnedGroup = removedGroup;
                 }
             }));
             this._popoutGroups.push(value);
             this.updateWatermark();
         })
             .catch((err) => {
-            console.error(err);
+            console.error('dockview: failed to create popout window', err);
         });
     }
     addFloatingGroup(item, coord, options) {
@@ -7424,7 +7410,7 @@ class DockviewComponent extends BaseGrid {
                     this.doRemoveGroup(item, {
                         skipDispose: true,
                         skipPopoutReturn: true,
-                        skipPopoutAssociated: !!popoutReferenceGroup,
+                        skipPopoutAssociated: false,
                     });
                 }
             }
@@ -7784,7 +7770,6 @@ class DockviewComponent extends BaseGrid {
     clear() {
         const groups = Array.from(this._groups.values()).map((_) => _.value);
         const hasActiveGroup = !!this.activeGroup;
-        !!this.activePanel;
         for (const group of groups) {
             // remove the group will automatically remove the panels
             this.removeGroup(group, { skipActive: true });
@@ -8290,7 +8275,7 @@ class DockviewComponent extends BaseGrid {
         }
         let id = options === null || options === void 0 ? void 0 : options.id;
         if (id && this._groups.has(options.id)) {
-            console.warn(`Duplicate group id ${options === null || options === void 0 ? void 0 : options.id}. reassigning group id to avoid errors`);
+            console.warn(`dockview: Duplicate group id ${options === null || options === void 0 ? void 0 : options.id}. reassigning group id to avoid errors`);
             id = undefined;
         }
         if (!id) {
@@ -9507,7 +9492,7 @@ class ReactPanelContentPart {
     }
     update(event) {
         var _a;
-        (_a = this.part) === null || _a === void 0 ? void 0 : _a.update(event.params);
+        (_a = this.part) === null || _a === void 0 ? void 0 : _a.update({ params: event.params });
     }
     layout(_width, _height) {
         // noop
@@ -9545,7 +9530,7 @@ class ReactPanelHeaderPart {
     }
     update(event) {
         var _a;
-        (_a = this.part) === null || _a === void 0 ? void 0 : _a.update(event.params);
+        (_a = this.part) === null || _a === void 0 ? void 0 : _a.update({ params: event.params });
     }
     layout(_width, _height) {
         // noop - retrieval from api