dockview 1.0.3 → 1.3.0

package/dist/esm/gridview/baseComponentGridview.js

@@ -1,22 +1,9 @@
-import { Emitter, TickDelayedEvent } from '../events';
+import { Emitter, Event, TickDelayedEvent } from '../events';
 import { getGridLocation, Gridview } from './gridview';
 import { Position } from '../dnd/droptarget';
 import { CompositeDisposable } from '../lifecycle';
 import { sequentialNumberGenerator } from '../math';
 import { Sizing, } from '../splitview/core/splitview';
-export var GroupChangeKind;
-(function (GroupChangeKind) {
-    GroupChangeKind["ADD_PANEL"] = "ADD_PANEL";
-    GroupChangeKind["REMOVE_PANEL"] = "REMOVE_PANEL";
-    GroupChangeKind["PANEL_ACTIVE"] = "PANEL_ACTIVE";
-    //
-    GroupChangeKind["GROUP_ACTIVE"] = "GROUP_ACTIVE";
-    GroupChangeKind["ADD_GROUP"] = "ADD_GROUP";
-    GroupChangeKind["REMOVE_GROUP"] = "REMOVE_GROUP";
-    //
-    GroupChangeKind["LAYOUT_FROM_JSON"] = "LAYOUT_FROM_JSON";
-    GroupChangeKind["LAYOUT"] = "LAYOUT";
-})(GroupChangeKind || (GroupChangeKind = {}));
 const nextLayoutId = sequentialNumberGenerator();
 export function toTarget(direction) {
     switch (direction) {
@@ -39,36 +26,26 @@ export class BaseGrid extends CompositeDisposable {
         this._element = _element;
         this._id = nextLayoutId.next();
         this._groups = new Map();
-        //
-        this._onGridEvent = new Emitter();
-        this.onGridEvent = this._onGridEvent.event;
         this._onDidLayoutChange = new Emitter();
         this.onDidLayoutChange = this._onDidLayoutChange.event;
+        this._onDidRemoveGroup = new Emitter();
+        this.onDidRemoveGroup = this._onDidRemoveGroup.event;
+        this._onDidAddGroup = new Emitter();
+        this.onDidAddGroup = this._onDidAddGroup.event;
+        this._onDidActiveGroupChange = new Emitter();
+        this.onDidActiveGroupChange = this._onDidActiveGroupChange.event;
+        this._bufferOnDidLayoutChange = new TickDelayedEvent();
         this.gridview = new Gridview(!!options.proportionalLayout, options.styles, options.orientation);
         this.element.appendChild(this.gridview.element);
-        // TODO for some reason this is required before anything will layout correctly
-        this.layout(0, 0, true);
+        this.layout(0, 0, true); // set some elements height/widths
         this.addDisposables(this.gridview.onDidChange(() => {
-            this._onGridEvent.fire({ kind: GroupChangeKind.LAYOUT });
+            this._onDidLayoutChange.fire();
         }));
-        this.addDisposables((() => {
-            const tickDelayedEvent = new TickDelayedEvent();
-            return new CompositeDisposable(this.onGridEvent((event) => {
-                if ([
-                    GroupChangeKind.ADD_GROUP,
-                    GroupChangeKind.REMOVE_GROUP,
-                    GroupChangeKind.ADD_PANEL,
-                    GroupChangeKind.REMOVE_PANEL,
-                    GroupChangeKind.GROUP_ACTIVE,
-                    GroupChangeKind.PANEL_ACTIVE,
-                    GroupChangeKind.LAYOUT,
-                ].includes(event.kind)) {
-                    tickDelayedEvent.fire();
-                }
-            }), tickDelayedEvent.onEvent(() => {
-                this._onDidLayoutChange.fire();
-            }), tickDelayedEvent);
-        })());
+        this.addDisposables(Event.any(this.onDidAddGroup, this.onDidRemoveGroup, this.onDidActiveGroupChange)(() => {
+            this._bufferOnDidLayoutChange.fire();
+        }), this._bufferOnDidLayoutChange.onEvent(() => {
+            this._onDidLayoutChange.fire();
+        }), this._bufferOnDidLayoutChange);
     }
     get id() {
         return this._id;
@@ -105,14 +82,14 @@ export class BaseGrid extends CompositeDisposable {
     }
     setVisible(panel, visible) {
         this.gridview.setViewVisible(getGridLocation(panel.element), visible);
-        this._onGridEvent.fire({ kind: GroupChangeKind.LAYOUT });
+        this._onDidLayoutChange.fire();
     }
     isVisible(panel) {
         return this.gridview.isViewVisible(getGridLocation(panel.element));
     }
     doAddGroup(group, location = [0], size) {
         this.gridview.addView(group, size !== null && size !== void 0 ? size : Sizing.Distribute, location);
-        this._onGridEvent.fire({ kind: GroupChangeKind.ADD_GROUP });
+        this._onDidAddGroup.fire(group);
         this.doSetGroupActive(group);
     }
     doRemoveGroup(group, options) {
@@ -123,9 +100,10 @@ export class BaseGrid extends CompositeDisposable {
         const view = this.gridview.remove(group, Sizing.Distribute);
         if (item && !(options === null || options === void 0 ? void 0 : options.skipDispose)) {
             item.disposable.dispose();
+            item.value.dispose();
             this._groups.delete(group.id);
         }
-        this._onGridEvent.fire({ kind: GroupChangeKind.REMOVE_GROUP });
+        this._onDidRemoveGroup.fire(group);
         if (!(options === null || options === void 0 ? void 0 : options.skipActive) && this._activeGroup === group) {
             const groups = Array.from(this._groups.values());
             this.doSetGroupActive(groups.length > 0 ? groups[0].value : undefined);
@@ -153,9 +131,7 @@ export class BaseGrid extends CompositeDisposable {
             }
         }
         this._activeGroup = group;
-        this._onGridEvent.fire({
-            kind: GroupChangeKind.GROUP_ACTIVE,
-        });
+        this._onDidActiveGroupChange.fire(group);
     }
     removeGroup(group) {
         this.doRemoveGroup(group);
@@ -211,7 +187,13 @@ export class BaseGrid extends CompositeDisposable {
     }
     dispose() {
         super.dispose();
-        this._onGridEvent.dispose();
+        this._onDidActiveGroupChange.dispose();
+        this._onDidAddGroup.dispose();
+        this._onDidRemoveGroup.dispose();
+        this._onDidLayoutChange.dispose();
+        for (const group of this.groups) {
+            group.dispose();
+        }
         this.gridview.dispose();
     }
 }

package/dist/esm/gridview/basePanelView.d.ts

@@ -4,21 +4,17 @@ import { PanelApiImpl } from '../api/panelApi';
 export interface BasePanelViewState {
     id: string;
     component: string;
-    params?: {
-        [key: string]: any;
-    };
-    state?: {
-        [key: string]: any;
-    };
+    params?: Record<string, any>;
 }
 export interface BasePanelViewExported<T extends PanelApiImpl> {
     readonly id: string;
     readonly api: T;
     readonly width: number;
     readonly height: number;
+    readonly params: Record<string, any> | undefined;
     focus(): void;
     toJSON(): object;
-    update(params: PanelUpdateEvent): void;
+    update(event: PanelUpdateEvent): void;
 }
 export declare abstract class BasePanelView<T extends PanelApiImpl> extends CompositeDisposable implements IPanel, BasePanelViewExported<T> {
     readonly id: string;
@@ -28,7 +24,7 @@ export declare abstract class BasePanelView<T extends PanelApiImpl> extends Comp
     private _width;
     private _element;
     protected part?: IFrameworkPart;
-    protected params?: PanelInitParameters;
+    protected _params?: PanelInitParameters;
     /**
      * Provide an IFrameworkPart that will determine the rendered UI of this view piece.
      */
@@ -36,6 +32,7 @@ export declare abstract class BasePanelView<T extends PanelApiImpl> extends Comp
     get element(): HTMLElement;
     get width(): number;
     get height(): number;
+    get params(): Record<string, any> | undefined;
     constructor(id: string, component: string, api: T);
     focus(): void;
     layout(width: number, height: number): void;

package/dist/esm/gridview/basePanelView.js

@@ -30,6 +30,10 @@ export class BasePanelView extends CompositeDisposable {
     get height() {
         return this._height;
     }
+    get params() {
+        var _a;
+        return (_a = this._params) === null || _a === void 0 ? void 0 : _a.params;
+    }
     focus() {
         this.api._onFocusEvent.fire();
     }
@@ -38,33 +42,33 @@ export class BasePanelView extends CompositeDisposable {
         this._height = height;
         this.api._onDidPanelDimensionChange.fire({ width, height });
         if (this.part) {
-            if (this.params) {
-                this.part.update(this.params.params);
+            if (this._params) {
+                this.part.update(this._params.params);
             }
         }
     }
     init(parameters) {
-        this.params = parameters;
+        this._params = parameters;
         this.part = this.getComponent();
     }
     update(event) {
         var _a, _b;
-        this.params = Object.assign(Object.assign({}, this.params), { params: Object.assign(Object.assign({}, (_a = this.params) === null || _a === void 0 ? void 0 : _a.params), event.params) });
-        (_b = this.part) === null || _b === void 0 ? void 0 : _b.update({ params: this.params.params });
+        this._params = Object.assign(Object.assign({}, this._params), { params: Object.assign(Object.assign({}, (_a = this._params) === null || _a === void 0 ? void 0 : _a.params), event.params) });
+        (_b = this.part) === null || _b === void 0 ? void 0 : _b.update({ params: this._params.params });
     }
     toJSON() {
         var _a, _b;
-        const state = this.api.getState();
-        const params = (_b = (_a = this.params) === null || _a === void 0 ? void 0 : _a.params) !== null && _b !== void 0 ? _b : {};
+        const params = (_b = (_a = this._params) === null || _a === void 0 ? void 0 : _a.params) !== null && _b !== void 0 ? _b : {};
         return {
             id: this.id,
             component: this.component,
             params: Object.keys(params).length > 0 ? params : undefined,
-            state: Object.keys(state).length === 0 ? undefined : state,
         };
     }
     dispose() {
+        var _a;
         super.dispose();
         this.api.dispose();
+        (_a = this.part) === null || _a === void 0 ? void 0 : _a.dispose();
     }
 }

package/dist/esm/gridview/branchNode.js

@@ -40,7 +40,7 @@ export class BranchNode extends CompositeDisposable {
                             : true,
                     };
                 }),
-                size: this.orthogonalSize,
+                size: this.size,
             };
             this.children = childDescriptors.map((c) => c.node);
             this.splitview = new Splitview(this.element, {
@@ -49,7 +49,7 @@ export class BranchNode extends CompositeDisposable {
                 proportionalLayout,
             });
         }
-        this.addDisposables(this.splitview.onDidSashEnd(() => {
+        this.addDisposables(this._onDidChange, this.splitview.onDidSashEnd(() => {
             this._onDidChange.fire(undefined);
         }));
         this.setupChildrenEvents();
@@ -201,7 +201,7 @@ export class BranchNode extends CompositeDisposable {
     }
     setupChildrenEvents() {
         this._childrenDisposable.dispose();
-        this._childrenDisposable = Event.any(...this.children.map((c) => c.onDidChange))((e) => {
+        this._childrenDisposable = Event.any(...this.children.map((c) => c.onDidChange))(() => {
             /**
              * indicate a change has occured to allows any re-rendering but don't bubble
              * event because that was specific to this branch

package/dist/esm/gridview/gridview.js

@@ -9,6 +9,15 @@ import { LeafNode } from './leafNode';
 import { BranchNode } from './branchNode';
 import { Emitter } from '../events';
 import { MutableDisposable } from '../lifecycle';
+function findLeaf(candiateNode, last) {
+    if (candiateNode instanceof LeafNode) {
+        return candiateNode;
+    }
+    if (candiateNode instanceof BranchNode) {
+        return findLeaf(candiateNode.children[last ? candiateNode.children.length - 1 : 0], last);
+    }
+    throw new Error('invalid node');
+}
 function flipNode(node, size, orthogonalSize) {
     if (node instanceof BranchNode) {
         const result = new BranchNode(orthogonal(node.orientation), node.proportionalLayout, node.styles, size, orthogonalSize);
@@ -140,6 +149,7 @@ export class Gridview {
         this.disposable.dispose();
         this._onDidChange.dispose();
         this.root.dispose();
+        this.element.remove();
     }
     clear() {
         const orientation = this.root.orientation;
@@ -147,13 +157,13 @@ export class Gridview {
     }
     deserialize(json, deserializer) {
         const orientation = json.orientation;
-        const height = json.height;
+        const height = orientation === Orientation.VERTICAL ? json.height : json.width;
         this._deserialize(json.root, orientation, deserializer, height);
     }
     _deserialize(root, orientation, deserializer, orthogonalSize) {
-        this.root = this._deserializeNode(root, orientation, deserializer, orthogonalSize);
+        this.root = this._deserializeNode(root, orientation, deserializer, orthogonalSize, true);
     }
-    _deserializeNode(node, orientation, deserializer, orthogonalSize) {
+    _deserializeNode(node, orientation, deserializer, orthogonalSize, isRoot = false) {
         let result;
         if (node.type === 'branch') {
             const serializedChildren = node.data;
@@ -163,7 +173,9 @@ export class Gridview {
                     visible: serializedChild.visible,
                 };
             });
-            result = new BranchNode(orientation, this.proportionalLayout, this.styles, node.size, orthogonalSize, children);
+            // HORIZONTAL => height=orthogonalsize width=size
+            // VERTICAL => height=size width=orthogonalsize
+            result = new BranchNode(orientation, this.proportionalLayout, this.styles, isRoot ? orthogonalSize : node.size, isRoot ? node.size : orthogonalSize, children);
         }
         else {
             result = new LeafNode(deserializer.fromJSON(node), orientation, orthogonalSize, node.size);
@@ -224,15 +236,6 @@ export class Gridview {
         if (!(node instanceof LeafNode)) {
             throw new Error('invalid location');
         }
-        const findLeaf = (candiateNode, last) => {
-            if (candiateNode instanceof LeafNode) {
-                return candiateNode;
-            }
-            if (candiateNode instanceof BranchNode) {
-                return findLeaf(candiateNode.children[last ? candiateNode.children.length - 1 : 0], last);
-            }
-            throw new Error('invalid node');
-        };
         for (let i = path.length - 1; i > -1; i--) {
             const n = path[i];
             const l = location[i] || 0;
@@ -334,9 +337,9 @@ export class Gridview {
         if (parent.children.length > 1) {
             return node.view;
         }
+        const sibling = parent.children[0];
         if (pathToParent.length === 0) {
             // parent is root
-            const sibling = parent.children[0];
             if (sibling instanceof LeafNode) {
                 return node.view;
             }
@@ -347,10 +350,9 @@ export class Gridview {
         }
         const [grandParent, ..._] = [...pathToParent].reverse();
         const [parentIndex, ...__] = [...rest].reverse();
-        const sibling = parent.children[0];
         const isSiblingVisible = parent.isChildVisible(0);
         parent.removeChild(0, sizing);
-        const sizes = grandParent.children.map((size, i) => grandParent.getChildSize(i));
+        const sizes = grandParent.children.map((_size, i) => grandParent.getChildSize(i));
         grandParent.removeChild(parentIndex, sizing);
         if (sibling instanceof BranchNode) {
             sizes.splice(parentIndex, 1, ...sibling.children.map((c) => c.size));

package/dist/esm/gridview/gridviewComponent.d.ts

@@ -5,11 +5,8 @@ import { GridviewComponentOptions } from './options';
 import { BaseGrid, Direction, IBaseGrid, IGridPanelView } from './baseComponentGridview';
 import { GridviewPanel, GridviewInitParameters, GridPanelViewState, IGridviewPanel } from './gridviewPanel';
 import { BaseComponentOptions } from '../panel/types';
-import { GridviewPanelApiImpl } from '../api/gridviewPanelApi';
 import { Orientation, Sizing } from '../splitview/core/splitview';
-interface PanelReference {
-    api: GridviewPanelApiImpl;
-}
+import { Event } from '../events';
 export interface SerializedGridview {
     grid: {
         height: number;
@@ -37,6 +34,7 @@ export interface IGridPanelComponentView extends IGridPanelView {
 export declare type GridviewComponentUpdateOptions = Pick<GridviewComponentOptions, 'orientation' | 'components' | 'frameworkComponents'>;
 export interface IGridviewComponent extends IBaseGrid<GridviewPanel> {
     readonly orientation: Orientation;
+    readonly onDidLayoutFromJSON: Event<void>;
     updateOptions(options: Partial<GridviewComponentUpdateOptions>): void;
     addPanel(options: AddComponentOptions): void;
     removePanel(panel: IGridviewPanel, sizing?: Sizing): void;
@@ -55,6 +53,8 @@ export interface IGridviewComponent extends IBaseGrid<GridviewPanel> {
 export declare class GridviewComponent extends BaseGrid<GridviewPanel> implements IGridviewComponent {
     private _options;
     private _deserializer;
+    private readonly _onDidLayoutfromJSON;
+    readonly onDidLayoutFromJSON: Event<void>;
     get orientation(): Orientation;
     set orientation(value: Orientation);
     get options(): GridviewComponentOptions;
@@ -79,10 +79,9 @@ export declare class GridviewComponent extends BaseGrid<GridviewPanel> implement
         reference: string;
         size?: number;
     }): void;
-    addPanel(options: AddComponentOptions): PanelReference;
+    addPanel(options: AddComponentOptions): void;
     private registerPanel;
     moveGroup(referenceGroup: IGridPanelComponentView, groupId: string, target: Position): void;
     removeGroup(group: GridviewPanel): void;
     dispose(): void;
 }
-export {};

package/dist/esm/gridview/gridviewComponent.js

@@ -2,9 +2,10 @@ import { getRelativeLocation, getGridLocation, } from './gridview';
 import { Position } from '../dnd/droptarget';
 import { tail, sequenceEquals } from '../array';
 import { CompositeDisposable } from '../lifecycle';
-import { BaseGrid, GroupChangeKind, toTarget, } from './baseComponentGridview';
+import { BaseGrid, toTarget, } from './baseComponentGridview';
 import { GridviewApi } from '../api/component.api';
 import { createComponent } from '../panel/componentFactory';
+import { Emitter } from '../events';
 export class GridviewComponent extends BaseGrid {
     constructor(element, options) {
         super(element, {
@@ -12,6 +13,8 @@ export class GridviewComponent extends BaseGrid {
             orientation: options.orientation,
             styles: options.styles,
         });
+        this._onDidLayoutfromJSON = new Emitter();
+        this.onDidLayoutFromJSON = this._onDidLayoutfromJSON.event;
         this._options = options;
         if (!this.options.components) {
             this.options.components = {};
@@ -64,7 +67,7 @@ export class GridviewComponent extends BaseGrid {
         this.gridview.setViewVisible(getGridLocation(panel.element), visible);
     }
     setActive(panel) {
-        this._groups.forEach((value, key) => {
+        this._groups.forEach((value, _key) => {
             value.value.setActive(panel === value.value);
         });
     }
@@ -77,8 +80,12 @@ export class GridviewComponent extends BaseGrid {
     }
     fromJSON(serializedGridview, deferComponentLayout) {
         const { grid, activePanel } = serializedGridview;
+        const groups = Array.from(this._groups.values()); // reassign since group panels will mutate
+        for (const group of groups) {
+            group.disposable.dispose();
+            this.doRemoveGroup(group.value, { skipActive: true });
+        }
         this.gridview.clear();
-        this._groups.clear();
         const queue = [];
         this.gridview.deserialize(grid, {
             fromJSON: (node) => {
@@ -119,7 +126,7 @@ export class GridviewComponent extends BaseGrid {
                 this.doSetGroupActive(panel);
             }
         }
-        this._onGridEvent.fire({ kind: GroupChangeKind.LAYOUT_FROM_JSON });
+        this._onDidLayoutfromJSON.fire();
     }
     movePanel(panel, options) {
         var _a;
@@ -175,7 +182,6 @@ export class GridviewComponent extends BaseGrid {
         });
         this.registerPanel(view);
         this.doAddGroup(view, relativeLocation, options.size);
-        return { api: view.api };
     }
     registerPanel(panel) {
         const disposable = new CompositeDisposable(panel.api.onDidFocusChange((event) => {
@@ -226,13 +232,9 @@ export class GridviewComponent extends BaseGrid {
     }
     removeGroup(group) {
         super.removeGroup(group);
-        const panel = this._groups.get(group.id);
-        if (panel) {
-            panel.disposable.dispose();
-            this._groups.delete(group.id);
-        }
     }
     dispose() {
         super.dispose();
+        this._onDidLayoutfromJSON.dispose();
     }
 }

package/dist/esm/gridview/gridviewPanel.d.ts

@@ -50,7 +50,6 @@ export declare abstract class GridviewPanel extends BasePanelView<GridviewPanelA
     init(parameters: GridviewInitParameters): void;
     private updateConstraints;
     toJSON(): GridPanelViewState;
-    dispose(): void;
 }
 export interface GridPanelViewState extends BasePanelViewState {
     minimumHeight?: number;

package/dist/esm/gridview/gridviewPanel.js

@@ -15,12 +15,12 @@ export class GridviewPanel extends BasePanelView {
         this._snap = false;
         this._onDidChange = new Emitter();
         this.onDidChange = this._onDidChange.event;
-        this.addDisposables(this.api.onVisibilityChange((event) => {
+        this.addDisposables(this._onDidChange, this.api.onVisibilityChange((event) => {
             const { isVisible } = event;
-            const { containerApi } = this.params;
+            const { containerApi } = this._params;
             containerApi.setVisible(this, isVisible);
         }), this.api.onActiveChange(() => {
-            const { containerApi } = this.params;
+            const { containerApi } = this._params;
             containerApi.setActive(this);
         }), this.api.onDidConstraintsChangeInternal((event) => {
             if (typeof event.minimumWidth === 'number' ||
@@ -135,7 +135,4 @@ export class GridviewPanel extends BasePanelView {
         const minimum = (value) => (value <= 0 ? undefined : value);
         return Object.assign(Object.assign({}, state), { minimumHeight: minimum(this.minimumHeight), maximumHeight: maximum(this.maximumHeight), minimumWidth: minimum(this.minimumWidth), maximumWidth: maximum(this.maximumWidth), snap: this.snap, priority: this.priority });
     }
-    dispose() {
-        super.dispose();
-    }
 }

package/dist/esm/gridview/leafNode.js

@@ -92,6 +92,7 @@ export class LeafNode {
         this.view.layout(this.width, this.height);
     }
     dispose() {
+        this._onDidChange.dispose();
         this._disposable.dispose();
     }
 }

package/dist/esm/groupview/groupPanel.d.ts

@@ -1,5 +1,4 @@
 import { DockviewPanelApi } from '../api/groupPanelApi';
-import { Event } from '../events';
 import { IDisposable } from '../lifecycle';
 import { HeaderPartInitParameters } from './types';
 import { IPanel, PanelInitParameters, PanelUpdateEvent, Parameters } from '../panel/types';
@@ -19,11 +18,9 @@ export interface IGroupPanel extends IDisposable, IPanel {
     readonly api: DockviewPanelApi;
     readonly title: string;
     readonly suppressClosable: boolean;
+    readonly params: Record<string, any> | undefined;
     updateParentGroup(group: GroupviewPanel, isGroupActive: boolean): void;
-    setDirty(isDirty: boolean): void;
-    close?(): Promise<boolean>;
     init(params: IGroupPanelInitParameters): void;
-    onDidStateChange: Event<void>;
     toJSON(): GroupviewPanelState;
     update(event: GroupPanelUpdateEvent): void;
 }
@@ -35,7 +32,4 @@ export interface GroupviewPanelState {
         [key: string]: any;
     };
     suppressClosable?: boolean;
-    state?: {
-        [key: string]: any;
-    };
 }

package/dist/esm/groupview/groupview.d.ts

@@ -11,8 +11,7 @@ import { DockviewDropTargets } from './dnd';
 export declare enum GroupChangeKind2 {
     ADD_PANEL = "ADD_PANEL",
     REMOVE_PANEL = "REMOVE_PANEL",
-    PANEL_ACTIVE = "PANEL_ACTIVE",
-    GROUP_ACTIVE = "GROUP_ACTIVE"
+    PANEL_ACTIVE = "PANEL_ACTIVE"
 }
 export interface DndService {
     canDisplayOverlay(group: IGroupview, event: DragEvent, target: DockviewDropTargets): boolean;
@@ -48,20 +47,26 @@ export interface GroupPanelViewState {
     activeView?: string;
     id: string;
 }
+export interface GroupviewDropEvent {
+    nativeEvent: DragEvent;
+    position: Position;
+    index?: number;
+}
 export interface IGroupview extends IDisposable, IGridPanelView {
     readonly isActive: boolean;
     readonly size: number;
     readonly panels: IGroupPanel[];
     readonly tabHeight: number | undefined;
+    readonly activePanel: IGroupPanel | undefined;
+    readonly onDidDrop: Event<GroupviewDropEvent>;
     isPanelActive: (panel: IGroupPanel) => boolean;
-    activePanel: IGroupPanel | undefined;
     indexOf(panel: IGroupPanel): number;
     openPanel(panel: IGroupPanel, options?: {
         index?: number;
         skipFocus?: boolean;
     }): void;
-    closePanel(panel: IGroupPanel): Promise<boolean>;
-    closeAllPanels(): Promise<boolean>;
+    closePanel(panel: IGroupPanel): void;
+    closeAllPanels(): void;
     containsPanel(panel: IGroupPanel): boolean;
     removePanel: (panelOrId: IGroupPanel | string) => IGroupPanel;
     onDidGroupChange: Event<GroupviewChangeEvent>;
@@ -100,6 +105,8 @@ export declare class Groupview extends CompositeDisposable implements IGroupview
     readonly onMove: Event<GroupMoveEvent>;
     private readonly _onDidGroupChange;
     readonly onDidGroupChange: Event<GroupviewChangeEvent>;
+    private readonly _onDidDrop;
+    readonly onDidDrop: Event<GroupviewDropEvent>;
     get element(): HTMLElement;
     get activePanel(): IGroupPanel | undefined;
     get tabHeight(): number | undefined;
@@ -112,6 +119,7 @@ export declare class Groupview extends CompositeDisposable implements IGroupview
     get maximumHeight(): number;
     get minimumWidth(): number;
     get maximumWidth(): number;
+    get hasWatermark(): boolean;
     constructor(container: HTMLElement, accessor: IDockviewComponent, id: string, options: GroupOptions, parent: GroupviewPanel);
     initialize(): void;
     isContentFocused(): boolean;
@@ -126,16 +134,16 @@ export declare class Groupview extends CompositeDisposable implements IGroupview
         suppressRoll?: boolean;
     }): void;
     containsPanel(panel: IGroupPanel): boolean;
-    init(params: PanelInitParameters): void;
-    update(params: PanelUpdateEvent): void;
+    init(_params: PanelInitParameters): void;
+    update(_params: PanelUpdateEvent): void;
     focus(): void;
     openPanel(panel: IGroupPanel, options?: {
         index?: number;
         skipFocus?: boolean;
     }): void;
     removePanel(groupItemOrId: IGroupPanel | string): IGroupPanel;
-    closeAllPanels(): Promise<boolean>;
-    closePanel: (panel: IGroupPanel) => Promise<boolean>;
+    closeAllPanels(): void;
+    closePanel(panel: IGroupPanel): void;
     private doClose;
     isPanelActive(panel: IGroupPanel): boolean;
     updateActions(): void;
@@ -147,7 +155,7 @@ export declare class Groupview extends CompositeDisposable implements IGroupview
     private doSetActivePanel;
     private updateMru;
     private updateContainer;
-    canDisplayOverlay(dragOverEvent: DragEvent, target: DockviewDropTargets): boolean;
+    canDisplayOverlay(event: DragEvent, target: DockviewDropTargets): boolean;
     private handleDropEvent;
     dispose(): void;
 }