dockview-core 7.0.2 → 7.0.3

package/dist/cjs/dockview/dockviewComponent.js

@@ -128,9 +128,9 @@ var _hasWarnedUsingCoreDirectly = false;
  * `process` is undefined.
  */
 function warnIfUsingCoreDirectly() {
+    var _a;
     if (typeof process !== 'undefined' &&
-        process.env &&
-        process.env.NODE_ENV === 'production') {
+        ((_a = process.env) === null || _a === void 0 ? void 0 : _a.NODE_ENV) === 'production') {
         return;
     }
     if (_hasWarnedUsingCoreDirectly || (0, modules_1.isDockviewPackageLoaded)()) {
@@ -276,7 +276,7 @@ var DockviewComponent = /** @class */ (function (_super) {
         // The shell always wraps the dockview element so edge groups can be
         // added at any time via addEdgeGroup() without re-parenting the DOM.
         _this.disableResizing = true;
-        container.removeChild(_this.element);
+        _this.element.remove();
         _this._shellManager = new dockviewShell_1.ShellManager(container, _this.element, function (w, h) { return _this._layoutFromShell(w, h); }, (_e = (_d = options.theme) === null || _d === void 0 ? void 0 : _d.gap) !== null && _e !== void 0 ? _e : 0, (_f = options.theme) === null || _f === void 0 ? void 0 : _f.edgeGroupCollapsedSize);
         // The shell wraps the dockview element, so move the popup anchor
         // into the shell so overflow dropdowns in edge groups position correctly
@@ -856,15 +856,13 @@ var DockviewComponent = /** @class */ (function (_super) {
             .open()
             .then(function (popoutContainer) {
             var e_3, _a;
-            var _b, _c, _d;
+            var _b, _c, _d, _e;
             if (_window.isDisposed) {
                 return false;
             }
-            var referenceGroup = (options === null || options === void 0 ? void 0 : options.referenceGroup)
-                ? options.referenceGroup
-                : itemToPopout instanceof dockviewPanel_1.DockviewPanel
-                    ? itemToPopout.group
-                    : itemToPopout;
+            var referenceGroup = (_b = options === null || options === void 0 ? void 0 : options.referenceGroup) !== null && _b !== void 0 ? _b : (itemToPopout instanceof dockviewPanel_1.DockviewPanel
+                ? itemToPopout.group
+                : itemToPopout);
             var referenceLocation = itemToPopout.api.location.type;
             /**
              * The group that is being added doesn't already exist within the DOM, the most likely occurrence
@@ -875,7 +873,7 @@ var DockviewComponent = /** @class */ (function (_super) {
             if (options === null || options === void 0 ? void 0 : options.overridePopoutGridview) {
                 // Restoring a multi-group window: the anchor group is
                 // already built inside the supplied gridview.
-                group = (_b = options.overridePopoutGroup) !== null && _b !== void 0 ? _b : referenceGroup;
+                group = (_c = options.overridePopoutGroup) !== null && _c !== void 0 ? _c : referenceGroup;
             }
             else if (!isGroupAddedToDom) {
                 group = referenceGroup;
@@ -906,7 +904,7 @@ var DockviewComponent = /** @class */ (function (_super) {
             // a nested splitview layout. The window starts with the single
             // anchor group; further groups arrive via drag-and-drop. On
             // restore a pre-populated gridview is supplied instead.
-            var popoutGridview = (_c = options === null || options === void 0 ? void 0 : options.overridePopoutGridview) !== null && _c !== void 0 ? _c : _this.createNestedGridview();
+            var popoutGridview = (_d = options === null || options === void 0 ? void 0 : options.overridePopoutGridview) !== null && _d !== void 0 ? _d : _this.createNestedGridview();
             if (!(options === null || options === void 0 ? void 0 : options.overridePopoutGridview)) {
                 popoutGridview.addView(group, splitview_1.Sizing.Distribute, [0]);
             }
@@ -949,11 +947,11 @@ var DockviewComponent = /** @class */ (function (_super) {
                             break;
                         case 'floating':
                         case 'popout':
-                            floatingBox = (_d = _this.floatingGroups
+                            floatingBox = (_e = _this.floatingGroups
                                 .find(function (value) {
                                 return value.group.api.id ===
                                     itemToPopout.api.id;
-                            })) === null || _d === void 0 ? void 0 : _d.overlay.toJSON();
+                            })) === null || _e === void 0 ? void 0 : _e.overlay.toJSON();
                             _this.removeGroup(referenceGroup);
                             break;
                     }
@@ -1947,7 +1945,7 @@ var DockviewComponent = /** @class */ (function (_super) {
                 var e_16, _a;
                 var id = data.id, locked = data.locked, hideHeader = data.hideHeader, headerPosition = data.headerPosition, views = data.views, activeView = data.activeView;
                 if (typeof id !== 'string') {
-                    throw new Error('dockview: group id must be of type string');
+                    throw new TypeError('dockview: group id must be of type string');
                 }
                 var group = _this.createGroup({
                     id: id,
@@ -2133,8 +2131,8 @@ var DockviewComponent = /** @class */ (function (_super) {
         return { gridview: gridview, members: members };
     };
     DockviewComponent.prototype.deserializeEdgeGroups = function (edgeGroups, panels) {
-        var e_17, _a, e_18, _b, e_19, _c;
-        var _d;
+        var e_17, _a, e_18, _b, e_19, _c, e_20, _d;
+        var _e;
         var edgeService = (0, modules_1.assertModule)(this._edgeGroupService, 'EdgeGroup', 'fromJSON edge restoration');
         if (!edgeService) {
             return;
@@ -2143,17 +2141,17 @@ var DockviewComponent = /** @class */ (function (_super) {
             // Auto-create edge groups for positions in the serialized state that
             // don't already have a group registered (e.g. when fromJSON is called
             // before the user has called addEdgeGroup).
-            for (var _e = __values([
+            for (var _f = __values([
                 'top',
                 'bottom',
                 'left',
                 'right',
-            ]), _f = _e.next(); !_f.done; _f = _e.next()) {
-                var _position = _f.value;
+            ]), _g = _f.next(); !_g.done; _g = _f.next()) {
+                var _position = _g.value;
                 var fixedData = edgeGroups[_position];
                 if (fixedData && !edgeService.has(_position)) {
                     var groupState = fixedData.group;
-                    var id = (_d = groupState === null || groupState === void 0 ? void 0 : groupState.id) !== null && _d !== void 0 ? _d : "".concat(_position, "-group");
+                    var id = (_e = groupState === null || groupState === void 0 ? void 0 : groupState.id) !== null && _e !== void 0 ? _e : "".concat(_position, "-group");
                     this.addEdgeGroup(_position, { id: id });
                 }
             }
@@ -2161,14 +2159,14 @@ var DockviewComponent = /** @class */ (function (_super) {
         catch (e_17_1) { e_17 = { error: e_17_1 }; }
         finally {
             try {
-                if (_f && !_f.done && (_a = _e.return)) _a.call(_e);
+                if (_g && !_g.done && (_a = _f.return)) _a.call(_f);
             }
             finally { if (e_17) throw e_17.error; }
         }
         try {
             // Restore panel contents of edge groups
-            for (var _g = __values(edgeService.entries()), _h = _g.next(); !_h.done; _h = _g.next()) {
-                var _j = __read(_h.value, 2), position = _j[0], edgeGroup = _j[1];
+            for (var _h = __values(edgeService.entries()), _j = _h.next(); !_j.done; _j = _h.next()) {
+                var _k = __read(_j.value, 2), position = _k[0], edgeGroup = _k[1];
                 var edgeData = edgeGroups[position];
                 var groupState = edgeData === null || edgeData === void 0 ? void 0 : edgeData.group;
                 if (groupState) {
@@ -2190,13 +2188,22 @@ var DockviewComponent = /** @class */ (function (_super) {
                         }
                         finally { if (e_19) throw e_19.error; }
                     }
-                    for (var i = 0; i < createdPanels.length; i++) {
-                        var panel = createdPanels[i];
-                        var isActive = activeView === panel.id;
-                        edgeGroup.model.openPanel(panel, {
-                            skipSetActive: !isActive,
-                            skipSetGroupActive: true,
-                        });
+                    try {
+                        for (var createdPanels_1 = (e_20 = void 0, __values(createdPanels)), createdPanels_1_1 = createdPanels_1.next(); !createdPanels_1_1.done; createdPanels_1_1 = createdPanels_1.next()) {
+                            var panel = createdPanels_1_1.value;
+                            var isActive = activeView === panel.id;
+                            edgeGroup.model.openPanel(panel, {
+                                skipSetActive: !isActive,
+                                skipSetGroupActive: true,
+                            });
+                        }
+                    }
+                    catch (e_20_1) { e_20 = { error: e_20_1 }; }
+                    finally {
+                        try {
+                            if (createdPanels_1_1 && !createdPanels_1_1.done && (_d = createdPanels_1.return)) _d.call(createdPanels_1);
+                        }
+                        finally { if (e_20) throw e_20.error; }
                     }
                     // Restore tab groups before activating a fallback panel
                     if (groupState.tabGroups && groupState.tabGroups.length > 0) {
@@ -2211,14 +2218,14 @@ var DockviewComponent = /** @class */ (function (_super) {
         catch (e_18_1) { e_18 = { error: e_18_1 }; }
         finally {
             try {
-                if (_h && !_h.done && (_b = _g.return)) _b.call(_g);
+                if (_j && !_j.done && (_b = _h.return)) _b.call(_h);
             }
             finally { if (e_18) throw e_18.error; }
         }
         this._shellManager.fromJSON(edgeGroups);
     };
     DockviewComponent.prototype.deserializeFloatingWindows = function (serialized, createGroup) {
-        var e_20, _a;
+        var e_21, _a;
         try {
             for (var serialized_1 = __values(serialized), serialized_1_1 = serialized_1.next(); !serialized_1_1.done; serialized_1_1 = serialized_1.next()) {
                 var serializedFloatingGroup = serialized_1_1.value;
@@ -2244,12 +2251,12 @@ var DockviewComponent = /** @class */ (function (_super) {
                 }
             }
         }
-        catch (e_20_1) { e_20 = { error: e_20_1 }; }
+        catch (e_21_1) { e_21 = { error: e_21_1 }; }
         finally {
             try {
                 if (serialized_1_1 && !serialized_1_1.done && (_a = serialized_1.return)) _a.call(serialized_1);
             }
-            finally { if (e_20) throw e_20.error; }
+            finally { if (e_21) throw e_21.error; }
         }
     };
     DockviewComponent.prototype.deserializePopoutWindows = function (serialized, createGroup) {
@@ -2295,7 +2302,7 @@ var DockviewComponent = /** @class */ (function (_super) {
                     popoutUrl: url,
                 });
             }, function () {
-                var e_21, _a, e_22, _b;
+                var e_22, _a, e_23, _b;
                 try {
                     // The group was registered in _groups synchronously but the
                     // timer that would parent it into the popout window never
@@ -2309,19 +2316,19 @@ var DockviewComponent = /** @class */ (function (_super) {
                             _this._groups.has(orphan.id) &&
                             orphan.element.parentElement === null) {
                             try {
-                                for (var _e = (e_22 = void 0, __values(__spreadArray([], __read(orphan.panels), false))), _f = _e.next(); !_f.done; _f = _e.next()) {
+                                for (var _e = (e_23 = void 0, __values(__spreadArray([], __read(orphan.panels), false))), _f = _e.next(); !_f.done; _f = _e.next()) {
                                     var panel = _f.value;
                                     _this.removePanel(panel, {
                                         removeEmptyGroup: false,
                                     });
                                 }
                             }
-                            catch (e_22_1) { e_22 = { error: e_22_1 }; }
+                            catch (e_23_1) { e_23 = { error: e_23_1 }; }
                             finally {
                                 try {
                                     if (_f && !_f.done && (_b = _e.return)) _b.call(_e);
                                 }
-                                finally { if (e_22) throw e_22.error; }
+                                finally { if (e_23) throw e_23.error; }
                             }
                             orphan.dispose();
                             _this._groups.delete(orphan.id);
@@ -2329,12 +2336,12 @@ var DockviewComponent = /** @class */ (function (_super) {
                         }
                     }
                 }
-                catch (e_21_1) { e_21 = { error: e_21_1 }; }
+                catch (e_22_1) { e_22 = { error: e_22_1 }; }
                 finally {
                     try {
                         if (_d && !_d.done && (_a = _c.return)) _a.call(_c);
                     }
-                    finally { if (e_21) throw e_21.error; }
+                    finally { if (e_22) throw e_22.error; }
                 }
             });
         });
@@ -2344,7 +2351,7 @@ var DockviewComponent = /** @class */ (function (_super) {
         this.mutation('clear', function () { return _this._doClear(); });
     };
     DockviewComponent.prototype._doClear = function () {
-        var e_23, _a, e_24, _b;
+        var e_24, _a, e_25, _b;
         var _c;
         var groups = Array.from(this._groups.values()).map(function (_) { return _.value; });
         var hasActiveGroup = !!this.activeGroup;
@@ -2355,17 +2362,17 @@ var DockviewComponent = /** @class */ (function (_super) {
                     // Edge groups are structural - only clear their panels, not the group itself
                     var panels = __spreadArray([], __read(group.panels), false);
                     try {
-                        for (var panels_1 = (e_24 = void 0, __values(panels)), panels_1_1 = panels_1.next(); !panels_1_1.done; panels_1_1 = panels_1.next()) {
+                        for (var panels_1 = (e_25 = void 0, __values(panels)), panels_1_1 = panels_1.next(); !panels_1_1.done; panels_1_1 = panels_1.next()) {
                             var panel = panels_1_1.value;
                             this.removePanel(panel, { removeEmptyGroup: false });
                         }
                     }
-                    catch (e_24_1) { e_24 = { error: e_24_1 }; }
+                    catch (e_25_1) { e_25 = { error: e_25_1 }; }
                     finally {
                         try {
                             if (panels_1_1 && !panels_1_1.done && (_b = panels_1.return)) _b.call(panels_1);
                         }
-                        finally { if (e_24) throw e_24.error; }
+                        finally { if (e_25) throw e_25.error; }
                     }
                     continue;
                 }
@@ -2373,12 +2380,12 @@ var DockviewComponent = /** @class */ (function (_super) {
                 this.removeGroup(group, { skipActive: true });
             }
         }
-        catch (e_23_1) { e_23 = { error: e_23_1 }; }
+        catch (e_24_1) { e_24 = { error: e_24_1 }; }
         finally {
             try {
                 if (groups_1_1 && !groups_1_1.done && (_a = groups_1.return)) _a.call(groups_1);
             }
-            finally { if (e_23) throw e_23.error; }
+            finally { if (e_24) throw e_24.error; }
         }
         if (hasActiveGroup) {
             this.doSetGroupAndPanelActive(undefined);
@@ -2390,7 +2397,7 @@ var DockviewComponent = /** @class */ (function (_super) {
         // One transaction — the per-panel removals inside nest via the depth
         // counter, so consumers (undo, announcements) see a single mutation.
         this.mutation('remove', function () {
-            var e_25, _a;
+            var e_26, _a;
             try {
                 for (var _b = __values(_this._groups.entries()), _c = _b.next(); !_c.done; _c = _b.next()) {
                     var entry = _c.value;
@@ -2398,12 +2405,12 @@ var DockviewComponent = /** @class */ (function (_super) {
                     group.value.model.closeAllPanels();
                 }
             }
-            catch (e_25_1) { e_25 = { error: e_25_1 }; }
+            catch (e_26_1) { e_26 = { error: e_26_1 }; }
             finally {
                 try {
                     if (_c && !_c.done && (_a = _b.return)) _a.call(_b);
                 }
-                finally { if (e_25) throw e_25.error; }
+                finally { if (e_26) throw e_26.error; }
             }
         });
     };
@@ -2412,8 +2419,8 @@ var DockviewComponent = /** @class */ (function (_super) {
         return this.mutation('add', function () { return _this._doAddPanel(options); });
     };
     DockviewComponent.prototype._doAddPanel = function (options) {
-        var _a, _b;
-        if (this.panels.find(function (_) { return _.id === options.id; })) {
+        var _a, _b, _c, _d;
+        if (this.panels.some(function (_) { return _.id === options.id; })) {
             throw new Error("dockview: panel with id ".concat(options.id, " already exists"));
         }
         var referenceGroup;
@@ -2432,18 +2439,24 @@ var DockviewComponent = /** @class */ (function (_super) {
                     : options.position.referencePanel;
                 index = options.position.index;
                 if (!referencePanel) {
-                    throw new Error("dockview: referencePanel '".concat(options.position.referencePanel, "' does not exist"));
+                    var referenceId = typeof options.position.referencePanel === 'string'
+                        ? options.position.referencePanel
+                        : (_a = options.position.referencePanel) === null || _a === void 0 ? void 0 : _a.id;
+                    throw new Error("dockview: referencePanel '".concat(referenceId, "' does not exist"));
                 }
                 referenceGroup = this.findGroup(referencePanel);
             }
             else if ((0, options_1.isPanelOptionsWithGroup)(options.position)) {
                 referenceGroup =
                     typeof options.position.referenceGroup === 'string'
-                        ? (_a = this._groups.get(options.position.referenceGroup)) === null || _a === void 0 ? void 0 : _a.value
+                        ? (_b = this._groups.get(options.position.referenceGroup)) === null || _b === void 0 ? void 0 : _b.value
                         : options.position.referenceGroup;
                 index = options.position.index;
                 if (!referenceGroup) {
-                    throw new Error("dockview: referenceGroup '".concat(options.position.referenceGroup, "' does not exist"));
+                    var referenceId = typeof options.position.referenceGroup === 'string'
+                        ? options.position.referenceGroup
+                        : (_c = options.position.referenceGroup) === null || _c === void 0 ? void 0 : _c.id;
+                    throw new Error("dockview: referenceGroup '".concat(referenceId, "' does not exist"));
                 }
             }
             else {
@@ -2469,7 +2482,7 @@ var DockviewComponent = /** @class */ (function (_super) {
         }
         var panel;
         if (referenceGroup) {
-            var target = (0, baseComponentGridview_1.toTarget)(((_b = options.position) === null || _b === void 0 ? void 0 : _b.direction) || 'within');
+            var target = (0, baseComponentGridview_1.toTarget)(((_d = options.position) === null || _d === void 0 ? void 0 : _d.direction) || 'within');
             if (options.floating) {
                 var group = this.createGroup();
                 this._onDidAddGroup.fire(group);
@@ -2553,15 +2566,16 @@ var DockviewComponent = /** @class */ (function (_super) {
     };
     DockviewComponent.prototype.removePanel = function (panel, options) {
         var _this = this;
-        if (options === void 0) { options = {
-            removeEmptyGroup: true,
-        }; }
-        this.mutation('remove', function () { return _this._doRemovePanel(panel, options); });
+        this.mutation('remove', function () {
+            var _a;
+            return _this._doRemovePanel(panel, {
+                removeEmptyGroup: (_a = options === null || options === void 0 ? void 0 : options.removeEmptyGroup) !== null && _a !== void 0 ? _a : true,
+                skipDispose: options === null || options === void 0 ? void 0 : options.skipDispose,
+                skipSetActiveGroup: options === null || options === void 0 ? void 0 : options.skipSetActiveGroup,
+            });
+        });
     };
     DockviewComponent.prototype._doRemovePanel = function (panel, options) {
-        if (options === void 0) { options = {
-            removeEmptyGroup: true,
-        }; }
         var group = panel.group;
         if (!group) {
             throw new Error("dockview: cannot remove panel ".concat(panel.id, ". it's missing a group."));
@@ -2588,28 +2602,34 @@ var DockviewComponent = /** @class */ (function (_super) {
         return this.mutation('add', function () { return _this._doAddGroup(options); });
     };
     DockviewComponent.prototype._doAddGroup = function (options) {
-        var _a;
+        var _a, _b, _c;
         if (options) {
             var referenceGroup = void 0;
             if ((0, options_1.isGroupOptionsWithPanel)(options)) {
                 var referencePanel = typeof options.referencePanel === 'string'
                     ? this.panels.find(function (panel) { return panel.id === options.referencePanel; })
                     : options.referencePanel;
+                var referencePanelId = typeof options.referencePanel === 'string'
+                    ? options.referencePanel
+                    : (_a = options.referencePanel) === null || _a === void 0 ? void 0 : _a.id;
                 if (!referencePanel) {
-                    throw new Error("dockview: reference panel ".concat(options.referencePanel, " does not exist"));
+                    throw new Error("dockview: reference panel ".concat(referencePanelId, " does not exist"));
                 }
                 referenceGroup = this.findGroup(referencePanel);
                 if (!referenceGroup) {
-                    throw new Error("dockview: reference group for reference panel ".concat(options.referencePanel, " does not exist"));
+                    throw new Error("dockview: reference group for reference panel ".concat(referencePanelId, " does not exist"));
                 }
             }
             else if ((0, options_1.isGroupOptionsWithGroup)(options)) {
                 referenceGroup =
                     typeof options.referenceGroup === 'string'
-                        ? (_a = this._groups.get(options.referenceGroup)) === null || _a === void 0 ? void 0 : _a.value
+                        ? (_b = this._groups.get(options.referenceGroup)) === null || _b === void 0 ? void 0 : _b.value
                         : options.referenceGroup;
                 if (!referenceGroup) {
-                    throw new Error("dockview: reference group ".concat(options.referenceGroup, " does not exist"));
+                    var referenceId = typeof options.referenceGroup === 'string'
+                        ? options.referenceGroup
+                        : (_c = options.referenceGroup) === null || _c === void 0 ? void 0 : _c.id;
+                    throw new Error("dockview: reference group ".concat(referenceId, " does not exist"));
                 }
             }
             else {
@@ -2710,7 +2730,7 @@ var DockviewComponent = /** @class */ (function (_super) {
         }
     };
     DockviewComponent.prototype.doRemoveGroup = function (group, options) {
-        var e_26, _a;
+        var e_27, _a;
         var _b, _c, _d, _e, _f;
         // Edge groups are permanent structural elements - never remove them from the layout
         if ((_b = this._edgeGroupService) === null || _b === void 0 ? void 0 : _b.includes(group)) {
@@ -2727,12 +2747,12 @@ var DockviewComponent = /** @class */ (function (_super) {
                     });
                 }
             }
-            catch (e_26_1) { e_26 = { error: e_26_1 }; }
+            catch (e_27_1) { e_27 = { error: e_27_1 }; }
             finally {
                 try {
                     if (panels_2_1 && !panels_2_1.done && (_a = panels_2.return)) _a.call(panels_2);
                 }
-                finally { if (e_26) throw e_26.error; }
+                finally { if (e_27) throw e_27.error; }
             }
         }
         var activePanel = this.activePanel;
@@ -2744,14 +2764,14 @@ var DockviewComponent = /** @class */ (function (_super) {
             if (this.detachFromNestedWindow(group)) {
                 // The floating window hosts other groups and stays alive —
                 // finalize just this group.
-                if (!(options === null || options === void 0 ? void 0 : options.skipDispose)) {
-                    this.disposeGroupRecord(group);
-                }
-                else {
+                if (options === null || options === void 0 ? void 0 : options.skipDispose) {
                     // Relocation: reset location so the destination root can
                     // re-tag it.
                     group.model.location = { type: 'grid' };
                 }
+                else {
+                    this.disposeGroupRecord(group);
+                }
                 this.activateFallbackGroupIfRemoved(group, options === null || options === void 0 ? void 0 : options.skipActive);
                 return group;
             }
@@ -2772,14 +2792,14 @@ var DockviewComponent = /** @class */ (function (_super) {
             if (this.detachFromNestedWindow(group)) {
                 // The popout window hosts other groups and stays alive —
                 // finalize just this group.
-                if (!(options === null || options === void 0 ? void 0 : options.skipDispose)) {
-                    this.disposeGroupRecord(group);
-                }
-                else {
+                if (options === null || options === void 0 ? void 0 : options.skipDispose) {
                     // Relocation: reset location so the destination root can
                     // re-tag it.
                     group.model.location = { type: 'grid' };
                 }
+                else {
+                    this.disposeGroupRecord(group);
+                }
                 this.activateFallbackGroupIfRemoved(group, options === null || options === void 0 ? void 0 : options.skipActive);
                 return group;
             }
@@ -2789,7 +2809,7 @@ var DockviewComponent = /** @class */ (function (_super) {
                     var refGroup = selectedGroup.referenceGroup
                         ? this.getPanel(selectedGroup.referenceGroup)
                         : undefined;
-                    if (refGroup && refGroup.panels.length === 0) {
+                    if ((refGroup === null || refGroup === void 0 ? void 0 : refGroup.panels.length) === 0) {
                         this.removeGroup(refGroup);
                     }
                 }
@@ -2834,7 +2854,7 @@ var DockviewComponent = /** @class */ (function (_super) {
             cancelAnimationFrame(this._updatePositionsFrameId);
         }
         this._updatePositionsFrameId = requestAnimationFrame(function () {
-            var e_27, _a;
+            var e_28, _a;
             var _b, _c;
             _this._updatePositionsFrameId = undefined;
             _this.overlayRenderContainer.updateAllPositions();
@@ -2847,12 +2867,12 @@ var DockviewComponent = /** @class */ (function (_super) {
                     entry.overlayRenderContainer.updateAllPositions();
                 }
             }
-            catch (e_27_1) { e_27 = { error: e_27_1 }; }
+            catch (e_28_1) { e_28 = { error: e_28_1 }; }
             finally {
                 try {
                     if (_e && !_e.done && (_a = _d.return)) _a.call(_d);
                 }
-                finally { if (e_27) throw e_27.error; }
+                finally { if (e_28) throw e_28.error; }
             }
         });
     };
@@ -3200,9 +3220,9 @@ var DockviewComponent = /** @class */ (function (_super) {
             return;
         }
         var addPanelsToGroup = function (targetGroup) {
-            var e_28, _a, e_29, _b;
+            var e_29, _a, e_30, _b;
             _this.movingLock(function () {
-                var e_30, _a;
+                var e_31, _a;
                 try {
                     for (var removedPanels_3 = __values(removedPanels), removedPanels_3_1 = removedPanels_3.next(); !removedPanels_3_1.done; removedPanels_3_1 = removedPanels_3.next()) {
                         var panel = removedPanels_3_1.value;
@@ -3213,12 +3233,12 @@ var DockviewComponent = /** @class */ (function (_super) {
                         });
                     }
                 }
-                catch (e_30_1) { e_30 = { error: e_30_1 }; }
+                catch (e_31_1) { e_31 = { error: e_31_1 }; }
                 finally {
                     try {
                         if (removedPanels_3_1 && !removedPanels_3_1.done && (_a = removedPanels_3.return)) _a.call(removedPanels_3);
                     }
-                    finally { if (e_30) throw e_30.error; }
+                    finally { if (e_31) throw e_31.error; }
                 }
             });
             // Recreate the tab group in the destination
@@ -3234,12 +3254,12 @@ var DockviewComponent = /** @class */ (function (_super) {
                     targetGroup.model.addPanelToTabGroup(newTabGroup.id, panel.id);
                 }
             }
-            catch (e_28_1) { e_28 = { error: e_28_1 }; }
+            catch (e_29_1) { e_29 = { error: e_29_1 }; }
             finally {
                 try {
                     if (removedPanels_1_1 && !removedPanels_1_1.done && (_a = removedPanels_1.return)) _a.call(removedPanels_1);
                 }
-                finally { if (e_28) throw e_28.error; }
+                finally { if (e_29) throw e_29.error; }
             }
             if (!options.skipSetActive) {
                 _this.doSetGroupAndPanelActive(targetGroup);
@@ -3253,12 +3273,12 @@ var DockviewComponent = /** @class */ (function (_super) {
                     });
                 }
             }
-            catch (e_29_1) { e_29 = { error: e_29_1 }; }
+            catch (e_30_1) { e_30 = { error: e_30_1 }; }
             finally {
                 try {
                     if (removedPanels_2_1 && !removedPanels_2_1.done && (_b = removedPanels_2.return)) _b.call(removedPanels_2);
                 }
-                finally { if (e_29) throw e_29.error; }
+                finally { if (e_30) throw e_30.error; }
             }
         };
         var targetGroup;
@@ -3301,7 +3321,7 @@ var DockviewComponent = /** @class */ (function (_super) {
         this.mutation('maximize', function () { return _super.prototype.exitMaximizedGroup.call(_this); });
     };
     DockviewComponent.prototype._doMoveGroup = function (options) {
-        var e_31, _a, e_32, _b, e_33, _c, e_34, _d;
+        var e_32, _a, e_33, _b, e_34, _c, e_35, _d;
         var _this = this;
         var _e, _f, _g;
         var from = options.from.group;
@@ -3334,7 +3354,7 @@ var DockviewComponent = /** @class */ (function (_super) {
                 this.doRemoveGroup(from, { skipActive: true });
             }
             this.movingLock(function () {
-                var e_35, _a;
+                var e_36, _a;
                 try {
                     for (var panels_4 = __values(panels_3), panels_4_1 = panels_4.next(); !panels_4_1.done; panels_4_1 = panels_4.next()) {
                         var panel = panels_4_1.value;
@@ -3344,12 +3364,12 @@ var DockviewComponent = /** @class */ (function (_super) {
                         });
                     }
                 }
-                catch (e_35_1) { e_35 = { error: e_35_1 }; }
+                catch (e_36_1) { e_36 = { error: e_36_1 }; }
                 finally {
                     try {
                         if (panels_4_1 && !panels_4_1.done && (_a = panels_4.return)) _a.call(panels_4);
                     }
-                    finally { if (e_35) throw e_35.error; }
+                    finally { if (e_36) throw e_36.error; }
                 }
             });
             try {
@@ -3362,26 +3382,26 @@ var DockviewComponent = /** @class */ (function (_super) {
                         componentParams: snapshot.componentParams,
                     });
                     try {
-                        for (var _h = (e_32 = void 0, __values(snapshot.panelIds)), _j = _h.next(); !_j.done; _j = _h.next()) {
+                        for (var _h = (e_33 = void 0, __values(snapshot.panelIds)), _j = _h.next(); !_j.done; _j = _h.next()) {
                             var panelId = _j.value;
                             to.model.addPanelToTabGroup(newTabGroup.id, panelId);
                         }
                     }
-                    catch (e_32_1) { e_32 = { error: e_32_1 }; }
+                    catch (e_33_1) { e_33 = { error: e_33_1 }; }
                     finally {
                         try {
                             if (_j && !_j.done && (_b = _h.return)) _b.call(_h);
                         }
-                        finally { if (e_32) throw e_32.error; }
+                        finally { if (e_33) throw e_33.error; }
                     }
                 }
             }
-            catch (e_31_1) { e_31 = { error: e_31_1 }; }
+            catch (e_32_1) { e_32 = { error: e_32_1 }; }
             finally {
                 try {
                     if (tabGroupSnapshots_1_1 && !tabGroupSnapshots_1_1.done && (_a = tabGroupSnapshots_1.return)) _a.call(tabGroupSnapshots_1);
                 }
-                finally { if (e_31) throw e_31.error; }
+                finally { if (e_32) throw e_32.error; }
             }
             // Ensure group becomes active after move
             if (options.skipSetActive !== true) {
@@ -3431,7 +3451,7 @@ var DockviewComponent = /** @class */ (function (_super) {
                 // and addEdgeGroup.
                 this._onDidAddGroup.fire(source);
                 this.movingLock(function () {
-                    var e_36, _a;
+                    var e_37, _a;
                     try {
                         for (var movedPanels_2 = __values(movedPanels_1), movedPanels_2_1 = movedPanels_2.next(); !movedPanels_2_1.done; movedPanels_2_1 = movedPanels_2.next()) {
                             var panel = movedPanels_2_1.value;
@@ -3441,12 +3461,12 @@ var DockviewComponent = /** @class */ (function (_super) {
                             });
                         }
                     }
-                    catch (e_36_1) { e_36 = { error: e_36_1 }; }
+                    catch (e_37_1) { e_37 = { error: e_37_1 }; }
                     finally {
                         try {
                             if (movedPanels_2_1 && !movedPanels_2_1.done && (_a = movedPanels_2.return)) _a.call(movedPanels_2);
                         }
-                        finally { if (e_36) throw e_36.error; }
+                        finally { if (e_37) throw e_37.error; }
                     }
                 });
                 try {
@@ -3459,26 +3479,26 @@ var DockviewComponent = /** @class */ (function (_super) {
                             componentParams: snapshot.componentParams,
                         });
                         try {
-                            for (var _k = (e_34 = void 0, __values(snapshot.panelIds)), _l = _k.next(); !_l.done; _l = _k.next()) {
+                            for (var _k = (e_35 = void 0, __values(snapshot.panelIds)), _l = _k.next(); !_l.done; _l = _k.next()) {
                                 var panelId = _l.value;
                                 source.model.addPanelToTabGroup(newTabGroup.id, panelId);
                             }
                         }
-                        catch (e_34_1) { e_34 = { error: e_34_1 }; }
+                        catch (e_35_1) { e_35 = { error: e_35_1 }; }
                         finally {
                             try {
                                 if (_l && !_l.done && (_d = _k.return)) _d.call(_k);
                             }
-                            finally { if (e_34) throw e_34.error; }
+                            finally { if (e_35) throw e_35.error; }
                         }
                     }
                 }
-                catch (e_33_1) { e_33 = { error: e_33_1 }; }
+                catch (e_34_1) { e_34 = { error: e_34_1 }; }
                 finally {
                     try {
                         if (tabGroupSnapshots_2_1 && !tabGroupSnapshots_2_1.done && (_c = tabGroupSnapshots_2.return)) _c.call(tabGroupSnapshots_2);
                     }
-                    finally { if (e_33) throw e_33.error; }
+                    finally { if (e_34) throw e_34.error; }
                 }
             }
             else {
@@ -3610,9 +3630,7 @@ var DockviewComponent = /** @class */ (function (_super) {
     };
     DockviewComponent.prototype.createGroup = function (options) {
         var _this = this;
-        if (!options) {
-            options = {};
-        }
+        options !== null && options !== void 0 ? options : (options = {});
         var id = options === null || options === void 0 ? void 0 : options.id;
         if (id && this._groups.has(options.id)) {
             console.warn("dockview: Duplicate group id ".concat(options === null || options === void 0 ? void 0 : options.id, ". reassigning group id to avoid errors"));
@@ -3795,7 +3813,7 @@ var DockviewComponent = /** @class */ (function (_super) {
             : (0, gridview_1.orthogonal)(rootOrientation);
     };
     DockviewComponent.prototype.updateTheme = function () {
-        var e_37, _a, e_38, _b, e_39, _c;
+        var e_38, _a, e_39, _b, e_40, _c;
         var _d, _e, _f, _g, _h, _j, _k, _l, _m, _o;
         var theme = (_d = this._options.theme) !== null && _d !== void 0 ? _d : theme_1.themeAbyss;
         // Apply the theme class only to the shell so edge groups and the
@@ -3813,12 +3831,12 @@ var DockviewComponent = /** @class */ (function (_super) {
                 floating.gridview.margin = gap;
             }
         }
-        catch (e_37_1) { e_37 = { error: e_37_1 }; }
+        catch (e_38_1) { e_38 = { error: e_38_1 }; }
         finally {
             try {
                 if (_q && !_q.done && (_a = _p.return)) _a.call(_p);
             }
-            finally { if (e_37) throw e_37.error; }
+            finally { if (e_38) throw e_38.error; }
         }
         try {
             for (var _r = __values((_h = (_g = this._popoutWindowService) === null || _g === void 0 ? void 0 : _g.entries) !== null && _h !== void 0 ? _h : []), _s = _r.next(); !_s.done; _s = _r.next()) {
@@ -3826,21 +3844,21 @@ var DockviewComponent = /** @class */ (function (_super) {
                 entry.gridview.margin = gap;
             }
         }
-        catch (e_38_1) { e_38 = { error: e_38_1 }; }
+        catch (e_39_1) { e_39 = { error: e_39_1 }; }
         finally {
             try {
                 if (_s && !_s.done && (_b = _r.return)) _b.call(_r);
             }
-            finally { if (e_38) throw e_38.error; }
+            finally { if (e_39) throw e_39.error; }
         }
         (_j = this._shellManager) === null || _j === void 0 ? void 0 : _j.updateTheme(gap, (_k = theme.edgeGroupCollapsedSize) !== null && _k !== void 0 ? _k : 35);
-        if (theme.dndOverlayBorder !== undefined) {
-            this.element.style.setProperty('--dv-drag-over-border', theme.dndOverlayBorder);
-            (_l = this._shellManager) === null || _l === void 0 ? void 0 : _l.element.style.setProperty('--dv-drag-over-border', theme.dndOverlayBorder);
+        if (theme.dndOverlayBorder === undefined) {
+            this.element.style.removeProperty('--dv-drag-over-border');
+            (_l = this._shellManager) === null || _l === void 0 ? void 0 : _l.element.style.removeProperty('--dv-drag-over-border');
         }
         else {
-            this.element.style.removeProperty('--dv-drag-over-border');
-            (_m = this._shellManager) === null || _m === void 0 ? void 0 : _m.element.style.removeProperty('--dv-drag-over-border');
+            this.element.style.setProperty('--dv-drag-over-border', theme.dndOverlayBorder);
+            (_m = this._shellManager) === null || _m === void 0 ? void 0 : _m.element.style.setProperty('--dv-drag-over-border', theme.dndOverlayBorder);
         }
         switch (theme.dndOverlayMounting) {
             case 'absolute':
@@ -3865,12 +3883,12 @@ var DockviewComponent = /** @class */ (function (_super) {
                 group.model.updateTabGroups();
             }
         }
-        catch (e_39_1) { e_39 = { error: e_39_1 }; }
+        catch (e_40_1) { e_40 = { error: e_40_1 }; }
         finally {
             try {
                 if (_u && !_u.done && (_c = _t.return)) _c.call(_t);
             }
-            finally { if (e_39) throw e_39.error; }
+            finally { if (e_40) throw e_40.error; }
         }
     };
     return DockviewComponent;