dockview-core 6.0.1 → 6.0.3

package/dist/cjs/dnd/groupDragHandler.js

@@ -44,6 +44,9 @@ var GroupDragHandler = /** @class */ (function (_super) {
         if (this.group.api.location.type === 'floating' && !_event.shiftKey) {
             return true;
         }
+        if (this.group.api.location.type === 'edge' && this.group.size === 0) {
+            return true;
+        }
         return false;
     };
     GroupDragHandler.prototype.getData = function (dragEvent) {

package/dist/cjs/dockview/dockviewComponent.js

@@ -902,10 +902,20 @@ var DockviewComponent = /** @class */ (function (_super) {
             if (event.isActive) {
                 overlay.bringToFront();
             }
-        }), (0, dom_1.watchElementResize)(group.element, function (entry) {
-            var _a = entry.contentRect, width = _a.width, height = _a.height;
-            group.layout(width, height); // let the group know it's size is changing so it can fire events to the panel
-        }));
+        }), (function () {
+            var lastWidth = -1;
+            var lastHeight = -1;
+            return (0, dom_1.watchElementResize)(group.element, function (entry) {
+                var width = Math.round(entry.contentRect.width);
+                var height = Math.round(entry.contentRect.height);
+                if (width === lastWidth && height === lastHeight) {
+                    return;
+                }
+                lastWidth = width;
+                lastHeight = height;
+                group.layout(width, height); // let the group know it's size is changing so it can fire events to the panel
+            });
+        })());
         floatingGroupPanel.addDisposables(overlay.onDidChange(function () {
             // this is either a resize or a move
             // to inform the panels .layout(...) the group with it's current size
@@ -2446,6 +2456,10 @@ var DockviewComponent = /** @class */ (function (_super) {
         var from = options.from.group;
         var to = options.to.group;
         var target = options.to.position;
+        // The group whose panels end up at the target. For non-edge moves
+        // we relocate `from` itself; for edge moves we move panels into a
+        // freshly created group so the edge slot stays anchored.
+        var source = from;
         if (target === 'center') {
             var activePanel_1 = from.activePanel;
             var panels_3 = this.movingLock(function () {
@@ -2490,55 +2504,94 @@ var DockviewComponent = /** @class */ (function (_super) {
             }
         }
         else {
-            switch (from.api.location.type) {
-                case 'grid':
-                    this.gridview.removeView((0, gridview_1.getGridLocation)(from.element));
-                    break;
-                case 'floating': {
-                    var selectedFloatingGroup = this._floatingGroups.find(function (x) { return x.group === from; });
-                    if (!selectedFloatingGroup) {
-                        throw new Error('dockview: failed to find floating group');
-                    }
-                    selectedFloatingGroup.dispose();
-                    break;
-                }
-                case 'popout': {
-                    var selectedPopoutGroup = this._popoutGroups.find(function (x) { return x.popoutGroup === from; });
-                    if (!selectedPopoutGroup) {
-                        throw new Error('dockview: failed to find popout group');
-                    }
-                    // Remove from popout groups list to prevent automatic restoration
-                    var index = this._popoutGroups.indexOf(selectedPopoutGroup);
-                    if (index >= 0) {
-                        this._popoutGroups.splice(index, 1);
-                    }
-                    // Clean up the reference group (ghost) if it exists and is hidden
-                    if (selectedPopoutGroup.referenceGroup) {
-                        var referenceGroup = this.getPanel(selectedPopoutGroup.referenceGroup);
-                        if (referenceGroup && !referenceGroup.api.isVisible) {
-                            this.doRemoveGroup(referenceGroup, {
-                                skipActive: true,
+            if (from.api.location.type === 'edge') {
+                /**
+                 * Edge groups are permanent structural elements and must
+                 * stay anchored in their edge slot. Move the panels into a
+                 * new group; the auto-collapse listener registered in
+                 * addEdgeGroup will collapse the now-empty edge slot once
+                 * the last panel leaves. The placement code below then
+                 * positions `source` like any other moved group.
+                 */
+                var activePanel_2 = from.activePanel;
+                var movedPanels_1 = this.movingLock(function () {
+                    return __spreadArray([], __read(from.panels), false).map(function (p) {
+                        return from.model.removePanel(p.id, { skipSetActive: true });
+                    });
+                });
+                source = this.createGroup();
+                this.movingLock(function () {
+                    var e_32, _a;
+                    try {
+                        for (var movedPanels_2 = __values(movedPanels_1), movedPanels_2_1 = movedPanels_2.next(); !movedPanels_2_1.done; movedPanels_2_1 = movedPanels_2.next()) {
+                            var panel = movedPanels_2_1.value;
+                            source.model.openPanel(panel, {
+                                skipSetActive: panel !== activePanel_2,
+                                skipSetGroupActive: true,
                             });
                         }
                     }
-                    // Manually dispose the window without triggering restoration
-                    selectedPopoutGroup.window.dispose();
-                    // Update group's location and containers for target
-                    if (to.api.location.type === 'grid') {
-                        from.model.renderContainer =
-                            this.overlayRenderContainer;
-                        from.model.dropTargetContainer =
-                            this.rootDropTargetContainer;
-                        from.model.location = { type: 'grid' };
+                    catch (e_32_1) { e_32 = { error: e_32_1 }; }
+                    finally {
+                        try {
+                            if (movedPanels_2_1 && !movedPanels_2_1.done && (_a = movedPanels_2.return)) _a.call(movedPanels_2);
+                        }
+                        finally { if (e_32) throw e_32.error; }
+                    }
+                });
+            }
+            else {
+                switch (from.api.location.type) {
+                    case 'grid':
+                        this.gridview.removeView((0, gridview_1.getGridLocation)(from.element));
+                        break;
+                    case 'floating': {
+                        var selectedFloatingGroup = this._floatingGroups.find(function (x) { return x.group === from; });
+                        if (!selectedFloatingGroup) {
+                            throw new Error('dockview: failed to find floating group');
+                        }
+                        selectedFloatingGroup.dispose();
+                        break;
                     }
-                    else if (to.api.location.type === 'floating') {
-                        from.model.renderContainer =
-                            this.overlayRenderContainer;
-                        from.model.dropTargetContainer =
-                            this.rootDropTargetContainer;
-                        from.model.location = { type: 'floating' };
+                    case 'popout': {
+                        var selectedPopoutGroup = this._popoutGroups.find(function (x) { return x.popoutGroup === from; });
+                        if (!selectedPopoutGroup) {
+                            throw new Error('dockview: failed to find popout group');
+                        }
+                        // Remove from popout groups list to prevent automatic restoration
+                        var index = this._popoutGroups.indexOf(selectedPopoutGroup);
+                        if (index >= 0) {
+                            this._popoutGroups.splice(index, 1);
+                        }
+                        // Clean up the reference group (ghost) if it exists and is hidden
+                        if (selectedPopoutGroup.referenceGroup) {
+                            var referenceGroup = this.getPanel(selectedPopoutGroup.referenceGroup);
+                            if (referenceGroup &&
+                                !referenceGroup.api.isVisible) {
+                                this.doRemoveGroup(referenceGroup, {
+                                    skipActive: true,
+                                });
+                            }
+                        }
+                        // Manually dispose the window without triggering restoration
+                        selectedPopoutGroup.window.dispose();
+                        // Update group's location and containers for target
+                        if (to.api.location.type === 'grid') {
+                            from.model.renderContainer =
+                                this.overlayRenderContainer;
+                            from.model.dropTargetContainer =
+                                this.rootDropTargetContainer;
+                            from.model.location = { type: 'grid' };
+                        }
+                        else if (to.api.location.type === 'floating') {
+                            from.model.renderContainer =
+                                this.overlayRenderContainer;
+                            from.model.dropTargetContainer =
+                                this.rootDropTargetContainer;
+                            from.model.location = { type: 'floating' };
+                        }
+                        break;
                     }
-                    break;
                 }
             }
             // For moves to grid locations
@@ -2561,7 +2614,7 @@ var DockviewComponent = /** @class */ (function (_super) {
                                 : from.api.width;
                         break;
                 }
-                this.gridview.addView(from, size, dropLocation);
+                this.gridview.addView(source, size, dropLocation);
             }
             else if (to.api.location.type === 'floating') {
                 // For moves to floating locations, add as floating group
@@ -2589,7 +2642,7 @@ var DockviewComponent = /** @class */ (function (_super) {
                     else {
                         top_1 = 50; // Default fallback
                     }
-                    this.addFloatingGroup(from, {
+                    this.addFloatingGroup(source, {
                         height: box.height,
                         width: box.width,
                         position: {
@@ -2600,7 +2653,7 @@ var DockviewComponent = /** @class */ (function (_super) {
                 }
             }
         }
-        from.panels.forEach(function (panel) {
+        source.panels.forEach(function (panel) {
             _this._onDidMovePanel.fire({ panel: panel, from: from });
         });
         this.debouncedUpdateAllPositions();
@@ -2611,6 +2664,11 @@ var DockviewComponent = /** @class */ (function (_super) {
             var targetGroup = to !== null && to !== void 0 ? to : from;
             this.doSetGroupAndPanelActive(targetGroup);
         }
+        else if (source !== from && options.skipSetActive !== true) {
+            // Edge group moves create a fresh `source` group; activate it
+            // by default so the moved panels receive focus.
+            this.doSetGroupAndPanelActive(source);
+        }
     };
     DockviewComponent.prototype.doSetGroupActive = function (group) {
         _super.prototype.doSetGroupActive.call(this, group);
@@ -2783,7 +2841,7 @@ var DockviewComponent = /** @class */ (function (_super) {
         }
     };
     DockviewComponent.prototype.updateTheme = function () {
-        var e_32, _a;
+        var e_33, _a;
         var _b, _c, _d, _e, _f, _g, _h, _j, _k;
         var theme = (_b = this._options.theme) !== null && _b !== void 0 ? _b : theme_1.themeAbyss;
         // Apply the theme class only to the shell so edge groups and the
@@ -2824,12 +2882,12 @@ var DockviewComponent = /** @class */ (function (_super) {
                 group.model.updateTabGroups();
             }
         }
-        catch (e_32_1) { e_32 = { error: e_32_1 }; }
+        catch (e_33_1) { e_33 = { error: e_33_1 }; }
         finally {
             try {
                 if (_m && !_m.done && (_a = _l.return)) _a.call(_l);
             }
-            finally { if (e_32) throw e_32.error; }
+            finally { if (e_33) throw e_33.error; }
         }
     };
     return DockviewComponent;

package/dist/cjs/dockview/dockviewShell.js

@@ -316,7 +316,12 @@ var ShellManager = /** @class */ (function () {
         this._middleIndex = 0;
         this._outerSplitview.addView(this._middleColumn, { type: 'distribute' }, 0);
         this._disposables.addDisposables((0, dom_1.watchElementResize)(this._shellElement, function (entry) {
-            var _a = entry.contentRect, width = _a.width, height = _a.height;
+            var width = Math.round(entry.contentRect.width);
+            var height = Math.round(entry.contentRect.height);
+            if (width === _this._currentWidth &&
+                height === _this._currentHeight) {
+                return;
+            }
             _this._currentWidth = width;
             _this._currentHeight = height;
             _this.layout(width, height);

package/dist/cjs/overlay/overlayRenderContainer.js

@@ -146,8 +146,14 @@ var OverlayRenderContainer = /** @class */ (function (_super) {
             };
         }
         var focusContainer = this.map[panel.api.id].element;
-        if (panel.view.content.element.parentElement !== focusContainer) {
-            focusContainer.appendChild(panel.view.content.element);
+        // Capture the content element now so the destroy disposable below
+        // does not re-query the renderer's `element` getter during teardown.
+        // Some framework adapters (e.g. dockview-angular) tear down their
+        // backing renderer before this disposable fires; reading through the
+        // getter at that point can throw.
+        var contentElement = panel.view.content.element;
+        if (contentElement.parentElement !== focusContainer) {
+            focusContainer.appendChild(contentElement);
         }
         if (focusContainer.parentElement !== this.element) {
             this.element.appendChild(focusContainer);
@@ -260,8 +266,8 @@ var OverlayRenderContainer = /** @class */ (function (_super) {
         }));
         this.map[panel.api.id].destroy = lifecycle_1.Disposable.from(function () {
             var _a;
-            if (panel.view.content.element.parentElement === focusContainer) {
-                focusContainer.removeChild(panel.view.content.element);
+            if (contentElement.parentElement === focusContainer) {
+                focusContainer.removeChild(contentElement);
             }
             (_a = focusContainer.parentElement) === null || _a === void 0 ? void 0 : _a.removeChild(focusContainer);
         });

package/dist/cjs/resizable.d.ts

@@ -2,6 +2,8 @@ import { CompositeDisposable } from './lifecycle';
 export declare abstract class Resizable extends CompositeDisposable {
     private readonly _element;
     private _disableResizing;
+    private _lastWidth;
+    private _lastHeight;
     get element(): HTMLElement;
     get disableResizing(): boolean;
     set disableResizing(value: boolean);

package/dist/cjs/resizable.js

@@ -23,6 +23,8 @@ var Resizable = /** @class */ (function (_super) {
     function Resizable(parentElement, disableResizing) {
         if (disableResizing === void 0) { disableResizing = false; }
         var _this = _super.call(this) || this;
+        _this._lastWidth = -1;
+        _this._lastHeight = -1;
         _this._disableResizing = disableResizing;
         _this._element = parentElement;
         _this.addDisposables((0, dom_1.watchElementResize)(_this._element, function (entry) {
@@ -59,7 +61,16 @@ var Resizable = /** @class */ (function (_super) {
                  */
                 return;
             }
-            var _a = entry.contentRect, width = _a.width, height = _a.height;
+            // Round to integers to absorb sub-pixel jitter from
+            // fractional devicePixelRatio (e.g. multi-monitor setups),
+            // which would otherwise re-fire layout in a feedback loop.
+            var width = Math.round(entry.contentRect.width);
+            var height = Math.round(entry.contentRect.height);
+            if (width === _this._lastWidth && height === _this._lastHeight) {
+                return;
+            }
+            _this._lastWidth = width;
+            _this._lastHeight = height;
             _this.layout(width, height);
         }));
         return _this;

package/dist/dockview-core.js

@@ -1,6 +1,6 @@
 /**
  * dockview-core
- * @version 6.0.1
+ * @version 6.0.3
  * @link https://github.com/mathuo/dockview
  * @license MIT
  */
@@ -2860,6 +2860,8 @@
       }
       constructor(parentElement, disableResizing = false) {
           super();
+          this._lastWidth = -1;
+          this._lastHeight = -1;
           this._disableResizing = disableResizing;
           this._element = parentElement;
           this.addDisposables(watchElementResize(this._element, (entry) => {
@@ -2896,7 +2898,16 @@
                    */
                   return;
               }
-              const { width, height } = entry.contentRect;
+              // Round to integers to absorb sub-pixel jitter from
+              // fractional devicePixelRatio (e.g. multi-monitor setups),
+              // which would otherwise re-fire layout in a feedback loop.
+              const width = Math.round(entry.contentRect.width);
+              const height = Math.round(entry.contentRect.height);
+              if (width === this._lastWidth && height === this._lastHeight) {
+                  return;
+              }
+              this._lastWidth = width;
+              this._lastHeight = height;
               this.layout(width, height);
           }));
       }
@@ -5478,6 +5489,9 @@
           if (this.group.api.location.type === 'floating' && !_event.shiftKey) {
               return true;
           }
+          if (this.group.api.location.type === 'edge' && this.group.size === 0) {
+              return true;
+          }
           return false;
       }
       getData(dragEvent) {
@@ -11325,8 +11339,14 @@
               };
           }
           const focusContainer = this.map[panel.api.id].element;
-          if (panel.view.content.element.parentElement !== focusContainer) {
-              focusContainer.appendChild(panel.view.content.element);
+          // Capture the content element now so the destroy disposable below
+          // does not re-query the renderer's `element` getter during teardown.
+          // Some framework adapters (e.g. dockview-angular) tear down their
+          // backing renderer before this disposable fires; reading through the
+          // getter at that point can throw.
+          const contentElement = panel.view.content.element;
+          if (contentElement.parentElement !== focusContainer) {
+              focusContainer.appendChild(contentElement);
           }
           if (focusContainer.parentElement !== this.element) {
               this.element.appendChild(focusContainer);
@@ -11437,8 +11457,8 @@
           }));
           this.map[panel.api.id].destroy = exports.DockviewDisposable.from(() => {
               var _a;
-              if (panel.view.content.element.parentElement === focusContainer) {
-                  focusContainer.removeChild(panel.view.content.element);
+              if (contentElement.parentElement === focusContainer) {
+                  focusContainer.removeChild(contentElement);
               }
               (_a = focusContainer.parentElement) === null || _a === void 0 ? void 0 : _a.removeChild(focusContainer);
           });
@@ -12293,7 +12313,12 @@
           this._middleIndex = 0;
           this._outerSplitview.addView(this._middleColumn, { type: 'distribute' }, 0);
           this._disposables.addDisposables(watchElementResize(this._shellElement, (entry) => {
-              const { width, height } = entry.contentRect;
+              const width = Math.round(entry.contentRect.width);
+              const height = Math.round(entry.contentRect.height);
+              if (width === this._currentWidth &&
+                  height === this._currentHeight) {
+                  return;
+              }
               this._currentWidth = width;
               this._currentHeight = height;
               this.layout(width, height);
@@ -13363,10 +13388,20 @@
               if (event.isActive) {
                   overlay.bringToFront();
               }
-          }), watchElementResize(group.element, (entry) => {
-              const { width, height } = entry.contentRect;
-              group.layout(width, height); // let the group know it's size is changing so it can fire events to the panel
-          }));
+          }), (() => {
+              let lastWidth = -1;
+              let lastHeight = -1;
+              return watchElementResize(group.element, (entry) => {
+                  const width = Math.round(entry.contentRect.width);
+                  const height = Math.round(entry.contentRect.height);
+                  if (width === lastWidth && height === lastHeight) {
+                      return;
+                  }
+                  lastWidth = width;
+                  lastHeight = height;
+                  group.layout(width, height); // let the group know it's size is changing so it can fire events to the panel
+              });
+          })());
           floatingGroupPanel.addDisposables(overlay.onDidChange(() => {
               // this is either a resize or a move
               // to inform the panels .layout(...) the group with it's current size
@@ -14586,6 +14621,10 @@
           const from = options.from.group;
           const to = options.to.group;
           const target = options.to.position;
+          // The group whose panels end up at the target. For non-edge moves
+          // we relocate `from` itself; for edge moves we move panels into a
+          // freshly created group so the edge slot stays anchored.
+          let source = from;
           if (target === 'center') {
               const activePanel = from.activePanel;
               const panels = this.movingLock(() => [...from.panels].map((p) => from.model.removePanel(p.id, {
@@ -14615,55 +14654,79 @@
               }
           }
           else {
-              switch (from.api.location.type) {
-                  case 'grid':
-                      this.gridview.removeView(getGridLocation(from.element));
-                      break;
-                  case 'floating': {
-                      const selectedFloatingGroup = this._floatingGroups.find((x) => x.group === from);
-                      if (!selectedFloatingGroup) {
-                          throw new Error('dockview: failed to find floating group');
-                      }
-                      selectedFloatingGroup.dispose();
-                      break;
-                  }
-                  case 'popout': {
-                      const selectedPopoutGroup = this._popoutGroups.find((x) => x.popoutGroup === from);
-                      if (!selectedPopoutGroup) {
-                          throw new Error('dockview: failed to find popout group');
-                      }
-                      // Remove from popout groups list to prevent automatic restoration
-                      const index = this._popoutGroups.indexOf(selectedPopoutGroup);
-                      if (index >= 0) {
-                          this._popoutGroups.splice(index, 1);
+              if (from.api.location.type === 'edge') {
+                  /**
+                   * Edge groups are permanent structural elements and must
+                   * stay anchored in their edge slot. Move the panels into a
+                   * new group; the auto-collapse listener registered in
+                   * addEdgeGroup will collapse the now-empty edge slot once
+                   * the last panel leaves. The placement code below then
+                   * positions `source` like any other moved group.
+                   */
+                  const activePanel = from.activePanel;
+                  const movedPanels = this.movingLock(() => [...from.panels].map((p) => from.model.removePanel(p.id, { skipSetActive: true })));
+                  source = this.createGroup();
+                  this.movingLock(() => {
+                      for (const panel of movedPanels) {
+                          source.model.openPanel(panel, {
+                              skipSetActive: panel !== activePanel,
+                              skipSetGroupActive: true,
+                          });
                       }
-                      // Clean up the reference group (ghost) if it exists and is hidden
-                      if (selectedPopoutGroup.referenceGroup) {
-                          const referenceGroup = this.getPanel(selectedPopoutGroup.referenceGroup);
-                          if (referenceGroup && !referenceGroup.api.isVisible) {
-                              this.doRemoveGroup(referenceGroup, {
-                                  skipActive: true,
-                              });
+                  });
+              }
+              else {
+                  switch (from.api.location.type) {
+                      case 'grid':
+                          this.gridview.removeView(getGridLocation(from.element));
+                          break;
+                      case 'floating': {
+                          const selectedFloatingGroup = this._floatingGroups.find((x) => x.group === from);
+                          if (!selectedFloatingGroup) {
+                              throw new Error('dockview: failed to find floating group');
                           }
+                          selectedFloatingGroup.dispose();
+                          break;
                       }
-                      // Manually dispose the window without triggering restoration
-                      selectedPopoutGroup.window.dispose();
-                      // Update group's location and containers for target
-                      if (to.api.location.type === 'grid') {
-                          from.model.renderContainer =
-                              this.overlayRenderContainer;
-                          from.model.dropTargetContainer =
-                              this.rootDropTargetContainer;
-                          from.model.location = { type: 'grid' };
-                      }
-                      else if (to.api.location.type === 'floating') {
-                          from.model.renderContainer =
-                              this.overlayRenderContainer;
-                          from.model.dropTargetContainer =
-                              this.rootDropTargetContainer;
-                          from.model.location = { type: 'floating' };
+                      case 'popout': {
+                          const selectedPopoutGroup = this._popoutGroups.find((x) => x.popoutGroup === from);
+                          if (!selectedPopoutGroup) {
+                              throw new Error('dockview: failed to find popout group');
+                          }
+                          // Remove from popout groups list to prevent automatic restoration
+                          const index = this._popoutGroups.indexOf(selectedPopoutGroup);
+                          if (index >= 0) {
+                              this._popoutGroups.splice(index, 1);
+                          }
+                          // Clean up the reference group (ghost) if it exists and is hidden
+                          if (selectedPopoutGroup.referenceGroup) {
+                              const referenceGroup = this.getPanel(selectedPopoutGroup.referenceGroup);
+                              if (referenceGroup &&
+                                  !referenceGroup.api.isVisible) {
+                                  this.doRemoveGroup(referenceGroup, {
+                                      skipActive: true,
+                                  });
+                              }
+                          }
+                          // Manually dispose the window without triggering restoration
+                          selectedPopoutGroup.window.dispose();
+                          // Update group's location and containers for target
+                          if (to.api.location.type === 'grid') {
+                              from.model.renderContainer =
+                                  this.overlayRenderContainer;
+                              from.model.dropTargetContainer =
+                                  this.rootDropTargetContainer;
+                              from.model.location = { type: 'grid' };
+                          }
+                          else if (to.api.location.type === 'floating') {
+                              from.model.renderContainer =
+                                  this.overlayRenderContainer;
+                              from.model.dropTargetContainer =
+                                  this.rootDropTargetContainer;
+                              from.model.location = { type: 'floating' };
+                          }
+                          break;
                       }
-                      break;
                   }
               }
               // For moves to grid locations
@@ -14686,7 +14749,7 @@
                                   : from.api.width;
                           break;
                   }
-                  this.gridview.addView(from, size, dropLocation);
+                  this.gridview.addView(source, size, dropLocation);
               }
               else if (to.api.location.type === 'floating') {
                   // For moves to floating locations, add as floating group
@@ -14714,7 +14777,7 @@
                       else {
                           top = 50; // Default fallback
                       }
-                      this.addFloatingGroup(from, {
+                      this.addFloatingGroup(source, {
                           height: box.height,
                           width: box.width,
                           position: {
@@ -14725,7 +14788,7 @@
                   }
               }
           }
-          from.panels.forEach((panel) => {
+          source.panels.forEach((panel) => {
               this._onDidMovePanel.fire({ panel, from });
           });
           this.debouncedUpdateAllPositions();
@@ -14736,6 +14799,11 @@
               const targetGroup = to !== null && to !== void 0 ? to : from;
               this.doSetGroupAndPanelActive(targetGroup);
           }
+          else if (source !== from && options.skipSetActive !== true) {
+              // Edge group moves create a fresh `source` group; activate it
+              // by default so the moved panels receive focus.
+              this.doSetGroupAndPanelActive(source);
+          }
       }
       doSetGroupActive(group) {
           super.doSetGroupActive(group);