dockview-core 4.3.1 → 4.4.1

package/dist/dockview-core.noStyle.js

@@ -1,6 +1,6 @@
 /**
  * dockview-core
- * @version 4.3.1
+ * @version 4.4.1
  * @link https://github.com/mathuo/dockview
  * @license MIT
  */
@@ -3626,6 +3626,9 @@
         get onDidPopoutGroupPositionChange() {
             return this.component.onDidPopoutGroupPositionChange;
         }
+        get onDidOpenPopoutWindowFail() {
+            return this.component.onDidOpenPopoutWindowFail;
+        }
         /**
          * All panel objects.
          */
@@ -4994,7 +4997,7 @@
             this._element = document.createElement('div');
             this._element.className = 'dv-tab';
             this._element.tabIndex = 0;
-            this._element.draggable = true;
+            this._element.draggable = !this.accessor.options.disableDnd;
             toggleClass(this.element, 'dv-inactive-tab', true);
             const dragHandler = new TabDragHandler(this._element, this.accessor, this.group, this.panel);
             this.dropTarget = new Droptarget(this._element, {
@@ -5042,6 +5045,9 @@
             this.content = part;
             this._element.appendChild(this.content.element);
         }
+        updateDragAndDropState() {
+            this._element.draggable = !this.accessor.options.disableDnd;
+        }
         dispose() {
             super.dispose();
         }
@@ -5113,7 +5119,7 @@
             this.onDragStart = this._onDragStart.event;
             this._element = document.createElement('div');
             this._element.className = 'dv-void-container';
-            this._element.draggable = true;
+            this._element.draggable = !this.accessor.options.disableDnd;
             this.addDisposables(this._onDrop, this._onDragStart, addDisposableListener(this._element, 'pointerdown', () => {
                 this.accessor.doSetGroupActive(this.group);
             }));
@@ -5136,6 +5142,9 @@
                 this._onDrop.fire(event);
             }), this.dropTarget);
         }
+        updateDragAndDropState() {
+            this._element.draggable = !this.accessor.options.disableDnd;
+        }
     }
 
     class Scrollbar extends CompositeDisposable {
@@ -5396,6 +5405,11 @@
                     .map((x) => x.value.panel.id);
             this._onOverflowTabsChange.fire({ tabs, reset: options.reset });
         }
+        updateDragAndDropState() {
+            for (const tab of this._tabs) {
+                tab.value.updateDragAndDropState();
+            }
+        }
     }
 
     const createSvgElementFromPath = (params) => {
@@ -5668,6 +5682,10 @@
                 });
             }));
         }
+        updateDragAndDropState() {
+            this.tabs.updateDragAndDropState();
+            this.voidContainer.updateDragAndDropState();
+        }
     }
 
     class DockviewUnhandledDragOverEvent extends AcceptableEvent {
@@ -6373,6 +6391,9 @@
                 }));
             }
         }
+        updateDragAndDropState() {
+            this.tabsContainer.updateDragAndDropState();
+        }
         dispose() {
             var _a, _b, _c;
             super.dispose();
@@ -8228,6 +8249,8 @@
             this.onDidPopoutGroupSizeChange = this._onDidPopoutGroupSizeChange.event;
             this._onDidPopoutGroupPositionChange = new Emitter();
             this.onDidPopoutGroupPositionChange = this._onDidPopoutGroupPositionChange.event;
+            this._onDidOpenPopoutWindowFail = new Emitter();
+            this.onDidOpenPopoutWindowFail = this._onDidOpenPopoutWindowFail.event;
             this._onDidLayoutFromJSON = new Emitter();
             this.onDidLayoutFromJSON = this._onDidLayoutFromJSON.event;
             this._onDidActivePanelChange = new Emitter({ replay: true });
@@ -8292,7 +8315,7 @@
             if (options.debug) {
                 this.addDisposables(new StrictEventsSequencing(this));
             }
-            this.addDisposables(this.rootDropTargetContainer, this.overlayRenderContainer, this._onWillDragPanel, this._onWillDragGroup, this._onWillShowOverlay, this._onDidActivePanelChange, this._onDidAddPanel, this._onDidRemovePanel, this._onDidLayoutFromJSON, this._onDidDrop, this._onWillDrop, this._onDidMovePanel, this._onDidAddGroup, this._onDidRemoveGroup, this._onDidActiveGroupChange, this._onUnhandledDragOverEvent, this._onDidMaximizedGroupChange, this._onDidOptionsChange, this._onDidPopoutGroupSizeChange, this._onDidPopoutGroupPositionChange, this.onDidViewVisibilityChangeMicroTaskQueue(() => {
+            this.addDisposables(this.rootDropTargetContainer, this.overlayRenderContainer, this._onWillDragPanel, this._onWillDragGroup, this._onWillShowOverlay, this._onDidActivePanelChange, this._onDidAddPanel, this._onDidRemovePanel, this._onDidLayoutFromJSON, this._onDidDrop, this._onWillDrop, this._onDidMovePanel, this._onDidAddGroup, this._onDidRemoveGroup, this._onDidActiveGroupChange, this._onUnhandledDragOverEvent, this._onDidMaximizedGroupChange, this._onDidOptionsChange, this._onDidPopoutGroupSizeChange, this._onDidPopoutGroupPositionChange, this._onDidOpenPopoutWindowFail, this.onDidViewVisibilityChangeMicroTaskQueue(() => {
                 this.updateWatermark();
             }), this.onDidAdd((event) => {
                 if (!this._moving) {
@@ -8438,13 +8461,6 @@
                 if (_window.isDisposed) {
                     return false;
                 }
-                if (popoutContainer === null) {
-                    popoutWindowDisposable.dispose();
-                    return false;
-                }
-                const gready = document.createElement('div');
-                gready.className = 'dv-overlay-render-container';
-                const overlayRenderContainer = new OverlayRenderContainer(gready, this);
                 const referenceGroup = (options === null || options === void 0 ? void 0 : options.referenceGroup)
                     ? options.referenceGroup
                     : itemToPopout instanceof DockviewPanel
@@ -8452,7 +8468,7 @@
                         : itemToPopout;
                 const referenceLocation = itemToPopout.api.location.type;
                 /**
-                 * The group that is being added doesn't already exist within the DOM, the most likely occurance
+                 * The group that is being added doesn't already exist within the DOM, the most likely occurrence
                  * of this case is when being called from the `fromJSON(...)` method
                  */
                 const isGroupAddedToDom = referenceGroup.element.parentElement !== null;
@@ -8465,8 +8481,28 @@
                 }
                 else {
                     group = this.createGroup({ id: groupId });
-                    this._onDidAddGroup.fire(group);
+                    if (popoutContainer) {
+                        this._onDidAddGroup.fire(group);
+                    }
+                }
+                if (popoutContainer === null) {
+                    console.error('dockview: failed to create popout. perhaps you need to allow pop-ups for this website');
+                    popoutWindowDisposable.dispose();
+                    this._onDidOpenPopoutWindowFail.fire();
+                    // if the popout window was blocked, we need to move the group back to the reference group
+                    // and set it to visible
+                    this.movingLock(() => moveGroupWithoutDestroying({
+                        from: group,
+                        to: referenceGroup,
+                    }));
+                    if (!referenceGroup.api.isVisible) {
+                        referenceGroup.api.setVisible(true);
+                    }
+                    return false;
                 }
+                const gready = document.createElement('div');
+                gready.className = 'dv-overlay-render-container';
+                const overlayRenderContainer = new OverlayRenderContainer(gready, this);
                 group.model.renderContainer = overlayRenderContainer;
                 group.layout(_window.window.innerWidth, _window.window.innerHeight);
                 let floatingBox;
@@ -8623,7 +8659,7 @@
                 return true;
             })
                 .catch((err) => {
-                console.error('dockview: failed to create popout window', err);
+                console.error('dockview: failed to create popout.', err);
                 return false;
             });
         }
@@ -8830,7 +8866,12 @@
                 }
             }
             this.updateDropTargetModel(options);
+            const oldDisableDnd = this.options.disableDnd;
             this._options = Object.assign(Object.assign({}, this.options), options);
+            const newDisableDnd = this.options.disableDnd;
+            if (oldDisableDnd !== newDisableDnd) {
+                this.updateDragAndDropState();
+            }
             if ('theme' in options) {
                 this.updateTheme();
             }
@@ -8845,6 +8886,12 @@
                 }
             }
         }
+        updateDragAndDropState() {
+            // Update draggable state for all tabs and void containers
+            for (const group of this.groups) {
+                group.model.updateDragAndDropState();
+            }
+        }
         focus() {
             var _a;
             (_a = this.activeGroup) === null || _a === void 0 ? void 0 : _a.focus();