dockview-core 4.2.4 → 4.3.0

package/dist/esm/api/component.api.d.ts

@@ -471,7 +471,7 @@ export declare class DockviewApi implements CommonApi<SerializedDockview> {
     /**
      * Get a group object given a `string` id. May return undefined.
      */
-    getGroup(id: string): DockviewGroupPanel | undefined;
+    getGroup(id: string): IDockviewGroupPanel | undefined;
     /**
      * Add a floating group
      */

package/dist/esm/dnd/droptarget.js

@@ -86,9 +86,9 @@ export class Droptarget extends CompositeDisposable {
             onDragOver: (e) => {
                 var _a, _b, _c, _d, _e, _f, _g;
                 Droptarget.ACTUAL_TARGET = this;
-                const overrideTraget = (_b = (_a = this.options).getOverrideTarget) === null || _b === void 0 ? void 0 : _b.call(_a);
+                const overrideTarget = (_b = (_a = this.options).getOverrideTarget) === null || _b === void 0 ? void 0 : _b.call(_a);
                 if (this._acceptedTargetZonesSet.size === 0) {
-                    if (overrideTraget) {
+                    if (overrideTarget) {
                         return;
                     }
                     this.removeDropTarget();
@@ -115,7 +115,7 @@ export class Droptarget extends CompositeDisposable {
                     return;
                 }
                 if (!this.options.canDisplayOverlay(e, quadrant)) {
-                    if (overrideTraget) {
+                    if (overrideTarget) {
                         return;
                     }
                     this.removeDropTarget();
@@ -135,7 +135,7 @@ export class Droptarget extends CompositeDisposable {
                     return;
                 }
                 this.markAsUsed(e);
-                if (overrideTraget) {
+                if (overrideTarget) {
                     //
                 }
                 else if (!this.targetElement) {

package/dist/esm/dnd/ghost.js

@@ -3,6 +3,8 @@ export function addGhostImage(dataTransfer, ghostElement, options) {
     var _a, _b;
     // class dockview provides to force ghost image to be drawn on a different layer and prevent weird rendering issues
     addClasses(ghostElement, 'dv-dragged');
+    // move the element off-screen initially otherwise it may in some cases be rendered at (0,0) momentarily
+    ghostElement.style.top = '-9999px';
     document.body.appendChild(ghostElement);
     dataTransfer.setDragImage(ghostElement, (_a = options === null || options === void 0 ? void 0 : options.x) !== null && _a !== void 0 ? _a : 0, (_b = options === null || options === void 0 ? void 0 : options.y) !== null && _b !== void 0 ? _b : 0);
     setTimeout(() => {

package/dist/esm/dockview/components/titlebar/voidContainer.d.ts

@@ -7,7 +7,7 @@ export declare class VoidContainer extends CompositeDisposable {
     private readonly accessor;
     private readonly group;
     private readonly _element;
-    private readonly dropTraget;
+    private readonly dropTarget;
     private readonly _onDrop;
     readonly onDrop: Event<DroptargetEvent>;
     private readonly _onDragStart;

package/dist/esm/dockview/components/titlebar/voidContainer.js

@@ -22,7 +22,7 @@ export class VoidContainer extends CompositeDisposable {
             this.accessor.doSetGroupActive(this.group);
         }));
         const handler = new GroupDragHandler(this._element, accessor, group);
-        this.dropTraget = new Droptarget(this._element, {
+        this.dropTarget = new Droptarget(this._element, {
             acceptedTargetZones: ['center'],
             canDisplayOverlay: (event, position) => {
                 const data = getPanelData();
@@ -33,11 +33,11 @@ export class VoidContainer extends CompositeDisposable {
             },
             getOverrideTarget: () => { var _a; return (_a = group.model.dropTargetContainer) === null || _a === void 0 ? void 0 : _a.model; },
         });
-        this.onWillShowOverlay = this.dropTraget.onWillShowOverlay;
+        this.onWillShowOverlay = this.dropTarget.onWillShowOverlay;
         this.addDisposables(handler, handler.onDragStart((event) => {
             this._onDragStart.fire(event);
-        }), this.dropTraget.onDrop((event) => {
+        }), this.dropTarget.onDrop((event) => {
             this._onDrop.fire(event);
-        }), this.dropTraget);
+        }), this.dropTarget);
     }
 }

package/dist/esm/dockview/dockviewComponent.d.ts

@@ -27,6 +27,7 @@ export interface DockviewPopoutGroupOptions {
      * Defaults to `/popout.html` if not provided
      */
     popoutUrl?: string;
+    referenceGroup?: DockviewGroupPanel;
     onDidOpen?: (event: {
         id: string;
         window: Window;

package/dist/esm/dockview/dockviewComponent.js

@@ -326,9 +326,11 @@ export class DockviewComponent extends BaseGrid {
             const gready = document.createElement('div');
             gready.className = 'dv-overlay-render-container';
             const overlayRenderContainer = new OverlayRenderContainer(gready, this);
-            const referenceGroup = itemToPopout instanceof DockviewPanel
-                ? itemToPopout.group
-                : itemToPopout;
+            const referenceGroup = (options === null || options === void 0 ? void 0 : options.referenceGroup)
+                ? options.referenceGroup
+                : itemToPopout instanceof DockviewPanel
+                    ? itemToPopout.group
+                    : itemToPopout;
             const referenceLocation = itemToPopout.api.location.type;
             /**
              * The group that is being added doesn't already exist within the DOM, the most likely occurance
@@ -818,7 +820,7 @@ export class DockviewComponent extends BaseGrid {
         return result;
     }
     fromJSON(data) {
-        var _a, _b, _c;
+        var _a, _b;
         this.clear();
         if (typeof data !== 'object' || data === null) {
             throw new Error('serialized layout must be a non-null object');
@@ -890,12 +892,11 @@ export class DockviewComponent extends BaseGrid {
             for (const serializedPopoutGroup of serializedPopoutGroups) {
                 const { data, position, gridReferenceGroup, url } = serializedPopoutGroup;
                 const group = createGroupFromSerializedState(data);
-                this.addPopoutGroup((_c = (gridReferenceGroup
-                    ? this.getPanel(gridReferenceGroup)
-                    : undefined)) !== null && _c !== void 0 ? _c : group, {
+                this.addPopoutGroup(group, {
                     position: position !== null && position !== void 0 ? position : undefined,
-                    overridePopoutGroup: gridReferenceGroup
-                        ? group
+                    overridePopoutGroup: gridReferenceGroup ? group : undefined,
+                    referenceGroup: gridReferenceGroup
+                        ? this.getPanel(gridReferenceGroup)
                         : undefined,
                     popoutUrl: url,
                 });

package/dist/esm/dom.js

@@ -317,9 +317,7 @@ export function onDidWindowResizeEnd(element, cb) {
 export function shiftAbsoluteElementIntoView(element, root, options = { buffer: 10 }) {
     const buffer = options.buffer;
     const rect = element.getBoundingClientRect();
-    const rootRect = element.getBoundingClientRect();
-    const viewportWidth = root.clientWidth;
-    const viewportHeight = root.clientHeight;
+    const rootRect = root.getBoundingClientRect();
     let translateX = 0;
     let translateY = 0;
     const left = rect.left - rootRect.left;
@@ -330,15 +328,15 @@ export function shiftAbsoluteElementIntoView(element, root, options = { buffer:
     if (left < buffer) {
         translateX = buffer - left;
     }
-    else if (right > viewportWidth - buffer) {
-        translateX = viewportWidth - right - buffer;
+    else if (right > buffer) {
+        translateX = -buffer - right;
     }
     // Check vertical overflow
     if (top < buffer) {
         translateY = buffer - top;
     }
-    else if (bottom > viewportHeight - buffer) {
-        translateY = viewportHeight - bottom - buffer;
+    else if (bottom > buffer) {
+        translateY = -bottom - buffer;
     }
     // Apply the translation if needed
     if (translateX !== 0 || translateY !== 0) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dockview-core",
-  "version": "4.2.4",
+  "version": "4.3.0",
   "description": "Zero dependency layout manager supporting tabs, grids and splitviews",
   "keywords": [
     "splitview",