dockview-core 4.0.0 → 4.1.0

package/dist/esm/paneview/paneviewPanel.js

@@ -51,26 +51,25 @@ export class PaneviewPanel extends BasePanelView {
         this._headerVisible = value;
         this.header.style.display = value ? '' : 'none';
     }
-    constructor(id, component, headerComponent, orientation, isExpanded, isHeaderVisible) {
-        super(id, component, new PaneviewPanelApiImpl(id, component));
-        this.headerComponent = headerComponent;
+    constructor(options) {
+        super(options.id, options.component, new PaneviewPanelApiImpl(options.id, options.component));
         this._onDidChangeExpansionState = new Emitter({ replay: true });
         this.onDidChangeExpansionState = this._onDidChangeExpansionState.event;
         this._onDidChange = new Emitter();
         this.onDidChange = this._onDidChange.event;
-        this.headerSize = 22;
         this._orthogonalSize = 0;
         this._size = 0;
-        this._minimumBodySize = 100;
-        this._maximumBodySize = Number.POSITIVE_INFINITY;
         this._isExpanded = false;
-        this.expandedSize = 0;
         this.api.pane = this; // TODO cannot use 'this' before 'super'
         this.api.initialize(this);
-        this._isExpanded = isExpanded;
-        this._headerVisible = isHeaderVisible;
+        this.headerSize = options.headerSize;
+        this.headerComponent = options.headerComponent;
+        this._minimumBodySize = options.minimumBodySize;
+        this._maximumBodySize = options.maximumBodySize;
+        this._isExpanded = options.isExpanded;
+        this._headerVisible = options.isHeaderVisible;
         this._onDidChangeExpansionState.fire(this.isExpanded()); // initialize value
-        this._orientation = orientation;
+        this._orientation = options.orientation;
         this.element.classList.add('dv-pane');
         this.addDisposables(this.api.onWillVisibilityChange((event) => {
             const { isVisible } = event;
@@ -137,9 +136,6 @@ export class PaneviewPanel extends BasePanelView {
         const [width, height] = this.orientation === Orientation.HORIZONTAL
             ? [size, orthogonalSize]
             : [orthogonalSize, size];
-        if (this.isExpanded()) {
-            this.expandedSize = width;
-        }
         super.layout(width, height);
     }
     init(parameters) {

package/dist/esm/popoutWindow.js

@@ -8,7 +8,7 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
     });
 };
 import { addStyles } from './dom';
-import { Emitter, addDisposableWindowListener } from './events';
+import { Emitter, addDisposableListener } from './events';
 import { CompositeDisposable, Disposable } from './lifecycle';
 export class PopoutWindow extends CompositeDisposable {
     get window() {
@@ -83,7 +83,7 @@ export class PopoutWindow extends CompositeDisposable {
             this._window = { value: externalWindow, disposable };
             disposable.addDisposables(Disposable.from(() => {
                 externalWindow.close();
-            }), addDisposableWindowListener(window, 'beforeunload', () => {
+            }), addDisposableListener(window, 'beforeunload', () => {
                 /**
                  * before the main window closes we should close this popup too
                  * to be good citizens
@@ -118,7 +118,7 @@ export class PopoutWindow extends CompositeDisposable {
                          * beforeunload must be registered after load for reasons I could not determine
                          * otherwise the beforeunload event will not fire when the window is closed
                          */
-                        addDisposableWindowListener(externalWindow, 'beforeunload', () => {
+                        addDisposableListener(externalWindow, 'beforeunload', () => {
                             /**
                              * @see https://developer.mozilla.org/en-US/docs/Web/API/Window/beforeunload_event
                              */

package/dist/esm/splitview/splitviewComponent.js

@@ -23,6 +23,9 @@ export class SplitviewComponent extends Resizable {
         return this._splitview;
     }
     set splitview(value) {
+        if (this._splitview) {
+            this._splitview.dispose();
+        }
         this._splitview = value;
         this._splitviewChangeDisposable.value = new CompositeDisposable(this._splitview.onDidSashEnd(() => {
             this._onDidLayoutChange.fire(undefined);

package/dist/styles/dockview.css

@@ -1,6 +1,7 @@
 .dv-scrollable {
   position: relative;
   overflow: hidden;
+  width: 100%;
 }
 .dv-scrollable .dv-scrollbar-horizontal {
   position: absolute;
@@ -1104,13 +1105,7 @@
   /* Track */
   /* Handle */
 }
-.dv-tabs-container.dv-horizontal .dv-tabs-container .dv-tab:last-child {
-  margin-right: 0;
-}
-.dv-tabs-container.dv-horizontal .dv-tabs-container .dv-tab:not(:nth-last-child(1)) {
-  margin-left: 0;
-}
-.dv-tabs-container.dv-horizontal .dv-tabs-container .dv-tab:not(:first-child)::before {
+.dv-tabs-container.dv-horizontal .dv-tab:not(:first-child)::before {
   content: " ";
   position: absolute;
   top: 0;
@@ -1172,6 +1167,7 @@
 }
 .dv-tabs-and-actions-container.dv-single-tab.dv-full-width-single-tab .dv-tabs-container .dv-tab {
   flex-grow: 1;
+  padding: 0px;
 }
 .dv-tabs-and-actions-container.dv-single-tab.dv-full-width-single-tab .dv-void-container {
   flex-grow: 0;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dockview-core",
-  "version": "4.0.0",
+  "version": "4.1.0",
   "description": "Zero dependency layout manager supporting tabs, grids and splitviews",
   "keywords": [
     "splitview",