dockview-core 3.0.2 → 3.1.1

package/dist/esm/api/dockviewGroupPanelApi.d.ts

@@ -31,11 +31,10 @@ export interface DockviewGroupPanelFloatingChangeEvent {
 }
 export declare class DockviewGroupPanelApiImpl extends GridviewPanelApiImpl {
     private readonly accessor;
-    private readonly _mutableDisposable;
     private _group;
     readonly _onDidLocationChange: Emitter<DockviewGroupPanelFloatingChangeEvent>;
     readonly onDidLocationChange: Event<DockviewGroupPanelFloatingChangeEvent>;
-    private readonly _onDidActivePanelChange;
+    readonly _onDidActivePanelChange: Emitter<DockviewGroupChangeEvent>;
     readonly onDidActivePanelChange: Event<DockviewGroupChangeEvent>;
     get location(): DockviewGroupLocation;
     constructor(id: string, accessor: DockviewComponent);

package/dist/esm/api/dockviewGroupPanelApi.js

@@ -1,6 +1,5 @@
 import { positionToDirection } from '../dnd/droptarget';
 import { Emitter } from '../events';
-import { MutableDisposable } from '../lifecycle';
 import { GridviewPanelApiImpl } from './gridviewPanelApi';
 const NOT_INITIALIZED_MESSAGE = 'dockview: DockviewGroupPanelApiImpl not initialized';
 export class DockviewGroupPanelApiImpl extends GridviewPanelApiImpl {
@@ -13,12 +12,11 @@ export class DockviewGroupPanelApiImpl extends GridviewPanelApiImpl {
     constructor(id, accessor) {
         super(id, '__dockviewgroup__');
         this.accessor = accessor;
-        this._mutableDisposable = new MutableDisposable();
         this._onDidLocationChange = new Emitter();
         this.onDidLocationChange = this._onDidLocationChange.event;
         this._onDidActivePanelChange = new Emitter();
         this.onDidActivePanelChange = this._onDidActivePanelChange.event;
-        this.addDisposables(this._onDidLocationChange, this._onDidActivePanelChange, this._mutableDisposable);
+        this.addDisposables(this._onDidLocationChange, this._onDidActivePanelChange);
     }
     close() {
         if (!this._group) {
@@ -76,19 +74,6 @@ export class DockviewGroupPanelApiImpl extends GridviewPanelApiImpl {
         }
     }
     initialize(group) {
-        /**
-         * TODO: Annoying initialization order caveat, find a better way to initialize and avoid needing null checks
-         *
-         * Due to the order on initialization we know that the model isn't defined until later in the same stack-frame of setup.
-         * By queuing a microtask we can ensure the setup is completed within the same stack-frame, but after everything else has
-         * finished ensuring the `model` is defined.
-         */
         this._group = group;
-        queueMicrotask(() => {
-            this._mutableDisposable.value =
-                this._group.model.onDidActivePanelChange((event) => {
-                    this._onDidActivePanelChange.fire(event);
-                });
-        });
     }
 }

package/dist/esm/dockview/components/tab/defaultTab.js

@@ -16,9 +16,6 @@ export class DefaultTab extends CompositeDisposable {
         this.action.appendChild(createCloseButton());
         this._element.appendChild(this._content);
         this._element.appendChild(this.action);
-        this.addDisposables(addDisposableListener(this.action, 'pointerdown', (ev) => {
-            ev.preventDefault();
-        }));
         this.render();
     }
     init(params) {

package/dist/esm/dockview/components/tab/tab.d.ts

@@ -12,8 +12,8 @@ export declare class Tab extends CompositeDisposable {
     private readonly _element;
     private readonly dropTarget;
     private content;
-    private readonly _onChanged;
-    readonly onChanged: Event<MouseEvent>;
+    private readonly _onPointDown;
+    readonly onPointerDown: Event<MouseEvent>;
     private readonly _onDropped;
     readonly onDrop: Event<DroptargetEvent>;
     private readonly _onDragStart;

package/dist/esm/dockview/components/tab/tab.js

@@ -31,8 +31,8 @@ export class Tab extends CompositeDisposable {
         this.accessor = accessor;
         this.group = group;
         this.content = undefined;
-        this._onChanged = new Emitter();
-        this.onChanged = this._onChanged.event;
+        this._onPointDown = new Emitter();
+        this.onPointerDown = this._onPointDown.event;
         this._onDropped = new Emitter();
         this.onDrop = this._onDropped.event;
         this._onDragStart = new Emitter();
@@ -62,13 +62,10 @@ export class Tab extends CompositeDisposable {
             },
         });
         this.onWillShowOverlay = this.dropTarget.onWillShowOverlay;
-        this.addDisposables(this._onChanged, this._onDropped, this._onDragStart, dragHandler.onDragStart((event) => {
+        this.addDisposables(this._onPointDown, this._onDropped, this._onDragStart, dragHandler.onDragStart((event) => {
             this._onDragStart.fire(event);
         }), dragHandler, addDisposableListener(this._element, 'pointerdown', (event) => {
-            if (event.defaultPrevented) {
-                return;
-            }
-            this._onChanged.fire(event);
+            this._onPointDown.fire(event);
         }), this.dropTarget.onDrop((event) => {
             this._onDropped.fire(event);
         }), this.dropTarget);

package/dist/esm/dockview/components/titlebar/tabsContainer.js

@@ -156,6 +156,9 @@ export class TabsContainer extends CompositeDisposable {
     delete(id) {
         const index = this.tabs.findIndex((tab) => tab.value.panel.id === id);
         const tabToRemove = this.tabs.splice(index, 1)[0];
+        if (!tabToRemove) {
+            throw new Error(`dockview: Tab not found`);
+        }
         const { value, disposable } = tabToRemove;
         disposable.dispose();
         value.dispose();
@@ -176,7 +179,10 @@ export class TabsContainer extends CompositeDisposable {
         tab.setContent(panel.view.tab);
         const disposable = new CompositeDisposable(tab.onDragStart((event) => {
             this._onTabDragStart.fire({ nativeEvent: event, panel });
-        }), tab.onChanged((event) => {
+        }), tab.onPointerDown((event) => {
+            if (event.defaultPrevented) {
+                return;
+            }
             const isFloatingGroupsEnabled = !this.accessor.options.disableFloatingGroups;
             const isFloatingWithOnePanel = this.group.api.location.type === 'floating' &&
                 this.size === 1;
@@ -194,12 +200,12 @@ export class TabsContainer extends CompositeDisposable {
                 });
                 return;
             }
-            const isLeftClick = event.button === 0;
-            if (!isLeftClick || event.defaultPrevented) {
-                return;
-            }
-            if (this.group.activePanel !== panel) {
-                this.group.model.openPanel(panel);
+            switch (event.button) {
+                case 0: // left click or touch
+                    if (this.group.activePanel !== panel) {
+                        this.group.model.openPanel(panel);
+                    }
+                    break;
             }
         }), tab.onDrop((event) => {
             this._onDrop.fire({

package/dist/esm/dockview/dockviewComponent.js

@@ -412,6 +412,9 @@ export class DockviewComponent extends BaseGrid {
             addDisposableWindowListener(_window.window, 'resize', () => {
                 group.layout(_window.window.innerWidth, _window.window.innerHeight);
             }), overlayRenderContainer, Disposable.from(() => {
+                if (this.isDisposed) {
+                    return; // cleanup may run after instance is disposed
+                }
                 if (isGroupAddedToDom &&
                     this.getPanel(referenceGroup.id)) {
                     this.movingLock(() => moveGroupWithoutDestroying({

package/dist/esm/dockview/dockviewGroupPanel.js

@@ -67,6 +67,9 @@ export class DockviewGroupPanel extends GridviewPanel {
         }, new DockviewGroupPanelApiImpl(id, accessor));
         this.api.initialize(this); // cannot use 'this' after after 'super' call
         this._model = new DockviewGroupPanelModel(this.element, accessor, id, options, this);
+        this.addDisposables(this.model.onDidActivePanelChange((event) => {
+            this.api._onDidActivePanelChange.fire(event);
+        }));
     }
     focus() {
         if (!this.api.isActive) {

package/dist/styles/dockview.css

@@ -243,7 +243,7 @@
 .dockview-theme-replit .dv-groupview.dv-inactive-group {
   border: 1px solid transparent;
 }
-.dockview-theme-replit .vertical > .sash-container > .sash:not(.disabled)::after {
+.dockview-theme-replit .dv-vertical > .dv-sash-container > .dv-sash:not(.disabled)::after {
   content: "";
   height: 4px;
   width: 40px;
@@ -254,7 +254,7 @@
   background-color: var(--dv-separator-handle-background-color);
   position: absolute;
 }
-.dockview-theme-replit .vertical > .sash-container > .sash:not(.disabled):hover::after {
+.dockview-theme-replit .dv-vertical > .dv-sash-container > .dv-sash:not(.disabled):hover::after {
   background-color: var(--dv-separator-handle-hover-background-color);
 }
 .dockview-theme-replit .dv-horizontal > .dv-sash-container > .dv-sash:not(.disabled)::after {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dockview-core",
-  "version": "3.0.2",
+  "version": "3.1.1",
   "description": "Zero dependency layout manager supporting tabs, grids and splitviews",
   "keywords": [
     "splitview",