dockview-core 3.0.1 → 3.1.0

package/dist/cjs/api/dockviewGroupPanelApi.d.ts

@@ -31,11 +31,10 @@ export interface DockviewGroupPanelFloatingChangeEvent {
 }
 export declare class DockviewGroupPanelApiImpl extends GridviewPanelApiImpl {
     private readonly accessor;
-    private readonly _mutableDisposable;
     private _group;
     readonly _onDidLocationChange: Emitter<DockviewGroupPanelFloatingChangeEvent>;
     readonly onDidLocationChange: Event<DockviewGroupPanelFloatingChangeEvent>;
-    private readonly _onDidActivePanelChange;
+    readonly _onDidActivePanelChange: Emitter<DockviewGroupChangeEvent>;
     readonly onDidActivePanelChange: Event<DockviewGroupChangeEvent>;
     get location(): DockviewGroupLocation;
     constructor(id: string, accessor: DockviewComponent);

package/dist/cjs/api/dockviewGroupPanelApi.js

@@ -18,7 +18,6 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.DockviewGroupPanelApiImpl = void 0;
 var droptarget_1 = require("../dnd/droptarget");
 var events_1 = require("../events");
-var lifecycle_1 = require("../lifecycle");
 var gridviewPanelApi_1 = require("./gridviewPanelApi");
 var NOT_INITIALIZED_MESSAGE = 'dockview: DockviewGroupPanelApiImpl not initialized';
 var DockviewGroupPanelApiImpl = /** @class */ (function (_super) {
@@ -26,12 +25,11 @@ var DockviewGroupPanelApiImpl = /** @class */ (function (_super) {
     function DockviewGroupPanelApiImpl(id, accessor) {
         var _this = _super.call(this, id, '__dockviewgroup__') || this;
         _this.accessor = accessor;
-        _this._mutableDisposable = new lifecycle_1.MutableDisposable();
         _this._onDidLocationChange = new events_1.Emitter();
         _this.onDidLocationChange = _this._onDidLocationChange.event;
         _this._onDidActivePanelChange = new events_1.Emitter();
         _this.onDidActivePanelChange = _this._onDidActivePanelChange.event;
-        _this.addDisposables(_this._onDidLocationChange, _this._onDidActivePanelChange, _this._mutableDisposable);
+        _this.addDisposables(_this._onDidLocationChange, _this._onDidActivePanelChange);
         return _this;
     }
     Object.defineProperty(DockviewGroupPanelApiImpl.prototype, "location", {
@@ -100,21 +98,7 @@ var DockviewGroupPanelApiImpl = /** @class */ (function (_super) {
         }
     };
     DockviewGroupPanelApiImpl.prototype.initialize = function (group) {
-        /**
-         * TODO: Annoying initialization order caveat, find a better way to initialize and avoid needing null checks
-         *
-         * Due to the order on initialization we know that the model isn't defined until later in the same stack-frame of setup.
-         * By queuing a microtask we can ensure the setup is completed within the same stack-frame, but after everything else has
-         * finished ensuring the `model` is defined.
-         */
-        var _this = this;
         this._group = group;
-        queueMicrotask(function () {
-            _this._mutableDisposable.value =
-                _this._group.model.onDidActivePanelChange(function (event) {
-                    _this._onDidActivePanelChange.fire(event);
-                });
-        });
     };
     return DockviewGroupPanelApiImpl;
 }(gridviewPanelApi_1.GridviewPanelApiImpl));

package/dist/cjs/dockview/components/tab/defaultTab.js

@@ -32,9 +32,6 @@ var DefaultTab = /** @class */ (function (_super) {
         _this.action.appendChild((0, svg_1.createCloseButton)());
         _this._element.appendChild(_this._content);
         _this._element.appendChild(_this.action);
-        _this.addDisposables((0, events_1.addDisposableListener)(_this.action, 'pointerdown', function (ev) {
-            ev.preventDefault();
-        }));
         _this.render();
         return _this;
     }

package/dist/cjs/dockview/components/titlebar/tabsContainer.js

@@ -228,6 +228,9 @@ var TabsContainer = /** @class */ (function (_super) {
     TabsContainer.prototype.delete = function (id) {
         var index = this.tabs.findIndex(function (tab) { return tab.value.panel.id === id; });
         var tabToRemove = this.tabs.splice(index, 1)[0];
+        if (!tabToRemove) {
+            throw new Error("dockview: Tab not found");
+        }
         var value = tabToRemove.value, disposable = tabToRemove.disposable;
         disposable.dispose();
         value.dispose();
@@ -251,6 +254,9 @@ var TabsContainer = /** @class */ (function (_super) {
         var disposable = new lifecycle_1.CompositeDisposable(tab.onDragStart(function (event) {
             _this._onTabDragStart.fire({ nativeEvent: event, panel: panel });
         }), tab.onChanged(function (event) {
+            if (event.defaultPrevented) {
+                return;
+            }
             var isFloatingGroupsEnabled = !_this.accessor.options.disableFloatingGroups;
             var isFloatingWithOnePanel = _this.group.api.location.type === 'floating' &&
                 _this.size === 1;
@@ -268,12 +274,15 @@ var TabsContainer = /** @class */ (function (_super) {
                 });
                 return;
             }
-            var isLeftClick = event.button === 0;
-            if (!isLeftClick || event.defaultPrevented) {
-                return;
-            }
-            if (_this.group.activePanel !== panel) {
-                _this.group.model.openPanel(panel);
+            switch (event.button) {
+                case 0: // left click or touch
+                    if (_this.group.activePanel !== panel) {
+                        _this.group.model.openPanel(panel);
+                    }
+                    break;
+                case 1: // middle click
+                    panel.api.close();
+                    break;
             }
         }), tab.onDrop(function (event) {
             _this._onDrop.fire({

package/dist/cjs/dockview/dockviewComponent.d.ts

@@ -207,7 +207,7 @@ export declare class DockviewComponent extends BaseGrid<DockviewGroupPanel> impl
     get api(): DockviewApi;
     get gap(): number;
     get floatingGroups(): DockviewFloatingGroupPanel[];
-    constructor(parentElement: HTMLElement, options: DockviewComponentOptions);
+    constructor(container: HTMLElement, options: DockviewComponentOptions);
     setVisible(panel: DockviewGroupPanel, visible: boolean): void;
     addPopoutGroup(itemToPopout: DockviewPanel | DockviewGroupPanel, options?: DockviewPopoutGroupOptions): Promise<boolean>;
     addFloatingGroup(item: DockviewPanel | DockviewGroupPanel, options?: FloatingGroupOptionsInternal): void;

package/dist/cjs/dockview/dockviewComponent.js

@@ -107,9 +107,9 @@ function moveGroupWithoutDestroying(options) {
 }
 var DockviewComponent = /** @class */ (function (_super) {
     __extends(DockviewComponent, _super);
-    function DockviewComponent(parentElement, options) {
+    function DockviewComponent(container, options) {
         var _a;
-        var _this = _super.call(this, parentElement, {
+        var _this = _super.call(this, container, {
             proportionalLayout: true,
             orientation: splitview_1.Orientation.HORIZONTAL,
             styles: options.hideBorders
@@ -541,6 +541,9 @@ var DockviewComponent = /** @class */ (function (_super) {
             (0, events_1.addDisposableWindowListener)(_window.window, 'resize', function () {
                 group.layout(_window.window.innerWidth, _window.window.innerHeight);
             }), overlayRenderContainer, lifecycle_1.Disposable.from(function () {
+                if (_this.isDisposed) {
+                    return; // cleanup may run after instance is disposed
+                }
                 if (isGroupAddedToDom &&
                     _this.getPanel(referenceGroup.id)) {
                     _this.movingLock(function () {
@@ -562,6 +565,16 @@ var DockviewComponent = /** @class */ (function (_super) {
                     group.model.renderContainer =
                         _this.overlayRenderContainer;
                     returnedGroup = group;
+                    var alreadyRemoved = !_this._popoutGroups.find(function (p) { return p.popoutGroup === group; });
+                    if (alreadyRemoved) {
+                        /**
+                         * If this popout group was explicitly removed then we shouldn't run the additional
+                         * steps. To tell if the running of this disposable is the result of this popout group
+                         * being explicitly removed we can check if this popout group is still referenced in
+                         * the `this._popoutGroups` list.
+                         */
+                        return;
+                    }
                     if (floatingBox) {
                         _this.addFloatingGroup(group, {
                             height: floatingBox.height,

package/dist/cjs/dockview/dockviewGroupPanel.js

@@ -33,6 +33,9 @@ var DockviewGroupPanel = /** @class */ (function (_super) {
         }, new dockviewGroupPanelApi_1.DockviewGroupPanelApiImpl(id, accessor)) || this;
         _this.api.initialize(_this); // cannot use 'this' after after 'super' call
         _this._model = new dockviewGroupPanelModel_1.DockviewGroupPanelModel(_this.element, accessor, id, options, _this);
+        _this.addDisposables(_this.model.onDidActivePanelChange(function (event) {
+            _this.api._onDidActivePanelChange.fire(event);
+        }));
         return _this;
     }
     Object.defineProperty(DockviewGroupPanel.prototype, "minimumWidth", {

package/dist/cjs/gridview/baseComponentGridview.d.ts

@@ -81,7 +81,7 @@ export declare abstract class BaseGrid<T extends IGridPanelView> extends Resizab
     get activeGroup(): T | undefined;
     get locked(): boolean;
     set locked(value: boolean);
-    constructor(parentElement: HTMLElement, options: BaseGridOptions);
+    constructor(container: HTMLElement, options: BaseGridOptions);
     abstract toJSON(): object;
     abstract fromJSON(data: any): void;
     abstract clear(): void;

package/dist/cjs/gridview/baseComponentGridview.js

@@ -53,9 +53,9 @@ function toTarget(direction) {
 exports.toTarget = toTarget;
 var BaseGrid = /** @class */ (function (_super) {
     __extends(BaseGrid, _super);
-    function BaseGrid(parentElement, options) {
+    function BaseGrid(container, options) {
         var _a;
-        var _this = _super.call(this, parentElement, options.disableAutoResizing) || this;
+        var _this = _super.call(this, document.createElement('div'), options.disableAutoResizing) || this;
         _this._id = nextLayoutId.next();
         _this._groups = new Map();
         _this._onDidRemove = new events_1.Emitter();
@@ -74,6 +74,8 @@ var BaseGrid = /** @class */ (function (_super) {
         _this.element.style.width = '100%';
         _this._classNames = new dom_1.Classnames(_this.element);
         _this._classNames.setClassNames((_a = options.className) !== null && _a !== void 0 ? _a : '');
+        // the container is owned by the third-party, do not modify/delete it
+        container.appendChild(_this.element);
         _this.gridview = new gridview_1.Gridview(!!options.proportionalLayout, options.styles, options.orientation, options.locked, options.margin);
         _this.gridview.locked = !!options.locked;
         _this.element.appendChild(_this.gridview.element);

package/dist/cjs/gridview/gridviewComponent.d.ts

@@ -61,7 +61,7 @@ export declare class GridviewComponent extends BaseGrid<GridviewPanel> implement
     get options(): GridviewComponentOptions;
     get deserializer(): IPanelDeserializer | undefined;
     set deserializer(value: IPanelDeserializer | undefined);
-    constructor(parentElement: HTMLElement, options: GridviewComponentOptions);
+    constructor(container: HTMLElement, options: GridviewComponentOptions);
     updateOptions(options: Partial<GridviewComponentOptions>): void;
     removePanel(panel: GridviewPanel): void;
     /**

package/dist/cjs/gridview/gridviewComponent.js

@@ -61,9 +61,9 @@ var baseComponentGridview_1 = require("./baseComponentGridview");
 var events_1 = require("../events");
 var GridviewComponent = /** @class */ (function (_super) {
     __extends(GridviewComponent, _super);
-    function GridviewComponent(parentElement, options) {
+    function GridviewComponent(container, options) {
         var _a;
-        var _this = _super.call(this, parentElement, {
+        var _this = _super.call(this, container, {
             proportionalLayout: (_a = options.proportionalLayout) !== null && _a !== void 0 ? _a : true,
             orientation: options.orientation,
             styles: options.hideBorders

package/dist/cjs/paneview/paneviewComponent.d.ts

@@ -110,7 +110,7 @@ export declare class PaneviewComponent extends Resizable implements IPaneviewCom
     get height(): number;
     get width(): number;
     get options(): PaneviewComponentOptions;
-    constructor(parentElement: HTMLElement, options: PaneviewComponentOptions);
+    constructor(container: HTMLElement, options: PaneviewComponentOptions);
     setVisible(panel: PaneviewPanel, visible: boolean): void;
     focus(): void;
     updateOptions(options: Partial<PaneviewComponentOptions>): void;

package/dist/cjs/paneview/paneviewComponent.js

@@ -83,9 +83,9 @@ var PaneFramework = /** @class */ (function (_super) {
 exports.PaneFramework = PaneFramework;
 var PaneviewComponent = /** @class */ (function (_super) {
     __extends(PaneviewComponent, _super);
-    function PaneviewComponent(parentElement, options) {
+    function PaneviewComponent(container, options) {
         var _a;
-        var _this = _super.call(this, parentElement, options.disableAutoResizing) || this;
+        var _this = _super.call(this, document.createElement('div'), options.disableAutoResizing) || this;
         _this._id = nextLayoutId.next();
         _this._disposable = new lifecycle_1.MutableDisposable();
         _this._viewDisposables = new Map();
@@ -101,9 +101,13 @@ var PaneviewComponent = /** @class */ (function (_super) {
         _this.onDidRemoveView = _this._onDidRemoveView.event;
         _this._onUnhandledDragOverEvent = new events_1.Emitter();
         _this.onUnhandledDragOverEvent = _this._onUnhandledDragOverEvent.event;
+        _this.element.style.height = '100%';
+        _this.element.style.width = '100%';
         _this.addDisposables(_this._onDidLayoutChange, _this._onDidLayoutfromJSON, _this._onDidDrop, _this._onDidAddView, _this._onDidRemoveView, _this._onUnhandledDragOverEvent);
         _this._classNames = new dom_1.Classnames(_this.element);
         _this._classNames.setClassNames((_a = options.className) !== null && _a !== void 0 ? _a : '');
+        // the container is owned by the third-party, do not modify/delete it
+        container.appendChild(_this.element);
         _this._options = options;
         _this.paneview = new paneview_1.Paneview(_this.element, {
             // only allow paneview in the vertical orientation for now

package/dist/cjs/splitview/splitview.d.ts

@@ -14,7 +14,7 @@ export interface ISplitviewStyles {
     separatorBorder: string;
 }
 export interface SplitViewOptions {
-    orientation: Orientation;
+    orientation?: Orientation;
     descriptor?: ISplitViewDescriptor;
     proportionalLayout?: boolean;
     styles?: ISplitviewStyles;

package/dist/cjs/splitview/splitview.js

@@ -79,7 +79,7 @@ var Sizing;
 var Splitview = /** @class */ (function () {
     function Splitview(container, options) {
         var _this = this;
-        var _a;
+        var _a, _b;
         this.container = container;
         this.viewItems = [];
         this.sashes = [];
@@ -201,9 +201,9 @@ var Splitview = /** @class */ (function () {
             //
             return delta;
         };
-        this._orientation = options.orientation;
+        this._orientation = (_a = options.orientation) !== null && _a !== void 0 ? _a : Orientation.VERTICAL;
         this.element = this.createContainer();
-        this.margin = (_a = options.margin) !== null && _a !== void 0 ? _a : 0;
+        this.margin = (_b = options.margin) !== null && _b !== void 0 ? _b : 0;
         this.proportionalLayout =
             options.proportionalLayout === undefined
                 ? true

package/dist/cjs/splitview/splitviewComponent.d.ts

@@ -83,7 +83,7 @@ export declare class SplitviewComponent extends Resizable implements ISplitviewC
     get maximumSize(): number;
     get height(): number;
     get width(): number;
-    constructor(parentElement: HTMLElement, options: SplitviewComponentOptions);
+    constructor(container: HTMLElement, options: SplitviewComponentOptions);
     updateOptions(options: Partial<SplitviewComponentOptions>): void;
     focus(): void;
     movePanel(from: number, to: number): void;

package/dist/cjs/splitview/splitviewComponent.js

@@ -64,9 +64,9 @@ var dom_1 = require("../dom");
  */
 var SplitviewComponent = /** @class */ (function (_super) {
     __extends(SplitviewComponent, _super);
-    function SplitviewComponent(parentElement, options) {
+    function SplitviewComponent(container, options) {
         var _a;
-        var _this = _super.call(this, parentElement, options.disableAutoResizing) || this;
+        var _this = _super.call(this, document.createElement('div'), options.disableAutoResizing) || this;
         _this._splitviewChangeDisposable = new lifecycle_1.MutableDisposable();
         _this._panels = new Map();
         _this._onDidLayoutfromJSON = new events_1.Emitter();
@@ -77,8 +77,12 @@ var SplitviewComponent = /** @class */ (function (_super) {
         _this.onDidRemoveView = _this._onDidRemoveView.event;
         _this._onDidLayoutChange = new events_1.Emitter();
         _this.onDidLayoutChange = _this._onDidLayoutChange.event;
+        _this.element.style.height = '100%';
+        _this.element.style.width = '100%';
         _this._classNames = new dom_1.Classnames(_this.element);
         _this._classNames.setClassNames((_a = options.className) !== null && _a !== void 0 ? _a : '');
+        // the container is owned by the third-party, do not modify/delete it
+        container.appendChild(_this.element);
         _this._options = options;
         _this.splitview = new splitview_1.Splitview(_this.element, options);
         _this.addDisposables(_this._onDidAddView, _this._onDidLayoutfromJSON, _this._onDidRemoveView, _this._onDidLayoutChange);