dockview-core 3.0.1 → 3.0.2

package/dist/esm/dockview/dockviewComponent.d.ts

@@ -207,7 +207,7 @@ export declare class DockviewComponent extends BaseGrid<DockviewGroupPanel> impl
     get api(): DockviewApi;
     get gap(): number;
     get floatingGroups(): DockviewFloatingGroupPanel[];
-    constructor(parentElement: HTMLElement, options: DockviewComponentOptions);
+    constructor(container: HTMLElement, options: DockviewComponentOptions);
     setVisible(panel: DockviewGroupPanel, visible: boolean): void;
     addPopoutGroup(itemToPopout: DockviewPanel | DockviewGroupPanel, options?: DockviewPopoutGroupOptions): Promise<boolean>;
     addFloatingGroup(item: DockviewPanel | DockviewGroupPanel, options?: FloatingGroupOptionsInternal): void;

package/dist/esm/dockview/dockviewComponent.js

@@ -73,9 +73,9 @@ export class DockviewComponent extends BaseGrid {
     get floatingGroups() {
         return this._floatingGroups;
     }
-    constructor(parentElement, options) {
+    constructor(container, options) {
         var _a;
-        super(parentElement, {
+        super(container, {
             proportionalLayout: true,
             orientation: Orientation.HORIZONTAL,
             styles: options.hideBorders
@@ -431,6 +431,16 @@ export class DockviewComponent extends BaseGrid {
                     group.model.renderContainer =
                         this.overlayRenderContainer;
                     returnedGroup = group;
+                    const alreadyRemoved = !this._popoutGroups.find((p) => p.popoutGroup === group);
+                    if (alreadyRemoved) {
+                        /**
+                         * If this popout group was explicitly removed then we shouldn't run the additional
+                         * steps. To tell if the running of this disposable is the result of this popout group
+                         * being explicitly removed we can check if this popout group is still referenced in
+                         * the `this._popoutGroups` list.
+                         */
+                        return;
+                    }
                     if (floatingBox) {
                         this.addFloatingGroup(group, {
                             height: floatingBox.height,

package/dist/esm/gridview/baseComponentGridview.d.ts

@@ -81,7 +81,7 @@ export declare abstract class BaseGrid<T extends IGridPanelView> extends Resizab
     get activeGroup(): T | undefined;
     get locked(): boolean;
     set locked(value: boolean);
-    constructor(parentElement: HTMLElement, options: BaseGridOptions);
+    constructor(container: HTMLElement, options: BaseGridOptions);
     abstract toJSON(): object;
     abstract fromJSON(data: any): void;
     abstract clear(): void;

package/dist/esm/gridview/baseComponentGridview.js

@@ -58,9 +58,9 @@ export class BaseGrid extends Resizable {
     set locked(value) {
         this.gridview.locked = value;
     }
-    constructor(parentElement, options) {
+    constructor(container, options) {
         var _a;
-        super(parentElement, options.disableAutoResizing);
+        super(document.createElement('div'), options.disableAutoResizing);
         this._id = nextLayoutId.next();
         this._groups = new Map();
         this._onDidRemove = new Emitter();
@@ -79,6 +79,8 @@ export class BaseGrid extends Resizable {
         this.element.style.width = '100%';
         this._classNames = new Classnames(this.element);
         this._classNames.setClassNames((_a = options.className) !== null && _a !== void 0 ? _a : '');
+        // the container is owned by the third-party, do not modify/delete it
+        container.appendChild(this.element);
         this.gridview = new Gridview(!!options.proportionalLayout, options.styles, options.orientation, options.locked, options.margin);
         this.gridview.locked = !!options.locked;
         this.element.appendChild(this.gridview.element);

package/dist/esm/gridview/gridviewComponent.d.ts

@@ -61,7 +61,7 @@ export declare class GridviewComponent extends BaseGrid<GridviewPanel> implement
     get options(): GridviewComponentOptions;
     get deserializer(): IPanelDeserializer | undefined;
     set deserializer(value: IPanelDeserializer | undefined);
-    constructor(parentElement: HTMLElement, options: GridviewComponentOptions);
+    constructor(container: HTMLElement, options: GridviewComponentOptions);
     updateOptions(options: Partial<GridviewComponentOptions>): void;
     removePanel(panel: GridviewPanel): void;
     /**

package/dist/esm/gridview/gridviewComponent.js

@@ -19,9 +19,9 @@ export class GridviewComponent extends BaseGrid {
     set deserializer(value) {
         this._deserializer = value;
     }
-    constructor(parentElement, options) {
+    constructor(container, options) {
         var _a;
-        super(parentElement, {
+        super(container, {
             proportionalLayout: (_a = options.proportionalLayout) !== null && _a !== void 0 ? _a : true,
             orientation: options.orientation,
             styles: options.hideBorders

package/dist/esm/paneview/paneviewComponent.d.ts

@@ -110,7 +110,7 @@ export declare class PaneviewComponent extends Resizable implements IPaneviewCom
     get height(): number;
     get width(): number;
     get options(): PaneviewComponentOptions;
-    constructor(parentElement: HTMLElement, options: PaneviewComponentOptions);
+    constructor(container: HTMLElement, options: PaneviewComponentOptions);
     setVisible(panel: PaneviewPanel, visible: boolean): void;
     focus(): void;
     updateOptions(options: Partial<PaneviewComponentOptions>): void;

package/dist/esm/paneview/paneviewComponent.js

@@ -56,9 +56,9 @@ export class PaneviewComponent extends Resizable {
     get options() {
         return this._options;
     }
-    constructor(parentElement, options) {
+    constructor(container, options) {
         var _a;
-        super(parentElement, options.disableAutoResizing);
+        super(document.createElement('div'), options.disableAutoResizing);
         this._id = nextLayoutId.next();
         this._disposable = new MutableDisposable();
         this._viewDisposables = new Map();
@@ -74,9 +74,13 @@ export class PaneviewComponent extends Resizable {
         this.onDidRemoveView = this._onDidRemoveView.event;
         this._onUnhandledDragOverEvent = new Emitter();
         this.onUnhandledDragOverEvent = this._onUnhandledDragOverEvent.event;
+        this.element.style.height = '100%';
+        this.element.style.width = '100%';
         this.addDisposables(this._onDidLayoutChange, this._onDidLayoutfromJSON, this._onDidDrop, this._onDidAddView, this._onDidRemoveView, this._onUnhandledDragOverEvent);
         this._classNames = new Classnames(this.element);
         this._classNames.setClassNames((_a = options.className) !== null && _a !== void 0 ? _a : '');
+        // the container is owned by the third-party, do not modify/delete it
+        container.appendChild(this.element);
         this._options = options;
         this.paneview = new Paneview(this.element, {
             // only allow paneview in the vertical orientation for now

package/dist/esm/splitview/splitview.d.ts

@@ -14,7 +14,7 @@ export interface ISplitviewStyles {
     separatorBorder: string;
 }
 export interface SplitViewOptions {
-    orientation: Orientation;
+    orientation?: Orientation;
     descriptor?: ISplitViewDescriptor;
     proportionalLayout?: boolean;
     styles?: ISplitviewStyles;

package/dist/esm/splitview/splitview.js

@@ -114,7 +114,7 @@ export class Splitview {
         this._margin = value;
     }
     constructor(container, options) {
-        var _a;
+        var _a, _b;
         this.container = container;
         this.viewItems = [];
         this.sashes = [];
@@ -212,9 +212,9 @@ export class Splitview {
             //
             return delta;
         };
-        this._orientation = options.orientation;
+        this._orientation = (_a = options.orientation) !== null && _a !== void 0 ? _a : Orientation.VERTICAL;
         this.element = this.createContainer();
-        this.margin = (_a = options.margin) !== null && _a !== void 0 ? _a : 0;
+        this.margin = (_b = options.margin) !== null && _b !== void 0 ? _b : 0;
         this.proportionalLayout =
             options.proportionalLayout === undefined
                 ? true

package/dist/esm/splitview/splitviewComponent.d.ts

@@ -83,7 +83,7 @@ export declare class SplitviewComponent extends Resizable implements ISplitviewC
     get maximumSize(): number;
     get height(): number;
     get width(): number;
-    constructor(parentElement: HTMLElement, options: SplitviewComponentOptions);
+    constructor(container: HTMLElement, options: SplitviewComponentOptions);
     updateOptions(options: Partial<SplitviewComponentOptions>): void;
     focus(): void;
     movePanel(from: number, to: number): void;

package/dist/esm/splitview/splitviewComponent.js

@@ -44,9 +44,9 @@ export class SplitviewComponent extends Resizable {
             ? this.splitview.size
             : this.splitview.orthogonalSize;
     }
-    constructor(parentElement, options) {
+    constructor(container, options) {
         var _a;
-        super(parentElement, options.disableAutoResizing);
+        super(document.createElement('div'), options.disableAutoResizing);
         this._splitviewChangeDisposable = new MutableDisposable();
         this._panels = new Map();
         this._onDidLayoutfromJSON = new Emitter();
@@ -57,8 +57,12 @@ export class SplitviewComponent extends Resizable {
         this.onDidRemoveView = this._onDidRemoveView.event;
         this._onDidLayoutChange = new Emitter();
         this.onDidLayoutChange = this._onDidLayoutChange.event;
+        this.element.style.height = '100%';
+        this.element.style.width = '100%';
         this._classNames = new Classnames(this.element);
         this._classNames.setClassNames((_a = options.className) !== null && _a !== void 0 ? _a : '');
+        // the container is owned by the third-party, do not modify/delete it
+        container.appendChild(this.element);
         this._options = options;
         this.splitview = new Splitview(this.element, options);
         this.addDisposables(this._onDidAddView, this._onDidLayoutfromJSON, this._onDidRemoveView, this._onDidLayoutChange);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dockview-core",
-  "version": "3.0.1",
+  "version": "3.0.2",
   "description": "Zero dependency layout manager supporting tabs, grids and splitviews",
   "keywords": [
     "splitview",