dockview-core 3.0.0 → 3.0.2

package/dist/cjs/dockview/dockviewComponent.d.ts

@@ -207,7 +207,7 @@ export declare class DockviewComponent extends BaseGrid<DockviewGroupPanel> impl
     get api(): DockviewApi;
     get gap(): number;
     get floatingGroups(): DockviewFloatingGroupPanel[];
-    constructor(parentElement: HTMLElement, options: DockviewComponentOptions);
+    constructor(container: HTMLElement, options: DockviewComponentOptions);
     setVisible(panel: DockviewGroupPanel, visible: boolean): void;
     addPopoutGroup(itemToPopout: DockviewPanel | DockviewGroupPanel, options?: DockviewPopoutGroupOptions): Promise<boolean>;
     addFloatingGroup(item: DockviewPanel | DockviewGroupPanel, options?: FloatingGroupOptionsInternal): void;

package/dist/cjs/dockview/dockviewComponent.js

@@ -107,9 +107,9 @@ function moveGroupWithoutDestroying(options) {
 }
 var DockviewComponent = /** @class */ (function (_super) {
     __extends(DockviewComponent, _super);
-    function DockviewComponent(parentElement, options) {
+    function DockviewComponent(container, options) {
         var _a;
-        var _this = _super.call(this, parentElement, {
+        var _this = _super.call(this, container, {
             proportionalLayout: true,
             orientation: splitview_1.Orientation.HORIZONTAL,
             styles: options.hideBorders
@@ -562,6 +562,16 @@ var DockviewComponent = /** @class */ (function (_super) {
                     group.model.renderContainer =
                         _this.overlayRenderContainer;
                     returnedGroup = group;
+                    var alreadyRemoved = !_this._popoutGroups.find(function (p) { return p.popoutGroup === group; });
+                    if (alreadyRemoved) {
+                        /**
+                         * If this popout group was explicitly removed then we shouldn't run the additional
+                         * steps. To tell if the running of this disposable is the result of this popout group
+                         * being explicitly removed we can check if this popout group is still referenced in
+                         * the `this._popoutGroups` list.
+                         */
+                        return;
+                    }
                     if (floatingBox) {
                         _this.addFloatingGroup(group, {
                             height: floatingBox.height,

package/dist/cjs/gridview/baseComponentGridview.d.ts

@@ -81,7 +81,7 @@ export declare abstract class BaseGrid<T extends IGridPanelView> extends Resizab
     get activeGroup(): T | undefined;
     get locked(): boolean;
     set locked(value: boolean);
-    constructor(parentElement: HTMLElement, options: BaseGridOptions);
+    constructor(container: HTMLElement, options: BaseGridOptions);
     abstract toJSON(): object;
     abstract fromJSON(data: any): void;
     abstract clear(): void;

package/dist/cjs/gridview/baseComponentGridview.js

@@ -53,7 +53,7 @@ function toTarget(direction) {
 exports.toTarget = toTarget;
 var BaseGrid = /** @class */ (function (_super) {
     __extends(BaseGrid, _super);
-    function BaseGrid(parentElement, options) {
+    function BaseGrid(container, options) {
         var _a;
         var _this = _super.call(this, document.createElement('div'), options.disableAutoResizing) || this;
         _this._id = nextLayoutId.next();
@@ -74,7 +74,8 @@ var BaseGrid = /** @class */ (function (_super) {
         _this.element.style.width = '100%';
         _this._classNames = new dom_1.Classnames(_this.element);
         _this._classNames.setClassNames((_a = options.className) !== null && _a !== void 0 ? _a : '');
-        parentElement.appendChild(_this.element);
+        // the container is owned by the third-party, do not modify/delete it
+        container.appendChild(_this.element);
         _this.gridview = new gridview_1.Gridview(!!options.proportionalLayout, options.styles, options.orientation, options.locked, options.margin);
         _this.gridview.locked = !!options.locked;
         _this.element.appendChild(_this.gridview.element);

package/dist/cjs/gridview/gridviewComponent.d.ts

@@ -61,7 +61,7 @@ export declare class GridviewComponent extends BaseGrid<GridviewPanel> implement
     get options(): GridviewComponentOptions;
     get deserializer(): IPanelDeserializer | undefined;
     set deserializer(value: IPanelDeserializer | undefined);
-    constructor(parentElement: HTMLElement, options: GridviewComponentOptions);
+    constructor(container: HTMLElement, options: GridviewComponentOptions);
     updateOptions(options: Partial<GridviewComponentOptions>): void;
     removePanel(panel: GridviewPanel): void;
     /**

package/dist/cjs/gridview/gridviewComponent.js

@@ -61,9 +61,9 @@ var baseComponentGridview_1 = require("./baseComponentGridview");
 var events_1 = require("../events");
 var GridviewComponent = /** @class */ (function (_super) {
     __extends(GridviewComponent, _super);
-    function GridviewComponent(parentElement, options) {
+    function GridviewComponent(container, options) {
         var _a;
-        var _this = _super.call(this, parentElement, {
+        var _this = _super.call(this, container, {
             proportionalLayout: (_a = options.proportionalLayout) !== null && _a !== void 0 ? _a : true,
             orientation: options.orientation,
             styles: options.hideBorders

package/dist/cjs/paneview/paneviewComponent.d.ts

@@ -110,7 +110,7 @@ export declare class PaneviewComponent extends Resizable implements IPaneviewCom
     get height(): number;
     get width(): number;
     get options(): PaneviewComponentOptions;
-    constructor(parentElement: HTMLElement, options: PaneviewComponentOptions);
+    constructor(container: HTMLElement, options: PaneviewComponentOptions);
     setVisible(panel: PaneviewPanel, visible: boolean): void;
     focus(): void;
     updateOptions(options: Partial<PaneviewComponentOptions>): void;

package/dist/cjs/paneview/paneviewComponent.js

@@ -83,9 +83,9 @@ var PaneFramework = /** @class */ (function (_super) {
 exports.PaneFramework = PaneFramework;
 var PaneviewComponent = /** @class */ (function (_super) {
     __extends(PaneviewComponent, _super);
-    function PaneviewComponent(parentElement, options) {
+    function PaneviewComponent(container, options) {
         var _a;
-        var _this = _super.call(this, parentElement, options.disableAutoResizing) || this;
+        var _this = _super.call(this, document.createElement('div'), options.disableAutoResizing) || this;
         _this._id = nextLayoutId.next();
         _this._disposable = new lifecycle_1.MutableDisposable();
         _this._viewDisposables = new Map();
@@ -101,9 +101,13 @@ var PaneviewComponent = /** @class */ (function (_super) {
         _this.onDidRemoveView = _this._onDidRemoveView.event;
         _this._onUnhandledDragOverEvent = new events_1.Emitter();
         _this.onUnhandledDragOverEvent = _this._onUnhandledDragOverEvent.event;
+        _this.element.style.height = '100%';
+        _this.element.style.width = '100%';
         _this.addDisposables(_this._onDidLayoutChange, _this._onDidLayoutfromJSON, _this._onDidDrop, _this._onDidAddView, _this._onDidRemoveView, _this._onUnhandledDragOverEvent);
         _this._classNames = new dom_1.Classnames(_this.element);
         _this._classNames.setClassNames((_a = options.className) !== null && _a !== void 0 ? _a : '');
+        // the container is owned by the third-party, do not modify/delete it
+        container.appendChild(_this.element);
         _this._options = options;
         _this.paneview = new paneview_1.Paneview(_this.element, {
             // only allow paneview in the vertical orientation for now

package/dist/cjs/splitview/splitview.d.ts

@@ -14,7 +14,7 @@ export interface ISplitviewStyles {
     separatorBorder: string;
 }
 export interface SplitViewOptions {
-    orientation: Orientation;
+    orientation?: Orientation;
     descriptor?: ISplitViewDescriptor;
     proportionalLayout?: boolean;
     styles?: ISplitviewStyles;

package/dist/cjs/splitview/splitview.js

@@ -79,7 +79,7 @@ var Sizing;
 var Splitview = /** @class */ (function () {
     function Splitview(container, options) {
         var _this = this;
-        var _a;
+        var _a, _b;
         this.container = container;
         this.viewItems = [];
         this.sashes = [];
@@ -201,9 +201,9 @@ var Splitview = /** @class */ (function () {
             //
             return delta;
         };
-        this._orientation = options.orientation;
+        this._orientation = (_a = options.orientation) !== null && _a !== void 0 ? _a : Orientation.VERTICAL;
         this.element = this.createContainer();
-        this.margin = (_a = options.margin) !== null && _a !== void 0 ? _a : 0;
+        this.margin = (_b = options.margin) !== null && _b !== void 0 ? _b : 0;
         this.proportionalLayout =
             options.proportionalLayout === undefined
                 ? true

package/dist/cjs/splitview/splitviewComponent.d.ts

@@ -83,7 +83,7 @@ export declare class SplitviewComponent extends Resizable implements ISplitviewC
     get maximumSize(): number;
     get height(): number;
     get width(): number;
-    constructor(parentElement: HTMLElement, options: SplitviewComponentOptions);
+    constructor(container: HTMLElement, options: SplitviewComponentOptions);
     updateOptions(options: Partial<SplitviewComponentOptions>): void;
     focus(): void;
     movePanel(from: number, to: number): void;

package/dist/cjs/splitview/splitviewComponent.js

@@ -64,9 +64,9 @@ var dom_1 = require("../dom");
  */
 var SplitviewComponent = /** @class */ (function (_super) {
     __extends(SplitviewComponent, _super);
-    function SplitviewComponent(parentElement, options) {
+    function SplitviewComponent(container, options) {
         var _a;
-        var _this = _super.call(this, parentElement, options.disableAutoResizing) || this;
+        var _this = _super.call(this, document.createElement('div'), options.disableAutoResizing) || this;
         _this._splitviewChangeDisposable = new lifecycle_1.MutableDisposable();
         _this._panels = new Map();
         _this._onDidLayoutfromJSON = new events_1.Emitter();
@@ -77,8 +77,12 @@ var SplitviewComponent = /** @class */ (function (_super) {
         _this.onDidRemoveView = _this._onDidRemoveView.event;
         _this._onDidLayoutChange = new events_1.Emitter();
         _this.onDidLayoutChange = _this._onDidLayoutChange.event;
+        _this.element.style.height = '100%';
+        _this.element.style.width = '100%';
         _this._classNames = new dom_1.Classnames(_this.element);
         _this._classNames.setClassNames((_a = options.className) !== null && _a !== void 0 ? _a : '');
+        // the container is owned by the third-party, do not modify/delete it
+        container.appendChild(_this.element);
         _this._options = options;
         _this.splitview = new splitview_1.Splitview(_this.element, options);
         _this.addDisposables(_this._onDidAddView, _this._onDidLayoutfromJSON, _this._onDidRemoveView, _this._onDidLayoutChange);

package/dist/dockview-core.amd.js

@@ -1,6 +1,6 @@
 /**
  * dockview-core
- * @version 3.0.0
+ * @version 3.0.2
  * @link https://github.com/mathuo/dockview
  * @license MIT
  */
@@ -880,7 +880,7 @@ define(['exports'], (function (exports) { 'use strict';
           this._margin = value;
       }
       constructor(container, options) {
-          var _a;
+          var _a, _b;
           this.container = container;
           this.viewItems = [];
           this.sashes = [];
@@ -978,9 +978,9 @@ define(['exports'], (function (exports) { 'use strict';
               //
               return delta;
           };
-          this._orientation = options.orientation;
+          this._orientation = (_a = options.orientation) !== null && _a !== void 0 ? _a : exports.Orientation.VERTICAL;
           this.element = this.createContainer();
-          this.margin = (_a = options.margin) !== null && _a !== void 0 ? _a : 0;
+          this.margin = (_b = options.margin) !== null && _b !== void 0 ? _b : 0;
           this.proportionalLayout =
               options.proportionalLayout === undefined
                   ? true
@@ -2799,7 +2799,7 @@ define(['exports'], (function (exports) { 'use strict';
       set locked(value) {
           this.gridview.locked = value;
       }
-      constructor(parentElement, options) {
+      constructor(container, options) {
           var _a;
           super(document.createElement('div'), options.disableAutoResizing);
           this._id = nextLayoutId$1.next();
@@ -2820,7 +2820,8 @@ define(['exports'], (function (exports) { 'use strict';
           this.element.style.width = '100%';
           this._classNames = new Classnames(this.element);
           this._classNames.setClassNames((_a = options.className) !== null && _a !== void 0 ? _a : '');
-          parentElement.appendChild(this.element);
+          // the container is owned by the third-party, do not modify/delete it
+          container.appendChild(this.element);
           this.gridview = new Gridview(!!options.proportionalLayout, options.styles, options.orientation, options.locked, options.margin);
           this.gridview.locked = !!options.locked;
           this.element.appendChild(this.gridview.element);
@@ -7540,9 +7541,9 @@ define(['exports'], (function (exports) { 'use strict';
       get floatingGroups() {
           return this._floatingGroups;
       }
-      constructor(parentElement, options) {
+      constructor(container, options) {
           var _a;
-          super(parentElement, {
+          super(container, {
               proportionalLayout: true,
               orientation: exports.Orientation.HORIZONTAL,
               styles: options.hideBorders
@@ -7898,6 +7899,16 @@ define(['exports'], (function (exports) { 'use strict';
                       group.model.renderContainer =
                           this.overlayRenderContainer;
                       returnedGroup = group;
+                      const alreadyRemoved = !this._popoutGroups.find((p) => p.popoutGroup === group);
+                      if (alreadyRemoved) {
+                          /**
+                           * If this popout group was explicitly removed then we shouldn't run the additional
+                           * steps. To tell if the running of this disposable is the result of this popout group
+                           * being explicitly removed we can check if this popout group is still referenced in
+                           * the `this._popoutGroups` list.
+                           */
+                          return;
+                      }
                       if (floatingBox) {
                           this.addFloatingGroup(group, {
                               height: floatingBox.height,
@@ -9074,9 +9085,9 @@ define(['exports'], (function (exports) { 'use strict';
       set deserializer(value) {
           this._deserializer = value;
       }
-      constructor(parentElement, options) {
+      constructor(container, options) {
           var _a;
-          super(parentElement, {
+          super(container, {
               proportionalLayout: (_a = options.proportionalLayout) !== null && _a !== void 0 ? _a : true,
               orientation: options.orientation,
               styles: options.hideBorders
@@ -9365,9 +9376,9 @@ define(['exports'], (function (exports) { 'use strict';
               ? this.splitview.size
               : this.splitview.orthogonalSize;
       }
-      constructor(parentElement, options) {
+      constructor(container, options) {
           var _a;
-          super(parentElement, options.disableAutoResizing);
+          super(document.createElement('div'), options.disableAutoResizing);
           this._splitviewChangeDisposable = new MutableDisposable();
           this._panels = new Map();
           this._onDidLayoutfromJSON = new Emitter();
@@ -9378,8 +9389,12 @@ define(['exports'], (function (exports) { 'use strict';
           this.onDidRemoveView = this._onDidRemoveView.event;
           this._onDidLayoutChange = new Emitter();
           this.onDidLayoutChange = this._onDidLayoutChange.event;
+          this.element.style.height = '100%';
+          this.element.style.width = '100%';
           this._classNames = new Classnames(this.element);
           this._classNames.setClassNames((_a = options.className) !== null && _a !== void 0 ? _a : '');
+          // the container is owned by the third-party, do not modify/delete it
+          container.appendChild(this.element);
           this._options = options;
           this.splitview = new Splitview(this.element, options);
           this.addDisposables(this._onDidAddView, this._onDidLayoutfromJSON, this._onDidRemoveView, this._onDidLayoutChange);
@@ -9689,9 +9704,9 @@ define(['exports'], (function (exports) { 'use strict';
       get options() {
           return this._options;
       }
-      constructor(parentElement, options) {
+      constructor(container, options) {
           var _a;
-          super(parentElement, options.disableAutoResizing);
+          super(document.createElement('div'), options.disableAutoResizing);
           this._id = nextLayoutId.next();
           this._disposable = new MutableDisposable();
           this._viewDisposables = new Map();
@@ -9707,9 +9722,13 @@ define(['exports'], (function (exports) { 'use strict';
           this.onDidRemoveView = this._onDidRemoveView.event;
           this._onUnhandledDragOverEvent = new Emitter();
           this.onUnhandledDragOverEvent = this._onUnhandledDragOverEvent.event;
+          this.element.style.height = '100%';
+          this.element.style.width = '100%';
           this.addDisposables(this._onDidLayoutChange, this._onDidLayoutfromJSON, this._onDidDrop, this._onDidAddView, this._onDidRemoveView, this._onUnhandledDragOverEvent);
           this._classNames = new Classnames(this.element);
           this._classNames.setClassNames((_a = options.className) !== null && _a !== void 0 ? _a : '');
+          // the container is owned by the third-party, do not modify/delete it
+          container.appendChild(this.element);
           this._options = options;
           this.paneview = new Paneview(this.element, {
               // only allow paneview in the vertical orientation for now