dockview-core 2.1.1 → 2.1.3

package/dist/esm/dockview/dockviewComponent.d.ts

@@ -208,6 +208,7 @@ export declare class DockviewComponent extends BaseGrid<DockviewGroupPanel> impl
     get gap(): number;
     get floatingGroups(): DockviewFloatingGroupPanel[];
     constructor(parentElement: HTMLElement, options: DockviewComponentOptions);
+    dispose(): void;
     setVisible(panel: DockviewGroupPanel, visible: boolean): void;
     addPopoutGroup(itemToPopout: DockviewPanel | DockviewGroupPanel, options?: DockviewPopoutGroupOptions): Promise<boolean>;
     addFloatingGroup(item: DockviewPanel | DockviewGroupPanel, options?: FloatingGroupOptionsInternal): void;

package/dist/esm/dockview/dockviewComponent.js

@@ -21,6 +21,7 @@ import { DockviewFloatingGroupPanel } from './dockviewFloatingGroupPanel';
 import { DEFAULT_FLOATING_GROUP_OVERFLOW_SIZE, DEFAULT_FLOATING_GROUP_POSITION, } from '../constants';
 import { OverlayRenderContainer, } from '../overlay/overlayRenderContainer';
 import { PopoutWindow } from '../popoutWindow';
+import { StrictEventsSequencing } from './strictEventsSequencing';
 const DEFAULT_ROOT_OVERLAY_MODEL = {
     activationSize: { type: 'pixels', value: 10 },
     size: { type: 'pixels', value: 20 },
@@ -124,7 +125,10 @@ export class DockviewComponent extends BaseGrid {
         this.overlayRenderContainer = new OverlayRenderContainer(this.gridview.element, this);
         toggleClass(this.gridview.element, 'dv-dockview', true);
         toggleClass(this.element, 'dv-debug', !!options.debug);
-        this.addDisposables(this.overlayRenderContainer, this._onWillDragPanel, this._onWillDragGroup, this._onWillShowOverlay, this._onDidActivePanelChange, this._onDidAddPanel, this._onDidRemovePanel, this._onDidLayoutFromJSON, this._onDidDrop, this._onWillDrop, this._onDidMovePanel, this._onDidAddGroup, this._onDidRemoveGroup, this._onDidActiveGroupChange, this._onUnhandledDragOverEvent, this.onDidViewVisibilityChangeMicroTaskQueue(() => {
+        if (options.debug) {
+            this.addDisposables(new StrictEventsSequencing(this));
+        }
+        this.addDisposables(this.overlayRenderContainer, this._onWillDragPanel, this._onWillDragGroup, this._onWillShowOverlay, this._onDidActivePanelChange, this._onDidAddPanel, this._onDidRemovePanel, this._onDidLayoutFromJSON, this._onDidDrop, this._onWillDrop, this._onDidMovePanel, this._onDidAddGroup, this._onDidRemoveGroup, this._onDidActiveGroupChange, this._onUnhandledDragOverEvent, this._onDidMaximizedGroupChange, this.onDidViewVisibilityChangeMicroTaskQueue(() => {
             this.updateWatermark();
         }), this.onDidAdd((event) => {
             if (!this._moving) {
@@ -241,6 +245,10 @@ export class DockviewComponent extends BaseGrid {
         this._api = new DockviewApi(this);
         this.updateWatermark();
     }
+    dispose() {
+        this.clear(); // explicitly clear the layout before cleaning up
+        super.dispose();
+    }
     setVisible(panel, visible) {
         switch (panel.api.location.type) {
             case 'grid':
@@ -299,6 +307,7 @@ export class DockviewComponent extends BaseGrid {
         return _window
             .open()
             .then((popoutContainer) => {
+            var _a;
             if (_window.isDisposed) {
                 return false;
             }
@@ -331,6 +340,7 @@ export class DockviewComponent extends BaseGrid {
             }
             group.model.renderContainer = overlayRenderContainer;
             group.layout(_window.window.innerWidth, _window.window.innerHeight);
+            let floatingBox;
             if (!(options === null || options === void 0 ? void 0 : options.overridePopoutGroup) && isGroupAddedToDom) {
                 if (itemToPopout instanceof DockviewPanel) {
                     this.movingLock(() => {
@@ -349,6 +359,9 @@ export class DockviewComponent extends BaseGrid {
                             break;
                         case 'floating':
                         case 'popout':
+                            floatingBox = (_a = this._floatingGroups
+                                .find((value) => value.group.api.id ===
+                                itemToPopout.api.id)) === null || _a === void 0 ? void 0 : _a.overlay.toJSON();
                             this.removeGroup(referenceGroup);
                             break;
                     }
@@ -419,17 +432,29 @@ export class DockviewComponent extends BaseGrid {
                     }
                 }
                 else if (this.getPanel(group.id)) {
-                    this.doRemoveGroup(group, {
-                        skipDispose: true,
-                        skipActive: true,
-                        skipPopoutReturn: true,
-                    });
                     const removedGroup = group;
-                    removedGroup.model.renderContainer =
-                        this.overlayRenderContainer;
-                    removedGroup.model.location = { type: 'grid' };
-                    returnedGroup = removedGroup;
-                    this.doAddGroup(removedGroup, [0]);
+                    if (floatingBox) {
+                        this.addFloatingGroup(removedGroup, {
+                            height: floatingBox.height,
+                            width: floatingBox.width,
+                            position: floatingBox,
+                        });
+                    }
+                    else {
+                        this.doRemoveGroup(removedGroup, {
+                            skipDispose: true,
+                            skipActive: true,
+                            skipPopoutReturn: true,
+                        });
+                        removedGroup.model.renderContainer =
+                            this.overlayRenderContainer;
+                        removedGroup.model.location = { type: 'grid' };
+                        returnedGroup = removedGroup;
+                        this.movingLock(() => {
+                            // suppress group add events since the group already exists
+                            this.doAddGroup(removedGroup, [0]);
+                        });
+                    }
                     this.doSetGroupAndPanelActive(removedGroup);
                 }
             }));
@@ -779,6 +804,7 @@ export class DockviewComponent extends BaseGrid {
                     locked: !!locked,
                     hideHeader: !!hideHeader,
                 });
+                this._onDidAddGroup.fire(group);
                 const createdPanels = [];
                 for (const child of views) {
                     /**
@@ -789,7 +815,6 @@ export class DockviewComponent extends BaseGrid {
                     const panel = this._deserializer.fromJSON(panels[child], group);
                     createdPanels.push(panel);
                 }
-                this._onDidAddGroup.fire(group);
                 for (let i = 0; i < views.length; i++) {
                     const panel = createdPanels[i];
                     const isActive = typeof activeView === 'string' &&
@@ -1323,9 +1348,7 @@ export class DockviewComponent extends BaseGrid {
                     }));
                     this.doRemoveGroup(sourceGroup, { skipActive: true });
                     const newGroup = this.createGroupAtLocation(targetLocation);
-                    this.movingLock(() => newGroup.model.openPanel(removedPanel, {
-                        skipSetActive: true,
-                    }));
+                    this.movingLock(() => newGroup.model.openPanel(removedPanel));
                     this.doSetGroupAndPanelActive(newGroup);
                     this._onDidMovePanel.fire({
                         panel: this.getGroupPanel(sourceItemId),

package/dist/esm/dockview/dockviewGroupPanelModel.js

@@ -215,7 +215,7 @@ export class DockviewGroupPanelModel extends CompositeDisposable {
                 group: this.groupPanel,
                 getData: getPanelData,
             }));
-        }), this._onMove, this._onDidChange, this._onDidDrop, this._onWillDrop, this._onDidAddPanel, this._onDidRemovePanel, this._onDidActivePanelChange, this._onUnhandledDragOverEvent);
+        }), this._onMove, this._onDidChange, this._onDidDrop, this._onWillDrop, this._onDidAddPanel, this._onDidRemovePanel, this._onDidActivePanelChange, this._onUnhandledDragOverEvent, this._onDidPanelTitleChange, this._onDidPanelParametersChange);
     }
     focusContent() {
         this.contentContainer.element.focus();

package/dist/esm/dockview/strictEventsSequencing.d.ts

@@ -0,0 +1,7 @@
+import { CompositeDisposable } from '../lifecycle';
+import { DockviewComponent } from './dockviewComponent';
+export declare class StrictEventsSequencing extends CompositeDisposable {
+    private readonly accessor;
+    constructor(accessor: DockviewComponent);
+    private init;
+}

package/dist/esm/dockview/strictEventsSequencing.js

@@ -0,0 +1,41 @@
+import { CompositeDisposable } from '../lifecycle';
+export class StrictEventsSequencing extends CompositeDisposable {
+    constructor(accessor) {
+        super();
+        this.accessor = accessor;
+        this.init();
+    }
+    init() {
+        const panels = new Set();
+        const groups = new Set();
+        this.addDisposables(this.accessor.onDidAddPanel((panel) => {
+            if (panels.has(panel.api.id)) {
+                throw new Error(`dockview: Invalid event sequence. [onDidAddPanel] called for panel ${panel.api.id} but panel already exists`);
+            }
+            else {
+                panels.add(panel.api.id);
+            }
+        }), this.accessor.onDidRemovePanel((panel) => {
+            if (!panels.has(panel.api.id)) {
+                throw new Error(`dockview: Invalid event sequence. [onDidRemovePanel] called for panel ${panel.api.id} but panel does not exists`);
+            }
+            else {
+                panels.delete(panel.api.id);
+            }
+        }), this.accessor.onDidAddGroup((group) => {
+            if (groups.has(group.api.id)) {
+                throw new Error(`dockview: Invalid event sequence. [onDidAddGroup] called for group ${group.api.id} but group already exists`);
+            }
+            else {
+                groups.add(group.api.id);
+            }
+        }), this.accessor.onDidRemoveGroup((group) => {
+            if (!groups.has(group.api.id)) {
+                throw new Error(`dockview: Invalid event sequence. [onDidRemoveGroup] called for group ${group.api.id} but group does not exists`);
+            }
+            else {
+                groups.delete(group.api.id);
+            }
+        }));
+    }
+}

package/dist/esm/gridview/baseComponentGridview.js

@@ -98,7 +98,7 @@ export class BaseGrid extends Resizable {
             this._bufferOnDidLayoutChange.fire();
         }), Event.any(this.onDidAdd, this.onDidRemove, this.onDidActiveChange)(() => {
             this._bufferOnDidLayoutChange.fire();
-        }), this._bufferOnDidLayoutChange);
+        }), this._onDidMaximizedChange, this._onDidViewVisibilityChangeMicroTaskQueue, this._bufferOnDidLayoutChange);
     }
     setVisible(panel, visible) {
         this.gridview.setViewVisible(getGridLocation(panel.element), visible);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dockview-core",
-  "version": "2.1.1",
+  "version": "2.1.3",
   "description": "Zero dependency layout manager supporting tabs, grids and splitviews",
   "keywords": [
     "splitview",