dockview-core 2.1.0 → 2.1.2

package/dist/dockview-core.js

@@ -1,6 +1,6 @@
 /**
  * dockview-core
- * @version 2.1.0
+ * @version 2.1.2
  * @link https://github.com/mathuo/dockview
  * @license MIT
  */
@@ -2800,7 +2800,7 @@
               this._bufferOnDidLayoutChange.fire();
           }), exports.DockviewEvent.any(this.onDidAdd, this.onDidRemove, this.onDidActiveChange)(() => {
               this._bufferOnDidLayoutChange.fire();
-          }), this._bufferOnDidLayoutChange);
+          }), this._onDidMaximizedChange, this._onDidViewVisibilityChangeMicroTaskQueue, this._bufferOnDidLayoutChange);
       }
       setVisible(panel, visible) {
           this.gridview.setViewVisible(getGridLocation(panel.element), visible);
@@ -5401,7 +5401,7 @@
                   group: this.groupPanel,
                   getData: getPanelData,
               }));
-          }), this._onMove, this._onDidChange, this._onDidDrop, this._onWillDrop, this._onDidAddPanel, this._onDidRemovePanel, this._onDidActivePanelChange, this._onUnhandledDragOverEvent);
+          }), this._onMove, this._onDidChange, this._onDidDrop, this._onWillDrop, this._onDidAddPanel, this._onDidRemovePanel, this._onDidActivePanelChange, this._onUnhandledDragOverEvent, this._onDidPanelTitleChange, this._onDidPanelParametersChange);
       }
       focusContent() {
           this.contentContainer.element.focus();
@@ -7403,6 +7403,47 @@
       }
   }
 
+  class StrictEventsSequencing extends CompositeDisposable {
+      constructor(accessor) {
+          super();
+          this.accessor = accessor;
+          this.init();
+      }
+      init() {
+          const panels = new Set();
+          const groups = new Set();
+          this.addDisposables(this.accessor.onDidAddPanel((panel) => {
+              if (panels.has(panel.api.id)) {
+                  throw new Error(`dockview: Invalid event sequence. [onDidAddPanel] called for panel ${panel.api.id} but panel already exists`);
+              }
+              else {
+                  panels.add(panel.api.id);
+              }
+          }), this.accessor.onDidRemovePanel((panel) => {
+              if (!panels.has(panel.api.id)) {
+                  throw new Error(`dockview: Invalid event sequence. [onDidRemovePanel] called for panel ${panel.api.id} but panel does not exists`);
+              }
+              else {
+                  panels.delete(panel.api.id);
+              }
+          }), this.accessor.onDidAddGroup((group) => {
+              if (groups.has(group.api.id)) {
+                  throw new Error(`dockview: Invalid event sequence. [onDidAddGroup] called for group ${group.api.id} but group already exists`);
+              }
+              else {
+                  groups.add(group.api.id);
+              }
+          }), this.accessor.onDidRemoveGroup((group) => {
+              if (!groups.has(group.api.id)) {
+                  throw new Error(`dockview: Invalid event sequence. [onDidRemoveGroup] called for group ${group.api.id} but group does not exists`);
+              }
+              else {
+                  groups.delete(group.api.id);
+              }
+          }));
+      }
+  }
+
   const DEFAULT_ROOT_OVERLAY_MODEL = {
       activationSize: { type: 'pixels', value: 10 },
       size: { type: 'pixels', value: 20 },
@@ -7506,7 +7547,10 @@
           this.overlayRenderContainer = new OverlayRenderContainer(this.gridview.element, this);
           toggleClass(this.gridview.element, 'dv-dockview', true);
           toggleClass(this.element, 'dv-debug', !!options.debug);
-          this.addDisposables(this.overlayRenderContainer, this._onWillDragPanel, this._onWillDragGroup, this._onWillShowOverlay, this._onDidActivePanelChange, this._onDidAddPanel, this._onDidRemovePanel, this._onDidLayoutFromJSON, this._onDidDrop, this._onWillDrop, this._onDidMovePanel, this._onDidAddGroup, this._onDidRemoveGroup, this._onDidActiveGroupChange, this._onUnhandledDragOverEvent, this.onDidViewVisibilityChangeMicroTaskQueue(() => {
+          if (options.debug) {
+              this.addDisposables(new StrictEventsSequencing(this));
+          }
+          this.addDisposables(this.overlayRenderContainer, this._onWillDragPanel, this._onWillDragGroup, this._onWillShowOverlay, this._onDidActivePanelChange, this._onDidAddPanel, this._onDidRemovePanel, this._onDidLayoutFromJSON, this._onDidDrop, this._onWillDrop, this._onDidMovePanel, this._onDidAddGroup, this._onDidRemoveGroup, this._onDidActiveGroupChange, this._onUnhandledDragOverEvent, this._onDidMaximizedGroupChange, this.onDidViewVisibilityChangeMicroTaskQueue(() => {
               this.updateWatermark();
           }), this.onDidAdd((event) => {
               if (!this._moving) {
@@ -7623,6 +7667,10 @@
           this._api = new DockviewApi(this);
           this.updateWatermark();
       }
+      dispose() {
+          this.clear(); // explicitly clear the layout before cleaning up
+          super.dispose();
+      }
       setVisible(panel, visible) {
           switch (panel.api.location.type) {
               case 'grid':
@@ -7681,6 +7729,7 @@
           return _window
               .open()
               .then((popoutContainer) => {
+              var _a;
               if (_window.isDisposed) {
                   return false;
               }
@@ -7713,6 +7762,7 @@
               }
               group.model.renderContainer = overlayRenderContainer;
               group.layout(_window.window.innerWidth, _window.window.innerHeight);
+              let floatingBox;
               if (!(options === null || options === void 0 ? void 0 : options.overridePopoutGroup) && isGroupAddedToDom) {
                   if (itemToPopout instanceof DockviewPanel) {
                       this.movingLock(() => {
@@ -7731,6 +7781,9 @@
                               break;
                           case 'floating':
                           case 'popout':
+                              floatingBox = (_a = this._floatingGroups
+                                  .find((value) => value.group.api.id ===
+                                  itemToPopout.api.id)) === null || _a === void 0 ? void 0 : _a.overlay.toJSON();
                               this.removeGroup(referenceGroup);
                               break;
                       }
@@ -7801,17 +7854,29 @@
                       }
                   }
                   else if (this.getPanel(group.id)) {
-                      this.doRemoveGroup(group, {
-                          skipDispose: true,
-                          skipActive: true,
-                          skipPopoutReturn: true,
-                      });
                       const removedGroup = group;
-                      removedGroup.model.renderContainer =
-                          this.overlayRenderContainer;
-                      removedGroup.model.location = { type: 'grid' };
-                      returnedGroup = removedGroup;
-                      this.doAddGroup(removedGroup, [0]);
+                      if (floatingBox) {
+                          this.addFloatingGroup(removedGroup, {
+                              height: floatingBox.height,
+                              width: floatingBox.width,
+                              position: floatingBox,
+                          });
+                      }
+                      else {
+                          this.doRemoveGroup(removedGroup, {
+                              skipDispose: true,
+                              skipActive: true,
+                              skipPopoutReturn: true,
+                          });
+                          removedGroup.model.renderContainer =
+                              this.overlayRenderContainer;
+                          removedGroup.model.location = { type: 'grid' };
+                          returnedGroup = removedGroup;
+                          this.movingLock(() => {
+                              // suppress group add events since the group already exists
+                              this.doAddGroup(removedGroup, [0]);
+                          });
+                      }
                       this.doSetGroupAndPanelActive(removedGroup);
                   }
               }));
@@ -8159,6 +8224,7 @@
                       locked: !!locked,
                       hideHeader: !!hideHeader,
                   });
+                  this._onDidAddGroup.fire(group);
                   const createdPanels = [];
                   for (const child of views) {
                       /**
@@ -8169,7 +8235,6 @@
                       const panel = this._deserializer.fromJSON(panels[child], group);
                       createdPanels.push(panel);
                   }
-                  this._onDidAddGroup.fire(group);
                   for (let i = 0; i < views.length; i++) {
                       const panel = createdPanels[i];
                       const isActive = typeof activeView === 'string' &&
@@ -8568,7 +8633,7 @@
                           const refGroup = selectedGroup.referenceGroup
                               ? this.getPanel(selectedGroup.referenceGroup)
                               : undefined;
-                          if (refGroup) {
+                          if (refGroup && refGroup.panels.length === 0) {
                               this.removeGroup(refGroup);
                           }
                       }