dockview-core 1.9.1 → 1.10.0

package/dist/cjs/dockview/dockviewGroupPanelModel.js

@@ -51,7 +51,7 @@ var __values = (this && this.__values) || function(o) {
     throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.DockviewGroupPanelModel = void 0;
+exports.DockviewGroupPanelModel = exports.WillShowOverlayLocationEvent = exports.DockviewWillDropEvent = exports.DockviewDidDropEvent = void 0;
 var component_api_1 = require("../api/component.api");
 var dataTransfer_1 = require("../dnd/dataTransfer");
 var dom_1 = require("../dom");
@@ -59,6 +59,110 @@ var events_1 = require("../events");
 var lifecycle_1 = require("../lifecycle");
 var content_1 = require("./components/panel/content");
 var tabsContainer_1 = require("./components/titlebar/tabsContainer");
+var DockviewDidDropEvent = /** @class */ (function (_super) {
+    __extends(DockviewDidDropEvent, _super);
+    function DockviewDidDropEvent(options) {
+        var _this = _super.call(this) || this;
+        _this.options = options;
+        return _this;
+    }
+    Object.defineProperty(DockviewDidDropEvent.prototype, "nativeEvent", {
+        get: function () {
+            return this.options.nativeEvent;
+        },
+        enumerable: false,
+        configurable: true
+    });
+    Object.defineProperty(DockviewDidDropEvent.prototype, "position", {
+        get: function () {
+            return this.options.position;
+        },
+        enumerable: false,
+        configurable: true
+    });
+    Object.defineProperty(DockviewDidDropEvent.prototype, "panel", {
+        get: function () {
+            return this.options.panel;
+        },
+        enumerable: false,
+        configurable: true
+    });
+    Object.defineProperty(DockviewDidDropEvent.prototype, "group", {
+        get: function () {
+            return this.options.group;
+        },
+        enumerable: false,
+        configurable: true
+    });
+    Object.defineProperty(DockviewDidDropEvent.prototype, "api", {
+        get: function () {
+            return this.options.api;
+        },
+        enumerable: false,
+        configurable: true
+    });
+    DockviewDidDropEvent.prototype.getData = function () {
+        return this.options.getData();
+    };
+    return DockviewDidDropEvent;
+}(events_1.DockviewEvent));
+exports.DockviewDidDropEvent = DockviewDidDropEvent;
+var DockviewWillDropEvent = /** @class */ (function (_super) {
+    __extends(DockviewWillDropEvent, _super);
+    function DockviewWillDropEvent(options) {
+        var _this = _super.call(this, options) || this;
+        _this._kind = options.kind;
+        return _this;
+    }
+    Object.defineProperty(DockviewWillDropEvent.prototype, "kind", {
+        get: function () {
+            return this._kind;
+        },
+        enumerable: false,
+        configurable: true
+    });
+    return DockviewWillDropEvent;
+}(DockviewDidDropEvent));
+exports.DockviewWillDropEvent = DockviewWillDropEvent;
+var WillShowOverlayLocationEvent = /** @class */ (function () {
+    function WillShowOverlayLocationEvent(event, options) {
+        this.event = event;
+        this._kind = options.kind;
+    }
+    Object.defineProperty(WillShowOverlayLocationEvent.prototype, "kind", {
+        get: function () {
+            return this._kind;
+        },
+        enumerable: false,
+        configurable: true
+    });
+    Object.defineProperty(WillShowOverlayLocationEvent.prototype, "nativeEvent", {
+        get: function () {
+            return this.event.nativeEvent;
+        },
+        enumerable: false,
+        configurable: true
+    });
+    Object.defineProperty(WillShowOverlayLocationEvent.prototype, "position", {
+        get: function () {
+            return this.event.position;
+        },
+        enumerable: false,
+        configurable: true
+    });
+    Object.defineProperty(WillShowOverlayLocationEvent.prototype, "defaultPrevented", {
+        get: function () {
+            return this.event.defaultPrevented;
+        },
+        enumerable: false,
+        configurable: true
+    });
+    WillShowOverlayLocationEvent.prototype.preventDefault = function () {
+        this.event.preventDefault();
+    };
+    return WillShowOverlayLocationEvent;
+}());
+exports.WillShowOverlayLocationEvent = WillShowOverlayLocationEvent;
 var DockviewGroupPanelModel = /** @class */ (function (_super) {
     __extends(DockviewGroupPanelModel, _super);
     function DockviewGroupPanelModel(container, accessor, id, options, groupPanel) {
@@ -71,7 +175,7 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
         _this.groupPanel = groupPanel;
         _this._isGroupActive = false;
         _this._locked = false;
-        _this._location = 'grid';
+        _this._location = { type: 'grid' };
         _this.mostRecentlyUsed = [];
         _this._onDidChange = new events_1.Emitter();
         _this.onDidChange = _this._onDidChange.event;
@@ -82,6 +186,10 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
         _this.onMove = _this._onMove.event;
         _this._onDidDrop = new events_1.Emitter();
         _this.onDidDrop = _this._onDidDrop.event;
+        _this._onWillDrop = new events_1.Emitter();
+        _this.onWillDrop = _this._onWillDrop.event;
+        _this._onWillShowOverlay = new events_1.Emitter();
+        _this.onWillShowOverlay = _this._onWillShowOverlay.event;
         _this._onTabDragStart = new events_1.Emitter();
         _this.onTabDragStart = _this._onTabDragStart.event;
         _this._onGroupDragStart = new events_1.Emitter();
@@ -92,25 +200,33 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
         _this.onDidRemovePanel = _this._onDidRemovePanel.event;
         _this._onDidActivePanelChange = new events_1.Emitter();
         _this.onDidActivePanelChange = _this._onDidActivePanelChange.event;
+        _this._overwriteRenderContainer = null;
         (0, dom_1.toggleClass)(_this.container, 'groupview', true);
+        _this._api = new component_api_1.DockviewApi(_this.accessor);
         _this.tabsContainer = new tabsContainer_1.TabsContainer(_this.accessor, _this.groupPanel);
         _this.contentContainer = new content_1.ContentContainer(_this.accessor, _this);
         container.append(_this.tabsContainer.element, _this.contentContainer.element);
         _this.header.hidden = !!options.hideHeader;
         _this.locked = (_a = options.locked) !== null && _a !== void 0 ? _a : false;
-        _this.addDisposables(_this._onTabDragStart, _this._onGroupDragStart, _this.tabsContainer.onTabDragStart(function (event) {
+        _this.addDisposables(_this._onTabDragStart, _this._onGroupDragStart, _this._onWillShowOverlay, _this.tabsContainer.onTabDragStart(function (event) {
             _this._onTabDragStart.fire(event);
         }), _this.tabsContainer.onGroupDragStart(function (event) {
             _this._onGroupDragStart.fire(event);
         }), _this.tabsContainer.onDrop(function (event) {
-            _this.handleDropEvent(event.event, 'center', event.index);
+            _this.handleDropEvent('header', event.event, 'center', event.index);
         }), _this.contentContainer.onDidFocus(function () {
-            _this.accessor.doSetGroupActive(_this.groupPanel, true);
+            _this.accessor.doSetGroupActive(_this.groupPanel);
         }), _this.contentContainer.onDidBlur(function () {
             // noop
         }), _this.contentContainer.dropTarget.onDrop(function (event) {
-            _this.handleDropEvent(event.nativeEvent, event.position);
-        }), _this._onMove, _this._onDidChange, _this._onDidDrop, _this._onDidAddPanel, _this._onDidRemovePanel, _this._onDidActivePanelChange);
+            _this.handleDropEvent('content', event.nativeEvent, event.position);
+        }), _this.tabsContainer.onWillShowOverlay(function (event) {
+            _this._onWillShowOverlay.fire(event);
+        }), _this.contentContainer.dropTarget.onWillShowOverlay(function (event) {
+            _this._onWillShowOverlay.fire(new WillShowOverlayLocationEvent(event, {
+                kind: 'content',
+            }));
+        }), _this._onMove, _this._onDidChange, _this._onDidDrop, _this._onWillDrop, _this._onDidAddPanel, _this._onDidRemovePanel, _this._onDidActivePanelChange);
         return _this;
     }
     Object.defineProperty(DockviewGroupPanelModel.prototype, "element", {
@@ -198,7 +314,7 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
             this._location = value;
             (0, dom_1.toggleClass)(this.container, 'dv-groupview-floating', false);
             (0, dom_1.toggleClass)(this.container, 'dv-groupview-popout', false);
-            switch (value) {
+            switch (value.type) {
                 case 'grid':
                     this.contentContainer.dropTarget.setTargetZones([
                         'top',
@@ -227,27 +343,47 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
         enumerable: false,
         configurable: true
     });
+    DockviewGroupPanelModel.prototype.focusContent = function () {
+        this.contentContainer.element.focus();
+    };
+    Object.defineProperty(DockviewGroupPanelModel.prototype, "renderContainer", {
+        get: function () {
+            var _a;
+            return ((_a = this._overwriteRenderContainer) !== null && _a !== void 0 ? _a : this.accessor.overlayRenderContainer);
+        },
+        set: function (value) {
+            var _this = this;
+            this.panels.forEach(function (panel) {
+                _this.renderContainer.detatch(panel);
+            });
+            this._overwriteRenderContainer = value;
+            this.panels.forEach(function (panel) {
+                _this.rerender(panel);
+            });
+        },
+        enumerable: false,
+        configurable: true
+    });
     DockviewGroupPanelModel.prototype.initialize = function () {
         var _this = this;
-        var _a, _b;
-        if ((_a = this.options) === null || _a === void 0 ? void 0 : _a.panels) {
+        if (this.options.panels) {
             this.options.panels.forEach(function (panel) {
                 _this.doAddPanel(panel);
             });
         }
-        if ((_b = this.options) === null || _b === void 0 ? void 0 : _b.activePanel) {
+        if (this.options.activePanel) {
             this.openPanel(this.options.activePanel);
         }
         // must be run after the constructor otherwise this.parent may not be
         // correctly initialized
-        this.setActive(this.isActive, true, true);
+        this.setActive(this.isActive, true);
         this.updateContainer();
         if (this.accessor.options.createRightHeaderActionsElement) {
             this._rightHeaderActions =
                 this.accessor.options.createRightHeaderActionsElement(this.groupPanel);
             this.addDisposables(this._rightHeaderActions);
             this._rightHeaderActions.init({
-                containerApi: new component_api_1.DockviewApi(this.accessor),
+                containerApi: this._api,
                 api: this.groupPanel.api,
             });
             this.tabsContainer.setRightActionsElement(this._rightHeaderActions.element);
@@ -257,7 +393,7 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
                 this.accessor.options.createLeftHeaderActionsElement(this.groupPanel);
             this.addDisposables(this._leftHeaderActions);
             this._leftHeaderActions.init({
-                containerApi: new component_api_1.DockviewApi(this.accessor),
+                containerApi: this._api,
                 api: this.groupPanel.api,
             });
             this.tabsContainer.setLeftActionsElement(this._leftHeaderActions.element);
@@ -267,7 +403,7 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
                 this.accessor.options.createPrefixHeaderActionsElement(this.groupPanel);
             this.addDisposables(this._prefixHeaderActions);
             this._prefixHeaderActions.init({
-                containerApi: new component_api_1.DockviewApi(this.accessor),
+                containerApi: this._api,
                 api: this.groupPanel.api,
             });
             this.tabsContainer.setPrefixActionsElement(this._prefixHeaderActions.element);
@@ -347,35 +483,47 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
         //noop
     };
     DockviewGroupPanelModel.prototype.focus = function () {
-        var _a, _b;
-        (_b = (_a = this._activePanel) === null || _a === void 0 ? void 0 : _a.focus) === null || _b === void 0 ? void 0 : _b.call(_a);
+        var _a;
+        (_a = this._activePanel) === null || _a === void 0 ? void 0 : _a.focus();
     };
     DockviewGroupPanelModel.prototype.openPanel = function (panel, options) {
+        /**
+         * set the panel group
+         * add the panel
+         * check if group active
+         * check if panel active
+         */
         if (options === void 0) { options = {}; }
         if (typeof options.index !== 'number' ||
             options.index > this.panels.length) {
             options.index = this.panels.length;
         }
-        var skipSetPanelActive = !!options.skipSetPanelActive;
-        var skipSetGroupActive = !!options.skipSetGroupActive;
+        var skipSetActive = !!options.skipSetActive;
         // ensure the group is updated before we fire any events
-        panel.updateParentGroup(this.groupPanel, true);
+        panel.updateParentGroup(this.groupPanel, {
+            skipSetActive: options.skipSetActive,
+        });
+        this.doAddPanel(panel, options.index, {
+            skipSetActive: skipSetActive,
+        });
         if (this._activePanel === panel) {
-            if (!skipSetGroupActive) {
-                this.accessor.doSetGroupActive(this.groupPanel);
-            }
+            this.contentContainer.renderPanel(panel, { asActive: true });
             return;
         }
-        this.doAddPanel(panel, options.index, skipSetPanelActive);
-        if (!skipSetPanelActive) {
+        if (!skipSetActive) {
             this.doSetActivePanel(panel);
         }
-        if (!skipSetGroupActive) {
-            this.accessor.doSetGroupActive(this.groupPanel, !!options.skipFocus);
+        if (!options.skipSetGroupActive) {
+            this.accessor.doSetGroupActive(this.groupPanel);
+        }
+        if (!options.skipSetActive) {
+            this.updateContainer();
         }
-        this.updateContainer();
     };
-    DockviewGroupPanelModel.prototype.removePanel = function (groupItemOrId) {
+    DockviewGroupPanelModel.prototype.removePanel = function (groupItemOrId, options) {
+        if (options === void 0) { options = {
+            skipSetActive: false,
+        }; }
         var id = typeof groupItemOrId === 'string'
             ? groupItemOrId
             : groupItemOrId.id;
@@ -383,7 +531,7 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
         if (!panelToRemove) {
             throw new Error('invalid operation');
         }
-        return this._removePanel(panelToRemove);
+        return this._removePanel(panelToRemove, options);
     };
     DockviewGroupPanelModel.prototype.closeAllPanels = function () {
         var e_1, _a;
@@ -420,14 +568,9 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
     DockviewGroupPanelModel.prototype.updateActions = function (element) {
         this.tabsContainer.setRightActionsElement(element);
     };
-    DockviewGroupPanelModel.prototype.setActive = function (isGroupActive, skipFocus, force) {
-        var _a, _b, _c, _d;
-        if (skipFocus === void 0) { skipFocus = false; }
+    DockviewGroupPanelModel.prototype.setActive = function (isGroupActive, force) {
         if (force === void 0) { force = false; }
         if (!force && this.isActive === isGroupActive) {
-            if (!skipFocus) {
-                (_b = (_a = this._activePanel) === null || _a === void 0 ? void 0 : _a.focus) === null || _b === void 0 ? void 0 : _b.call(_a);
-            }
             return;
         }
         this._isGroupActive = isGroupActive;
@@ -438,11 +581,6 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
             this.doSetActivePanel(this.panels[0]);
         }
         this.updateContainer();
-        if (isGroupActive) {
-            if (!skipFocus) {
-                (_d = (_c = this._activePanel) === null || _c === void 0 ? void 0 : _c.focus) === null || _d === void 0 ? void 0 : _d.call(_c);
-            }
-        }
     };
     DockviewGroupPanelModel.prototype.layout = function (width, height) {
         var _a;
@@ -453,17 +591,22 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
             this._activePanel.layout(this._width, this._height);
         }
     };
-    DockviewGroupPanelModel.prototype._removePanel = function (panel) {
+    DockviewGroupPanelModel.prototype._removePanel = function (panel, options) {
         var isActivePanel = this._activePanel === panel;
         this.doRemovePanel(panel);
         if (isActivePanel && this.panels.length > 0) {
             var nextPanel = this.mostRecentlyUsed[0];
-            this.openPanel(nextPanel);
+            this.openPanel(nextPanel, {
+                skipSetActive: options.skipSetActive,
+                skipSetGroupActive: options.skipSetActiveGroup,
+            });
         }
         if (this._activePanel && this.panels.length === 0) {
             this.doSetActivePanel(undefined);
         }
-        this.updateContainer();
+        if (!options.skipSetActive) {
+            this.updateContainer();
+        }
         return panel;
     };
     DockviewGroupPanelModel.prototype.doRemovePanel = function (panel) {
@@ -478,15 +621,15 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
         }
         this._onDidRemovePanel.fire({ panel: panel });
     };
-    DockviewGroupPanelModel.prototype.doAddPanel = function (panel, index, skipSetActive) {
+    DockviewGroupPanelModel.prototype.doAddPanel = function (panel, index, options) {
         if (index === void 0) { index = this.panels.length; }
-        if (skipSetActive === void 0) { skipSetActive = false; }
+        if (options === void 0) { options = { skipSetActive: false }; }
         var existingPanel = this._panels.indexOf(panel);
         var hasExistingPanel = existingPanel > -1;
         this.tabsContainer.show();
         this.contentContainer.show();
         this.tabsContainer.openPanel(panel, index);
-        if (!skipSetActive) {
+        if (!options.skipSetActive) {
             this.contentContainer.openPanel(panel);
         }
         if (hasExistingPanel) {
@@ -498,12 +641,17 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
         this._onDidAddPanel.fire({ panel: panel });
     };
     DockviewGroupPanelModel.prototype.doSetActivePanel = function (panel) {
+        if (this._activePanel === panel) {
+            return;
+        }
         this._activePanel = panel;
         if (panel) {
             this.tabsContainer.setActivePanel(panel);
             panel.layout(this._width, this._height);
             this.updateMru(panel);
-            this._onDidActivePanelChange.fire({ panel: panel });
+            this._onDidActivePanelChange.fire({
+                panel: panel,
+            });
         }
     };
     DockviewGroupPanelModel.prototype.updateMru = function (panel) {
@@ -516,13 +664,11 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
         var _this = this;
         var _a, _b;
         (0, dom_1.toggleClass)(this.container, 'empty', this.isEmpty);
-        this.panels.forEach(function (panel) {
-            return panel.updateParentGroup(_this.groupPanel, _this.isActive);
-        });
+        this.panels.forEach(function (panel) { return panel.runEvents(); });
         if (this.isEmpty && !this.watermark) {
             var watermark = this.accessor.createWatermarkComponent();
             watermark.init({
-                containerApi: new component_api_1.DockviewApi(this.accessor),
+                containerApi: this._api,
                 group: this.groupPanel,
             });
             this.watermark = watermark;
@@ -555,10 +701,32 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
         }
         return false;
     };
-    DockviewGroupPanelModel.prototype.handleDropEvent = function (event, position, index) {
+    DockviewGroupPanelModel.prototype.handleDropEvent = function (type, event, position, index) {
         if (this.locked === 'no-drop-target') {
             return;
         }
+        function getKind() {
+            switch (type) {
+                case 'header':
+                    return typeof index === 'number' ? 'tab' : 'header_space';
+                case 'content':
+                    return 'content';
+            }
+        }
+        var panel = typeof index === 'number' ? this.panels[index] : undefined;
+        var willDropEvent = new DockviewWillDropEvent({
+            nativeEvent: event,
+            position: position,
+            panel: panel,
+            getData: function () { return (0, dataTransfer_1.getPanelData)(); },
+            kind: getKind(),
+            group: this.groupPanel,
+            api: this._api,
+        });
+        this._onWillDrop.fire(willDropEvent);
+        if (willDropEvent.defaultPrevented) {
+            return;
+        }
         var data = (0, dataTransfer_1.getPanelData)();
         if (data && data.viewId === this.accessor.id) {
             if (data.panelId === null) {
@@ -591,12 +759,14 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
             });
         }
         else {
-            this._onDidDrop.fire({
+            this._onDidDrop.fire(new DockviewDidDropEvent({
                 nativeEvent: event,
                 position: position,
-                index: index,
+                panel: panel,
                 getData: function () { return (0, dataTransfer_1.getPanelData)(); },
-            });
+                group: this.groupPanel,
+                api: this._api,
+            }));
         }
     };
     DockviewGroupPanelModel.prototype.dispose = function () {
@@ -605,6 +775,7 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
         _super.prototype.dispose.call(this);
         (_b = this.watermark) === null || _b === void 0 ? void 0 : _b.element.remove();
         (_d = (_c = this.watermark) === null || _c === void 0 ? void 0 : _c.dispose) === null || _d === void 0 ? void 0 : _d.call(_c);
+        this.watermark = undefined;
         try {
             for (var _e = __values(this.panels), _f = _e.next(); !_f.done; _f = _e.next()) {
                 var panel = _f.value;
@@ -624,4 +795,3 @@ var DockviewGroupPanelModel = /** @class */ (function (_super) {
     return DockviewGroupPanelModel;
 }(lifecycle_1.CompositeDisposable));
 exports.DockviewGroupPanelModel = DockviewGroupPanelModel;
-//# sourceMappingURL=dockviewGroupPanelModel.js.map

package/dist/cjs/dockview/dockviewPanel.d.ts

@@ -13,11 +13,14 @@ export interface IDockviewPanel extends IDisposable, IPanel {
     readonly api: DockviewPanelApi;
     readonly title: string | undefined;
     readonly params: Parameters | undefined;
-    updateParentGroup(group: DockviewGroupPanel, isGroupActive: boolean): void;
+    updateParentGroup(group: DockviewGroupPanel, options?: {
+        skipSetActive?: boolean;
+    }): void;
     init(params: IGroupPanelInitParameters): void;
     toJSON(): GroupviewPanelState;
     setTitle(title: string): void;
     update(event: PanelUpdateEvent): void;
+    runEvents(): void;
 }
 export declare class DockviewPanel extends CompositeDisposable implements IDockviewPanel {
     readonly id: string;
@@ -42,8 +45,10 @@ export declare class DockviewPanel extends CompositeDisposable implements IDockv
     setTitle(title: string): void;
     setRenderer(renderer: DockviewPanelRenderer): void;
     update(event: PanelUpdateEvent): void;
-    updateParentGroup(group: DockviewGroupPanel, isGroupActive: boolean): void;
+    updateParentGroup(group: DockviewGroupPanel, options?: {
+        skipSetActive?: boolean;
+    }): void;
+    runEvents(): void;
     layout(width: number, height: number): void;
     dispose(): void;
 }
-//# sourceMappingURL=dockviewPanel.d.ts.map

package/dist/cjs/dockview/dockviewPanel.js

@@ -40,6 +40,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.DockviewPanel = void 0;
 var dockviewPanelApi_1 = require("../api/dockviewPanelApi");
 var lifecycle_1 = require("../lifecycle");
+var panelApi_1 = require("../api/panelApi");
 var DockviewPanel = /** @class */ (function (_super) {
     __extends(DockviewPanel, _super);
     function DockviewPanel(id, accessor, containerApi, group, view, options) {
@@ -97,7 +98,14 @@ var DockviewPanel = /** @class */ (function (_super) {
         this.setTitle(params.title);
     };
     DockviewPanel.prototype.focus = function () {
-        this.api._onFocusEvent.fire();
+        var event = new panelApi_1.WillFocusEvent();
+        this.api._onWillFocus.fire(event);
+        if (event.defaultPrevented) {
+            return;
+        }
+        if (!this.api.isActive) {
+            this.api.setActive();
+        }
     };
     DockviewPanel.prototype.toJSON = function () {
         return {
@@ -165,20 +173,40 @@ var DockviewPanel = /** @class */ (function (_super) {
             },
         });
     };
-    DockviewPanel.prototype.updateParentGroup = function (group, isGroupActive) {
+    DockviewPanel.prototype.updateParentGroup = function (group, options) {
         this._group = group;
-        this.api.group = group;
+        this.api.group = this._group;
         var isPanelVisible = this._group.model.isPanelActive(this);
-        this.api._onDidActiveChange.fire({
-            isActive: isGroupActive && isPanelVisible,
-        });
-        this.api._onDidVisibilityChange.fire({
-            isVisible: isPanelVisible,
-        });
-        this.view.updateParentGroup(this._group, this._group.model.isPanelActive(this));
+        var isActive = this.group.api.isActive && isPanelVisible;
+        if (!(options === null || options === void 0 ? void 0 : options.skipSetActive)) {
+            if (this.api.isActive !== isActive) {
+                this.api._onDidActiveChange.fire({
+                    isActive: this.group.api.isActive && isPanelVisible,
+                });
+            }
+        }
+        if (this.api.isVisible !== isPanelVisible) {
+            this.api._onDidVisibilityChange.fire({
+                isVisible: isPanelVisible,
+            });
+        }
+    };
+    DockviewPanel.prototype.runEvents = function () {
+        var isPanelVisible = this._group.model.isPanelActive(this);
+        var isActive = this.group.api.isActive && isPanelVisible;
+        if (this.api.isActive !== isActive) {
+            this.api._onDidActiveChange.fire({
+                isActive: this.group.api.isActive && isPanelVisible,
+            });
+        }
+        if (this.api.isVisible !== isPanelVisible) {
+            this.api._onDidVisibilityChange.fire({
+                isVisible: isPanelVisible,
+            });
+        }
     };
     DockviewPanel.prototype.layout = function (width, height) {
-        // the obtain the correct dimensions of the content panel we must deduct the tab height
+        // TODO: Can we somehow do height without header height or indicate what the header height is?
         this.api._onDidDimensionChange.fire({
             width: width,
             height: height,
@@ -192,4 +220,3 @@ var DockviewPanel = /** @class */ (function (_super) {
     return DockviewPanel;
 }(lifecycle_1.CompositeDisposable));
 exports.DockviewPanel = DockviewPanel;
-//# sourceMappingURL=dockviewPanel.js.map

package/dist/cjs/dockview/dockviewPanelModel.d.ts

@@ -20,17 +20,14 @@ export declare class DockviewPanelModel implements IDockviewPanelModel {
     readonly tabComponent?: string | undefined;
     private readonly _content;
     private readonly _tab;
-    private _group;
-    private _isPanelVisible;
     get content(): IContentRenderer;
     get tab(): ITabRenderer;
     constructor(accessor: IDockviewComponent, id: string, contentComponent: string, tabComponent?: string | undefined);
     init(params: GroupPanelPartInitParameters): void;
-    updateParentGroup(group: DockviewGroupPanel, isPanelVisible: boolean): void;
+    updateParentGroup(_group: DockviewGroupPanel, _isPanelVisible: boolean): void;
     layout(width: number, height: number): void;
     update(event: PanelUpdateEvent): void;
     dispose(): void;
     private createContentComponent;
     private createTabComponent;
 }
-//# sourceMappingURL=dockviewPanelModel.d.ts.map

package/dist/cjs/dockview/dockviewPanelModel.js

@@ -20,8 +20,6 @@ var DockviewPanelModel = /** @class */ (function () {
         this.id = id;
         this.contentComponent = contentComponent;
         this.tabComponent = tabComponent;
-        this._group = null;
-        this._isPanelVisible = null;
         this._content = this.createContentComponent(this.id, contentComponent);
         this._tab = this.createTabComponent(this.id, tabComponent);
     }
@@ -43,25 +41,8 @@ var DockviewPanelModel = /** @class */ (function () {
         this.content.init(__assign(__assign({}, params), { tab: this.tab }));
         this.tab.init(params);
     };
-    DockviewPanelModel.prototype.updateParentGroup = function (group, isPanelVisible) {
-        if (group !== this._group) {
-            this._group = group;
-            if (this._content.onGroupChange) {
-                this._content.onGroupChange(group);
-            }
-            if (this._tab.onGroupChange) {
-                this._tab.onGroupChange(group);
-            }
-        }
-        if (isPanelVisible !== this._isPanelVisible) {
-            this._isPanelVisible = isPanelVisible;
-            if (this._content.onPanelVisibleChange) {
-                this._content.onPanelVisibleChange(isPanelVisible);
-            }
-            if (this._tab.onPanelVisibleChange) {
-                this._tab.onPanelVisibleChange(isPanelVisible);
-            }
-        }
+    DockviewPanelModel.prototype.updateParentGroup = function (_group, _isPanelVisible) {
+        // noop
     };
     DockviewPanelModel.prototype.layout = function (width, height) {
         var _a, _b;
@@ -96,4 +77,3 @@ var DockviewPanelModel = /** @class */ (function () {
     return DockviewPanelModel;
 }());
 exports.DockviewPanelModel = DockviewPanelModel;
-//# sourceMappingURL=dockviewPanelModel.js.map