dockview-core 1.8.2 → 1.8.4

package/dist/cjs/dockview/dockviewComponent.js

@@ -84,6 +84,67 @@ var dataTransfer_1 = require("../dnd/dataTransfer");
 var overlay_1 = require("../dnd/overlay");
 var dom_1 = require("../dom");
 var dockviewFloatingGroupPanel_1 = require("./dockviewFloatingGroupPanel");
+var DEFAULT_FLOATING_GROUP_OVERFLOW_SIZE = 100;
+function typeValidate3(data, path) {
+    if (typeof data.id !== 'string') {
+        throw new Error("".concat(path, ".id must be a string"));
+    }
+    if (typeof data.activeView !== 'string' ||
+        typeof data.activeView !== 'undefined') {
+        throw new Error("".concat(path, ".activeView must be a string of undefined"));
+    }
+}
+function typeValidate2(data, path) {
+    if (typeof data.size !== 'number' && typeof data.size !== 'undefined') {
+        throw new Error("".concat(path, ".size must be a number or undefined"));
+    }
+    if (typeof data.visible !== 'boolean' &&
+        typeof data.visible !== 'undefined') {
+        throw new Error("".concat(path, ".visible must be a boolean or undefined"));
+    }
+    if (data.type === 'leaf') {
+        if (typeof data.data !== 'object' ||
+            data.data === null ||
+            Array.isArray(data.data)) {
+            throw new Error('object must be a non-null object');
+        }
+        typeValidate3(data.data, "".concat(path, ".data"));
+    }
+    else if (data.type === 'branch') {
+        if (!Array.isArray(data.data)) {
+            throw new Error("".concat(path, ".data must be an array"));
+        }
+    }
+    else {
+        throw new Error("".concat(path, ".type must be onew of {'branch', 'leaf'}"));
+    }
+}
+function typeValidate(data) {
+    if (typeof data !== 'object' || data === null) {
+        throw new Error('object must be a non-null object');
+    }
+    var grid = data.grid, panels = data.panels, activeGroup = data.activeGroup, floatingGroups = data.floatingGroups;
+    if (typeof grid !== 'object' || grid === null) {
+        throw new Error("'.grid' must be a non-null object");
+    }
+    if (typeof grid.height !== 'number') {
+        throw new Error("'.grid.height' must be a number");
+    }
+    if (typeof grid.width !== 'number') {
+        throw new Error("'.grid.width' must be a number");
+    }
+    if (typeof grid.root !== 'object' || grid.root === null) {
+        throw new Error("'.grid.root' must be a non-null object");
+    }
+    if (grid.root.type !== 'branch') {
+        throw new Error(".grid.root.type must be of type 'branch'");
+    }
+    if (grid.orientation !== splitview_1.Orientation.HORIZONTAL &&
+        grid.orientation !== splitview_1.Orientation.VERTICAL) {
+        throw new Error("'.grid.width' must be one of {".concat(splitview_1.Orientation.HORIZONTAL, ", ").concat(splitview_1.Orientation.VERTICAL, "}"));
+    }
+    typeValidate2(grid.root, '.grid.root');
+}
 var DockviewComponent = /** @class */ (function (_super) {
     __extends(DockviewComponent, _super);
     function DockviewComponent(options) {
@@ -96,6 +157,10 @@ var DockviewComponent = /** @class */ (function (_super) {
         _this.nextGroupId = (0, math_1.sequentialNumberGenerator)();
         _this._deserializer = new deserializer_1.DefaultDockviewDeserialzier(_this);
         _this.watermark = null;
+        _this._onWillDragPanel = new events_1.Emitter();
+        _this.onWillDragPanel = _this._onWillDragPanel.event;
+        _this._onWillDragGroup = new events_1.Emitter();
+        _this.onWillDragGroup = _this._onWillDragGroup.event;
         _this._onDidDrop = new events_1.Emitter();
         _this.onDidDrop = _this._onDidDrop.event;
         _this._onDidRemovePanel = new events_1.Emitter();
@@ -108,7 +173,7 @@ var DockviewComponent = /** @class */ (function (_super) {
         _this.onDidActivePanelChange = _this._onDidActivePanelChange.event;
         _this.floatingGroups = [];
         (0, dom_1.toggleClass)(_this.gridview.element, 'dv-dockview', true);
-        _this.addDisposables(_this._onDidDrop, events_1.Event.any(_this.onDidAddGroup, _this.onDidRemoveGroup)(function () {
+        _this.addDisposables(_this._onWillDragPanel, _this._onWillDragGroup, _this._onDidActivePanelChange, _this._onDidAddPanel, _this._onDidRemovePanel, _this._onDidLayoutFromJSON, _this._onDidDrop, events_1.Event.any(_this.onDidAddGroup, _this.onDidRemoveGroup)(function () {
             _this.updateWatermark();
         }), events_1.Event.any(_this.onDidAddPanel, _this.onDidRemovePanel, _this.onDidActivePanelChange)(function () {
             _this._bufferOnDidLayoutChange.fire();
@@ -222,7 +287,7 @@ var DockviewComponent = /** @class */ (function (_super) {
     });
     DockviewComponent.prototype.addFloatingGroup = function (item, coord, options) {
         var _this = this;
-        var _a, _b;
+        var _a, _b, _c, _d, _e, _f;
         var group;
         if (item instanceof dockviewPanel_1.DockviewPanel) {
             group = this.createGroup();
@@ -250,8 +315,12 @@ var DockviewComponent = /** @class */ (function (_super) {
             width: (_b = coord === null || coord === void 0 ? void 0 : coord.width) !== null && _b !== void 0 ? _b : 300,
             left: overlayLeft,
             top: overlayTop,
-            minimumInViewportWidth: 100,
-            minimumInViewportHeight: 100,
+            minimumInViewportWidth: this.options.floatingGroupBounds === 'boundedWithinViewport'
+                ? undefined
+                : (_d = (_c = this.options.floatingGroupBounds) === null || _c === void 0 ? void 0 : _c.minimumWidthWithinViewport) !== null && _d !== void 0 ? _d : DEFAULT_FLOATING_GROUP_OVERFLOW_SIZE,
+            minimumInViewportHeight: this.options.floatingGroupBounds === 'boundedWithinViewport'
+                ? undefined
+                : (_f = (_e = this.options.floatingGroupBounds) === null || _e === void 0 ? void 0 : _e.minimumHeightWithinViewport) !== null && _f !== void 0 ? _f : DEFAULT_FLOATING_GROUP_OVERFLOW_SIZE,
         });
         var el = group.element.querySelector('.void-container');
         if (!el) {
@@ -324,16 +393,52 @@ var DockviewComponent = /** @class */ (function (_super) {
         }
     };
     DockviewComponent.prototype.updateOptions = function (options) {
+        var e_1, _a;
+        var _b, _c;
         var hasOrientationChanged = typeof options.orientation === 'string' &&
             this.gridview.orientation !== options.orientation;
+        var hasFloatingGroupOptionsChanged = options.floatingGroupBounds !== undefined &&
+            options.floatingGroupBounds !== this.options.floatingGroupBounds;
         this._options = __assign(__assign({}, this.options), options);
         if (hasOrientationChanged) {
             this.gridview.orientation = options.orientation;
         }
+        if (hasFloatingGroupOptionsChanged) {
+            try {
+                for (var _d = __values(this.floatingGroups), _e = _d.next(); !_e.done; _e = _d.next()) {
+                    var group = _e.value;
+                    switch (this.options.floatingGroupBounds) {
+                        case 'boundedWithinViewport':
+                            group.overlay.minimumInViewportHeight = undefined;
+                            group.overlay.minimumInViewportWidth = undefined;
+                            break;
+                        case undefined:
+                            group.overlay.minimumInViewportHeight =
+                                DEFAULT_FLOATING_GROUP_OVERFLOW_SIZE;
+                            group.overlay.minimumInViewportWidth =
+                                DEFAULT_FLOATING_GROUP_OVERFLOW_SIZE;
+                            break;
+                        default:
+                            group.overlay.minimumInViewportHeight =
+                                (_b = this.options.floatingGroupBounds) === null || _b === void 0 ? void 0 : _b.minimumHeightWithinViewport;
+                            group.overlay.minimumInViewportWidth =
+                                (_c = this.options.floatingGroupBounds) === null || _c === void 0 ? void 0 : _c.minimumWidthWithinViewport;
+                    }
+                    group.overlay.setBounds({});
+                }
+            }
+            catch (e_1_1) { e_1 = { error: e_1_1 }; }
+            finally {
+                try {
+                    if (_e && !_e.done && (_a = _d.return)) _a.call(_d);
+                }
+                finally { if (e_1) throw e_1.error; }
+            }
+        }
         this.layout(this.gridview.width, this.gridview.height, true);
     };
     DockviewComponent.prototype.layout = function (width, height, forceResize) {
-        var e_1, _a;
+        var e_2, _a;
         _super.prototype.layout.call(this, width, height, forceResize);
         if (this.floatingGroups) {
             try {
@@ -343,12 +448,12 @@ var DockviewComponent = /** @class */ (function (_super) {
                     floating.overlay.setBounds();
                 }
             }
-            catch (e_1_1) { e_1 = { error: e_1_1 }; }
+            catch (e_2_1) { e_2 = { error: e_2_1 }; }
             finally {
                 try {
                     if (_c && !_c.done && (_a = _b.return)) _a.call(_b);
                 }
-                finally { if (e_1) throw e_1.error; }
+                finally { if (e_2) throw e_2.error; }
             }
         }
     };
@@ -433,101 +538,194 @@ var DockviewComponent = /** @class */ (function (_super) {
         return result;
     };
     DockviewComponent.prototype.fromJSON = function (data) {
-        var e_2, _a, e_3, _b;
+        var e_3, _a, e_4, _b, e_5, _c, e_6, _d, e_7, _e, e_8, _f;
         var _this = this;
-        var _c;
+        var _g;
         this.clear();
+        if (typeof data !== 'object' || data === null) {
+            throw new Error('serialized layout must be a non-null object');
+        }
         var grid = data.grid, panels = data.panels, activeGroup = data.activeGroup;
         if (grid.root.type !== 'branch' || !Array.isArray(grid.root.data)) {
             throw new Error('root must be of type branch');
         }
-        // take note of the existing dimensions
-        var width = this.width;
-        var height = this.height;
-        var createGroupFromSerializedState = function (data) {
-            var e_4, _a;
-            var id = data.id, locked = data.locked, hideHeader = data.hideHeader, views = data.views, activeView = data.activeView;
-            var group = _this.createGroup({
-                id: id,
-                locked: !!locked,
-                hideHeader: !!hideHeader,
-            });
-            _this._onDidAddGroup.fire(group);
-            try {
-                for (var views_1 = __values(views), views_1_1 = views_1.next(); !views_1_1.done; views_1_1 = views_1.next()) {
-                    var child = views_1_1.value;
-                    var panel = _this._deserializer.fromJSON(panels[child], group);
-                    var isActive = typeof activeView === 'string' && activeView === panel.id;
+        try {
+            // take note of the existing dimensions
+            var width = this.width;
+            var height = this.height;
+            var createGroupFromSerializedState_1 = function (data) {
+                var e_9, _a;
+                var id = data.id, locked = data.locked, hideHeader = data.hideHeader, views = data.views, activeView = data.activeView;
+                if (typeof id !== 'string') {
+                    throw new Error('group id must be of type string');
+                }
+                var group = _this.createGroup({
+                    id: id,
+                    locked: !!locked,
+                    hideHeader: !!hideHeader,
+                });
+                var createdPanels = [];
+                try {
+                    for (var views_1 = __values(views), views_1_1 = views_1.next(); !views_1_1.done; views_1_1 = views_1.next()) {
+                        var child = views_1_1.value;
+                        /**
+                         * Run the deserializer step seperately since this may fail to due corrupted external state.
+                         * In running this section first we avoid firing lots of 'add' events in the event of a failure
+                         * due to a corruption of input data.
+                         */
+                        var panel = _this._deserializer.fromJSON(panels[child], group);
+                        createdPanels.push(panel);
+                    }
+                }
+                catch (e_9_1) { e_9 = { error: e_9_1 }; }
+                finally {
+                    try {
+                        if (views_1_1 && !views_1_1.done && (_a = views_1.return)) _a.call(views_1);
+                    }
+                    finally { if (e_9) throw e_9.error; }
+                }
+                _this._onDidAddGroup.fire(group);
+                for (var i = 0; i < views.length; i++) {
+                    var panel = createdPanels[i];
+                    var isActive = typeof activeView === 'string' &&
+                        activeView === panel.id;
                     group.model.openPanel(panel, {
                         skipSetPanelActive: !isActive,
                         skipSetGroupActive: true,
                     });
                 }
+                if (!group.activePanel && group.panels.length > 0) {
+                    group.model.openPanel(group.panels[group.panels.length - 1], {
+                        skipSetGroupActive: true,
+                    });
+                }
+                return group;
+            };
+            this.gridview.deserialize(grid, {
+                fromJSON: function (node) {
+                    return createGroupFromSerializedState_1(node.data);
+                },
+            });
+            this.layout(width, height, true);
+            var serializedFloatingGroups = (_g = data.floatingGroups) !== null && _g !== void 0 ? _g : [];
+            try {
+                for (var serializedFloatingGroups_1 = __values(serializedFloatingGroups), serializedFloatingGroups_1_1 = serializedFloatingGroups_1.next(); !serializedFloatingGroups_1_1.done; serializedFloatingGroups_1_1 = serializedFloatingGroups_1.next()) {
+                    var serializedFloatingGroup = serializedFloatingGroups_1_1.value;
+                    var data_1 = serializedFloatingGroup.data, position = serializedFloatingGroup.position;
+                    var group = createGroupFromSerializedState_1(data_1);
+                    this.addFloatingGroup(group, {
+                        x: position.left,
+                        y: position.top,
+                        height: position.height,
+                        width: position.width,
+                    }, { skipRemoveGroup: true, inDragMode: false });
+                }
+            }
+            catch (e_3_1) { e_3 = { error: e_3_1 }; }
+            finally {
+                try {
+                    if (serializedFloatingGroups_1_1 && !serializedFloatingGroups_1_1.done && (_a = serializedFloatingGroups_1.return)) _a.call(serializedFloatingGroups_1);
+                }
+                finally { if (e_3) throw e_3.error; }
+            }
+            try {
+                for (var _h = __values(this.floatingGroups), _j = _h.next(); !_j.done; _j = _h.next()) {
+                    var floatingGroup = _j.value;
+                    floatingGroup.overlay.setBounds();
+                }
             }
             catch (e_4_1) { e_4 = { error: e_4_1 }; }
             finally {
                 try {
-                    if (views_1_1 && !views_1_1.done && (_a = views_1.return)) _a.call(views_1);
+                    if (_j && !_j.done && (_b = _h.return)) _b.call(_h);
                 }
                 finally { if (e_4) throw e_4.error; }
             }
-            if (!group.activePanel && group.panels.length > 0) {
-                group.model.openPanel(group.panels[group.panels.length - 1], {
-                    skipSetGroupActive: true,
-                });
+            if (typeof activeGroup === 'string') {
+                var panel = this.getPanel(activeGroup);
+                if (panel) {
+                    this.doSetGroupActive(panel);
+                }
             }
-            return group;
-        };
-        this.gridview.deserialize(grid, {
-            fromJSON: function (node) {
-                return createGroupFromSerializedState(node.data);
-            },
-        });
-        this.layout(width, height, true);
-        var serializedFloatingGroups = (_c = data.floatingGroups) !== null && _c !== void 0 ? _c : [];
-        try {
-            for (var serializedFloatingGroups_1 = __values(serializedFloatingGroups), serializedFloatingGroups_1_1 = serializedFloatingGroups_1.next(); !serializedFloatingGroups_1_1.done; serializedFloatingGroups_1_1 = serializedFloatingGroups_1.next()) {
-                var serializedFloatingGroup = serializedFloatingGroups_1_1.value;
-                var data_1 = serializedFloatingGroup.data, position = serializedFloatingGroup.position;
-                var group = createGroupFromSerializedState(data_1);
-                this.addFloatingGroup(group, {
-                    x: position.left,
-                    y: position.top,
-                    height: position.height,
-                    width: position.width,
-                }, { skipRemoveGroup: true, inDragMode: false });
-            }
-        }
-        catch (e_2_1) { e_2 = { error: e_2_1 }; }
-        finally {
+        }
+        catch (err) {
             try {
-                if (serializedFloatingGroups_1_1 && !serializedFloatingGroups_1_1.done && (_a = serializedFloatingGroups_1.return)) _a.call(serializedFloatingGroups_1);
+                /**
+                 * Takes all the successfully created groups and remove all of their panels.
+                 */
+                for (var _k = __values(this.groups), _l = _k.next(); !_l.done; _l = _k.next()) {
+                    var group = _l.value;
+                    try {
+                        for (var _m = (e_6 = void 0, __values(group.panels)), _o = _m.next(); !_o.done; _o = _m.next()) {
+                            var panel = _o.value;
+                            this.removePanel(panel, {
+                                removeEmptyGroup: false,
+                                skipDispose: false,
+                            });
+                        }
+                    }
+                    catch (e_6_1) { e_6 = { error: e_6_1 }; }
+                    finally {
+                        try {
+                            if (_o && !_o.done && (_d = _m.return)) _d.call(_m);
+                        }
+                        finally { if (e_6) throw e_6.error; }
+                    }
+                }
             }
-            finally { if (e_2) throw e_2.error; }
-        }
-        try {
-            for (var _d = __values(this.floatingGroups), _e = _d.next(); !_e.done; _e = _d.next()) {
-                var floatingGroup = _e.value;
-                floatingGroup.overlay.setBounds();
+            catch (e_5_1) { e_5 = { error: e_5_1 }; }
+            finally {
+                try {
+                    if (_l && !_l.done && (_c = _k.return)) _c.call(_k);
+                }
+                finally { if (e_5) throw e_5.error; }
             }
-        }
-        catch (e_3_1) { e_3 = { error: e_3_1 }; }
-        finally {
             try {
-                if (_e && !_e.done && (_b = _d.return)) _b.call(_d);
+                /**
+                 * To remove a group we cannot call this.removeGroup(...) since this makes assumptions about
+                 * the underlying HTMLElement existing in the Gridview.
+                 */
+                for (var _p = __values(this.groups), _q = _p.next(); !_q.done; _q = _p.next()) {
+                    var group = _q.value;
+                    group.dispose();
+                    this._groups.delete(group.id);
+                    this._onDidRemoveGroup.fire(group);
+                }
             }
-            finally { if (e_3) throw e_3.error; }
-        }
-        if (typeof activeGroup === 'string') {
-            var panel = this.getPanel(activeGroup);
-            if (panel) {
-                this.doSetGroupActive(panel);
+            catch (e_7_1) { e_7 = { error: e_7_1 }; }
+            finally {
+                try {
+                    if (_q && !_q.done && (_e = _p.return)) _e.call(_p);
+                }
+                finally { if (e_7) throw e_7.error; }
+            }
+            try {
+                // iterate over a reassigned array since original array will be modified
+                for (var _r = __values(__spreadArray([], __read(this.floatingGroups), false)), _s = _r.next(); !_s.done; _s = _r.next()) {
+                    var floatingGroup = _s.value;
+                    floatingGroup.dispose();
+                }
             }
+            catch (e_8_1) { e_8 = { error: e_8_1 }; }
+            finally {
+                try {
+                    if (_s && !_s.done && (_f = _r.return)) _f.call(_r);
+                }
+                finally { if (e_8) throw e_8.error; }
+            }
+            // fires clean-up events and clears the underlying HTML gridview.
+            this.clear();
+            /**
+             * even though we have cleaned-up we still want to inform the caller of their error
+             * and we'll do this through re-throwing the original error since afterall you would
+             * expect trying to load a corrupted layout to result in an error and not silently fail...
+             */
+            throw err;
         }
         this._onDidLayoutFromJSON.fire();
     };
     DockviewComponent.prototype.clear = function () {
-        var e_5, _a;
+        var e_10, _a;
         var groups = Array.from(this._groups.values()).map(function (_) { return _.value; });
         var hasActiveGroup = !!this.activeGroup;
         var hasActivePanel = !!this.activePanel;
@@ -538,12 +736,12 @@ var DockviewComponent = /** @class */ (function (_super) {
                 this.removeGroup(group, { skipActive: true });
             }
         }
-        catch (e_5_1) { e_5 = { error: e_5_1 }; }
+        catch (e_10_1) { e_10 = { error: e_10_1 }; }
         finally {
             try {
                 if (groups_1_1 && !groups_1_1.done && (_a = groups_1.return)) _a.call(groups_1);
             }
-            finally { if (e_5) throw e_5.error; }
+            finally { if (e_10) throw e_10.error; }
         }
         if (hasActiveGroup) {
             this.doSetGroupActive(undefined);
@@ -554,7 +752,7 @@ var DockviewComponent = /** @class */ (function (_super) {
         this.gridview.clear();
     };
     DockviewComponent.prototype.closeAllGroups = function () {
-        var e_6, _a;
+        var e_11, _a;
         try {
             for (var _b = __values(this._groups.entries()), _c = _b.next(); !_c.done; _c = _b.next()) {
                 var entry = _c.value;
@@ -562,12 +760,12 @@ var DockviewComponent = /** @class */ (function (_super) {
                 group.value.model.closeAllPanels();
             }
         }
-        catch (e_6_1) { e_6 = { error: e_6_1 }; }
+        catch (e_11_1) { e_11 = { error: e_11_1 }; }
         finally {
             try {
                 if (_c && !_c.done && (_a = _b.return)) _a.call(_b);
             }
-            finally { if (e_6) throw e_6.error; }
+            finally { if (e_11) throw e_11.error; }
         }
     };
     DockviewComponent.prototype.addPanel = function (options) {
@@ -743,7 +941,7 @@ var DockviewComponent = /** @class */ (function (_super) {
         }
     };
     DockviewComponent.prototype.removeGroup = function (group, options) {
-        var e_7, _a;
+        var e_12, _a;
         var _b;
         var panels = __spreadArray([], __read(group.panels), false); // reassign since group panels will mutate
         try {
@@ -755,12 +953,12 @@ var DockviewComponent = /** @class */ (function (_super) {
                 });
             }
         }
-        catch (e_7_1) { e_7 = { error: e_7_1 }; }
+        catch (e_12_1) { e_12 = { error: e_12_1 }; }
         finally {
             try {
                 if (panels_1_1 && !panels_1_1.done && (_a = panels_1.return)) _a.call(panels_1);
             }
-            finally { if (e_7) throw e_7.error; }
+            finally { if (e_12) throw e_12.error; }
         }
         this.doRemoveGroup(group, options);
     };
@@ -770,6 +968,7 @@ var DockviewComponent = /** @class */ (function (_super) {
             if (!(options === null || options === void 0 ? void 0 : options.skipDispose)) {
                 floatingGroup.group.dispose();
                 this._groups.delete(group.id);
+                // TODO: fire group removed event?
             }
             floatingGroup.dispose();
             return floatingGroup.group;
@@ -839,7 +1038,7 @@ var DockviewComponent = /** @class */ (function (_super) {
         }
     };
     DockviewComponent.prototype.moveGroup = function (sourceGroup, referenceGroup, target) {
-        var e_8, _a;
+        var e_13, _a;
         if (sourceGroup) {
             if (!target || target === 'center') {
                 var activePanel = sourceGroup.activePanel;
@@ -857,12 +1056,12 @@ var DockviewComponent = /** @class */ (function (_super) {
                         });
                     }
                 }
-                catch (e_8_1) { e_8 = { error: e_8_1 }; }
+                catch (e_13_1) { e_13 = { error: e_13_1 }; }
                 finally {
                     try {
                         if (panels_2_1 && !panels_2_1.done && (_a = panels_2.return)) _a.call(panels_2);
                     }
-                    finally { if (e_8) throw e_8.error; }
+                    finally { if (e_13) throw e_13.error; }
                 }
             }
             else {
@@ -906,7 +1105,11 @@ var DockviewComponent = /** @class */ (function (_super) {
         var view = new dockviewGroupPanel_1.DockviewGroupPanel(this, id, options);
         view.init({ params: {}, accessor: null }); // required to initialized .part and allow for correct disposal of group
         if (!this._groups.has(view.id)) {
-            var disposable = new lifecycle_1.CompositeDisposable(view.model.onMove(function (event) {
+            var disposable = new lifecycle_1.CompositeDisposable(view.model.onTabDragStart(function (event) {
+                _this._onWillDragPanel.fire(event);
+            }), view.model.onGroupDragStart(function (event) {
+                _this._onWillDragGroup.fire(event);
+            }), view.model.onMove(function (event) {
                 var groupId = event.groupId, itemId = event.itemId, target = event.target, index = event.index;
                 _this.moveGroupOrPanel(view, groupId, itemId, target, index);
             }), view.model.onDidDrop(function (event) {
@@ -948,13 +1151,6 @@ var DockviewComponent = /** @class */ (function (_super) {
             return group.value.model.containsPanel(panel);
         })) === null || _a === void 0 ? void 0 : _a.value;
     };
-    DockviewComponent.prototype.dispose = function () {
-        this._onDidActivePanelChange.dispose();
-        this._onDidAddPanel.dispose();
-        this._onDidRemovePanel.dispose();
-        this._onDidLayoutFromJSON.dispose();
-        _super.prototype.dispose.call(this);
-    };
     return DockviewComponent;
 }(baseComponentGridview_1.BaseGrid));
 exports.DockviewComponent = DockviewComponent;