dockview-core 1.17.2 → 2.1.0

package/dist/esm/popoutWindow.js

@@ -9,7 +9,7 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
 };
 import { addStyles } from './dom';
 import { Emitter, addDisposableWindowListener } from './events';
-import { CompositeDisposable } from './lifecycle';
+import { CompositeDisposable, Disposable } from './lifecycle';
 export class PopoutWindow extends CompositeDisposable {
     get window() {
         var _a, _b;
@@ -50,7 +50,6 @@ export class PopoutWindow extends CompositeDisposable {
                 window: this._window.value,
             });
             this._window.disposable.dispose();
-            this._window.value.close();
             this._window = null;
             this._onDidClose.fire();
         }
@@ -82,7 +81,9 @@ export class PopoutWindow extends CompositeDisposable {
             }
             const disposable = new CompositeDisposable();
             this._window = { value: externalWindow, disposable };
-            disposable.addDisposables(addDisposableWindowListener(window, 'beforeunload', () => {
+            disposable.addDisposables(Disposable.from(() => {
+                externalWindow.close();
+            }), addDisposableWindowListener(window, 'beforeunload', () => {
                 /**
                  * before the main window closes we should close this popup too
                  * to be good citizens
@@ -99,7 +100,7 @@ export class PopoutWindow extends CompositeDisposable {
                 id: this.target,
                 window: externalWindow,
             });
-            return new Promise((resolve) => {
+            return new Promise((resolve, reject) => {
                 externalWindow.addEventListener('unload', (e) => {
                     // if page fails to load before unloading
                     // this.close();
@@ -108,21 +109,27 @@ export class PopoutWindow extends CompositeDisposable {
                     /**
                      * @see https://developer.mozilla.org/en-US/docs/Web/API/Window/load_event
                      */
-                    const externalDocument = externalWindow.document;
-                    externalDocument.title = document.title;
-                    externalDocument.body.appendChild(container);
-                    addStyles(externalDocument, window.document.styleSheets);
-                    /**
-                     * beforeunload must be registered after load for reasons I could not determine
-                     * otherwise the beforeunload event will not fire when the window is closed
-                     */
-                    addDisposableWindowListener(externalWindow, 'beforeunload', () => {
+                    try {
+                        const externalDocument = externalWindow.document;
+                        externalDocument.title = document.title;
+                        externalDocument.body.appendChild(container);
+                        addStyles(externalDocument, window.document.styleSheets);
                         /**
-                         * @see https://developer.mozilla.org/en-US/docs/Web/API/Window/beforeunload_event
+                         * beforeunload must be registered after load for reasons I could not determine
+                         * otherwise the beforeunload event will not fire when the window is closed
                          */
-                        this.close();
-                    });
-                    resolve(container);
+                        addDisposableWindowListener(externalWindow, 'beforeunload', () => {
+                            /**
+                             * @see https://developer.mozilla.org/en-US/docs/Web/API/Window/beforeunload_event
+                             */
+                            this.close();
+                        });
+                        resolve(container);
+                    }
+                    catch (err) {
+                        // only except this is the DOM isn't setup. e.g. in a in correctly configured test
+                        reject(err);
+                    }
                 });
             });
         });

package/dist/esm/splitview/splitview.d.ts

@@ -67,17 +67,17 @@ export interface ISplitViewDescriptor {
 }
 export declare class Splitview {
     private readonly container;
-    private element;
-    private viewContainer;
-    private sashContainer;
-    private viewItems;
-    private sashes;
+    private readonly element;
+    private readonly viewContainer;
+    private readonly sashContainer;
+    private readonly viewItems;
+    private readonly sashes;
     private _orientation;
     private _size;
     private _orthogonalSize;
     private _contentSize;
     private _proportions;
-    private proportionalLayout;
+    private readonly proportionalLayout;
     private _startSnappingEnabled;
     private _endSnappingEnabled;
     private _disabled;

package/dist/esm/splitview/splitview.js

@@ -67,10 +67,10 @@ export class Splitview {
         const tmp = this.size;
         this.size = this.orthogonalSize;
         this.orthogonalSize = tmp;
-        removeClasses(this.element, 'horizontal', 'vertical');
+        removeClasses(this.element, 'dv-horizontal', 'dv-vertical');
         this.element.classList.add(this.orientation == Orientation.HORIZONTAL
-            ? 'horizontal'
-            : 'vertical');
+            ? 'dv-horizontal'
+            : 'dv-vertical');
     }
     get minimumSize() {
         return this.viewItems.reduce((r, item) => r + item.minimumSize, 0);
@@ -248,11 +248,11 @@ export class Splitview {
     }
     style(styles) {
         if ((styles === null || styles === void 0 ? void 0 : styles.separatorBorder) === 'transparent') {
-            removeClasses(this.element, 'separator-border');
+            removeClasses(this.element, 'dv-separator-border');
             this.element.style.removeProperty('--dv-separator-border');
         }
         else {
-            addClasses(this.element, 'separator-border');
+            addClasses(this.element, 'dv-separator-border');
             if (styles === null || styles === void 0 ? void 0 : styles.separatorBorder) {
                 this.element.style.setProperty('--dv-separator-border', styles.separatorBorder);
             }
@@ -322,7 +322,7 @@ export class Splitview {
     }
     addView(view, size = { type: 'distribute' }, index = this.viewItems.length, skipLayout) {
         const container = document.createElement('div');
-        container.className = 'view';
+        container.className = 'dv-view';
         container.appendChild(view.element);
         let viewSize;
         if (typeof size === 'number') {
@@ -354,7 +354,7 @@ export class Splitview {
         if (this.viewItems.length > 1) {
             //add sash
             const sash = document.createElement('div');
-            sash.className = 'sash';
+            sash.className = 'dv-sash';
             const onPointerStart = (event) => {
                 for (const item of this.viewItems) {
                     item.enabled = false;
@@ -613,7 +613,8 @@ export class Splitview {
             const offset = i === 0 || visiblePanelsBeforeThisView === 0
                 ? 0
                 : viewLeftOffsets[i - 1] +
-                    (visiblePanelsBeforeThisView / sashCount) * marginReducedSize;
+                    (visiblePanelsBeforeThisView / sashCount) *
+                        marginReducedSize;
             if (i < this.viewItems.length - 1) {
                 // calculate sash position
                 const newSize = view.visible
@@ -724,27 +725,27 @@ export class Splitview {
         }
     }
     updateSash(sash, state) {
-        toggleClass(sash.container, 'disabled', state === SashState.DISABLED);
-        toggleClass(sash.container, 'enabled', state === SashState.ENABLED);
-        toggleClass(sash.container, 'maximum', state === SashState.MAXIMUM);
-        toggleClass(sash.container, 'minimum', state === SashState.MINIMUM);
+        toggleClass(sash.container, 'dv-disabled', state === SashState.DISABLED);
+        toggleClass(sash.container, 'dv-enabled', state === SashState.ENABLED);
+        toggleClass(sash.container, 'dv-maximum', state === SashState.MAXIMUM);
+        toggleClass(sash.container, 'dv-minimum', state === SashState.MINIMUM);
     }
     createViewContainer() {
         const element = document.createElement('div');
-        element.className = 'view-container';
+        element.className = 'dv-view-container';
         return element;
     }
     createSashContainer() {
         const element = document.createElement('div');
-        element.className = 'sash-container';
+        element.className = 'dv-sash-container';
         return element;
     }
     createContainer() {
         const element = document.createElement('div');
         const orientationClassname = this._orientation === Orientation.HORIZONTAL
-            ? 'horizontal'
-            : 'vertical';
-        element.className = `split-view-container ${orientationClassname}`;
+            ? 'dv-horizontal'
+            : 'dv-vertical';
+        element.className = `dv-split-view-container ${orientationClassname}`;
         return element;
     }
     dispose() {

package/dist/esm/splitview/splitviewComponent.d.ts

@@ -59,10 +59,10 @@ export interface ISplitviewComponent extends IDisposable {
  * A high-level implementation of splitview that works using 'panels'
  */
 export declare class SplitviewComponent extends Resizable implements ISplitviewComponent {
-    private _splitviewChangeDisposable;
+    private readonly _splitviewChangeDisposable;
     private _splitview;
     private _activePanel;
-    private _panels;
+    private readonly _panels;
     private _options;
     private readonly _onDidLayoutfromJSON;
     readonly onDidLayoutFromJSON: Event<void>;

package/dist/esm/splitview/viewItem.d.ts

@@ -3,7 +3,7 @@ import { IView, LayoutPriority } from './splitview';
 export declare class ViewItem {
     container: HTMLElement;
     view: IView;
-    private disposable;
+    private readonly disposable;
     private _size;
     private _cachedVisibleSize;
     set size(size: number);

package/dist/esm/svg.js

@@ -5,7 +5,7 @@ const createSvgElementFromPath = (params) => {
     svg.setAttributeNS(null, 'viewBox', params.viewbox);
     svg.setAttributeNS(null, 'aria-hidden', 'false');
     svg.setAttributeNS(null, 'focusable', 'false');
-    svg.classList.add('dockview-svg');
+    svg.classList.add('dv-svg');
     const path = document.createElementNS('http://www.w3.org/2000/svg', 'path');
     path.setAttributeNS(null, 'd', params.path);
     svg.appendChild(path);