dockview-core 1.13.1 → 1.14.0

package/dist/cjs/api/dockviewGroupPanelApi.js

@@ -20,8 +20,7 @@ var droptarget_1 = require("../dnd/droptarget");
 var events_1 = require("../events");
 var lifecycle_1 = require("../lifecycle");
 var gridviewPanelApi_1 = require("./gridviewPanelApi");
-// TODO find a better way to initialize and avoid needing null checks
-var NOT_INITIALIZED_MESSAGE = 'DockviewGroupPanelApiImpl not initialized';
+var NOT_INITIALIZED_MESSAGE = 'dockview: DockviewGroupPanelApiImpl not initialized';
 var DockviewGroupPanelApiImpl = /** @class */ (function (_super) {
     __extends(DockviewGroupPanelApiImpl, _super);
     function DockviewGroupPanelApiImpl(id, accessor) {
@@ -100,15 +99,15 @@ var DockviewGroupPanelApiImpl = /** @class */ (function (_super) {
         }
     };
     DockviewGroupPanelApiImpl.prototype.initialize = function (group) {
-        var _this = this;
-        this._group = group;
         /**
-         * TODO: Annoying initialization order caveat
+         * TODO: Annoying initialization order caveat, find a better way to initialize and avoid needing null checks
          *
          * Due to the order on initialization we know that the model isn't defined until later in the same stack-frame of setup.
          * By queuing a microtask we can ensure the setup is completed within the same stack-frame, but after everything else has
          * finished ensuring the `model` is defined.
          */
+        var _this = this;
+        this._group = group;
         queueMicrotask(function () {
             _this._mutableDisposable.value =
                 _this._group.model.onDidActivePanelChange(function (event) {

package/dist/cjs/api/dockviewPanelApi.js

@@ -133,12 +133,10 @@ var DockviewPanelApiImpl = /** @class */ (function (_super) {
         var _a;
         var _trackGroupActive = (_a = previousGroup === null || previousGroup === void 0 ? void 0 : previousGroup.isActive) !== null && _a !== void 0 ? _a : false; // prevent duplicate events with same state
         this.groupEventsDisposable.value = new lifecycle_1.CompositeDisposable(this.group.api.onDidVisibilityChange(function (event) {
-            if (!event.isVisible && _this.isVisible) {
-                _this._onDidVisibilityChange.fire(event);
-            }
-            else if (event.isVisible &&
-                !_this.isVisible &&
-                _this.group.model.isPanelActive(_this.panel)) {
+            var hasBecomeHidden = !event.isVisible && _this.isVisible;
+            var hasBecomeVisible = event.isVisible && !_this.isVisible;
+            var isActivePanel = _this.group.model.isPanelActive(_this.panel);
+            if (hasBecomeHidden || (hasBecomeVisible && isActivePanel)) {
                 _this._onDidVisibilityChange.fire(event);
             }
         }), this.group.api.onDidLocationChange(function (event) {

package/dist/cjs/dockview/dockviewComponent.js

@@ -447,7 +447,7 @@ var DockviewComponent = /** @class */ (function (_super) {
             return element.getBoundingClientRect();
         }
         var box = getBox();
-        var groupId = (_b = (_a = options === null || options === void 0 ? void 0 : options.overridePopoutGroup) === null || _a === void 0 ? void 0 : _a.id) !== null && _b !== void 0 ? _b : this.getNextGroupId(); //item.id;
+        var groupId = (_b = (_a = options === null || options === void 0 ? void 0 : options.overridePopoutGroup) === null || _a === void 0 ? void 0 : _a.id) !== null && _b !== void 0 ? _b : this.getNextGroupId();
         if (itemToPopout.api.location.type === 'grid') {
             itemToPopout.api.setVisible(false);
         }
@@ -567,24 +567,22 @@ var DockviewComponent = /** @class */ (function (_super) {
                         });
                     }
                 }
-                else {
-                    if (_this.getPanel(group.id)) {
-                        var removedGroup = _this.doRemoveGroup(group, {
-                            skipDispose: true,
-                            skipActive: true,
-                        });
-                        removedGroup.model.renderContainer =
-                            _this.overlayRenderContainer;
-                        removedGroup.model.location = { type: 'grid' };
-                        returnedGroup = removedGroup;
-                    }
+                else if (_this.getPanel(group.id)) {
+                    var removedGroup = _this.doRemoveGroup(group, {
+                        skipDispose: true,
+                        skipActive: true,
+                    });
+                    removedGroup.model.renderContainer =
+                        _this.overlayRenderContainer;
+                    removedGroup.model.location = { type: 'grid' };
+                    returnedGroup = removedGroup;
                 }
             }));
             _this._popoutGroups.push(value);
             _this.updateWatermark();
         })
             .catch(function (err) {
-            console.error(err);
+            console.error('dockview: failed to create popout window', err);
         });
     };
     DockviewComponent.prototype.addFloatingGroup = function (item, coord, options) {
@@ -634,7 +632,7 @@ var DockviewComponent = /** @class */ (function (_super) {
                     this.doRemoveGroup(item, {
                         skipDispose: true,
                         skipPopoutReturn: true,
-                        skipPopoutAssociated: !!popoutReferenceGroup_1,
+                        skipPopoutAssociated: false,
                     });
                 }
             }
@@ -1104,7 +1102,6 @@ var DockviewComponent = /** @class */ (function (_super) {
         var e_13, _a;
         var groups = Array.from(this._groups.values()).map(function (_) { return _.value; });
         var hasActiveGroup = !!this.activeGroup;
-        var hasActivePanel = !!this.activePanel;
         try {
             for (var groups_1 = __values(groups), groups_1_1 = groups_1.next(); !groups_1_1.done; groups_1_1 = groups_1.next()) {
                 var group = groups_1_1.value;
@@ -1671,7 +1668,7 @@ var DockviewComponent = /** @class */ (function (_super) {
         }
         var id = options === null || options === void 0 ? void 0 : options.id;
         if (id && this._groups.has(options.id)) {
-            console.warn("Duplicate group id ".concat(options === null || options === void 0 ? void 0 : options.id, ". reassigning group id to avoid errors"));
+            console.warn("dockview: Duplicate group id ".concat(options === null || options === void 0 ? void 0 : options.id, ". reassigning group id to avoid errors"));
             id = undefined;
         }
         if (!id) {

package/dist/cjs/dockview/dockviewPanel.js

@@ -123,12 +123,6 @@ var DockviewPanel = /** @class */ (function (_super) {
         var didTitleChange = title !== this.title;
         if (didTitleChange) {
             this._title = title;
-            this.view.update({
-                params: {
-                    params: this._params,
-                    title: this.title,
-                },
-            });
             this.api._onDidTitleChange.fire({ title: title });
         }
     };
@@ -167,10 +161,7 @@ var DockviewPanel = /** @class */ (function (_super) {
         }
         // update the view with the updated props
         this.view.update({
-            params: {
-                params: this._params,
-                title: this.title,
-            },
+            params: this._params,
         });
     };
     DockviewPanel.prototype.updateParentGroup = function (group, options) {

package/dist/cjs/events.js

@@ -79,7 +79,7 @@ var Stacktrace = /** @class */ (function () {
         return new Stacktrace((_a = new Error().stack) !== null && _a !== void 0 ? _a : '');
     };
     Stacktrace.prototype.print = function () {
-        console.warn(this.value);
+        console.warn('dockview: stacktrace', this.value);
     };
     return Stacktrace;
 }());
@@ -129,7 +129,7 @@ var Emitter = /** @class */ (function () {
                             }
                             else if (Emitter.ENABLE_TRACKING) {
                                 // console.warn(
-                                //     `Listener already disposed`,
+                                //     `dockview: listener already disposed`,
                                 //     Stacktrace.create().print()
                                 // );
                             }
@@ -175,7 +175,7 @@ var Emitter = /** @class */ (function () {
                             // don't check until stack of execution is completed to allow for out-of-order disposals within the same execution block
                             for (var _c = __values(_this._listeners), _d = _c.next(); !_d.done; _d = _c.next()) {
                                 var listener = _d.value;
-                                console.warn((_b = listener.stacktrace) === null || _b === void 0 ? void 0 : _b.print());
+                                console.warn('dockview: stacktrace', (_b = listener.stacktrace) === null || _b === void 0 ? void 0 : _b.print());
                             }
                         }
                         catch (e_2_1) { e_2 = { error: e_2_1 }; }

package/dist/dockview-core.amd.js

@@ -1,6 +1,6 @@
 /**
  * dockview-core
- * @version 1.13.1
+ * @version 1.14.0
  * @link https://github.com/mathuo/dockview
  * @license MIT
  */
@@ -155,7 +155,7 @@ define(['exports'], (function (exports) { 'use strict';
           this.value = value;
       }
       print() {
-          console.warn(this.value);
+          console.warn('dockview: stacktrace', this.value);
       }
   }
   class Listener {
@@ -220,7 +220,7 @@ define(['exports'], (function (exports) { 'use strict';
                           var _a;
                           // don't check until stack of execution is completed to allow for out-of-order disposals within the same execution block
                           for (const listener of this._listeners) {
-                              console.warn((_a = listener.stacktrace) === null || _a === void 0 ? void 0 : _a.print());
+                              console.warn('dockview: stacktrace', (_a = listener.stacktrace) === null || _a === void 0 ? void 0 : _a.print());
                           }
                       });
                   }
@@ -5770,8 +5770,7 @@ define(['exports'], (function (exports) { 'use strict';
       }
   }
 
-  // TODO find a better way to initialize and avoid needing null checks
-  const NOT_INITIALIZED_MESSAGE = 'DockviewGroupPanelApiImpl not initialized';
+  const NOT_INITIALIZED_MESSAGE = 'dockview: DockviewGroupPanelApiImpl not initialized';
   class DockviewGroupPanelApiImpl extends GridviewPanelApiImpl {
       get location() {
           if (!this._group) {
@@ -5844,14 +5843,14 @@ define(['exports'], (function (exports) { 'use strict';
           }
       }
       initialize(group) {
-          this._group = group;
           /**
-           * TODO: Annoying initialization order caveat
+           * TODO: Annoying initialization order caveat, find a better way to initialize and avoid needing null checks
            *
            * Due to the order on initialization we know that the model isn't defined until later in the same stack-frame of setup.
            * By queuing a microtask we can ensure the setup is completed within the same stack-frame, but after everything else has
            * finished ensuring the `model` is defined.
            */
+          this._group = group;
           queueMicrotask(() => {
               this._mutableDisposable.value =
                   this._group.model.onDidActivePanelChange((event) => {
@@ -6005,12 +6004,10 @@ define(['exports'], (function (exports) { 'use strict';
           var _a;
           let _trackGroupActive = (_a = previousGroup === null || previousGroup === void 0 ? void 0 : previousGroup.isActive) !== null && _a !== void 0 ? _a : false; // prevent duplicate events with same state
           this.groupEventsDisposable.value = new CompositeDisposable(this.group.api.onDidVisibilityChange((event) => {
-              if (!event.isVisible && this.isVisible) {
-                  this._onDidVisibilityChange.fire(event);
-              }
-              else if (event.isVisible &&
-                  !this.isVisible &&
-                  this.group.model.isPanelActive(this.panel)) {
+              const hasBecomeHidden = !event.isVisible && this.isVisible;
+              const hasBecomeVisible = event.isVisible && !this.isVisible;
+              const isActivePanel = this.group.model.isPanelActive(this.panel);
+              if (hasBecomeHidden || (hasBecomeVisible && isActivePanel)) {
                   this._onDidVisibilityChange.fire(event);
               }
           }), this.group.api.onDidLocationChange((event) => {
@@ -6096,12 +6093,6 @@ define(['exports'], (function (exports) { 'use strict';
           const didTitleChange = title !== this.title;
           if (didTitleChange) {
               this._title = title;
-              this.view.update({
-                  params: {
-                      params: this._params,
-                      title: this.title,
-                  },
-              });
               this.api._onDidTitleChange.fire({ title });
           }
       }
@@ -6129,10 +6120,7 @@ define(['exports'], (function (exports) { 'use strict';
           }
           // update the view with the updated props
           this.view.update({
-              params: {
-                  params: this._params,
-                  title: this.title,
-              },
+              params: this._params,
           });
       }
       updateParentGroup(group, options) {
@@ -7270,7 +7258,7 @@ define(['exports'], (function (exports) { 'use strict';
               return element.getBoundingClientRect();
           }
           const box = getBox();
-          const groupId = (_b = (_a = options === null || options === void 0 ? void 0 : options.overridePopoutGroup) === null || _a === void 0 ? void 0 : _a.id) !== null && _b !== void 0 ? _b : this.getNextGroupId(); //item.id;
+          const groupId = (_b = (_a = options === null || options === void 0 ? void 0 : options.overridePopoutGroup) === null || _a === void 0 ? void 0 : _a.id) !== null && _b !== void 0 ? _b : this.getNextGroupId();
           if (itemToPopout.api.location.type === 'grid') {
               itemToPopout.api.setVisible(false);
           }
@@ -7386,24 +7374,22 @@ define(['exports'], (function (exports) { 'use strict';
                           });
                       }
                   }
-                  else {
-                      if (this.getPanel(group.id)) {
-                          const removedGroup = this.doRemoveGroup(group, {
-                              skipDispose: true,
-                              skipActive: true,
-                          });
-                          removedGroup.model.renderContainer =
-                              this.overlayRenderContainer;
-                          removedGroup.model.location = { type: 'grid' };
-                          returnedGroup = removedGroup;
-                      }
+                  else if (this.getPanel(group.id)) {
+                      const removedGroup = this.doRemoveGroup(group, {
+                          skipDispose: true,
+                          skipActive: true,
+                      });
+                      removedGroup.model.renderContainer =
+                          this.overlayRenderContainer;
+                      removedGroup.model.location = { type: 'grid' };
+                      returnedGroup = removedGroup;
                   }
               }));
               this._popoutGroups.push(value);
               this.updateWatermark();
           })
               .catch((err) => {
-              console.error(err);
+              console.error('dockview: failed to create popout window', err);
           });
       }
       addFloatingGroup(item, coord, options) {
@@ -7446,7 +7432,7 @@ define(['exports'], (function (exports) { 'use strict';
                       this.doRemoveGroup(item, {
                           skipDispose: true,
                           skipPopoutReturn: true,
-                          skipPopoutAssociated: !!popoutReferenceGroup,
+                          skipPopoutAssociated: false,
                       });
                   }
               }
@@ -7806,7 +7792,6 @@ define(['exports'], (function (exports) { 'use strict';
       clear() {
           const groups = Array.from(this._groups.values()).map((_) => _.value);
           const hasActiveGroup = !!this.activeGroup;
-          !!this.activePanel;
           for (const group of groups) {
               // remove the group will automatically remove the panels
               this.removeGroup(group, { skipActive: true });
@@ -8312,7 +8297,7 @@ define(['exports'], (function (exports) { 'use strict';
           }
           let id = options === null || options === void 0 ? void 0 : options.id;
           if (id && this._groups.has(options.id)) {
-              console.warn(`Duplicate group id ${options === null || options === void 0 ? void 0 : options.id}. reassigning group id to avoid errors`);
+              console.warn(`dockview: Duplicate group id ${options === null || options === void 0 ? void 0 : options.id}. reassigning group id to avoid errors`);
               id = undefined;
           }
           if (!id) {