dockview-core 1.13.0 → 1.13.1

package/dist/cjs/dockview/dockviewComponent.js

@@ -1310,7 +1310,6 @@ var DockviewComponent = /** @class */ (function (_super) {
     };
     DockviewComponent.prototype.addGroup = function (options) {
         var _a;
-        var group = this.createGroup(options);
         if (options) {
             var referenceGroup = void 0;
             if ((0, options_1.isGroupOptionsWithPanel)(options)) {
@@ -1344,6 +1343,7 @@ var DockviewComponent = /** @class */ (function (_super) {
             var target = (0, baseComponentGridview_1.toTarget)(options.direction || 'within');
             var location_2 = (0, gridview_1.getGridLocation)(referenceGroup.element);
             var relativeLocation = (0, gridview_1.getRelativeLocation)(this.gridview.orientation, location_2, target);
+            var group = this.createGroup(options);
             this.doAddGroup(group, relativeLocation);
             if (!options.skipSetActive) {
                 this.doSetGroupAndPanelActive(group);
@@ -1351,6 +1351,7 @@ var DockviewComponent = /** @class */ (function (_super) {
             return group;
         }
         else {
+            var group = this.createGroup(options);
             this.doAddGroup(group);
             this.doSetGroupAndPanelActive(group);
             return group;

package/dist/cjs/events.d.ts

@@ -47,9 +47,20 @@ export declare class Emitter<T> implements IDisposable {
 }
 export declare function addDisposableWindowListener<K extends keyof WindowEventMap>(element: Window, type: K, listener: (this: Window, ev: WindowEventMap[K]) => any, options?: boolean | AddEventListenerOptions): IDisposable;
 export declare function addDisposableListener<K extends keyof HTMLElementEventMap>(element: HTMLElement, type: K, listener: (this: HTMLElement, ev: HTMLElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): IDisposable;
-export declare class TickDelayedEvent implements IDisposable {
-    private timer;
+/**
+ *
+ * Event Emitter that fires events from a Microtask callback, only one event will fire per event-loop cycle.
+ *
+ * It's kind of like using an `asapScheduler` in RxJs with additional logic to only fire once per event-loop cycle.
+ * This implementation exists to avoid external dependencies.
+ *
+ * @see https://developer.mozilla.org/en-US/docs/Web/API/queueMicrotask
+ * @see https://rxjs.dev/api/index/const/asapScheduler
+ */
+export declare class AsapEvent implements IDisposable {
     private readonly _onFired;
+    private _currentFireCount;
+    private _queued;
     readonly onEvent: Event<void>;
     fire(): void;
     dispose(): void;

package/dist/cjs/events.js

@@ -11,7 +11,7 @@ var __values = (this && this.__values) || function(o) {
     throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.TickDelayedEvent = exports.addDisposableListener = exports.addDisposableWindowListener = exports.Emitter = exports.DockviewEvent = exports.Event = void 0;
+exports.AsapEvent = exports.addDisposableListener = exports.addDisposableWindowListener = exports.Emitter = exports.DockviewEvent = exports.Event = void 0;
 var Event;
 (function (Event) {
     Event.any = function () {
@@ -217,24 +217,56 @@ function addDisposableListener(element, type, listener, options) {
     };
 }
 exports.addDisposableListener = addDisposableListener;
-var TickDelayedEvent = /** @class */ (function () {
-    function TickDelayedEvent() {
+/**
+ *
+ * Event Emitter that fires events from a Microtask callback, only one event will fire per event-loop cycle.
+ *
+ * It's kind of like using an `asapScheduler` in RxJs with additional logic to only fire once per event-loop cycle.
+ * This implementation exists to avoid external dependencies.
+ *
+ * @see https://developer.mozilla.org/en-US/docs/Web/API/queueMicrotask
+ * @see https://rxjs.dev/api/index/const/asapScheduler
+ */
+var AsapEvent = /** @class */ (function () {
+    function AsapEvent() {
+        var _this = this;
         this._onFired = new Emitter();
-        this.onEvent = this._onFired.event;
+        this._currentFireCount = 0;
+        this._queued = false;
+        this.onEvent = function (e) {
+            /**
+             * when the event is first subscribed to take note of the current fire count
+             */
+            var fireCountAtTimeOfEventSubscription = _this._currentFireCount;
+            return _this._onFired.event(function () {
+                /**
+                 * if the current fire count is greater than the fire count at event subscription
+                 * then the event has been fired since we subscribed and it's ok to "on_next" the event.
+                 *
+                 * if the count is not greater then what we are recieving is an event from the microtask
+                 * queue that was triggered before we actually subscribed and therfore we should ignore it.
+                 */
+                if (_this._currentFireCount > fireCountAtTimeOfEventSubscription) {
+                    e();
+                }
+            });
+        };
     }
-    TickDelayedEvent.prototype.fire = function () {
+    AsapEvent.prototype.fire = function () {
         var _this = this;
-        if (this.timer) {
-            clearTimeout(this.timer);
+        this._currentFireCount++;
+        if (this._queued) {
+            return;
         }
-        this.timer = setTimeout(function () {
+        this._queued = true;
+        queueMicrotask(function () {
+            _this._queued = false;
             _this._onFired.fire();
-            clearTimeout(_this.timer);
         });
     };
-    TickDelayedEvent.prototype.dispose = function () {
+    AsapEvent.prototype.dispose = function () {
         this._onFired.dispose();
     };
-    return TickDelayedEvent;
+    return AsapEvent;
 }());
-exports.TickDelayedEvent = TickDelayedEvent;
+exports.AsapEvent = AsapEvent;

package/dist/cjs/gridview/baseComponentGridview.d.ts

@@ -1,4 +1,4 @@
-import { Event, TickDelayedEvent } from '../events';
+import { Event, AsapEvent } from '../events';
 import { Gridview, IGridView } from './gridview';
 import { Position } from '../dnd/droptarget';
 import { IValueDisposable } from '../lifecycle';
@@ -51,15 +51,14 @@ export declare abstract class BaseGrid<T extends IGridPanelView> extends Resizab
     protected readonly _groups: Map<string, IValueDisposable<T>>;
     protected readonly gridview: Gridview;
     protected _activeGroup: T | undefined;
-    private _onDidLayoutChange;
-    readonly onDidLayoutChange: Event<void>;
     private readonly _onDidRemove;
     readonly onDidRemove: Event<T>;
     private readonly _onDidAdd;
     readonly onDidAdd: Event<T>;
     private readonly _onDidActiveChange;
     readonly onDidActiveChange: Event<T | undefined>;
-    protected readonly _bufferOnDidLayoutChange: TickDelayedEvent;
+    protected readonly _bufferOnDidLayoutChange: AsapEvent;
+    readonly onDidLayoutChange: Event<void>;
     get id(): string;
     get size(): number;
     get groups(): T[];

package/dist/cjs/gridview/baseComponentGridview.js

@@ -56,15 +56,14 @@ var BaseGrid = /** @class */ (function (_super) {
         var _this = _super.call(this, document.createElement('div'), options.disableAutoResizing) || this;
         _this._id = nextLayoutId.next();
         _this._groups = new Map();
-        _this._onDidLayoutChange = new events_1.Emitter();
-        _this.onDidLayoutChange = _this._onDidLayoutChange.event;
         _this._onDidRemove = new events_1.Emitter();
         _this.onDidRemove = _this._onDidRemove.event;
         _this._onDidAdd = new events_1.Emitter();
         _this.onDidAdd = _this._onDidAdd.event;
         _this._onDidActiveChange = new events_1.Emitter();
         _this.onDidActiveChange = _this._onDidActiveChange.event;
-        _this._bufferOnDidLayoutChange = new events_1.TickDelayedEvent();
+        _this._bufferOnDidLayoutChange = new events_1.AsapEvent();
+        _this.onDidLayoutChange = _this._bufferOnDidLayoutChange.onEvent;
         _this.element.style.height = '100%';
         _this.element.style.width = '100%';
         options.parentElement.appendChild(_this.element);
@@ -79,8 +78,6 @@ var BaseGrid = /** @class */ (function (_super) {
             _this._bufferOnDidLayoutChange.fire();
         }), events_1.Event.any(_this.onDidAdd, _this.onDidRemove, _this.onDidActiveChange)(function () {
             _this._bufferOnDidLayoutChange.fire();
-        }), _this._bufferOnDidLayoutChange.onEvent(function () {
-            _this._onDidLayoutChange.fire();
         }), _this._bufferOnDidLayoutChange);
         return _this;
     }
@@ -166,7 +163,7 @@ var BaseGrid = /** @class */ (function (_super) {
     });
     BaseGrid.prototype.setVisible = function (panel, visible) {
         this.gridview.setViewVisible((0, gridview_1.getGridLocation)(panel.element), visible);
-        this._onDidLayoutChange.fire();
+        this._bufferOnDidLayoutChange.fire();
     };
     BaseGrid.prototype.isVisible = function (panel) {
         return this.gridview.isViewVisible((0, gridview_1.getGridLocation)(panel.element));
@@ -278,7 +275,6 @@ var BaseGrid = /** @class */ (function (_super) {
         this._onDidActiveChange.dispose();
         this._onDidAdd.dispose();
         this._onDidRemove.dispose();
-        this._onDidLayoutChange.dispose();
         try {
             for (var _b = __values(this.groups), _c = _b.next(); !_c.done; _c = _b.next()) {
                 var group = _c.value;

package/dist/dockview-core.amd.js

@@ -1,6 +1,6 @@
 /**
  * dockview-core
- * @version 1.13.0
+ * @version 1.13.1
  * @link https://github.com/mathuo/dockview
  * @license MIT
  */
@@ -250,18 +250,49 @@ define(['exports'], (function (exports) { 'use strict';
           },
       };
   }
-  class TickDelayedEvent {
+  /**
+   *
+   * Event Emitter that fires events from a Microtask callback, only one event will fire per event-loop cycle.
+   *
+   * It's kind of like using an `asapScheduler` in RxJs with additional logic to only fire once per event-loop cycle.
+   * This implementation exists to avoid external dependencies.
+   *
+   * @see https://developer.mozilla.org/en-US/docs/Web/API/queueMicrotask
+   * @see https://rxjs.dev/api/index/const/asapScheduler
+   */
+  class AsapEvent {
       constructor() {
           this._onFired = new Emitter();
-          this.onEvent = this._onFired.event;
+          this._currentFireCount = 0;
+          this._queued = false;
+          this.onEvent = (e) => {
+              /**
+               * when the event is first subscribed to take note of the current fire count
+               */
+              const fireCountAtTimeOfEventSubscription = this._currentFireCount;
+              return this._onFired.event(() => {
+                  /**
+                   * if the current fire count is greater than the fire count at event subscription
+                   * then the event has been fired since we subscribed and it's ok to "on_next" the event.
+                   *
+                   * if the count is not greater then what we are recieving is an event from the microtask
+                   * queue that was triggered before we actually subscribed and therfore we should ignore it.
+                   */
+                  if (this._currentFireCount > fireCountAtTimeOfEventSubscription) {
+                      e();
+                  }
+              });
+          };
       }
       fire() {
-          if (this.timer) {
-              clearTimeout(this.timer);
+          this._currentFireCount++;
+          if (this._queued) {
+              return;
           }
-          this.timer = setTimeout(() => {
+          this._queued = true;
+          queueMicrotask(() => {
+              this._queued = false;
               this._onFired.fire();
-              clearTimeout(this.timer);
           });
       }
       dispose() {
@@ -2579,15 +2610,14 @@ define(['exports'], (function (exports) { 'use strict';
           super(document.createElement('div'), options.disableAutoResizing);
           this._id = nextLayoutId$1.next();
           this._groups = new Map();
-          this._onDidLayoutChange = new Emitter();
-          this.onDidLayoutChange = this._onDidLayoutChange.event;
           this._onDidRemove = new Emitter();
           this.onDidRemove = this._onDidRemove.event;
           this._onDidAdd = new Emitter();
           this.onDidAdd = this._onDidAdd.event;
           this._onDidActiveChange = new Emitter();
           this.onDidActiveChange = this._onDidActiveChange.event;
-          this._bufferOnDidLayoutChange = new TickDelayedEvent();
+          this._bufferOnDidLayoutChange = new AsapEvent();
+          this.onDidLayoutChange = this._bufferOnDidLayoutChange.onEvent;
           this.element.style.height = '100%';
           this.element.style.width = '100%';
           options.parentElement.appendChild(this.element);
@@ -2602,13 +2632,11 @@ define(['exports'], (function (exports) { 'use strict';
               this._bufferOnDidLayoutChange.fire();
           }), exports.DockviewEvent.any(this.onDidAdd, this.onDidRemove, this.onDidActiveChange)(() => {
               this._bufferOnDidLayoutChange.fire();
-          }), this._bufferOnDidLayoutChange.onEvent(() => {
-              this._onDidLayoutChange.fire();
           }), this._bufferOnDidLayoutChange);
       }
       setVisible(panel, visible) {
           this.gridview.setViewVisible(getGridLocation(panel.element), visible);
-          this._onDidLayoutChange.fire();
+          this._bufferOnDidLayoutChange.fire();
       }
       isVisible(panel) {
           return this.gridview.isViewVisible(getGridLocation(panel.element));
@@ -2714,7 +2742,6 @@ define(['exports'], (function (exports) { 'use strict';
           this._onDidActiveChange.dispose();
           this._onDidAdd.dispose();
           this._onDidRemove.dispose();
-          this._onDidLayoutChange.dispose();
           for (const group of this.groups) {
               group.dispose();
           }
@@ -7963,7 +7990,6 @@ define(['exports'], (function (exports) { 'use strict';
       }
       addGroup(options) {
           var _a;
-          const group = this.createGroup(options);
           if (options) {
               let referenceGroup;
               if (isGroupOptionsWithPanel(options)) {
@@ -7997,6 +8023,7 @@ define(['exports'], (function (exports) { 'use strict';
               const target = toTarget(options.direction || 'within');
               const location = getGridLocation(referenceGroup.element);
               const relativeLocation = getRelativeLocation(this.gridview.orientation, location, target);
+              const group = this.createGroup(options);
               this.doAddGroup(group, relativeLocation);
               if (!options.skipSetActive) {
                   this.doSetGroupAndPanelActive(group);
@@ -8004,6 +8031,7 @@ define(['exports'], (function (exports) { 'use strict';
               return group;
           }
           else {
+              const group = this.createGroup(options);
               this.doAddGroup(group);
               this.doSetGroupAndPanelActive(group);
               return group;