dockview-core 1.10.0 → 1.10.1

package/dist/dockview-core.js

@@ -1,6 +1,6 @@
 /**
  * dockview-core
- * @version 1.10.0
+ * @version 1.10.1
  * @link https://github.com/mathuo/dockview
  * @license MIT
  */
@@ -1482,6 +1482,9 @@
               this._onDidChange.fire();
           }));
       }
+      setViewVisible(index, visible) {
+          this.splitview.setViewVisible(index, visible);
+      }
       addPane(pane, size, index = this.splitview.length, skipLayout = false) {
           const disposable = pane.onDidChangeExpansionState(() => {
               this.setupAnimation();
@@ -2986,19 +2989,27 @@
           return this.component.onWillDrop;
       }
       /**
+       * Invoked before an overlay is shown indicating a drop target.
        *
+       * Calling `event.preventDefault()` will prevent the overlay being shown and prevent
+       * the any subsequent drop event.
        */
       get onWillShowOverlay() {
           return this.component.onWillShowOverlay;
       }
       /**
-       * Invoked before a group is dragged. Exposed for custom Drag'n'Drop functionality.
+       * Invoked before a group is dragged.
+       *
+       * Calling `event.nativeEvent.preventDefault()` will prevent the group drag starting.
+       *
        */
       get onWillDragGroup() {
           return this.component.onWillDragGroup;
       }
       /**
-       * Invoked before a panel is dragged. Exposed for custom Drag'n'Drop functionality.
+       * Invoked before a panel is dragged.
+       *
+       * Calling `event.nativeEvent.preventDefault()` will prevent the panel drag starting.
        */
       get onWillDragPanel() {
           return this.component.onWillDragPanel;
@@ -3542,7 +3553,7 @@
                           data.groupId === this.group.id;
                       return !groupHasOnePanelAndIsActiveDragElement;
                   }
-                  return this.group.canDisplayOverlay(event, position, 'panel');
+                  return this.group.canDisplayOverlay(event, position, 'content');
               },
           });
           this.addDisposables(this.dropTarget);
@@ -3865,7 +3876,7 @@
                       // don't show the overlay if the tab being dragged is the last panel of this group
                       return ((_a = last(this.group.panels)) === null || _a === void 0 ? void 0 : _a.id) !== data.panelId;
                   }
-                  return group.model.canDisplayOverlay(event, position, 'panel');
+                  return group.model.canDisplayOverlay(event, position, 'header_space');
               },
           });
           this.onWillShowOverlay = this.dropTraget.onWillShowOverlay;
@@ -4994,9 +5005,6 @@
       get isVisible() {
           return this._isVisible;
       }
-      get isHidden() {
-          return this._isHidden;
-      }
       get width() {
           return this._width;
       }
@@ -5009,7 +5017,6 @@
           this._isFocused = false;
           this._isActive = false;
           this._isVisible = true;
-          this._isHidden = false;
           this._width = 0;
           this._height = 0;
           this.panelUpdatesDisposable = new MutableDisposable();
@@ -5023,8 +5030,8 @@
           //
           this._onDidVisibilityChange = new Emitter();
           this.onDidVisibilityChange = this._onDidVisibilityChange.event;
-          this._onDidHiddenChange = new Emitter();
-          this.onDidHiddenChange = this._onDidHiddenChange.event;
+          this._onWillVisibilityChange = new Emitter();
+          this.onWillVisibilityChange = this._onWillVisibilityChange.event;
           this._onDidActiveChange = new Emitter();
           this.onDidActiveChange = this._onDidActiveChange.event;
           this._onActiveChange = new Emitter();
@@ -5037,12 +5044,10 @@
               this._isActive = event.isActive;
           }), this.onDidVisibilityChange((event) => {
               this._isVisible = event.isVisible;
-          }), this.onDidHiddenChange((event) => {
-              this._isHidden = event.isHidden;
           }), this.onDidDimensionsChange((event) => {
               this._width = event.width;
               this._height = event.height;
-          }), this.panelUpdatesDisposable, this._onDidDimensionChange, this._onDidChangeFocus, this._onDidVisibilityChange, this._onDidActiveChange, this._onWillFocus, this._onActiveChange, this._onUpdateParameters, this._onWillFocus, this._onDidHiddenChange, this._onUpdateParameters);
+          }), this.panelUpdatesDisposable, this._onDidDimensionChange, this._onDidChangeFocus, this._onDidVisibilityChange, this._onDidActiveChange, this._onWillFocus, this._onActiveChange, this._onUpdateParameters, this._onWillFocus, this._onWillVisibilityChange, this._onUpdateParameters);
       }
       initialize(panel) {
           this.panelUpdatesDisposable.value = this._onUpdateParameters.event((parameters) => {
@@ -5051,8 +5056,8 @@
               });
           });
       }
-      setHidden(isHidden) {
-          this._onDidHiddenChange.fire({ isHidden });
+      setVisible(isVisible) {
+          this._onWillVisibilityChange.fire({ isVisible });
       }
       setActive() {
           this._onActiveChange.fire();
@@ -5270,7 +5275,11 @@
           this._onDidChangeExpansionState.fire(this.isExpanded()); // initialize value
           this._orientation = orientation;
           this.element.classList.add('pane');
-          this.addDisposables(this.api.onDidSizeChange((event) => {
+          this.addDisposables(this.api.onWillVisibilityChange((event) => {
+              const { isVisible } = event;
+              const { accessor } = this._params;
+              accessor.setVisible(this, isVisible);
+          }), this.api.onDidSizeChange((event) => {
               this._onDidChange.fire({ size: event.size });
           }), addDisposableListener(this.element, 'mouseenter', (ev) => {
               this.api._onMouseEnter.fire(ev);
@@ -5574,10 +5583,10 @@
               this._maximumHeight = options.maximumHeight;
           }
           this.api.initialize(this); // TODO: required to by-pass 'super before this' requirement
-          this.addDisposables(this.api.onDidHiddenChange((event) => {
-              const { isHidden } = event;
+          this.addDisposables(this.api.onWillVisibilityChange((event) => {
+              const { isVisible } = event;
               const { accessor } = this._params;
-              accessor.setVisible(this, !isHidden);
+              accessor.setVisible(this, isVisible);
           }), this.api.onActiveChange(() => {
               const { accessor } = this._params;
               accessor.doSetGroupActive(this);
@@ -5818,32 +5827,11 @@
           return this.panel.renderer;
       }
       set group(value) {
-          const isOldGroupActive = this.isGroupActive;
+          const oldGroup = this._group;
           if (this._group !== value) {
               this._group = value;
               this._onDidGroupChange.fire({});
-              let _trackGroupActive = isOldGroupActive; // prevent duplicate events with same state
-              this.groupEventsDisposable.value = new CompositeDisposable(this.group.api.onDidLocationChange((event) => {
-                  if (this.group !== this.panel.group) {
-                      return;
-                  }
-                  this._onDidLocationChange.fire(event);
-              }), this.group.api.onDidActiveChange(() => {
-                  if (this.group !== this.panel.group) {
-                      return;
-                  }
-                  if (_trackGroupActive !== this.isGroupActive) {
-                      _trackGroupActive = this.isGroupActive;
-                      this._onDidActiveGroupChange.fire({
-                          isActive: this.isGroupActive,
-                      });
-                  }
-              }));
-              // if (this.isGroupActive !== isOldGroupActive) {
-              //     this._onDidActiveGroupChange.fire({
-              //         isActive: this.isGroupActive,
-              //     });
-              // }
+              this.setupGroupEventListeners(oldGroup);
               this._onDidLocationChange.fire({
                   location: this.group.api.location,
               });
@@ -5869,6 +5857,7 @@
           this.groupEventsDisposable = new MutableDisposable();
           this.initialize(panel);
           this._group = group;
+          this.setupGroupEventListeners();
           this.addDisposables(this.groupEventsDisposable, this._onDidRendererChange, this._onDidTitleChange, this._onDidGroupChange, this._onDidActiveGroupChange, this._onDidLocationChange);
       }
       getWindow() {
@@ -5903,6 +5892,35 @@
       exitMaximized() {
           this.group.api.exitMaximized();
       }
+      setupGroupEventListeners(previousGroup) {
+          var _a;
+          let _trackGroupActive = (_a = previousGroup === null || previousGroup === void 0 ? void 0 : previousGroup.isActive) !== null && _a !== void 0 ? _a : false; // prevent duplicate events with same state
+          this.groupEventsDisposable.value = new CompositeDisposable(this.group.api.onDidVisibilityChange((event) => {
+              if (!event.isVisible && this.isVisible) {
+                  this._onDidVisibilityChange.fire(event);
+              }
+              else if (event.isVisible &&
+                  !this.isVisible &&
+                  this.group.model.isPanelActive(this.panel)) {
+                  this._onDidVisibilityChange.fire(event);
+              }
+          }), this.group.api.onDidLocationChange((event) => {
+              if (this.group !== this.panel.group) {
+                  return;
+              }
+              this._onDidLocationChange.fire(event);
+          }), this.group.api.onDidActiveChange(() => {
+              if (this.group !== this.panel.group) {
+                  return;
+              }
+              if (_trackGroupActive !== this.isGroupActive) {
+                  _trackGroupActive = this.isGroupActive;
+                  this._onDidActiveGroupChange.fire({
+                      isActive: this.isGroupActive,
+                  });
+              }
+          }));
+      }
   }
 
   class DockviewPanel extends CompositeDisposable {
@@ -7083,7 +7101,15 @@
               acceptedTargetZones: ['top', 'bottom', 'left', 'right', 'center'],
               overlayModel: (_b = this.options.rootOverlayModel) !== null && _b !== void 0 ? _b : DEFAULT_ROOT_OVERLAY_MODEL,
           });
-          this.addDisposables(this._rootDropTarget.onDrop((event) => {
+          this.addDisposables(this._rootDropTarget, this._rootDropTarget.onWillShowOverlay((event) => {
+              if (this.gridview.length > 0 && event.position === 'center') {
+                  // option only available when no panels in primary grid
+                  return;
+              }
+              this._onWillShowOverlay.fire(new WillShowOverlayLocationEvent(event, {
+                  kind: 'edge',
+              }));
+          }), this._rootDropTarget.onDrop((event) => {
               var _a;
               const willDropEvent = new DockviewWillDropEvent({
                   nativeEvent: event.nativeEvent,
@@ -7092,7 +7118,7 @@
                   api: this._api,
                   group: undefined,
                   getData: getPanelData,
-                  kind: 'content',
+                  kind: 'edge',
               });
               this._onWillDrop.fire(willDropEvent);
               if (willDropEvent.defaultPrevented) {
@@ -7148,7 +7174,7 @@
           const box = getBox();
           const groupId = (_b = (_a = options === null || options === void 0 ? void 0 : options.overridePopoutGroup) === null || _a === void 0 ? void 0 : _a.id) !== null && _b !== void 0 ? _b : this.getNextGroupId(); //item.id;
           if (itemToPopout.api.location.type === 'grid') {
-              itemToPopout.api.setHidden(true);
+              itemToPopout.api.setVisible(false);
           }
           const _window = new PopoutWindow(`${this.id}-${groupId}`, // unique id
           theme !== null && theme !== void 0 ? theme : '', {
@@ -7199,7 +7225,7 @@
                   }));
                   switch (referenceLocation) {
                       case 'grid':
-                          referenceGroup.api.setHidden(true);
+                          referenceGroup.api.setVisible(false);
                           break;
                       case 'floating':
                       case 'popout':
@@ -7253,8 +7279,8 @@
                           from: group,
                           to: referenceGroup,
                       }));
-                      if (referenceGroup.api.isHidden) {
-                          referenceGroup.api.setHidden(false);
+                      if (!referenceGroup.api.isVisible) {
+                          referenceGroup.api.setVisible(true);
                       }
                       if (this.getPanel(group.id)) {
                           this.doRemoveGroup(group, {
@@ -7827,7 +7853,7 @@
       }
       updateWatermark() {
           var _a, _b;
-          if (this.groups.filter((x) => x.api.location.type === 'grid' && !x.api.isHidden).length === 0) {
+          if (this.groups.filter((x) => x.api.location.type === 'grid' && x.api.isVisible).length === 0) {
               if (!this.watermark) {
                   this.watermark = this.createWatermarkComponent();
                   this.watermark.init({
@@ -8610,19 +8636,19 @@
           const index = this.panels.indexOf(panel);
           this.splitview.setViewVisible(index, visible);
       }
-      setActive(view, skipFocus) {
-          this._activePanel = view;
+      setActive(panel, skipFocus) {
+          this._activePanel = panel;
           this.panels
-              .filter((v) => v !== view)
+              .filter((v) => v !== panel)
               .forEach((v) => {
               v.api._onDidActiveChange.fire({ isActive: false });
               if (!skipFocus) {
                   v.focus();
               }
           });
-          view.api._onDidActiveChange.fire({ isActive: true });
+          panel.api._onDidActiveChange.fire({ isActive: true });
           if (!skipFocus) {
-              view.focus();
+              panel.focus();
           }
       }
       removePanel(panel, sizing) {
@@ -8921,6 +8947,10 @@
           });
           this.addDisposables(this._disposable);
       }
+      setVisible(panel, visible) {
+          const index = this.panels.indexOf(panel);
+          this.paneview.setViewVisible(index, visible);
+      }
       focus() {
           //noop
       }
@@ -8967,6 +8997,7 @@
               isExpanded: options.isExpanded,
               title: options.title,
               containerApi: new PaneviewApi(this),
+              accessor: this,
           });
           this.paneview.addPane(view, size, index);
           view.orientation = this.paneview.orientation;
@@ -9066,6 +9097,7 @@
                               title: data.title,
                               isExpanded: !!view.expanded,
                               containerApi: new PaneviewApi(this),
+                              accessor: this,
                           });
                           panel.orientation = this.paneview.orientation;
                       });
@@ -9154,10 +9186,10 @@
           this._onDidChange = new Emitter();
           this.onDidChange = this._onDidChange.event;
           this.api.initialize(this);
-          this.addDisposables(this._onDidChange, this.api.onDidHiddenChange((event) => {
-              const { isHidden } = event;
+          this.addDisposables(this._onDidChange, this.api.onWillVisibilityChange((event) => {
+              const { isVisible } = event;
               const { accessor } = this._params;
-              accessor.setVisible(this, !isHidden);
+              accessor.setVisible(this, isVisible);
           }), this.api.onActiveChange(() => {
               const { accessor } = this._params;
               accessor.setActive(this);