docbrain 1.5.10 → 1.5.12

package/install.js

@@ -40,14 +40,31 @@ function download(url) {
           reject(new Error(`Download failed: HTTP ${res.statusCode}`));
           return;
         }
-        const file = fs.createWriteStream(dest);
+        // Download to a scratch path and rename into place. rename() is atomic
+        // within a filesystem, so a download that is interrupted — or two that
+        // race, now that run.js can trigger one on first use — can never leave a
+        // half-written file at `dest`. A truncated binary is the worst outcome
+        // available here: it exists, so nothing re-downloads it, and it fails at
+        // exec with an error that says nothing about the real cause.
+        const tmp = `${dest}.tmp-${process.pid}`;
+        const file = fs.createWriteStream(tmp);
         res.pipe(file);
         file.on("finish", () => {
-          file.close();
-          fs.chmodSync(dest, 0o755);
-          resolve();
+          file.close(() => {
+            try {
+              fs.chmodSync(tmp, 0o755);
+              fs.renameSync(tmp, dest);
+              resolve();
+            } catch (err) {
+              try { fs.unlinkSync(tmp); } catch {}
+              reject(err);
+            }
+          });
+        });
+        file.on("error", (err) => {
+          try { fs.unlinkSync(tmp); } catch {}
+          reject(err);
         });
-        file.on("error", reject);
       })
       .on("error", reject);
   });

package/package.json

@@ -1,13 +1,13 @@
 {
   "name": "docbrain",
-  "version": "1.5.10",
+  "version": "1.5.12",
   "description": "AI-powered documentation intelligence CLI",
   "homepage": "https://github.com/docbrain-ai/docbrain",
   "repository": {
     "type": "git",
     "url": "https://github.com/docbrain-ai/docbrain.git"
   },
-  "license": "BSL-1.1",
+  "license": "MIT",
   "bin": {
     "docbrain": "run.js"
   },

package/run.js

@@ -2,17 +2,53 @@
 "use strict";
 
 const { execFileSync } = require("child_process");
+const fs = require("fs");
 const path = require("path");
 
 const binary = path.join(__dirname, "bin", "docbrain");
 
+// npm 12 turned lifecycle scripts off by default, so the postinstall hook that
+// fetches this binary may simply never have run — `npm install -g docbrain`
+// reports success and leaves nothing behind. Fetching on first use covers that,
+// and also covers an install that was interrupted before the download finished.
+//
+// The previous behaviour was to tell the user to reinstall. Under npm 12 that
+// advice cannot work: the reinstall skips the same postinstall and fails
+// identically, so following it loops forever.
+function ensureBinary() {
+  if (fs.existsSync(binary)) return;
+
+  console.error("DocBrain CLI binary not found — downloading it now (one-time).");
+  try {
+    execFileSync(process.execPath, [path.join(__dirname, "install.js")], {
+      stdio: "inherit",
+    });
+  } catch {
+    // install.js has already explained what went wrong. Add the two things it
+    // cannot know: where the binary belongs, and that a permission error means
+    // this needs running as whoever owns the install directory.
+    console.error("");
+    console.error(`Could not place the binary at: ${binary}`);
+    console.error(
+      "If that path is not writable, run this once as the user that installed the package,"
+    );
+    console.error(
+      "or download the binary manually from https://github.com/docbrain-ai/docbrain/releases"
+    );
+    process.exit(1);
+  }
+}
+
+ensureBinary();
+
 try {
   execFileSync(binary, process.argv.slice(2), { stdio: "inherit" });
 } catch (err) {
-  if (err.status !== null) {
+  // A non-null status means the CLI itself ran and chose that exit code, so
+  // pass it through untouched — callers and CI depend on it.
+  if (err.status !== null && err.status !== undefined) {
     process.exit(err.status);
   }
   console.error(`Failed to run DocBrain CLI: ${err.message}`);
-  console.error("Try reinstalling: npm install -g docbrain");
   process.exit(1);
 }