doc-detective 4.4.0 → 4.5.0

package/dist/index.cjs

@@ -130043,6 +130043,21 @@ var import_promises = __toESM(require("node:dns/promises"), 1);
 var import_node_net = __toESM(require("node:net"), 1);
 var import_axios = __toESM(require("axios"), 1);
 var import_node_child_process = require("node:child_process");
+async function findFreePort() {
+  return new Promise((resolve, reject) => {
+    const server = import_node_net.default.createServer();
+    server.once("error", reject);
+    server.listen(0, "127.0.0.1", () => {
+      const addr = server.address();
+      if (!addr || typeof addr === "string") {
+        server.close(() => reject(new Error("Failed to obtain ephemeral port")));
+        return;
+      }
+      const port = addr.port;
+      server.close(() => resolve(port));
+    });
+  });
+}
 function compileFilter(patterns) {
   if (!Array.isArray(patterns) || patterns.length === 0)
     return [];
@@ -137558,7 +137573,6 @@ function getIntegrationConfig(config, sourceIntegration) {
 
 // dist/core/tests.js
 var import_node_http2 = __toESM(require("node:http"), 1);
-var import_node_net2 = __toESM(require("node:net"), 1);
 var import_node_https2 = __toESM(require("node:https"), 1);
 var import_node_url3 = require("node:url");
 var __dirname3 = import_node_path15.default.dirname((0, import_node_url3.fileURLToPath)(importMetaUrl));
@@ -137879,10 +137893,12 @@ async function runSpecs({ resolvedTests }) {
     specs: []
   };
   const appiumRequired = isAppiumRequired(specs);
+  let appiumPort;
   if (appiumRequired) {
     setAppiumHome();
-    await waitForPortFree(4723);
-    appium = (0, import_node_child_process3.spawn)("npx", ["appium"], {
+    appiumPort = await findFreePort();
+    log(config, "debug", `Starting Appium on port ${appiumPort}`);
+    appium = (0, import_node_child_process3.spawn)("npx", ["appium", "-a", "127.0.0.1", "-p", String(appiumPort)], {
       shell: true,
       windowsHide: true,
       cwd: import_node_path15.default.join(__dirname3, "../..")
@@ -137894,7 +137910,7 @@ async function runSpecs({ resolvedTests }) {
     });
     appium.stderr.on("data", (data) => {
     });
-    await appiumIsReady();
+    await appiumIsReady(appiumPort);
     log(config, "debug", "Appium is ready.");
   }
   log(config, "info", "Running test specs.");
@@ -137967,8 +137983,11 @@ ${JSON.stringify(context, null, 2)}`);
           });
           log(config, "debug", "CAPABILITIES:");
           log(config, "debug", caps);
+          if (appiumPort === void 0) {
+            throw new Error("Driver requested but Appium was not started. isAppiumRequired(specs) and isDriverRequired(context) disagreed; this is a bug.");
+          }
           try {
-            driver = await driverStart(caps);
+            driver = await driverStart(caps, appiumPort);
           } catch (error) {
             try {
               log(config, "warning", `Failed to start context '${context.browser?.name}' on '${platform}'. Retrying as headless.`);
@@ -137982,7 +138001,7 @@ ${JSON.stringify(context, null, 2)}`);
                   headless: context.browser?.headless !== false
                 }
               });
-              driver = await driverStart(caps);
+              driver = await driverStart(caps, appiumPort);
             } catch (error2) {
               let errorMessage = `Failed to start context '${context.browser?.name}' on '${platform}'.`;
               if (context.browser?.name === "safari")
@@ -138258,40 +138277,16 @@ async function runStep({ config = {}, context = {}, step, driver, metaValues = {
   }
   return actionResult;
 }
-async function waitForPortFree(port, timeoutMs = 3e4) {
-  const start = Date.now();
-  while (Date.now() - start < timeoutMs) {
-    const result = await new Promise((resolve) => {
-      const server = import_node_net2.default.createServer();
-      server.once("error", (err) => {
-        if (err && err.code === "EADDRINUSE")
-          resolve("busy");
-        else
-          resolve(err instanceof Error ? err : new Error(String(err)));
-      });
-      server.once("listening", () => {
-        server.close(() => resolve("free"));
-      });
-      server.listen(port, "127.0.0.1");
-    });
-    if (result === "free")
-      return;
-    if (result instanceof Error)
-      throw result;
-    await new Promise((r) => setTimeout(r, 250));
-  }
-  throw new Error(`Timed out after ${timeoutMs}ms waiting for 127.0.0.1:${port} to become free. A prior Appium instance is still bound to the port; the next session create would race the teardown and fail with an opaque ECONNREFUSED.`);
-}
-async function appiumIsReady(timeoutMs = 12e4) {
+async function appiumIsReady(port, timeoutMs = 12e4) {
   let isReady = false;
   const start = Date.now();
   while (!isReady) {
     if (Date.now() - start > timeoutMs) {
-      throw new Error(`Appium server failed to start within ${timeoutMs / 1e3} seconds`);
+      throw new Error(`Appium server on port ${port} failed to start within ${timeoutMs / 1e3} seconds`);
     }
     await new Promise((resolve) => setTimeout(resolve, 1e3));
     try {
-      let resp = await import_axios6.default.get("http://127.0.0.1:4723/status");
+      let resp = await import_axios6.default.get(`http://127.0.0.1:${port}/status`);
       if (resp.status === 200)
         isReady = true;
     } catch {
@@ -138299,14 +138294,14 @@ async function appiumIsReady(timeoutMs = 12e4) {
   }
   return isReady;
 }
-async function driverStart(capabilities, maxAttempts = 4) {
+async function driverStart(capabilities, port, maxAttempts = 4) {
   let lastError;
   for (let attempt = 1; attempt <= maxAttempts; attempt++) {
     try {
       const driver = await wdio.remote({
         protocol: "http",
         hostname: "127.0.0.1",
-        port: 4723,
+        port,
         path: "/",
         logLevel: "error",
         capabilities,
@@ -138343,13 +138338,17 @@ async function getRunner(options = {}) {
     throw new Error("Chrome browser is not available. Please ensure Chrome is installed and accessible.");
   }
   setAppiumHome();
-  const appium = (0, import_node_child_process3.spawn)("npx", ["appium"], {
+  const appiumPort = await findFreePort();
+  const appium = (0, import_node_child_process3.spawn)("npx", ["appium", "-a", "127.0.0.1", "-p", String(appiumPort)], {
     shell: true,
     windowsHide: true,
     cwd: import_node_path15.default.join(__dirname3, "../..")
   });
-  await appiumIsReady();
-  log(config, "debug", "Appium is ready for external driver.");
+  appium.on("error", (err) => {
+    log(config, "warning", `Appium process error: ${err?.stack ?? err?.message ?? String(err)}`);
+  });
+  await appiumIsReady(appiumPort);
+  log(config, "debug", `Appium is ready for external driver on port ${appiumPort}.`);
   const caps = getDriverCapabilities({
     runnerDetails,
     name: "chrome",
@@ -138361,12 +138360,12 @@ async function getRunner(options = {}) {
   });
   let runner;
   try {
-    runner = await driverStart(caps);
+    runner = await driverStart(caps, appiumPort);
   } catch (error) {
     try {
       log(config, "warning", "Failed to start Chrome runner. Retrying as headless.");
       caps["goog:chromeOptions"].args.push("--headless", "--disable-gpu");
-      runner = await driverStart(caps);
+      runner = await driverStart(caps, appiumPort);
     } catch (error2) {
       (0, import_tree_kill.default)(appium.pid);
       throw new Error(`Failed to start Chrome runner: ${error2.message}`);

package/package.json

@@ -1,9 +1,10 @@
 {
   "name": "doc-detective",
-  "version": "4.4.0",
+  "version": "4.5.0",
   "description": "Treat doc content as testable assertions to validate doc accuracy and product UX.",
   "bin": {
-    "doc-detective": "bin/doc-detective.js"
+    "doc-detective": "bin/doc-detective.js",
+    "doc-detective-runner": "bin/runner-entrypoint.js"
   },
   "type": "module",
   "files": [