distyll 0.1.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CONTRIBUTING.md +159 -0
- package/POSTMORTEM.json +60 -0
- package/README.md +218 -0
- package/SETUP.md +79 -0
- package/action.yml +37 -0
- package/dist/cache.d.ts +26 -0
- package/dist/cache.d.ts.map +1 -0
- package/dist/cache.js +115 -0
- package/dist/cache.js.map +1 -0
- package/dist/cli.d.ts +3 -0
- package/dist/cli.d.ts.map +1 -0
- package/dist/cli.js +153 -0
- package/dist/cli.js.map +1 -0
- package/dist/commands/ci.d.ts +7 -0
- package/dist/commands/ci.d.ts.map +1 -0
- package/dist/commands/ci.js +101 -0
- package/dist/commands/ci.js.map +1 -0
- package/dist/commands/diff.d.ts +10 -0
- package/dist/commands/diff.d.ts.map +1 -0
- package/dist/commands/diff.js +95 -0
- package/dist/commands/diff.js.map +1 -0
- package/dist/commands/fingerprint.d.ts +2 -0
- package/dist/commands/fingerprint.d.ts.map +1 -0
- package/dist/commands/fingerprint.js +77 -0
- package/dist/commands/fingerprint.js.map +1 -0
- package/dist/commands/hook.d.ts +3 -0
- package/dist/commands/hook.d.ts.map +1 -0
- package/dist/commands/hook.js +110 -0
- package/dist/commands/hook.js.map +1 -0
- package/dist/commands/init.d.ts +2 -0
- package/dist/commands/init.d.ts.map +1 -0
- package/dist/commands/init.js +75 -0
- package/dist/commands/init.js.map +1 -0
- package/dist/config.d.ts +7 -0
- package/dist/config.d.ts.map +1 -0
- package/dist/config.js +100 -0
- package/dist/config.js.map +1 -0
- package/dist/errors.d.ts +30 -0
- package/dist/errors.d.ts.map +1 -0
- package/dist/errors.js +133 -0
- package/dist/errors.js.map +1 -0
- package/dist/fingerprint/analyzer.d.ts +3 -0
- package/dist/fingerprint/analyzer.d.ts.map +1 -0
- package/dist/fingerprint/analyzer.js +230 -0
- package/dist/fingerprint/analyzer.js.map +1 -0
- package/dist/fingerprint/comparator.d.ts +4 -0
- package/dist/fingerprint/comparator.d.ts.map +1 -0
- package/dist/fingerprint/comparator.js +78 -0
- package/dist/fingerprint/comparator.js.map +1 -0
- package/dist/fingerprint/profile.d.ts +5 -0
- package/dist/fingerprint/profile.d.ts.map +1 -0
- package/dist/fingerprint/profile.js +68 -0
- package/dist/fingerprint/profile.js.map +1 -0
- package/dist/fixes/index.d.ts +12 -0
- package/dist/fixes/index.d.ts.map +1 -0
- package/dist/fixes/index.js +42 -0
- package/dist/fixes/index.js.map +1 -0
- package/dist/fixes/single-use-wrapper.d.ts +8 -0
- package/dist/fixes/single-use-wrapper.d.ts.map +1 -0
- package/dist/fixes/single-use-wrapper.js +54 -0
- package/dist/fixes/single-use-wrapper.js.map +1 -0
- package/dist/fixes/unnecessary-try-catch.d.ts +8 -0
- package/dist/fixes/unnecessary-try-catch.d.ts.map +1 -0
- package/dist/fixes/unnecessary-try-catch.js +37 -0
- package/dist/fixes/unnecessary-try-catch.js.map +1 -0
- package/dist/fixes/unused-imports.d.ts +7 -0
- package/dist/fixes/unused-imports.d.ts.map +1 -0
- package/dist/fixes/unused-imports.js +41 -0
- package/dist/fixes/unused-imports.js.map +1 -0
- package/dist/fixes/verbose-comments.d.ts +7 -0
- package/dist/fixes/verbose-comments.d.ts.map +1 -0
- package/dist/fixes/verbose-comments.js +29 -0
- package/dist/fixes/verbose-comments.js.map +1 -0
- package/dist/formatter.d.ts +4 -0
- package/dist/formatter.d.ts.map +1 -0
- package/dist/formatter.js +72 -0
- package/dist/formatter.js.map +1 -0
- package/dist/git.d.ts +22 -0
- package/dist/git.d.ts.map +1 -0
- package/dist/git.js +130 -0
- package/dist/git.js.map +1 -0
- package/dist/index.d.ts +16 -0
- package/dist/index.d.ts.map +1 -0
- package/dist/index.js +40 -0
- package/dist/index.js.map +1 -0
- package/dist/languages/index.d.ts +8 -0
- package/dist/languages/index.d.ts.map +1 -0
- package/dist/languages/index.js +50 -0
- package/dist/languages/index.js.map +1 -0
- package/dist/languages/javascript.d.ts +6 -0
- package/dist/languages/javascript.d.ts.map +1 -0
- package/dist/languages/javascript.js +39 -0
- package/dist/languages/javascript.js.map +1 -0
- package/dist/languages/python.d.ts +6 -0
- package/dist/languages/python.d.ts.map +1 -0
- package/dist/languages/python.js +50 -0
- package/dist/languages/python.js.map +1 -0
- package/dist/parser.d.ts +8 -0
- package/dist/parser.d.ts.map +1 -0
- package/dist/parser.js +55 -0
- package/dist/parser.js.map +1 -0
- package/dist/reporters/github.d.ts +4 -0
- package/dist/reporters/github.d.ts.map +1 -0
- package/dist/reporters/github.js +70 -0
- package/dist/reporters/github.js.map +1 -0
- package/dist/reporters/terminal.d.ts +4 -0
- package/dist/reporters/terminal.d.ts.map +1 -0
- package/dist/reporters/terminal.js +59 -0
- package/dist/reporters/terminal.js.map +1 -0
- package/dist/rules/dead-code-paths.d.ts +3 -0
- package/dist/rules/dead-code-paths.d.ts.map +1 -0
- package/dist/rules/dead-code-paths.js +57 -0
- package/dist/rules/dead-code-paths.js.map +1 -0
- package/dist/rules/excessive-comments.d.ts +3 -0
- package/dist/rules/excessive-comments.d.ts.map +1 -0
- package/dist/rules/excessive-comments.js +86 -0
- package/dist/rules/excessive-comments.js.map +1 -0
- package/dist/rules/hallucinated-imports.d.ts +3 -0
- package/dist/rules/hallucinated-imports.d.ts.map +1 -0
- package/dist/rules/hallucinated-imports.js +228 -0
- package/dist/rules/hallucinated-imports.js.map +1 -0
- package/dist/rules/index.d.ts +4 -0
- package/dist/rules/index.d.ts.map +1 -0
- package/dist/rules/index.js +34 -0
- package/dist/rules/index.js.map +1 -0
- package/dist/rules/magic-values.d.ts +3 -0
- package/dist/rules/magic-values.d.ts.map +1 -0
- package/dist/rules/magic-values.js +168 -0
- package/dist/rules/magic-values.js.map +1 -0
- package/dist/rules/near-duplicate-functions.d.ts +3 -0
- package/dist/rules/near-duplicate-functions.d.ts.map +1 -0
- package/dist/rules/near-duplicate-functions.js +78 -0
- package/dist/rules/near-duplicate-functions.js.map +1 -0
- package/dist/rules/over-defensive-nulls.d.ts +3 -0
- package/dist/rules/over-defensive-nulls.d.ts.map +1 -0
- package/dist/rules/over-defensive-nulls.js +129 -0
- package/dist/rules/over-defensive-nulls.js.map +1 -0
- package/dist/rules/redundant-else-return.d.ts +3 -0
- package/dist/rules/redundant-else-return.d.ts.map +1 -0
- package/dist/rules/redundant-else-return.js +57 -0
- package/dist/rules/redundant-else-return.js.map +1 -0
- package/dist/rules/single-option-object.d.ts +3 -0
- package/dist/rules/single-option-object.d.ts.map +1 -0
- package/dist/rules/single-option-object.js +88 -0
- package/dist/rules/single-option-object.js.map +1 -0
- package/dist/rules/single-use-wrapper.d.ts +3 -0
- package/dist/rules/single-use-wrapper.d.ts.map +1 -0
- package/dist/rules/single-use-wrapper.js +172 -0
- package/dist/rules/single-use-wrapper.js.map +1 -0
- package/dist/rules/unnecessary-try-catch.d.ts +3 -0
- package/dist/rules/unnecessary-try-catch.d.ts.map +1 -0
- package/dist/rules/unnecessary-try-catch.js +116 -0
- package/dist/rules/unnecessary-try-catch.js.map +1 -0
- package/dist/rules/unused-imports.d.ts +3 -0
- package/dist/rules/unused-imports.d.ts.map +1 -0
- package/dist/rules/unused-imports.js +103 -0
- package/dist/rules/unused-imports.js.map +1 -0
- package/dist/rules/verbose-comments.d.ts +3 -0
- package/dist/rules/verbose-comments.d.ts.map +1 -0
- package/dist/rules/verbose-comments.js +100 -0
- package/dist/rules/verbose-comments.js.map +1 -0
- package/dist/scanner.d.ts +11 -0
- package/dist/scanner.d.ts.map +1 -0
- package/dist/scanner.js +196 -0
- package/dist/scanner.js.map +1 -0
- package/dist/scorer.d.ts +3 -0
- package/dist/scorer.d.ts.map +1 -0
- package/dist/scorer.js +23 -0
- package/dist/scorer.js.map +1 -0
- package/dist/types.d.ts +62 -0
- package/dist/types.d.ts.map +1 -0
- package/dist/types.js +3 -0
- package/dist/types.js.map +1 -0
- package/hn_post.md +13 -0
- package/marketing/COMPETITIVE_ANALYSIS.md +62 -0
- package/marketing/EMAIL_ANNOUNCEMENT.md +91 -0
- package/marketing/LANDING_PAGE_COPY.md +123 -0
- package/marketing/LAUNCH_POST.md +68 -0
- package/marketing/PRODUCT_HUNT.md +39 -0
- package/marketing/TWITTER_THREAD.md +70 -0
- package/package.json +44 -0
- package/producthunt.md +52 -0
- package/reddit_post.md +39 -0
- package/site/favicon.svg +10 -0
- package/site/index.html +281 -0
- package/site/script.js +82 -0
- package/site/style.css +516 -0
- package/src/cache.ts +114 -0
- package/src/cli.ts +169 -0
- package/src/commands/ci.ts +111 -0
- package/src/commands/diff.ts +108 -0
- package/src/commands/fingerprint.ts +47 -0
- package/src/commands/hook.ts +85 -0
- package/src/commands/init.ts +42 -0
- package/src/config.ts +75 -0
- package/src/errors.ts +105 -0
- package/src/fingerprint/analyzer.ts +214 -0
- package/src/fingerprint/comparator.ts +93 -0
- package/src/fingerprint/profile.ts +32 -0
- package/src/fixes/index.ts +58 -0
- package/src/fixes/single-use-wrapper.ts +60 -0
- package/src/fixes/unnecessary-try-catch.ts +43 -0
- package/src/fixes/unused-imports.ts +53 -0
- package/src/fixes/verbose-comments.ts +35 -0
- package/src/formatter.ts +79 -0
- package/src/git.ts +115 -0
- package/src/index.ts +15 -0
- package/src/languages/index.ts +50 -0
- package/src/languages/javascript.ts +36 -0
- package/src/languages/python.ts +47 -0
- package/src/parser.ts +52 -0
- package/src/reporters/github.ts +75 -0
- package/src/reporters/terminal.ts +67 -0
- package/src/rules/dead-code-paths.ts +62 -0
- package/src/rules/excessive-comments.ts +94 -0
- package/src/rules/hallucinated-imports.ts +195 -0
- package/src/rules/index.ts +32 -0
- package/src/rules/magic-values.ts +167 -0
- package/src/rules/near-duplicate-functions.ts +89 -0
- package/src/rules/over-defensive-nulls.ts +137 -0
- package/src/rules/redundant-else-return.ts +61 -0
- package/src/rules/single-option-object.ts +97 -0
- package/src/rules/single-use-wrapper.ts +184 -0
- package/src/rules/unnecessary-try-catch.ts +121 -0
- package/src/rules/unused-imports.ts +115 -0
- package/src/rules/verbose-comments.ts +105 -0
- package/src/scanner.ts +184 -0
- package/src/scorer.ts +26 -0
- package/src/types.ts +70 -0
- package/tests/commands/diff.test.ts +107 -0
- package/tests/config.test.ts +69 -0
- package/tests/e2e.test.ts +163 -0
- package/tests/edge-cases.test.ts +167 -0
- package/tests/fingerprint/analyzer.test.ts +131 -0
- package/tests/fixes/unnecessary-try-catch.test.ts +62 -0
- package/tests/git.test.ts +79 -0
- package/tests/rules/hallucinated-imports.test.ts +59 -0
- package/tests/rules/near-duplicate-functions.test.ts +90 -0
- package/tests/rules/unnecessary-try-catch.test.ts +81 -0
- package/tests/scanner.test.ts +88 -0
- package/tsconfig.json +20 -0
- package/twitter_thread.md +46 -0
- package/vitest.config.ts +7 -0
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"hallucinated-imports.js","sourceRoot":"","sources":["../../src/rules/hallucinated-imports.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AACA,uCAAyB;AACzB,2CAA6B;AAC7B,sCAAgD;AAChD,4CAAoE;AAGpE,SAAS,kBAAkB,CAAC,IAAiB;IAC3C,MAAM,OAAO,GAAuD,EAAE,CAAC;IACvE,MAAM,WAAW,GAAG,IAAA,kBAAS,EAAC,IAAI,CAAC,QAAQ,EAAE,kBAAkB,CAAC,CAAC;IAEjE,KAAK,MAAM,IAAI,IAAI,WAAW,EAAE,CAAC;QAC/B,IAAA,iBAAQ,EAAC,IAAI,EAAE,CAAC,IAAI,EAAE,EAAE;YACtB,IAAI,IAAI,CAAC,IAAI,KAAK,QAAQ,IAAI,IAAI,CAAC,MAAM,EAAE,IAAI,KAAK,kBAAkB,EAAE,CAAC;gBACvE,MAAM,MAAM,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC;gBAC9C,OAAO,CAAC,IAAI,CAAC,EAAE,MAAM,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;YACvC,CAAC;QACH,CAAC,CAAC,CAAC;IACL,CAAC;IAED,6BAA6B;IAC7B,MAAM,SAAS,GAAG,IAAA,kBAAS,EAAC,IAAI,CAAC,QAAQ,EAAE,iBAAiB,CAAC,CAAC;IAC9D,KAAK,MAAM,IAAI,IAAI,SAAS,EAAE,CAAC;QAC7B,MAAM,EAAE,GAAG,IAAI,CAAC,iBAAiB,CAAC,UAAU,CAAC,CAAC;QAC9C,IAAI,EAAE,EAAE,IAAI,KAAK,SAAS,IAAI,IAAI,CAAC,iBAAiB,CAAC,WAAW,CAAC,EAAE,CAAC;YAClE,MAAM,IAAI,GAAG,IAAI,CAAC,iBAAiB,CAAC,WAAW,CAAC,CAAC;YACjD,IAAI,IAAI,IAAI,IAAI,CAAC,aAAa,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;gBAC5C,MAAM,GAAG,GAAG,IAAI,CAAC,aAAa,CAAC,CAAC,CAAC,CAAC;gBAClC,IAAI,GAAG,CAAC,IAAI,KAAK,QAAQ,EAAE,CAAC;oBAC1B,MAAM,MAAM,GAAG,GAAG,CAAC,IAAI,CAAC,OAAO,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC;oBAC7C,OAAO,CAAC,IAAI,CAAC,EAAE,MAAM,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;gBACvC,CAAC;YACH,CAAC;QACH,CAAC;IACH,CAAC;IAED,OAAO,OAAO,CAAC;AACjB,CAAC;AAED,SAAS,sBAAsB,CAAC,IAAiB;IAC/C,MAAM,OAAO,GAAuD,EAAE,CAAC;IAEvE,8BAA8B;IAC9B,MAAM,WAAW,GAAG,IAAA,kBAAS,EAAC,IAAI,CAAC,QAAQ,EAAE,kBAAkB,CAAC,CAAC;IACjE,KAAK,MAAM,IAAI,IAAI,WAAW,EAAE,CAAC;QAC/B,IAAA,iBAAQ,EAAC,IAAI,EAAE,CAAC,IAAI,EAAE,EAAE;YACtB,IAAI,IAAI,CAAC,IAAI,KAAK,aAAa,IAAI,IAAI,CAAC,MAAM,EAAE,IAAI,KAAK,kBAAkB,EAAE,CAAC;gBAC5E,qCAAqC;gBACrC,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC;gBAC3B,MAAM,QAAQ,GAAG,QAAQ,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC;gBACxC,OAAO,CAAC,IAAI,CAAC,EAAE,MAAM,EAAE,QAAQ,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;YACjD,CAAC;QACH,CAAC,CAAC,CAAC;IACL,CAAC;IAED,gDAAgD;IAChD,MAAM,SAAS,GAAG,IAAA,kBAAS,EAAC,IAAI,CAAC,QAAQ,EAAE,uBAAuB,CAAC,CAAC;IACpE,KAAK,MAAM,IAAI,IAAI,SAAS,EAAE,CAAC;QAC7B,IAAA,iBAAQ,EAAC,IAAI,EAAE,CAAC,IAAI,EAAE,EAAE;YACtB,IAAI,IAAI,CAAC,IAAI,KAAK,aAAa,IAAI,IAAI,CAAC,MAAM,EAAE,IAAI,KAAK,uBAAuB,EAAE,CAAC;gBACjF,yEAAyE;gBACzE,MAAM,YAAY,GAAG,CAAC,IAAI,CAAC,oBAAoB,IAAI,IAAI,CAAC,oBAAoB,CAAC,IAAI,KAAK,aAAa,CAAC;gBACpG,IAAI,YAAY,EAAE,CAAC;oBACjB,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC;oBACzC,OAAO,CAAC,IAAI,CAAC,EAAE,MAAM,EAAE,QAAQ,EAAE,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC;gBACjD,CAAC;YACH,CAAC;YACD,uEAAuE;YACvE,IAAI,IAAI,CAAC,IAAI,KAAK,iBAAiB,EAAE,CAAC;gBACpC,yBAAyB;YAC3B,CAAC;QACH,CAAC,CAAC,CAAC;IACL,CAAC;IAED,OAAO,OAAO,CAAC;AACjB,CAAC;AAED,SAAS,gBAAgB,CAAC,MAAc;IACtC,OAAO,MAAM,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,MAAM,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC;AAC1D,CAAC;AAED,SAAS,qBAAqB,CAAC,MAAc,EAAE,QAAgB;IAC7D,kDAAkD;IAClD,MAAM,OAAO,GAAG,MAAM,CAAC,UAAU,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC;IACxG,IAAI,GAAG,GAAG,IAAI,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC;IACjC,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC;QAC5B,MAAM,SAAS,GAAG,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,cAAc,EAAE,OAAO,CAAC,CAAC;QAC1D,IAAI,EAAE,CAAC,UAAU,CAAC,SAAS,CAAC;YAAE,OAAO,IAAI,CAAC;QAC1C,MAAM,MAAM,GAAG,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC;QACjC,IAAI,MAAM,KAAK,GAAG;YAAE,MAAM;QAC1B,GAAG,GAAG,MAAM,CAAC;IACf,CAAC;IACD,OAAO,KAAK,CAAC;AACf,CAAC;AAED,SAAS,eAAe,CAAC,MAAc,EAAE,QAAgB,EAAE,QAAkB;IAC3E,0CAA0C;IAC1C,IAAI,gBAAgB,CAAC,MAAM,CAAC,EAAE,CAAC;QAC7B,MAAM,GAAG,GAAG,IAAI,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC;QACnC,MAAM,UAAU,GAAG,CAAC,KAAK,EAAE,MAAM,EAAE,KAAK,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,OAAO,EAAE,EAAE,CAAC,CAAC;QAC/E,KAAK,MAAM,GAAG,IAAI,UAAU,EAAE,CAAC;YAC7B,IAAI,EAAE,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,MAAM,GAAG,GAAG,CAAC,CAAC;gBAAE,OAAO,IAAI,CAAC;YAC7D,IAAI,EAAE,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,MAAM,EAAE,OAAO,GAAG,GAAG,CAAC,CAAC;gBAAE,OAAO,IAAI,CAAC;QACxE,CAAC;QACD,OAAO,KAAK,CAAC;IACf,CAAC;IAED,MAAM,MAAM,GAAG,IAAA,4BAAgB,EAAC,QAAQ,CAAC,CAAC;IAC1C,IAAI,MAAM,CAAC,GAAG,CAAC,MAAM,CAAC;QAAE,OAAO,IAAI,CAAC;IACpC,IAAI,qBAAqB,CAAC,MAAM,EAAE,QAAQ,CAAC;QAAE,OAAO,IAAI,CAAC;IAEzD,OAAO,KAAK,CAAC;AACf,CAAC;AAED,SAAS,mBAAmB,CAAC,MAAc,EAAE,QAAgB;IAC3D,MAAM,MAAM,GAAG,IAAA,4BAAgB,EAAC,QAAQ,CAAC,CAAC;IAC1C,IAAI,MAAM,CAAC,GAAG,CAAC,MAAM,CAAC;QAAE,OAAO,IAAI,CAAC;IAEpC,oDAAoD;IACpD,MAAM,GAAG,GAAG,IAAI,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC;IACnC,IAAI,EAAE,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,MAAM,GAAG,KAAK,CAAC,CAAC;QAAE,OAAO,IAAI,CAAC;IAC/D,IAAI,EAAE,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,MAAM,CAAC,CAAC,IAAI,EAAE,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,MAAM,EAAE,aAAa,CAAC,CAAC;QAAE,OAAO,IAAI,CAAC;IAE/G,sEAAsE;IACtE,IAAI,SAAS,GAAG,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC;IAClC,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,CAAC,EAAE,CAAC,EAAE,EAAE,CAAC;QAC3B,IAAI,EAAE,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,SAAS,EAAE,MAAM,GAAG,KAAK,CAAC,CAAC;YAAE,OAAO,IAAI,CAAC;QACrE,IAAI,EAAE,CAAC,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,SAAS,EAAE,MAAM,EAAE,aAAa,CAAC,CAAC;YAAE,OAAO,IAAI,CAAC;QAC5E,MAAM,MAAM,GAAG,IAAI,CAAC,OAAO,CAAC,SAAS,CAAC,CAAC;QACvC,IAAI,MAAM,KAAK,SAAS;YAAE,MAAM;QAChC,SAAS,GAAG,MAAM,CAAC;IACrB,CAAC;IAED,2EAA2E;IAC3E,wEAAwE;IACxE,OAAO,IAAI,CAAC,CAAC,iDAAiD;AAChE,CAAC;AAEY,QAAA,mBAAmB,GAAS;IACvC,IAAI,EAAE,sBAAsB;IAC5B,WAAW,EAAE,uFAAuF;IACpG,QAAQ,EAAE,OAAO;IAEjB,KAAK,CAAC,IAAiB,EAAE,MAAc,EAAE,QAAgB;QACvD,MAAM,QAAQ,GAAc,EAAE,CAAC;QAC/B,MAAM,QAAQ,GAAG,UAAU,CAAC,QAAQ,CAAC,CAAC;QACtC,IAAI,CAAC,QAAQ;YAAE,OAAO,QAAQ,CAAC;QAE/B,IAAI,IAAA,oBAAQ,EAAC,QAAQ,CAAC,EAAE,CAAC;YACvB,MAAM,OAAO,GAAG,kBAAkB,CAAC,IAAI,CAAC,CAAC;YACzC,KAAK,MAAM,EAAE,MAAM,EAAE,GAAG,EAAE,IAAI,EAAE,IAAI,OAAO,EAAE,CAAC;gBAC5C,IAAI,CAAC,GAAG;oBAAE,SAAS;gBACnB,IAAI,CAAC,eAAe,CAAC,GAAG,EAAE,QAAQ,EAAE,QAAQ,CAAC,EAAE,CAAC;oBAC9C,QAAQ,CAAC,IAAI,CAAC;wBACZ,IAAI,EAAE,QAAQ;wBACd,IAAI,EAAE,IAAI,CAAC,aAAa,CAAC,GAAG,GAAG,CAAC;wBAChC,MAAM,EAAE,IAAI,CAAC,aAAa,CAAC,MAAM,GAAG,CAAC;wBACrC,OAAO,EAAE,IAAI,CAAC,WAAW,CAAC,GAAG,GAAG,CAAC;wBACjC,SAAS,EAAE,IAAI,CAAC,WAAW,CAAC,MAAM,GAAG,CAAC;wBACtC,IAAI,EAAE,sBAAsB;wBAC5B,QAAQ,EAAE,OAAO;wBACjB,OAAO,EAAE,WAAW,GAAG,uEAAuE;qBAC/F,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;QACH,CAAC;aAAM,IAAI,IAAA,oBAAQ,EAAC,QAAQ,CAAC,EAAE,CAAC;YAC9B,MAAM,OAAO,GAAG,sBAAsB,CAAC,IAAI,CAAC,CAAC;YAC7C,KAAK,MAAM,EAAE,MAAM,EAAE,GAAG,EAAE,IAAI,EAAE,IAAI,OAAO,EAAE,CAAC;gBAC5C,IAAI,CAAC,GAAG;oBAAE,SAAS;gBACnB,IAAI,CAAC,mBAAmB,CAAC,GAAG,EAAE,QAAQ,CAAC,EAAE,CAAC;oBACxC,QAAQ,CAAC,IAAI,CAAC;wBACZ,IAAI,EAAE,QAAQ;wBACd,IAAI,EAAE,IAAI,CAAC,aAAa,CAAC,GAAG,GAAG,CAAC;wBAChC,MAAM,EAAE,IAAI,CAAC,aAAa,CAAC,MAAM,GAAG,CAAC;wBACrC,OAAO,EAAE,IAAI,CAAC,WAAW,CAAC,GAAG,GAAG,CAAC;wBACjC,SAAS,EAAE,IAAI,CAAC,WAAW,CAAC,MAAM,GAAG,CAAC;wBACtC,IAAI,EAAE,sBAAsB;wBAC5B,QAAQ,EAAE,OAAO;wBACjB,OAAO,EAAE,WAAW,GAAG,2EAA2E;qBACnG,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;QACH,CAAC;QAED,OAAO,QAAQ,CAAC;IAClB,CAAC;CACF,CAAC;AAEF,SAAS,UAAU,CAAC,QAAgB;IAClC,IAAI,QAAQ,CAAC,QAAQ,CAAC,MAAM,CAAC;QAAE,OAAO,KAAK,CAAC;IAC5C,IAAI,QAAQ,CAAC,QAAQ,CAAC,KAAK,CAAC;QAAE,OAAO,YAAY,CAAC;IAClD,IAAI,QAAQ,CAAC,QAAQ,CAAC,KAAK,CAAC,IAAI,QAAQ,CAAC,QAAQ,CAAC,MAAM,CAAC,IAAI,QAAQ,CAAC,QAAQ,CAAC,MAAM,CAAC,IAAI,QAAQ,CAAC,QAAQ,CAAC,MAAM,CAAC;QAAE,OAAO,YAAY,CAAC;IACzI,IAAI,QAAQ,CAAC,QAAQ,CAAC,KAAK,CAAC,IAAI,QAAQ,CAAC,QAAQ,CAAC,MAAM,CAAC;QAAE,OAAO,QAAQ,CAAC;IAC3E,OAAO,IAAI,CAAC;AACd,CAAC"}
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"index.d.ts","sourceRoot":"","sources":["../../src/rules/index.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,IAAI,EAAE,MAAM,UAAU,CAAC;AAcrC,eAAO,MAAM,QAAQ,EAAE,IAAI,EAa1B,CAAC;AAEF,wBAAgB,aAAa,CAAC,IAAI,EAAE,MAAM,GAAG,IAAI,GAAG,SAAS,CAE5D"}
|
|
@@ -0,0 +1,34 @@
|
|
|
1
|
+
"use strict";
|
|
2
|
+
Object.defineProperty(exports, "__esModule", { value: true });
|
|
3
|
+
exports.allRules = void 0;
|
|
4
|
+
exports.getRuleByName = getRuleByName;
|
|
5
|
+
const unnecessary_try_catch_1 = require("./unnecessary-try-catch");
|
|
6
|
+
const single_use_wrapper_1 = require("./single-use-wrapper");
|
|
7
|
+
const verbose_comments_1 = require("./verbose-comments");
|
|
8
|
+
const unused_imports_1 = require("./unused-imports");
|
|
9
|
+
const single_option_object_1 = require("./single-option-object");
|
|
10
|
+
const redundant_else_return_1 = require("./redundant-else-return");
|
|
11
|
+
const hallucinated_imports_1 = require("./hallucinated-imports");
|
|
12
|
+
const near_duplicate_functions_1 = require("./near-duplicate-functions");
|
|
13
|
+
const over_defensive_nulls_1 = require("./over-defensive-nulls");
|
|
14
|
+
const magic_values_1 = require("./magic-values");
|
|
15
|
+
const dead_code_paths_1 = require("./dead-code-paths");
|
|
16
|
+
const excessive_comments_1 = require("./excessive-comments");
|
|
17
|
+
exports.allRules = [
|
|
18
|
+
unnecessary_try_catch_1.unnecessaryTryCatch,
|
|
19
|
+
single_use_wrapper_1.singleUseWrapper,
|
|
20
|
+
verbose_comments_1.verboseComments,
|
|
21
|
+
unused_imports_1.unusedImports,
|
|
22
|
+
single_option_object_1.singleOptionObject,
|
|
23
|
+
redundant_else_return_1.redundantElseReturn,
|
|
24
|
+
hallucinated_imports_1.hallucinatedImports,
|
|
25
|
+
near_duplicate_functions_1.nearDuplicateFunctions,
|
|
26
|
+
over_defensive_nulls_1.overDefensiveNulls,
|
|
27
|
+
magic_values_1.magicValues,
|
|
28
|
+
dead_code_paths_1.deadCodePaths,
|
|
29
|
+
excessive_comments_1.excessiveComments,
|
|
30
|
+
];
|
|
31
|
+
function getRuleByName(name) {
|
|
32
|
+
return exports.allRules.find((r) => r.name === name);
|
|
33
|
+
}
|
|
34
|
+
//# sourceMappingURL=index.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"index.js","sourceRoot":"","sources":["../../src/rules/index.ts"],"names":[],"mappings":";;;AA6BA,sCAEC;AA9BD,mEAA8D;AAC9D,6DAAwD;AACxD,yDAAqD;AACrD,qDAAiD;AACjD,iEAA4D;AAC5D,mEAA8D;AAC9D,iEAA6D;AAC7D,yEAAoE;AACpE,iEAA4D;AAC5D,iDAA6C;AAC7C,uDAAkD;AAClD,6DAAyD;AAE5C,QAAA,QAAQ,GAAW;IAC9B,2CAAmB;IACnB,qCAAgB;IAChB,kCAAe;IACf,8BAAa;IACb,yCAAkB;IAClB,2CAAmB;IACnB,0CAAmB;IACnB,iDAAsB;IACtB,yCAAkB;IAClB,0BAAW;IACX,+BAAa;IACb,sCAAiB;CAClB,CAAC;AAEF,SAAgB,aAAa,CAAC,IAAY;IACxC,OAAO,gBAAQ,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,IAAI,CAAC,CAAC;AAC/C,CAAC"}
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"magic-values.d.ts","sourceRoot":"","sources":["../../src/rules/magic-values.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAW,IAAI,EAAE,MAAM,UAAU,CAAC;AAuF9C,eAAO,MAAM,WAAW,EAAE,IA6EzB,CAAC"}
|
|
@@ -0,0 +1,168 @@
|
|
|
1
|
+
"use strict";
|
|
2
|
+
Object.defineProperty(exports, "__esModule", { value: true });
|
|
3
|
+
exports.magicValues = void 0;
|
|
4
|
+
const parser_1 = require("../parser");
|
|
5
|
+
// Well-known constants that are NOT magic values — exempted to avoid false positives
|
|
6
|
+
const EXEMPT_NUMBERS = new Set([
|
|
7
|
+
'0', '1', '-1', '2', '0.5',
|
|
8
|
+
// HTTP status codes
|
|
9
|
+
'200', '201', '204', '301', '302', '304', '400', '401', '403', '404', '405', '409', '422', '429', '500', '502', '503', '504',
|
|
10
|
+
// Common bit/byte values
|
|
11
|
+
'8', '16', '32', '64', '128', '256', '512', '1024',
|
|
12
|
+
// Time
|
|
13
|
+
'24', '60', '100', '1000', '3600',
|
|
14
|
+
]);
|
|
15
|
+
const EXEMPT_STRINGS = new Set([
|
|
16
|
+
'', 'utf-8', 'utf8', 'ascii', 'base64', 'hex', 'binary',
|
|
17
|
+
'GET', 'POST', 'PUT', 'DELETE', 'PATCH', 'HEAD', 'OPTIONS',
|
|
18
|
+
'Content-Type', 'Authorization', 'Accept',
|
|
19
|
+
'application/json', 'text/html', 'text/plain', 'multipart/form-data',
|
|
20
|
+
'true', 'false', 'null', 'undefined',
|
|
21
|
+
'development', 'production', 'test', 'staging',
|
|
22
|
+
'click', 'change', 'submit', 'input', 'keydown', 'keyup',
|
|
23
|
+
'div', 'span', 'p', 'a', 'button', 'input', 'form',
|
|
24
|
+
]);
|
|
25
|
+
const MIN_MAGIC_STRING_LENGTH = 2;
|
|
26
|
+
const MAX_MAGIC_STRING_LENGTH = 50;
|
|
27
|
+
function isInConstDeclaration(node) {
|
|
28
|
+
let current = node;
|
|
29
|
+
while (current) {
|
|
30
|
+
// JS/TS: const x = value
|
|
31
|
+
if (current.type === 'lexical_declaration') {
|
|
32
|
+
const keyword = current.children[0];
|
|
33
|
+
if (keyword?.text === 'const')
|
|
34
|
+
return true;
|
|
35
|
+
}
|
|
36
|
+
// Python: UPPER_CASE = value (convention)
|
|
37
|
+
if (current.type === 'assignment') {
|
|
38
|
+
const left = current.childForFieldName('left');
|
|
39
|
+
if (left && /^[A-Z_][A-Z0-9_]*$/.test(left.text))
|
|
40
|
+
return true;
|
|
41
|
+
}
|
|
42
|
+
// Enum members
|
|
43
|
+
if (current.type === 'enum_declaration' || current.type === 'enum_body')
|
|
44
|
+
return true;
|
|
45
|
+
current = current.parent;
|
|
46
|
+
}
|
|
47
|
+
return false;
|
|
48
|
+
}
|
|
49
|
+
function isInImportOrExport(node) {
|
|
50
|
+
let current = node;
|
|
51
|
+
while (current) {
|
|
52
|
+
if (current.type === 'import_statement' || current.type === 'import_from_statement' ||
|
|
53
|
+
current.type === 'export_statement')
|
|
54
|
+
return true;
|
|
55
|
+
current = current.parent;
|
|
56
|
+
}
|
|
57
|
+
return false;
|
|
58
|
+
}
|
|
59
|
+
function isObjectKey(node) {
|
|
60
|
+
if (!node.parent)
|
|
61
|
+
return false;
|
|
62
|
+
// String used as object key: { "key": value }
|
|
63
|
+
if (node.parent.type === 'pair') {
|
|
64
|
+
const key = node.parent.childForFieldName('key');
|
|
65
|
+
return key === node;
|
|
66
|
+
}
|
|
67
|
+
return false;
|
|
68
|
+
}
|
|
69
|
+
function isInComparison(node) {
|
|
70
|
+
return node.parent?.type === 'binary_expression' || node.parent?.type === 'comparison_operator';
|
|
71
|
+
}
|
|
72
|
+
function isReturnValue(node) {
|
|
73
|
+
return node.parent?.type === 'return_statement';
|
|
74
|
+
}
|
|
75
|
+
function isDefaultParam(node) {
|
|
76
|
+
return node.parent?.type === 'assignment_pattern' || node.parent?.type === 'default_parameter';
|
|
77
|
+
}
|
|
78
|
+
function countOccurrences(root, value, type) {
|
|
79
|
+
let count = 0;
|
|
80
|
+
(0, parser_1.walkTree)(root, (node) => {
|
|
81
|
+
if (node.type === type && node.text === value)
|
|
82
|
+
count++;
|
|
83
|
+
});
|
|
84
|
+
return count;
|
|
85
|
+
}
|
|
86
|
+
exports.magicValues = {
|
|
87
|
+
name: 'magic-values',
|
|
88
|
+
description: 'Flags magic numbers and strings that should be named constants',
|
|
89
|
+
severity: 'info',
|
|
90
|
+
check(tree, source, filePath) {
|
|
91
|
+
const findings = [];
|
|
92
|
+
const seen = new Set();
|
|
93
|
+
(0, parser_1.walkTree)(tree.rootNode, (node) => {
|
|
94
|
+
// Magic numbers
|
|
95
|
+
if (node.type === 'number' || node.type === 'integer' || node.type === 'float') {
|
|
96
|
+
const value = node.text;
|
|
97
|
+
if (EXEMPT_NUMBERS.has(value))
|
|
98
|
+
return;
|
|
99
|
+
if (isInConstDeclaration(node))
|
|
100
|
+
return;
|
|
101
|
+
if (isInImportOrExport(node))
|
|
102
|
+
return;
|
|
103
|
+
if (isDefaultParam(node))
|
|
104
|
+
return;
|
|
105
|
+
if (isReturnValue(node))
|
|
106
|
+
return;
|
|
107
|
+
// Only flag if the same magic number appears 3+ times
|
|
108
|
+
const key = `num:${value}`;
|
|
109
|
+
if (seen.has(key))
|
|
110
|
+
return;
|
|
111
|
+
const count = countOccurrences(tree.rootNode, value, node.type);
|
|
112
|
+
if (count >= 3) {
|
|
113
|
+
seen.add(key);
|
|
114
|
+
findings.push({
|
|
115
|
+
file: filePath,
|
|
116
|
+
line: node.startPosition.row + 1,
|
|
117
|
+
column: node.startPosition.column + 1,
|
|
118
|
+
endLine: node.endPosition.row + 1,
|
|
119
|
+
endColumn: node.endPosition.column + 1,
|
|
120
|
+
rule: 'magic-values',
|
|
121
|
+
severity: 'info',
|
|
122
|
+
message: `Magic number ${value} appears ${count} times — consider extracting to a named constant`,
|
|
123
|
+
});
|
|
124
|
+
}
|
|
125
|
+
}
|
|
126
|
+
// Magic strings
|
|
127
|
+
if (node.type === 'string' || node.type === 'string_fragment') {
|
|
128
|
+
// Get the actual string content (strip quotes)
|
|
129
|
+
let value = node.text;
|
|
130
|
+
if (node.type === 'string') {
|
|
131
|
+
value = value.slice(1, -1);
|
|
132
|
+
}
|
|
133
|
+
if (value.length < MIN_MAGIC_STRING_LENGTH || value.length > MAX_MAGIC_STRING_LENGTH)
|
|
134
|
+
return;
|
|
135
|
+
if (EXEMPT_STRINGS.has(value))
|
|
136
|
+
return;
|
|
137
|
+
if (isInConstDeclaration(node))
|
|
138
|
+
return;
|
|
139
|
+
if (isInImportOrExport(node))
|
|
140
|
+
return;
|
|
141
|
+
if (isObjectKey(node))
|
|
142
|
+
return;
|
|
143
|
+
if (isDefaultParam(node))
|
|
144
|
+
return;
|
|
145
|
+
// Only flag strings that appear 3+ times
|
|
146
|
+
const key = `str:${value}`;
|
|
147
|
+
if (seen.has(key))
|
|
148
|
+
return;
|
|
149
|
+
const count = countOccurrences(tree.rootNode, node.text, node.type);
|
|
150
|
+
if (count >= 3) {
|
|
151
|
+
seen.add(key);
|
|
152
|
+
findings.push({
|
|
153
|
+
file: filePath,
|
|
154
|
+
line: node.startPosition.row + 1,
|
|
155
|
+
column: node.startPosition.column + 1,
|
|
156
|
+
endLine: node.endPosition.row + 1,
|
|
157
|
+
endColumn: node.endPosition.column + 1,
|
|
158
|
+
rule: 'magic-values',
|
|
159
|
+
severity: 'info',
|
|
160
|
+
message: `Magic string "${value}" appears ${count} times — consider extracting to a named constant`,
|
|
161
|
+
});
|
|
162
|
+
}
|
|
163
|
+
}
|
|
164
|
+
});
|
|
165
|
+
return findings;
|
|
166
|
+
},
|
|
167
|
+
};
|
|
168
|
+
//# sourceMappingURL=magic-values.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"magic-values.js","sourceRoot":"","sources":["../../src/rules/magic-values.ts"],"names":[],"mappings":";;;AACA,sCAAqC;AAGrC,qFAAqF;AACrF,MAAM,cAAc,GAAG,IAAI,GAAG,CAAC;IAC7B,GAAG,EAAE,GAAG,EAAE,IAAI,EAAE,GAAG,EAAE,KAAK;IAC1B,oBAAoB;IACpB,KAAK,EAAE,KAAK,EAAE,KAAK,EAAE,KAAK,EAAE,KAAK,EAAE,KAAK,EAAE,KAAK,EAAE,KAAK,EAAE,KAAK,EAAE,KAAK,EAAE,KAAK,EAAE,KAAK,EAAE,KAAK,EAAE,KAAK,EAAE,KAAK,EAAE,KAAK,EAAE,KAAK,EAAE,KAAK;IAC5H,yBAAyB;IACzB,GAAG,EAAE,IAAI,EAAE,IAAI,EAAE,IAAI,EAAE,KAAK,EAAE,KAAK,EAAE,KAAK,EAAE,MAAM;IAClD,OAAO;IACP,IAAI,EAAE,IAAI,EAAE,KAAK,EAAE,MAAM,EAAE,MAAM;CAClC,CAAC,CAAC;AAEH,MAAM,cAAc,GAAG,IAAI,GAAG,CAAC;IAC7B,EAAE,EAAE,OAAO,EAAE,MAAM,EAAE,OAAO,EAAE,QAAQ,EAAE,KAAK,EAAE,QAAQ;IACvD,KAAK,EAAE,MAAM,EAAE,KAAK,EAAE,QAAQ,EAAE,OAAO,EAAE,MAAM,EAAE,SAAS;IAC1D,cAAc,EAAE,eAAe,EAAE,QAAQ;IACzC,kBAAkB,EAAE,WAAW,EAAE,YAAY,EAAE,qBAAqB;IACpE,MAAM,EAAE,OAAO,EAAE,MAAM,EAAE,WAAW;IACpC,aAAa,EAAE,YAAY,EAAE,MAAM,EAAE,SAAS;IAC9C,OAAO,EAAE,QAAQ,EAAE,QAAQ,EAAE,OAAO,EAAE,SAAS,EAAE,OAAO;IACxD,KAAK,EAAE,MAAM,EAAE,GAAG,EAAE,GAAG,EAAE,QAAQ,EAAE,OAAO,EAAE,MAAM;CACnD,CAAC,CAAC;AAEH,MAAM,uBAAuB,GAAG,CAAC,CAAC;AAClC,MAAM,uBAAuB,GAAG,EAAE,CAAC;AAEnC,SAAS,oBAAoB,CAAC,IAAuB;IACnD,IAAI,OAAO,GAA6B,IAAI,CAAC;IAC7C,OAAO,OAAO,EAAE,CAAC;QACf,yBAAyB;QACzB,IAAI,OAAO,CAAC,IAAI,KAAK,qBAAqB,EAAE,CAAC;YAC3C,MAAM,OAAO,GAAG,OAAO,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC;YACpC,IAAI,OAAO,EAAE,IAAI,KAAK,OAAO;gBAAE,OAAO,IAAI,CAAC;QAC7C,CAAC;QACD,0CAA0C;QAC1C,IAAI,OAAO,CAAC,IAAI,KAAK,YAAY,EAAE,CAAC;YAClC,MAAM,IAAI,GAAG,OAAO,CAAC,iBAAiB,CAAC,MAAM,CAAC,CAAC;YAC/C,IAAI,IAAI,IAAI,oBAAoB,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC;gBAAE,OAAO,IAAI,CAAC;QAChE,CAAC;QACD,eAAe;QACf,IAAI,OAAO,CAAC,IAAI,KAAK,kBAAkB,IAAI,OAAO,CAAC,IAAI,KAAK,WAAW;YAAE,OAAO,IAAI,CAAC;QACrF,OAAO,GAAG,OAAO,CAAC,MAAM,CAAC;IAC3B,CAAC;IACD,OAAO,KAAK,CAAC;AACf,CAAC;AAED,SAAS,kBAAkB,CAAC,IAAuB;IACjD,IAAI,OAAO,GAA6B,IAAI,CAAC;IAC7C,OAAO,OAAO,EAAE,CAAC;QACf,IAAI,OAAO,CAAC,IAAI,KAAK,kBAAkB,IAAI,OAAO,CAAC,IAAI,KAAK,uBAAuB;YAC/E,OAAO,CAAC,IAAI,KAAK,kBAAkB;YAAE,OAAO,IAAI,CAAC;QACrD,OAAO,GAAG,OAAO,CAAC,MAAM,CAAC;IAC3B,CAAC;IACD,OAAO,KAAK,CAAC;AACf,CAAC;AAED,SAAS,WAAW,CAAC,IAAuB;IAC1C,IAAI,CAAC,IAAI,CAAC,MAAM;QAAE,OAAO,KAAK,CAAC;IAC/B,8CAA8C;IAC9C,IAAI,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,MAAM,EAAE,CAAC;QAChC,MAAM,GAAG,GAAG,IAAI,CAAC,MAAM,CAAC,iBAAiB,CAAC,KAAK,CAAC,CAAC;QACjD,OAAO,GAAG,KAAK,IAAI,CAAC;IACtB,CAAC;IACD,OAAO,KAAK,CAAC;AACf,CAAC;AAED,SAAS,cAAc,CAAC,IAAuB;IAC7C,OAAO,IAAI,CAAC,MAAM,EAAE,IAAI,KAAK,mBAAmB,IAAI,IAAI,CAAC,MAAM,EAAE,IAAI,KAAK,qBAAqB,CAAC;AAClG,CAAC;AAED,SAAS,aAAa,CAAC,IAAuB;IAC5C,OAAO,IAAI,CAAC,MAAM,EAAE,IAAI,KAAK,kBAAkB,CAAC;AAClD,CAAC;AAED,SAAS,cAAc,CAAC,IAAuB;IAC7C,OAAO,IAAI,CAAC,MAAM,EAAE,IAAI,KAAK,oBAAoB,IAAI,IAAI,CAAC,MAAM,EAAE,IAAI,KAAK,mBAAmB,CAAC;AACjG,CAAC;AAED,SAAS,gBAAgB,CAAC,IAAuB,EAAE,KAAa,EAAE,IAAY;IAC5E,IAAI,KAAK,GAAG,CAAC,CAAC;IACd,IAAA,iBAAQ,EAAC,IAAI,EAAE,CAAC,IAAI,EAAE,EAAE;QACtB,IAAI,IAAI,CAAC,IAAI,KAAK,IAAI,IAAI,IAAI,CAAC,IAAI,KAAK,KAAK;YAAE,KAAK,EAAE,CAAC;IACzD,CAAC,CAAC,CAAC;IACH,OAAO,KAAK,CAAC;AACf,CAAC;AAEY,QAAA,WAAW,GAAS;IAC/B,IAAI,EAAE,cAAc;IACpB,WAAW,EAAE,gEAAgE;IAC7E,QAAQ,EAAE,MAAM;IAEhB,KAAK,CAAC,IAAiB,EAAE,MAAc,EAAE,QAAgB;QACvD,MAAM,QAAQ,GAAc,EAAE,CAAC;QAC/B,MAAM,IAAI,GAAG,IAAI,GAAG,EAAU,CAAC;QAE/B,IAAA,iBAAQ,EAAC,IAAI,CAAC,QAAQ,EAAE,CAAC,IAAI,EAAE,EAAE;YAC/B,gBAAgB;YAChB,IAAI,IAAI,CAAC,IAAI,KAAK,QAAQ,IAAI,IAAI,CAAC,IAAI,KAAK,SAAS,IAAI,IAAI,CAAC,IAAI,KAAK,OAAO,EAAE,CAAC;gBAC/E,MAAM,KAAK,GAAG,IAAI,CAAC,IAAI,CAAC;gBACxB,IAAI,cAAc,CAAC,GAAG,CAAC,KAAK,CAAC;oBAAE,OAAO;gBACtC,IAAI,oBAAoB,CAAC,IAAI,CAAC;oBAAE,OAAO;gBACvC,IAAI,kBAAkB,CAAC,IAAI,CAAC;oBAAE,OAAO;gBACrC,IAAI,cAAc,CAAC,IAAI,CAAC;oBAAE,OAAO;gBACjC,IAAI,aAAa,CAAC,IAAI,CAAC;oBAAE,OAAO;gBAEhC,sDAAsD;gBACtD,MAAM,GAAG,GAAG,OAAO,KAAK,EAAE,CAAC;gBAC3B,IAAI,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC;oBAAE,OAAO;gBAE1B,MAAM,KAAK,GAAG,gBAAgB,CAAC,IAAI,CAAC,QAAQ,EAAE,KAAK,EAAE,IAAI,CAAC,IAAI,CAAC,CAAC;gBAChE,IAAI,KAAK,IAAI,CAAC,EAAE,CAAC;oBACf,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;oBACd,QAAQ,CAAC,IAAI,CAAC;wBACZ,IAAI,EAAE,QAAQ;wBACd,IAAI,EAAE,IAAI,CAAC,aAAa,CAAC,GAAG,GAAG,CAAC;wBAChC,MAAM,EAAE,IAAI,CAAC,aAAa,CAAC,MAAM,GAAG,CAAC;wBACrC,OAAO,EAAE,IAAI,CAAC,WAAW,CAAC,GAAG,GAAG,CAAC;wBACjC,SAAS,EAAE,IAAI,CAAC,WAAW,CAAC,MAAM,GAAG,CAAC;wBACtC,IAAI,EAAE,cAAc;wBACpB,QAAQ,EAAE,MAAM;wBAChB,OAAO,EAAE,gBAAgB,KAAK,YAAY,KAAK,kDAAkD;qBAClG,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;YAED,gBAAgB;YAChB,IAAI,IAAI,CAAC,IAAI,KAAK,QAAQ,IAAI,IAAI,CAAC,IAAI,KAAK,iBAAiB,EAAE,CAAC;gBAC9D,+CAA+C;gBAC/C,IAAI,KAAK,GAAG,IAAI,CAAC,IAAI,CAAC;gBACtB,IAAI,IAAI,CAAC,IAAI,KAAK,QAAQ,EAAE,CAAC;oBAC3B,KAAK,GAAG,KAAK,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC;gBAC7B,CAAC;gBAED,IAAI,KAAK,CAAC,MAAM,GAAG,uBAAuB,IAAI,KAAK,CAAC,MAAM,GAAG,uBAAuB;oBAAE,OAAO;gBAC7F,IAAI,cAAc,CAAC,GAAG,CAAC,KAAK,CAAC;oBAAE,OAAO;gBACtC,IAAI,oBAAoB,CAAC,IAAI,CAAC;oBAAE,OAAO;gBACvC,IAAI,kBAAkB,CAAC,IAAI,CAAC;oBAAE,OAAO;gBACrC,IAAI,WAAW,CAAC,IAAI,CAAC;oBAAE,OAAO;gBAC9B,IAAI,cAAc,CAAC,IAAI,CAAC;oBAAE,OAAO;gBAEjC,yCAAyC;gBACzC,MAAM,GAAG,GAAG,OAAO,KAAK,EAAE,CAAC;gBAC3B,IAAI,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC;oBAAE,OAAO;gBAE1B,MAAM,KAAK,GAAG,gBAAgB,CAAC,IAAI,CAAC,QAAQ,EAAE,IAAI,CAAC,IAAI,EAAE,IAAI,CAAC,IAAI,CAAC,CAAC;gBACpE,IAAI,KAAK,IAAI,CAAC,EAAE,CAAC;oBACf,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC;oBACd,QAAQ,CAAC,IAAI,CAAC;wBACZ,IAAI,EAAE,QAAQ;wBACd,IAAI,EAAE,IAAI,CAAC,aAAa,CAAC,GAAG,GAAG,CAAC;wBAChC,MAAM,EAAE,IAAI,CAAC,aAAa,CAAC,MAAM,GAAG,CAAC;wBACrC,OAAO,EAAE,IAAI,CAAC,WAAW,CAAC,GAAG,GAAG,CAAC;wBACjC,SAAS,EAAE,IAAI,CAAC,WAAW,CAAC,MAAM,GAAG,CAAC;wBACtC,IAAI,EAAE,cAAc;wBACpB,QAAQ,EAAE,MAAM;wBAChB,OAAO,EAAE,iBAAiB,KAAK,aAAa,KAAK,kDAAkD;qBACpG,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;QACH,CAAC,CAAC,CAAC;QAEH,OAAO,QAAQ,CAAC;IAClB,CAAC;CACF,CAAC"}
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"near-duplicate-functions.d.ts","sourceRoot":"","sources":["../../src/rules/near-duplicate-functions.ts"],"names":[],"mappings":"AAGA,OAAO,KAAK,EAAW,IAAI,EAAE,MAAM,UAAU,CAAC;AAuC9C,eAAO,MAAM,sBAAsB,EAAE,IA8CpC,CAAC"}
|
|
@@ -0,0 +1,78 @@
|
|
|
1
|
+
"use strict";
|
|
2
|
+
Object.defineProperty(exports, "__esModule", { value: true });
|
|
3
|
+
exports.nearDuplicateFunctions = void 0;
|
|
4
|
+
const string_similarity_1 = require("string-similarity");
|
|
5
|
+
const parser_1 = require("../parser");
|
|
6
|
+
const FUNCTION_NODE_TYPES = [
|
|
7
|
+
'function_declaration',
|
|
8
|
+
'method_definition',
|
|
9
|
+
'arrow_function',
|
|
10
|
+
'function',
|
|
11
|
+
// Python
|
|
12
|
+
'function_definition',
|
|
13
|
+
];
|
|
14
|
+
const MIN_BODY_LENGTH = 40; // Ignore very short function bodies
|
|
15
|
+
const SIMILARITY_THRESHOLD = 0.85;
|
|
16
|
+
function getFunctionName(node) {
|
|
17
|
+
const nameNode = node.childForFieldName('name');
|
|
18
|
+
if (nameNode)
|
|
19
|
+
return nameNode.text;
|
|
20
|
+
// Arrow functions assigned to variables: const foo = () => ...
|
|
21
|
+
if (node.type === 'arrow_function' && node.parent?.type === 'variable_declarator') {
|
|
22
|
+
const varName = node.parent.childForFieldName('name');
|
|
23
|
+
if (varName)
|
|
24
|
+
return varName.text;
|
|
25
|
+
}
|
|
26
|
+
return '<anonymous>';
|
|
27
|
+
}
|
|
28
|
+
function getFunctionBody(node) {
|
|
29
|
+
const body = node.childForFieldName('body');
|
|
30
|
+
if (!body)
|
|
31
|
+
return null;
|
|
32
|
+
return body.text;
|
|
33
|
+
}
|
|
34
|
+
exports.nearDuplicateFunctions = {
|
|
35
|
+
name: 'near-duplicate-functions',
|
|
36
|
+
description: 'Flags functions with near-identical bodies that suggest copy-paste with subtle variations',
|
|
37
|
+
severity: 'warning',
|
|
38
|
+
check(tree, source, filePath) {
|
|
39
|
+
const findings = [];
|
|
40
|
+
const funcNodes = (0, parser_1.findNodesMulti)(tree.rootNode, FUNCTION_NODE_TYPES);
|
|
41
|
+
const functions = [];
|
|
42
|
+
for (const node of funcNodes) {
|
|
43
|
+
const body = getFunctionBody(node);
|
|
44
|
+
if (!body || body.length < MIN_BODY_LENGTH)
|
|
45
|
+
continue;
|
|
46
|
+
functions.push({
|
|
47
|
+
name: getFunctionName(node),
|
|
48
|
+
body,
|
|
49
|
+
node,
|
|
50
|
+
});
|
|
51
|
+
}
|
|
52
|
+
// Compare all pairs — O(n^2) but function counts per file are small
|
|
53
|
+
const flagged = new Set();
|
|
54
|
+
for (let i = 0; i < functions.length; i++) {
|
|
55
|
+
for (let j = i + 1; j < functions.length; j++) {
|
|
56
|
+
if (flagged.has(j))
|
|
57
|
+
continue;
|
|
58
|
+
const sim = (0, string_similarity_1.compareTwoStrings)(functions[i].body, functions[j].body);
|
|
59
|
+
if (sim >= SIMILARITY_THRESHOLD) {
|
|
60
|
+
flagged.add(j);
|
|
61
|
+
const nodeJ = functions[j].node;
|
|
62
|
+
findings.push({
|
|
63
|
+
file: filePath,
|
|
64
|
+
line: nodeJ.startPosition.row + 1,
|
|
65
|
+
column: nodeJ.startPosition.column + 1,
|
|
66
|
+
endLine: nodeJ.endPosition.row + 1,
|
|
67
|
+
endColumn: nodeJ.endPosition.column + 1,
|
|
68
|
+
rule: 'near-duplicate-functions',
|
|
69
|
+
severity: 'warning',
|
|
70
|
+
message: `Function '${functions[j].name}' is ${Math.round(sim * 100)}% similar to '${functions[i].name}' (line ${functions[i].node.startPosition.row + 1}) — consider extracting shared logic`,
|
|
71
|
+
});
|
|
72
|
+
}
|
|
73
|
+
}
|
|
74
|
+
}
|
|
75
|
+
return findings;
|
|
76
|
+
},
|
|
77
|
+
};
|
|
78
|
+
//# sourceMappingURL=near-duplicate-functions.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"near-duplicate-functions.js","sourceRoot":"","sources":["../../src/rules/near-duplicate-functions.ts"],"names":[],"mappings":";;;AACA,yDAAsD;AACtD,sCAA2C;AAG3C,MAAM,mBAAmB,GAAG;IAC1B,sBAAsB;IACtB,mBAAmB;IACnB,gBAAgB;IAChB,UAAU;IACV,SAAS;IACT,qBAAqB;CACtB,CAAC;AAEF,MAAM,eAAe,GAAG,EAAE,CAAC,CAAC,oCAAoC;AAChE,MAAM,oBAAoB,GAAG,IAAI,CAAC;AAElC,SAAS,eAAe,CAAC,IAAuB;IAC9C,MAAM,QAAQ,GAAG,IAAI,CAAC,iBAAiB,CAAC,MAAM,CAAC,CAAC;IAChD,IAAI,QAAQ;QAAE,OAAO,QAAQ,CAAC,IAAI,CAAC;IAEnC,+DAA+D;IAC/D,IAAI,IAAI,CAAC,IAAI,KAAK,gBAAgB,IAAI,IAAI,CAAC,MAAM,EAAE,IAAI,KAAK,qBAAqB,EAAE,CAAC;QAClF,MAAM,OAAO,GAAG,IAAI,CAAC,MAAM,CAAC,iBAAiB,CAAC,MAAM,CAAC,CAAC;QACtD,IAAI,OAAO;YAAE,OAAO,OAAO,CAAC,IAAI,CAAC;IACnC,CAAC;IAED,OAAO,aAAa,CAAC;AACvB,CAAC;AAED,SAAS,eAAe,CAAC,IAAuB;IAC9C,MAAM,IAAI,GAAG,IAAI,CAAC,iBAAiB,CAAC,MAAM,CAAC,CAAC;IAC5C,IAAI,CAAC,IAAI;QAAE,OAAO,IAAI,CAAC;IACvB,OAAO,IAAI,CAAC,IAAI,CAAC;AACnB,CAAC;AAQY,QAAA,sBAAsB,GAAS;IAC1C,IAAI,EAAE,0BAA0B;IAChC,WAAW,EAAE,2FAA2F;IACxG,QAAQ,EAAE,SAAS;IAEnB,KAAK,CAAC,IAAiB,EAAE,MAAc,EAAE,QAAgB;QACvD,MAAM,QAAQ,GAAc,EAAE,CAAC;QAC/B,MAAM,SAAS,GAAG,IAAA,uBAAc,EAAC,IAAI,CAAC,QAAQ,EAAE,mBAAmB,CAAC,CAAC;QAErE,MAAM,SAAS,GAAmB,EAAE,CAAC;QACrC,KAAK,MAAM,IAAI,IAAI,SAAS,EAAE,CAAC;YAC7B,MAAM,IAAI,GAAG,eAAe,CAAC,IAAI,CAAC,CAAC;YACnC,IAAI,CAAC,IAAI,IAAI,IAAI,CAAC,MAAM,GAAG,eAAe;gBAAE,SAAS;YACrD,SAAS,CAAC,IAAI,CAAC;gBACb,IAAI,EAAE,eAAe,CAAC,IAAI,CAAC;gBAC3B,IAAI;gBACJ,IAAI;aACL,CAAC,CAAC;QACL,CAAC;QAED,oEAAoE;QACpE,MAAM,OAAO,GAAG,IAAI,GAAG,EAAU,CAAC;QAClC,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,SAAS,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;YAC1C,KAAK,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,SAAS,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;gBAC9C,IAAI,OAAO,CAAC,GAAG,CAAC,CAAC,CAAC;oBAAE,SAAS;gBAE7B,MAAM,GAAG,GAAG,IAAA,qCAAiB,EAAC,SAAS,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,SAAS,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC;gBACpE,IAAI,GAAG,IAAI,oBAAoB,EAAE,CAAC;oBAChC,OAAO,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC;oBACf,MAAM,KAAK,GAAG,SAAS,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;oBAChC,QAAQ,CAAC,IAAI,CAAC;wBACZ,IAAI,EAAE,QAAQ;wBACd,IAAI,EAAE,KAAK,CAAC,aAAa,CAAC,GAAG,GAAG,CAAC;wBACjC,MAAM,EAAE,KAAK,CAAC,aAAa,CAAC,MAAM,GAAG,CAAC;wBACtC,OAAO,EAAE,KAAK,CAAC,WAAW,CAAC,GAAG,GAAG,CAAC;wBAClC,SAAS,EAAE,KAAK,CAAC,WAAW,CAAC,MAAM,GAAG,CAAC;wBACvC,IAAI,EAAE,0BAA0B;wBAChC,QAAQ,EAAE,SAAS;wBACnB,OAAO,EAAE,aAAa,SAAS,CAAC,CAAC,CAAC,CAAC,IAAI,QAAQ,IAAI,CAAC,KAAK,CAAC,GAAG,GAAG,GAAG,CAAC,iBAAiB,SAAS,CAAC,CAAC,CAAC,CAAC,IAAI,WAAW,SAAS,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,aAAa,CAAC,GAAG,GAAG,CAAC,sCAAsC;qBAC/L,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;QACH,CAAC;QAED,OAAO,QAAQ,CAAC;IAClB,CAAC;CACF,CAAC"}
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"over-defensive-nulls.d.ts","sourceRoot":"","sources":["../../src/rules/over-defensive-nulls.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAW,IAAI,EAAE,MAAM,UAAU,CAAC;AAgD9C,eAAO,MAAM,kBAAkB,EAAE,IAsFhC,CAAC"}
|
|
@@ -0,0 +1,129 @@
|
|
|
1
|
+
"use strict";
|
|
2
|
+
Object.defineProperty(exports, "__esModule", { value: true });
|
|
3
|
+
exports.overDefensiveNulls = void 0;
|
|
4
|
+
const parser_1 = require("../parser");
|
|
5
|
+
/**
|
|
6
|
+
* Detects patterns where code checks for null/undefined on values that
|
|
7
|
+
* were just assigned or are non-nullable by context. Focuses on clearly
|
|
8
|
+
* unnecessary checks to minimize false positives.
|
|
9
|
+
*
|
|
10
|
+
* Patterns detected:
|
|
11
|
+
* - Null check immediately after non-nullable assignment: `const x = 5; if (x != null) ...`
|
|
12
|
+
* - Double null checks: `if (x != null) { if (x != null) ... }`
|
|
13
|
+
* - Typeof check on known values: `const x = []; if (typeof x !== 'undefined') ...`
|
|
14
|
+
*/
|
|
15
|
+
const LITERAL_TYPES = new Set([
|
|
16
|
+
'number', 'string', 'true', 'false', 'template_string',
|
|
17
|
+
'array', 'object', 'regex',
|
|
18
|
+
// Python
|
|
19
|
+
'integer', 'float', 'list', 'dictionary', 'set', 'tuple',
|
|
20
|
+
]);
|
|
21
|
+
const NULL_CHECK_PATTERNS = new Set([
|
|
22
|
+
'!= null', '!== null', '!= undefined', '!== undefined',
|
|
23
|
+
'!= None', 'is not None',
|
|
24
|
+
]);
|
|
25
|
+
function isNullCheck(node) {
|
|
26
|
+
const text = node.text.replace(/\s+/g, ' ').trim();
|
|
27
|
+
for (const pattern of NULL_CHECK_PATTERNS) {
|
|
28
|
+
if (text.includes(pattern))
|
|
29
|
+
return true;
|
|
30
|
+
}
|
|
31
|
+
// typeof x !== 'undefined'
|
|
32
|
+
if (text.includes('typeof') && text.includes('undefined'))
|
|
33
|
+
return true;
|
|
34
|
+
return false;
|
|
35
|
+
}
|
|
36
|
+
function isLiteralAssignment(node) {
|
|
37
|
+
// Check if the right side of an assignment is a literal
|
|
38
|
+
const value = node.childForFieldName('value') ?? node.childForFieldName('right');
|
|
39
|
+
if (!value)
|
|
40
|
+
return false;
|
|
41
|
+
return LITERAL_TYPES.has(value.type);
|
|
42
|
+
}
|
|
43
|
+
function getAssignedName(node) {
|
|
44
|
+
const nameNode = node.childForFieldName('name') ?? node.childForFieldName('left');
|
|
45
|
+
if (!nameNode)
|
|
46
|
+
return null;
|
|
47
|
+
return nameNode.text;
|
|
48
|
+
}
|
|
49
|
+
exports.overDefensiveNulls = {
|
|
50
|
+
name: 'over-defensive-nulls',
|
|
51
|
+
description: 'Flags null/undefined checks on values that are clearly non-nullable',
|
|
52
|
+
severity: 'info',
|
|
53
|
+
check(tree, source, filePath) {
|
|
54
|
+
const findings = [];
|
|
55
|
+
// Strategy: find variable declarations with literal values, then check if
|
|
56
|
+
// the very next sibling is a null check on that variable
|
|
57
|
+
const declarations = (0, parser_1.findNodesMulti)(tree.rootNode, [
|
|
58
|
+
'lexical_declaration', 'variable_declaration',
|
|
59
|
+
// Python
|
|
60
|
+
'assignment',
|
|
61
|
+
]);
|
|
62
|
+
for (const decl of declarations) {
|
|
63
|
+
let assignedName = null;
|
|
64
|
+
// For JS/TS: const x = literal
|
|
65
|
+
if (decl.type === 'lexical_declaration' || decl.type === 'variable_declaration') {
|
|
66
|
+
for (const child of decl.namedChildren) {
|
|
67
|
+
if (child.type === 'variable_declarator' && isLiteralAssignment(child)) {
|
|
68
|
+
assignedName = getAssignedName(child);
|
|
69
|
+
}
|
|
70
|
+
}
|
|
71
|
+
}
|
|
72
|
+
// For Python: x = literal
|
|
73
|
+
if (decl.type === 'assignment' && isLiteralAssignment(decl)) {
|
|
74
|
+
assignedName = getAssignedName(decl);
|
|
75
|
+
}
|
|
76
|
+
if (!assignedName)
|
|
77
|
+
continue;
|
|
78
|
+
// Check the next sibling statement for a null check on this variable
|
|
79
|
+
const nextSibling = decl.nextNamedSibling;
|
|
80
|
+
if (!nextSibling)
|
|
81
|
+
continue;
|
|
82
|
+
if (nextSibling.type === 'if_statement' || nextSibling.type === 'expression_statement') {
|
|
83
|
+
const condition = nextSibling.childForFieldName('condition') ?? nextSibling;
|
|
84
|
+
if (isNullCheck(condition) && condition.text.includes(assignedName)) {
|
|
85
|
+
findings.push({
|
|
86
|
+
file: filePath,
|
|
87
|
+
line: nextSibling.startPosition.row + 1,
|
|
88
|
+
column: nextSibling.startPosition.column + 1,
|
|
89
|
+
endLine: nextSibling.endPosition.row + 1,
|
|
90
|
+
endColumn: nextSibling.endPosition.column + 1,
|
|
91
|
+
rule: 'over-defensive-nulls',
|
|
92
|
+
severity: 'info',
|
|
93
|
+
message: `Null check on '${assignedName}' is unnecessary — it was just assigned a non-nullable value on line ${decl.startPosition.row + 1}`,
|
|
94
|
+
});
|
|
95
|
+
}
|
|
96
|
+
}
|
|
97
|
+
}
|
|
98
|
+
// Detect nested duplicate null checks
|
|
99
|
+
const ifStatements = (0, parser_1.findNodesMulti)(tree.rootNode, ['if_statement']);
|
|
100
|
+
for (const ifStmt of ifStatements) {
|
|
101
|
+
const condition = ifStmt.childForFieldName('condition');
|
|
102
|
+
if (!condition || !isNullCheck(condition))
|
|
103
|
+
continue;
|
|
104
|
+
const consequence = ifStmt.childForFieldName('consequence') ?? ifStmt.childForFieldName('body');
|
|
105
|
+
if (!consequence)
|
|
106
|
+
continue;
|
|
107
|
+
// Look for nested if with the same null check
|
|
108
|
+
(0, parser_1.walkTree)(consequence, (inner) => {
|
|
109
|
+
if (inner.type === 'if_statement' && inner !== ifStmt) {
|
|
110
|
+
const innerCond = inner.childForFieldName('condition');
|
|
111
|
+
if (innerCond && isNullCheck(innerCond) && innerCond.text === condition.text) {
|
|
112
|
+
findings.push({
|
|
113
|
+
file: filePath,
|
|
114
|
+
line: inner.startPosition.row + 1,
|
|
115
|
+
column: inner.startPosition.column + 1,
|
|
116
|
+
endLine: inner.endPosition.row + 1,
|
|
117
|
+
endColumn: inner.endPosition.column + 1,
|
|
118
|
+
rule: 'over-defensive-nulls',
|
|
119
|
+
severity: 'info',
|
|
120
|
+
message: `Duplicate null check — '${innerCond.text}' is already checked on line ${ifStmt.startPosition.row + 1}`,
|
|
121
|
+
});
|
|
122
|
+
}
|
|
123
|
+
}
|
|
124
|
+
});
|
|
125
|
+
}
|
|
126
|
+
return findings;
|
|
127
|
+
},
|
|
128
|
+
};
|
|
129
|
+
//# sourceMappingURL=over-defensive-nulls.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"over-defensive-nulls.js","sourceRoot":"","sources":["../../src/rules/over-defensive-nulls.ts"],"names":[],"mappings":";;;AACA,sCAAqD;AAGrD;;;;;;;;;GASG;AAEH,MAAM,aAAa,GAAG,IAAI,GAAG,CAAC;IAC5B,QAAQ,EAAE,QAAQ,EAAE,MAAM,EAAE,OAAO,EAAE,iBAAiB;IACtD,OAAO,EAAE,QAAQ,EAAE,OAAO;IAC1B,SAAS;IACT,SAAS,EAAE,OAAO,EAAE,MAAM,EAAE,YAAY,EAAE,KAAK,EAAE,OAAO;CACzD,CAAC,CAAC;AAEH,MAAM,mBAAmB,GAAG,IAAI,GAAG,CAAC;IAClC,SAAS,EAAE,UAAU,EAAE,cAAc,EAAE,eAAe;IACtD,SAAS,EAAE,aAAa;CACzB,CAAC,CAAC;AAEH,SAAS,WAAW,CAAC,IAAuB;IAC1C,MAAM,IAAI,GAAG,IAAI,CAAC,IAAI,CAAC,OAAO,CAAC,MAAM,EAAE,GAAG,CAAC,CAAC,IAAI,EAAE,CAAC;IACnD,KAAK,MAAM,OAAO,IAAI,mBAAmB,EAAE,CAAC;QAC1C,IAAI,IAAI,CAAC,QAAQ,CAAC,OAAO,CAAC;YAAE,OAAO,IAAI,CAAC;IAC1C,CAAC;IACD,2BAA2B;IAC3B,IAAI,IAAI,CAAC,QAAQ,CAAC,QAAQ,CAAC,IAAI,IAAI,CAAC,QAAQ,CAAC,WAAW,CAAC;QAAE,OAAO,IAAI,CAAC;IACvE,OAAO,KAAK,CAAC;AACf,CAAC;AAED,SAAS,mBAAmB,CAAC,IAAuB;IAClD,wDAAwD;IACxD,MAAM,KAAK,GAAG,IAAI,CAAC,iBAAiB,CAAC,OAAO,CAAC,IAAI,IAAI,CAAC,iBAAiB,CAAC,OAAO,CAAC,CAAC;IACjF,IAAI,CAAC,KAAK;QAAE,OAAO,KAAK,CAAC;IACzB,OAAO,aAAa,CAAC,GAAG,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;AACvC,CAAC;AAED,SAAS,eAAe,CAAC,IAAuB;IAC9C,MAAM,QAAQ,GAAG,IAAI,CAAC,iBAAiB,CAAC,MAAM,CAAC,IAAI,IAAI,CAAC,iBAAiB,CAAC,MAAM,CAAC,CAAC;IAClF,IAAI,CAAC,QAAQ;QAAE,OAAO,IAAI,CAAC;IAC3B,OAAO,QAAQ,CAAC,IAAI,CAAC;AACvB,CAAC;AAEY,QAAA,kBAAkB,GAAS;IACtC,IAAI,EAAE,sBAAsB;IAC5B,WAAW,EAAE,qEAAqE;IAClF,QAAQ,EAAE,MAAM;IAEhB,KAAK,CAAC,IAAiB,EAAE,MAAc,EAAE,QAAgB;QACvD,MAAM,QAAQ,GAAc,EAAE,CAAC;QAE/B,0EAA0E;QAC1E,yDAAyD;QACzD,MAAM,YAAY,GAAG,IAAA,uBAAc,EAAC,IAAI,CAAC,QAAQ,EAAE;YACjD,qBAAqB,EAAE,sBAAsB;YAC7C,SAAS;YACT,YAAY;SACb,CAAC,CAAC;QAEH,KAAK,MAAM,IAAI,IAAI,YAAY,EAAE,CAAC;YAChC,IAAI,YAAY,GAAkB,IAAI,CAAC;YAEvC,+BAA+B;YAC/B,IAAI,IAAI,CAAC,IAAI,KAAK,qBAAqB,IAAI,IAAI,CAAC,IAAI,KAAK,sBAAsB,EAAE,CAAC;gBAChF,KAAK,MAAM,KAAK,IAAI,IAAI,CAAC,aAAa,EAAE,CAAC;oBACvC,IAAI,KAAK,CAAC,IAAI,KAAK,qBAAqB,IAAI,mBAAmB,CAAC,KAAK,CAAC,EAAE,CAAC;wBACvE,YAAY,GAAG,eAAe,CAAC,KAAK,CAAC,CAAC;oBACxC,CAAC;gBACH,CAAC;YACH,CAAC;YACD,0BAA0B;YAC1B,IAAI,IAAI,CAAC,IAAI,KAAK,YAAY,IAAI,mBAAmB,CAAC,IAAI,CAAC,EAAE,CAAC;gBAC5D,YAAY,GAAG,eAAe,CAAC,IAAI,CAAC,CAAC;YACvC,CAAC;YAED,IAAI,CAAC,YAAY;gBAAE,SAAS;YAE5B,qEAAqE;YACrE,MAAM,WAAW,GAAG,IAAI,CAAC,gBAAgB,CAAC;YAC1C,IAAI,CAAC,WAAW;gBAAE,SAAS;YAE3B,IAAI,WAAW,CAAC,IAAI,KAAK,cAAc,IAAI,WAAW,CAAC,IAAI,KAAK,sBAAsB,EAAE,CAAC;gBACvF,MAAM,SAAS,GAAG,WAAW,CAAC,iBAAiB,CAAC,WAAW,CAAC,IAAI,WAAW,CAAC;gBAC5E,IAAI,WAAW,CAAC,SAAS,CAAC,IAAI,SAAS,CAAC,IAAI,CAAC,QAAQ,CAAC,YAAY,CAAC,EAAE,CAAC;oBACpE,QAAQ,CAAC,IAAI,CAAC;wBACZ,IAAI,EAAE,QAAQ;wBACd,IAAI,EAAE,WAAW,CAAC,aAAa,CAAC,GAAG,GAAG,CAAC;wBACvC,MAAM,EAAE,WAAW,CAAC,aAAa,CAAC,MAAM,GAAG,CAAC;wBAC5C,OAAO,EAAE,WAAW,CAAC,WAAW,CAAC,GAAG,GAAG,CAAC;wBACxC,SAAS,EAAE,WAAW,CAAC,WAAW,CAAC,MAAM,GAAG,CAAC;wBAC7C,IAAI,EAAE,sBAAsB;wBAC5B,QAAQ,EAAE,MAAM;wBAChB,OAAO,EAAE,kBAAkB,YAAY,wEAAwE,IAAI,CAAC,aAAa,CAAC,GAAG,GAAG,CAAC,EAAE;qBAC5I,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;QACH,CAAC;QAED,sCAAsC;QACtC,MAAM,YAAY,GAAG,IAAA,uBAAc,EAAC,IAAI,CAAC,QAAQ,EAAE,CAAC,cAAc,CAAC,CAAC,CAAC;QACrE,KAAK,MAAM,MAAM,IAAI,YAAY,EAAE,CAAC;YAClC,MAAM,SAAS,GAAG,MAAM,CAAC,iBAAiB,CAAC,WAAW,CAAC,CAAC;YACxD,IAAI,CAAC,SAAS,IAAI,CAAC,WAAW,CAAC,SAAS,CAAC;gBAAE,SAAS;YAEpD,MAAM,WAAW,GAAG,MAAM,CAAC,iBAAiB,CAAC,aAAa,CAAC,IAAI,MAAM,CAAC,iBAAiB,CAAC,MAAM,CAAC,CAAC;YAChG,IAAI,CAAC,WAAW;gBAAE,SAAS;YAE3B,8CAA8C;YAC9C,IAAA,iBAAQ,EAAC,WAAW,EAAE,CAAC,KAAK,EAAE,EAAE;gBAC9B,IAAI,KAAK,CAAC,IAAI,KAAK,cAAc,IAAI,KAAK,KAAK,MAAM,EAAE,CAAC;oBACtD,MAAM,SAAS,GAAG,KAAK,CAAC,iBAAiB,CAAC,WAAW,CAAC,CAAC;oBACvD,IAAI,SAAS,IAAI,WAAW,CAAC,SAAS,CAAC,IAAI,SAAS,CAAC,IAAI,KAAK,SAAS,CAAC,IAAI,EAAE,CAAC;wBAC7E,QAAQ,CAAC,IAAI,CAAC;4BACZ,IAAI,EAAE,QAAQ;4BACd,IAAI,EAAE,KAAK,CAAC,aAAa,CAAC,GAAG,GAAG,CAAC;4BACjC,MAAM,EAAE,KAAK,CAAC,aAAa,CAAC,MAAM,GAAG,CAAC;4BACtC,OAAO,EAAE,KAAK,CAAC,WAAW,CAAC,GAAG,GAAG,CAAC;4BAClC,SAAS,EAAE,KAAK,CAAC,WAAW,CAAC,MAAM,GAAG,CAAC;4BACvC,IAAI,EAAE,sBAAsB;4BAC5B,QAAQ,EAAE,MAAM;4BAChB,OAAO,EAAE,2BAA2B,SAAS,CAAC,IAAI,gCAAgC,MAAM,CAAC,aAAa,CAAC,GAAG,GAAG,CAAC,EAAE;yBACjH,CAAC,CAAC;oBACL,CAAC;gBACH,CAAC;YACH,CAAC,CAAC,CAAC;QACL,CAAC;QAED,OAAO,QAAQ,CAAC;IAClB,CAAC;CACF,CAAC"}
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"redundant-else-return.d.ts","sourceRoot":"","sources":["../../src/rules/redundant-else-return.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAW,IAAI,EAAE,MAAM,UAAU,CAAC;AAS9C,eAAO,MAAM,mBAAmB,EAAE,IAiDjC,CAAC"}
|
|
@@ -0,0 +1,57 @@
|
|
|
1
|
+
"use strict";
|
|
2
|
+
Object.defineProperty(exports, "__esModule", { value: true });
|
|
3
|
+
exports.redundantElseReturn = void 0;
|
|
4
|
+
const parser_1 = require("../parser");
|
|
5
|
+
function blockEndsWithReturn(block) {
|
|
6
|
+
const children = block.namedChildren;
|
|
7
|
+
if (children.length === 0)
|
|
8
|
+
return false;
|
|
9
|
+
const last = children[children.length - 1];
|
|
10
|
+
return last.type === 'return_statement' || last.type === 'throw_statement';
|
|
11
|
+
}
|
|
12
|
+
exports.redundantElseReturn = {
|
|
13
|
+
name: 'redundant-else-return',
|
|
14
|
+
description: 'Flags else blocks after if blocks that end with return/throw',
|
|
15
|
+
severity: 'info',
|
|
16
|
+
check(tree, source, filePath) {
|
|
17
|
+
const findings = [];
|
|
18
|
+
const ifStatements = (0, parser_1.findNodes)(tree.rootNode, 'if_statement');
|
|
19
|
+
for (const ifNode of ifStatements) {
|
|
20
|
+
const consequence = ifNode.childForFieldName('consequence');
|
|
21
|
+
const alternative = ifNode.childForFieldName('alternative');
|
|
22
|
+
if (!consequence || !alternative)
|
|
23
|
+
continue;
|
|
24
|
+
// Skip if the alternative is another if statement (else if chains are fine)
|
|
25
|
+
if (alternative.type === 'if_statement')
|
|
26
|
+
continue;
|
|
27
|
+
// For else_clause, check the inner block
|
|
28
|
+
let altBlock = alternative;
|
|
29
|
+
if (alternative.type === 'else_clause') {
|
|
30
|
+
const inner = alternative.namedChildren[0];
|
|
31
|
+
if (!inner || inner.type === 'if_statement')
|
|
32
|
+
continue;
|
|
33
|
+
altBlock = inner;
|
|
34
|
+
}
|
|
35
|
+
// Check if the if-block ends with return or throw
|
|
36
|
+
let ifBlock = consequence;
|
|
37
|
+
if (consequence.type === 'statement_block') {
|
|
38
|
+
ifBlock = consequence;
|
|
39
|
+
}
|
|
40
|
+
if (!blockEndsWithReturn(ifBlock))
|
|
41
|
+
continue;
|
|
42
|
+
// The else block is redundant — the code inside could be un-indented
|
|
43
|
+
findings.push({
|
|
44
|
+
file: filePath,
|
|
45
|
+
line: alternative.startPosition.row + 1,
|
|
46
|
+
column: alternative.startPosition.column + 1,
|
|
47
|
+
endLine: alternative.endPosition.row + 1,
|
|
48
|
+
endColumn: alternative.endPosition.column + 1,
|
|
49
|
+
rule: 'redundant-else-return',
|
|
50
|
+
severity: 'info',
|
|
51
|
+
message: 'else block is unnecessary after return/throw — un-indent and remove the else',
|
|
52
|
+
});
|
|
53
|
+
}
|
|
54
|
+
return findings;
|
|
55
|
+
},
|
|
56
|
+
};
|
|
57
|
+
//# sourceMappingURL=redundant-else-return.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"redundant-else-return.js","sourceRoot":"","sources":["../../src/rules/redundant-else-return.ts"],"names":[],"mappings":";;;AACA,sCAAsC;AAGtC,SAAS,mBAAmB,CAAC,KAAwB;IACnD,MAAM,QAAQ,GAAG,KAAK,CAAC,aAAa,CAAC;IACrC,IAAI,QAAQ,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,KAAK,CAAC;IACxC,MAAM,IAAI,GAAG,QAAQ,CAAC,QAAQ,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC;IAC3C,OAAO,IAAI,CAAC,IAAI,KAAK,kBAAkB,IAAI,IAAI,CAAC,IAAI,KAAK,iBAAiB,CAAC;AAC7E,CAAC;AAEY,QAAA,mBAAmB,GAAS;IACvC,IAAI,EAAE,uBAAuB;IAC7B,WAAW,EAAE,8DAA8D;IAC3E,QAAQ,EAAE,MAAM;IAEhB,KAAK,CAAC,IAAiB,EAAE,MAAc,EAAE,QAAgB;QACvD,MAAM,QAAQ,GAAc,EAAE,CAAC;QAC/B,MAAM,YAAY,GAAG,IAAA,kBAAS,EAAC,IAAI,CAAC,QAAQ,EAAE,cAAc,CAAC,CAAC;QAE9D,KAAK,MAAM,MAAM,IAAI,YAAY,EAAE,CAAC;YAClC,MAAM,WAAW,GAAG,MAAM,CAAC,iBAAiB,CAAC,aAAa,CAAC,CAAC;YAC5D,MAAM,WAAW,GAAG,MAAM,CAAC,iBAAiB,CAAC,aAAa,CAAC,CAAC;YAE5D,IAAI,CAAC,WAAW,IAAI,CAAC,WAAW;gBAAE,SAAS;YAE3C,4EAA4E;YAC5E,IAAI,WAAW,CAAC,IAAI,KAAK,cAAc;gBAAE,SAAS;YAElD,yCAAyC;YACzC,IAAI,QAAQ,GAAG,WAAW,CAAC;YAC3B,IAAI,WAAW,CAAC,IAAI,KAAK,aAAa,EAAE,CAAC;gBACvC,MAAM,KAAK,GAAG,WAAW,CAAC,aAAa,CAAC,CAAC,CAAC,CAAC;gBAC3C,IAAI,CAAC,KAAK,IAAI,KAAK,CAAC,IAAI,KAAK,cAAc;oBAAE,SAAS;gBACtD,QAAQ,GAAG,KAAK,CAAC;YACnB,CAAC;YAED,kDAAkD;YAClD,IAAI,OAAO,GAAG,WAAW,CAAC;YAC1B,IAAI,WAAW,CAAC,IAAI,KAAK,iBAAiB,EAAE,CAAC;gBAC3C,OAAO,GAAG,WAAW,CAAC;YACxB,CAAC;YAED,IAAI,CAAC,mBAAmB,CAAC,OAAO,CAAC;gBAAE,SAAS;YAE5C,qEAAqE;YACrE,QAAQ,CAAC,IAAI,CAAC;gBACZ,IAAI,EAAE,QAAQ;gBACd,IAAI,EAAE,WAAW,CAAC,aAAa,CAAC,GAAG,GAAG,CAAC;gBACvC,MAAM,EAAE,WAAW,CAAC,aAAa,CAAC,MAAM,GAAG,CAAC;gBAC5C,OAAO,EAAE,WAAW,CAAC,WAAW,CAAC,GAAG,GAAG,CAAC;gBACxC,SAAS,EAAE,WAAW,CAAC,WAAW,CAAC,MAAM,GAAG,CAAC;gBAC7C,IAAI,EAAE,uBAAuB;gBAC7B,QAAQ,EAAE,MAAM;gBAChB,OAAO,EAAE,8EAA8E;aACxF,CAAC,CAAC;QACL,CAAC;QAED,OAAO,QAAQ,CAAC;IAClB,CAAC;CACF,CAAC"}
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"single-option-object.d.ts","sourceRoot":"","sources":["../../src/rules/single-option-object.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAW,IAAI,EAAE,MAAM,UAAU,CAAC;AA+C9C,eAAO,MAAM,kBAAkB,EAAE,IA+ChC,CAAC"}
|