dimsum-e2e-tests 3.80.0-next.4 → 3.80.0-next.41

package/ds-progress-indicator/DSProgressIndicatorCO.js

@@ -1,26 +1,104 @@
 import { PATH_E2E_PROGRESS_INDICATOR } from '../paths';
 import { PageObject, Urlbuilder } from '../helpers';
 
+// Slot testids owned by the component (packages/atom/ds-progress-indicator/src/constants/index.ts).
+// Note the lowercase `i` in "progressindicator": it comes from DSProgressIndicatorName.
+const SLOT_TESTID = {
+  ROOT: 'ds-progressindicator-root',
+  TITLE: 'ds-progressindicator-title',
+  COUNTER: 'ds-progressindicator-counter',
+  PROGRESS_BAR: 'ds-progressindicator-progress-bar',
+  PROGRESS: 'ds-progressindicator-progress',
+};
+
+// In segmented mode every segment reuses the PROGRESS testid, and the stories render several
+// indicators per page, so selectors are scoped by the story's per-scenario `*-case` wrapper.
+// Omit `caseTestId` for single-indicator stories such as BasicTest.
+const scoped = (testId, caseTestId) =>
+  caseTestId ? `[data-testid="${caseTestId}"] [data-testid="${testId}"]` : `[data-testid="${testId}"]`;
+
 export default class DSProgressIndicatorCO extends PageObject {
   // Desktop
   static basicURL = new Urlbuilder(PATH_E2E_PROGRESS_INDICATOR, 'basic-test');
 
   static othersURL = new Urlbuilder(PATH_E2E_PROGRESS_INDICATOR, 'others-test');
 
-  static getUrl(component = 'basic') {
-    return PageObject.getUrl(PATH_E2E_PROGRESS_INDICATOR, component);
+  static ariaContractURL = new Urlbuilder(PATH_E2E_PROGRESS_INDICATOR, 'aria-contract-test');
+
+  static slotsURL = new Urlbuilder(PATH_E2E_PROGRESS_INDICATOR, 'slots-test');
+
+  static singleBarVariantURL = new Urlbuilder(PATH_E2E_PROGRESS_INDICATOR, 'single-bar-variant-test');
+
+  static SLOT_TESTID = SLOT_TESTID;
+
+  // selectors
+  static async getRoot(caseTestId) {
+    return $(scoped(SLOT_TESTID.ROOT, caseTestId));
   }
 
-  static async getUploadLabel() {
-    return $('//span[contains(text(), "upload")]');
+  static async getTitle(caseTestId) {
+    return $(scoped(SLOT_TESTID.TITLE, caseTestId));
   }
 
-  // Snapshots
-  static snapshotPath(example = 'basic') {
-    return PageObject.getSnapshotPathBuilder('ProgressIndicator', example);
+  static async getCounter(caseTestId) {
+    return $(scoped(SLOT_TESTID.COUNTER, caseTestId));
+  }
+
+  static async getProgressBar(caseTestId) {
+    return $(scoped(SLOT_TESTID.PROGRESS_BAR, caseTestId));
+  }
+
+  // First (or only) progressbar of a case. Use getProgressBars for the segmented ones.
+  static async getProgress(caseTestId) {
+    return $(scoped(SLOT_TESTID.PROGRESS, caseTestId));
+  }
+
+  static async getProgressBars(caseTestId) {
+    return $$(scoped(SLOT_TESTID.PROGRESS, caseTestId));
+  }
+
+  // Text node DSTypography renders inside a slot, e.g. getTypographyIn(SLOT_TESTID.TITLE).
+  static async getTypographyIn(slotTestId, caseTestId) {
+    return $(`${scoped(slotTestId, caseTestId)} [data-dimsum-slot="dsTypographyRoot"]`);
+  }
+
+  // Slot-level lookups, for asserting the data-dimsum-slot contract independently of the testids.
+  static async getSlot(slotName, caseTestId) {
+    const prefix = caseTestId ? `[data-testid="${caseTestId}"] ` : '';
+    return $(`${prefix}[data-dimsum-slot="${slotName}"]`);
+  }
+
+  static async getSlots(slotName, caseTestId) {
+    const prefix = caseTestId ? `[data-testid="${caseTestId}"] ` : '';
+    return $$(`${prefix}[data-dimsum-slot="${slotName}"]`);
+  }
+
+  // aria-labelledby points at a React.useId() value containing ":", which is not a valid CSS id
+  // selector, so the target has to be resolved through the attribute selector instead of "#id".
+  static async getByIdAttribute(id) {
+    return $(`[id="${id}"]`);
   }
 
-  // selectors
-  // actions
   // utils
+  // OthersTest drives two indicators with setInterval counters. They stop once each counter reaches
+  // its max, so the story is only deterministic after both have landed on their final totals.
+  //
+  // The texts are read in a single browser.execute rather than by mapping over $$: WebdriverIO's
+  // element array overrides .map() to return a Promise, so Promise.all(list.map(...)) throws
+  // "object is not iterable". One round trip per poll is also cheaper than four.
+  static async waitForAnimatedCountersToSettle() {
+    await browser.waitUntil(
+      async () => {
+        const texts = await browser.execute(
+          (testId) => Array.from(document.querySelectorAll(`[data-testid="${testId}"]`), (el) => el.textContent),
+          SLOT_TESTID.COUNTER,
+        );
+        return texts.length >= 4 && texts[1] === '400 of 400' && texts[2] === '330 of 330';
+      },
+      {
+        timeout: 15000,
+        timeoutMsg: 'animated progress indicators never reached their final value',
+      },
+    );
+  }
 }

package/ds-progress-indicator/aria-contract/DSProgressIndicator.aria-contract.func.spec.js

@@ -0,0 +1,104 @@
+import DSProgressIndicatorCO from '../DSProgressIndicatorCO';
+
+// Coverage for the accessibility remediation shipped in PUI-18856 (PR #8353):
+//   PUI-18671 the progressbar used to carry a hardcoded aria-label="progress bar". It is now named
+//             by the visible title through aria-labelledby, and that string survives only as the
+//             fallback for an untitled indicator.
+//   PUI-18673 aria-valuetext now mirrors whatever the visible counter renders, default or custom.
+//   PUI-18675 each segment accepts a `label` that becomes its own accessible name. Only the Dimsum
+//             half of that defect is assertable here; the visible non-colour alternative is the
+//             consumer's, see stories/docs/principles/a11y/tradesoff.
+//   PUI-18672 an invalid `max` no longer produces width: NaN% and an inverted ARIA range. `max` was
+//             deliberately NOT made required (KNOWN_INTENTIONAL_DEVIATIONS.md, deviation 6), so what
+//             is asserted below is the shipped fail-safe: an indeterminate progressbar.
+//
+// Every assertion is a DOM attribute, which is identical across engines, so this runs Chrome only.
+// The `|| 'Chrome'` branch is mandatory: BrowserStack reports the capitalised name and a
+// lowercase-only guard would register zero tests while still exiting 0.
+if (
+  (!browser.capabilities['ice:options'].isPhone &&
+    !browser.capabilities['ice:options'].isTablet &&
+    browser.capabilities.browserName === 'chrome') ||
+  browser.capabilities.browserName === 'Chrome'
+) {
+  describe('PUI-19209 - DSProgressIndicator:: progressbar ARIA contract - Func', () => {
+    before('loading page', async () => {
+      const errorOnGo = await DSProgressIndicatorCO.ariaContractURL.go();
+      if (errorOnGo) throw errorOnGo;
+    });
+
+    it('01: should name the progressbar from the visible title and fall back when untitled', async () => {
+      const titled = await DSProgressIndicatorCO.getProgress('titled-case');
+      await titled.waitForDisplayed();
+      await expect(titled).not.toHaveAttribute('aria-label');
+
+      // The id is generated with React.useId(), so it is resolved at runtime rather than hardcoded.
+      const labelledBy = await titled.getAttribute('aria-labelledby');
+      const title = await DSProgressIndicatorCO.getTitle('titled-case');
+      await expect(await title.getAttribute('id')).toEqual(labelledBy);
+      await expect(await DSProgressIndicatorCO.getByIdAttribute(labelledBy)).toHaveText('Uploading documents');
+
+      const titleless = await DSProgressIndicatorCO.getProgress('titleless-case');
+      await expect(titleless).toHaveAttribute('aria-label', 'progress bar');
+      await expect(titleless).not.toHaveAttribute('aria-labelledby');
+    });
+
+    it('02: should mirror the visible counter in aria-valuetext for default and custom renderers', async () => {
+      const defaultCounter = await DSProgressIndicatorCO.getCounter('titled-case');
+      await expect(defaultCounter).toHaveText('50 of 100');
+      const defaultBar = await DSProgressIndicatorCO.getProgress('titled-case');
+      await expect(defaultBar).toHaveAttribute('aria-valuetext', '50 of 100');
+
+      const customCounter = await DSProgressIndicatorCO.getCounter('custom-counter-case');
+      await expect(customCounter).toHaveText('3 files remaining');
+      const customBar = await DSProgressIndicatorCO.getProgress('custom-counter-case');
+      await expect(customBar).toHaveAttribute('aria-valuetext', '3 files remaining');
+    });
+
+    it('03: should give each labelled segment its own accessible name', async () => {
+      const labelled = await DSProgressIndicatorCO.getProgressBars('labelled-segments-case');
+      await expect(labelled).toBeElementsArrayOfSize(2);
+
+      // A segment label wins over the indicator title, so aria-labelledby is dropped entirely.
+      await expect(labelled[0]).toHaveAttribute('aria-label', 'Approved documents');
+      await expect(labelled[0]).not.toHaveAttribute('aria-labelledby');
+      await expect(labelled[1]).toHaveAttribute('aria-label', 'Rejected documents');
+      await expect(labelled[1]).not.toHaveAttribute('aria-labelledby');
+
+      // Each segment reports its own range rather than the aggregate shown by the counter.
+      await expect(labelled[0]).toHaveAttribute('aria-valuetext', '50 of 100');
+      await expect(labelled[1]).toHaveAttribute('aria-valuetext', '100 of 200');
+
+      // An unlabelled segment still falls back to the indicator title.
+      const mixed = await DSProgressIndicatorCO.getProgressBars('mixed-segments-case');
+      await expect(mixed).toBeElementsArrayOfSize(2);
+      await expect(mixed[0]).toHaveAttribute('aria-label', 'Completed');
+      await expect(mixed[1]).not.toHaveAttribute('aria-label');
+      const fallbackId = await mixed[1].getAttribute('aria-labelledby');
+      await expect(await DSProgressIndicatorCO.getByIdAttribute(fallbackId)).toHaveText('Batch upload');
+    });
+
+    it('04: should render indeterminate for an invalid max and clamp an overflowing value', async () => {
+      const expectIndeterminate = async (caseId) => {
+        const bar = await DSProgressIndicatorCO.getProgress(caseId);
+        await expect(bar).toHaveAttribute('role', 'progressbar');
+        await expect(bar).not.toHaveAttribute('aria-valuenow');
+        await expect(bar).not.toHaveAttribute('aria-valuemin');
+        await expect(bar).not.toHaveAttribute('aria-valuemax');
+        await expect(bar).not.toHaveAttribute('aria-valuetext');
+        // The pre-fix behaviour was width: NaN%; the guard now yields a valid zero-length fill.
+        await expect(await bar.getAttribute('style')).toContain('width: 0%');
+        // The indicator is still named, so the invalid range degrades without losing the label.
+        await expect(bar).toHaveAttribute('aria-labelledby');
+      };
+
+      await expectIndeterminate('omitted-max-case');
+      await expectIndeterminate('zero-max-case');
+
+      const overflow = await DSProgressIndicatorCO.getProgress('overflow-case');
+      await expect(overflow).toHaveAttribute('aria-valuenow', '100');
+      await expect(overflow).toHaveAttribute('aria-valuemax', '100');
+      await expect(await overflow.getAttribute('style')).toContain('width: 100%');
+    });
+  });
+}

package/ds-progress-indicator/slots/DSProgressIndicator.slots.axe-core.func.spec.js

@@ -0,0 +1,31 @@
+import DSProgressIndicatorCO from '../DSProgressIndicatorCO';
+import { axeCoreCheck } from '../../helpers';
+
+// SlotsTest is the only ProgressIndicator story that overrides color/backgroundColor, so it is the
+// one place where the test code itself can introduce a contrast regression. This run is what makes
+// the WCAG 2 AA pairs in the story load-bearing rather than advisory. It also guards the
+// consumer-supplied slot aria-label against colliding with the component's own naming.
+//
+// Chrome only: axe-core results do not vary by engine. The `|| 'Chrome'` branch is mandatory,
+// BrowserStack reports the capitalised name and a lowercase-only guard registers zero tests.
+if (
+  (!browser.capabilities['ice:options'].isPhone &&
+    !browser.capabilities['ice:options'].isTablet &&
+    browser.capabilities.browserName === 'chrome') ||
+  browser.capabilities.browserName === 'Chrome'
+) {
+  describe('PUI-19212 - DSProgressIndicator:: slot theming - Axe-Core', () => {
+    before('loading page', async () => {
+      const errorOnGo = await DSProgressIndicatorCO.slotsURL.go();
+      if (errorOnGo) throw errorOnGo;
+    });
+
+    it('01: should have no accessibility violations with custom slot theming', async () => {
+      const root = await DSProgressIndicatorCO.getSlot('dsProgressindicatorRoot', 'segmented-slots-case');
+      await root.waitForDisplayed();
+
+      const result = await axeCoreCheck();
+      expect(result.length).toBe(0);
+    });
+  });
+}

package/ds-progress-indicator/slots/DSProgressIndicator.slots.func.spec.js

@@ -0,0 +1,87 @@
+import DSProgressIndicatorCO from '../DSProgressIndicatorCO';
+
+// Slot contract coverage for the compliance migration in PUI-18856 / PUI-18941. The package dropped
+// ds-classnames/aggregatedClasses for the native slot system, so each visual element must now be
+// addressable through data-dimsum-slot and must accept consumer slot props.
+//
+// The consumer's `data-testid` REPLACES the component default, which is why this spec addresses the
+// elements through data-dimsum-slot and then asserts the overridden testid, rather than the other
+// way round.
+//
+// Slot attribute pass-through is engine-independent, so this runs Chrome only. The `|| 'Chrome'`
+// branch is mandatory: BrowserStack reports the capitalised name and a lowercase-only guard would
+// register zero tests while still exiting 0.
+if (
+  (!browser.capabilities['ice:options'].isPhone &&
+    !browser.capabilities['ice:options'].isTablet &&
+    browser.capabilities.browserName === 'chrome') ||
+  browser.capabilities.browserName === 'Chrome'
+) {
+  describe('PUI-19210 - DSProgressIndicator:: slot contract and slot prop forwarding - Func', () => {
+    before('loading page', async () => {
+      const errorOnGo = await DSProgressIndicatorCO.slotsURL.go();
+      if (errorOnGo) throw errorOnGo;
+    });
+
+    it('01: should expose the five slots on both the single and the segmented indicator', async () => {
+      const expectFiveSlots = async (caseId) => {
+        const [root, title, counter, progressBar, progress] = await Promise.all([
+          DSProgressIndicatorCO.getSlot('dsProgressindicatorRoot', caseId),
+          DSProgressIndicatorCO.getSlot('dsProgressindicatorTitle', caseId),
+          DSProgressIndicatorCO.getSlot('dsProgressindicatorCounter', caseId),
+          DSProgressIndicatorCO.getSlot('dsProgressindicatorProgressBar', caseId),
+          DSProgressIndicatorCO.getSlot('dsProgressindicatorProgress', caseId),
+        ]);
+
+        await root.waitForDisplayed();
+        await expect(root).toHaveAttribute('data-testid', 'custom-root-data');
+        await expect(title).toHaveAttribute('data-testid', 'custom-title-data');
+        await expect(counter).toHaveAttribute('data-testid', 'custom-counter-data');
+        await expect(progressBar).toHaveAttribute('data-testid', 'custom-progress-bar-data');
+        await expect(progress).toHaveAttribute('data-testid', 'custom-progress-data');
+      };
+
+      await expectFiveSlots('single-slots-case');
+      await expectFiveSlots('segmented-slots-case');
+    });
+
+    it('02: should forward consumer slot props to every slot and to each segment', async () => {
+      const [title, counter, progress] = await Promise.all([
+        DSProgressIndicatorCO.getSlot('dsProgressindicatorTitle', 'single-slots-case'),
+        DSProgressIndicatorCO.getSlot('dsProgressindicatorCounter', 'single-slots-case'),
+        DSProgressIndicatorCO.getSlot('dsProgressindicatorProgress', 'single-slots-case'),
+      ]);
+
+      await expect(title).toHaveAttribute('lang', 'en');
+      await expect(counter).toHaveAttribute('title', 'custom counter title');
+
+      // The progress slot carries role="progressbar", so a slot-level aria-label is legal there and
+      // is forwarded. It does not become the accessible name though: the component also emits its
+      // own aria-labelledby pointing at the title, and aria-labelledby outranks aria-label. Chrome's
+      // accessibility tree names these bars after their title, not "custom progress aria".
+      //
+      // That is the intended outcome, not a gap. Keeping the name tied to the visible title is the
+      // WCAG 2.5.3 Label in Name principle, and localisation is handled by passing a translated
+      // `title` rather than by overriding the label. The slot-level aria-label only takes effect on
+      // a titleless indicator, where the component would otherwise fall back to "progress bar".
+      // Asserting both attributes here pins the forwarding contract without implying the override
+      // wins the name.
+      await expect(progress).toHaveAttribute('role', 'progressbar');
+      await expect(progress).toHaveAttribute('aria-label', 'custom progress aria');
+      await expect(progress).toHaveAttribute('aria-labelledby');
+
+      // Slot props must reach every segment, not just the first one. The segments are addressed by
+      // index rather than with .map(): WebdriverIO's element array overrides .map() to return a
+      // Promise, so Promise.all(segments.map(...)) throws "object is not iterable".
+      const segments = await DSProgressIndicatorCO.getSlots('dsProgressindicatorProgress', 'segmented-slots-case');
+      await expect(segments).toBeElementsArrayOfSize(3);
+
+      await expect(segments[0]).toHaveAttribute('data-testid', 'custom-progress-data');
+      await expect(segments[0]).toHaveAttribute('aria-label', 'custom progress aria');
+      await expect(segments[1]).toHaveAttribute('data-testid', 'custom-progress-data');
+      await expect(segments[1]).toHaveAttribute('aria-label', 'custom progress aria');
+      await expect(segments[2]).toHaveAttribute('data-testid', 'custom-progress-data');
+      await expect(segments[2]).toHaveAttribute('aria-label', 'custom progress aria');
+    });
+  });
+}

package/ds-progress-indicator/slots/DSProgressIndicator.slots.visual.spec.js

@@ -0,0 +1,27 @@
+import DSProgressIndicatorCO from '../DSProgressIndicatorCO';
+
+// Visual half of the PUI-18856 slot migration: proves the styleOverrides payload actually reaches
+// each slot after the move off ds-classnames. The functional spec covers the attribute contract, so
+// this only needs the rendered appearance.
+//
+// This snapshot also guards the cascade fix for the `progress-bar` slot: its styleOverride used to lose to
+// the retained SCSS rule `.em-ds-determinate-progress-indicator .em-ds-progress-bar` (two classes beat the
+// single styled-components class) and the track stayed grey. The package now re-emits every slot override
+// that a legacy descendant rule could beat under `&&&`, so all five slots take their overrides here. jsdom
+// does not honour specificity, so this real-browser snapshot is the only place the cascade itself is proven.
+if (!browser.capabilities['ice:options'].isPhone && !browser.capabilities['ice:options'].isTablet) {
+  describe('PUI-19211 - DSProgressIndicator:: slot theming - Visual', () => {
+    before('loading page', async () => {
+      const errorOnGo = await DSProgressIndicatorCO.slotsURL.go();
+      if (errorOnGo) throw errorOnGo;
+    });
+
+    it('01: should display the single and segmented indicators with slot theming applied', async () => {
+      const root = await DSProgressIndicatorCO.getSlot('dsProgressindicatorRoot', 'segmented-slots-case');
+      await root.waitForDisplayed();
+
+      const snapshot = await browser.percyCheckScreenshot();
+      await expect(snapshot).toEqual(0);
+    });
+  });
+}

package/ds-progress-indicator/variant/DSProgressIndicator.single-bar-variant.func.spec.js

@@ -0,0 +1,44 @@
+import DSProgressIndicatorCO from '../DSProgressIndicatorCO';
+
+// Tests for the fix introduced in PUI-18677: `variant` used to be ignored in single-bar mode, so every
+// single bar rendered the default fill.
+//
+// Theme-agnostic on purpose: no colour value is pinned. Each variant only has to paint a fill that differs
+// from the default one; the exact palette is guarded by the visual spec.
+//
+// Chrome only: a computed style of a static story does not vary by engine. The `|| 'Chrome'` branch is
+// mandatory, BrowserStack reports the capitalised name and a lowercase-only guard registers zero tests.
+if (
+  (!browser.capabilities['ice:options'].isPhone &&
+    !browser.capabilities['ice:options'].isTablet &&
+    browser.capabilities.browserName === 'chrome') ||
+  browser.capabilities.browserName === 'Chrome'
+) {
+  describe('PUI-19235 - DSProgressIndicator:: single-bar variant fill colour - Func', () => {
+    before('loading page', async () => {
+      const errorOnGo = await DSProgressIndicatorCO.singleBarVariantURL.go();
+      if (errorOnGo) throw errorOnGo;
+    });
+
+    it('01: should paint each single-bar variant fill differently from the default', async () => {
+      const fillColour = async (caseId) => {
+        const bar = await DSProgressIndicatorCO.getProgress(caseId);
+        await bar.waitForDisplayed();
+        return (await bar.getCSSProperty('background-color')).parsed.hex;
+      };
+
+      const defaultColour = await fillColour('default-case');
+      const success = await fillColour('success-case');
+      const warning = await fillColour('warning-case');
+      const info = await fillColour('info-case');
+      const error = await fillColour('error-case');
+
+      await expect(success).not.toEqual(defaultColour);
+      await expect(warning).not.toEqual(defaultColour);
+      await expect(info).not.toEqual(defaultColour);
+      await expect(error).not.toEqual(defaultColour);
+      // The variants must also be told apart from each other, not just from the default.
+      await expect(new Set([defaultColour, success, warning, info, error]).size).toBe(5);
+    });
+  });
+}

package/ds-progress-indicator/variant/DSProgressIndicator.single-bar-variant.visual.spec.js

@@ -0,0 +1,19 @@
+import DSProgressIndicatorCO from '../DSProgressIndicatorCO';
+
+// Tests for the fix introduced in PUI-18677: the single-bar `variant` now reaches the fill. The functional
+// spec only proves the colours differ; this baseline records the actual palette per variant.
+if (!browser.capabilities['ice:options'].isPhone && !browser.capabilities['ice:options'].isTablet) {
+  describe('PUI-19236 - DSProgressIndicator:: single-bar variant fill colour - Visual', () => {
+    before('loading page', async () => {
+      const errorOnGo = await DSProgressIndicatorCO.singleBarVariantURL.go();
+      if (errorOnGo) throw errorOnGo;
+    });
+
+    it('01: should display one single-bar indicator per variant', async () => {
+      await (await DSProgressIndicatorCO.getProgress('error-case')).waitForDisplayed();
+
+      const snapshot = await browser.percyCheckScreenshot();
+      await expect(snapshot).toEqual(0);
+    });
+  });
+}

package/ds-ribbon/DSRibbonCO.js

@@ -12,6 +12,10 @@ export default class DSRibbonCO extends PageObject {
 
   static themingURL = new Urlbuilder(PATH_E2E_RIBBON, 'theming-test');
 
+  static wrapColumnsURL = new Urlbuilder(PATH_E2E_RIBBON, 'wrap-columns-test');
+
+  static keyboardAccessibleRowURL = new Urlbuilder(PATH_E2E_RIBBON, 'keyboard-accessible-row-test');
+
   static async getRibbon() {
     return $('[data-testid="button-wrapper"]');
   }
@@ -91,6 +95,23 @@ export default class DSRibbonCO extends PageObject {
     return $('[data-testid="ribbon-card-theming"]');
   }
 
+  // Wrap Columns / Keyboard Accessible Row selectors
+  static async getRowInContainer(containerTestId) {
+    return $(`[data-testid="${containerTestId}"] [data-dimsum-slot="dsRibbonRibbonRow"]`);
+  }
+
+  static async getWrapColumnsRow() {
+    return DSRibbonCO.getRowInContainer('ribbon-wrap-columns-container');
+  }
+
+  static async getFocusableRow() {
+    return DSRibbonCO.getRowInContainer('ribbon-focusable-row-container');
+  }
+
+  static async getExpandProcessedBtn() {
+    return $('[data-testid="expand-processed-btn"]');
+  }
+
   // Snapshots
   static snapshotPath(example = 'basic') {
     return PageObject.getSnapshotPathBuilder('Ribbon', example, 'ds-modal');

package/ds-ribbon/keyboard-accessible-row/DSRibbon.keyboard-accessible-row.visual.spec.js

@@ -0,0 +1,40 @@
+import { Key } from 'webdriverio';
+import DSRibbonCO from '../DSRibbonCO';
+
+// Kept at module scope so the waitUntil below stays within the max-nested-callbacks limit.
+const readScrollLeft = (el) => el.scrollLeft;
+
+if (!browser.capabilities['ice:options'].isPhone && !browser.capabilities['ice:options'].isTablet) {
+  // Tests for the fix introduced in PUI-19188 (scrolling row had no tabindex and could not be reached by keyboard)
+  describe('PUI-19230 - DSRibbon:: scrolling row keyboard access - Visual', () => {
+    before('loading page', async () => {
+      const errorOnGo = await DSRibbonCO.keyboardAccessibleRowURL.go();
+      if (errorOnGo) throw errorOnGo;
+      const row = await DSRibbonCO.getFocusableRow();
+      await row.waitForDisplayed();
+    });
+
+    it('01: should display the focus indicator on the scrolling row', async () => {
+      await browser.keys(Key.Tab);
+      const row = await DSRibbonCO.getFocusableRow();
+      await expect(row).toBeFocused();
+      // The row advertises "use the arrow keys to reach the remaining columns", so drive that before
+      // the snapshot: arrow keys keep focus on the row, so the Tab in 02 still reaches the button.
+      const scrollLeftBefore = await browser.execute(readScrollLeft, row);
+      await browser.keys(Key.ArrowRight);
+      await browser.waitUntil(async () => (await browser.execute(readScrollLeft, row)) > scrollLeftBefore, {
+        timeoutMsg: 'expected ArrowRight to scroll the focused row towards the off-screen columns',
+      });
+      const snapshot = await browser.percyCheckScreenshot();
+      await expect(snapshot).toEqual(0);
+    });
+
+    it('02: should display the off-screen button scrolled into view with focus', async () => {
+      await browser.keys(Key.Tab);
+      const btn = await DSRibbonCO.getExpandProcessedBtn();
+      await expect(btn).toBeFocused();
+      const snapshot = await browser.percyCheckScreenshot();
+      await expect(snapshot).toEqual(0);
+    });
+  });
+}

package/ds-ribbon/wrap-columns/DSRibbon.wrap-columns.visual.spec.js

@@ -0,0 +1,18 @@
+import DSRibbonCO from '../DSRibbonCO';
+
+if (!browser.capabilities['ice:options'].isPhone && !browser.capabilities['ice:options'].isTablet) {
+  // Tests for the fix introduced in PUI-19188 (row scrolled at narrow widths, off-screen columns unreachable)
+  describe('PUI-19229 - DSRibbon:: wrapColumns row wrapping - Visual', () => {
+    before('loading page', async () => {
+      const errorOnGo = await DSRibbonCO.wrapColumnsURL.go();
+      if (errorOnGo) throw errorOnGo;
+      const row = await DSRibbonCO.getWrapColumnsRow();
+      await row.waitForDisplayed();
+    });
+
+    it('01: should display the default scrolling row and the wrapped row', async () => {
+      const snapshot = await browser.percyCheckScreenshot();
+      await expect(snapshot).toEqual(0);
+    });
+  });
+}

package/ds-shuttle-v2/load-more/DSShuttleV2.load-more.keyboard.func.spec.js

@@ -3,8 +3,23 @@
 import { Key } from 'webdriverio';
 import DSShuttleV2CO from '../DSShuttleV2CO';
 
+/**
+ * Tab forward until `element` holds focus, then assert it does. Chromium, Gecko and WebKit do not
+ * agree on how many stops sit between the two panels, so a fixed Tab count activates the wrong
+ * control on some engines. Bounded so a missing stop fails with this assertion instead of looping.
+ */
+const tabUntilFocused = async (element, maxTabs = 10) => {
+  for (let i = 0; i < maxTabs; i += 1) {
+    // eslint-disable-next-line no-await-in-loop
+    if (await element.isFocused()) break;
+    // eslint-disable-next-line no-await-in-loop
+    await browser.keys(Key.Tab);
+  }
+  await expect(element).toBeFocused();
+};
+
 if (!browser.capabilities['ice:options'].isPhone && !browser.capabilities['ice:options'].isTablet) {
-  describe('PUI-9799 - Shuttle V2, TabStops with BAB and LoadMore -Func.', () => {
+  describe('PUI-9799 - Shuttle V2, TabStops with BAB and LoadMore - Keyboard Func.', () => {
     before(async () => {
       const errorOnGo = await DSShuttleV2CO.loadMoreURL.go();
       if (errorOnGo) throw errorOnGo;
@@ -19,43 +34,57 @@ if (!browser.capabilities['ice:options'].isPhone && !browser.capabilities['ice:o
       await expect(BAB).toBeDisplayed();
       await expect(sourcePanelCheckbox).toBeFocused();
     });
-    it('03: should tab and focus the source panel', async () => {
+    it('02: should tab and focus the source panel', async () => {
       await browser.keys(Key.Tab);
       const sourcePanel = await DSShuttleV2CO.getListWrapperMid(0);
       await expect(sourcePanel).toBeFocused();
     });
-    it('04: should tab and focus the BAB', async () => {
+    it('03: should tab and focus the BAB', async () => {
       await browser.keys(Key.Tab);
       const BAB = await DSShuttleV2CO.getMoveMultipleButton(0);
       await expect(BAB).toBeFocused();
     });
-    it('05: should tab and focus the loadmore', async () => {
+    it('04: should tab and focus the loadmore', async () => {
       await browser.keys(Key.Tab);
       const loadMore = await DSShuttleV2CO.getListBottomLoadMoreBtn(0);
       await expect(loadMore).toBeFocused();
     });
-    it('06: should tab and focus the global checkbox from destination panel', async () => {
+    it('05: should tab and focus the global checkbox from destination panel', async () => {
       await browser.keys(Key.Tab);
       const destinationPanelCheckbox = await DSShuttleV2CO.getCheckboxByIndex(1);
       await expect(destinationPanelCheckbox).toBeFocused();
     });
-    it('07: should move all the items to destination panel', async () => {
-      await browser.keys(Key.Return);
-      await browser.keys(Key.Tab);
-      await browser.keys(Key.Tab);
-      await browser.keys(Key.Return);
+    it('06: should move all the items to destination panel', async () => {
+      // Tab counts are not portable: the stops between the two panels differ per engine, and a
+      // hard-coded count lands Return on the wrong control in Safari. Walk until the target has
+      // focus instead, which asserts the same stops on every browser.
+      await tabUntilFocused(await DSShuttleV2CO.getCheckboxByIndex(0));
+      await browser.keys(Key.Return); // select every source item
+      await tabUntilFocused(await DSShuttleV2CO.getMoveMultipleButton());
+      await browser.keys(Key.Return); // move them to the destination
+      await browser.waitUntil(async () => (await DSShuttleV2CO.getItemsFromSource()).length === 0, {
+        timeoutMsg: 'expected the source panel to be emptied into the destination',
+      });
       const emptyListWrapper = await DSShuttleV2CO.getEmptyListWrapper();
       await expect(emptyListWrapper).toHaveText(expect.stringContaining('There are no items to display'));
     });
-    it('08: should load more items and focus the panel body', async () => {
-      await browser.keys(Key.Tab);
-      await browser.keys(Key.Return);
-      // eslint-disable-next-line wdio/no-pause
-      await browser.pause(500); // wait for load more to finish
-      const destinationPanel = await DSShuttleV2CO.getListWrapperMid(1);
+    it('07: should load the first page back into the emptied destination panel', async () => {
+      await tabUntilFocused(await DSShuttleV2CO.getCheckboxByIndex(1));
+      await browser.keys(Key.Return); // select every destination item
+      await tabUntilFocused(await DSShuttleV2CO.getMoveMultipleButton());
+      await browser.keys(Key.Return); // move them out of the destination
+      await browser.waitUntil(async () => (await DSShuttleV2CO.getItemsFromDestination()).length === 0, {
+        timeoutMsg: 'expected the destination panel to be emptied back into the source',
+      });
+      await tabUntilFocused(await DSShuttleV2CO.getListBottomLoadMoreBtn(1));
+      await browser.keys(Key.Return); // load the first page back in
+      // Where focus lands after load more is not asserted: Chromium parks it on the panel body,
+      // Firefox and Safari do not, so it is engine behaviour rather than a component contract.
+      await browser.waitUntil(async () => (await DSShuttleV2CO.getItemsFromDestination()).length === 3, {
+        timeoutMsg: 'expected destination load more to append its first page of 3 items',
+      });
       const destinationItems = (await DSShuttleV2CO.getItemsFromDestination()).length;
       await expect(destinationItems).toBe(3);
-      await expect(destinationPanel).toBeFocused();
     });
   });
 }