digital-tools 2.1.3 → 2.4.0

package/src/providers/crm/hubspot.ts

@@ -25,6 +25,101 @@ import { defineProvider } from '../registry.js'
 
 const HUBSPOT_API_URL = 'https://api.hubapi.com/crm/v3'
 
+// =============================================================================
+// HubSpot API Response Types
+// =============================================================================
+
+/** HubSpot contact properties from API */
+interface HubSpotContactProperties {
+  firstname?: string
+  lastname?: string
+  email?: string
+  phone?: string
+  company?: string
+  jobtitle?: string
+  hubspot_owner_id?: string
+  createdate?: string
+  lastmodifieddate?: string
+  [key: string]: string | undefined
+}
+
+/** HubSpot contact response from API */
+interface HubSpotContact {
+  id: string
+  properties: HubSpotContactProperties
+  createdAt?: string
+  updatedAt?: string
+}
+
+/** HubSpot deal properties from API */
+interface HubSpotDealProperties {
+  dealname?: string
+  amount?: string
+  deal_currency_code?: string
+  dealstage?: string
+  hs_deal_stage_probability?: string
+  associatedcontactid?: string
+  associatedcompanyid?: string
+  hubspot_owner_id?: string
+  closedate?: string
+  createdate?: string
+  hs_lastmodifieddate?: string
+  hs_date_entered_closedwon?: string
+  hs_date_entered_closedlost?: string
+  [key: string]: string | undefined
+}
+
+/** HubSpot deal response from API */
+interface HubSpotDeal {
+  id: string
+  properties: HubSpotDealProperties
+  createdAt?: string
+  updatedAt?: string
+}
+
+/** HubSpot engagement properties from API */
+interface HubSpotEngagementProperties {
+  hs_engagement_type?: string
+  hs_engagement_subject?: string
+  hs_note_body?: string
+  hs_email_text?: string
+  hubspot_owner_id?: string
+  hs_task_due_date?: string
+  hs_engagement_completed_at?: string
+  hs_createdate?: string
+  [key: string]: string | undefined
+}
+
+/** HubSpot engagement response from API */
+interface HubSpotEngagement {
+  id: string
+  properties: HubSpotEngagementProperties
+  createdAt?: string
+}
+
+/** HubSpot paginated list response */
+interface HubSpotListResponse<T> {
+  results: T[]
+  total?: number
+  paging?: {
+    next?: {
+      after: string
+    }
+  }
+}
+
+/** HubSpot association result */
+interface HubSpotAssociationResult {
+  id: string
+}
+
+/** HubSpot error response */
+interface HubSpotErrorResponse {
+  message?: string
+  status?: string
+  category?: string
+}
+
 /**
  * HubSpot provider info
  */
@@ -42,60 +137,70 @@ export const hubspotInfo: ProviderInfo = {
 /**
  * Map HubSpot contact properties to CRMContactData
  */
-function mapContactFromHubSpot(contact: any): CRMContactData {
+function mapContactFromHubSpot(contact: HubSpotContact): CRMContactData {
   const props = contact.properties || {}
   return {
     id: contact.id,
-    firstName: props.firstname || '',
-    lastName: props.lastname || '',
-    email: props.email,
-    phone: props.phone,
-    company: props.company,
-    title: props.jobtitle,
-    ownerId: props.hubspot_owner_id,
-    createdAt: new Date(props.createdate || contact.createdAt),
-    updatedAt: new Date(props.lastmodifieddate || contact.updatedAt),
+    firstName: props['firstname'] || '',
+    lastName: props['lastname'] || '',
+    ...(props['email'] !== undefined && { email: props['email'] }),
+    ...(props['phone'] !== undefined && { phone: props['phone'] }),
+    ...(props['company'] !== undefined && { company: props['company'] }),
+    ...(props['jobtitle'] !== undefined && { title: props['jobtitle'] }),
+    ...(props['hubspot_owner_id'] !== undefined && { ownerId: props['hubspot_owner_id'] }),
+    createdAt: new Date(props['createdate'] || contact.createdAt || Date.now()),
+    updatedAt: new Date(props['lastmodifieddate'] || contact.updatedAt || Date.now()),
   }
 }
 
 /**
  * Map HubSpot deal properties to DealData
  */
-function mapDealFromHubSpot(deal: any): DealData {
+function mapDealFromHubSpot(deal: HubSpotDeal): DealData {
   const props = deal.properties || {}
   return {
     id: deal.id,
-    name: props.dealname || '',
-    value: props.amount ? parseFloat(props.amount) : undefined,
-    currency: props.deal_currency_code,
-    stage: props.dealstage || '',
-    probability: props.hs_deal_stage_probability ? parseFloat(props.hs_deal_stage_probability) : undefined,
-    contactId: props.associatedcontactid,
-    companyId: props.associatedcompanyid,
-    ownerId: props.hubspot_owner_id,
-    closeDate: props.closedate ? new Date(props.closedate) : undefined,
-    createdAt: new Date(props.createdate || deal.createdAt),
-    updatedAt: new Date(props.hs_lastmodifieddate || deal.updatedAt),
-    wonAt: props.hs_date_entered_closedwon ? new Date(props.hs_date_entered_closedwon) : undefined,
-    lostAt: props.hs_date_entered_closedlost ? new Date(props.hs_date_entered_closedlost) : undefined,
+    name: props['dealname'] || '',
+    ...(props['amount'] !== undefined && { value: parseFloat(props['amount']) }),
+    ...(props['deal_currency_code'] !== undefined && { currency: props['deal_currency_code'] }),
+    stage: props['dealstage'] || '',
+    ...(props['hs_deal_stage_probability'] !== undefined && {
+      probability: parseFloat(props['hs_deal_stage_probability']),
+    }),
+    ...(props['associatedcontactid'] !== undefined && { contactId: props['associatedcontactid'] }),
+    ...(props['associatedcompanyid'] !== undefined && { companyId: props['associatedcompanyid'] }),
+    ...(props['hubspot_owner_id'] !== undefined && { ownerId: props['hubspot_owner_id'] }),
+    ...(props['closedate'] !== undefined && { closeDate: new Date(props['closedate']) }),
+    createdAt: new Date(props['createdate'] || deal.createdAt || Date.now()),
+    updatedAt: new Date(props['hs_lastmodifieddate'] || deal.updatedAt || Date.now()),
+    ...(props['hs_date_entered_closedwon'] !== undefined && {
+      wonAt: new Date(props['hs_date_entered_closedwon']),
+    }),
+    ...(props['hs_date_entered_closedlost'] !== undefined && {
+      lostAt: new Date(props['hs_date_entered_closedlost']),
+    }),
   }
 }
 
 /**
  * Map HubSpot engagement to CRMActivityData
  */
-function mapActivityFromHubSpot(engagement: any, contactId: string): CRMActivityData {
+function mapActivityFromHubSpot(engagement: HubSpotEngagement, contactId: string): CRMActivityData {
   const props = engagement.properties || {}
   return {
     id: engagement.id,
-    type: props.hs_engagement_type || 'note',
-    subject: props.hs_engagement_subject || '',
-    body: props.hs_note_body || props.hs_email_text || '',
+    type: props['hs_engagement_type'] || 'note',
+    subject: props['hs_engagement_subject'] || '',
+    body: props['hs_note_body'] || props['hs_email_text'] || '',
     contactId,
-    ownerId: props.hubspot_owner_id || '',
-    dueDate: props.hs_task_due_date ? new Date(props.hs_task_due_date) : undefined,
-    completedAt: props.hs_engagement_completed_at ? new Date(props.hs_engagement_completed_at) : undefined,
-    createdAt: new Date(props.hs_createdate || engagement.createdAt),
+    ownerId: props['hubspot_owner_id'] || '',
+    ...(props['hs_task_due_date'] !== undefined && {
+      dueDate: new Date(props['hs_task_due_date']),
+    }),
+    ...(props['hs_engagement_completed_at'] !== undefined && {
+      completedAt: new Date(props['hs_engagement_completed_at']),
+    }),
+    createdAt: new Date(props['hs_createdate'] || engagement.createdAt || Date.now()),
   }
 }
 
@@ -153,7 +258,10 @@ export function createHubSpotProvider(config: ProviderConfig): CRMProvider {
   }
 
   // Helper function to associate engagement with contact
-  async function associateEngagementWithContact(engagementId: string, contactId: string): Promise<void> {
+  async function associateEngagementWithContact(
+    engagementId: string,
+    contactId: string
+  ): Promise<void> {
     try {
       const response = await fetch(
         `${baseUrl}/objects/engagements/${engagementId}/associations/contacts/${contactId}/engagement_to_contact`,
@@ -217,19 +325,23 @@ export function createHubSpotProvider(config: ProviderConfig): CRMProvider {
     },
 
     async createContact(contact: CreateContactOptions): Promise<CRMContactData> {
-      const properties: Record<string, any> = {
+      const properties: Record<string, string> = {
         firstname: contact.firstName,
         lastname: contact.lastName,
       }
 
-      if (contact.email) properties.email = contact.email
-      if (contact.phone) properties.phone = contact.phone
-      if (contact.company) properties.company = contact.company
-      if (contact.title) properties.jobtitle = contact.title
+      if (contact.email) properties['email'] = contact.email
+      if (contact.phone) properties['phone'] = contact.phone
+      if (contact.company) properties['company'] = contact.company
+      if (contact.title) properties['jobtitle'] = contact.title
 
       // Add custom fields
       if (contact.customFields) {
-        Object.assign(properties, contact.customFields)
+        for (const [key, value] of Object.entries(contact.customFields)) {
+          if (value !== undefined && value !== null) {
+            properties[key] = String(value)
+          }
+        }
       }
 
       try {
@@ -243,11 +355,11 @@ export function createHubSpotProvider(config: ProviderConfig): CRMProvider {
         })
 
         if (!response.ok) {
-          const errorData = await response.json().catch(() => ({}))
-          throw new Error((errorData as any)?.message || `HTTP ${response.status}`)
+          const errorData = (await response.json().catch(() => ({}))) as HubSpotErrorResponse
+          throw new Error(errorData.message || `HTTP ${response.status}`)
         }
 
-        const data: any = await response.json()
+        const data = (await response.json()) as HubSpotContact
         return mapContactFromHubSpot(data)
       } catch (error) {
         throw new Error(
@@ -273,7 +385,7 @@ export function createHubSpotProvider(config: ProviderConfig): CRMProvider {
           throw new Error(`HTTP ${response.status}`)
         }
 
-        const data: any = await response.json()
+        const data = (await response.json()) as HubSpotContact
         return mapContactFromHubSpot(data)
       } catch (error) {
         if (error instanceof Error && error.message.includes('404')) {
@@ -289,18 +401,22 @@ export function createHubSpotProvider(config: ProviderConfig): CRMProvider {
       contactId: string,
       updates: Partial<CreateContactOptions>
     ): Promise<CRMContactData> {
-      const properties: Record<string, any> = {}
+      const properties: Record<string, string> = {}
 
-      if (updates.firstName !== undefined) properties.firstname = updates.firstName
-      if (updates.lastName !== undefined) properties.lastname = updates.lastName
-      if (updates.email !== undefined) properties.email = updates.email
-      if (updates.phone !== undefined) properties.phone = updates.phone
-      if (updates.company !== undefined) properties.company = updates.company
-      if (updates.title !== undefined) properties.jobtitle = updates.title
+      if (updates.firstName !== undefined) properties['firstname'] = updates.firstName
+      if (updates.lastName !== undefined) properties['lastname'] = updates.lastName
+      if (updates.email !== undefined) properties['email'] = updates.email
+      if (updates.phone !== undefined) properties['phone'] = updates.phone
+      if (updates.company !== undefined) properties['company'] = updates.company
+      if (updates.title !== undefined) properties['jobtitle'] = updates.title
 
       // Add custom fields
       if (updates.customFields) {
-        Object.assign(properties, updates.customFields)
+        for (const [key, value] of Object.entries(updates.customFields)) {
+          if (value !== undefined && value !== null) {
+            properties[key] = String(value)
+          }
+        }
       }
 
       try {
@@ -314,11 +430,11 @@ export function createHubSpotProvider(config: ProviderConfig): CRMProvider {
         })
 
         if (!response.ok) {
-          const errorData = await response.json().catch(() => ({}))
-          throw new Error((errorData as any)?.message || `HTTP ${response.status}`)
+          const errorData = (await response.json().catch(() => ({}))) as HubSpotErrorResponse
+          throw new Error(errorData.message || `HTTP ${response.status}`)
         }
 
-        const data: any = await response.json()
+        const data = (await response.json()) as HubSpotContact
         return mapContactFromHubSpot(data)
       } catch (error) {
         throw new Error(
@@ -348,12 +464,12 @@ export function createHubSpotProvider(config: ProviderConfig): CRMProvider {
           throw new Error(`HTTP ${response.status}`)
         }
 
-        const data: any = await response.json()
+        const data = (await response.json()) as HubSpotListResponse<HubSpotContact>
         return {
           items: (data.results || []).map(mapContactFromHubSpot),
-          total: data.total,
+          ...(data.total !== undefined && { total: data.total }),
           hasMore: !!data.paging?.next,
-          nextCursor: data.paging?.next?.after,
+          ...(data.paging?.next?.after !== undefined && { nextCursor: data.paging.next.after }),
         }
       } catch (error) {
         throw new Error(
@@ -400,7 +516,7 @@ export function createHubSpotProvider(config: ProviderConfig): CRMProvider {
           throw new Error(`HTTP ${response.status}`)
         }
 
-        const data: any = await response.json()
+        const data = (await response.json()) as HubSpotListResponse<HubSpotContact>
         return (data.results || []).map(mapContactFromHubSpot)
       } catch (error) {
         throw new Error(
@@ -410,15 +526,16 @@ export function createHubSpotProvider(config: ProviderConfig): CRMProvider {
     },
 
     async createDeal(deal: CreateDealOptions): Promise<DealData> {
-      const properties: Record<string, any> = {
+      const properties: Record<string, string> = {
         dealname: deal.name,
         dealstage: deal.stage,
       }
 
-      if (deal.value !== undefined) properties.amount = String(deal.value)
-      if (deal.currency) properties.deal_currency_code = deal.currency
-      if (deal.closeDate) properties.closedate = deal.closeDate.toISOString()
-      if (deal.probability !== undefined) properties.hs_deal_stage_probability = String(deal.probability)
+      if (deal.value !== undefined) properties['amount'] = String(deal.value)
+      if (deal.currency) properties['deal_currency_code'] = deal.currency
+      if (deal.closeDate) properties['closedate'] = deal.closeDate.toISOString()
+      if (deal.probability !== undefined)
+        properties['hs_deal_stage_probability'] = String(deal.probability)
 
       try {
         const response = await fetch(`${baseUrl}/objects/deals`, {
@@ -431,11 +548,11 @@ export function createHubSpotProvider(config: ProviderConfig): CRMProvider {
         })
 
         if (!response.ok) {
-          const errorData = await response.json().catch(() => ({}))
-          throw new Error((errorData as any)?.message || `HTTP ${response.status}`)
+          const errorData = (await response.json().catch(() => ({}))) as HubSpotErrorResponse
+          throw new Error(errorData.message || `HTTP ${response.status}`)
         }
 
-        const data: any = await response.json()
+        const data = (await response.json()) as HubSpotDeal
         const dealData = mapDealFromHubSpot(data)
 
         // Associate with contact if specified
@@ -473,7 +590,7 @@ export function createHubSpotProvider(config: ProviderConfig): CRMProvider {
           throw new Error(`HTTP ${response.status}`)
         }
 
-        const data: any = await response.json()
+        const data = (await response.json()) as HubSpotDeal
         return mapDealFromHubSpot(data)
       } catch (error) {
         if (error instanceof Error && error.message.includes('404')) {
@@ -486,14 +603,15 @@ export function createHubSpotProvider(config: ProviderConfig): CRMProvider {
     },
 
     async updateDeal(dealId: string, updates: Partial<CreateDealOptions>): Promise<DealData> {
-      const properties: Record<string, any> = {}
+      const properties: Record<string, string> = {}
 
-      if (updates.name !== undefined) properties.dealname = updates.name
-      if (updates.stage !== undefined) properties.dealstage = updates.stage
-      if (updates.value !== undefined) properties.amount = String(updates.value)
-      if (updates.currency !== undefined) properties.deal_currency_code = updates.currency
-      if (updates.closeDate !== undefined) properties.closedate = updates.closeDate.toISOString()
-      if (updates.probability !== undefined) properties.hs_deal_stage_probability = String(updates.probability)
+      if (updates.name !== undefined) properties['dealname'] = updates.name
+      if (updates.stage !== undefined) properties['dealstage'] = updates.stage
+      if (updates.value !== undefined) properties['amount'] = String(updates.value)
+      if (updates.currency !== undefined) properties['deal_currency_code'] = updates.currency
+      if (updates.closeDate !== undefined) properties['closedate'] = updates.closeDate.toISOString()
+      if (updates.probability !== undefined)
+        properties['hs_deal_stage_probability'] = String(updates.probability)
 
       try {
         const response = await fetch(`${baseUrl}/objects/deals/${dealId}`, {
@@ -506,11 +624,11 @@ export function createHubSpotProvider(config: ProviderConfig): CRMProvider {
         })
 
         if (!response.ok) {
-          const errorData = await response.json().catch(() => ({}))
-          throw new Error((errorData as any)?.message || `HTTP ${response.status}`)
+          const errorData = (await response.json().catch(() => ({}))) as HubSpotErrorResponse
+          throw new Error(errorData.message || `HTTP ${response.status}`)
         }
 
-        const data: any = await response.json()
+        const data = (await response.json()) as HubSpotDeal
         return mapDealFromHubSpot(data)
       } catch (error) {
         throw new Error(
@@ -540,12 +658,12 @@ export function createHubSpotProvider(config: ProviderConfig): CRMProvider {
           throw new Error(`HTTP ${response.status}`)
         }
 
-        const data: any = await response.json()
+        const data = (await response.json()) as HubSpotListResponse<HubSpotDeal>
         return {
           items: (data.results || []).map(mapDealFromHubSpot),
-          total: data.total,
+          ...(data.total !== undefined && { total: data.total }),
           hasMore: !!data.paging?.next,
-          nextCursor: data.paging?.next?.after,
+          ...(data.paging?.next?.after !== undefined && { nextCursor: data.paging.next.after }),
         }
       } catch (error) {
         throw new Error(
@@ -554,29 +672,37 @@ export function createHubSpotProvider(config: ProviderConfig): CRMProvider {
       }
     },
 
-    async logActivity(contactId: string, activity: CreateActivityOptions): Promise<CRMActivityData> {
+    async logActivity(
+      contactId: string,
+      activity: CreateActivityOptions
+    ): Promise<CRMActivityData> {
       // Map activity type to HubSpot engagement type
-      const engagementType = activity.type === 'email' ? 'EMAIL' :
-                             activity.type === 'call' ? 'CALL' :
-                             activity.type === 'meeting' ? 'MEETING' :
-                             activity.type === 'task' ? 'TASK' :
-                             'NOTE'
-
-      const properties: Record<string, any> = {
+      const engagementType =
+        activity.type === 'email'
+          ? 'EMAIL'
+          : activity.type === 'call'
+          ? 'CALL'
+          : activity.type === 'meeting'
+          ? 'MEETING'
+          : activity.type === 'task'
+          ? 'TASK'
+          : 'NOTE'
+
+      const properties: Record<string, string> = {
         hs_engagement_type: engagementType.toLowerCase(),
         hs_engagement_subject: activity.subject,
       }
 
       if (activity.body) {
         if (engagementType === 'NOTE') {
-          properties.hs_note_body = activity.body
+          properties['hs_note_body'] = activity.body
         } else if (engagementType === 'EMAIL') {
-          properties.hs_email_text = activity.body
+          properties['hs_email_text'] = activity.body
         }
       }
 
       if (activity.dueDate) {
-        properties.hs_task_due_date = activity.dueDate.toISOString()
+        properties['hs_task_due_date'] = activity.dueDate.toISOString()
       }
 
       try {
@@ -590,11 +716,11 @@ export function createHubSpotProvider(config: ProviderConfig): CRMProvider {
         })
 
         if (!response.ok) {
-          const errorData = await response.json().catch(() => ({}))
-          throw new Error((errorData as any)?.message || `HTTP ${response.status}`)
+          const errorData = (await response.json().catch(() => ({}))) as HubSpotErrorResponse
+          throw new Error(errorData.message || `HTTP ${response.status}`)
         }
 
-        const data: any = await response.json()
+        const data = (await response.json()) as HubSpotEngagement
 
         // Associate engagement with contact
         await associateEngagementWithContact(data.id, contactId)
@@ -624,8 +750,8 @@ export function createHubSpotProvider(config: ProviderConfig): CRMProvider {
           throw new Error(`HTTP ${response.status}`)
         }
 
-        const data: any = await response.json()
-        const engagementIds = (data.results || []).map((r: any) => r.id)
+        const data = (await response.json()) as HubSpotListResponse<HubSpotAssociationResult>
+        const engagementIds = (data.results || []).map((r) => r.id)
 
         if (engagementIds.length === 0) {
           return []
@@ -641,15 +767,15 @@ export function createHubSpotProvider(config: ProviderConfig): CRMProvider {
               },
             })
             if (engResponse.ok) {
-              return engResponse.json()
+              return (await engResponse.json()) as HubSpotEngagement
             }
             return null
           })
         )
 
         return engagements
-          .filter((eng: any) => eng !== null)
-          .map((eng: any) => mapActivityFromHubSpot(eng, contactId))
+          .filter((eng): eng is HubSpotEngagement => eng !== null)
+          .map((eng) => mapActivityFromHubSpot(eng, contactId))
       } catch (error) {
         throw new Error(
           `Failed to list activities: ${error instanceof Error ? error.message : 'Unknown error'}`