diffninja 0.1.1 → 0.2.0

package/README.md

@@ -1,259 +1,115 @@
 # diffninja
 
-PR reviews for humans, not prose from a chatbot, run from inside your coding
-agent. Ask Claude Code, Codex, pi, or another MCP-capable agent CLI to review a
-GitHub PR link and diffninja returns a review workspace where you read the diff,
-write inline comments, and submit the review yourself. Give the agent a diff or
-a git range and diffninja returns an evidence-backed reading agenda alongside
-the complete diff, as structured data for the agent and as a page for you.
-
-diffninja is an MCP server (`review_diff`) plus a `diffninja setup` command that
-registers it. It has no terminal review mode.
-
-Analysis is local and deterministic: no model is called, no source leaves your
-machine, and the same input always gives the same report. Each hunk gets change
-facts — did a comparison, a limit, or an input check change; is a failure handed
-to the caller, deferred, or discarded — each pointing at the changed line it
-rests on. Interpreting what the change means is left to you and, if you ask it,
-to the agent you already use. diffninja writes no review prose. You stay the
-reviewer.
+diffninja helps you review pull requests faster without handing the review to
+a bot. You ask your coding agent (Claude Code, Codex, and others) to review a
+PR. diffninja gives you a review page that shows the changes in the order worth
+reading them, with the agent's notes next to the code. You read, comment, and
+submit the review to GitHub yourself.
+
+## Why use it
+
+- **Read the important changes first.** Big PRs are hard to follow file by
+  file. diffninja numbers each change, most important first, and lets you step
+  through them with `j` and `k`.
+- **Your agent does the first pass.** For each change, the agent answers simple
+  questions: does it change behavior, is it tested, does it match the PR's
+  goal. The answers sit above the code.
+- **Suggested comments, never posted for you.** The agent can suggest short
+  line comments. You add them with one click, edit them, or dismiss them.
+  Nothing reaches GitHub until you press Submit.
+- **Facts you can check.** diffninja points at the exact lines that changed a
+  comparison, a limit, an input check, or error handling. It also shows call
+  flows: which functions call the changed code.
+- **Private.** The analysis runs on your machine. diffninja calls no AI model,
+  needs no API key, and sends your code nowhere. It uses your existing GitHub
+  CLI login to read the PR and post your review.
 
 ## What you need
 
-- **Node.js 22.18 or newer.**
-- **An MCP-capable agent CLI:** Claude Code, Codex, OMP, pi, or any client that
-  can launch a stdio MCP server.
-- **GitHub CLI (`gh`) 2.45.0+, authenticated** (`gh auth login`) — only for
-  reviewing pull requests. diffninja never asks for a token; it reuses your
-  `gh` session.
-- No API key. Git ranges may install missing parsing grammars through npm the
-  first time a language is seen.
+- **Node.js 22.18 or newer**
+- **An agent CLI:** Claude Code, Codex, OMP, or pi (or any tool that supports
+  MCP servers)
+- **GitHub CLI (`gh`) 2.45.0 or newer, logged in:** run `gh auth login` once.
+  Only needed for pull requests.
 
 ## Install
 
-Register the MCP server on every agent CLI you use (Claude Code, Codex, OMP,
-pi) with one command:
+Run this once:
 
 ```bash
-npx -y diffninja setup
+npx -y diffninja@latest setup
 ```
 
-It installs the package globally first, then registers the server in each
-detected CLI. `diffninja setup --help` lists the options (`--cli`,
-`--uninstall`, `--dry-run`, `--no-install`); `docs/mcp-setup.md` has the manual
-entries.
-
-The package ships `diffninja` (setup only) and `diffninja-mcp` (the MCP server).
-`npx` fetches the latest published version on first run; if a cached copy feels
-stale, pin it explicitly (`npx -y diffninja@latest setup`).
-
-On npm 12 and later, which block dependency install scripts by default, setup
-names the ones diffninja needs (`--allow-scripts=diffninja,tree-sitter,...`), so
-nothing extra is required. If you install by hand, pass the same flag:
-`npm install -g --allow-scripts=diffninja,tree-sitter,tree-sitter-javascript,tree-sitter-typescript diffninja`.
-
-## Review a pull request
-
-Ask your agent to review `https://github.com/OWNER/REPO/pull/123`. It calls
-`review_diff` with the link, reads the pull request, sends its reading with
-`finish_review`, and then gives you a loopback review page, loaded from the
-canonical GitHub patch through your `gh` authentication. The link arrives
-once the agent has read the change, so the page opens complete: the agent's
-reading order, its answers, and its suggested comments. Select diff lines,
-write single-line inline comments and a review body, pick Comment, Approve, or
-Request changes, preview the exact payload, and submit. Comments your agent
-suggests wait under their lines until you add them; every word you submit is one
-you chose, and diffninja only carries it to GitHub. It never approves, blocks, or merges
-anything on its own. The page belongs to the agent's MCP connection and closes
-when the agent exits.
-
-The diff opens in the **reading order**: each hunk is a numbered change,
-most important first, with your agent's answers (does this change behavior,
-does a test exercise it, does it serve the stated goal) and the facts to look
-at above its code. Hunks outside the order follow under **Other changes**.
-Press `j` and `k` to step through the changes. A rail beside the diff lists
-them, marks the one you are reading, and fills in as you read. **By file**
-switches to one block per file, with each change's number where it starts,
-and keeps you on the change you were reading. When the agent works inside your local
-clone it passes it as `repo`; once the clone has the pull request's commits,
-the analysis adds definitions and call flows, and the page opens a file's call
-flow in a drawer beside the diff. diffninja never fetches or writes in the
-clone; when it lacks the commits, the page says so and names the `git fetch`
-that would add them.
-
-## Review a diff or a git range
+It installs diffninja and adds it to every agent CLI it finds on your machine.
+Then restart your agent CLI.
 
-Ask your agent to review a patch, the working tree, or a range such as
-`main..HEAD` in a repository. It calls `review_diff` with `diff` text or with
-`repo`, `from`, and `to`, and receives the report as the tool result: the exact
-expected outcome when supplied (`expectedOutcome`), a short reading agenda,
-bounded automatic findings, explicit check coverage, and every hunk, ranked as
-**attention**, **uncertain**, **low**, or **passed**; git ranges add call flows
-and snapshot-bound source. Claims in a description are not proof that the code
-fulfills them. Once the agent has sent its reading (below), it gets `reportUrl`:
-a read-only page on `127.0.0.1` with the same report for you to read (the
-agenda, call-flow graphs, and every hunk), served from memory for as long as
-the agent's session lasts.
-The tool writes no report files. Arguments and examples:
-[docs/mcp-setup.md](docs/mcp-setup.md). Trying it on real reviews:
-[docs/pilot.md](docs/pilot.md).
+To update later, run the same command again. To remove diffninja from your
+agent CLIs, run `npx -y diffninja setup --uninstall`. Other options:
+`npx -y diffninja setup --help`.
 
-## How static analysis works
+## How to use it
 
-1. **Evidence first.** No-op hunks and blank-only document changes pass.
-   Repository snapshots support bounded checks for duplicate function bodies and
-   unread `errors` response fields, plus caller and contract source cards.
-   Optional TypeScript reference checking compares before/after diagnostics,
-   including unchanged consumers, using an explicitly trusted installed compiler.
-   Unsupported or incomplete checks say so.
-2. **Change facts per hunk.** The added and removed lines are read lexically —
-   strings and comments set aside, moved lines cancelling out. Code gets six facts:
-   comparison changed, limit changed (a numeric bound, or `<` turned into `<=`),
-   input check changed (type/shape checks, or a changed guard in front of a
-   raise), failure handed to the caller, failure deferred or retried, failure
-   discarded (an empty or defaulting `catch`, `except: pass`, …). Documentation
-   (`.md`, `.rst`, `.txt`, …) is asked whether an instruction to readers changed
-   (must, never, only, at most, …), a link target changed, or a numeric limit
-   changed. Configuration (`.yml`, `.json`, `.toml`, Dockerfiles, `.env`, …) is
-   asked whether a CI gate was weakened (`continue-on-error`, `|| true`, a
-   failure turned into a warning, a check step removed), permissions or secret
-   access changed, a version pin changed, or a limit changed. Each `yes` cites
-   its changed line. `no` speaks only about the lines the hunk shows. A change
-   that only touches formatting, comments, or line breaks is recognized as such.
-   JS/TS, Java, C#, Go, Rust, C/C++, Kotlin, Swift, PHP, Python, Ruby,
-   documentation and configuration are read; any other file type says that no
-   facts were established instead of claiming none.
-3. **Status and order.** A code or configuration change outside a test file
-   reads **attention**; documentation reads **attention** when it changes an
-   instruction, a link, or a limit, **low** otherwise; a test-file change reads
-   **attention** only when it changes a limit, discards a failure, or weakens a
-   gate, **low** otherwise; a formatting-only change **passed**;
-   an unread file type **uncertain**, for a person to read. Priority orders hunks:
-   a fixed base, plus 10 for a real change, plus the heaviest fact of the
-   boundary group (what the change says or bounds) and of the failure group
-   (failures, CI gates, permissions) — each group counts once, never summed. The report lists
-   manual work first (binary and other metadata-only units), then the read hunks
-   by priority, then passes; among equal priorities the hunk that changes more
-   lines comes first. Hunks in test files (by path convention: `test/`,
-   `*.test.ts`, `test_*.py`, `*_test.go`, …, including snapshots diffninja does
-   not read) come after the other hunks, still ordered by their own priority: a
-   regression test changes as much as its fix.
-   Documentation is not demoted, because prose can be normative. Status is a
-   label for filtering and never reorders the report.
-4. **Questions for your agent.** Where a judgment needs meaning rather than
-   syntax, the report asks the agent that requested it — does this hunk change
-   what callers observe, does a test exercise it, does a test change weaken it,
-   do the docs match the code, does the hunk serve the stated goal. Questions
-   are fixed templates with closed options (always including `cannot-tell`).
-   diffninja itself still calls no model.
-   The agent sends its whole reading in one `finish_review` call: an answer to
-   every question, the reading order of every hunk (most important first),
-   and the line comments it would leave (or none). diffninja checks all of it
-   and only then hands out the page link, so every page you open already
-   carries the agent's answers, its order, and its comment decision; an agent
-   cannot give you a half-read page. The pages list every hunk in the agent's
-   order, attributed to it; diffninja's own order stays available one click
-   away, and statuses stay diffninja's. `record_answers`, `record_order`, and
-   `suggest_comments` update a review afterwards. On 159 held-out open-source
-   pull requests, weighted by the severity of maintainers' actual review
-   comments, a host model that read diffninja's report put the serious
-   comments earlier than diffninja's deterministic order did.
-   On a pull request, the suggested line comments are short, in the reviewer's
-   own voice, with no "Finding 1:" scaffolding. The page shows each under its line; you add one
-   or all of them to your draft with a click, edit or dismiss them, and submit
-   the review yourself. Nothing is posted without you.
-5. **Project context (git ranges only).** What a diff does not show is often
-   the project around it. From the local clone alone — nothing is fetched —
-   the report names the commits that last changed each hunk's removed lines
-   (`git blame` at the base), earlier revert commits that touched a changed
-   file or share a rare word with the goal or the changed file names,
-   contributor guidelines that apply (`CONTRIBUTING`, `AGENTS.md`, `.github/`,
-   docs policy pages such as versioning or preview rules), and, for a new
-   file, identifiers most of its same-named siblings use and it does not
-   (`components/*/select.py`). They add questions for your agent: does a hunk
-   undo a fix it removes, does the change reintroduce something reverted, does
-   it follow the guidelines and the sibling pattern. These are pointers, not
-   verdicts, and never change status or order. A shallow clone says so: lines
-   whose origin lies past its boundary count as unknown.
+Inside your agent CLI, ask in plain words:
 
-Intent cross-checks keep author claims and generated summaries separate.
-Source matches are navigation evidence, not proof of fulfillment. Broad goals,
-missing metadata, and behavior not established by the available code remain
-explicitly unestablished. Findings likewise state their scope: duplicated syntax
-is not necessarily duplicated responsibility, and an unread field alone does not
-prove that a real failure was mishandled.
+```text
+Review https://github.com/OWNER/REPO/pull/123 with diffninja
+```
 
-Git-range analysis supplies selected call-site blocks from both snapshots,
-including written arguments, declared parameters, locations, and explicit target
-and binding uncertainty. Unambiguous same-file JS/TS and Python calls support
-positional binding; Python also supports named arguments. Imports, member
-dispatch, dynamic targets, and other grammars do not get guessed mappings.
-These are static source expressions, not runtime values or data-flow analysis.
-TypeScript/TSX extraction includes methods of decorated exported classes,
-including stacked and custom decorators; method source spans retain their
-decorators so decorator-only changes still select the method body. Simple explicit class-field and
-constructor-property types identify candidate dependency methods; unsupported
-receiver types stay unresolved rather than borrowing the containing class's
-method. These are not type-checked or proven runtime bindings.
+The agent reads the PR, then gives you a link to the review page (it runs on
+your machine at `127.0.0.1`). On the page:
+
+1. Start with **Goal**: the reviewing agent's short, plain-English explanation
+   of what the PR is meant to do and its important limits. The full
+   **Original PR description** stays one click away, with Markdown formatting.
+   The goal is stated intent, not proof the code fulfills it.
+   `j` and `k` move to the next and previous change, and the list on the left
+   shows where you are. The agent sets the reading order; the connected page
+   does not label changes “Attention”.
+2. Hover a line and press **+** to write a comment, or add the agent's
+   suggestions.
+3. Write a summary, choose **Comment**, **Approve**, or **Request changes**.
+4. Press **Check the review** to see exactly what will be sent, then
+   **Submit review**.
+
+Tip: if your agent is running inside a local clone of the repository, it can
+pass the clone to diffninja. You then also get call-flow diagrams for the
+changed files.
+
+You can also review changes that aren't a PR yet:
+
+```text
+Review my changes on this branch against main with diffninja
+```
 
-Review context also follows candidate event and queue relations: static
-`emit`/`emitAsync` keys match `@On*Event` handlers; injected queue `.add` keys
-match `@Processor` consumers' `job.name` cases or `@Process` methods only on a
-matching queue channel. String enum values can connect member keys to literal
-cases. These are source-derived relations, not runtime calls or proof of
-delivery; dynamic keys, aliases, and unrecognized framework syntax can be absent.
-Constant resolution is snapshot-local, including when extraction is cached.
+The agent gets a report of every changed piece of code, ranked by importance,
+and gives you a link to read the same report in your browser.
 
-Module-level TypeScript/TSX interfaces, type aliases, and enums are addressable
-non-callable context nodes. Signature, body, and generic type references connect
-them to reviewed methods and other contracts. Relative import bindings take
-precedence; unique module-path suffixes and unimported names are candidate
-matches, not type checking. Unresolved imports do not borrow same-named types.
-Barrel re-exports, nested declarations, and class-field contracts may be absent.
+## Good to know
 
-Context prioritizes calls adjacent to the hunk, with depth limited to four,
-at most eight arguments per call, and 120 characters per argument excerpt.
-Snapshot-bound changed definitions, callers, callees, dispatch endpoints, and
-type contracts carry complete source plus selected relation evidence. Bodies not
-already shown in the hunk take precedence over duplicate source. Unseen type
-declarations and dispatch endpoints precede ordinary caller chains, nearest
-first, with resulting-snapshot evidence ahead of prior-snapshot duplicates.
-Unresolved own-call expressions remain verbatim in a whole source body rather
-than repeating unknown-binding boilerplate. At most eight distinct definition
-nodes are kept per hunk, each carried whole, never shortened.
+- The review page closes when you exit your agent CLI.
+- The page and the agent's session contain source code. Treat them like the
+  code itself.
+- diffninja never approves, blocks, or merges anything on its own.
 
-Automatic response/caller evidence is narrower than the candidate call graph:
-it requires a supported lexical or typed-constructor binding. Relative modules
-and simple single-target `paths` aliases from snapshot-local, standalone JSON
-`tsconfig.json` files are supported. JSONC, inherited configurations, package or
-barrel resolution, and complex receivers remain unproven rather than borrowing
-an unrelated same-named function. `referenceProject: "path/to/tsconfig.json"`
-opts into the separate TypeScript diagnostic comparison; absent dependencies,
-unsupported project layouts, and exceeded bounds are reported as not checked.
+## More
 
-## Good to know
+- [How the analysis works](docs/how-it-works.md): what diffninja checks and
+  how it ranks changes
+- [Manual setup and tool reference](docs/mcp-setup.md): for agent CLIs that
+  `setup` doesn't configure
+- [Releasing](docs/npm-release.md): how new versions are published
 
-- Tool results embed source code, including unchanged code, and stay in your
-  agent's session. Keep transcripts that contain them private.
-- Connected PR reviews need authenticated `gh`. Nothing else leaves your
-  machine: no model is called and no API key is needed.
-
-## Dev
+## Development
 
 ```bash
-npm run build   # tsc -> dist/
-npm run lint    # oxlint
-npm test        # vitest run
+npm install
+npm run build   # compile to dist/
+npm run lint
+npm test
 ```
 
-Run the built server directly with `node dist/review/mcp-cli.js` (it speaks MCP
-over stdio and prints nothing else to stdout).
-
-Releases and the npm publishing setup: [docs/npm-release.md](docs/npm-release.md).
-
 ## Credits
 
 The call-flow engine is a fork of
 [calldiff](https://github.com/tanishqkancharla/calldiff) by Tanishq Kancharla
-(MIT, see LICENSE). diffninja uses its call graphs to show which flows each
-hunk touches.
+(MIT, see LICENSE).

package/dist/review/connected-analysis.d.ts

@@ -11,7 +11,7 @@
  * MCP client that recorded it.
  */
 import { type QuestionKind, type Verdict } from "./questions.js";
-import type { ReviewReport, ReviewStatus, SuggestedComment } from "./types.js";
+import type { AgentSummary, ReviewReport, ReviewStatus, SuggestedComment } from "./types.js";
 /** Most agenda entries the page lists; the full report has the rest. */
 export declare const CONNECTED_AGENDA_LIMIT = 5;
 export interface ConnectedFact {
@@ -70,13 +70,21 @@ export interface ConnectedAnalysis {
         readonly total: number;
         readonly answered: number;
     };
-    /** Line comments the reviewing agent suggested, for the human to add to their review or not. */
     /** Changed files that have call-flow diagrams, for the page's "Call flow" buttons; empty for a patch-only analysis. */
     readonly callFlowFiles: readonly string[];
+    /** Line comments the reviewing agent suggested, for the human to add to their review or not. */
     suggestions?: {
         readonly suggestedBy: string;
         readonly comments: readonly SuggestedComment[];
     };
+    /**
+     * The reviewing agent's own short paragraph on what the pull request does and
+     * why, attributed to the client that wrote it. Absent when no finish_review
+     * accepted one, which the page must say instead of showing a goal of its own:
+     * diffninja generates no summary, and this one is the agent's reading of the
+     * author's stated intent, not a claim that the changes achieve it.
+     */
+    summary?: AgentSummary;
 }
 export type ConnectedOrder = {
     readonly source: "agent";

package/dist/review/connected-analysis.js

@@ -159,5 +159,10 @@ export function connectedAnalysisOf(report, snapshotId, reviewId, reportUrl, sco
     if (report.agentComments !== undefined) {
         analysis.suggestions = { suggestedBy: report.agentComments.suggestedBy, comments: report.agentComments.comments };
     }
+    // Only finish_review stores a summary, so this is present exactly when the
+    // agent's whole reading was accepted for this snapshot's report; it is copied
+    // verbatim, attributed, and never synthesized here.
+    if (report.agentSummary !== undefined)
+        analysis.summary = report.agentSummary;
     return analysis;
 }