dht-rpc 6.25.1 → 6.26.1

package/lib/health.js

@@ -1,6 +1,4 @@
-const MAX_HEALTH_WINDOW = 2
-const RESPONSES_SANITY = 0
-const TIMEOUTS_SANITY = 0
+const MAX_HEALTH_WINDOW = 4
 const TIMEOUTS_THRESHOLD = 0.5
 
 module.exports = class NetworkHealth {
@@ -19,17 +17,31 @@ module.exports = class NetworkHealth {
     return this._window[this._tail]
   }
 
+  get previous() {
+    return this._window[(this._head - 1 + this._maxHealthWindow) % this._maxHealthWindow]
+  }
+
   get newest() {
     return this._window[this._head]
   }
 
+  get recentResponses() {
+    if (!this.newest || !this.previous) return 0
+    return this.newest.responses - this.previous.responses
+  }
+
+  get recentTimeouts() {
+    if (!this.newest || !this.previous) return 0
+    return this.newest.timeouts - this.previous.timeouts
+  }
+
   get responses() {
-    if (!this.newest) return 0
+    if (!this.newest || !this.oldest) return 0
     return this.newest.responses - this.oldest.responses
   }
 
   get timeouts() {
-    if (!this.newest) return 0
+    if (!this.newest || !this.oldest) return 0
     return this.newest.timeouts - this.oldest.timeouts
   }
 
@@ -38,13 +50,20 @@ module.exports = class NetworkHealth {
     return this.timeouts / (this.responses + this.timeouts)
   }
 
+  get idle() {
+    return this.recentResponses === 0 && this.recentTimeouts === 0
+  }
+
   get stats() {
     return {
       online: this.online,
       degraded: this.degraded,
+      idle: this.idle,
       responses: this.responses,
       timeouts: this.timeouts,
-      timeoutsRate: this.timeoutsRate
+      timeoutsRate: this.timeoutsRate,
+      recentResponses: this.recentResponses,
+      recentTimeouts: this.recentTimeouts
     }
   }
 
@@ -52,10 +71,6 @@ module.exports = class NetworkHealth {
     return (this._head + 1) % this._maxHealthWindow
   }
 
-  get cold() {
-    return this._window.length < this._maxHealthWindow
-  }
-
   reset() {
     this._window = []
     this._head = -1
@@ -71,24 +86,10 @@ module.exports = class NetworkHealth {
       timeouts: this._dht.stats.requests.timeouts
     }
 
-    if (this.cold) return
-
-    const responses = this.responses
-    const timeouts = this.timeouts
-    const timeoutsRate = this.timeoutsRate
-
-    if (responses > 0) {
-      this.online = true
-    }
-
-    if (responses > RESPONSES_SANITY * this._window.length) {
-      this.degraded = timeoutsRate > TIMEOUTS_THRESHOLD
-    }
+    if (this.idle) return
 
-    if (responses === 0 && timeouts > TIMEOUTS_SANITY * this._window.length) {
-      this.online = false
-      this.degraded = false
-    }
+    this.online = this.recentResponses > 0
+    this.degraded = this.online && this.timeoutsRate > TIMEOUTS_THRESHOLD
 
     if (this.online && !this.degraded) this._dht._online()
     else if (this.degraded) this._dht._degraded()

package/lib/io.js

@@ -595,7 +595,7 @@ function noop() {}
 function oncycle(req) {
   req._timeout = null
   req.oncycle(req)
-  if (req.sent >= req.retries) {
+  if (req.sent > req.retries) {
     req._io.stats.requests.timeouts++
     req.destroy(REQUEST_TIMEOUT())
     req._io.ontimeout(req)

package/lib/query.js

@@ -27,7 +27,6 @@ module.exports = class Query extends Readable {
     this.map = opts.map || defaultMap
     this.retries =
       opts.retries === 0 ? 0 : opts.retries || (this.internal && command === DOWN_HINT ? 3 : 5)
-    this.maxSlow = opts.maxSlow === 0 ? 0 : opts.maxSlow || 5
     this.closestReplies = []
 
     this._slow = 0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "dht-rpc",
-  "version": "6.25.1",
+  "version": "6.26.1",
   "description": "Make RPC calls over a Kademlia based DHT",
   "main": "index.js",
   "files": [