dflow-sdd-ddd 0.7.0 → 0.8.0

package/templates/greenfield/references/pr-review-checklist.md

@@ -0,0 +1,130 @@
+# PR Review Checklist — Greenfield Clean Architecture
+
+`/dflow:pr-review` enters this checklist starting from **Step 0**. Do not skip Step 0 — reviewing code without first understanding spec intent breaks the SDD feedback loop (all the upstream spec work loses its verification mechanism).
+
+## Step 0: Understand the Change Intent (before code review)
+
+Ground yourself in the spec *before* looking at the diff. A feature
+directory may contain multiple spec files; identify which ones this PR
+touches and read them all.
+
+- [ ] Locate the feature directory at
+      `dflow/specs/features/active/{SPEC-ID}-{slug}/` (or
+      `dflow/specs/features/completed/{SPEC-ID}-{slug}/` if the PR is the
+      closeout commit and the dir was already `git mv`d)
+- [ ] Read `_index.md` first — it gives you the feature-level overview,
+      Current BR Snapshot, list of phase-specs, and Resume Pointer (where the
+      author left off)
+- [ ] Identify which **phase-spec(s)** and / or **lightweight-spec(s)**
+      this PR diff touches. There may be:
+      - A new phase-spec being introduced (T1) — read in full,
+        including Aggregate state transitions and Domain Events
+      - An existing phase-spec being marked `completed` — verify its
+        Delta-from-prior-phases section reads correctly relative to the
+        prior phase
+      - A new lightweight-spec (T2) — read in full
+      - Just T3 inline rows added to `_index.md` Lightweight Changes (no
+        spec file changed) — confirm the row description is precise
+- [ ] If a `Behavior Delta` / Delta-from-prior-phases section exists,
+      read **ADDED / MODIFIED / REMOVED / RENAMED** — pay attention to
+      any Aggregate state transitions and Domain Events listed in the
+      Delta; note any **UNCHANGED** scope declaration
+- [ ] State in one sentence: "This PR intends to {change} because
+      {reason}." (If you can't, pause and ask the author.)
+- [ ] Cross-reference `dflow/specs/domain/{context}/behavior.md` if it exists
+      — confirm the Delta has been reflected or is scheduled to be
+      (draft vs finalized; finalisation usually happens at
+      `/dflow:finish-feature` time)
+- [ ] Only then proceed to the code-review sections below
+
+If the PR has no spec or no `_index.md`:
+```
+"I don't see a feature directory or _index.md for this PR. Before I
+review the code, can you point me to it, or run /dflow:new-feature
+(or /dflow:bug-fix for a small fix) to create the feature directory
+and at least a lightweight spec? SDD relies on the spec being the
+review anchor."
+```
+
+## Spec Compliance
+
+Per-feature checks:
+- [ ] **Feature directory exists** with `_index.md` + at least one
+      phase-spec (or one lightweight-spec for a T2-only feature)
+- [ ] **`_index.md` Current BR Snapshot is up to date** — reflects
+      the cumulative effect of all phase-specs / lightweight-specs in
+      the directory
+- [ ] **`_index.md` Phase Specs table** — every row's referenced
+      phase-spec file exists and its `status` matches the row's claim
+- [ ] **For follow-up features**: `_index.md` Metadata has `follow-up-of:
+      {原 SPEC-ID}` AND the original feature's `_index.md`
+      Follow-up Tracking row references this feature
+
+Per-phase-spec / lightweight-spec checks (run for **each** spec file the
+PR touches, not just one):
+- [ ] Spec matches code
+- [ ] Implementation matches Given/When/Then scenarios (including
+      Aggregate state transitions and Domain Events)
+- [ ] All business rules (BR-*) in this spec implemented
+- [ ] Edge cases (EC-*) in this spec handled
+- [ ] **Delta integrity** (phase 2+ only) — the Delta-from-prior-phases
+      section's ADDED / MODIFIED / REMOVED / RENAMED entries actually
+      match the diff against the prior phase-spec's BR set
+
+If the closeout commit is in this PR (`/dflow:finish-feature` was run):
+- [ ] **BC layer sync landed** — `dflow/specs/domain/{context}/rules.md` /
+      `behavior.md` / `events.md` / `context-map.md` reflect the
+      feature's net effect (compare against `_index.md` Current BR
+      Snapshot)
+- [ ] **Whole feature directory `git mv`'d** to `completed/` — git
+      shows `renamed:` (not `deleted:` + `new file:`)
+- [ ] **Integration Summary** was emitted to the conversation (not
+      written to a file — it's ephemeral)
+
+## Domain Layer Quality
+
+- [ ] **Zero external dependencies** — check the Domain package/module manifest; no external dependencies beyond the language/runtime baseline
+- [ ] **No ORM attributes** — no [Table], [Column], [Key] on domain classes
+- [ ] **No serialization attributes** — no [JsonProperty], [JsonIgnore]
+- [ ] **Private setters** — state changes through methods only
+- [ ] **Invariants enforced** — constructor and methods reject invalid state
+- [ ] **Value Objects immutable** — using `record` or readonly properties
+- [ ] **Domain Events raised** — significant state changes produce events
+- [ ] **Other Aggregates referenced by ID** — not by direct object reference
+
+## Application Layer Quality
+
+- [ ] **No business logic** — handlers only orchestrate, not decide
+- [ ] **CQRS respected** — Commands for writes, Queries for reads
+- [ ] **Validation in Validator** — not in handler or controller
+- [ ] **No Domain objects in DTOs** — proper mapping between layers
+- [ ] **Event handlers are idempotent** — safe to replay
+
+## Infrastructure Layer Quality
+
+- [ ] **EF config in Fluent API** — not attributes on Domain entities
+- [ ] **Repository only for Aggregate Roots** — not for child entities
+- [ ] **No business logic in SQL/LINQ** — complex filtering via Specifications
+- [ ] **External service behind interface** — mockable for tests
+
+## Presentation Layer Quality
+
+- [ ] **Thin controllers** — parse, dispatch, respond
+- [ ] **No domain objects exposed** — only DTOs/ViewModels in API
+- [ ] **Proper status codes** — 201 Created, 404 Not Found, 422 Unprocessable
+- [ ] **No business logic** — not even validation beyond format checking
+
+## Cross-Cutting
+
+- [ ] **Glossary consistency** — new terms documented?
+- [ ] **Context boundaries respected** — no reaching into another context's internals
+- [ ] **Domain Events documented** — events.md updated?
+- [ ] **Tests cover invariants** — not just happy path
+
+## Architecture Score
+
+- **A**: Clean layer separation, Domain-first design, full spec, comprehensive tests
+- **B**: Mostly clean, minor layer bleed, spec exists, good test coverage
+- **C**: Some business logic in wrong layer, spec exists
+- **D**: Working code but architecture concerns, needs refactoring
+- **F**: Business logic in controller/infrastructure, no spec — push back

package/templates/greenfield/scaffolding/AI-AGENT-GUIDE.md

@@ -121,12 +121,39 @@ Recommend `docs/migrating-to-dflow-v1.md` for the manual migration
 checklist. Migration affects every spec the team has written; manual
 review is required.
 
+## Workflow Steps
+
+This guide is the **command registry, routing rules, and project context**.
+Executable workflow steps (Step 1→N, step gates, completion checklists) are
+**not** defined here. They live in the vendored workflow bundle projected into
+this project at:
+
+- `dflow/specs/shared/dflow-workflows/`
+
+When executing a `/dflow:*` command, read the matching flow file from that
+directory first. For example:
+
+| Command | Flow file |
+|---|---|
+| `/dflow:new-feature` | `dflow/specs/shared/dflow-workflows/references/new-feature-flow.md` |
+| `/dflow:modify-existing` | `dflow/specs/shared/dflow-workflows/references/modify-existing-flow.md` |
+| `/dflow:bug-fix` | `dflow/specs/shared/dflow-workflows/references/modify-existing-flow.md` (lightweight-ceremony branch) |
+| `/dflow:new-phase` | `dflow/specs/shared/dflow-workflows/references/new-phase-flow.md` |
+| `/dflow:finish-feature` | `dflow/specs/shared/dflow-workflows/references/finish-feature-flow.md` |
+| `/dflow:verify` | `dflow/specs/shared/dflow-workflows/references/drift-verification.md` |
+| `/dflow:pr-review` | `dflow/specs/shared/dflow-workflows/references/pr-review-checklist.md` |
+| `/dflow:report-dflow-feedback` | `dflow/specs/shared/dflow-workflows/references/dflow-feedback-flow.md` |
+
+Supporting files (templates, domain modeling guide, drift checklist) are also
+in `dflow/specs/shared/dflow-workflows/` under the same relative paths used
+by the flow files.
+
 ## Tool-Specific Notes
 
-This file is the canonical Dflow guide. Root-level files such as
-`AGENTS.md`, `CLAUDE.md`, and `.github/copilot-instructions.md`
+This file is the canonical Dflow guide (registry + rules + router). Root-level
+files such as `AGENTS.md`, `CLAUDE.md`, and `.github/copilot-instructions.md`
 should stay thin and point back here.
 
 If a tool does not support Dflow slash commands, treat the command names as
-plain workflow names. This guide contains the installed runtime behavior
-contract; execute the workflow semantics defined here directly.
+plain workflow names and follow the matching flow file from the workflow bundle
+at `dflow/specs/shared/dflow-workflows/`.

package/templates/greenfield/scaffolding/CLAUDE-md-snippet.md

@@ -1,14 +1,16 @@
-<!-- Scaffolding template maintained alongside Dflow skill. See archive/proposals/PROPOSAL-010 for origin. -->
+<!-- Seeded by Dflow. -->
 
 # CLAUDE.md Snippet — Dflow Adoption (Greenfield track)
 
 > Source: `scaffolding/CLAUDE-md-snippet.md`
 > Purpose: a minimal block you paste into (or replace with) your
 > project's root `CLAUDE.md` when adopting Dflow.
-> For the Greenfield track, the full reference template lives at
-> `sdd-ddd-greenfield-skill/templates/CLAUDE.md` — if you want the complete
-> legacy Claude-specific version, use that instead. New CLI init output uses
-> `AI-AGENT-GUIDE.md` plus a generated `CLAUDE.md` shim.
+> For the Greenfield track, the full reference template lives in the
+> in-project bundle at
+> `dflow/specs/shared/dflow-workflows/templates/CLAUDE.md` (projected by
+> `dflow init`) — if you want the complete legacy Claude-specific version,
+> use that instead. New CLI init output uses `AI-AGENT-GUIDE.md` plus a
+> generated `CLAUDE.md` shim.
 
 ---
 
@@ -91,14 +93,14 @@ dflow/specs/
 
 > SDD 流程、Git 整合、Domain 層規範、AI 協作
 
-### Dflow Skill — Canonical Decision Logic Lives in the Skill
+### Dflow Skill — Canonical Decision Logic Lives in the Project
 
 AI 的完整決策樹、Workflow Transparency、Ceremony Scaling 三層判準
 （T1 Heavy / T2 Light / T3 Trivial）、所有 slash command 的 step-by-step
-流程 **不在此重述**，請以 Dflow skill 本體為準：
+流程 **不在此重述**，請以本專案內的 Dflow 工件為準（init 時投影）：
 
-- `sdd-ddd-greenfield-skill/SKILL.md`（決策樹 + Slash Commands 總表）
-- `sdd-ddd-greenfield-skill/references/` 內各 flow 文件
+- `dflow/specs/shared/AI-AGENT-GUIDE.md`（決策樹 + Slash Commands 總表 + 路由規則）
+- `dflow/specs/shared/dflow-workflows/references/` 內各 flow 文件（執行步驟定義）
 
 本專案採用的 Dflow entry points：
 - Dflow CLI init command (`dflow init`, or `npx dflow-sdd-ddd init` when using the no-install path) — 專案初始化（一次性，已執行過）
@@ -159,10 +161,10 @@ AI 的完整決策樹、Workflow Transparency、Ceremony Scaling 三層判準
 
 ## Notes
 
-- This snippet is intentionally lighter than
-  `sdd-ddd-greenfield-skill/templates/CLAUDE.md`. If you want the full version
-  (with detailed flow descriptions per slash command), use that
-  template instead
+- This snippet is intentionally lighter than the in-project bundle
+  template at `dflow/specs/shared/dflow-workflows/templates/CLAUDE.md`. If
+  you want the full version (with detailed flow descriptions per slash
+  command), use that template instead
 - The snippet does NOT re-copy the Dflow decision tree, Ceremony
   Scaling criteria, or per-flow step details — those live in the
   skill and change when the skill evolves

package/templates/greenfield/scaffolding/Git-principles-gitflow.md

@@ -1,4 +1,4 @@
-<!-- Scaffolding template maintained alongside Dflow skill. See archive/proposals/PROPOSAL-010 for origin. -->
+<!-- Seeded by Dflow. -->
 
 # Git Principles — Git Flow edition
 

package/templates/greenfield/scaffolding/Git-principles-trunk.md

@@ -1,4 +1,4 @@
-<!-- Scaffolding template maintained alongside Dflow skill. See archive/proposals/PROPOSAL-010 for origin. -->
+<!-- Seeded by Dflow. -->
 
 # Git Principles — Trunk-based / GitHub Flow edition
 

package/templates/greenfield/scaffolding/_conventions.md

@@ -1,4 +1,4 @@
-<!-- Scaffolding template maintained alongside Dflow skill. See archive/proposals/PROPOSAL-010 for origin. -->
+<!-- Seeded by Dflow. -->
 
 # Spec Writing Conventions — {System Name}
 

package/templates/greenfield/scaffolding/_overview.md

@@ -1,4 +1,4 @@
-<!-- Scaffolding template maintained alongside Dflow skill. See archive/proposals/PROPOSAL-010 for origin. -->
+<!-- Seeded by Dflow. -->
 
 # System Overview — {System Name}
 
@@ -179,5 +179,7 @@ Initial ADRs that typically exist:
 - [Glossary](../domain/glossary.md)
 - [Tech debt backlog](../architecture/tech-debt.md)
 - [Architecture decisions](../architecture/decisions/)
-- Dflow skill: see `CLAUDE.md` and the `sdd-ddd-greenfield-skill/` bundle
-  for the full AI workflow guidance.
+- Dflow workflow guidance: see `CLAUDE.md` (project-level AI rules) and the
+  in-project vendored bundle at `dflow/specs/shared/AI-AGENT-GUIDE.md` +
+  `dflow/specs/shared/dflow-workflows/references/` for the full AI workflow
+  decision tree, slash commands, and step-by-step flow definitions.

package/templates/greenfield/scaffolding/architecture-decisions-README.md

@@ -1,4 +1,4 @@
-<!-- Template maintained by Dflow. See archive/proposals/PROPOSAL-013 for origin. -->
+<!-- Seeded by Dflow. -->
 
 # Architecture Decisions
 

package/templates/greenfield/templates/context-map.md

@@ -1,4 +1,4 @@
-<!-- Template maintained by Dflow. See archive/proposals/PROPOSAL-013 for origin. -->
+<!-- Seeded by Dflow. -->
 
 # Context Map
 

package/templates/greenfield/templates/events.md

@@ -1,4 +1,4 @@
-<!-- Template maintained by Dflow. See archive/proposals/PROPOSAL-013 for origin. -->
+<!-- Seeded by Dflow. -->
 
 # Domain Events
 

package/templates/greenfield/templates/glossary.md

@@ -1,4 +1,4 @@
-<!-- Template maintained by Dflow. See archive/proposals/PROPOSAL-013 for origin. -->
+<!-- Seeded by Dflow. -->
 
 # Glossary
 

package/templates/greenfield/templates/models.md

@@ -1,4 +1,4 @@
-<!-- Template maintained by Dflow. See archive/proposals/PROPOSAL-013 for origin. -->
+<!-- Seeded by Dflow. -->
 
 # Domain Models
 

package/templates/greenfield/templates/rules.md

@@ -1,4 +1,4 @@
-<!-- Template maintained by Dflow. See archive/proposals/PROPOSAL-013 for origin. -->
+<!-- Seeded by Dflow. -->
 
 # Business Rules
 

package/templates/greenfield/templates/tech-debt.md

@@ -1,4 +1,4 @@
-<!-- Template maintained by Dflow. See archive/proposals/PROPOSAL-013 for origin. -->
+<!-- Seeded by Dflow. -->
 
 # Architecture Tech Debt