dexbot 1.6.4 → 1.6.6

package/dist/modules/order/grid.js

@@ -12,63 +12,58 @@
  * - Detects and flags out-of-spread conditions
  *
  * ===============================================================================
- * TABLE OF CONTENTS - Grid Functions (27 exported functions)
+ * TABLE OF CONTENTS - Grid Functions (22 exported functions)
  * ===============================================================================
  *
- * CONFIGURATION & CALCULATION (1 method)
- *   1. calculateGapSlots(incrementPercent, targetSpreadPercent) - Calculate spread gap size
+ * CONFIGURATION & CALCULATION (2 functions)
+ *   1. resolveRmsThresholdPct(manager) - Resolve the structural-divergence threshold
+ *   2. calculateGapSlots(incrementPercent, targetSpreadPercent) - Calculate spread gap size
  *
- * GRID SIZING & CONTEXT (1 method)
- *   3. _getSizingContext(manager, side) - Get budget and sizing parameters (internal)
- *      Determines budget from allocated funds, deducts BTS fees if needed
+ * GRID SIZING & CONTEXT (1 function)
+ *   3. _getSizingContext(manager, side, options) - Get budget and sizing parameters
+ *      Determines budget from allocated funds and optionally deducts BTS fees
  *
- * GRID CREATION (1 method)
+ * GRID CREATION (1 function)
  *   4. createOrderGrid(config) - Create geometric price grid
  *      Returns price levels from minPrice to maxPrice with increment spacing
  *
- * ORDER CACHE MANAGEMENT (1 method - internal)
- *   5. _clearOrderCachesLogic(manager) - Clear order caches (_ordersByType, _ordersByState)
+ * GRID LOADING & INITIALIZATION (2 functions - async)
+ *   5. loadGrid(manager, grid, boundaryIdx, genesisInput, options) - Load grid into manager orders
+ *   6. initializeGrid(manager) - Full grid initialization from config
  *
- * GRID LOADING & INITIALIZATION (2 methods - async)
- *   6. loadGrid(manager, grid, boundaryIdx) - Load grid into manager orders
- *   7. initializeGrid(manager) - Full grid initialization from config
+ * GRID RECALCULATION (1 function - async)
+ *   7. recalculateGrid(manager, opts) - Recalculate grid based on current state
  *
- * GRID RECALCULATION (1 method - async)
- *   8. recalculateGrid(manager, opts) - Recalculate grid based on current state
+ * GRID STATE CHECKING (1 function)
+ *   8. checkAndUpdateGridIfNeeded(manager) - Check if grid needs update
  *
- * GRID STATE CHECKING (1 method)
- *   9. checkAndUpdateGridIfNeeded(manager) - Check if grid needs update
+ * BLOCKCHAIN SYNCHRONIZATION (2 functions - async)
+ *   9. _recalculateGridOrderSizesFromBlockchain(manager, orderType, options) - Recalculate sizes from blockchain
+ *   10. updateGridFromBlockchainSnapshot(manager, orderType, fromBlockchainTimer, overrideBoundaryIdx) - Update grid from blockchain
  *
- * BLOCKCHAIN SYNCHRONIZATION (2 methods - async)
- *   10. _recalculateGridOrderSizesFromBlockchain(manager, orderType) - Recalculate sizes from blockchain
- *   11. updateGridFromBlockchainSnapshot(manager, orderType, fromBlockchainTimer) - Update grid from blockchain
- *
- * GRID COMPARISON (2 methods - async)
- *   12. compareGrids(calculatedGrid, persistedGrid, manager) - Compare two grids
+ * GRID COMPARISON (2 functions - async)
+ *   11. compareGrids(calculatedGrid, persistedGrid, manager) - Compare two grids
  *       Validates grid structure and reports divergence metrics
- *   13. monitorDivergence(manager, calculatedGrid, persistedGrid) - Unified divergence check
+ *   12. monitorDivergence(manager, calculatedGrid, persistedGrid) - Unified divergence check
  *       Runs ratio-based + RMS-based checks and returns combined result
  *
- * ON-CHAIN ORDER FETCHING (1 method - async)
- *   14. _getOnChainOrders(manager) - Collect on-chain buy/sell orders from manager
- *
- * SPREAD MANAGEMENT (2 methods - async)
- *   15. calculateCurrentSpread(manager) - Calculate current bid-ask spread
- *   16. checkSpreadCondition(manager, BitShares, updateOrdersOnChainBatch) - Check and flag spread condition
+ * SPREAD MANAGEMENT (2 functions)
+ *   13. calculateCurrentSpread(manager) - Calculate current bid-ask spread
+ *   14. checkSpreadCondition(manager, BitShares, updateOrdersOnChainBatch) - Check and flag spread condition
  *
- * GRID HEALTH MONITORING (6 methods)
- *   17. checkGridHealth(manager, updateOrdersOnChainBatch) - Monitor grid health (async)
- *   18. checkWindowDust(manager) - Dust check scoped to the active buy/sell window (async)
- *   19. _hasAnyDust(manager, partials, type) - Check for dust orders (internal)
- *   20. hasAnyDust(manager, partials, side) - Check for dust orders (public)
- *   21. getDustOrders(manager, partials, side) - Get all dust order IDs (public)
- *   22. determineOrderSideByFunds(manager, currentMarketPrice) - Determine priority side
+ * GRID HEALTH MONITORING (4 functions)
+ *   15. checkGridHealth(manager, updateOrdersOnChainBatch) - Monitor grid health
+ *   16. checkWindowDust(manager) - Dust check scoped to the active buy/sell window
+ *   17. hasAnyDust(manager, partials, side) - Check for dust orders
+ *   18. getDustOrders(manager, partials, side) - Get dust order IDs
  *
- * SPREAD CORRECTION (1 method)
- *   23. prepareSpreadCorrectionOrders(manager, preferredSide) - Prepare correction orders
+ * SIDE SELECTION (1 function)
+ *   19. determineOrderSideByFunds(manager, currentMarketPrice) - Determine priority side
  *
- * DUST DETECTION (1 method - internal)
- *   25. _getDustOrders(manager, partials, type) - Internal dust detection helper
+ * BLOAT STATUS (3 functions)
+ *   20. isGridBloated(manager, orders) - Check whether the grid is bloated
+ *   21. isGridBloatGraceActive(manager) - Check the bloat grace state
+ *   22. clearGridBloatFlag(manager) - Clear the bloat state
  *
  * ===============================================================================
  *
@@ -95,13 +90,24 @@
 import { createRequire } from 'node:module';
 const require = createRequire(import.meta.url);
 import { ORDER_TYPES, ORDER_STATES, COW_ACTIONS, DEFAULT_CONFIG, GRID_LIMITS, TIMING, PIPELINE_TIMING, MARKET_ADAPTER, INCREMENT_BOUNDS } from '../constants.js';
-const { GRID_COMPARISON } = GRID_LIMITS;
 import * as Format from './format.js';
 import { resolveMaxAsymmetryFactor, applyAsymmetricBounds, applyNarrowingSideGuard, } from '../../market_adapter/core/asymmetric_bounds.js';
 // FIX: Extract magic numbers to named constants for maintainability
 const GRID_CONSTANTS = {
     RMS_PERCENTAGE_SCALE: 100, // Convert RMS percentage threshold from percent to decimal
 };
+/**
+ * Central resolution for the RMS structural-divergence threshold (percent).
+ * Single source of truth: per-bot override wins, global GRID_COMPARISON default
+ * is the fallback. Used by compareGrids() and re-exported for the maintenance
+ * runtime so the reset log always shows the level that actually fired.
+ * @param {any} manager - OrderManager instance (may be null)
+ * @returns {number} Threshold in percent (0 = disabled)
+ */
+export function resolveRmsThresholdPct(manager) {
+    return manager?.config?.gridLimits?.GRID_COMPARISON?.RMS_PERCENTAGE
+        ?? GRID_LIMITS.GRID_COMPARISON.RMS_PERCENTAGE;
+}
 function _snapshotFundState(manager) {
     return {
         buyFree: Number(manager.accountTotals?.buyFree || 0),
@@ -114,7 +120,7 @@ import { floatToBlockchainInt, getPrecisionByOrderType, getPrecisionsForManager,
 import { filterOrdersByType, checkSizesBeforeMinimum, checkSizeThreshold, resolveConfiguredPriceBound, shouldFlagOutOfSpread, isOrderHealthy, isPhantomOrder, isSlotAvailable, isOrderOnChain, isOrderPlaced, hasOnChainId, isEmptyGridSlot, parseSlotIndex, calculateIdealBoundary, assignGridRoles, resolveOnChainRetypeType, resolveReserveCount, reserveEdgeIdSet, resolveLiveReserveEdgeAnchorPrice } from './utils/order.js';
 import { loadAmaCenterPrice, loadAmaCenterSnapshot, withBlockchainRetry } from './utils/system.js';
 import * as MathUtils from './utils/math.js';
-import { derivePriceWithPoolRef } from './utils/withPoolRef.js';
+import { derivePriceWithPoolRef, resolveStartPriceMode } from './utils/withPoolRef.js';
 import { getWhitelistFlags } from '../market_adapter_whitelist.js';
 import { getErrorMessage } from '../utils/errors.js';
 const calculateGapSlots = _mathGapSlots;
@@ -943,9 +949,14 @@ export async function initializeGrid(manager) {
     if (typeof mpRaw !== 'number' || isNaN(mpRaw)) {
         try {
             const { BitShares } = require('../bitshares_client');
-            const derived = await derivePriceWithPoolRef(BitShares, manager.config.assetA, manager.config.assetB, manager.config.priceMode || 'auto', manager.config.poolRef);
+            // startPrice is the master price source: pass its own mode so a
+            // pinned poolRef only refines pool discovery. Without this,
+            // the old `priceMode || 'auto'` read (priceMode is never set in
+            // the runtime path) let a poolRef override startPrice:"book".
+            const startPriceMode = resolveStartPriceMode(mpRaw, manager.config.priceMode || 'auto');
+            const derived = await derivePriceWithPoolRef(BitShares, manager.config.assetA, manager.config.assetB, startPriceMode, manager.config.poolRef);
             if (derived) {
-                manager.logger?.log?.(`[DIAGNOSTIC] initializeGrid: Derived new startPrice=${derived.toFixed(8)} (mode=${manager.config.priceMode || 'auto'})`, 'info');
+                manager.logger?.log?.(`[DIAGNOSTIC] initializeGrid: Derived new startPrice=${derived.toFixed(8)} (mode=${startPriceMode})`, 'info');
                 manager.config.startPrice = Number(derived);
             }
             else {
@@ -1884,8 +1895,9 @@ export async function compareGrids(calculatedGrid, persistedGrid, manager = null
     // Check if metrics exceed threshold and flag sides for regeneration
     // Set RMS_PERCENTAGE to 0 to disable RMS divergence checks
     let buyUpdated = false, sellUpdated = false;
-    if (manager && (manager.config?.gridLimits?.GRID_COMPARISON?.RMS_PERCENTAGE ?? GRID_COMPARISON.RMS_PERCENTAGE) > 0) {
-        const limit = (manager.config?.gridLimits?.GRID_COMPARISON?.RMS_PERCENTAGE ?? GRID_COMPARISON.RMS_PERCENTAGE) / GRID_CONSTANTS.RMS_PERCENTAGE_SCALE;
+    const rmsThresholdPct = resolveRmsThresholdPct(manager);
+    if (manager && rmsThresholdPct > 0) {
+        const limit = rmsThresholdPct / GRID_CONSTANTS.RMS_PERCENTAGE_SCALE;
         if (buyMetric > limit) {
             // RC-3: Use Set for automatic duplicate prevention
             if (!(manager._gridSidesUpdated instanceof Set))
@@ -1900,11 +1912,16 @@ export async function compareGrids(calculatedGrid, persistedGrid, manager = null
             manager._gridSidesUpdated.add(ORDER_TYPES.SELL);
             sellUpdated = true;
         }
+        manager.logger?.log?.(`[RMS] BUY check: metric=${Format.formatPercent(buyMetric * 100, 2)}% (threshold=${rmsThresholdPct}%) → ${buyUpdated ? 'TRIGGER-RESYNC' : 'no trigger'} | SELL check: metric=${Format.formatPercent(sellMetric * 100, 2)}% (threshold=${rmsThresholdPct}%) → ${sellUpdated ? 'TRIGGER-RESYNC' : 'no trigger'}`, 'debug');
+    }
+    else if (manager) {
+        manager.logger?.log?.(`[RMS] checks disabled (threshold=${rmsThresholdPct}%) — buy=${Format.formatPercent(buyMetric * 100, 2)}%, sell=${Format.formatPercent(sellMetric * 100, 2)}%`, 'debug');
     }
     return {
         buy: { metric: buyMetric, updated: buyUpdated },
         sell: { metric: sellMetric, updated: sellUpdated },
-        totalMetric: (buyMetric + sellMetric) / 2
+        totalMetric: (buyMetric + sellMetric) / 2,
+        thresholdPct: rmsThresholdPct
     };
 }
 /**
@@ -1937,7 +1954,8 @@ export async function monitorDivergence(manager, calculatedGrid, persistedGrid)
         needsUpdate: buyUpdated || sellUpdated,
         buy: { updated: buyUpdated, ratio: ratioResult.buyUpdated, rms: rmsResult.buy.updated, metric: rmsResult.buy.metric, shrink: ratioResult.buyShrink === true },
         sell: { updated: sellUpdated, ratio: ratioResult.sellUpdated, rms: rmsResult.sell.updated, metric: rmsResult.sell.metric, shrink: ratioResult.sellShrink === true },
-        orderType: getOrderTypeFromUpdatedFlags(buyUpdated, sellUpdated)
+        orderType: getOrderTypeFromUpdatedFlags(buyUpdated, sellUpdated),
+        thresholdPct: rmsResult.thresholdPct
     };
 }
 /**