devrites 7.1.1 → 7.2.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +13 -0
- package/README.md +9 -4
- package/docs/dsh.md +46 -0
- package/engine/internal/devritespaths/paths.go +2 -0
- package/engine/internal/hostpack/hostpack.go +29 -5
- package/engine/internal/install/apply.go +14 -2
- package/engine/internal/install/install.go +7 -3
- package/engine/internal/install/merge.go +1 -0
- package/engine/internal/install/preflight.go +9 -2
- package/engine/internal/install/update.go +1 -1
- package/engine/internal/lib/dispatch_packet.go +1 -1
- package/pack/.claude/agents/devrites-upgrade-planner.md +12 -4
- package/pack/.claude/skills/devrites-debug-recovery/SKILL.md +21 -4
- package/pack/.claude/skills/devrites-debug-recovery/reference/cleanup-and-classify.md +10 -3
- package/pack/.claude/skills/devrites-debug-recovery/reference/regression-test.md +7 -4
- package/pack/.claude/skills/devrites-lib/reference/reply-contract.md +11 -11
- package/pack/.claude/skills/devrites-lib/reference/standards/afk-hitl.md +52 -56
- package/pack/.claude/skills/devrites-lib/reference/standards/agents.md +11 -1
- package/pack/.claude/skills/devrites-lib/reference/standards/core.md +41 -40
- package/pack/.claude/skills/rite-autocomplete/SKILL.md +12 -14
- package/pack/.claude/skills/rite-autocomplete/reference/loop.md +34 -38
- package/pack/.claude/skills/rite-autocomplete/reference/stop-conditions.md +38 -39
- package/pack/.claude/skills/rite-define/SKILL.md +28 -27
- package/pack/.claude/skills/rite-plan/SKILL.md +7 -2
- package/pack/.claude/skills/rite-plan/reference/replan-and-repair.md +5 -2
- package/pack/.claude/skills/rite-resolve/SKILL.md +17 -10
- package/pack/.claude/skills/rite-resolve/reference/answer-protocol.md +18 -6
- package/pack/.claude/skills/rite-review/SKILL.md +4 -4
- package/pack/.claude/skills/rite-review/reference/security-review.md +4 -2
- package/pack/.claude/skills/rite-seal/SKILL.md +28 -33
- package/pack/.claude/skills/rite-ship/SKILL.md +14 -7
- package/pack/.claude/skills/rite-temper/SKILL.md +18 -18
- package/pack/.claude/skills/rite-temper/reference/scope-modes.md +6 -7
- package/pack/.claude/skills/rite-upgrade/SKILL.md +7 -2
- package/pack/.claude/skills/rite-vet/SKILL.md +33 -34
- package/pack/generated/README.md +3 -1
- package/pack/generated/claude/agents/devrites-upgrade-planner.md +12 -4
- package/pack/generated/claude/skills/devrites-debug-recovery/SKILL.md +21 -4
- package/pack/generated/claude/skills/devrites-debug-recovery/reference/cleanup-and-classify.md +10 -3
- package/pack/generated/claude/skills/devrites-debug-recovery/reference/regression-test.md +7 -4
- package/pack/generated/claude/skills/devrites-lib/reference/reply-contract.md +11 -11
- package/pack/generated/claude/skills/devrites-lib/reference/standards/afk-hitl.md +52 -56
- package/pack/generated/claude/skills/devrites-lib/reference/standards/agents.md +11 -1
- package/pack/generated/claude/skills/devrites-lib/reference/standards/core.md +41 -40
- package/pack/generated/claude/skills/rite-autocomplete/SKILL.md +12 -14
- package/pack/generated/claude/skills/rite-autocomplete/reference/loop.md +34 -38
- package/pack/generated/claude/skills/rite-autocomplete/reference/stop-conditions.md +38 -39
- package/pack/generated/claude/skills/rite-define/SKILL.md +28 -27
- package/pack/generated/claude/skills/rite-plan/SKILL.md +7 -2
- package/pack/generated/claude/skills/rite-plan/reference/replan-and-repair.md +5 -2
- package/pack/generated/claude/skills/rite-resolve/SKILL.md +17 -10
- package/pack/generated/claude/skills/rite-resolve/reference/answer-protocol.md +18 -6
- package/pack/generated/claude/skills/rite-review/SKILL.md +4 -4
- package/pack/generated/claude/skills/rite-review/reference/security-review.md +4 -2
- package/pack/generated/claude/skills/rite-seal/SKILL.md +28 -33
- package/pack/generated/claude/skills/rite-ship/SKILL.md +14 -7
- package/pack/generated/claude/skills/rite-temper/SKILL.md +18 -18
- package/pack/generated/claude/skills/rite-temper/reference/scope-modes.md +6 -7
- package/pack/generated/claude/skills/rite-upgrade/SKILL.md +7 -2
- package/pack/generated/claude/skills/rite-vet/SKILL.md +33 -34
- package/pack/generated/codex/agents/devrites-upgrade-planner.toml +12 -4
- package/pack/generated/codex/skills/devrites-debug-recovery/SKILL.md +21 -4
- package/pack/generated/codex/skills/devrites-debug-recovery/reference/cleanup-and-classify.md +10 -3
- package/pack/generated/codex/skills/devrites-debug-recovery/reference/regression-test.md +7 -4
- package/pack/generated/codex/skills/devrites-lib/reference/reply-contract.md +11 -11
- package/pack/generated/codex/skills/devrites-lib/reference/standards/afk-hitl.md +52 -56
- package/pack/generated/codex/skills/devrites-lib/reference/standards/agents.md +11 -1
- package/pack/generated/codex/skills/devrites-lib/reference/standards/core.md +41 -40
- package/pack/generated/codex/skills/rite-autocomplete/SKILL.md +12 -14
- package/pack/generated/codex/skills/rite-autocomplete/reference/loop.md +34 -38
- package/pack/generated/codex/skills/rite-autocomplete/reference/stop-conditions.md +38 -39
- package/pack/generated/codex/skills/rite-define/SKILL.md +28 -27
- package/pack/generated/codex/skills/rite-plan/SKILL.md +7 -2
- package/pack/generated/codex/skills/rite-plan/reference/replan-and-repair.md +5 -2
- package/pack/generated/codex/skills/rite-resolve/SKILL.md +17 -10
- package/pack/generated/codex/skills/rite-resolve/reference/answer-protocol.md +18 -6
- package/pack/generated/codex/skills/rite-review/SKILL.md +4 -4
- package/pack/generated/codex/skills/rite-review/reference/security-review.md +4 -2
- package/pack/generated/codex/skills/rite-seal/SKILL.md +28 -33
- package/pack/generated/codex/skills/rite-ship/SKILL.md +14 -7
- package/pack/generated/codex/skills/rite-temper/SKILL.md +18 -18
- package/pack/generated/codex/skills/rite-temper/reference/scope-modes.md +6 -7
- package/pack/generated/codex/skills/rite-upgrade/SKILL.md +7 -2
- package/pack/generated/codex/skills/rite-vet/SKILL.md +33 -34
- package/pack/generated/devin/agents/devrites-upgrade-planner.md +12 -4
- package/pack/generated/devin/skills/devrites-debug-recovery/SKILL.md +21 -4
- package/pack/generated/devin/skills/devrites-debug-recovery/reference/cleanup-and-classify.md +10 -3
- package/pack/generated/devin/skills/devrites-debug-recovery/reference/regression-test.md +7 -4
- package/pack/generated/devin/skills/devrites-lib/reference/reply-contract.md +11 -11
- package/pack/generated/devin/skills/devrites-lib/reference/standards/afk-hitl.md +52 -56
- package/pack/generated/devin/skills/devrites-lib/reference/standards/agents.md +11 -1
- package/pack/generated/devin/skills/devrites-lib/reference/standards/core.md +41 -40
- package/pack/generated/devin/skills/rite-autocomplete/SKILL.md +12 -14
- package/pack/generated/devin/skills/rite-autocomplete/reference/loop.md +34 -38
- package/pack/generated/devin/skills/rite-autocomplete/reference/stop-conditions.md +38 -39
- package/pack/generated/devin/skills/rite-define/SKILL.md +28 -27
- package/pack/generated/devin/skills/rite-plan/SKILL.md +7 -2
- package/pack/generated/devin/skills/rite-plan/reference/replan-and-repair.md +5 -2
- package/pack/generated/devin/skills/rite-resolve/SKILL.md +17 -10
- package/pack/generated/devin/skills/rite-resolve/reference/answer-protocol.md +18 -6
- package/pack/generated/devin/skills/rite-review/SKILL.md +4 -4
- package/pack/generated/devin/skills/rite-review/reference/security-review.md +4 -2
- package/pack/generated/devin/skills/rite-seal/SKILL.md +28 -33
- package/pack/generated/devin/skills/rite-ship/SKILL.md +14 -7
- package/pack/generated/devin/skills/rite-temper/SKILL.md +18 -18
- package/pack/generated/devin/skills/rite-temper/reference/scope-modes.md +6 -7
- package/pack/generated/devin/skills/rite-upgrade/SKILL.md +7 -2
- package/pack/generated/devin/skills/rite-vet/SKILL.md +33 -34
- package/pack/generated/dsh/AGENTS.md +20 -0
- package/pack/generated/dsh/agents/devrites-code-reviewer.md +180 -0
- package/pack/generated/dsh/agents/devrites-devex-reviewer.md +137 -0
- package/pack/generated/dsh/agents/devrites-doubt-reviewer.md +100 -0
- package/pack/generated/dsh/agents/devrites-evidence-scout.md +93 -0
- package/pack/generated/dsh/agents/devrites-frontend-reviewer.md +139 -0
- package/pack/generated/dsh/agents/devrites-performance-reviewer.md +142 -0
- package/pack/generated/dsh/agents/devrites-plan-drafter.md +113 -0
- package/pack/generated/dsh/agents/devrites-plan-reviewer.md +167 -0
- package/pack/generated/dsh/agents/devrites-proof-runner.md +101 -0
- package/pack/generated/dsh/agents/devrites-retrospector.md +82 -0
- package/pack/generated/dsh/agents/devrites-security-auditor.md +146 -0
- package/pack/generated/dsh/agents/devrites-simplifier-reviewer.md +113 -0
- package/pack/generated/dsh/agents/devrites-slice-wright.md +240 -0
- package/pack/generated/dsh/agents/devrites-spec-reviewer.md +105 -0
- package/pack/generated/dsh/agents/devrites-strategy-reviewer.md +109 -0
- package/pack/generated/dsh/agents/devrites-test-analyst.md +110 -0
- package/pack/generated/dsh/agents/devrites-upgrade-planner.md +107 -0
- package/pack/generated/dsh/agents/fast-builder.md +92 -0
- package/pack/generated/dsh/agents/fast-checker.md +61 -0
- package/pack/generated/dsh/agents/fast-critic.md +71 -0
- package/pack/generated/dsh/agents/fast-planner.md +95 -0
- package/pack/generated/dsh/agents/overhaul-backend-engineer.md +70 -0
- package/pack/generated/dsh/agents/overhaul-boundary.md +64 -0
- package/pack/generated/dsh/agents/overhaul-craft.md +85 -0
- package/pack/generated/dsh/agents/overhaul-frontend-engineer.md +73 -0
- package/pack/generated/dsh/agents/overhaul-implementer.md +72 -0
- package/pack/generated/dsh/agents/overhaul-recon.md +77 -0
- package/pack/generated/dsh/agents/overhaul-specialist.md +67 -0
- package/pack/generated/dsh/agents/overhaul-verifier.md +73 -0
- package/pack/generated/dsh/runtime/cordis.patch.yml +1450 -0
- package/pack/generated/dsh/runtime/specialist.mjs +62 -0
- package/pack/generated/dsh/skills/devrites-api-interface/SKILL.md +65 -0
- package/pack/generated/dsh/skills/devrites-audit/SKILL.md +60 -0
- package/pack/generated/dsh/skills/devrites-browser-proof/SKILL.md +109 -0
- package/pack/generated/dsh/skills/devrites-browser-proof/reference/browser-performance.md +19 -0
- package/pack/generated/dsh/skills/devrites-browser-proof/reference/visual-verdict.md +38 -0
- package/pack/generated/dsh/skills/devrites-debug-recovery/SKILL.md +119 -0
- package/pack/generated/dsh/skills/devrites-debug-recovery/reference/build-the-loop.md +58 -0
- package/pack/generated/dsh/skills/devrites-debug-recovery/reference/cleanup-and-classify.md +41 -0
- package/pack/generated/dsh/skills/devrites-debug-recovery/reference/hypotheses.md +23 -0
- package/pack/generated/dsh/skills/devrites-debug-recovery/reference/instrumentation.md +21 -0
- package/pack/generated/dsh/skills/devrites-debug-recovery/reference/regression-test.md +33 -0
- package/pack/generated/dsh/skills/devrites-debug-recovery/reference/trace.md +25 -0
- package/pack/generated/dsh/skills/devrites-doubt/SKILL.md +83 -0
- package/pack/generated/dsh/skills/devrites-frontend-craft/SKILL.md +89 -0
- package/pack/generated/dsh/skills/devrites-frontend-craft/reference/craft.md +63 -0
- package/pack/generated/dsh/skills/devrites-frontend-craft/reference/design-references.md +120 -0
- package/pack/generated/dsh/skills/devrites-frontend-craft/reference/fullstack.md +46 -0
- package/pack/generated/dsh/skills/devrites-frontend-craft/reference/quality-standards.md +286 -0
- package/pack/generated/dsh/skills/devrites-frontend-craft/reference/reuse-first.md +53 -0
- package/pack/generated/dsh/skills/devrites-frontend-craft/reference/shape.md +61 -0
- package/pack/generated/dsh/skills/devrites-interview/SKILL.md +107 -0
- package/pack/generated/dsh/skills/devrites-lib/SKILL.md +98 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/candidate-integrity.md +59 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/intent-map.md +86 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/orchestration-profiles.md +48 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/parallel-dispatch.md +184 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/reply-contract.md +123 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/README.md +70 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/acceptance-preserving-reslice.md +32 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/afk-hitl.md +467 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/agents.md +231 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/anti-patterns.md +50 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/architecture-health.md +64 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/assumption-checkpoints.md +42 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/audit-coverage.md +107 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/browser-proof-checklist.md +37 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/ci-cd.md +62 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/code-index.md +111 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/code-navigation.md +69 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/code-review.md +178 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/coding-style.md +53 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/context-hygiene.md +136 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/core.md +202 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/data-integrity.md +144 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/debug-recovery.md +42 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/definition-of-done.md +25 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/deprecation.md +49 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/developer-experience.md +128 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/development-workflow.md +31 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/documentation.md +55 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/duplicate-code.md +129 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/edge-case-trace.md +94 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/elicitation.md +114 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/error-handling.md +49 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/gates.md +159 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/git-workflow.md +51 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/glossary.md +40 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/hooks.md +41 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/integration-reliability.md +121 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/loop-operations.md +123 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/observability.md +90 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/one-shot-actions.md +105 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/patterns.md +70 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/performance.md +88 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/principles.md +56 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/prose-style.md +127 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/release/ship-checklist.md +12 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/repository-topology.md +82 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/review/README.md +28 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/review/ci-workflows.md +50 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/review/default.md +42 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/review/go.md +47 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/review/python.md +46 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/review/react.md +55 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/review/shell.md +40 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/review/stack-profile.md +155 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/review/ts-js.md +74 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/review-checklist.md +14 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/security-checklist.md +30 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/security.md +283 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/skill-authoring.md +269 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/spec-grammar.md +214 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/test-proof-checklist.md +18 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/testing.md +295 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/tooling.md +125 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/verification-methods.md +143 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/windows.md +60 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/standards/workflow-artifacts.md +435 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/visual-playbooks/code.md +44 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/visual-playbooks/comparison.md +42 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/visual-playbooks/diagram.md +51 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/visual-playbooks/index.md +66 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/visual-playbooks/input.md +46 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/visual-playbooks/outline-template.md +106 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/visual-playbooks/plan.md +48 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/visual-playbooks/slides.md +40 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/visual-playbooks/table.md +42 -0
- package/pack/generated/dsh/skills/devrites-lib/reference/workspace-artifact-schema.md +312 -0
- package/pack/generated/dsh/skills/devrites-prose-craft/SKILL.md +81 -0
- package/pack/generated/dsh/skills/devrites-prose-craft/reference/banned-phrases.md +132 -0
- package/pack/generated/dsh/skills/devrites-prose-craft/reference/examples.md +136 -0
- package/pack/generated/dsh/skills/devrites-prose-craft/reference/structures.md +196 -0
- package/pack/generated/dsh/skills/devrites-source-driven/SKILL.md +54 -0
- package/pack/generated/dsh/skills/devrites-ux-shape/SKILL.md +135 -0
- package/pack/generated/dsh/skills/devrites-ux-shape/reference/brief-template.md +108 -0
- package/pack/generated/dsh/skills/devrites-ux-shape/reference/visual-direction-probe.md +50 -0
- package/pack/generated/dsh/skills/overhaul/SKILL.md +221 -0
- package/pack/generated/dsh/skills/overhaul/references/audit-domains.md +390 -0
- package/pack/generated/dsh/skills/overhaul/references/lifecycle.md +314 -0
- package/pack/generated/dsh/skills/overhaul/references/orchestration.md +291 -0
- package/pack/generated/dsh/skills/overhaul/references/records.md +203 -0
- package/pack/generated/dsh/skills/overhaul/references/repair-and-measurement.md +310 -0
- package/pack/generated/dsh/skills/overhaul/references/review-and-report.md +139 -0
- package/pack/generated/dsh/skills/overhaul/references/scope-and-safety.md +233 -0
- package/pack/generated/dsh/skills/overhaul/references/scoring.md +261 -0
- package/pack/generated/dsh/skills/overhaul/references/stack-profiles.md +316 -0
- package/pack/generated/dsh/skills/rite/SKILL.md +157 -0
- package/pack/generated/dsh/skills/rite/reference/menu.md +49 -0
- package/pack/generated/dsh/skills/rite-adopt/SKILL.md +64 -0
- package/pack/generated/dsh/skills/rite-adopt/reference/adoption.md +25 -0
- package/pack/generated/dsh/skills/rite-adopt/reference/anti-patterns.md +19 -0
- package/pack/generated/dsh/skills/rite-autocomplete/SKILL.md +167 -0
- package/pack/generated/dsh/skills/rite-autocomplete/reference/decision-policy.md +44 -0
- package/pack/generated/dsh/skills/rite-autocomplete/reference/lookahead.md +50 -0
- package/pack/generated/dsh/skills/rite-autocomplete/reference/loop.md +164 -0
- package/pack/generated/dsh/skills/rite-autocomplete/reference/stop-conditions.md +118 -0
- package/pack/generated/dsh/skills/rite-build/SKILL.md +126 -0
- package/pack/generated/dsh/skills/rite-build/reference/afk-discipline.md +153 -0
- package/pack/generated/dsh/skills/rite-build/reference/anti-patterns.md +27 -0
- package/pack/generated/dsh/skills/rite-build/reference/checkpoint-protocol.md +115 -0
- package/pack/generated/dsh/skills/rite-build/reference/checkpoint.md +79 -0
- package/pack/generated/dsh/skills/rite-build/reference/frontend-trigger.md +39 -0
- package/pack/generated/dsh/skills/rite-build/reference/one-slice-cycle.md +57 -0
- package/pack/generated/dsh/skills/rite-build/reference/output.md +29 -0
- package/pack/generated/dsh/skills/rite-build/reference/parallel-batch.md +260 -0
- package/pack/generated/dsh/skills/rite-build/reference/phase-contract.md +130 -0
- package/pack/generated/dsh/skills/rite-build/reference/spec-drift-guard.md +91 -0
- package/pack/generated/dsh/skills/rite-build/reference/tdd.md +27 -0
- package/pack/generated/dsh/skills/rite-build/reference/wright-dispatch.md +198 -0
- package/pack/generated/dsh/skills/rite-clarify/SKILL.md +104 -0
- package/pack/generated/dsh/skills/rite-clarify/reference/anti-patterns.md +24 -0
- package/pack/generated/dsh/skills/rite-clarify/reference/decision-coverage.md +56 -0
- package/pack/generated/dsh/skills/rite-converge/SKILL.md +167 -0
- package/pack/generated/dsh/skills/rite-converge/reference/anti-patterns.md +35 -0
- package/pack/generated/dsh/skills/rite-converge/reference/convergence-assessment.md +70 -0
- package/pack/generated/dsh/skills/rite-customize/SKILL.md +64 -0
- package/pack/generated/dsh/skills/rite-define/SKILL.md +203 -0
- package/pack/generated/dsh/skills/rite-define/reference/anti-patterns.md +26 -0
- package/pack/generated/dsh/skills/rite-define/reference/gates.md +160 -0
- package/pack/generated/dsh/skills/rite-define/reference/plan-template.md +153 -0
- package/pack/generated/dsh/skills/rite-doctor/SKILL.md +107 -0
- package/pack/generated/dsh/skills/rite-dogfood/SKILL.md +57 -0
- package/pack/generated/dsh/skills/rite-explain/SKILL.md +154 -0
- package/pack/generated/dsh/skills/rite-explain/reference/intake.md +89 -0
- package/pack/generated/dsh/skills/rite-fast/SKILL.md +185 -0
- package/pack/generated/dsh/skills/rite-fast/reference/artifacts.md +107 -0
- package/pack/generated/dsh/skills/rite-fast/reference/check-and-triage.md +51 -0
- package/pack/generated/dsh/skills/rite-frame/SKILL.md +119 -0
- package/pack/generated/dsh/skills/rite-frame/reference/failure-modes.md +66 -0
- package/pack/generated/dsh/skills/rite-handoff/SKILL.md +117 -0
- package/pack/generated/dsh/skills/rite-handoff/reference/handoff-template.md +56 -0
- package/pack/generated/dsh/skills/rite-harness/SKILL.md +76 -0
- package/pack/generated/dsh/skills/rite-harness/reference/feature-map.md +60 -0
- package/pack/generated/dsh/skills/rite-learn/SKILL.md +107 -0
- package/pack/generated/dsh/skills/rite-plan/SKILL.md +215 -0
- package/pack/generated/dsh/skills/rite-plan/reference/anti-patterns.md +34 -0
- package/pack/generated/dsh/skills/rite-plan/reference/dependency-graph.md +48 -0
- package/pack/generated/dsh/skills/rite-plan/reference/replan-and-repair.md +114 -0
- package/pack/generated/dsh/skills/rite-plan/reference/slicing.md +187 -0
- package/pack/generated/dsh/skills/rite-plan/reference/task-breakdown.md +50 -0
- package/pack/generated/dsh/skills/rite-polish/SKILL.md +128 -0
- package/pack/generated/dsh/skills/rite-polish/reference/adr-promotion.md +11 -0
- package/pack/generated/dsh/skills/rite-polish/reference/anti-ai-slop.md +210 -0
- package/pack/generated/dsh/skills/rite-polish/reference/anti-patterns.md +30 -0
- package/pack/generated/dsh/skills/rite-polish/reference/backend-polish.md +80 -0
- package/pack/generated/dsh/skills/rite-polish/reference/browser-polish-evidence.md +33 -0
- package/pack/generated/dsh/skills/rite-polish/reference/code.md +87 -0
- package/pack/generated/dsh/skills/rite-polish/reference/design-memory.md +117 -0
- package/pack/generated/dsh/skills/rite-polish/reference/design-system-discovery.md +8 -0
- package/pack/generated/dsh/skills/rite-polish/reference/harden-checklist.md +110 -0
- package/pack/generated/dsh/skills/rite-polish/reference/ledger.md +67 -0
- package/pack/generated/dsh/skills/rite-polish/reference/ui.md +146 -0
- package/pack/generated/dsh/skills/rite-pov/SKILL.md +71 -0
- package/pack/generated/dsh/skills/rite-pr-feedback/SKILL.md +61 -0
- package/pack/generated/dsh/skills/rite-pressure-test/SKILL.md +76 -0
- package/pack/generated/dsh/skills/rite-prototype/SKILL.md +106 -0
- package/pack/generated/dsh/skills/rite-prove/SKILL.md +151 -0
- package/pack/generated/dsh/skills/rite-prove/reference/acceptance-proof.md +88 -0
- package/pack/generated/dsh/skills/rite-prove/reference/anti-patterns.md +25 -0
- package/pack/generated/dsh/skills/rite-prove/reference/browser-proof.md +51 -0
- package/pack/generated/dsh/skills/rite-prove/reference/failure-triage.md +53 -0
- package/pack/generated/dsh/skills/rite-prove/reference/proof-ladder.md +39 -0
- package/pack/generated/dsh/skills/rite-prove/reference/test-command-discovery.md +36 -0
- package/pack/generated/dsh/skills/rite-quick/SKILL.md +97 -0
- package/pack/generated/dsh/skills/rite-resolve/SKILL.md +113 -0
- package/pack/generated/dsh/skills/rite-resolve/reference/answer-protocol.md +129 -0
- package/pack/generated/dsh/skills/rite-review/SKILL.md +190 -0
- package/pack/generated/dsh/skills/rite-review/reference/anti-patterns.md +32 -0
- package/pack/generated/dsh/skills/rite-review/reference/cognitive-load.md +90 -0
- package/pack/generated/dsh/skills/rite-review/reference/feature-scoped-review.md +26 -0
- package/pack/generated/dsh/skills/rite-review/reference/five-axis-review.md +66 -0
- package/pack/generated/dsh/skills/rite-review/reference/nielsen-heuristics.md +126 -0
- package/pack/generated/dsh/skills/rite-review/reference/performance-checklist.md +99 -0
- package/pack/generated/dsh/skills/rite-review/reference/performance-review.md +14 -0
- package/pack/generated/dsh/skills/rite-review/reference/security-review.md +44 -0
- package/pack/generated/dsh/skills/rite-seal/SKILL.md +99 -0
- package/pack/generated/dsh/skills/rite-seal/reference/anti-patterns.md +29 -0
- package/pack/generated/dsh/skills/rite-seal/reference/final-evidence.md +41 -0
- package/pack/generated/dsh/skills/rite-seal/reference/go-no-go.md +32 -0
- package/pack/generated/dsh/skills/rite-seal/reference/output.md +5 -0
- package/pack/generated/dsh/skills/rite-seal/reference/phase-contract.md +56 -0
- package/pack/generated/dsh/skills/rite-seal/reference/risk-and-rollback.md +56 -0
- package/pack/generated/dsh/skills/rite-seal/reference/seal-template.md +32 -0
- package/pack/generated/dsh/skills/rite-ship/SKILL.md +101 -0
- package/pack/generated/dsh/skills/rite-ship/reference/anti-patterns.md +28 -0
- package/pack/generated/dsh/skills/rite-ship/reference/close-out.md +69 -0
- package/pack/generated/dsh/skills/rite-ship/reference/git-ship.md +128 -0
- package/pack/generated/dsh/skills/rite-ship/reference/rollout.md +62 -0
- package/pack/generated/dsh/skills/rite-ship/reference/ship-template.md +40 -0
- package/pack/generated/dsh/skills/rite-spec/SKILL.md +169 -0
- package/pack/generated/dsh/skills/rite-spec/reference/acceptance-criteria.md +31 -0
- package/pack/generated/dsh/skills/rite-spec/reference/ai-spec-template.md +40 -0
- package/pack/generated/dsh/skills/rite-spec/reference/anti-patterns.md +27 -0
- package/pack/generated/dsh/skills/rite-spec/reference/interview-patterns.md +56 -0
- package/pack/generated/dsh/skills/rite-spec/reference/investigation.md +83 -0
- package/pack/generated/dsh/skills/rite-spec/reference/question-protocol.md +36 -0
- package/pack/generated/dsh/skills/rite-spec/reference/references-intake.md +62 -0
- package/pack/generated/dsh/skills/rite-spec/reference/spec-checklists.md +89 -0
- package/pack/generated/dsh/skills/rite-spec/reference/spec-template.md +160 -0
- package/pack/generated/dsh/skills/rite-spec/reference/state-workspace.md +240 -0
- package/pack/generated/dsh/skills/rite-status/SKILL.md +74 -0
- package/pack/generated/dsh/skills/rite-temper/SKILL.md +137 -0
- package/pack/generated/dsh/skills/rite-temper/reference/anti-patterns.md +30 -0
- package/pack/generated/dsh/skills/rite-temper/reference/review-dimensions.md +66 -0
- package/pack/generated/dsh/skills/rite-temper/reference/scope-modes.md +52 -0
- package/pack/generated/dsh/skills/rite-temper/reference/significance.md +55 -0
- package/pack/generated/dsh/skills/rite-temper/reference/strategy-template.md +101 -0
- package/pack/generated/dsh/skills/rite-upgrade/SKILL.md +142 -0
- package/pack/generated/dsh/skills/rite-vet/SKILL.md +242 -0
- package/pack/generated/dsh/skills/rite-vet/reference/anti-patterns.md +43 -0
- package/pack/generated/dsh/skills/rite-vet/reference/artifacts.md +248 -0
- package/pack/generated/dsh/skills/rite-vet/reference/cross-model.md +19 -0
- package/pack/generated/dsh/skills/rite-vet/reference/depth.md +59 -0
- package/pack/generated/dsh/skills/rite-vet/reference/eng-lenses.md +48 -0
- package/pack/generated/dsh/skills/rite-vet/reference/review-axes.md +210 -0
- package/pack/generated/dsh/skills/rite-watch-pr/SKILL.md +87 -0
- package/pack/generated/dsh/skills/rite-zoom-out/SKILL.md +76 -0
- package/pack/generated/omp/agents/devrites-upgrade-planner.md +12 -4
- package/pack/generated/omp/skills/devrites-debug-recovery/SKILL.md +21 -4
- package/pack/generated/omp/skills/devrites-debug-recovery/reference/cleanup-and-classify.md +10 -3
- package/pack/generated/omp/skills/devrites-debug-recovery/reference/regression-test.md +7 -4
- package/pack/generated/omp/skills/devrites-lib/reference/reply-contract.md +11 -11
- package/pack/generated/omp/skills/devrites-lib/reference/standards/afk-hitl.md +52 -56
- package/pack/generated/omp/skills/devrites-lib/reference/standards/agents.md +11 -1
- package/pack/generated/omp/skills/devrites-lib/reference/standards/core.md +41 -40
- package/pack/generated/omp/skills/rite-autocomplete/SKILL.md +12 -14
- package/pack/generated/omp/skills/rite-autocomplete/reference/loop.md +34 -38
- package/pack/generated/omp/skills/rite-autocomplete/reference/stop-conditions.md +38 -39
- package/pack/generated/omp/skills/rite-define/SKILL.md +28 -27
- package/pack/generated/omp/skills/rite-plan/SKILL.md +7 -2
- package/pack/generated/omp/skills/rite-plan/reference/replan-and-repair.md +5 -2
- package/pack/generated/omp/skills/rite-resolve/SKILL.md +17 -10
- package/pack/generated/omp/skills/rite-resolve/reference/answer-protocol.md +18 -6
- package/pack/generated/omp/skills/rite-review/SKILL.md +4 -4
- package/pack/generated/omp/skills/rite-review/reference/security-review.md +4 -2
- package/pack/generated/omp/skills/rite-seal/SKILL.md +28 -33
- package/pack/generated/omp/skills/rite-ship/SKILL.md +14 -7
- package/pack/generated/omp/skills/rite-temper/SKILL.md +18 -18
- package/pack/generated/omp/skills/rite-temper/reference/scope-modes.md +6 -7
- package/pack/generated/omp/skills/rite-upgrade/SKILL.md +7 -2
- package/pack/generated/omp/skills/rite-vet/SKILL.md +33 -34
- package/pack/generated/pi/agents/devrites-upgrade-planner.md +12 -4
- package/pack/generated/pi/skills/devrites-debug-recovery/SKILL.md +21 -4
- package/pack/generated/pi/skills/devrites-debug-recovery/reference/cleanup-and-classify.md +10 -3
- package/pack/generated/pi/skills/devrites-debug-recovery/reference/regression-test.md +7 -4
- package/pack/generated/pi/skills/devrites-lib/reference/reply-contract.md +11 -11
- package/pack/generated/pi/skills/devrites-lib/reference/standards/afk-hitl.md +52 -56
- package/pack/generated/pi/skills/devrites-lib/reference/standards/agents.md +11 -1
- package/pack/generated/pi/skills/devrites-lib/reference/standards/core.md +41 -40
- package/pack/generated/pi/skills/rite-autocomplete/SKILL.md +12 -14
- package/pack/generated/pi/skills/rite-autocomplete/reference/loop.md +34 -38
- package/pack/generated/pi/skills/rite-autocomplete/reference/stop-conditions.md +38 -39
- package/pack/generated/pi/skills/rite-define/SKILL.md +28 -27
- package/pack/generated/pi/skills/rite-plan/SKILL.md +7 -2
- package/pack/generated/pi/skills/rite-plan/reference/replan-and-repair.md +5 -2
- package/pack/generated/pi/skills/rite-resolve/SKILL.md +17 -10
- package/pack/generated/pi/skills/rite-resolve/reference/answer-protocol.md +18 -6
- package/pack/generated/pi/skills/rite-review/SKILL.md +4 -4
- package/pack/generated/pi/skills/rite-review/reference/security-review.md +4 -2
- package/pack/generated/pi/skills/rite-seal/SKILL.md +28 -33
- package/pack/generated/pi/skills/rite-ship/SKILL.md +14 -7
- package/pack/generated/pi/skills/rite-temper/SKILL.md +18 -18
- package/pack/generated/pi/skills/rite-temper/reference/scope-modes.md +6 -7
- package/pack/generated/pi/skills/rite-upgrade/SKILL.md +7 -2
- package/pack/generated/pi/skills/rite-vet/SKILL.md +33 -34
- package/package.json +3 -1
- package/scripts/build-host-artifacts.sh +6 -2
- package/scripts/dsh-generate.py +135 -0
- package/scripts/dsh-specialist.mjs +62 -0
- package/scripts/install-lib.sh +3 -1
|
@@ -0,0 +1,242 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: rite-vet
|
|
3
|
+
description: Review a defined engineering plan before code. Use for plan vetting or lock-in; not for implementation review or final readiness sealing.
|
|
4
|
+
argument-hint: "[slug] [--cross-model] [--full]"
|
|
5
|
+
user-invocable: true
|
|
6
|
+
---
|
|
7
|
+
|
|
8
|
+
<!-- loads: {"always":["devrites-lib/reference/standards/core.md","devrites-lib/reference/standards/code-navigation.md","devrites-lib/reference/standards/code-index.md","devrites-lib/reference/orchestration-profiles.md","devrites-lib/reference/parallel-dispatch.md","devrites-lib/reference/standards/gates.md","rite-vet/reference/review-axes.md","rite-vet/reference/artifacts.md","rite-vet/reference/depth.md","rite-vet/reference/eng-lenses.md","rite-vet/reference/anti-patterns.md"],"triggers":{"afk":["devrites-lib/reference/standards/afk-hitl.md"],"applicability":["devrites-lib/reference/standards/repository-topology.md","devrites-lib/reference/standards/data-integrity.md","devrites-lib/reference/standards/integration-reliability.md"],"assumption-delta":["devrites-lib/reference/standards/assumption-checkpoints.md"],"cross-model":["rite-vet/reference/cross-model.md"],"devex":["devrites-lib/reference/standards/developer-experience.md"],"dod":["devrites-lib/reference/standards/definition-of-done.md"],"elicitation":["devrites-lib/reference/standards/elicitation.md"],"errors":["devrites-lib/reference/standards/error-handling.md"],"grammar":["devrites-lib/reference/standards/spec-grammar.md"],"one-shot":["devrites-lib/reference/standards/one-shot-actions.md"],"performance":["devrites-lib/reference/standards/performance.md"],"principles":["devrites-lib/reference/standards/principles.md"],"reslice":["devrites-lib/reference/standards/acceptance-preserving-reslice.md"],"testing":["devrites-lib/reference/standards/testing.md"],"workflow":["devrites-lib/reference/standards/development-workflow.md"],"workflow-artifacts":["devrites-lib/reference/standards/workflow-artifacts.md"],"yagni":["devrites-lib/reference/standards/patterns.md","devrites-lib/reference/standards/coding-style.md"]},"workspace":["brief.md","spec.md","state.md","decisions.md","assumptions.md","questions.md","decision-coverage.md","strategy.md","architecture.md","plan.md","tasks.md","traceability.md","eng-review.md","test-plan.md","gates.md"],"rootOnly":["devrites-lib/reference/standards/code-index.md","devrites-lib/reference/standards/afk-hitl.md","devrites-lib/reference/standards/elicitation.md","devrites-lib/reference/orchestration-profiles.md","devrites-lib/reference/parallel-dispatch.md","devrites-lib/reference/standards/workflow-artifacts.md"],"workspaceByRole":{"doubt-reviewer":["spec.md","architecture.md","plan.md","tasks.md","test-plan.md","decisions.md","state.md"],"devex-reviewer":["spec.md","plan.md","tasks.md","decisions.md","state.md"],"plan-reviewer":["spec.md","plan.md","tasks.md","test-plan.md","decision-coverage.md","architecture.md","decisions.md","state.md"],"strategy-reviewer":["brief.md","spec.md","plan.md","decisions.md","decision-coverage.md","strategy.md","state.md"]}} -->
|
|
9
|
+
> Read-set manifest: `devrites-engine context --skills-root .dsh/skills <slug> --phase vet` bundles every file named below into one deduplicated read. Trigger names map to the conditional rules in the sections that follow.
|
|
10
|
+
|
|
11
|
+
|
|
12
|
+
# /rite-vet: review the plan before build
|
|
13
|
+
|
|
14
|
+
Vet each plan: scope, architecture, quality, proof, performance, failures, writer
|
|
15
|
+
safety. Fold cited technical findings; design Build tests. Temper owns product,
|
|
16
|
+
Vet implementation. Current `$ARGUMENTS` (`--full`) feeds `reference/depth.md`
|
|
17
|
+
triggers; profiles never remove the exact plan-reviewer gate
|
|
18
|
+
([orchestration-profiles.md](../devrites-lib/reference/orchestration-profiles.md)).
|
|
19
|
+
|
|
20
|
+
## Rules
|
|
21
|
+
|
|
22
|
+
Read the active standard from: [`principles.md`](../devrites-lib/reference/standards/principles.md), [`patterns.md`](../devrites-lib/reference/standards/patterns.md) + [`coding-style.md`](../devrites-lib/reference/standards/coding-style.md) (over-engineering / YAGNI rubric, trigger `yagni`),
|
|
23
|
+
[`testing.md`](../devrites-lib/reference/standards/testing.md), [`spec-grammar.md`](../devrites-lib/reference/standards/spec-grammar.md), [`performance.md`](../devrites-lib/reference/standards/performance.md), [`error-handling.md`](../devrites-lib/reference/standards/error-handling.md) (trigger `errors`),
|
|
24
|
+
[`development-workflow.md`](../devrites-lib/reference/standards/development-workflow.md), [`afk-hitl.md`](../devrites-lib/reference/standards/afk-hitl.md), [`one-shot-actions.md`](../devrites-lib/reference/standards/one-shot-actions.md),
|
|
25
|
+
[`developer-experience.md`](../devrites-lib/reference/standards/developer-experience.md), [`elicitation.md`](../devrites-lib/reference/standards/elicitation.md), and [`definition-of-done.md`](../devrites-lib/reference/standards/definition-of-done.md) (trigger `dod`). Load
|
|
26
|
+
repository topology, data integrity, and integration reliability only when
|
|
27
|
+
triggered (trigger `applicability`). When the plan's scope generalizes an existing boundary — a second
|
|
28
|
+
platform/tenant/source of truth, a newly optional field, a constant turned parameter —
|
|
29
|
+
confirm the [`assumption-checkpoints.md`](../devrites-lib/reference/standards/assumption-checkpoints.md) question (trigger `assumption-delta`)
|
|
30
|
+
was answered and recorded, not skipped-as-negative.
|
|
31
|
+
Before classifying any Reslice, read `.dsh/skills/devrites-lib/reference/standards/acceptance-preserving-reslice.md`.
|
|
32
|
+
When a
|
|
33
|
+
plan declares a root-authored executable workflow file, read
|
|
34
|
+
[`workflow-artifacts.md`](../devrites-lib/reference/standards/workflow-artifacts.md).
|
|
35
|
+
|
|
36
|
+
<!-- BEGIN RESLICE ROUTE-TO-ACTION -->
|
|
37
|
+
- `FOLD` → fold technical topology; invalidate Vet/readiness; affected Vet before Build.
|
|
38
|
+
- `GUARD_AND_REPAIR` → no planning writes; Spec Drift Guard → Clarify → Plan repair → affected Vet.
|
|
39
|
+
- `BLOCKED_INPUT` → no planning writes; exact diagnostic; recover input; reclassify.
|
|
40
|
+
<!-- END RESLICE ROUTE-TO-ACTION -->
|
|
41
|
+
|
|
42
|
+
## Invariants
|
|
43
|
+
|
|
44
|
+
- Review implementation, not ambition. Challenge creep/complexity/proof/risk
|
|
45
|
+
without changing accepted product scope.
|
|
46
|
+
- Root owns decisions/writes/readiness; reviewers judge, not route. Cite
|
|
47
|
+
findings/confidence; suppress unverified or confidence ≤4 findings per
|
|
48
|
+
`review-axes.md`. `eng-lenses.md` arrows are heuristics; use only the four
|
|
49
|
+
`review-axes.md` band names.
|
|
50
|
+
- Auth, migration, public API, and data-model changes need maximum caution,
|
|
51
|
+
full review, and explicit rollback. Pause only for
|
|
52
|
+
[canonical irreversible-risk items](../devrites-lib/reference/standards/afk-hitl.md#irreversible-risk-list-always-pause)
|
|
53
|
+
or unresolved human-owned decisions, not an already-approved reversible internal
|
|
54
|
+
data-model change. Project principles never become trade-offs.
|
|
55
|
+
- **Governance-protected paths** (`.devrites/**`, pack skill/agent trees,
|
|
56
|
+
`NOTICE.md` generator regions, documented CI/hook config) require explicit
|
|
57
|
+
human approval before plan slices edit them; absent approval → Vet
|
|
58
|
+
**NEEDS CLARIFICATION**.
|
|
59
|
+
- Use lowest axis band; never average/round thin to ready. Search; resolve
|
|
60
|
+
reversible technical choices; ask only human-owned.
|
|
61
|
+
- Preserve a valid technical return cursor. Agent-owned `NEEDS REPLAN` returns
|
|
62
|
+
internally to its caller, not to the human; on a direct invocation there is
|
|
63
|
+
no caller, so Vet becomes it — save a return cursor
|
|
64
|
+
(`return_phase`/`return_next_action`) naming this Vet pass as the caller and
|
|
65
|
+
invoke `/rite-plan` repair inline under the same fingerprint caps. An
|
|
66
|
+
agent-owned verdict with budget remaining is never a user-facing command.
|
|
67
|
+
- **Recovery recheck is bounded and batched.** A valid cursor plus open
|
|
68
|
+
fingerprints enters Recovery recheck; it does not start another Full Vet or
|
|
69
|
+
repeat unaffected axes/reviewers. One dispatch covers every open fingerprint
|
|
70
|
+
of the fold — each checked individually — with a mandatory correction-created
|
|
71
|
+
regression audit.
|
|
72
|
+
- Refuse the rationalizations in [`anti-patterns`](reference/anti-patterns.md).
|
|
73
|
+
<!-- workflow-artifact-adapter: {"module":"devrites-lib/reference/standards/workflow-artifacts.md","entry":"plan declares root-authored executable workflow file","action":"emit exact admission; stale/missing authority uses PLAN_VET_REPAIR","return":"Vet READY cursor or exact technical replan"} -->
|
|
74
|
+
## Workflow
|
|
75
|
+
|
|
76
|
+
0. **Orient.** Read core. Resolve active slug, require state, and read plan,
|
|
77
|
+
tasks, spec, decision coverage, optional strategy/design brief, decisions,
|
|
78
|
+
assumptions, and state. Require approved Plan and `Decision coverage: CLEAR`;
|
|
79
|
+
otherwise stop for Define or Clarify. Check placement (`get_architecture`),
|
|
80
|
+
blast radius (`trace_path`), and reuse (`search_graph`) per [`code-navigation.md`](../devrites-lib/reference/standards/code-navigation.md).
|
|
81
|
+
1. **Select depth.** Apply `reference/depth.md` exactly; never skip. Initial passes
|
|
82
|
+
record engineering verdict and test-plan coverage. Valid Recovery rechecks
|
|
83
|
+
retain prior depth; enter 1b.
|
|
84
|
+
1a. **Independent initial pass.** Freeze candidate; dispatch exact fresh read-only
|
|
85
|
+
plan reviewer, plus developer-experience reviewer for developer surfaces
|
|
86
|
+
(trigger `devex`) and current strategy reviewer after significant Temper, in
|
|
87
|
+
parallel under `../devrites-lib/reference/parallel-dispatch.md`: independent
|
|
88
|
+
read-only passes on one frozen candidate. Missing required account blocks.
|
|
89
|
+
Meanwhile run root steps 2–4, including step 3 preflight commands, on that
|
|
90
|
+
candidate; reconcile returned accounts.
|
|
91
|
+
1b. **Recovery recheck.** Require valid return cursor, accepted prior finding,
|
|
92
|
+
exact fingerprint/reproduction, repaired candidate identity, changed
|
|
93
|
+
paths/criteria, affected drift/evidence, and the recorded delta self-check.
|
|
94
|
+
Freeze that packet and dispatch each exact owning reviewer once,
|
|
95
|
+
fresh/read-only, limited to it — all its open fingerprints in that dispatch.
|
|
96
|
+
Do not rerun broad inventory or unaffected reviewers. Close the prior
|
|
97
|
+
fingerprint only with discriminating evidence plus an explicit
|
|
98
|
+
correction-created regression verdict on the touched invariants (acyclic
|
|
99
|
+
deps, traceability, contract proof, sizing) and every region depending on a
|
|
100
|
+
changed clause — enumerate dependents via the dep graph and traceability
|
|
101
|
+
refs, not only patched sites. Otherwise record one no-progress outcome. A
|
|
102
|
+
different Critical/Important invariant needs exact evidence and a new
|
|
103
|
+
fingerprint; a Suggestion, Nit, or FYI cannot keep recovery open. Reviewer
|
|
104
|
+
`Late:` rows on unchanged clauses follow the canonical
|
|
105
|
+
[late-finding rule](../devrites-lib/reference/standards/afk-hitl.md#retry-cap-no-progress-loops-and-self-resolve):
|
|
106
|
+
Critical with a failure path → new fingerprint; otherwise `eng-review.md`
|
|
107
|
+
`## Deferred findings` (mechanism rows become one proof row at step 6). A packet
|
|
108
|
+
marked `convergence_pressure` accepts an explicit, bounded declared
|
|
109
|
+
residual/limitation folded into the contract text as closure for a finding
|
|
110
|
+
marked as a refinement of an already-pinned clause; the recheck may re-raise
|
|
111
|
+
it only by naming a concrete failure path the declaration omits. A
|
|
112
|
+
`new_failure_mode` finding is never residual-eligible. A fold whose
|
|
113
|
+
findings are all `mechanism` kind or Suggestion-or-lower rechecks mechanically at the
|
|
114
|
+
materialization gate — anchors applied (a clean `state apply-bundle`), mirrors consistent, invariants
|
|
115
|
+
pass — without a dispatched reviewer; sub-Important findings already
|
|
116
|
+
cannot keep recovery open. Reconcile
|
|
117
|
+
shared artifact/readiness gates, then enter step 8 or the next repair.
|
|
118
|
+
Do not fall through to steps 2–7. Retain evidenced unchanged coverage; changed
|
|
119
|
+
global contract/uncertain impact requires full applicable review. Reopen historical
|
|
120
|
+
findings only for affected invariants/dependencies.
|
|
121
|
+
2. **Challenge scope.** Apply review-axes §0; search accepted decisions.
|
|
122
|
+
Harden to the smallest contract-complete plan, using marked topology action.
|
|
123
|
+
Then verify bidirectional ID-and-meaning traceability across spec/plan/
|
|
124
|
+
tasks/test-plan/traceability, acceptance, terms, principles, anti-slop,
|
|
125
|
+
and conventions; every slice and test-plan row maps to a live requirement
|
|
126
|
+
and vice versa. Critical gaps/unexcepted principle breaches block. Record
|
|
127
|
+
rechecked result in `eng-review.md` §2 (Scope challenge).
|
|
128
|
+
3. **Preflight Build entry.** Under `reference/artifacts.md`, verify exact
|
|
129
|
+
command/cwd/tool/version/prerequisite; output filters must preserve upstream
|
|
130
|
+
failure. Verify dependencies from authoritative source plus nearest manifest.
|
|
131
|
+
Run parser-sensitive syntax only in isolated fixtures. Remeasure mutable facts;
|
|
132
|
+
live evidence wins, conflict marks stale, and unmeasurable conflict is a gap.
|
|
133
|
+
Record complete SHA-256 provenance. Every behavioral mapping names a positive
|
|
134
|
+
discriminating assertion and decisive signal, never only exit zero.
|
|
135
|
+
|
|
136
|
+
For each consumptive action, bind every `reference/artifacts.md` Consumptive
|
|
137
|
+
action gates column; every fingerprint identifies one actionable seam; aliasing multiple
|
|
138
|
+
emit sites is a gap. Preflight observes but need not make future behavior pass,
|
|
139
|
+
except that a manifest/lockfile edit is dry-run now: before READY run
|
|
140
|
+
`devrites-engine check preconditions <slug>` (rows with `Run at` `vet`, including each
|
|
141
|
+
`dependency-dry-run` and preserve-baseline row). A failure folds into Plan repair; only an
|
|
142
|
+
owner-owned decision becomes a question, batched under the afk-hitl decision-chain rule.
|
|
143
|
+
4. **Audit readiness.** Goal-backward map every requirement, criterion, NFR,
|
|
144
|
+
interaction, edge/prohibition, and decision row to one slice and executable
|
|
145
|
+
proof. Verify UX/spec/architecture alignment, contracts, dependency order,
|
|
146
|
+
slice independence/wiring, prerequisites, failure/observability/rollback, and
|
|
147
|
+
ownership. The plan's `Shared contract proof` names one reused boundary
|
|
148
|
+
artifact plus two consuming tests for every changed API/event/schema/provider-
|
|
149
|
+
consumer seam, or an explicit no-impact statement. Missing, one-sided,
|
|
150
|
+
duplicated-contract, vague, or non-consuming proof fails closed. Each slice
|
|
151
|
+
names a fast writer-safe check its wright can run; proof reachable only through
|
|
152
|
+
root-owned full gates is a `mechanism` finding.
|
|
153
|
+
|
|
154
|
+
Technical gaps are `NEEDS REPLAN` and Plan repair — each finding marks
|
|
155
|
+
itself `new_failure_mode` or names the already-pinned clause/fingerprint
|
|
156
|
+
it refines, making alias-detection and `convergence_pressure` eligibility
|
|
157
|
+
mechanical — and carries `kind: contract | mechanism`
|
|
158
|
+
(`review-axes.md` § Finding kind). Only `contract` findings open a Plan
|
|
159
|
+
repair; a `mechanism` finding is closed by one `test-plan.md` proof row
|
|
160
|
+
at step 6 and leaves readiness intact when nothing else is open.
|
|
161
|
+
Product/risk gaps are
|
|
162
|
+
`NEEDS CLARIFICATION` and Clarify. Neither becomes a Build qid.
|
|
163
|
+
5. **Review axes.** Apply `review-axes.md` through `eng-lenses.md`. Fold verified
|
|
164
|
+
behavior-preserving technical findings; walk only human-owned decisions.
|
|
165
|
+
Profile gate ceiling and Reslice marked action remain authoritative.
|
|
166
|
+
6. **Write outputs.** Produce every artifact in `reference/artifacts.md`. After
|
|
167
|
+
editing intent/decision/assumption/question owners, re-scan affected coverage,
|
|
168
|
+
assumptions, uncertainty, and gates. Keep state non-READY. Every scenario and
|
|
169
|
+
criterion needs positive, discriminating proof; every slice must be one-pass
|
|
170
|
+
implementable; developer plans (trigger `devex`) write the devex reviewer's
|
|
171
|
+
predicted scorecard to `devex.md`. Durable commands
|
|
172
|
+
are portable repository commands, not host wrappers — resolve them with
|
|
173
|
+
`devrites-engine detect commands` (Makefile/package.json/manifests, no
|
|
174
|
+
execution) and cite the resolved text verbatim; an `unresolved` slot means
|
|
175
|
+
name the concrete command in the plan, never guess one.
|
|
176
|
+
Once the `## Build-entry preflight` table is final, run
|
|
177
|
+
`devrites-engine gates scaffold <slug>` to seed `gates.md` (one pending gate
|
|
178
|
+
per `AC-###`; never clobber an existing ledger), then author each gate's
|
|
179
|
+
`CHECK`/`EXPECT`/`CWD` per artifacts.md §`gates.md` so every runnable oracle
|
|
180
|
+
is an approved preflight row. Run
|
|
181
|
+
`devrites-engine gates lint <slug> --strict` and resolve every finding before
|
|
182
|
+
READY; the readiness check refuses a missing or malformed ledger but does not
|
|
183
|
+
replace this oracle-quality gate.
|
|
184
|
+
7. **Narrow recheck after edits.** A slice-bound recheck builds its bundle and
|
|
185
|
+
opens its wave with `--slice <SLICE-ID>` per affected slice (every 5 rechecks
|
|
186
|
+
per slice need a reslice review, as in Build). **Workflow Artifact bytes-only:**
|
|
187
|
+
after `OFFLINE_RECOVERY`, a correction leaving every admission/`WA-*` row
|
|
188
|
+
unchanged records `Workflow Artifact reviewed identity: <re-preflight identity
|
|
189
|
+
digest>` below the admission block; when `check drift` reports only
|
|
190
|
+
`reviewed-identity-only`, the reviewer is one fresh `devrites-code-reviewer` on
|
|
191
|
+
the prior-source→re-preflight diff against those rows (no drafter or plan
|
|
192
|
+
reviewer); green proceeds to step 8. Otherwise dispatch the exact plan reviewer once per
|
|
193
|
+
fold — one dispatch covering every open fingerprint, preserving
|
|
194
|
+
per correction/fingerprint accounting (each checked individually with its
|
|
195
|
+
accepted findings, changed paths/criteria, new identity, and recorded delta
|
|
196
|
+
self-check); it must return an explicit correction-created regression
|
|
197
|
+
verdict over touched invariants plus every dependent of each changed clause
|
|
198
|
+
(dep-graph and traceability lookup), not only fingerprint closure. Within one correction, no broad
|
|
199
|
+
third loop. If it changes plan, fold again. A closed input plus a distinct Critical/Important invariant returns
|
|
200
|
+
that new fingerprint as progress. Then close matrix and rerun ID/meaning audit.
|
|
201
|
+
8. **Build readback and readiness.** Add a cited five-line readback to
|
|
202
|
+
`eng-review.md` (artifacts.md §7 rows 1–5): outcome/ACs; IN/OUT/must-NOT; UI direction and architecture/
|
|
203
|
+
critical flow; slice order/first slice; decisive proof/action-time gates. No implementer should need to invent product, architecture, or proof.
|
|
204
|
+
Contradiction, ownerlessness, or material ambiguity blocks via Clarify or Plan.
|
|
205
|
+
|
|
206
|
+
Write exactly one `Implementation readiness: READY`, `NEEDS CLARIFICATION`,
|
|
207
|
+
or `NEEDS REPLAN`. Root sets READY after every account, checklist,
|
|
208
|
+
preflight, and sweep is green, including the
|
|
209
|
+
[`spec-grammar.md`](../devrites-lib/reference/standards/spec-grammar.md) marker sweep whose
|
|
210
|
+
`marker sweep:` line is recorded in `eng-review.md`; a kept hit blocks READY. Write phase/next step and emit one
|
|
211
|
+
`Readiness inputs SHA-256` with
|
|
212
|
+
`devrites-engine check readiness --emit-binding <slug>`; normal readiness check
|
|
213
|
+
must pass, and it replays Build-entry `check slice` on every unbuilt slice, so
|
|
214
|
+
READY needs each to pass (fix failures in `/rite-plan`). READY also needs every
|
|
215
|
+
unbuilt slice's write set closed against the live tree (plan-reviewer
|
|
216
|
+
dimension 6), so frontier gaps fold in one Plan repair, not one per slice; an
|
|
217
|
+
affected recheck also closes every unbuilt slice and never defers a closure row. A `sequence_lookahead: yes` workspace also records one
|
|
218
|
+
`Predecessor readiness: <predecessor> <digest>` line from the predecessor's
|
|
219
|
+
`--emit-binding` hex; readiness re-checks it. Record the per-input drift baseline alongside it:
|
|
220
|
+
`devrites-engine check drift <slug> --record` — a later stale binding then
|
|
221
|
+
names the exact artifact that moved instead of "something changed". An `ADVISORY
|
|
222
|
+
proportion:` line names a slice whose proof outgrew its ACs: move its rows without a
|
|
223
|
+
`Proves` spec line to `Deferred hardening` before READY, never deepen them. Technical failure records reproduction, not qid. Human gap awaits
|
|
224
|
+
Clarify. Optional cross-model follows `reference/cross-model.md` (trigger `cross-model`).
|
|
225
|
+
|
|
226
|
+
With READY, no pending remediation, and a valid technical return cursor,
|
|
227
|
+
restore and consume the return cursor instead of defaulting to Build. Preserve
|
|
228
|
+
it through admitted remediation. Only a real stop reaches the human.
|
|
229
|
+
9. **Stop at the Vet boundary.** Show Build readback, scope verdict, lowest axis,
|
|
230
|
+
closed gaps, preflight, action checkpoints, and critical failures. Recommend
|
|
231
|
+
Build only when READY.
|
|
232
|
+
|
|
233
|
+
> Do not replace interactive review with artifacts, change acceptance through
|
|
234
|
+
> hardening, score without source evidence, or ignore unexplained complexity.
|
|
235
|
+
|
|
236
|
+
## Phase exit
|
|
237
|
+
|
|
238
|
+
**Complete when:** `eng-review.md` records exactly one readiness verdict, readiness
|
|
239
|
+
binding SHA-256 passes, and every required reviewer account is admitted.
|
|
240
|
+
|
|
241
|
+
**Failing case:** READY written while a required reviewer returned `Outcome: gap` →
|
|
242
|
+
not complete; restore NEEDS REPLAN or dispatch missing reviewer.
|
|
@@ -0,0 +1,43 @@
|
|
|
1
|
+
# /rite-vet: anti-patterns
|
|
2
|
+
|
|
3
|
+
Read [universal anti-patterns](../../devrites-lib/reference/standards/anti-patterns.md).
|
|
4
|
+
|
|
5
|
+
Authority: `.dsh/skills/devrites-lib/reference/standards/acceptance-preserving-reslice.md`.
|
|
6
|
+
|
|
7
|
+
<!-- BEGIN RESLICE ROUTE-TO-ACTION -->
|
|
8
|
+
- `FOLD` → fold technical topology; invalidate Vet/readiness; affected Vet before Build.
|
|
9
|
+
- `GUARD_AND_REPAIR` → no planning writes; Spec Drift Guard → Clarify → Plan repair → affected Vet.
|
|
10
|
+
- `BLOCKED_INPUT` → no planning writes; exact diagnostic; recover input; reclassify.
|
|
11
|
+
<!-- END RESLICE ROUTE-TO-ACTION -->
|
|
12
|
+
|
|
13
|
+
## Phase rationalizations
|
|
14
|
+
|
|
15
|
+
| Excuse | Rebuttal |
|
|
16
|
+
|---|---|
|
|
17
|
+
| "I'll write all the findings into `eng-review.md` and let the user read it." | Fold verified behavior-preserving findings together and recheck affected closure. Ask human-owned choices with recommendations and await answers. Recording alone resolves nothing; never silently change acceptance or mark unresolved choices READY. |
|
|
18
|
+
| "The plan doesn't handle X: flag it." (without checking) | Quote the line first. If you can't quote where the plan handles X, you also can't be sure it doesn't: force confidence ≤4 and suppress. The "field/case doesn't exist" finding is the most common false positive; the verification gate exists to kill it. |
|
|
19
|
+
| "It's an obvious fix. I'll just edit the plan." | Vet hardens verified plans; topology uses the marked action. |
|
|
20
|
+
| "This dimension is thin but the others are strong: net it's fine." | The gate is the **floor**, not the average. A plan `broken` on test-coverage does not pass because it's `strong` on architecture. |
|
|
21
|
+
| "I can see it's adequate. I'll note the band, the evidence is obvious." | Cite quoted evidence **before** the band; never score first and rationalize later. |
|
|
22
|
+
| "8+ files but it all needs to change: proceed." | Apply `review-axes.md` §0: justify complexity against the smallest contract-complete alternative; fold technical reductions through the marked action. File count does not justify design or require a pause. Ask only for changed scope, behavior, or risk policy. |
|
|
23
|
+
| "There's no test for this, but the user can add one later." | Coverage is designed **now**, before the code, so the build writes tests alongside it. A deferred test is a test that misses the boundary cases writing-it-now would expose. Regressions are non-negotiable. Critical, no question. |
|
|
24
|
+
| "Performance looks fine." | "Looks fine" is not a measurement. A perf finding is "measure X against budget Y" or it's nothing: don't recommend speculative tuning, and don't wave past an N+1 you can quote. |
|
|
25
|
+
| "Cross-model agrees, so apply it." | Consensus is a signal, not proof or approval. Verify the finding against source, then use the same technical-hardening or human-owned decision route; model agreement never authorizes a scope, acceptance, or policy change. |
|
|
26
|
+
|
|
27
|
+
## Reslice classifier rationalizations
|
|
28
|
+
|
|
29
|
+
**RSLICE-VET-001** — Slice/topology growth alone does not stop; fewer slices do not prove scope reduction; remediation does not grow product.
|
|
30
|
+
|
|
31
|
+
## Red flags
|
|
32
|
+
- `eng-review.md` / `test-plan.md` written but `plan.md` / `tasks.md` **not** hardened: the build
|
|
33
|
+
follows the plan, so the review changed nothing.
|
|
34
|
+
- A finding raised with confidence ≥7 but **no quoted source line**, that defeats the verification gate.
|
|
35
|
+
- Acceptance/product-behavior growth auto-applied in AFK, or an orthogonal human-owned gate that did not pause.
|
|
36
|
+
- A failure-mode table with rows but no verdict column filled: a "no test + no handling + silent" row not marked Critical.
|
|
37
|
+
- Repeating an exhausted causal failure under the shared no-progress rule in
|
|
38
|
+
[`afk-hitl.md`](../../devrites-lib/reference/standards/afk-hitl.md), or stopping a
|
|
39
|
+
distinct cause solely because the total review round exceeds three.
|
|
40
|
+
- The reviewer / cross-model being handed the author's reasoning as independent
|
|
41
|
+
evidence (defeats the fresh-context point).
|
|
42
|
+
- The skill writing code, implementing a slice, or running the build. That's `/rite-build`. Vet reviews and hardens the plan; it never implements.
|
|
43
|
+
- Re-litigating the **spec's** scope/ambition, that was `/rite-temper`. Vet challenges *implementation* scope only.
|
|
@@ -0,0 +1,248 @@
|
|
|
1
|
+
# `eng-review.md` + `test-plan.md` templates + fold-back rules
|
|
2
|
+
|
|
3
|
+
`eng-review.md` records review; `test-plan.md` drives Build. Fold accepted findings
|
|
4
|
+
into `plan.md`/`tasks.md`; prose alone never changes Build.
|
|
5
|
+
|
|
6
|
+
Authority: `.dsh/skills/devrites-lib/reference/standards/acceptance-preserving-reslice.md`.
|
|
7
|
+
|
|
8
|
+
<!-- BEGIN RESLICE ROUTE-TO-ACTION -->
|
|
9
|
+
- `FOLD` → fold technical topology; invalidate Vet/readiness; affected Vet before Build.
|
|
10
|
+
- `GUARD_AND_REPAIR` → no planning writes; Spec Drift Guard → Clarify → Plan repair → affected Vet.
|
|
11
|
+
- `BLOCKED_INPUT` → no planning writes; exact diagnostic; recover input; reclassify.
|
|
12
|
+
<!-- END RESLICE ROUTE-TO-ACTION -->
|
|
13
|
+
|
|
14
|
+
## `eng-review.md`: the record
|
|
15
|
+
|
|
16
|
+
Write/update `.devrites/work/<slug>/eng-review.md`; never clobber.
|
|
17
|
+
|
|
18
|
+
```markdown
|
|
19
|
+
# Eng review: <slug>
|
|
20
|
+
Vetted: <iso> Cross-model: ran (codex) | off
|
|
21
|
+
Implementation readiness: <READY | NEEDS CLARIFICATION | NEEDS REPLAN>
|
|
22
|
+
(`NEEDS REPLAN` is the eng-review field value; `NEEDS_REPLAN` with an underscore
|
|
23
|
+
is the autocomplete/reply-contract routing token — do not conflate.)
|
|
24
|
+
Readiness inputs SHA-256: <64 lowercase hex>
|
|
25
|
+
|
|
26
|
+
## 1. Depth
|
|
27
|
+
light | full (<trigger that escalated it>) # every plan is vetted — light or full, never skipped (see depth.md)
|
|
28
|
+
|
|
29
|
+
## 2. Scope challenge
|
|
30
|
+
- Existing reuse: <findings adopted by the plan>
|
|
31
|
+
- Minimum diff: <accepted | trimmed n; list in NOT-in-scope>
|
|
32
|
+
- Complexity: ok | smell (<n files, m new services) → asked → <reduce|proceed, why>
|
|
33
|
+
- Built-in / completeness / distribution: <flags, with source citations>
|
|
34
|
+
|
|
35
|
+
## 2a. Build-entry preflight
|
|
36
|
+
| Gate | Command + cwd | Tool/version | Prerequisite owner | Full provenance inputs | Fixture/smoke | Verdict |
|
|
37
|
+
|---|---|---|---|---|---|---|
|
|
38
|
+
| <test/browser/package> | <command · cwd> | <version> | <owner + item> | <tool/manifest/lockfile/config SHA-256> | <what ran> | pass/fail/blocked |
|
|
39
|
+
|
|
40
|
+
## 2b. Implementation readiness
|
|
41
|
+
| Surface | Requirement/decision | Boundary/wiring | Slice | Proof | Verdict |
|
|
42
|
+
|---|---|---|---|---|---|
|
|
43
|
+
| <journey/data/interface/ops> | <REQ/AC + coverage row> | <contract + key link> | <SLICE-###> | <test-plan row> | ready/gap |
|
|
44
|
+
|
|
45
|
+
Inventory/currentness: <pass/gaps> · slice order/independence: <pass/gaps> ·
|
|
46
|
+
UX/spec/architecture: <pass/n-a/gaps> · operations/rollout/rollback: <pass/n-a/gaps>
|
|
47
|
+
|
|
48
|
+
Shared contract proof: <pass | gap: missing/one-sided/duplicated-contract/vague/non-consuming>
|
|
49
|
+
One-shot evidence completeness: <n/a | pass: action + retained artifact + bounds/sanitization + injective boundary map + per-seam/collision/cleanup fixtures | gap: exact missing proof>
|
|
50
|
+
|
|
51
|
+
## 3. Axis findings (floor-gated)
|
|
52
|
+
| Axis | Floor band | Findings (sev · confidence) |
|
|
53
|
+
|---|---|---|
|
|
54
|
+
| Architecture | strong/adequate/thin/broken | Critical (9) … |
|
|
55
|
+
| Plan code-quality | … | … |
|
|
56
|
+
| Test-coverage design | … | see test-plan.md |
|
|
57
|
+
| Performance | … | … |
|
|
58
|
+
Suppressed (confidence ≤4, unverified): <count — one line each>
|
|
59
|
+
|
|
60
|
+
## 4. Failure modes
|
|
61
|
+
| New codepath/boundary | Realistic failure | Partial/unknown effect | Recovery owner/path | Proof? | Silent? | Verdict |
|
|
62
|
+
|---|---|---|---|---|---|---|
|
|
63
|
+
| <path> | timeout / duplicate / race / stale | <state/effect> | <owner/action> | y/n | y/n | ok / **CRITICAL gap** |
|
|
64
|
+
|
|
65
|
+
## 5. Dependency safety
|
|
66
|
+
<declared order is safe | exact dependency/order correction>
|
|
67
|
+
|
|
68
|
+
## 6. Native reviewer accounts
|
|
69
|
+
- `devrites-plan-reviewer`: <findings + resolution | evidence-based No-findings>
|
|
70
|
+
- `devrites-strategy-reviewer`: <current Temper verdict | Not-applicable: low-stakes skip>
|
|
71
|
+
- `devrites-devex-reviewer`: <findings + resolution | No-findings | Not-applicable: no developer surface>; predicted scorecard → `devex.md`
|
|
72
|
+
- Recheck: <not-needed | one narrow recheck and result>
|
|
73
|
+
- Cross-model (if --cross-model): <overlap / unique findings — informational until approved>
|
|
74
|
+
- Final: floor = <band>; unresolved → <none | blocking qid>
|
|
75
|
+
|
|
76
|
+
## 7. Completion summary
|
|
77
|
+
- Outcome: <one sentence; REQ/AC refs>
|
|
78
|
+
- Boundaries: <IN/OUT/must-NOT refs>
|
|
79
|
+
- Design/flow: <UI/n-a; chosen seams/why; happy/error refs>
|
|
80
|
+
- Delivery: <slice order + first>
|
|
81
|
+
- Proof/gates: <test-plan rows; justified action-time gates>
|
|
82
|
+
- Review: scope <accepted/reduced>; architecture <n>; quality <n>; coverage <x/y>,
|
|
83
|
+
gaps <n>, Critical regressions <n>; failure modes <n>, Critical gaps <n>.
|
|
84
|
+
- Entry/records: preflight <pass/fail/blocked>; checkpoints <none/list>;
|
|
85
|
+
NOT-in-scope + existing written; plan <hardened | n Guard deltas>.
|
|
86
|
+
```
|
|
87
|
+
|
|
88
|
+
## `test-plan.md`: the build-readable coverage target
|
|
89
|
+
|
|
90
|
+
Write/update `.devrites/work/<slug>/test-plan.md`. `/rite-build`'s slice-wright
|
|
91
|
+
writes tests from it; `/rite-prove` walks it against `evidence.md`. Specify
|
|
92
|
+
*what/where* to test, not implementation.
|
|
93
|
+
|
|
94
|
+
```markdown
|
|
95
|
+
# Test plan: <slug>
|
|
96
|
+
From /rite-vet on <iso>. Runner + conventions: <detected framework + command>.
|
|
97
|
+
|
|
98
|
+
## Build-entry preflight
|
|
99
|
+
| Gate | Command | Cwd | Expected | Prerequisites | Provenance to recapture | Run at |
|
|
100
|
+
|---|---|---|---|---|---|---|
|
|
101
|
+
| <test/browser/package> | <exact command> | <path> | <exit/output> | <service/browser/credential owner> | <tool version + full SHA-256s> | vet / pre-dispatch SLICE-### / action |
|
|
102
|
+
|
|
103
|
+
`check preconditions` runs `vet` rows (`--slice` runs `pre-dispatch` rows; `action` rows
|
|
104
|
+
never run there) and passes on exit 0. A slice editing a manifest or lockfile needs a
|
|
105
|
+
`dependency-dry-run SLICE-###` row at `vet`: apply the planned pin in an isolated copy, run
|
|
106
|
+
the tidy/lock step, then the project's admission checks. Resource rows only read
|
|
107
|
+
eligibility (swap, cpuset, env var present); they never measure or change the host.
|
|
108
|
+
Link any disposable parser fixture. Preflight values are planning evidence, not post-build proof;
|
|
109
|
+
Prove recaptures the observed command, candidate identity, and result.
|
|
110
|
+
|
|
111
|
+
## Feature gates
|
|
112
|
+
| Gate | Command | Cwd | Expected |
|
|
113
|
+
|---|---|---|---|
|
|
114
|
+
| <full suite / workspace lint / audit> | <exact command> | <path> | <exit/output> |
|
|
115
|
+
|
|
116
|
+
Whole-repository rows only: Build runs them per landing
|
|
117
|
+
([tiers](../../rite-build/reference/phase-contract.md#proof-tiers)), Prove on the final candidate.
|
|
118
|
+
|
|
119
|
+
Commands in this durable artifact are portable repository commands: no RTK or local shell
|
|
120
|
+
aliases, user-specific absolute paths, or temporary proof trees. Evidence records
|
|
121
|
+
the command actually executed.
|
|
122
|
+
|
|
123
|
+
## Consumptive action gates
|
|
124
|
+
| Action | Why one-shot/consumptive | Retained artifact | Bounds + sanitization | Boundary map + collision proof | Terminal-path fixtures | Cleanup survival | Retry authority |
|
|
125
|
+
|---|---|---|---|---|---|---|---|
|
|
126
|
+
| <exact approved action or n/a> | <one attempt/quota/state/evidence deletion> | <durable operator-controlled path/schema> | <size/cardinality + known/unknown/malformed handling> | <every emit seam -> stable boundary ID; per-seam injection + alias mutant rejected> | <success/known/unknown/hostile> | <assertion> | <none/fresh human authorization> |
|
|
127
|
+
|
|
128
|
+
Every behavioral row names a positive, discriminating assertion and the decisive output it
|
|
129
|
+
produces. A command or expected exit zero alone is not a behavioral assertion; static gates
|
|
130
|
+
prove only their named static criterion.
|
|
131
|
+
|
|
132
|
+
## Coverage diagram
|
|
133
|
+
<the ASCII code-paths + user-flows diagram from review-axes.md, with COVERAGE / GAPS / REGRESSIONS line>
|
|
134
|
+
|
|
135
|
+
## Per-gap test requirements
|
|
136
|
+
| ID | Path / flow | Test file (match conventions) | Asserts (input → expected) | Kind | Slice | Priority | Proves |
|
|
137
|
+
|---|---|---|---|---|---|---|---|
|
|
138
|
+
| T1 | <path> | <path/to.test> | <empty list → 200 + []> | unit / E2E / eval | <slice> | P1 / **Regression-Critical** | <AC/REQ/INV/PROH/DEC/EDGE ID or standard § + quoted line> |
|
|
139
|
+
|
|
140
|
+
Every row's `Proves` quotes the spec line or standard rule it proves. A row that proves
|
|
141
|
+
none is plan-invented hardening: move it to `Deferred hardening`.
|
|
142
|
+
|
|
143
|
+
## Deferred hardening
|
|
144
|
+
| ID | Hardening | Why no spec line needs it | Promote by |
|
|
145
|
+
|---|---|---|---|
|
|
146
|
+
| D1 | <proof or mechanism> | <reason> | <the spec line an owner would add> |
|
|
147
|
+
|
|
148
|
+
Deferred rows, like a [deferred slice](../../rite-plan/reference/slicing.md#deferred-slice),
|
|
149
|
+
are not built, proven, or gating in this feature; this table is their follow-up record.
|
|
150
|
+
Nothing is deleted.
|
|
151
|
+
|
|
152
|
+
## Interaction inventory (UI slices — every element + flow gets an asserting test)
|
|
153
|
+
Enumerate every interactive element and user flow the feature exposes; one row each, none
|
|
154
|
+
skipped. Level per [`testing.md`](../../devrites-lib/reference/standards/testing.md) "Completeness": elements/fields → unit/component, critical
|
|
155
|
+
journeys → one E2E (never one-per-field). `/rite-build` must cover every row; `/rite-prove`
|
|
156
|
+
fails any row with no passing result — an unverified element is a NO-GO, like an unproven criterion.
|
|
157
|
+
```markdown
|
|
158
|
+
| Element / flow | Kind (field/checkbox/select/radio/toggle/button/link/flow) | Level | Test file | Asserts (action → expected) |
|
|
159
|
+
|---|---|---|---|---|
|
|
160
|
+
| email field | field | unit | <form.test> | invalid → error; valid → accepted |
|
|
161
|
+
| login | flow ★★★ | E2E | <login.e2e> | submit → dashboard |
|
|
162
|
+
```
|
|
163
|
+
|
|
164
|
+
Omit the whole section only for a slice with **no** interactive surface (pure backend/logic).
|
|
165
|
+
|
|
166
|
+
## Acceptance → test map
|
|
167
|
+
|
|
168
|
+
- <spec acceptance criterion> → <T1, T3> # every criterion maps to ≥1 test
|
|
169
|
+
|
|
170
|
+
For every row in `plan.md`'s `Shared contract proof`, the per-gap requirements name both
|
|
171
|
+
provider- and consumer-side asserting tests and state how each consumes the same canonical
|
|
172
|
+
artifact. Reference the plan row; do not reproduce its contract table here.
|
|
173
|
+
|
|
174
|
+
## `gates.md`: the acceptance ledger
|
|
175
|
+
|
|
176
|
+
Write `.devrites/work/<slug>/gates.md` once the preflight table is final —
|
|
177
|
+
`devrites-engine gates scaffold <slug>` seeds one pending gate per `AC-###` in
|
|
178
|
+
`spec.md`; never clobber a ledger that already carries evidence. Grammar,
|
|
179
|
+
evidence binding, and oracle rules live in
|
|
180
|
+
[`gates.md`](../../devrites-lib/reference/standards/gates.md); the engine
|
|
181
|
+
enforces them, so author to the contract, not around it:
|
|
182
|
+
|
|
183
|
+
- One gate per required outcome; reuse `AC-###` ids so readiness coverage and
|
|
184
|
+
the ledger name the same set.
|
|
185
|
+
- A runnable gate's `CHECK` must be a `## Build-entry preflight` `Command`
|
|
186
|
+
verbatim with a matching `Cwd` — a gate whose command is absent from the
|
|
187
|
+
preflight table can never execute, so add the row first.
|
|
188
|
+
- `EXPECT` names a line only success can print; `gates lint <slug>` flags
|
|
189
|
+
tautological commands and weak expectations before build.
|
|
190
|
+
- Manual gates (`EVIDENCE` only) are for judgment-bound outcomes; Prove
|
|
191
|
+
attests them, Seal still requires them checked.
|
|
192
|
+
- Carry a `Tests/proof` row marked `RUN: writer` at define into its gate as
|
|
193
|
+
`RUN: writer`; never on a CHECK that needs an empty `git diff` or a driver.
|
|
194
|
+
|
|
195
|
+
## Parallelization table (in `eng-review.md` §5 when there's an opportunity)
|
|
196
|
+
|
|
197
|
+
```markdown
|
|
198
|
+
| Step / workstream | Modules touched (dir-level) | Depends on |
|
|
199
|
+
|---|---|---|
|
|
200
|
+
| API endpoints | controllers/, serializers/ | — |
|
|
201
|
+
| Worker | jobs/, lib/queue/ | API endpoints |
|
|
202
|
+
|
|
203
|
+
Lanes: A: API → Worker (sequential, shared lib/) · B: migration (independent)
|
|
204
|
+
Order: launch A + B in parallel worktrees → merge → C
|
|
205
|
+
Conflicts: Lanes A and B both touch models/ — sequential or coordinate.
|
|
206
|
+
```
|
|
207
|
+
|
|
208
|
+
## Fold-back: the part the build follows
|
|
209
|
+
|
|
210
|
+
Vet hardens the plan. Use the marked action before fold-back.
|
|
211
|
+
|
|
212
|
+
- **Write directly into `plan.md` / `tasks.md`** (single canonical writer: you, not the reviewer):
|
|
213
|
+
- `plan.md` §Scope boundaries ← "NOT in scope" items.
|
|
214
|
+
- `plan.md` §Architecture decisions ← reuse-over-rebuild calls + named failure scenarios.
|
|
215
|
+
- `plan.md` §Applicability and system ownership ← corrected topology/data/integration
|
|
216
|
+
routing and each triggered standard's feature-specific output.
|
|
217
|
+
- `plan.md` §Dependency graph / §Implementation order ← any dependency or ordering fix
|
|
218
|
+
(e.g. refactor-before-feature split).
|
|
219
|
+
- `plan.md` §Complexity & deviations gate ← any deviation the §0 challenge surfaced + its justification.
|
|
220
|
+
- `tasks.md` slices ← added test requirements (point at `test-plan.md`), added error-handling /
|
|
221
|
+
failure-mode coverage, tightened slice scope, a split of a refactor+behavior slice into two.
|
|
222
|
+
Adjust a slice's `Gate:` upward when vet reveals higher stakes (e.g. an unflagged migration).
|
|
223
|
+
- Re-run the `plan.md` Readiness gate after edits; it must still pass.
|
|
224
|
+
- **Reslice:** marked action only; no local predicate.
|
|
225
|
+
- **`decisions.md`:** one ADR per material call: `context · decision · why-not-the-alternative ·
|
|
226
|
+
what-would-change-it`.
|
|
227
|
+
- **`assumptions.md`:** every "we'll probably need X" demoted to an explicit assumption-to-verify,
|
|
228
|
+
never smuggled into scope as a fact.
|
|
229
|
+
|
|
230
|
+
## Write discipline
|
|
231
|
+
|
|
232
|
+
- **Single canonical writer.** The skill writes review/test-plan and edits plan/tasks;
|
|
233
|
+
`devrites-plan-reviewer` is **read-only** and returns findings + bands.
|
|
234
|
+
- **No silent scope.** Growing acceptance without a decision, or dropping a criterion
|
|
235
|
+
without the Guard, is a defect.
|
|
236
|
+
- Put `eng-review.md` + `test-plan.md` between `tasks.md` and `state.md`. Build/Prove
|
|
237
|
+
read test-plan as coverage; Review/Seal may consult eng-review for scope/failures.
|
|
238
|
+
- Finish `test-plan.md`, fold-back, and rechecks first. Changes to `brief.md`, `spec.md`,
|
|
239
|
+
`decisions.md`, `assumptions.md`, or `questions.md` require revalidating the
|
|
240
|
+
affected decision-coverage rows, assumption audit, residual uncertainty, and closed gates.
|
|
241
|
+
`open` rows, an unowned material assumption, or an open blocking/escalating question routes
|
|
242
|
+
`/rite-clarify`/HITL. Re-read affected rows with current evidence; repeat the exact
|
|
243
|
+
plan-reviewer and applicable strategy/DevEx after edits. Root writes READY only after
|
|
244
|
+
the checklist. Normal readiness rejects missing/stale bindings; empty tables,
|
|
245
|
+
placeholders, non-passing preflight rows, or an
|
|
246
|
+
acceptance criterion with no meaningful test mapping remain native review blockers.
|
|
247
|
+
After the final recheck, emit the binding with `devrites-engine check readiness
|
|
248
|
+
--emit-binding <slug>` and replace its one exact line. Never refresh it without Vet.
|
|
@@ -0,0 +1,19 @@
|
|
|
1
|
+
# `--cross-model`: explicit outside integration
|
|
2
|
+
|
|
3
|
+
This optional pass runs only when the user supplies `--cross-model` and a
|
|
4
|
+
different-model plugin, MCP server, or other native integration is explicitly
|
|
5
|
+
connected. DevRites does not discover aliases, invent a fallback model, or wrap
|
|
6
|
+
availability.
|
|
7
|
+
|
|
8
|
+
Give the integration the same immutable `spec.md`, `plan.md`, and `tasks.md`
|
|
9
|
+
candidate, without author reasoning. Ask for evidence-backed findings on
|
|
10
|
+
boundaries, scope/reuse, proof design, performance, reversibility, and failure
|
|
11
|
+
modes. The integration must remain read-only.
|
|
12
|
+
|
|
13
|
+
If no explicit integration is connected, record `requested but not configured`
|
|
14
|
+
and continue with the native `devrites-plan-reviewer`; absence is neither a pass
|
|
15
|
+
nor a blocker.
|
|
16
|
+
|
|
17
|
+
Verify every returned finding against the project before accepting it. Record
|
|
18
|
+
only the integration used and accepted evidence in `eng-review.md`; do not
|
|
19
|
+
maintain availability aliases or outside-review telemetry.
|
|
@@ -0,0 +1,59 @@
|
|
|
1
|
+
# Depth calibration: always vet, scale the rigor (never skip)
|
|
2
|
+
|
|
3
|
+
`/rite-vet` runs on **every** plan. Simple reversible work gets a **light pass**;
|
|
4
|
+
big/risky work gets a **full pass**, never a skip. Standalone Vet and Autocomplete
|
|
5
|
+
use these same depth rules.
|
|
6
|
+
|
|
7
|
+
A four-section deep-dive on a one-file reversible plan is wasteful; rubber-stamping a
|
|
8
|
+
migration-touching plan is dangerous. Match the effort to the stakes, but **always** leave a
|
|
9
|
+
recorded engineering verdict and a coverage plan.
|
|
10
|
+
|
|
11
|
+
Authority: `.dsh/skills/devrites-lib/reference/standards/acceptance-preserving-reslice.md`.
|
|
12
|
+
|
|
13
|
+
<!-- BEGIN RESLICE ROUTE-TO-ACTION -->
|
|
14
|
+
- `FOLD` → fold technical topology; invalidate Vet/readiness; affected Vet before Build.
|
|
15
|
+
- `GUARD_AND_REPAIR` → no planning writes; Spec Drift Guard → Clarify → Plan repair → affected Vet.
|
|
16
|
+
- `BLOCKED_INPUT` → no planning writes; exact diagnostic; recover input; reclassify.
|
|
17
|
+
<!-- END RESLICE ROUTE-TO-ACTION -->
|
|
18
|
+
|
|
19
|
+
## Full pass when ANY trips
|
|
20
|
+
- **Irreversible-risk contact:** the plan touches anything on the [`afk-hitl.md`](../../devrites-lib/reference/standards/afk-hitl.md) irreversible-risk
|
|
21
|
+
list: destructive data migration, auth/authz boundary, public-API break, external-service
|
|
22
|
+
contract, filesystem destruction outside the workspace.
|
|
23
|
+
- **Data model:** new/changed entities, relationships, or persistence shape.
|
|
24
|
+
- **Cross-module blast radius:** the impact (from codebase-memory `trace_path` per
|
|
25
|
+
`../../devrites-lib/reference/standards/code-navigation.md`, or an honest estimate) crosses
|
|
26
|
+
module/service boundaries or has many dependents.
|
|
27
|
+
- **Complexity:** `plan.md` touches **>8 files** or adds **>2 new services/modules/classes**.
|
|
28
|
+
- **Multi-slice / multi-day work**, new dependency/pattern/design system. Slice count alone never creates a human pause.
|
|
29
|
+
- **The user asked**, or `--full`.
|
|
30
|
+
|
|
31
|
+
Full pass = §0 scope challenge + all four axes (each walked finding-by-finding) + the failure-mode
|
|
32
|
+
table + dependency-safety review + the reviewer loop. See [`review-axes.md`](review-axes.md).
|
|
33
|
+
|
|
34
|
+
## Light pass otherwise (the default for simple plans: still never a skip)
|
|
35
|
+
When none of the full-pass triggers fire, run the **light pass**: a fast but real engineering
|
|
36
|
+
check that still leaves a verdict and a coverage plan. In a handful of lines:
|
|
37
|
+
- **§0 scope challenge, in brief:** confirm minimum diff + reuse (one line each); if a complexity
|
|
38
|
+
smell or missed reuse appears, escalate that to the full treatment.
|
|
39
|
+
- **One-line scan per axis** (architecture / plan code-quality / test-coverage / performance):
|
|
40
|
+
"No issues" is a valid result, but you must look and say so per axis, not assume.
|
|
41
|
+
- **Always** produce the acceptance→test map + any regression-Criticals in `test-plan.md`. This is
|
|
42
|
+
the part that makes "a correct engineering plan for *everything*" real. It never downgrades,
|
|
43
|
+
light or full.
|
|
44
|
+
- Write the short `eng-review.md` (`Depth: light`) and harden `tasks.md` with the test requirements.
|
|
45
|
+
|
|
46
|
+
A light-pass finding that turns out to be real **escalates that axis to full treatment** (walk it
|
|
47
|
+
with the human, confidence-banded). Light means *less ceremony*, never *less honesty*.
|
|
48
|
+
|
|
49
|
+
## In `/rite-autocomplete`
|
|
50
|
+
Autocomplete runs `/rite-vet` after `/rite-define` on **every** feature: light or full per the
|
|
51
|
+
triggers above, **never skipped**. Under the AFK gate ceiling:
|
|
52
|
+
- **Auto-apply (no pause):** hardening findings: added test requirements, error-handling /
|
|
53
|
+
failure-mode coverage, tightened scope, reuse-over-rebuild, dependency-order fixes
|
|
54
|
+
(these never grow acceptance). Record the rationale in `decisions.md`.
|
|
55
|
+
- **Topology findings:** marked action; slice count alone never pauses.
|
|
56
|
+
- **Stops:** human-owned irreversible-risk findings pause. Technical recovery follows
|
|
57
|
+
[the canonical retry contract](../../devrites-lib/reference/standards/afk-hitl.md#retry-cap-no-progress-loops-and-self-resolve),
|
|
58
|
+
with no depth-specific round limit; no-progress exhaustion blocks, never grants readiness.
|
|
59
|
+
- **Cross-model** is off by default; it runs only if `--cross-model` was explicitly armed.
|