devrites 6.1.3 → 6.1.5

package/CHANGELOG.md

@@ -2,6 +2,18 @@
 
 All notable changes to DevRites are documented here. The format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/) and DevRites adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). Releases are generated automatically by [semantic-release](https://semantic-release.gitbook.io/) from Conventional Commits on `main`.
 
+## [6.1.5](https://github.com/ViktorsBaikers/DevRites/compare/v6.1.4...v6.1.5) (2026-10-16)
+
+### Fixed
+
+* **devrites:** wrights run writer-safe checks despite contract text ([#111](https://github.com/ViktorsBaikers/DevRites/issues/111)) ([eef69af](https://github.com/ViktorsBaikers/DevRites/commit/eef69af5d62b3ea29293626fce5bc41c6c38ced9))
+
+## [6.1.4](https://github.com/ViktorsBaikers/DevRites/compare/v6.1.3...v6.1.4) (2026-10-16)
+
+### Fixed
+
+* **devrites:** free dead-session claims and surface writer-safe rule ([#110](https://github.com/ViktorsBaikers/DevRites/issues/110)) ([3d431b1](https://github.com/ViktorsBaikers/DevRites/commit/3d431b12cab83d4aaff7aaa4ced2c75210416a90))
+
 ## [6.1.3](https://github.com/ViktorsBaikers/DevRites/compare/v6.1.2...v6.1.3) (2026-10-16)
 
 ### Changed

package/README.md

@@ -31,7 +31,7 @@ history can't lose it. After you clear the conversation, switch hosts, or hand
 the feature to another engineer, the next session reads the same plan,
 decisions, and evidence before it continues.
 
-**Status:** [`v6.1.3`](https://github.com/ViktorsBaikers/DevRites/releases/tag/v6.1.3): see [`CHANGELOG.md`](CHANGELOG.md) for release notes.
+**Status:** [`v6.1.5`](https://github.com/ViktorsBaikers/DevRites/releases/tag/v6.1.5): see [`CHANGELOG.md`](CHANGELOG.md) for release notes.
 
 This is the latest published release; `main` may contain unreleased work.
 

package/engine/internal/lib/claims.go

@@ -55,6 +55,9 @@ type claimRecord struct {
 	// so a later session can prove that holder exited (see holderProbe).
 	Host    string      `json:"host,omitempty"`
 	Anchors []claimProc `json:"anchors,omitempty"`
+	// Holder is the anchor that is the claiming agent session itself; its
+	// exit releases the claim even while the shell that launched it lives.
+	Holder *claimProc `json:"holder,omitempty"`
 }
 
 // RunClaim manages the advisory file-claim ledger.
@@ -318,6 +321,7 @@ func claimAddLocked(path, session, reason string, ttl int, paths []string, stdou
 		ExpiresAt: now.Add(time.Duration(ttl) * time.Minute).Format(time.RFC3339),
 		Host:      probe.host,
 		Anchors:   probe.anchors(now),
+		Holder:    probe.holder(now),
 	}
 	if err := appendClaim(path, rec); err != nil {
 		fmt.Fprintf(stderr, "claim: %v\n", err)

package/engine/internal/lib/claims_holder.go

@@ -3,6 +3,7 @@ package lib
 import (
 	"os"
 	"os/exec"
+	"path/filepath"
 	"slices"
 	"strconv"
 	"strings"
@@ -23,6 +24,14 @@ type claimProc struct {
 type procInfo struct {
 	ppid  int
 	start string
+	comm  string
+}
+
+// shells outlive the agent sessions they launch (a terminal pane, a
+// multiplexer's login shell), so a shell never stands for the holder.
+var shells = map[string]bool{
+	"sh": true, "bash": true, "zsh": true, "fish": true, "dash": true, "ksh": true,
+	"tcsh": true, "csh": true, "nu": true, "pwsh": true, "powershell": true, "cmd": true,
 }
 
 // processTable lists running processes keyed by pid, or nil when the host
@@ -30,7 +39,7 @@ type procInfo struct {
 var processTable = psProcessTable
 
 func psProcessTable() map[int]procInfo {
-	cmd := exec.Command("ps", "-A", "-o", "pid=,ppid=,lstart=")
+	cmd := exec.Command("ps", "-A", "-o", "pid=,ppid=,lstart=,comm=")
 	cmd.Env = append(os.Environ(), "LC_ALL=C")
 	out, err := cmd.Output()
 	if err != nil {
@@ -39,16 +48,16 @@ func psProcessTable() map[int]procInfo {
 	table := map[int]procInfo{}
 	for _, line := range strings.Split(string(out), "\n") {
 		f := strings.Fields(line)
-		if len(f) != 7 {
+		if len(f) < 8 {
 			continue
 		}
 		pid, perr := strconv.Atoi(f[0])
 		ppid, pperr := strconv.Atoi(f[1])
-		start, serr := time.ParseInLocation("Mon Jan 2 15:04:05 2006", strings.Join(f[2:], " "), time.Local)
+		start, serr := time.ParseInLocation("Mon Jan 2 15:04:05 2006", strings.Join(f[2:7], " "), time.Local)
 		if perr != nil || pperr != nil || serr != nil {
 			continue
 		}
-		table[pid] = procInfo{ppid: ppid, start: start.UTC().Format(time.RFC3339)}
+		table[pid] = procInfo{ppid: ppid, start: start.UTC().Format(time.RFC3339), comm: strings.Join(f[7:], " ")}
 	}
 	if len(table) == 0 {
 		return nil
@@ -99,12 +108,33 @@ func (p holderProbe) anchors(now time.Time) []claimProc {
 	return out
 }
 
+// holder returns the nearest anchor that is not a shell: the agent session
+// process that owns the claim. A shell or terminal multiplexer above it can
+// outlive the session, so only the session's own exit proves release.
+func (p holderProbe) holder(now time.Time) *claimProc {
+	for _, proc := range p.anchors(now) {
+		name := strings.TrimPrefix(filepath.Base(p.table[proc.PID].comm), "-")
+		if name != "" && !shells[name] {
+			return &proc
+		}
+	}
+	return nil
+}
+
 // gone reports whether rec's holder is proven exited: the claim was taken on
-// this host and every anchor it does not share with the caller has exited.
+// this host and its recorded holder session has exited, or, for a claim with
+// no recorded holder, every anchor it does not share with the caller has.
 func (p holderProbe) gone(rec *claimRecord) bool {
 	if p.table == nil || rec.Host == "" || rec.Host != p.host {
 		return false
 	}
+	if h := rec.Holder; h != nil {
+		if slices.Contains(p.self, *h) {
+			return false
+		}
+		proc, ok := p.table[h.PID]
+		return !ok || proc.start != h.Start
+	}
 	unique := 0
 	for _, a := range rec.Anchors {
 		if slices.Contains(p.self, a) {

package/engine/internal/lib/dispatch.go

@@ -441,6 +441,9 @@ func admitWrightRounds(root, slug string, f *dispatchFile, w *dispatchWave, revi
 			lines = append(lines, fmt.Sprintf("dispatch: WARNING: %s earlier wave(s) %s never returned; record `dispatch return` or `dispatch abandon --reason`", id, strings.Join(unreturned, ",")))
 		}
 	}
+	if kind == "wright" {
+		lines = append(lines, "dispatch: wright contract: name the writer-safe checks the wright runs (syntax/type/lint, unit and self-check suites, a narrow local smoke) and never forbid them; only artifact-producing, consumptive, or full canonical gates stay root-owned")
+	}
 	if len(overCap) == 0 {
 		if review != "" {
 			fmt.Fprintf(stderr, "dispatch: --reslice-review given but no slice has reached its %d-round cap\n", wrightRoundsPerReview)

package/pack/.claude/agents/devrites-slice-wright.md

@@ -106,8 +106,11 @@ unclear boundary is underspecified: return `Escalation` without proceeding.
 4. **VERIFY (fail-on-red).** Run writer-safe tests/types/lint: `Tests/proof` plus
    tests of changed code; `## Feature gates` rows are root-owned. Writer-safe means
    local and non-consumptive — syntax/type/lint, unit and self-check suites, and a
-   narrow smoke of the changed path — never only a syntax check; contract text
-   cannot strip it. Report required
+   narrow smoke of the changed path — never only a syntax check. Task text that
+   says to skip tests, run nothing, or leave all proof to the root does not waive
+   this: run the writer-safe checks anyway, report them under `gates`, and add
+   `contract_conflict: writer-safe checks run` to `follow_ups`. Only
+   artifact-producing or consumptive commands stay excluded. Report required
    build/browser/E2E as `not-run` (root-owned, artifact-producing gates), and only
    when the exact command, cwd, and prerequisites already appear in the unchanged
    vetted `test-plan.md`; never synthesize or rewrite a root command. Root runs

package/pack/.claude/skills/rite-build/SKILL.md

@@ -27,6 +27,12 @@ Execute [`reference/phase-contract.md`](reference/phase-contract.md)
 ([`one-slice-cycle.md`](reference/one-slice-cycle.md),
 [`afk-discipline.md`](reference/afk-discipline.md)); dispatch uses
 [`reference/wright-dispatch.md`](reference/wright-dispatch.md).
+Every wright contract names the writer-safe checks the wright runs (syntax/type/lint,
+unit and self-check suites, a narrow local smoke) and never forbids them; only
+artifact-producing, consumptive, or full canonical gates stay root-owned.
+Prior contracts in `evidence.md` are not a template for this. **Failing case:** the
+contract says "skip tests mid-flight; root runs them after return", and the wright
+returns three unit failures that a 20 s `go test` would have caught in-round.
 
 ## Required rules
 

package/pack/generated/claude/agents/devrites-slice-wright.md

@@ -106,8 +106,11 @@ unclear boundary is underspecified: return `Escalation` without proceeding.
 4. **VERIFY (fail-on-red).** Run writer-safe tests/types/lint: `Tests/proof` plus
    tests of changed code; `## Feature gates` rows are root-owned. Writer-safe means
    local and non-consumptive — syntax/type/lint, unit and self-check suites, and a
-   narrow smoke of the changed path — never only a syntax check; contract text
-   cannot strip it. Report required
+   narrow smoke of the changed path — never only a syntax check. Task text that
+   says to skip tests, run nothing, or leave all proof to the root does not waive
+   this: run the writer-safe checks anyway, report them under `gates`, and add
+   `contract_conflict: writer-safe checks run` to `follow_ups`. Only
+   artifact-producing or consumptive commands stay excluded. Report required
    build/browser/E2E as `not-run` (root-owned, artifact-producing gates), and only
    when the exact command, cwd, and prerequisites already appear in the unchanged
    vetted `test-plan.md`; never synthesize or rewrite a root command. Root runs

package/pack/generated/claude/skills/rite-build/SKILL.md

@@ -27,6 +27,12 @@ Execute [`reference/phase-contract.md`](reference/phase-contract.md)
 ([`one-slice-cycle.md`](reference/one-slice-cycle.md),
 [`afk-discipline.md`](reference/afk-discipline.md)); dispatch uses
 [`reference/wright-dispatch.md`](reference/wright-dispatch.md).
+Every wright contract names the writer-safe checks the wright runs (syntax/type/lint,
+unit and self-check suites, a narrow local smoke) and never forbids them; only
+artifact-producing, consumptive, or full canonical gates stay root-owned.
+Prior contracts in `evidence.md` are not a template for this. **Failing case:** the
+contract says "skip tests mid-flight; root runs them after return", and the wright
+returns three unit failures that a 20 s `go test` would have caught in-round.
 
 ## Required rules
 

package/pack/generated/codex/agents/devrites-slice-wright.toml

@@ -104,8 +104,11 @@ unclear boundary is underspecified: return `Escalation` without proceeding.
 4. **VERIFY (fail-on-red).** Run writer-safe tests/types/lint: `Tests/proof` plus
    tests of changed code; `## Feature gates` rows are root-owned. Writer-safe means
    local and non-consumptive — syntax/type/lint, unit and self-check suites, and a
-   narrow smoke of the changed path — never only a syntax check; contract text
-   cannot strip it. Report required
+   narrow smoke of the changed path — never only a syntax check. spawn_agent text that
+   says to skip tests, run nothing, or leave all proof to the root does not waive
+   this: run the writer-safe checks anyway, report them under `gates`, and add
+   `contract_conflict: writer-safe checks run` to `follow_ups`. Only
+   artifact-producing or consumptive commands stay excluded. Report required
    build/browser/E2E as `not-run` (root-owned, artifact-producing gates), and only
    when the exact command, cwd, and prerequisites already appear in the unchanged
    vetted `test-plan.md`; never synthesize or rewrite a root command. Root runs

package/pack/generated/codex/skills/rite-build/SKILL.md

@@ -27,6 +27,12 @@ Execute [`reference/phase-contract.md`](reference/phase-contract.md)
 ([`one-slice-cycle.md`](reference/one-slice-cycle.md),
 [`afk-discipline.md`](reference/afk-discipline.md)); dispatch uses
 [`reference/wright-dispatch.md`](reference/wright-dispatch.md).
+Every wright contract names the writer-safe checks the wright runs (syntax/type/lint,
+unit and self-check suites, a narrow local smoke) and never forbids them; only
+artifact-producing, consumptive, or full canonical gates stay root-owned.
+Prior contracts in `evidence.md` are not a template for this. **Failing case:** the
+contract says "skip tests mid-flight; root runs them after return", and the wright
+returns three unit failures that a 20 s `go test` would have caught in-round.
 
 ## Required rules
 

package/pack/generated/devin/agents/devrites-slice-wright.md

@@ -111,8 +111,11 @@ unclear boundary is underspecified: return `Escalation` without proceeding.
 4. **VERIFY (fail-on-red).** Run writer-safe tests/types/lint: `Tests/proof` plus
    tests of changed code; `## Feature gates` rows are root-owned. Writer-safe means
    local and non-consumptive — syntax/type/lint, unit and self-check suites, and a
-   narrow smoke of the changed path — never only a syntax check; contract text
-   cannot strip it. Report required
+   narrow smoke of the changed path — never only a syntax check. Task text that
+   says to skip tests, run nothing, or leave all proof to the root does not waive
+   this: run the writer-safe checks anyway, report them under `gates`, and add
+   `contract_conflict: writer-safe checks run` to `follow_ups`. Only
+   artifact-producing or consumptive commands stay excluded. Report required
    build/browser/E2E as `not-run` (root-owned, artifact-producing gates), and only
    when the exact command, cwd, and prerequisites already appear in the unchanged
    vetted `test-plan.md`; never synthesize or rewrite a root command. Root runs

package/pack/generated/devin/skills/rite-build/SKILL.md

@@ -26,6 +26,12 @@ Execute [`reference/phase-contract.md`](reference/phase-contract.md)
 ([`one-slice-cycle.md`](reference/one-slice-cycle.md),
 [`afk-discipline.md`](reference/afk-discipline.md)); dispatch uses
 [`reference/wright-dispatch.md`](reference/wright-dispatch.md).
+Every wright contract names the writer-safe checks the wright runs (syntax/type/lint,
+unit and self-check suites, a narrow local smoke) and never forbids them; only
+artifact-producing, consumptive, or full canonical gates stay root-owned.
+Prior contracts in `evidence.md` are not a template for this. **Failing case:** the
+contract says "skip tests mid-flight; root runs them after return", and the wright
+returns three unit failures that a 20 s `go test` would have caught in-round.
 
 ## Required rules
 

package/pack/generated/omp/agents/devrites-slice-wright.md

@@ -104,8 +104,11 @@ unclear boundary is underspecified: return `Escalation` without proceeding.
 4. **VERIFY (fail-on-red).** Run writer-safe tests/types/lint: `Tests/proof` plus
    tests of changed code; `## Feature gates` rows are root-owned. Writer-safe means
    local and non-consumptive — syntax/type/lint, unit and self-check suites, and a
-   narrow smoke of the changed path — never only a syntax check; contract text
-   cannot strip it. Report required
+   narrow smoke of the changed path — never only a syntax check. Task text that
+   says to skip tests, run nothing, or leave all proof to the root does not waive
+   this: run the writer-safe checks anyway, report them under `gates`, and add
+   `contract_conflict: writer-safe checks run` to `follow_ups`. Only
+   artifact-producing or consumptive commands stay excluded. Report required
    build/browser/E2E as `not-run` (root-owned, artifact-producing gates), and only
    when the exact command, cwd, and prerequisites already appear in the unchanged
    vetted `test-plan.md`; never synthesize or rewrite a root command. Root runs

package/pack/generated/omp/skills/rite-build/SKILL.md

@@ -27,6 +27,12 @@ Execute [`reference/phase-contract.md`](reference/phase-contract.md)
 ([`one-slice-cycle.md`](reference/one-slice-cycle.md),
 [`afk-discipline.md`](reference/afk-discipline.md)); dispatch uses
 [`reference/wright-dispatch.md`](reference/wright-dispatch.md).
+Every wright contract names the writer-safe checks the wright runs (syntax/type/lint,
+unit and self-check suites, a narrow local smoke) and never forbids them; only
+artifact-producing, consumptive, or full canonical gates stay root-owned.
+Prior contracts in `evidence.md` are not a template for this. **Failing case:** the
+contract says "skip tests mid-flight; root runs them after return", and the wright
+returns three unit failures that a 20 s `go test` would have caught in-round.
 
 ## Required rules
 

package/pack/generated/pi/agents/devrites-slice-wright.md

@@ -105,8 +105,11 @@ unclear boundary is underspecified: return `Escalation` without proceeding.
 4. **VERIFY (fail-on-red).** Run writer-safe tests/types/lint: `Tests/proof` plus
    tests of changed code; `## Feature gates` rows are root-owned. Writer-safe means
    local and non-consumptive — syntax/type/lint, unit and self-check suites, and a
-   narrow smoke of the changed path — never only a syntax check; contract text
-   cannot strip it. Report required
+   narrow smoke of the changed path — never only a syntax check. Task text that
+   says to skip tests, run nothing, or leave all proof to the root does not waive
+   this: run the writer-safe checks anyway, report them under `gates`, and add
+   `contract_conflict: writer-safe checks run` to `follow_ups`. Only
+   artifact-producing or consumptive commands stay excluded. Report required
    build/browser/E2E as `not-run` (root-owned, artifact-producing gates), and only
    when the exact command, cwd, and prerequisites already appear in the unchanged
    vetted `test-plan.md`; never synthesize or rewrite a root command. Root runs

package/pack/generated/pi/skills/rite-build/SKILL.md

@@ -27,6 +27,12 @@ Execute [`reference/phase-contract.md`](reference/phase-contract.md)
 ([`one-slice-cycle.md`](reference/one-slice-cycle.md),
 [`afk-discipline.md`](reference/afk-discipline.md)); dispatch uses
 [`reference/wright-dispatch.md`](reference/wright-dispatch.md).
+Every wright contract names the writer-safe checks the wright runs (syntax/type/lint,
+unit and self-check suites, a narrow local smoke) and never forbids them; only
+artifact-producing, consumptive, or full canonical gates stay root-owned.
+Prior contracts in `evidence.md` are not a template for this. **Failing case:** the
+contract says "skip tests mid-flight; root runs them after return", and the wright
+returns three unit failures that a 20 s `go test` would have caught in-round.
 
 ## Required rules
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "devrites",
-  "version": "6.1.3",
+  "version": "6.1.5",
   "description": "DevRites: a disciplined senior-engineer workflow pack for Claude Code, Codex, omp, pi, and Devin CLI",
   "license": "SEE LICENSE IN LICENSE",
   "homepage": "https://github.com/ViktorsBaikers/DevRites#readme",