devrites 6.0.3 → 6.1.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +12 -0
- package/README.md +24 -9
- package/SECURITY.md +9 -6
- package/bin/devrites.mjs +28 -12
- package/docs/adr/0035-claude-root-leaves-plan-mode.md +33 -0
- package/docs/adr/0036-archive-recall-is-a-read-time-query.md +32 -0
- package/docs/adr/README.md +4 -2
- package/docs/cli.md +25 -2
- package/docs/command-map.md +10 -8
- package/docs/engine/commands.md +10 -7
- package/docs/harness-compliance.md +2 -2
- package/docs/orchestration.md +5 -4
- package/docs/release.md +4 -4
- package/docs/skills.md +2 -2
- package/engine/commands.go +1 -1
- package/engine/help.go +10 -6
- package/engine/internal/acceptance/cli.go +4 -1
- package/engine/internal/acceptance/exec.go +11 -11
- package/engine/internal/devritespaths/paths.go +5 -0
- package/engine/internal/hostpack/hostpack.go +48 -3
- package/engine/internal/install/apply.go +68 -1
- package/engine/internal/install/binary.go +4 -0
- package/engine/internal/install/install.go +25 -15
- package/engine/internal/install/merge.go +287 -123
- package/engine/internal/install/preflight.go +71 -1
- package/engine/internal/install/uninstall.go +7 -1
- package/engine/internal/install/update.go +7 -3
- package/engine/internal/lib/claims.go +30 -14
- package/engine/internal/lib/cli_observe.go +6 -0
- package/engine/internal/lib/context.go +35 -12
- package/engine/internal/lib/diffscope.go +79 -3
- package/engine/internal/lib/dispatch.go +78 -12
- package/engine/internal/lib/drift.go +9 -2
- package/engine/internal/lib/handoff.go +14 -5
- package/engine/internal/lib/metrics.go +103 -10
- package/engine/internal/lib/migrate.go +30 -12
- package/engine/internal/lib/next.go +22 -2
- package/engine/internal/lib/observe_summary.go +8 -0
- package/engine/internal/lib/open_visual.go +3 -1
- package/engine/internal/lib/recall.go +355 -0
- package/engine/internal/lib/regression.go +20 -0
- package/engine/internal/lib/resolve.go +96 -53
- package/engine/internal/lib/secretscan.go +24 -1
- package/engine/internal/lib/taskgraph.go +31 -1
- package/engine/internal/lib/util.go +18 -7
- package/engine/internal/lib/windows.go +68 -15
- package/engine/internal/markdowntext/markdowntext.go +45 -6
- package/engine/internal/notes/cli.go +5 -3
- package/engine/internal/notes/notes.go +8 -3
- package/engine/internal/overhaul/admit/run.go +16 -12
- package/engine/internal/overhaul/overhaul.go +1 -0
- package/engine/internal/overhaul/records/check.go +52 -9
- package/engine/internal/overhaul/render/run.go +3 -2
- package/engine/internal/overhaul/snapshot/run.go +2 -2
- package/engine/internal/parallel/git.go +5 -6
- package/engine/internal/parallel/ops.go +3 -0
- package/engine/internal/parallel/pathdisjoint.go +9 -4
- package/engine/internal/release/release.go +11 -9
- package/engine/internal/safepath/safepath.go +17 -1
- package/engine/internal/state/budgets.go +8 -4
- package/engine/internal/state/feature.go +3 -1
- package/engine/internal/state/observation.go +12 -7
- package/engine/internal/state/taskgraph.go +67 -12
- package/engine/internal/state/write.go +7 -1
- package/engine/main.go +6 -2
- package/pack/.claude/agents/_shared/composition-overhaul.md +2 -0
- package/pack/.claude/agents/devrites-devex-reviewer.md +5 -0
- package/pack/.claude/agents/devrites-evidence-scout.md +4 -0
- package/pack/.claude/agents/devrites-plan-reviewer.md +4 -1
- package/pack/.claude/agents/devrites-slice-wright.md +4 -1
- package/pack/.claude/agents/overhaul-implementer.md +1 -0
- package/pack/.claude/settings.json +4 -4
- package/pack/.claude/skills/devrites-api-interface/SKILL.md +1 -1
- package/pack/.claude/skills/devrites-audit/SKILL.md +1 -1
- package/pack/.claude/skills/devrites-browser-proof/SKILL.md +1 -1
- package/pack/.claude/skills/devrites-debug-recovery/SKILL.md +3 -2
- package/pack/.claude/skills/devrites-doubt/SKILL.md +1 -1
- package/pack/.claude/skills/devrites-frontend-craft/SKILL.md +1 -1
- package/pack/.claude/skills/devrites-interview/SKILL.md +1 -1
- package/pack/.claude/skills/devrites-lib/reference/intent-map.md +3 -3
- package/pack/.claude/skills/devrites-lib/reference/parallel-dispatch.md +4 -3
- package/pack/.claude/skills/devrites-lib/reference/standards/afk-hitl.md +5 -4
- package/pack/.claude/skills/devrites-lib/reference/standards/ci-cd.md +2 -1
- package/pack/.claude/skills/devrites-lib/reference/standards/code-review.md +1 -1
- package/pack/.claude/skills/devrites-lib/reference/standards/data-integrity.md +4 -0
- package/pack/.claude/skills/devrites-lib/reference/standards/developer-experience.md +5 -0
- package/pack/.claude/skills/devrites-lib/reference/standards/loop-operations.md +3 -0
- package/pack/.claude/skills/devrites-lib/reference/standards/performance.md +2 -0
- package/pack/.claude/skills/devrites-lib/reference/standards/skill-authoring.md +13 -1
- package/pack/.claude/skills/devrites-lib/reference/standards/testing.md +13 -0
- package/pack/.claude/skills/devrites-lib/reference/workspace-artifact-schema.md +10 -6
- package/pack/.claude/skills/devrites-prose-craft/SKILL.md +1 -1
- package/pack/.claude/skills/devrites-source-driven/SKILL.md +1 -1
- package/pack/.claude/skills/devrites-ux-shape/SKILL.md +1 -1
- package/pack/.claude/skills/overhaul/references/orchestration.md +6 -2
- package/pack/.claude/skills/overhaul/references/records.md +8 -3
- package/pack/.claude/skills/rite/SKILL.md +4 -3
- package/pack/.claude/skills/rite/reference/menu.md +6 -5
- package/pack/.claude/skills/rite-adopt/SKILL.md +4 -3
- package/pack/.claude/skills/rite-autocomplete/SKILL.md +6 -5
- package/pack/.claude/skills/rite-autocomplete/reference/loop.md +2 -1
- package/pack/.claude/skills/rite-autocomplete/reference/stop-conditions.md +2 -1
- package/pack/.claude/skills/rite-build/reference/afk-discipline.md +3 -1
- package/pack/.claude/skills/rite-build/reference/output.md +1 -1
- package/pack/.claude/skills/rite-build/reference/phase-contract.md +2 -0
- package/pack/.claude/skills/rite-build/reference/wright-dispatch.md +19 -0
- package/pack/.claude/skills/rite-converge/SKILL.md +4 -3
- package/pack/.claude/skills/rite-customize/SKILL.md +1 -1
- package/pack/.claude/skills/rite-define/SKILL.md +3 -2
- package/pack/.claude/skills/rite-doctor/SKILL.md +12 -6
- package/pack/.claude/skills/rite-dogfood/SKILL.md +2 -2
- package/pack/.claude/skills/rite-explain/SKILL.md +1 -1
- package/pack/.claude/skills/rite-fast/SKILL.md +3 -1
- package/pack/.claude/skills/rite-handoff/SKILL.md +4 -3
- package/pack/.claude/skills/rite-learn/SKILL.md +2 -2
- package/pack/.claude/skills/rite-plan/reference/replan-and-repair.md +2 -0
- package/pack/.claude/skills/rite-plan/reference/slicing.md +3 -1
- package/pack/.claude/skills/rite-pov/SKILL.md +1 -1
- package/pack/.claude/skills/rite-pr-feedback/SKILL.md +5 -4
- package/pack/.claude/skills/rite-pressure-test/SKILL.md +7 -5
- package/pack/.claude/skills/rite-prototype/SKILL.md +1 -1
- package/pack/.claude/skills/rite-quick/SKILL.md +10 -5
- package/pack/.claude/skills/rite-resolve/SKILL.md +3 -3
- package/pack/.claude/skills/rite-resolve/reference/answer-protocol.md +4 -5
- package/pack/.claude/skills/rite-review/SKILL.md +2 -1
- package/pack/.claude/skills/rite-seal/SKILL.md +3 -3
- package/pack/.claude/skills/rite-seal/reference/go-no-go.md +2 -0
- package/pack/.claude/skills/rite-seal/reference/seal-template.md +5 -2
- package/pack/.claude/skills/rite-ship/reference/close-out.md +3 -2
- package/pack/.claude/skills/rite-spec/SKILL.md +4 -1
- package/pack/.claude/skills/rite-status/SKILL.md +1 -1
- package/pack/.claude/skills/rite-temper/reference/significance.md +2 -0
- package/pack/.claude/skills/rite-upgrade/SKILL.md +4 -2
- package/pack/.claude/skills/rite-vet/SKILL.md +3 -2
- package/pack/.claude/skills/rite-vet/reference/artifacts.md +1 -1
- package/pack/.claude/skills/rite-watch-pr/SKILL.md +1 -1
- package/pack/.claude/skills/rite-zoom-out/SKILL.md +1 -1
- package/pack/generated/claude/agents/devrites-devex-reviewer.md +5 -0
- package/pack/generated/claude/agents/devrites-evidence-scout.md +4 -0
- package/pack/generated/claude/agents/devrites-plan-reviewer.md +4 -1
- package/pack/generated/claude/agents/devrites-slice-wright.md +4 -1
- package/pack/generated/claude/agents/overhaul-backend-engineer.md +2 -0
- package/pack/generated/claude/agents/overhaul-boundary.md +2 -0
- package/pack/generated/claude/agents/overhaul-craft.md +2 -0
- package/pack/generated/claude/agents/overhaul-frontend-engineer.md +2 -0
- package/pack/generated/claude/agents/overhaul-implementer.md +3 -0
- package/pack/generated/claude/agents/overhaul-recon.md +2 -0
- package/pack/generated/claude/agents/overhaul-specialist.md +2 -0
- package/pack/generated/claude/agents/overhaul-verifier.md +2 -0
- package/pack/generated/claude/settings.json +4 -4
- package/pack/generated/claude/skills/devrites-api-interface/SKILL.md +1 -1
- package/pack/generated/claude/skills/devrites-audit/SKILL.md +1 -1
- package/pack/generated/claude/skills/devrites-browser-proof/SKILL.md +1 -1
- package/pack/generated/claude/skills/devrites-debug-recovery/SKILL.md +3 -2
- package/pack/generated/claude/skills/devrites-doubt/SKILL.md +1 -1
- package/pack/generated/claude/skills/devrites-frontend-craft/SKILL.md +1 -1
- package/pack/generated/claude/skills/devrites-interview/SKILL.md +1 -1
- package/pack/generated/claude/skills/devrites-lib/reference/intent-map.md +3 -3
- package/pack/generated/claude/skills/devrites-lib/reference/parallel-dispatch.md +4 -3
- package/pack/generated/claude/skills/devrites-lib/reference/standards/afk-hitl.md +5 -4
- package/pack/generated/claude/skills/devrites-lib/reference/standards/ci-cd.md +2 -1
- package/pack/generated/claude/skills/devrites-lib/reference/standards/code-review.md +1 -1
- package/pack/generated/claude/skills/devrites-lib/reference/standards/data-integrity.md +4 -0
- package/pack/generated/claude/skills/devrites-lib/reference/standards/developer-experience.md +5 -0
- package/pack/generated/claude/skills/devrites-lib/reference/standards/loop-operations.md +3 -0
- package/pack/generated/claude/skills/devrites-lib/reference/standards/performance.md +2 -0
- package/pack/generated/claude/skills/devrites-lib/reference/standards/skill-authoring.md +13 -1
- package/pack/generated/claude/skills/devrites-lib/reference/standards/testing.md +13 -0
- package/pack/generated/claude/skills/devrites-lib/reference/workspace-artifact-schema.md +10 -6
- package/pack/generated/claude/skills/devrites-prose-craft/SKILL.md +1 -1
- package/pack/generated/claude/skills/devrites-source-driven/SKILL.md +1 -1
- package/pack/generated/claude/skills/devrites-ux-shape/SKILL.md +1 -1
- package/pack/generated/claude/skills/overhaul/references/orchestration.md +6 -2
- package/pack/generated/claude/skills/overhaul/references/records.md +8 -3
- package/pack/generated/claude/skills/rite/SKILL.md +4 -3
- package/pack/generated/claude/skills/rite/reference/menu.md +6 -5
- package/pack/generated/claude/skills/rite-adopt/SKILL.md +4 -3
- package/pack/generated/claude/skills/rite-autocomplete/SKILL.md +6 -5
- package/pack/generated/claude/skills/rite-autocomplete/reference/loop.md +2 -1
- package/pack/generated/claude/skills/rite-autocomplete/reference/stop-conditions.md +2 -1
- package/pack/generated/claude/skills/rite-build/reference/afk-discipline.md +3 -1
- package/pack/generated/claude/skills/rite-build/reference/output.md +1 -1
- package/pack/generated/claude/skills/rite-build/reference/phase-contract.md +2 -0
- package/pack/generated/claude/skills/rite-build/reference/wright-dispatch.md +19 -0
- package/pack/generated/claude/skills/rite-converge/SKILL.md +4 -3
- package/pack/generated/claude/skills/rite-customize/SKILL.md +1 -1
- package/pack/generated/claude/skills/rite-define/SKILL.md +3 -2
- package/pack/generated/claude/skills/rite-doctor/SKILL.md +12 -6
- package/pack/generated/claude/skills/rite-dogfood/SKILL.md +2 -2
- package/pack/generated/claude/skills/rite-explain/SKILL.md +1 -1
- package/pack/generated/claude/skills/rite-fast/SKILL.md +3 -1
- package/pack/generated/claude/skills/rite-handoff/SKILL.md +4 -3
- package/pack/generated/claude/skills/rite-learn/SKILL.md +2 -2
- package/pack/generated/claude/skills/rite-plan/reference/replan-and-repair.md +2 -0
- package/pack/generated/claude/skills/rite-plan/reference/slicing.md +3 -1
- package/pack/generated/claude/skills/rite-pov/SKILL.md +1 -1
- package/pack/generated/claude/skills/rite-pr-feedback/SKILL.md +5 -4
- package/pack/generated/claude/skills/rite-pressure-test/SKILL.md +7 -5
- package/pack/generated/claude/skills/rite-prototype/SKILL.md +1 -1
- package/pack/generated/claude/skills/rite-quick/SKILL.md +10 -5
- package/pack/generated/claude/skills/rite-resolve/SKILL.md +3 -3
- package/pack/generated/claude/skills/rite-resolve/reference/answer-protocol.md +4 -5
- package/pack/generated/claude/skills/rite-review/SKILL.md +2 -1
- package/pack/generated/claude/skills/rite-seal/SKILL.md +3 -3
- package/pack/generated/claude/skills/rite-seal/reference/go-no-go.md +2 -0
- package/pack/generated/claude/skills/rite-seal/reference/seal-template.md +5 -2
- package/pack/generated/claude/skills/rite-ship/reference/close-out.md +3 -2
- package/pack/generated/claude/skills/rite-spec/SKILL.md +4 -1
- package/pack/generated/claude/skills/rite-status/SKILL.md +1 -1
- package/pack/generated/claude/skills/rite-temper/reference/significance.md +2 -0
- package/pack/generated/claude/skills/rite-upgrade/SKILL.md +4 -2
- package/pack/generated/claude/skills/rite-vet/SKILL.md +3 -2
- package/pack/generated/claude/skills/rite-vet/reference/artifacts.md +1 -1
- package/pack/generated/claude/skills/rite-watch-pr/SKILL.md +1 -1
- package/pack/generated/claude/skills/rite-zoom-out/SKILL.md +1 -1
- package/pack/generated/codex/agents/devrites-code-reviewer.toml +7 -7
- package/pack/generated/codex/agents/devrites-devex-reviewer.toml +6 -1
- package/pack/generated/codex/agents/devrites-evidence-scout.toml +4 -0
- package/pack/generated/codex/agents/devrites-frontend-reviewer.toml +1 -1
- package/pack/generated/codex/agents/devrites-plan-drafter.toml +3 -3
- package/pack/generated/codex/agents/devrites-plan-reviewer.toml +5 -2
- package/pack/generated/codex/agents/devrites-proof-runner.toml +2 -2
- package/pack/generated/codex/agents/devrites-security-auditor.toml +1 -1
- package/pack/generated/codex/agents/devrites-simplifier-reviewer.toml +1 -1
- package/pack/generated/codex/agents/devrites-slice-wright.toml +8 -5
- package/pack/generated/codex/agents/devrites-test-analyst.toml +5 -5
- package/pack/generated/codex/agents/devrites-upgrade-planner.toml +1 -1
- package/pack/generated/codex/agents/fast-builder.toml +3 -3
- package/pack/generated/codex/agents/fast-critic.toml +3 -3
- package/pack/generated/codex/agents/overhaul-backend-engineer.toml +2 -0
- package/pack/generated/codex/agents/overhaul-boundary.toml +2 -0
- package/pack/generated/codex/agents/overhaul-craft.toml +2 -0
- package/pack/generated/codex/agents/overhaul-frontend-engineer.toml +2 -0
- package/pack/generated/codex/agents/overhaul-implementer.toml +2 -0
- package/pack/generated/codex/agents/overhaul-recon.toml +2 -0
- package/pack/generated/codex/agents/overhaul-specialist.toml +2 -0
- package/pack/generated/codex/agents/overhaul-verifier.toml +2 -0
- package/pack/generated/codex/skills/devrites-api-interface/SKILL.md +1 -1
- package/pack/generated/codex/skills/devrites-audit/SKILL.md +1 -1
- package/pack/generated/codex/skills/devrites-browser-proof/SKILL.md +1 -1
- package/pack/generated/codex/skills/devrites-debug-recovery/SKILL.md +3 -2
- package/pack/generated/codex/skills/devrites-doubt/SKILL.md +1 -1
- package/pack/generated/codex/skills/devrites-frontend-craft/SKILL.md +1 -1
- package/pack/generated/codex/skills/devrites-interview/SKILL.md +1 -1
- package/pack/generated/codex/skills/devrites-lib/reference/intent-map.md +3 -3
- package/pack/generated/codex/skills/devrites-lib/reference/parallel-dispatch.md +6 -5
- package/pack/generated/codex/skills/devrites-lib/reference/standards/afk-hitl.md +5 -4
- package/pack/generated/codex/skills/devrites-lib/reference/standards/agents.md +1 -1
- package/pack/generated/codex/skills/devrites-lib/reference/standards/ci-cd.md +2 -1
- package/pack/generated/codex/skills/devrites-lib/reference/standards/code-review.md +1 -1
- package/pack/generated/codex/skills/devrites-lib/reference/standards/core.md +1 -1
- package/pack/generated/codex/skills/devrites-lib/reference/standards/data-integrity.md +4 -0
- package/pack/generated/codex/skills/devrites-lib/reference/standards/developer-experience.md +5 -0
- package/pack/generated/codex/skills/devrites-lib/reference/standards/loop-operations.md +3 -0
- package/pack/generated/codex/skills/devrites-lib/reference/standards/performance.md +2 -0
- package/pack/generated/codex/skills/devrites-lib/reference/standards/skill-authoring.md +13 -1
- package/pack/generated/codex/skills/devrites-lib/reference/standards/testing.md +13 -0
- package/pack/generated/codex/skills/devrites-lib/reference/workspace-artifact-schema.md +11 -7
- package/pack/generated/codex/skills/devrites-prose-craft/SKILL.md +1 -1
- package/pack/generated/codex/skills/devrites-source-driven/SKILL.md +1 -1
- package/pack/generated/codex/skills/devrites-ux-shape/SKILL.md +1 -1
- package/pack/generated/codex/skills/overhaul/SKILL.md +15 -15
- package/pack/generated/codex/skills/overhaul/references/audit-domains.md +2 -2
- package/pack/generated/codex/skills/overhaul/references/orchestration.md +11 -7
- package/pack/generated/codex/skills/overhaul/references/records.md +8 -3
- package/pack/generated/codex/skills/rite/SKILL.md +4 -3
- package/pack/generated/codex/skills/rite/reference/menu.md +6 -5
- package/pack/generated/codex/skills/rite-adopt/SKILL.md +4 -3
- package/pack/generated/codex/skills/rite-autocomplete/SKILL.md +7 -6
- package/pack/generated/codex/skills/rite-autocomplete/reference/loop.md +2 -1
- package/pack/generated/codex/skills/rite-autocomplete/reference/stop-conditions.md +2 -1
- package/pack/generated/codex/skills/rite-build/SKILL.md +2 -2
- package/pack/generated/codex/skills/rite-build/reference/afk-discipline.md +3 -1
- package/pack/generated/codex/skills/rite-build/reference/output.md +1 -1
- package/pack/generated/codex/skills/rite-build/reference/parallel-batch.md +1 -1
- package/pack/generated/codex/skills/rite-build/reference/phase-contract.md +2 -0
- package/pack/generated/codex/skills/rite-build/reference/wright-dispatch.md +20 -1
- package/pack/generated/codex/skills/rite-clarify/SKILL.md +1 -1
- package/pack/generated/codex/skills/rite-converge/SKILL.md +5 -4
- package/pack/generated/codex/skills/rite-customize/SKILL.md +1 -1
- package/pack/generated/codex/skills/rite-define/SKILL.md +4 -3
- package/pack/generated/codex/skills/rite-doctor/SKILL.md +12 -6
- package/pack/generated/codex/skills/rite-dogfood/SKILL.md +2 -2
- package/pack/generated/codex/skills/rite-explain/SKILL.md +1 -1
- package/pack/generated/codex/skills/rite-fast/SKILL.md +8 -6
- package/pack/generated/codex/skills/rite-frame/SKILL.md +1 -1
- package/pack/generated/codex/skills/rite-handoff/SKILL.md +4 -3
- package/pack/generated/codex/skills/rite-learn/SKILL.md +2 -2
- package/pack/generated/codex/skills/rite-plan/SKILL.md +1 -1
- package/pack/generated/codex/skills/rite-plan/reference/replan-and-repair.md +2 -0
- package/pack/generated/codex/skills/rite-plan/reference/slicing.md +3 -1
- package/pack/generated/codex/skills/rite-polish/SKILL.md +2 -2
- package/pack/generated/codex/skills/rite-pov/SKILL.md +1 -1
- package/pack/generated/codex/skills/rite-pr-feedback/SKILL.md +5 -4
- package/pack/generated/codex/skills/rite-pressure-test/SKILL.md +7 -5
- package/pack/generated/codex/skills/rite-prototype/SKILL.md +1 -1
- package/pack/generated/codex/skills/rite-prove/SKILL.md +1 -1
- package/pack/generated/codex/skills/rite-quick/SKILL.md +11 -6
- package/pack/generated/codex/skills/rite-resolve/SKILL.md +3 -3
- package/pack/generated/codex/skills/rite-resolve/reference/answer-protocol.md +4 -5
- package/pack/generated/codex/skills/rite-review/SKILL.md +3 -2
- package/pack/generated/codex/skills/rite-seal/SKILL.md +4 -4
- package/pack/generated/codex/skills/rite-seal/reference/go-no-go.md +2 -0
- package/pack/generated/codex/skills/rite-seal/reference/seal-template.md +5 -2
- package/pack/generated/codex/skills/rite-ship/SKILL.md +1 -1
- package/pack/generated/codex/skills/rite-ship/reference/close-out.md +3 -2
- package/pack/generated/codex/skills/rite-spec/SKILL.md +5 -2
- package/pack/generated/codex/skills/rite-status/SKILL.md +1 -1
- package/pack/generated/codex/skills/rite-temper/SKILL.md +2 -2
- package/pack/generated/codex/skills/rite-temper/reference/significance.md +2 -0
- package/pack/generated/codex/skills/rite-upgrade/SKILL.md +4 -2
- package/pack/generated/codex/skills/rite-vet/SKILL.md +4 -3
- package/pack/generated/codex/skills/rite-vet/reference/artifacts.md +1 -1
- package/pack/generated/codex/skills/rite-watch-pr/SKILL.md +1 -1
- package/pack/generated/codex/skills/rite-zoom-out/SKILL.md +1 -1
- package/pack/generated/devin/AGENTS.md +1 -1
- package/pack/generated/devin/agents/devrites-devex-reviewer.md +5 -0
- package/pack/generated/devin/agents/devrites-evidence-scout.md +4 -0
- package/pack/generated/devin/agents/devrites-plan-reviewer.md +4 -1
- package/pack/generated/devin/agents/devrites-slice-wright.md +4 -1
- package/pack/generated/devin/agents/overhaul-backend-engineer.md +2 -0
- package/pack/generated/devin/agents/overhaul-boundary.md +2 -0
- package/pack/generated/devin/agents/overhaul-craft.md +2 -0
- package/pack/generated/devin/agents/overhaul-frontend-engineer.md +2 -0
- package/pack/generated/devin/agents/overhaul-implementer.md +2 -0
- package/pack/generated/devin/agents/overhaul-recon.md +2 -0
- package/pack/generated/devin/agents/overhaul-specialist.md +2 -0
- package/pack/generated/devin/agents/overhaul-verifier.md +2 -0
- package/pack/generated/devin/skills/devrites-api-interface/SKILL.md +1 -1
- package/pack/generated/devin/skills/devrites-audit/SKILL.md +1 -1
- package/pack/generated/devin/skills/devrites-browser-proof/SKILL.md +1 -1
- package/pack/generated/devin/skills/devrites-debug-recovery/SKILL.md +3 -2
- package/pack/generated/devin/skills/devrites-doubt/SKILL.md +1 -1
- package/pack/generated/devin/skills/devrites-frontend-craft/SKILL.md +1 -1
- package/pack/generated/devin/skills/devrites-interview/SKILL.md +2 -2
- package/pack/generated/devin/skills/devrites-lib/reference/intent-map.md +3 -3
- package/pack/generated/devin/skills/devrites-lib/reference/parallel-dispatch.md +6 -5
- package/pack/generated/devin/skills/devrites-lib/reference/standards/afk-hitl.md +8 -7
- package/pack/generated/devin/skills/devrites-lib/reference/standards/agents.md +1 -1
- package/pack/generated/devin/skills/devrites-lib/reference/standards/ci-cd.md +2 -1
- package/pack/generated/devin/skills/devrites-lib/reference/standards/code-review.md +1 -1
- package/pack/generated/devin/skills/devrites-lib/reference/standards/core.md +1 -1
- package/pack/generated/devin/skills/devrites-lib/reference/standards/data-integrity.md +4 -0
- package/pack/generated/devin/skills/devrites-lib/reference/standards/developer-experience.md +5 -0
- package/pack/generated/devin/skills/devrites-lib/reference/standards/loop-operations.md +3 -0
- package/pack/generated/devin/skills/devrites-lib/reference/standards/performance.md +2 -0
- package/pack/generated/devin/skills/devrites-lib/reference/standards/skill-authoring.md +13 -1
- package/pack/generated/devin/skills/devrites-lib/reference/standards/testing.md +13 -0
- package/pack/generated/devin/skills/devrites-lib/reference/workspace-artifact-schema.md +11 -7
- package/pack/generated/devin/skills/devrites-prose-craft/SKILL.md +1 -1
- package/pack/generated/devin/skills/devrites-source-driven/SKILL.md +1 -1
- package/pack/generated/devin/skills/devrites-ux-shape/SKILL.md +1 -1
- package/pack/generated/devin/skills/overhaul/SKILL.md +15 -15
- package/pack/generated/devin/skills/overhaul/references/audit-domains.md +2 -2
- package/pack/generated/devin/skills/overhaul/references/orchestration.md +11 -7
- package/pack/generated/devin/skills/overhaul/references/records.md +8 -3
- package/pack/generated/devin/skills/rite/SKILL.md +4 -3
- package/pack/generated/devin/skills/rite/reference/menu.md +6 -5
- package/pack/generated/devin/skills/rite-adopt/SKILL.md +4 -3
- package/pack/generated/devin/skills/rite-autocomplete/SKILL.md +8 -7
- package/pack/generated/devin/skills/rite-autocomplete/reference/decision-policy.md +1 -1
- package/pack/generated/devin/skills/rite-autocomplete/reference/loop.md +2 -1
- package/pack/generated/devin/skills/rite-autocomplete/reference/stop-conditions.md +3 -2
- package/pack/generated/devin/skills/rite-build/SKILL.md +2 -2
- package/pack/generated/devin/skills/rite-build/reference/afk-discipline.md +3 -1
- package/pack/generated/devin/skills/rite-build/reference/checkpoint-protocol.md +2 -2
- package/pack/generated/devin/skills/rite-build/reference/output.md +1 -1
- package/pack/generated/devin/skills/rite-build/reference/parallel-batch.md +1 -1
- package/pack/generated/devin/skills/rite-build/reference/phase-contract.md +2 -0
- package/pack/generated/devin/skills/rite-build/reference/wright-dispatch.md +20 -1
- package/pack/generated/devin/skills/rite-clarify/SKILL.md +1 -1
- package/pack/generated/devin/skills/rite-converge/SKILL.md +5 -4
- package/pack/generated/devin/skills/rite-customize/SKILL.md +1 -1
- package/pack/generated/devin/skills/rite-define/SKILL.md +4 -3
- package/pack/generated/devin/skills/rite-doctor/SKILL.md +12 -6
- package/pack/generated/devin/skills/rite-dogfood/SKILL.md +2 -2
- package/pack/generated/devin/skills/rite-explain/SKILL.md +3 -3
- package/pack/generated/devin/skills/rite-explain/reference/intake.md +1 -1
- package/pack/generated/devin/skills/rite-fast/SKILL.md +8 -6
- package/pack/generated/devin/skills/rite-frame/SKILL.md +1 -1
- package/pack/generated/devin/skills/rite-handoff/SKILL.md +4 -3
- package/pack/generated/devin/skills/rite-learn/SKILL.md +2 -2
- package/pack/generated/devin/skills/rite-plan/SKILL.md +1 -1
- package/pack/generated/devin/skills/rite-plan/reference/replan-and-repair.md +2 -0
- package/pack/generated/devin/skills/rite-plan/reference/slicing.md +3 -1
- package/pack/generated/devin/skills/rite-polish/SKILL.md +2 -2
- package/pack/generated/devin/skills/rite-pov/SKILL.md +1 -1
- package/pack/generated/devin/skills/rite-pr-feedback/SKILL.md +5 -4
- package/pack/generated/devin/skills/rite-pressure-test/SKILL.md +7 -5
- package/pack/generated/devin/skills/rite-prototype/SKILL.md +1 -1
- package/pack/generated/devin/skills/rite-prove/SKILL.md +1 -1
- package/pack/generated/devin/skills/rite-quick/SKILL.md +11 -6
- package/pack/generated/devin/skills/rite-resolve/SKILL.md +4 -4
- package/pack/generated/devin/skills/rite-resolve/reference/answer-protocol.md +4 -5
- package/pack/generated/devin/skills/rite-review/SKILL.md +3 -2
- package/pack/generated/devin/skills/rite-seal/SKILL.md +4 -4
- package/pack/generated/devin/skills/rite-seal/reference/go-no-go.md +2 -0
- package/pack/generated/devin/skills/rite-seal/reference/seal-template.md +5 -2
- package/pack/generated/devin/skills/rite-ship/SKILL.md +1 -1
- package/pack/generated/devin/skills/rite-ship/reference/close-out.md +3 -2
- package/pack/generated/devin/skills/rite-spec/SKILL.md +5 -2
- package/pack/generated/devin/skills/rite-spec/reference/investigation.md +1 -1
- package/pack/generated/devin/skills/rite-status/SKILL.md +1 -1
- package/pack/generated/devin/skills/rite-temper/SKILL.md +3 -3
- package/pack/generated/devin/skills/rite-temper/reference/scope-modes.md +1 -1
- package/pack/generated/devin/skills/rite-temper/reference/significance.md +3 -1
- package/pack/generated/devin/skills/rite-upgrade/SKILL.md +4 -2
- package/pack/generated/devin/skills/rite-vet/SKILL.md +4 -3
- package/pack/generated/devin/skills/rite-vet/reference/artifacts.md +1 -1
- package/pack/generated/devin/skills/rite-vet/reference/review-axes.md +2 -2
- package/pack/generated/devin/skills/rite-watch-pr/SKILL.md +1 -1
- package/pack/generated/devin/skills/rite-zoom-out/SKILL.md +1 -1
- package/pack/generated/omp/agents/devrites-code-reviewer.md +7 -7
- package/pack/generated/omp/agents/devrites-devex-reviewer.md +6 -1
- package/pack/generated/omp/agents/devrites-evidence-scout.md +4 -0
- package/pack/generated/omp/agents/devrites-frontend-reviewer.md +1 -1
- package/pack/generated/omp/agents/devrites-plan-drafter.md +3 -3
- package/pack/generated/omp/agents/devrites-plan-reviewer.md +5 -2
- package/pack/generated/omp/agents/devrites-proof-runner.md +2 -2
- package/pack/generated/omp/agents/devrites-security-auditor.md +1 -1
- package/pack/generated/omp/agents/devrites-simplifier-reviewer.md +1 -1
- package/pack/generated/omp/agents/devrites-slice-wright.md +8 -5
- package/pack/generated/omp/agents/devrites-test-analyst.md +5 -5
- package/pack/generated/omp/agents/devrites-upgrade-planner.md +1 -1
- package/pack/generated/omp/agents/fast-builder.md +3 -3
- package/pack/generated/omp/agents/fast-critic.md +3 -3
- package/pack/generated/omp/agents/overhaul-backend-engineer.md +2 -0
- package/pack/generated/omp/agents/overhaul-boundary.md +2 -0
- package/pack/generated/omp/agents/overhaul-craft.md +2 -0
- package/pack/generated/omp/agents/overhaul-frontend-engineer.md +2 -0
- package/pack/generated/omp/agents/overhaul-implementer.md +2 -0
- package/pack/generated/omp/agents/overhaul-recon.md +2 -0
- package/pack/generated/omp/agents/overhaul-specialist.md +2 -0
- package/pack/generated/omp/agents/overhaul-verifier.md +2 -0
- package/pack/generated/omp/commands/rite-resolve.md +1 -1
- package/pack/generated/omp/skills/devrites-api-interface/SKILL.md +4 -4
- package/pack/generated/omp/skills/devrites-audit/SKILL.md +5 -5
- package/pack/generated/omp/skills/devrites-browser-proof/SKILL.md +5 -5
- package/pack/generated/omp/skills/devrites-browser-proof/reference/browser-performance.md +1 -1
- package/pack/generated/omp/skills/devrites-browser-proof/reference/visual-verdict.md +1 -1
- package/pack/generated/omp/skills/devrites-debug-recovery/SKILL.md +7 -6
- package/pack/generated/omp/skills/devrites-debug-recovery/reference/cleanup-and-classify.md +1 -1
- package/pack/generated/omp/skills/devrites-doubt/SKILL.md +6 -6
- package/pack/generated/omp/skills/devrites-frontend-craft/SKILL.md +3 -3
- package/pack/generated/omp/skills/devrites-frontend-craft/reference/craft.md +1 -1
- package/pack/generated/omp/skills/devrites-frontend-craft/reference/design-references.md +4 -4
- package/pack/generated/omp/skills/devrites-frontend-craft/reference/fullstack.md +1 -1
- package/pack/generated/omp/skills/devrites-frontend-craft/reference/quality-standards.md +8 -8
- package/pack/generated/omp/skills/devrites-frontend-craft/reference/reuse-first.md +2 -2
- package/pack/generated/omp/skills/devrites-frontend-craft/reference/shape.md +2 -2
- package/pack/generated/omp/skills/devrites-interview/SKILL.md +3 -3
- package/pack/generated/omp/skills/devrites-lib/reference/intent-map.md +4 -4
- package/pack/generated/omp/skills/devrites-lib/reference/parallel-dispatch.md +8 -7
- package/pack/generated/omp/skills/devrites-lib/reference/standards/afk-hitl.md +13 -12
- package/pack/generated/omp/skills/devrites-lib/reference/standards/agents.md +6 -6
- package/pack/generated/omp/skills/devrites-lib/reference/standards/browser-proof-checklist.md +2 -2
- package/pack/generated/omp/skills/devrites-lib/reference/standards/ci-cd.md +2 -1
- package/pack/generated/omp/skills/devrites-lib/reference/standards/code-review.md +3 -3
- package/pack/generated/omp/skills/devrites-lib/reference/standards/coding-style.md +1 -1
- package/pack/generated/omp/skills/devrites-lib/reference/standards/context-hygiene.md +2 -2
- package/pack/generated/omp/skills/devrites-lib/reference/standards/core.md +3 -3
- package/pack/generated/omp/skills/devrites-lib/reference/standards/data-integrity.md +4 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/debug-recovery.md +1 -1
- package/pack/generated/omp/skills/devrites-lib/reference/standards/definition-of-done.md +1 -1
- package/pack/generated/omp/skills/devrites-lib/reference/standards/developer-experience.md +8 -3
- package/pack/generated/omp/skills/devrites-lib/reference/standards/glossary.md +3 -3
- package/pack/generated/omp/skills/devrites-lib/reference/standards/loop-operations.md +3 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/performance.md +3 -1
- package/pack/generated/omp/skills/devrites-lib/reference/standards/prose-style.md +4 -4
- package/pack/generated/omp/skills/devrites-lib/reference/standards/release/ship-checklist.md +1 -1
- package/pack/generated/omp/skills/devrites-lib/reference/standards/review/README.md +1 -1
- package/pack/generated/omp/skills/devrites-lib/reference/standards/review/ci-workflows.md +1 -1
- package/pack/generated/omp/skills/devrites-lib/reference/standards/review/react.md +1 -1
- package/pack/generated/omp/skills/devrites-lib/reference/standards/review/stack-profile.md +5 -5
- package/pack/generated/omp/skills/devrites-lib/reference/standards/skill-authoring.md +15 -3
- package/pack/generated/omp/skills/devrites-lib/reference/standards/spec-grammar.md +3 -3
- package/pack/generated/omp/skills/devrites-lib/reference/standards/testing.md +14 -1
- package/pack/generated/omp/skills/devrites-lib/reference/standards/tooling.md +1 -1
- package/pack/generated/omp/skills/devrites-lib/reference/standards/verification-methods.md +1 -1
- package/pack/generated/omp/skills/devrites-lib/reference/visual-playbooks/index.md +2 -2
- package/pack/generated/omp/skills/devrites-lib/reference/workspace-artifact-schema.md +12 -8
- package/pack/generated/omp/skills/devrites-prose-craft/SKILL.md +4 -4
- package/pack/generated/omp/skills/devrites-prose-craft/reference/examples.md +1 -1
- package/pack/generated/omp/skills/devrites-source-driven/SKILL.md +3 -3
- package/pack/generated/omp/skills/devrites-ux-shape/SKILL.md +10 -10
- package/pack/generated/omp/skills/devrites-ux-shape/reference/brief-template.md +3 -3
- package/pack/generated/omp/skills/devrites-ux-shape/reference/visual-direction-probe.md +1 -1
- package/pack/generated/omp/skills/overhaul/references/orchestration.md +6 -2
- package/pack/generated/omp/skills/overhaul/references/records.md +8 -3
- package/pack/generated/omp/skills/rite/SKILL.md +8 -7
- package/pack/generated/omp/skills/rite/reference/menu.md +6 -5
- package/pack/generated/omp/skills/rite-adopt/SKILL.md +6 -5
- package/pack/generated/omp/skills/rite-adopt/reference/anti-patterns.md +1 -1
- package/pack/generated/omp/skills/rite-autocomplete/SKILL.md +11 -10
- package/pack/generated/omp/skills/rite-autocomplete/reference/decision-policy.md +1 -1
- package/pack/generated/omp/skills/rite-autocomplete/reference/loop.md +4 -3
- package/pack/generated/omp/skills/rite-autocomplete/reference/stop-conditions.md +2 -1
- package/pack/generated/omp/skills/rite-build/SKILL.md +7 -7
- package/pack/generated/omp/skills/rite-build/reference/afk-discipline.md +4 -2
- package/pack/generated/omp/skills/rite-build/reference/anti-patterns.md +1 -1
- package/pack/generated/omp/skills/rite-build/reference/checkpoint-protocol.md +2 -2
- package/pack/generated/omp/skills/rite-build/reference/checkpoint.md +2 -2
- package/pack/generated/omp/skills/rite-build/reference/frontend-trigger.md +1 -1
- package/pack/generated/omp/skills/rite-build/reference/output.md +1 -1
- package/pack/generated/omp/skills/rite-build/reference/parallel-batch.md +4 -4
- package/pack/generated/omp/skills/rite-build/reference/phase-contract.md +8 -6
- package/pack/generated/omp/skills/rite-build/reference/tdd.md +1 -1
- package/pack/generated/omp/skills/rite-build/reference/wright-dispatch.md +27 -8
- package/pack/generated/omp/skills/rite-clarify/SKILL.md +4 -4
- package/pack/generated/omp/skills/rite-clarify/reference/anti-patterns.md +1 -1
- package/pack/generated/omp/skills/rite-converge/SKILL.md +16 -15
- package/pack/generated/omp/skills/rite-converge/reference/convergence-assessment.md +4 -4
- package/pack/generated/omp/skills/rite-customize/SKILL.md +2 -2
- package/pack/generated/omp/skills/rite-define/SKILL.md +25 -24
- package/pack/generated/omp/skills/rite-define/reference/anti-patterns.md +2 -2
- package/pack/generated/omp/skills/rite-define/reference/gates.md +2 -2
- package/pack/generated/omp/skills/rite-doctor/SKILL.md +12 -6
- package/pack/generated/omp/skills/rite-dogfood/SKILL.md +5 -5
- package/pack/generated/omp/skills/rite-explain/SKILL.md +7 -7
- package/pack/generated/omp/skills/rite-explain/reference/intake.md +1 -1
- package/pack/generated/omp/skills/rite-fast/SKILL.md +12 -10
- package/pack/generated/omp/skills/rite-fast/reference/artifacts.md +1 -1
- package/pack/generated/omp/skills/rite-frame/SKILL.md +6 -6
- package/pack/generated/omp/skills/rite-frame/reference/failure-modes.md +4 -4
- package/pack/generated/omp/skills/rite-handoff/SKILL.md +7 -6
- package/pack/generated/omp/skills/rite-learn/SKILL.md +6 -6
- package/pack/generated/omp/skills/rite-plan/SKILL.md +8 -8
- package/pack/generated/omp/skills/rite-plan/reference/anti-patterns.md +1 -1
- package/pack/generated/omp/skills/rite-plan/reference/replan-and-repair.md +3 -1
- package/pack/generated/omp/skills/rite-plan/reference/slicing.md +6 -4
- package/pack/generated/omp/skills/rite-plan/reference/task-breakdown.md +1 -1
- package/pack/generated/omp/skills/rite-polish/SKILL.md +6 -6
- package/pack/generated/omp/skills/rite-polish/reference/anti-ai-slop.md +9 -9
- package/pack/generated/omp/skills/rite-polish/reference/anti-patterns.md +1 -1
- package/pack/generated/omp/skills/rite-polish/reference/backend-polish.md +2 -2
- package/pack/generated/omp/skills/rite-polish/reference/browser-polish-evidence.md +1 -1
- package/pack/generated/omp/skills/rite-polish/reference/code.md +8 -8
- package/pack/generated/omp/skills/rite-polish/reference/design-memory.md +3 -3
- package/pack/generated/omp/skills/rite-polish/reference/design-system-discovery.md +1 -1
- package/pack/generated/omp/skills/rite-polish/reference/harden-checklist.md +1 -1
- package/pack/generated/omp/skills/rite-polish/reference/ledger.md +3 -3
- package/pack/generated/omp/skills/rite-polish/reference/ui.md +1 -1
- package/pack/generated/omp/skills/rite-pov/SKILL.md +2 -2
- package/pack/generated/omp/skills/rite-pr-feedback/SKILL.md +6 -5
- package/pack/generated/omp/skills/rite-pressure-test/SKILL.md +9 -7
- package/pack/generated/omp/skills/rite-prototype/SKILL.md +1 -1
- package/pack/generated/omp/skills/rite-prove/SKILL.md +13 -13
- package/pack/generated/omp/skills/rite-prove/reference/acceptance-proof.md +7 -7
- package/pack/generated/omp/skills/rite-prove/reference/anti-patterns.md +1 -1
- package/pack/generated/omp/skills/rite-prove/reference/browser-proof.md +3 -3
- package/pack/generated/omp/skills/rite-prove/reference/failure-triage.md +2 -2
- package/pack/generated/omp/skills/rite-quick/SKILL.md +19 -14
- package/pack/generated/omp/skills/rite-resolve/SKILL.md +6 -6
- package/pack/generated/omp/skills/rite-resolve/reference/answer-protocol.md +4 -5
- package/pack/generated/omp/skills/rite-review/SKILL.md +23 -22
- package/pack/generated/omp/skills/rite-review/reference/anti-patterns.md +1 -1
- package/pack/generated/omp/skills/rite-review/reference/cognitive-load.md +2 -2
- package/pack/generated/omp/skills/rite-review/reference/nielsen-heuristics.md +1 -1
- package/pack/generated/omp/skills/rite-review/reference/performance-checklist.md +1 -1
- package/pack/generated/omp/skills/rite-review/reference/performance-review.md +1 -1
- package/pack/generated/omp/skills/rite-review/reference/security-review.md +2 -2
- package/pack/generated/omp/skills/rite-seal/SKILL.md +11 -11
- package/pack/generated/omp/skills/rite-seal/reference/anti-patterns.md +1 -1
- package/pack/generated/omp/skills/rite-seal/reference/final-evidence.md +3 -3
- package/pack/generated/omp/skills/rite-seal/reference/go-no-go.md +3 -1
- package/pack/generated/omp/skills/rite-seal/reference/output.md +1 -1
- package/pack/generated/omp/skills/rite-seal/reference/phase-contract.md +4 -4
- package/pack/generated/omp/skills/rite-seal/reference/seal-template.md +5 -2
- package/pack/generated/omp/skills/rite-ship/SKILL.md +7 -7
- package/pack/generated/omp/skills/rite-ship/reference/anti-patterns.md +1 -1
- package/pack/generated/omp/skills/rite-ship/reference/close-out.md +5 -4
- package/pack/generated/omp/skills/rite-ship/reference/git-ship.md +2 -2
- package/pack/generated/omp/skills/rite-ship/reference/rollout.md +3 -3
- package/pack/generated/omp/skills/rite-spec/SKILL.md +17 -14
- package/pack/generated/omp/skills/rite-spec/reference/anti-patterns.md +1 -1
- package/pack/generated/omp/skills/rite-spec/reference/investigation.md +3 -3
- package/pack/generated/omp/skills/rite-spec/reference/question-protocol.md +1 -1
- package/pack/generated/omp/skills/rite-spec/reference/spec-template.md +2 -2
- package/pack/generated/omp/skills/rite-spec/reference/state-workspace.md +8 -8
- package/pack/generated/omp/skills/rite-status/SKILL.md +2 -2
- package/pack/generated/omp/skills/rite-temper/SKILL.md +13 -13
- package/pack/generated/omp/skills/rite-temper/reference/anti-patterns.md +2 -2
- package/pack/generated/omp/skills/rite-temper/reference/review-dimensions.md +3 -3
- package/pack/generated/omp/skills/rite-temper/reference/scope-modes.md +3 -3
- package/pack/generated/omp/skills/rite-temper/reference/significance.md +4 -2
- package/pack/generated/omp/skills/rite-upgrade/SKILL.md +7 -5
- package/pack/generated/omp/skills/rite-vet/SKILL.md +14 -13
- package/pack/generated/omp/skills/rite-vet/reference/anti-patterns.md +2 -2
- package/pack/generated/omp/skills/rite-vet/reference/artifacts.md +3 -3
- package/pack/generated/omp/skills/rite-vet/reference/depth.md +3 -3
- package/pack/generated/omp/skills/rite-vet/reference/review-axes.md +5 -5
- package/pack/generated/omp/skills/rite-watch-pr/SKILL.md +2 -2
- package/pack/generated/omp/skills/rite-zoom-out/SKILL.md +1 -1
- package/pack/generated/pi/agents/devrites-devex-reviewer.md +5 -0
- package/pack/generated/pi/agents/devrites-evidence-scout.md +4 -0
- package/pack/generated/pi/agents/devrites-plan-reviewer.md +4 -1
- package/pack/generated/pi/agents/devrites-slice-wright.md +4 -1
- package/pack/generated/pi/agents/overhaul-backend-engineer.md +2 -0
- package/pack/generated/pi/agents/overhaul-boundary.md +2 -0
- package/pack/generated/pi/agents/overhaul-craft.md +2 -0
- package/pack/generated/pi/agents/overhaul-frontend-engineer.md +2 -0
- package/pack/generated/pi/agents/overhaul-implementer.md +2 -0
- package/pack/generated/pi/agents/overhaul-recon.md +2 -0
- package/pack/generated/pi/agents/overhaul-specialist.md +2 -0
- package/pack/generated/pi/agents/overhaul-verifier.md +2 -0
- package/pack/generated/pi/prompts/rite-resolve.md +1 -1
- package/pack/generated/pi/skills/devrites-api-interface/SKILL.md +1 -1
- package/pack/generated/pi/skills/devrites-audit/SKILL.md +1 -1
- package/pack/generated/pi/skills/devrites-browser-proof/SKILL.md +1 -1
- package/pack/generated/pi/skills/devrites-debug-recovery/SKILL.md +3 -2
- package/pack/generated/pi/skills/devrites-doubt/SKILL.md +1 -1
- package/pack/generated/pi/skills/devrites-frontend-craft/SKILL.md +1 -1
- package/pack/generated/pi/skills/devrites-interview/SKILL.md +1 -1
- package/pack/generated/pi/skills/devrites-lib/reference/intent-map.md +3 -3
- package/pack/generated/pi/skills/devrites-lib/reference/parallel-dispatch.md +6 -5
- package/pack/generated/pi/skills/devrites-lib/reference/standards/afk-hitl.md +5 -4
- package/pack/generated/pi/skills/devrites-lib/reference/standards/agents.md +1 -1
- package/pack/generated/pi/skills/devrites-lib/reference/standards/ci-cd.md +2 -1
- package/pack/generated/pi/skills/devrites-lib/reference/standards/code-review.md +1 -1
- package/pack/generated/pi/skills/devrites-lib/reference/standards/core.md +1 -1
- package/pack/generated/pi/skills/devrites-lib/reference/standards/data-integrity.md +4 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/developer-experience.md +5 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/loop-operations.md +3 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/performance.md +2 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/skill-authoring.md +13 -1
- package/pack/generated/pi/skills/devrites-lib/reference/standards/testing.md +13 -0
- package/pack/generated/pi/skills/devrites-lib/reference/workspace-artifact-schema.md +11 -7
- package/pack/generated/pi/skills/devrites-prose-craft/SKILL.md +1 -1
- package/pack/generated/pi/skills/devrites-source-driven/SKILL.md +1 -1
- package/pack/generated/pi/skills/devrites-ux-shape/SKILL.md +1 -1
- package/pack/generated/pi/skills/overhaul/SKILL.md +15 -15
- package/pack/generated/pi/skills/overhaul/references/audit-domains.md +2 -2
- package/pack/generated/pi/skills/overhaul/references/orchestration.md +11 -7
- package/pack/generated/pi/skills/overhaul/references/records.md +8 -3
- package/pack/generated/pi/skills/rite/SKILL.md +4 -3
- package/pack/generated/pi/skills/rite/reference/menu.md +6 -5
- package/pack/generated/pi/skills/rite-adopt/SKILL.md +4 -3
- package/pack/generated/pi/skills/rite-autocomplete/SKILL.md +7 -6
- package/pack/generated/pi/skills/rite-autocomplete/reference/loop.md +2 -1
- package/pack/generated/pi/skills/rite-autocomplete/reference/stop-conditions.md +2 -1
- package/pack/generated/pi/skills/rite-build/SKILL.md +2 -2
- package/pack/generated/pi/skills/rite-build/reference/afk-discipline.md +3 -1
- package/pack/generated/pi/skills/rite-build/reference/output.md +1 -1
- package/pack/generated/pi/skills/rite-build/reference/parallel-batch.md +1 -1
- package/pack/generated/pi/skills/rite-build/reference/phase-contract.md +2 -0
- package/pack/generated/pi/skills/rite-build/reference/wright-dispatch.md +20 -1
- package/pack/generated/pi/skills/rite-clarify/SKILL.md +1 -1
- package/pack/generated/pi/skills/rite-converge/SKILL.md +5 -4
- package/pack/generated/pi/skills/rite-customize/SKILL.md +1 -1
- package/pack/generated/pi/skills/rite-define/SKILL.md +4 -3
- package/pack/generated/pi/skills/rite-doctor/SKILL.md +12 -6
- package/pack/generated/pi/skills/rite-dogfood/SKILL.md +2 -2
- package/pack/generated/pi/skills/rite-explain/SKILL.md +1 -1
- package/pack/generated/pi/skills/rite-fast/SKILL.md +8 -6
- package/pack/generated/pi/skills/rite-frame/SKILL.md +1 -1
- package/pack/generated/pi/skills/rite-handoff/SKILL.md +4 -3
- package/pack/generated/pi/skills/rite-learn/SKILL.md +2 -2
- package/pack/generated/pi/skills/rite-plan/SKILL.md +1 -1
- package/pack/generated/pi/skills/rite-plan/reference/replan-and-repair.md +2 -0
- package/pack/generated/pi/skills/rite-plan/reference/slicing.md +3 -1
- package/pack/generated/pi/skills/rite-polish/SKILL.md +2 -2
- package/pack/generated/pi/skills/rite-pov/SKILL.md +1 -1
- package/pack/generated/pi/skills/rite-pr-feedback/SKILL.md +5 -4
- package/pack/generated/pi/skills/rite-pressure-test/SKILL.md +7 -5
- package/pack/generated/pi/skills/rite-prototype/SKILL.md +1 -1
- package/pack/generated/pi/skills/rite-prove/SKILL.md +1 -1
- package/pack/generated/pi/skills/rite-quick/SKILL.md +11 -6
- package/pack/generated/pi/skills/rite-resolve/SKILL.md +3 -3
- package/pack/generated/pi/skills/rite-resolve/reference/answer-protocol.md +4 -5
- package/pack/generated/pi/skills/rite-review/SKILL.md +3 -2
- package/pack/generated/pi/skills/rite-seal/SKILL.md +4 -4
- package/pack/generated/pi/skills/rite-seal/reference/go-no-go.md +2 -0
- package/pack/generated/pi/skills/rite-seal/reference/seal-template.md +5 -2
- package/pack/generated/pi/skills/rite-ship/SKILL.md +1 -1
- package/pack/generated/pi/skills/rite-ship/reference/close-out.md +3 -2
- package/pack/generated/pi/skills/rite-spec/SKILL.md +5 -2
- package/pack/generated/pi/skills/rite-status/SKILL.md +1 -1
- package/pack/generated/pi/skills/rite-temper/SKILL.md +2 -2
- package/pack/generated/pi/skills/rite-temper/reference/significance.md +2 -0
- package/pack/generated/pi/skills/rite-upgrade/SKILL.md +4 -2
- package/pack/generated/pi/skills/rite-vet/SKILL.md +4 -3
- package/pack/generated/pi/skills/rite-vet/reference/artifacts.md +1 -1
- package/pack/generated/pi/skills/rite-watch-pr/SKILL.md +1 -1
- package/pack/generated/pi/skills/rite-zoom-out/SKILL.md +1 -1
- package/package.json +3 -2
- package/scripts/build-host-artifacts.sh +13 -0
- package/scripts/codex-generate.sh +5 -1
- package/scripts/devin-generate.sh +4 -3
- package/scripts/install-lib.sh +5 -0
- package/scripts/omp-generate.sh +23 -1
- package/scripts/pi-generate.sh +2 -2
- package/engine/cmd/releasepack/main_test.go +0 -239
- package/engine/harnessmatrix_test.go +0 -46
- package/engine/help_test.go +0 -241
- package/engine/internal/acceptance/acceptance_test.go +0 -946
- package/engine/internal/devritespaths/paths_test.go +0 -128
- package/engine/internal/fsutil/copy_test.go +0 -154
- package/engine/internal/gate/gate_test.go +0 -865
- package/engine/internal/gate/readiness_binding_test.go +0 -443
- package/engine/internal/gitenv/env_test.go +0 -48
- package/engine/internal/hostpack/hostpack_test.go +0 -269
- package/engine/internal/install/install_test.go +0 -1741
- package/engine/internal/install/workspace_advisory_test.go +0 -54
- package/engine/internal/lib/candidate_test.go +0 -506
- package/engine/internal/lib/claims_test.go +0 -267
- package/engine/internal/lib/closeout_test.go +0 -266
- package/engine/internal/lib/context_next_test.go +0 -860
- package/engine/internal/lib/cursor_compat_test.go +0 -65
- package/engine/internal/lib/detect_test.go +0 -118
- package/engine/internal/lib/drift_test.go +0 -135
- package/engine/internal/lib/dup_test.go +0 -666
- package/engine/internal/lib/environment_report_test.go +0 -54
- package/engine/internal/lib/evidencefresh_test.go +0 -120
- package/engine/internal/lib/handoff_test.go +0 -83
- package/engine/internal/lib/manifest_union_test.go +0 -251
- package/engine/internal/lib/metrics_test.go +0 -28
- package/engine/internal/lib/migrate_test.go +0 -213
- package/engine/internal/lib/observe_budgets_test.go +0 -396
- package/engine/internal/lib/open_visual_test.go +0 -291
- package/engine/internal/lib/regression_test.go +0 -282
- package/engine/internal/lib/resolve_remediation_test.go +0 -192
- package/engine/internal/lib/secretscan_test.go +0 -556
- package/engine/internal/lib/slicecheck_test.go +0 -170
- package/engine/internal/lib/taskgraph_test.go +0 -353
- package/engine/internal/lib/triggers_test.go +0 -23
- package/engine/internal/lib/util_test.go +0 -148
- package/engine/internal/lib/visual_outline_test.go +0 -189
- package/engine/internal/lib/windows_test.go +0 -420
- package/engine/internal/lib/workspace_read_test.go +0 -102
- package/engine/internal/markdowntext/markdowntext_fuzz_test.go +0 -36
- package/engine/internal/markdowntext/markdowntext_test.go +0 -58
- package/engine/internal/markdowntext/testdata/structural.json +0 -277
- package/engine/internal/notes/notes_test.go +0 -545
- package/engine/internal/overhaul/admit/admit_test.go +0 -204
- package/engine/internal/overhaul/admit/packet_test.go +0 -223
- package/engine/internal/overhaul/bench/run_test.go +0 -316
- package/engine/internal/overhaul/ovio/ovio_test.go +0 -75
- package/engine/internal/overhaul/packet/packet_test.go +0 -263
- package/engine/internal/overhaul/records/init_test.go +0 -96
- package/engine/internal/overhaul/records/records_test.go +0 -696
- package/engine/internal/overhaul/records/run_test.go +0 -77
- package/engine/internal/overhaul/render/run_test.go +0 -928
- package/engine/internal/overhaul/score/run_test.go +0 -636
- package/engine/internal/overhaul/snapshot/run_test.go +0 -718
- package/engine/internal/parallel/cli_test.go +0 -91
- package/engine/internal/parallel/ops_test.go +0 -939
- package/engine/internal/parallel/parallel_test.go +0 -645
- package/engine/internal/parallel/pathdisjoint_fuzz_test.go +0 -43
- package/engine/internal/parallel/pathdisjoint_test.go +0 -193
- package/engine/internal/parallel/select_test.go +0 -95
- package/engine/internal/parallel/testdata/fuzz/FuzzPathDisjoint/a449b81b4711b7b4 +0 -3
- package/engine/internal/reason/reason_test.go +0 -37
- package/engine/internal/release/release_test.go +0 -181
- package/engine/internal/rootfacts/facts_test.go +0 -364
- package/engine/internal/safepath/safepath_fuzz_test.go +0 -21
- package/engine/internal/safepath/safepath_test.go +0 -69
- package/engine/internal/safepath/safepath_windows_test.go +0 -26
- package/engine/internal/state/acceptance_test.go +0 -57
- package/engine/internal/state/budgets_test.go +0 -135
- package/engine/internal/state/cmd/workflowmanifest/main_test.go +0 -96
- package/engine/internal/state/concurrency_test.go +0 -184
- package/engine/internal/state/cursor_fuzz_test.go +0 -80
- package/engine/internal/state/cursor_test.go +0 -276
- package/engine/internal/state/observation_test.go +0 -961
- package/engine/internal/state/observation_unix_test.go +0 -68
- package/engine/internal/state/state_test.go +0 -986
- package/engine/internal/state/taskgraph_fuzz_test.go +0 -38
- package/engine/internal/state/taskgraph_test.go +0 -43
- package/engine/internal/state/testdata/fuzz/FuzzCursorRoundTrip/114b28f68c1fa4db +0 -4
- package/engine/internal/state/testdata/fuzz/FuzzCursorRoundTrip/378a0f2218e812ea +0 -4
- package/engine/internal/state/testdata/fuzz/FuzzCursorRoundTrip/39eaa26fcb481e3c +0 -4
- package/engine/internal/state/testdata/fuzz/FuzzCursorRoundTrip/776ca1dc0143acf0 +0 -4
- package/engine/internal/state/testdata/fuzz/FuzzCursorRoundTrip/9295930c1ebb81df +0 -4
- package/engine/internal/state/testdata/fuzz/FuzzCursorRoundTrip/a60de309dc33be0d +0 -4
- package/engine/internal/state/testdata/fuzz/FuzzCursorRoundTrip/f04dc7b06ef7c99f +0 -4
- package/engine/internal/state/testdata/fuzz/FuzzCursorRoundTrip/f3000ac510878bd6 +0 -4
- package/engine/internal/state/testdata/fuzz/FuzzWorkspaceSchemaRow/a75aabb9f2a847d5 +0 -2
- package/engine/internal/state/workspaceschema_fuzz_test.go +0 -27
- package/engine/internal/state/workspaceschema_test.go +0 -101
- package/engine/internal/state/write_test.go +0 -136
- package/engine/internal/version/version_test.go +0 -29
- package/engine/internal/workflow/commands_test.go +0 -18
- package/engine/note_routing_test.go +0 -95
- package/engine/observation_contract_test.go +0 -175
- package/engine/root_routing_test.go +0 -340
|
@@ -1,666 +0,0 @@
|
|
|
1
|
-
package lib
|
|
2
|
-
|
|
3
|
-
import (
|
|
4
|
-
"bytes"
|
|
5
|
-
"encoding/json"
|
|
6
|
-
"os"
|
|
7
|
-
"os/exec"
|
|
8
|
-
"path/filepath"
|
|
9
|
-
"regexp"
|
|
10
|
-
"strings"
|
|
11
|
-
"testing"
|
|
12
|
-
|
|
13
|
-
"github.com/devrites/devrites/internal/testutil"
|
|
14
|
-
)
|
|
15
|
-
|
|
16
|
-
func runDupGit(t *testing.T, project string, args ...string) {
|
|
17
|
-
t.Helper()
|
|
18
|
-
cmd := exec.Command("git", append([]string{"-C", project}, args...)...)
|
|
19
|
-
if out, err := cmd.CombinedOutput(); err != nil {
|
|
20
|
-
t.Fatalf("git %v: %v\n%s", args, err, out)
|
|
21
|
-
}
|
|
22
|
-
}
|
|
23
|
-
|
|
24
|
-
func initDupRepo(t *testing.T, project string) {
|
|
25
|
-
t.Helper()
|
|
26
|
-
runDupGit(t, project, "init", "-q")
|
|
27
|
-
runDupGit(t, project, "config", "user.email", "tests@example.invalid")
|
|
28
|
-
runDupGit(t, project, "config", "user.name", "DevRites Tests")
|
|
29
|
-
}
|
|
30
|
-
|
|
31
|
-
// dupBlockA/B are the same logic under different names: the renaming case a
|
|
32
|
-
// verbatim-line diff cannot catch but token normalization can.
|
|
33
|
-
const dupBlockA = `func fetchDiscount(customer *Customer) (float64, error) {
|
|
34
|
-
if customer == nil {
|
|
35
|
-
return 0, errors.New("nil customer")
|
|
36
|
-
}
|
|
37
|
-
total, err := lookupOrders(customer.ID)
|
|
38
|
-
if err != nil {
|
|
39
|
-
return 0, fmt.Errorf("orders: %w", err)
|
|
40
|
-
}
|
|
41
|
-
if total > 1000 {
|
|
42
|
-
return 0.15, nil
|
|
43
|
-
}
|
|
44
|
-
if total > 500 {
|
|
45
|
-
return 0.10, nil
|
|
46
|
-
}
|
|
47
|
-
return 0, nil
|
|
48
|
-
}
|
|
49
|
-
`
|
|
50
|
-
|
|
51
|
-
const dupBlockB = `func resolveRate(account *Account) (float64, error) {
|
|
52
|
-
if account == nil {
|
|
53
|
-
return 0, errors.New("nil account")
|
|
54
|
-
}
|
|
55
|
-
sum, err := queryInvoices(account.Ref)
|
|
56
|
-
if err != nil {
|
|
57
|
-
return 0, fmt.Errorf("invoices: %w", err)
|
|
58
|
-
}
|
|
59
|
-
if sum > 2000 {
|
|
60
|
-
return 0.20, nil
|
|
61
|
-
}
|
|
62
|
-
if sum > 800 {
|
|
63
|
-
return 0.05, nil
|
|
64
|
-
}
|
|
65
|
-
return 0, nil
|
|
66
|
-
}
|
|
67
|
-
`
|
|
68
|
-
|
|
69
|
-
func TestNormalizeDupSourceStripsCommentsAndStrings(t *testing.T) {
|
|
70
|
-
src := "package x // trail\n\n// full-line comment\n/* block\n still */\nfunc f() string { return \"http://a//b\" } // done\n"
|
|
71
|
-
lines := normalizeDupSource(src, dupCStyle)
|
|
72
|
-
if len(lines) != 7 {
|
|
73
|
-
t.Fatalf("lines=%d", len(lines))
|
|
74
|
-
}
|
|
75
|
-
if lines[2].tokens != "_" || lines[3].tokens != "_" || lines[4].tokens != "_" {
|
|
76
|
-
t.Fatalf("comment lines got tokens: %q %q %q", lines[2].tokens, lines[3].tokens, lines[4].tokens)
|
|
77
|
-
}
|
|
78
|
-
if !strings.Contains(lines[5].tokens, "s") || strings.Contains(lines[5].tokens, "http") {
|
|
79
|
-
t.Fatalf("string literal not collapsed: %q", lines[5].tokens)
|
|
80
|
-
}
|
|
81
|
-
if strings.Contains(lines[5].tokens, "done") {
|
|
82
|
-
t.Fatalf("trailing comment survived: %q", lines[5].tokens)
|
|
83
|
-
}
|
|
84
|
-
}
|
|
85
|
-
|
|
86
|
-
func TestCanonicalizeDupLineCollapsesIdentifiers(t *testing.T) {
|
|
87
|
-
a := canonicalizeDupLine("if total > 1000 {")
|
|
88
|
-
b := canonicalizeDupLine("if sum > 2000 {")
|
|
89
|
-
if a.tokens != b.tokens {
|
|
90
|
-
t.Fatalf("renamed identifiers diverged: %q vs %q", a.tokens, b.tokens)
|
|
91
|
-
}
|
|
92
|
-
if !strings.HasPrefix(a.tokens, "if") {
|
|
93
|
-
t.Fatalf("keyword erased: %q", a.tokens)
|
|
94
|
-
}
|
|
95
|
-
c := canonicalizeDupLine("while total > 1000 {")
|
|
96
|
-
if a.tokens == c.tokens {
|
|
97
|
-
t.Fatal("if and while collapsed to the same skeleton")
|
|
98
|
-
}
|
|
99
|
-
trivial := canonicalizeDupLine("}")
|
|
100
|
-
if !trivial.trivial || trivial.tokens != "_" {
|
|
101
|
-
t.Fatalf("trivial line: %+v", trivial)
|
|
102
|
-
}
|
|
103
|
-
}
|
|
104
|
-
|
|
105
|
-
func TestDupDetectFindsRenamedCopy(t *testing.T) {
|
|
106
|
-
files := []dupFile{
|
|
107
|
-
{path: "a/one.go", lines: normalizeDupSource("package a\n\n"+dupBlockA, dupCStyle)},
|
|
108
|
-
{path: "b/two.go", lines: normalizeDupSource("package b\n\n"+dupBlockB, dupCStyle)},
|
|
109
|
-
}
|
|
110
|
-
clusters, units := dupDetect(files, dupOptions{minLines: 5, threshold: 0.6})
|
|
111
|
-
if len(clusters) != 1 {
|
|
112
|
-
t.Fatalf("clusters=%d want 1", len(clusters))
|
|
113
|
-
}
|
|
114
|
-
if len(clusters[0].units) != 2 {
|
|
115
|
-
t.Fatalf("cluster units=%v", clusters[0].units)
|
|
116
|
-
}
|
|
117
|
-
if len(units) != 2 || clusters[0].hash == "" {
|
|
118
|
-
t.Fatalf("units=%d hash=%q", len(units), clusters[0].hash)
|
|
119
|
-
}
|
|
120
|
-
}
|
|
121
|
-
|
|
122
|
-
func TestDupDetectIgnoresShortOverlap(t *testing.T) {
|
|
123
|
-
shared := "x := 1\ny := 2\nz := 3\nw := 4\n"
|
|
124
|
-
tailA := "if x > 1 {\n\treturn x + y\n}\nfor i := 0; i < 3; i++ {\n\tfmt.Println(i)\n}\nswitch z {\ncase 1:\n\tw++\n}\n"
|
|
125
|
-
tailB := "m := map[string]int{}\nfor k := range m {\n\tdelete(m, k)\n}\nif len(m) == 0 && z < 0 {\n\tpanic(\"empty\")\n}\nreturn\n"
|
|
126
|
-
files := []dupFile{
|
|
127
|
-
{path: "a.go", lines: normalizeDupSource("package a\n"+shared+tailA, dupCStyle)},
|
|
128
|
-
{path: "b.go", lines: normalizeDupSource("package b\n"+shared+tailB, dupCStyle)},
|
|
129
|
-
}
|
|
130
|
-
clusters, _ := dupDetect(files, dupOptions{minLines: 8, threshold: 0.6})
|
|
131
|
-
if len(clusters) != 0 {
|
|
132
|
-
t.Fatalf("short overlap reported: %+v", clusters)
|
|
133
|
-
}
|
|
134
|
-
}
|
|
135
|
-
|
|
136
|
-
func TestDupDistanceBoostPrefersDistantTwins(t *testing.T) {
|
|
137
|
-
seg := dupSegment{aStart: 0, aEnd: 10, bStart: 0, bEnd: 10}
|
|
138
|
-
near := dupDistanceBoost("a/x.go", "a/y.go", seg)
|
|
139
|
-
far := dupDistanceBoost("a/b/c/x.go", "d/e/f/y.go", seg)
|
|
140
|
-
if far <= near {
|
|
141
|
-
t.Fatalf("far=%f near=%f", far, near)
|
|
142
|
-
}
|
|
143
|
-
same := dupDistanceBoost("a/x.go", "a/x.go", dupSegment{aStart: 0, aEnd: 10, bStart: 600, bEnd: 610})
|
|
144
|
-
if same <= 0 {
|
|
145
|
-
t.Fatalf("same-file distant copy got no boost: %f", same)
|
|
146
|
-
}
|
|
147
|
-
}
|
|
148
|
-
|
|
149
|
-
func TestDupClusterHashStableAcrossMoves(t *testing.T) {
|
|
150
|
-
// The same pair of twins with one block shifted down in its file must
|
|
151
|
-
// hash identically: a cluster hash keys on content, not position.
|
|
152
|
-
run := func(aSrc string) string {
|
|
153
|
-
files := []dupFile{
|
|
154
|
-
{path: "a/one.go", lines: normalizeDupSource(aSrc, dupCStyle)},
|
|
155
|
-
{path: "b/two.go", lines: normalizeDupSource("package b\n\n"+dupBlockB, dupCStyle)},
|
|
156
|
-
}
|
|
157
|
-
clusters, _ := dupDetect(files, dupOptions{minLines: 5, threshold: 0.6})
|
|
158
|
-
if len(clusters) != 1 {
|
|
159
|
-
t.Fatalf("clusters=%d", len(clusters))
|
|
160
|
-
}
|
|
161
|
-
return clusters[0].hash
|
|
162
|
-
}
|
|
163
|
-
base := run("package a\n\n" + dupBlockA)
|
|
164
|
-
moved := run("package a\n\n\n// spacer\n\n" + dupBlockA)
|
|
165
|
-
if base != moved {
|
|
166
|
-
t.Fatal("cluster hash shifted when the block moved lines")
|
|
167
|
-
}
|
|
168
|
-
edited := run("package a\n\n" + strings.Replace(dupBlockA, "total > 1000", "total >= 1000", 1))
|
|
169
|
-
if edited == base {
|
|
170
|
-
t.Fatal("cluster hash unchanged after a body edit")
|
|
171
|
-
}
|
|
172
|
-
}
|
|
173
|
-
|
|
174
|
-
func TestDupChangedRangesParsesHunks(t *testing.T) {
|
|
175
|
-
diff := "diff --git a/f.go b/f.go\nindex 1..2 100644\n--- a/f.go\n+++ b/f.go\n" +
|
|
176
|
-
"@@ -10,0 +11,3 @@\n+a\n+b\n+c\n@@ -30 +31 @@\n+x\n" +
|
|
177
|
-
"diff --git a/gone.go b/gone.go\n--- a/gone.go\n+++ /dev/null\n@@ -1 +0,0 @@\n-y\n"
|
|
178
|
-
ranges := dupChangedRanges(diff)
|
|
179
|
-
got := ranges["f.go"]
|
|
180
|
-
if len(got) != 2 || got[0] != [2]int{11, 13} || got[1] != [2]int{31, 31} {
|
|
181
|
-
t.Fatalf("ranges=%v", got)
|
|
182
|
-
}
|
|
183
|
-
if _, ok := ranges["gone.go"]; ok {
|
|
184
|
-
t.Fatal("deleted file recorded a range")
|
|
185
|
-
}
|
|
186
|
-
}
|
|
187
|
-
|
|
188
|
-
func TestDupLoadIgnoreStripsComments(t *testing.T) {
|
|
189
|
-
f := filepath.Join(t.TempDir(), "dup-ignore")
|
|
190
|
-
testutil.WriteFile(t, f, "abcdef123456 # coincidental helpers\n\n \n# full comment\nbeef00\n")
|
|
191
|
-
got := dupLoadIgnore(f)
|
|
192
|
-
if !got["abcdef123456"] || !got["beef00"] || len(got) != 2 {
|
|
193
|
-
t.Fatalf("ignored=%v", got)
|
|
194
|
-
}
|
|
195
|
-
}
|
|
196
|
-
|
|
197
|
-
func TestRunCheckDupWorktreeMarksChanged(t *testing.T) {
|
|
198
|
-
project := t.TempDir()
|
|
199
|
-
initDupRepo(t, project)
|
|
200
|
-
testutil.WriteFile(t, filepath.Join(project, "a/one.go"), "package a\n\n"+dupBlockA)
|
|
201
|
-
runDupGit(t, project, "add", ".")
|
|
202
|
-
runDupGit(t, project, "commit", "-qm", "base")
|
|
203
|
-
// New file duplicating committed code: untracked → whole file changed.
|
|
204
|
-
testutil.WriteFile(t, filepath.Join(project, "b/two.go"), "package b\n\n"+dupBlockB)
|
|
205
|
-
|
|
206
|
-
var stdout, stderr bytes.Buffer
|
|
207
|
-
code := RunCheckDup(filepath.Join(project, ".devrites"), []string{"--min-lines", "5"}, &stdout, &stderr)
|
|
208
|
-
if code != 0 {
|
|
209
|
-
t.Fatalf("code=%d stderr=%s", code, stderr.String())
|
|
210
|
-
}
|
|
211
|
-
out := stdout.String()
|
|
212
|
-
if !strings.Contains(out, "cluster 1 (") || !strings.Contains(out, "* b/two.go:") {
|
|
213
|
-
t.Fatalf("missing changed-marked cluster:\n%s", out)
|
|
214
|
-
}
|
|
215
|
-
if strings.Contains(out, "* a/one.go:") {
|
|
216
|
-
t.Fatalf("unchanged file marked:\n%s", out)
|
|
217
|
-
}
|
|
218
|
-
}
|
|
219
|
-
|
|
220
|
-
func TestRunCheckDupAllFindsPreexistingDup(t *testing.T) {
|
|
221
|
-
project := t.TempDir()
|
|
222
|
-
initDupRepo(t, project)
|
|
223
|
-
testutil.WriteFile(t, filepath.Join(project, "a/one.go"), "package a\n\n"+dupBlockA)
|
|
224
|
-
testutil.WriteFile(t, filepath.Join(project, "b/two.go"), "package b\n\n"+dupBlockB)
|
|
225
|
-
runDupGit(t, project, "add", ".")
|
|
226
|
-
runDupGit(t, project, "commit", "-qm", "base")
|
|
227
|
-
root := filepath.Join(project, ".devrites")
|
|
228
|
-
|
|
229
|
-
var stdout, stderr bytes.Buffer
|
|
230
|
-
code := RunCheckDup(root, []string{"--all", "--min-lines", "5"}, &stdout, &stderr)
|
|
231
|
-
if code != 0 || !strings.Contains(stdout.String(), "cluster 1 (") {
|
|
232
|
-
t.Fatalf("code=%d out=%s err=%s", code, stdout.String(), stderr.String())
|
|
233
|
-
}
|
|
234
|
-
// Worktree mode with a clean tree reports nothing attributable, but the
|
|
235
|
-
// message must say the diff is clean, not imply the repo has no duplicates.
|
|
236
|
-
stdout.Reset()
|
|
237
|
-
code = RunCheckDup(root, nil, &stdout, &stderr)
|
|
238
|
-
if code != 0 || strings.Contains(stdout.String(), "cluster 1 (") ||
|
|
239
|
-
!strings.Contains(stdout.String(), "no clusters touch the diff") {
|
|
240
|
-
t.Fatalf("clean worktree misreported: code=%d out=%s", code, stdout.String())
|
|
241
|
-
}
|
|
242
|
-
}
|
|
243
|
-
|
|
244
|
-
func TestRunCheckDupIgnoreFileSuppressesCluster(t *testing.T) {
|
|
245
|
-
project := t.TempDir()
|
|
246
|
-
initDupRepo(t, project)
|
|
247
|
-
testutil.WriteFile(t, filepath.Join(project, "a/one.go"), "package a\n\n"+dupBlockA)
|
|
248
|
-
runDupGit(t, project, "add", ".")
|
|
249
|
-
runDupGit(t, project, "commit", "-qm", "base")
|
|
250
|
-
testutil.WriteFile(t, filepath.Join(project, "b/two.go"), "package b\n\n"+dupBlockB)
|
|
251
|
-
root := filepath.Join(project, ".devrites")
|
|
252
|
-
|
|
253
|
-
var stdout, stderr bytes.Buffer
|
|
254
|
-
code := RunCheckDup(root, []string{"--all", "--min-lines", "5"}, &stdout, &stderr)
|
|
255
|
-
if code != 0 {
|
|
256
|
-
t.Fatalf("code=%d stderr=%s", code, stderr.String())
|
|
257
|
-
}
|
|
258
|
-
out := stdout.String()
|
|
259
|
-
start := strings.Index(out, "cluster 1 (")
|
|
260
|
-
if start < 0 {
|
|
261
|
-
t.Fatalf("no cluster:\n%s", out)
|
|
262
|
-
}
|
|
263
|
-
hash := out[start+len("cluster 1 (") : start+len("cluster 1 (")+12]
|
|
264
|
-
if err := os.MkdirAll(root, 0o755); err != nil {
|
|
265
|
-
t.Fatal(err)
|
|
266
|
-
}
|
|
267
|
-
testutil.WriteFile(t, filepath.Join(root, "dup-ignore"), hash+" # coincidence\n")
|
|
268
|
-
|
|
269
|
-
stdout.Reset()
|
|
270
|
-
code = RunCheckDup(root, []string{"--all", "--min-lines", "5"}, &stdout, &stderr)
|
|
271
|
-
if code != 0 {
|
|
272
|
-
t.Fatalf("code=%d stderr=%s", code, stderr.String())
|
|
273
|
-
}
|
|
274
|
-
if !strings.Contains(stdout.String(), "ignored") {
|
|
275
|
-
t.Fatalf("ignore file not honored:\n%s", stdout.String())
|
|
276
|
-
}
|
|
277
|
-
}
|
|
278
|
-
|
|
279
|
-
func TestDupScannableSkipsNestedVendoredTrees(t *testing.T) {
|
|
280
|
-
for _, p := range []string{
|
|
281
|
-
"vendor/x/lib.go",
|
|
282
|
-
"services/api/vendor/x/lib.go",
|
|
283
|
-
"a/node_modules/pkg/index.js",
|
|
284
|
-
"pkg/testdata/fixture.go",
|
|
285
|
-
"sub/.devrites/work/f.go",
|
|
286
|
-
"gen/output.pb.go",
|
|
287
|
-
"dist/bundle.min.js",
|
|
288
|
-
} {
|
|
289
|
-
if dupScannable(p, nil) {
|
|
290
|
-
t.Fatalf("%s should be skipped", p)
|
|
291
|
-
}
|
|
292
|
-
}
|
|
293
|
-
for _, p := range []string{
|
|
294
|
-
"vendorless/lib.go", // name contains but is not the dir
|
|
295
|
-
"pkg/vendorx/v.go",
|
|
296
|
-
"engine/main.go",
|
|
297
|
-
} {
|
|
298
|
-
if !dupScannable(p, nil) {
|
|
299
|
-
t.Fatalf("%s should be scannable", p)
|
|
300
|
-
}
|
|
301
|
-
}
|
|
302
|
-
if dupScannable("sub/lib/util.go", []string{"lib/"}) {
|
|
303
|
-
t.Fatal("--exclude lib/ should match at any depth")
|
|
304
|
-
}
|
|
305
|
-
}
|
|
306
|
-
|
|
307
|
-
func TestDupRejectsInvalidArgs(t *testing.T) {
|
|
308
|
-
for _, args := range [][]string{{"--threshold", "NaN"}, {"--base", "--output=escaped"}, {"--all", "--staged"}, {"--limit", "1", "--limit", "2"}, {"--phase"}, {"--cwd", "--all"}, {"--ignore-file"}, {"--exclude", ""}} {
|
|
309
|
-
var out, errOut bytes.Buffer
|
|
310
|
-
root := filepath.Join(t.TempDir(), ".devrites")
|
|
311
|
-
if code := RunCheckDup(root, args, &out, &errOut); code != 2 || !strings.Contains(errOut.String(), "dup:") || strings.Contains(errOut.String(), "git ") || out.Len() != 0 {
|
|
312
|
-
t.Errorf("args=%v code=%d out=%s err=%s", args, code, &out, &errOut)
|
|
313
|
-
}
|
|
314
|
-
if _, err := os.Stat(filepath.Join(root, "metrics")); !os.IsNotExist(err) {
|
|
315
|
-
t.Fatal("invalid args wrote metrics")
|
|
316
|
-
}
|
|
317
|
-
}
|
|
318
|
-
}
|
|
319
|
-
|
|
320
|
-
func TestDupStagedSnapshot(t *testing.T) {
|
|
321
|
-
project := t.TempDir()
|
|
322
|
-
initDupRepo(t, project)
|
|
323
|
-
testutil.WriteFile(t, filepath.Join(project, "a.go"), dupBlockA)
|
|
324
|
-
runDupGit(t, project, "add", ".")
|
|
325
|
-
runDupGit(t, project, "commit", "-qm", "base")
|
|
326
|
-
testutil.WriteFile(t, filepath.Join(project, "b.go"), dupBlockB)
|
|
327
|
-
runDupGit(t, project, "add", "b.go")
|
|
328
|
-
testutil.WriteFile(t, filepath.Join(project, "a.go"), "package different")
|
|
329
|
-
if err := os.Remove(filepath.Join(project, "b.go")); err != nil {
|
|
330
|
-
t.Fatal(err)
|
|
331
|
-
}
|
|
332
|
-
testutil.WriteFile(t, filepath.Join(project, "untracked.go"), dupBlockA)
|
|
333
|
-
var out, errOut bytes.Buffer
|
|
334
|
-
code := RunCheckDup(filepath.Join(project, ".devrites"), []string{"--staged", "--min-lines", "5"}, &out, &errOut)
|
|
335
|
-
if code != 0 || !strings.Contains(out.String(), "* b.go:") || !strings.Contains(out.String(), " a.go:") || strings.Contains(out.String(), "untracked.go") {
|
|
336
|
-
t.Fatalf("code=%d out=%s err=%s", code, &out, &errOut)
|
|
337
|
-
}
|
|
338
|
-
}
|
|
339
|
-
|
|
340
|
-
func TestDupUnavailableAndExcluded(t *testing.T) {
|
|
341
|
-
for _, kind := range []string{"missing", "oversized", "generated", "empty", "partial"} {
|
|
342
|
-
t.Run(kind, func(t *testing.T) {
|
|
343
|
-
project := t.TempDir()
|
|
344
|
-
initDupRepo(t, project)
|
|
345
|
-
if kind != "empty" {
|
|
346
|
-
testutil.WriteFile(t, filepath.Join(project, "a.go"), dupBlockA)
|
|
347
|
-
runDupGit(t, project, "add", ".")
|
|
348
|
-
}
|
|
349
|
-
switch kind {
|
|
350
|
-
case "missing", "partial":
|
|
351
|
-
if err := os.Remove(filepath.Join(project, "a.go")); err != nil {
|
|
352
|
-
t.Fatal(err)
|
|
353
|
-
}
|
|
354
|
-
case "oversized":
|
|
355
|
-
testutil.WriteFile(t, filepath.Join(project, "a.go"), strings.Repeat("x", dupMaxFileBytes+1))
|
|
356
|
-
case "generated":
|
|
357
|
-
testutil.WriteFile(t, filepath.Join(project, "a.go"), "// Code generated; DO NOT EDIT.")
|
|
358
|
-
}
|
|
359
|
-
if kind == "partial" {
|
|
360
|
-
testutil.WriteFile(t, filepath.Join(project, "b.go"), dupBlockB)
|
|
361
|
-
}
|
|
362
|
-
var out, errOut bytes.Buffer
|
|
363
|
-
code := RunCheckDup(filepath.Join(project, ".devrites"), []string{"--all"}, &out, &errOut)
|
|
364
|
-
if kind == "missing" || kind == "oversized" || kind == "partial" {
|
|
365
|
-
if code != 2 || strings.Contains(out.String(), "dup: ok") || !strings.Contains(errOut.String(), "incomplete") {
|
|
366
|
-
t.Fatalf("code=%d out=%s err=%s", code, &out, &errOut)
|
|
367
|
-
}
|
|
368
|
-
} else if code != 0 || !strings.Contains(out.String(), map[string]string{"empty": "no eligible", "generated": "generated"}[kind]) {
|
|
369
|
-
t.Fatalf("code=%d out=%s err=%s", code, &out, &errOut)
|
|
370
|
-
}
|
|
371
|
-
})
|
|
372
|
-
}
|
|
373
|
-
}
|
|
374
|
-
|
|
375
|
-
func TestDupBaseFlagCannotWriteFile(t *testing.T) {
|
|
376
|
-
project := t.TempDir()
|
|
377
|
-
initDupRepo(t, project)
|
|
378
|
-
testutil.WriteFile(t, filepath.Join(project, "a.go"), dupBlockA)
|
|
379
|
-
runDupGit(t, project, "add", ".")
|
|
380
|
-
runDupGit(t, project, "commit", "-qm", "base")
|
|
381
|
-
testutil.WriteFile(t, filepath.Join(project, "a.go"), dupBlockB)
|
|
382
|
-
target := filepath.Join(project, "escaped")
|
|
383
|
-
var out, errOut bytes.Buffer
|
|
384
|
-
code := RunCheckDup(filepath.Join(project, ".devrites"), []string{"--base", "--output=" + target}, &out, &errOut)
|
|
385
|
-
if code != 2 {
|
|
386
|
-
t.Fatalf("code=%d out=%s err=%s", code, &out, &errOut)
|
|
387
|
-
}
|
|
388
|
-
if _, err := os.Stat(target); !os.IsNotExist(err) {
|
|
389
|
-
t.Fatalf("git output target exists: %v", err)
|
|
390
|
-
}
|
|
391
|
-
}
|
|
392
|
-
|
|
393
|
-
func TestDupStagedRejectsUnsafeIndexEntries(t *testing.T) {
|
|
394
|
-
for _, kind := range []string{"symlink", "unmerged", "oversized"} {
|
|
395
|
-
t.Run(kind, func(t *testing.T) {
|
|
396
|
-
project := t.TempDir()
|
|
397
|
-
initDupRepo(t, project)
|
|
398
|
-
testutil.WriteFile(t, filepath.Join(project, "a.go"), dupBlockA)
|
|
399
|
-
runDupGit(t, project, "add", ".")
|
|
400
|
-
runDupGit(t, project, "commit", "-qm", "base")
|
|
401
|
-
switch kind {
|
|
402
|
-
case "symlink":
|
|
403
|
-
if err := os.Symlink("a.go", filepath.Join(project, "b.go")); err != nil {
|
|
404
|
-
t.Fatal(err)
|
|
405
|
-
}
|
|
406
|
-
runDupGit(t, project, "add", "b.go")
|
|
407
|
-
case "oversized":
|
|
408
|
-
testutil.WriteFile(t, filepath.Join(project, "b.go"), strings.Repeat("x", dupMaxFileBytes+1))
|
|
409
|
-
runDupGit(t, project, "add", "b.go")
|
|
410
|
-
case "unmerged":
|
|
411
|
-
oid, err := exec.Command("git", "-C", project, "rev-parse", "HEAD:a.go").Output()
|
|
412
|
-
if err != nil {
|
|
413
|
-
t.Fatal(err)
|
|
414
|
-
}
|
|
415
|
-
cmd := exec.Command("git", "-C", project, "update-index", "--index-info")
|
|
416
|
-
cmd.Stdin = strings.NewReader("0 0000000000000000000000000000000000000000\ta.go\n100644 " + strings.TrimSpace(string(oid)) + " 1\ta.go\n")
|
|
417
|
-
if out, err := cmd.CombinedOutput(); err != nil {
|
|
418
|
-
t.Fatalf("index: %s %v", out, err)
|
|
419
|
-
}
|
|
420
|
-
}
|
|
421
|
-
var out, errOut bytes.Buffer
|
|
422
|
-
code := RunCheckDup(filepath.Join(project, ".devrites"), []string{"--staged"}, &out, &errOut)
|
|
423
|
-
if code != 2 || strings.Contains(out.String(), "dup: ok") || !strings.Contains(errOut.String(), "incomplete") {
|
|
424
|
-
t.Fatalf("code=%d out=%s err=%s", code, &out, &errOut)
|
|
425
|
-
}
|
|
426
|
-
})
|
|
427
|
-
}
|
|
428
|
-
}
|
|
429
|
-
|
|
430
|
-
func TestDupStagedDeletionAndUntrackedAreNotComparators(t *testing.T) {
|
|
431
|
-
project := t.TempDir()
|
|
432
|
-
initDupRepo(t, project)
|
|
433
|
-
testutil.WriteFile(t, filepath.Join(project, "a.go"), dupBlockA)
|
|
434
|
-
runDupGit(t, project, "add", ".")
|
|
435
|
-
runDupGit(t, project, "commit", "-qm", "base")
|
|
436
|
-
runDupGit(t, project, "rm", "a.go")
|
|
437
|
-
testutil.WriteFile(t, filepath.Join(project, "b.go"), dupBlockB)
|
|
438
|
-
runDupGit(t, project, "add", "b.go")
|
|
439
|
-
testutil.WriteFile(t, filepath.Join(project, "untracked.go"), dupBlockA)
|
|
440
|
-
var out, errOut bytes.Buffer
|
|
441
|
-
code := RunCheckDup(filepath.Join(project, ".devrites"), []string{"--staged", "--min-lines", "5"}, &out, &errOut)
|
|
442
|
-
if code != 0 || !strings.Contains(out.String(), "scanned 1 files") || strings.Contains(out.String(), "cluster 1 (") {
|
|
443
|
-
t.Fatalf("code=%d out=%s err=%s", code, &out, &errOut)
|
|
444
|
-
}
|
|
445
|
-
}
|
|
446
|
-
|
|
447
|
-
func TestDupDoesNotExecuteDiffHelpers(t *testing.T) {
|
|
448
|
-
project := t.TempDir()
|
|
449
|
-
initDupRepo(t, project)
|
|
450
|
-
testutil.WriteFile(t, filepath.Join(project, "a.go"), dupBlockA)
|
|
451
|
-
testutil.WriteFile(t, filepath.Join(project, ".gitattributes"), "*.go diff=hostile\n")
|
|
452
|
-
runDupGit(t, project, "add", ".")
|
|
453
|
-
runDupGit(t, project, "commit", "-qm", "base")
|
|
454
|
-
testutil.WriteFile(t, filepath.Join(project, "a.go"), dupBlockB)
|
|
455
|
-
runDupGit(t, project, "add", ".")
|
|
456
|
-
runDupGit(t, project, "config", "diff.external", "missing-external-diff-command")
|
|
457
|
-
runDupGit(t, project, "config", "diff.hostile.textconv", "missing-textconv-command")
|
|
458
|
-
for _, mode := range [][]string{{"--staged"}, {"--worktree"}, {"--base", "HEAD"}} {
|
|
459
|
-
var out, errOut bytes.Buffer
|
|
460
|
-
if code := RunCheckDup(filepath.Join(project, ".devrites"), mode, &out, &errOut); code != 0 {
|
|
461
|
-
t.Fatalf("mode=%v code=%d out=%s err=%s", mode, code, &out, &errOut)
|
|
462
|
-
}
|
|
463
|
-
}
|
|
464
|
-
}
|
|
465
|
-
|
|
466
|
-
func TestDupGitOutputRejectsTruncation(t *testing.T) {
|
|
467
|
-
project := t.TempDir()
|
|
468
|
-
initDupRepo(t, project)
|
|
469
|
-
if _, err := dupGitOutput(project, nil, 1, "rev-parse", "--show-toplevel"); err == nil {
|
|
470
|
-
t.Fatal("truncated Git output accepted")
|
|
471
|
-
}
|
|
472
|
-
}
|
|
473
|
-
|
|
474
|
-
func TestDupStagedQuotedPathAndDiffConfig(t *testing.T) {
|
|
475
|
-
project := t.TempDir()
|
|
476
|
-
initDupRepo(t, project)
|
|
477
|
-
testutil.WriteFile(t, filepath.Join(project, "a.go"), dupBlockA)
|
|
478
|
-
runDupGit(t, project, "add", ".")
|
|
479
|
-
runDupGit(t, project, "commit", "-qm", "base")
|
|
480
|
-
name := "space name.go"
|
|
481
|
-
testutil.WriteFile(t, filepath.Join(project, name), dupBlockB)
|
|
482
|
-
runDupGit(t, project, "add", ".")
|
|
483
|
-
runDupGit(t, project, "config", "diff.noprefix", "true")
|
|
484
|
-
runDupGit(t, project, "config", "color.ui", "always")
|
|
485
|
-
var out, errOut bytes.Buffer
|
|
486
|
-
code := RunCheckDup(filepath.Join(project, ".devrites"), []string{"--staged", "--min-lines", "5"}, &out, &errOut)
|
|
487
|
-
if code != 0 || !strings.Contains(out.String(), "* "+name+":") {
|
|
488
|
-
t.Fatalf("code=%d out=%s err=%s", code, &out, &errOut)
|
|
489
|
-
}
|
|
490
|
-
}
|
|
491
|
-
|
|
492
|
-
const dupBlockC = `func loadSettings(path string) (map[string]string, error) {
|
|
493
|
-
data, err := os.ReadFile(path)
|
|
494
|
-
if err != nil {
|
|
495
|
-
return nil, fmt.Errorf("read: %w", err)
|
|
496
|
-
}
|
|
497
|
-
out := map[string]string{}
|
|
498
|
-
for _, line := range strings.Split(string(data), "\n") {
|
|
499
|
-
k, v, ok := strings.Cut(line, "=")
|
|
500
|
-
if !ok {
|
|
501
|
-
continue
|
|
502
|
-
}
|
|
503
|
-
out[strings.TrimSpace(k)] = strings.TrimSpace(v)
|
|
504
|
-
}
|
|
505
|
-
return out, nil
|
|
506
|
-
}
|
|
507
|
-
`
|
|
508
|
-
|
|
509
|
-
const dupBlockD = `func readProfile(file string) (map[string]string, error) {
|
|
510
|
-
raw, err := os.ReadFile(file)
|
|
511
|
-
if err != nil {
|
|
512
|
-
return nil, fmt.Errorf("open: %w", err)
|
|
513
|
-
}
|
|
514
|
-
res := map[string]string{}
|
|
515
|
-
for _, row := range strings.Split(string(raw), "\n") {
|
|
516
|
-
name, val, found := strings.Cut(row, "=")
|
|
517
|
-
if !found {
|
|
518
|
-
continue
|
|
519
|
-
}
|
|
520
|
-
res[strings.TrimSpace(name)] = strings.TrimSpace(val)
|
|
521
|
-
}
|
|
522
|
-
return res, nil
|
|
523
|
-
}
|
|
524
|
-
`
|
|
525
|
-
|
|
526
|
-
func dupMetricBytes(t *testing.T, root, slug string) []int64 {
|
|
527
|
-
t.Helper()
|
|
528
|
-
data, err := os.ReadFile(filepath.Join(root, "work", slug, MetricsFile))
|
|
529
|
-
if err != nil {
|
|
530
|
-
t.Fatal(err)
|
|
531
|
-
}
|
|
532
|
-
var got []int64
|
|
533
|
-
for _, line := range strings.Split(strings.TrimSpace(string(data)), "\n") {
|
|
534
|
-
var ev metricEvent
|
|
535
|
-
if err := json.Unmarshal([]byte(line), &ev); err != nil {
|
|
536
|
-
t.Fatal(err)
|
|
537
|
-
}
|
|
538
|
-
got = append(got, ev.Bytes)
|
|
539
|
-
}
|
|
540
|
-
return got
|
|
541
|
-
}
|
|
542
|
-
|
|
543
|
-
func TestRunCheckDupMetricIgnoresLimitAndCountsOnlyShown(t *testing.T) {
|
|
544
|
-
project := t.TempDir()
|
|
545
|
-
initDupRepo(t, project)
|
|
546
|
-
testutil.WriteFile(t, filepath.Join(project, "a/one.go"), "package a\n\n"+dupBlockA)
|
|
547
|
-
testutil.WriteFile(t, filepath.Join(project, "c/three.go"), "package c\n\n"+dupBlockC)
|
|
548
|
-
testutil.WriteFile(t, filepath.Join(project, "b/two.go"), "package b\n\n"+dupBlockB)
|
|
549
|
-
testutil.WriteFile(t, filepath.Join(project, "d/four.go"), "package d\n\n"+dupBlockD)
|
|
550
|
-
runDupGit(t, project, "add", ".")
|
|
551
|
-
runDupGit(t, project, "commit", "-qm", "base")
|
|
552
|
-
root := filepath.Join(project, ".devrites")
|
|
553
|
-
if err := os.MkdirAll(filepath.Join(root, "work", "demo"), 0o755); err != nil {
|
|
554
|
-
t.Fatal(err)
|
|
555
|
-
}
|
|
556
|
-
|
|
557
|
-
var hashes []string
|
|
558
|
-
for _, limit := range []string{"1", "50"} {
|
|
559
|
-
var stdout, stderr bytes.Buffer
|
|
560
|
-
args := []string{"demo", "--all", "--min-lines", "5", "--limit", limit}
|
|
561
|
-
if code := RunCheckDup(root, args, &stdout, &stderr); code != 0 {
|
|
562
|
-
t.Fatalf("limit=%s code=%d stderr=%s", limit, code, stderr.String())
|
|
563
|
-
}
|
|
564
|
-
if limit == "50" {
|
|
565
|
-
for _, m := range regexp.MustCompile(`cluster \d+ \(([0-9a-f]+)\)`).FindAllStringSubmatch(stdout.String(), -1) {
|
|
566
|
-
hashes = append(hashes, m[1])
|
|
567
|
-
}
|
|
568
|
-
}
|
|
569
|
-
}
|
|
570
|
-
if len(hashes) != 2 {
|
|
571
|
-
t.Fatalf("want 2 clusters, got %v", hashes)
|
|
572
|
-
}
|
|
573
|
-
got := dupMetricBytes(t, root, "demo")
|
|
574
|
-
if len(got) != 2 || got[0] != got[1] {
|
|
575
|
-
t.Fatalf("metric depends on --limit: %v", got)
|
|
576
|
-
}
|
|
577
|
-
|
|
578
|
-
testutil.WriteFile(t, filepath.Join(root, "dup-ignore"), hashes[0]+"\n")
|
|
579
|
-
var stdout, stderr bytes.Buffer
|
|
580
|
-
if code := RunCheckDup(root, []string{"demo", "--all", "--min-lines", "5"}, &stdout, &stderr); code != 0 {
|
|
581
|
-
t.Fatalf("code=%d stderr=%s", code, stderr.String())
|
|
582
|
-
}
|
|
583
|
-
oneIgnored := dupMetricBytes(t, root, "demo")[2]
|
|
584
|
-
|
|
585
|
-
testutil.WriteFile(t, filepath.Join(root, "dup-ignore"), hashes[0]+"\n"+hashes[1]+"\n")
|
|
586
|
-
stdout.Reset()
|
|
587
|
-
if code := RunCheckDup(root, []string{"demo", "--all", "--min-lines", "5"}, &stdout, &stderr); code != 0 {
|
|
588
|
-
t.Fatalf("code=%d stderr=%s", code, stderr.String())
|
|
589
|
-
}
|
|
590
|
-
if allIgnored := dupMetricBytes(t, root, "demo")[3]; allIgnored > oneIgnored {
|
|
591
|
-
t.Fatalf("metric rose when findings were dismissed: %d -> %d", oneIgnored, allIgnored)
|
|
592
|
-
}
|
|
593
|
-
}
|
|
594
|
-
|
|
595
|
-
// dupGroupedInput builds nFiles files of 10 units each (lines 10u..10u+4)
|
|
596
|
-
// where every unit position is linked across consecutive files of each group.
|
|
597
|
-
func dupGroupedInput(nFiles, group int) ([]dupSegment, []dupFile) {
|
|
598
|
-
files := make([]dupFile, nFiles)
|
|
599
|
-
for i := range files {
|
|
600
|
-
files[i] = dupFile{path: "pkg" + string(rune('a'+i%26)) + "/f" + string(rune('a'+i/26%26)) + string(rune('a'+i/676)) + ".go", lines: make([]dupLine, 100)}
|
|
601
|
-
}
|
|
602
|
-
var segs []dupSegment
|
|
603
|
-
for base := 0; base+group <= nFiles; base += group {
|
|
604
|
-
for u := 0; u < 10; u++ {
|
|
605
|
-
for k := 0; k+1 < group; k++ {
|
|
606
|
-
segs = append(segs, dupSegment{
|
|
607
|
-
aFile: base + k, bFile: base + k + 1,
|
|
608
|
-
aStart: u * 10, aEnd: u*10 + 4, bStart: u * 10, bEnd: u*10 + 4,
|
|
609
|
-
boosted: float64((base+k+u)%7+1) / 10,
|
|
610
|
-
})
|
|
611
|
-
}
|
|
612
|
-
}
|
|
613
|
-
}
|
|
614
|
-
return segs, files
|
|
615
|
-
}
|
|
616
|
-
|
|
617
|
-
func TestDupClusterUnitsSmallCase(t *testing.T) {
|
|
618
|
-
files := []dupFile{
|
|
619
|
-
{path: "a/x.go", lines: make([]dupLine, 40)},
|
|
620
|
-
{path: "b/y.go", lines: make([]dupLine, 40)},
|
|
621
|
-
{path: "c/z.go", lines: make([]dupLine, 40)},
|
|
622
|
-
}
|
|
623
|
-
segs := []dupSegment{
|
|
624
|
-
{aFile: 0, bFile: 1, aStart: 0, aEnd: 4, bStart: 0, bEnd: 4, boosted: 0.5},
|
|
625
|
-
{aFile: 1, bFile: 2, aStart: 0, aEnd: 4, bStart: 0, bEnd: 4, boosted: 0.9},
|
|
626
|
-
{aFile: 0, bFile: 1, aStart: 20, aEnd: 24, bStart: 20, bEnd: 24, boosted: 0.3},
|
|
627
|
-
}
|
|
628
|
-
clusters, units, edges := dupClusterUnits(segs, files)
|
|
629
|
-
if len(units) != 5 || len(edges) != 3 || len(clusters) != 2 {
|
|
630
|
-
t.Fatalf("units=%d edges=%d clusters=%d", len(units), len(edges), len(clusters))
|
|
631
|
-
}
|
|
632
|
-
if len(clusters[0].units) != 3 || clusters[0].score != 0.9 {
|
|
633
|
-
t.Fatalf("first cluster = %d units score %v", len(clusters[0].units), clusters[0].score)
|
|
634
|
-
}
|
|
635
|
-
if len(clusters[1].units) != 2 || clusters[1].score != 0.3 {
|
|
636
|
-
t.Fatalf("second cluster = %d units score %v", len(clusters[1].units), clusters[1].score)
|
|
637
|
-
}
|
|
638
|
-
if clusters[0].hash == clusters[1].hash || len(clusters[0].hash) != dupHashLength {
|
|
639
|
-
t.Fatalf("hashes %q %q", clusters[0].hash, clusters[1].hash)
|
|
640
|
-
}
|
|
641
|
-
}
|
|
642
|
-
|
|
643
|
-
func TestDupClusterUnitsWorkIsLinear(t *testing.T) {
|
|
644
|
-
segs, files := dupGroupedInput(1600, 20)
|
|
645
|
-
var steps int
|
|
646
|
-
clusters, units, _ := dupClusterUnitsCounted(segs, files, &steps)
|
|
647
|
-
if len(clusters) != 80*10 {
|
|
648
|
-
t.Fatalf("clusters=%d, want 800", len(clusters))
|
|
649
|
-
}
|
|
650
|
-
for _, c := range clusters {
|
|
651
|
-
if len(c.units) != 20 {
|
|
652
|
-
t.Fatalf("cluster has %d units, want 20", len(c.units))
|
|
653
|
-
}
|
|
654
|
-
}
|
|
655
|
-
// Every unit sits alone in a 10-line slot, so each of the two endpoints of
|
|
656
|
-
// a segment overlaps exactly one unit, and the scoring pass visits each
|
|
657
|
-
// edge once. A path that scans all units or all edges per cluster does
|
|
658
|
-
// more work, and one that skips the counter does none.
|
|
659
|
-
groups, perGroup, unitsPerFile := 1600/20, 20, 10
|
|
660
|
-
if want := groups * unitsPerFile * (perGroup - 1); len(segs) != want {
|
|
661
|
-
t.Fatalf("fixture has %d segments, want %d", len(segs), want)
|
|
662
|
-
}
|
|
663
|
-
if want := 3 * len(segs); steps != want {
|
|
664
|
-
t.Fatalf("examined %d units/edges for %d segments and %d units, want exactly %d", steps, len(segs), len(units), want)
|
|
665
|
-
}
|
|
666
|
-
}
|