devrites 5.4.0 → 5.6.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +12 -0
- package/README.md +8 -6
- package/docs/command-map.md +2 -2
- package/docs/engine/state-schema.md +12 -0
- package/docs/flow.md +4 -0
- package/docs/orchestration.md +5 -2
- package/engine/commands.go +2 -2
- package/engine/internal/devritespaths/paths.go +18 -0
- package/engine/internal/gate/gate.go +78 -0
- package/engine/internal/gate/gate_test.go +118 -0
- package/engine/internal/hostpack/hostpack.go +45 -6
- package/engine/internal/hostpack/hostpack_test.go +29 -13
- package/engine/internal/install/apply.go +14 -5
- package/engine/internal/install/install.go +8 -2
- package/engine/internal/install/install_test.go +12 -5
- package/engine/internal/install/merge.go +5 -0
- package/engine/internal/install/preflight.go +20 -2
- package/engine/internal/install/uninstall.go +5 -0
- package/engine/internal/install/update.go +1 -1
- package/engine/internal/lib/candidate.go +7 -3
- package/engine/internal/lib/manifest_union.go +326 -0
- package/engine/internal/lib/manifest_union_test.go +214 -0
- package/engine/internal/lib/observe_budgets.go +73 -0
- package/engine/internal/lib/observe_budgets_test.go +142 -0
- package/engine/internal/lib/observe_summary.go +74 -13
- package/engine/internal/lib/workspace_read.go +11 -6
- package/engine/internal/state/budgets.go +163 -0
- package/engine/internal/state/budgets_test.go +42 -0
- package/engine/internal/state/cursor.go +16 -10
- package/engine/internal/state/observation.go +50 -4
- package/engine/internal/state/status.go +38 -26
- package/engine/internal/state/taskgraph.go +23 -0
- package/engine/main.go +32 -13
- package/engine/root_routing_test.go +3 -1
- package/install.sh +4 -1
- package/pack/.claude/agents/devrites-code-reviewer.md +9 -6
- package/pack/.claude/agents/devrites-doubt-reviewer.md +6 -0
- package/pack/.claude/agents/devrites-plan-reviewer.md +7 -1
- package/pack/.claude/agents/devrites-slice-wright.md +42 -46
- package/pack/.claude/agents/devrites-test-analyst.md +9 -4
- package/pack/.claude/agents/devrites-upgrade-planner.md +9 -1
- package/pack/.claude/settings.json +17 -0
- package/pack/.claude/skills/devrites-api-interface/SKILL.md +2 -2
- package/pack/.claude/skills/devrites-doubt/SKILL.md +9 -17
- package/pack/.claude/skills/devrites-lib/reference/candidate-integrity.md +34 -35
- package/pack/.claude/skills/devrites-lib/reference/parallel-dispatch.md +11 -12
- package/pack/.claude/skills/devrites-lib/reference/standards/afk-hitl.md +104 -51
- package/pack/.claude/skills/devrites-lib/reference/standards/agents.md +1 -0
- package/pack/.claude/skills/devrites-lib/reference/standards/context-hygiene.md +45 -25
- package/pack/.claude/skills/devrites-lib/reference/standards/core.md +1 -1
- package/pack/.claude/skills/devrites-lib/reference/workspace-artifact-schema.md +80 -41
- package/pack/.claude/skills/rite-autocomplete/SKILL.md +19 -8
- package/pack/.claude/skills/rite-autocomplete/reference/loop.md +33 -1
- package/pack/.claude/skills/rite-build/SKILL.md +26 -19
- package/pack/.claude/skills/rite-build/reference/afk-discipline.md +1 -1
- package/pack/.claude/skills/rite-build/reference/parallel-batch.md +90 -40
- package/pack/.claude/skills/rite-build/reference/phase-contract.md +79 -59
- package/pack/.claude/skills/rite-build/reference/spec-drift-guard.md +14 -15
- package/pack/.claude/skills/rite-build/reference/wright-dispatch.md +8 -8
- package/pack/.claude/skills/rite-define/SKILL.md +4 -1
- package/pack/.claude/skills/rite-plan/SKILL.md +4 -1
- package/pack/.claude/skills/rite-plan/reference/replan-and-repair.md +21 -0
- package/pack/.claude/skills/rite-plan/reference/slicing.md +117 -15
- package/pack/.claude/skills/rite-prove/SKILL.md +20 -22
- package/pack/.claude/skills/rite-review/SKILL.md +23 -16
- package/pack/.claude/skills/rite-seal/SKILL.md +8 -8
- package/pack/.claude/skills/rite-seal/reference/final-evidence.md +6 -5
- package/pack/.claude/skills/rite-seal/reference/phase-contract.md +13 -13
- package/pack/.claude/skills/rite-ship/SKILL.md +3 -0
- package/pack/.claude/skills/rite-ship/reference/close-out.md +16 -2
- package/pack/.claude/skills/rite-ship/reference/git-ship.md +14 -5
- package/pack/.claude/skills/rite-spec/SKILL.md +6 -0
- package/pack/.claude/skills/rite-spec/reference/state-workspace.md +6 -0
- package/pack/.claude/skills/rite-status/SKILL.md +4 -1
- package/pack/.claude/skills/rite-temper/SKILL.md +14 -11
- package/pack/.claude/skills/rite-temper/reference/anti-patterns.md +14 -13
- package/pack/.claude/skills/rite-temper/reference/review-dimensions.md +3 -4
- package/pack/.claude/skills/rite-upgrade/SKILL.md +11 -2
- package/pack/.claude/skills/rite-vet/SKILL.md +22 -15
- package/pack/.claude/skills/rite-vet/reference/anti-patterns.md +11 -9
- package/pack/.claude/skills/rite-vet/reference/depth.md +6 -7
- package/pack/.claude/skills/rite-vet/reference/review-axes.md +39 -14
- package/pack/generated/README.md +5 -1
- package/pack/generated/claude/agents/devrites-code-reviewer.md +9 -6
- package/pack/generated/claude/agents/devrites-doubt-reviewer.md +6 -0
- package/pack/generated/claude/agents/devrites-plan-reviewer.md +7 -1
- package/pack/generated/claude/agents/devrites-slice-wright.md +42 -46
- package/pack/generated/claude/agents/devrites-test-analyst.md +9 -4
- package/pack/generated/claude/agents/devrites-upgrade-planner.md +9 -1
- package/pack/generated/claude/settings.json +17 -0
- package/pack/generated/claude/skills/devrites-api-interface/SKILL.md +2 -2
- package/pack/generated/claude/skills/devrites-doubt/SKILL.md +9 -17
- package/pack/generated/claude/skills/devrites-lib/reference/candidate-integrity.md +34 -35
- package/pack/generated/claude/skills/devrites-lib/reference/parallel-dispatch.md +11 -12
- package/pack/generated/claude/skills/devrites-lib/reference/standards/afk-hitl.md +104 -51
- package/pack/generated/claude/skills/devrites-lib/reference/standards/agents.md +1 -0
- package/pack/generated/claude/skills/devrites-lib/reference/standards/context-hygiene.md +45 -25
- package/pack/generated/claude/skills/devrites-lib/reference/standards/core.md +1 -1
- package/pack/generated/claude/skills/devrites-lib/reference/workspace-artifact-schema.md +80 -41
- package/pack/generated/claude/skills/rite-autocomplete/SKILL.md +19 -8
- package/pack/generated/claude/skills/rite-autocomplete/reference/loop.md +33 -1
- package/pack/generated/claude/skills/rite-build/SKILL.md +26 -19
- package/pack/generated/claude/skills/rite-build/reference/afk-discipline.md +1 -1
- package/pack/generated/claude/skills/rite-build/reference/parallel-batch.md +90 -40
- package/pack/generated/claude/skills/rite-build/reference/phase-contract.md +79 -59
- package/pack/generated/claude/skills/rite-build/reference/spec-drift-guard.md +14 -15
- package/pack/generated/claude/skills/rite-build/reference/wright-dispatch.md +8 -8
- package/pack/generated/claude/skills/rite-define/SKILL.md +4 -1
- package/pack/generated/claude/skills/rite-plan/SKILL.md +4 -1
- package/pack/generated/claude/skills/rite-plan/reference/replan-and-repair.md +21 -0
- package/pack/generated/claude/skills/rite-plan/reference/slicing.md +117 -15
- package/pack/generated/claude/skills/rite-prove/SKILL.md +20 -22
- package/pack/generated/claude/skills/rite-review/SKILL.md +23 -16
- package/pack/generated/claude/skills/rite-seal/SKILL.md +8 -8
- package/pack/generated/claude/skills/rite-seal/reference/final-evidence.md +6 -5
- package/pack/generated/claude/skills/rite-seal/reference/phase-contract.md +13 -13
- package/pack/generated/claude/skills/rite-ship/SKILL.md +3 -0
- package/pack/generated/claude/skills/rite-ship/reference/close-out.md +16 -2
- package/pack/generated/claude/skills/rite-ship/reference/git-ship.md +14 -5
- package/pack/generated/claude/skills/rite-spec/SKILL.md +6 -0
- package/pack/generated/claude/skills/rite-spec/reference/state-workspace.md +6 -0
- package/pack/generated/claude/skills/rite-status/SKILL.md +4 -1
- package/pack/generated/claude/skills/rite-temper/SKILL.md +14 -11
- package/pack/generated/claude/skills/rite-temper/reference/anti-patterns.md +14 -13
- package/pack/generated/claude/skills/rite-temper/reference/review-dimensions.md +3 -4
- package/pack/generated/claude/skills/rite-upgrade/SKILL.md +11 -2
- package/pack/generated/claude/skills/rite-vet/SKILL.md +22 -15
- package/pack/generated/claude/skills/rite-vet/reference/anti-patterns.md +11 -9
- package/pack/generated/claude/skills/rite-vet/reference/depth.md +6 -7
- package/pack/generated/claude/skills/rite-vet/reference/review-axes.md +39 -14
- package/pack/generated/codex/agents/devrites-code-reviewer.toml +9 -6
- package/pack/generated/codex/agents/devrites-doubt-reviewer.toml +6 -0
- package/pack/generated/codex/agents/devrites-plan-reviewer.toml +7 -1
- package/pack/generated/codex/agents/devrites-slice-wright.toml +42 -46
- package/pack/generated/codex/agents/devrites-test-analyst.toml +9 -4
- package/pack/generated/codex/agents/devrites-upgrade-planner.toml +9 -1
- package/pack/generated/codex/skills/devrites-api-interface/SKILL.md +2 -2
- package/pack/generated/codex/skills/devrites-doubt/SKILL.md +9 -17
- package/pack/generated/codex/skills/devrites-lib/reference/candidate-integrity.md +34 -35
- package/pack/generated/codex/skills/devrites-lib/reference/parallel-dispatch.md +11 -12
- package/pack/generated/codex/skills/devrites-lib/reference/standards/afk-hitl.md +104 -51
- package/pack/generated/codex/skills/devrites-lib/reference/standards/agents.md +1 -0
- package/pack/generated/codex/skills/devrites-lib/reference/standards/context-hygiene.md +45 -25
- package/pack/generated/codex/skills/devrites-lib/reference/standards/core.md +1 -1
- package/pack/generated/codex/skills/devrites-lib/reference/workspace-artifact-schema.md +80 -41
- package/pack/generated/codex/skills/rite-autocomplete/SKILL.md +19 -8
- package/pack/generated/codex/skills/rite-autocomplete/reference/loop.md +33 -1
- package/pack/generated/codex/skills/rite-build/SKILL.md +26 -19
- package/pack/generated/codex/skills/rite-build/reference/afk-discipline.md +1 -1
- package/pack/generated/codex/skills/rite-build/reference/parallel-batch.md +90 -40
- package/pack/generated/codex/skills/rite-build/reference/phase-contract.md +79 -59
- package/pack/generated/codex/skills/rite-build/reference/spec-drift-guard.md +14 -15
- package/pack/generated/codex/skills/rite-build/reference/wright-dispatch.md +8 -8
- package/pack/generated/codex/skills/rite-define/SKILL.md +4 -1
- package/pack/generated/codex/skills/rite-plan/SKILL.md +4 -1
- package/pack/generated/codex/skills/rite-plan/reference/replan-and-repair.md +21 -0
- package/pack/generated/codex/skills/rite-plan/reference/slicing.md +117 -15
- package/pack/generated/codex/skills/rite-prove/SKILL.md +20 -22
- package/pack/generated/codex/skills/rite-review/SKILL.md +23 -16
- package/pack/generated/codex/skills/rite-seal/SKILL.md +8 -8
- package/pack/generated/codex/skills/rite-seal/reference/final-evidence.md +6 -5
- package/pack/generated/codex/skills/rite-seal/reference/phase-contract.md +13 -13
- package/pack/generated/codex/skills/rite-ship/SKILL.md +3 -0
- package/pack/generated/codex/skills/rite-ship/reference/close-out.md +16 -2
- package/pack/generated/codex/skills/rite-ship/reference/git-ship.md +14 -5
- package/pack/generated/codex/skills/rite-spec/SKILL.md +6 -0
- package/pack/generated/codex/skills/rite-spec/reference/state-workspace.md +6 -0
- package/pack/generated/codex/skills/rite-status/SKILL.md +4 -1
- package/pack/generated/codex/skills/rite-temper/SKILL.md +14 -11
- package/pack/generated/codex/skills/rite-temper/reference/anti-patterns.md +14 -13
- package/pack/generated/codex/skills/rite-temper/reference/review-dimensions.md +3 -4
- package/pack/generated/codex/skills/rite-upgrade/SKILL.md +11 -2
- package/pack/generated/codex/skills/rite-vet/SKILL.md +22 -15
- package/pack/generated/codex/skills/rite-vet/reference/anti-patterns.md +11 -9
- package/pack/generated/codex/skills/rite-vet/reference/depth.md +6 -7
- package/pack/generated/codex/skills/rite-vet/reference/review-axes.md +39 -14
- package/pack/generated/omp/agents/devrites-code-reviewer.md +9 -6
- package/pack/generated/omp/agents/devrites-doubt-reviewer.md +6 -0
- package/pack/generated/omp/agents/devrites-plan-reviewer.md +7 -1
- package/pack/generated/omp/agents/devrites-slice-wright.md +42 -46
- package/pack/generated/omp/agents/devrites-test-analyst.md +9 -4
- package/pack/generated/omp/agents/devrites-upgrade-planner.md +9 -1
- package/pack/generated/omp/skills/devrites-api-interface/SKILL.md +2 -2
- package/pack/generated/omp/skills/devrites-doubt/SKILL.md +9 -17
- package/pack/generated/omp/skills/devrites-lib/reference/candidate-integrity.md +34 -35
- package/pack/generated/omp/skills/devrites-lib/reference/parallel-dispatch.md +11 -12
- package/pack/generated/omp/skills/devrites-lib/reference/standards/afk-hitl.md +104 -51
- package/pack/generated/omp/skills/devrites-lib/reference/standards/agents.md +1 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/context-hygiene.md +45 -25
- package/pack/generated/omp/skills/devrites-lib/reference/standards/core.md +1 -1
- package/pack/generated/omp/skills/devrites-lib/reference/workspace-artifact-schema.md +80 -41
- package/pack/generated/omp/skills/rite-autocomplete/SKILL.md +19 -8
- package/pack/generated/omp/skills/rite-autocomplete/reference/loop.md +33 -1
- package/pack/generated/omp/skills/rite-build/SKILL.md +26 -19
- package/pack/generated/omp/skills/rite-build/reference/afk-discipline.md +1 -1
- package/pack/generated/omp/skills/rite-build/reference/parallel-batch.md +90 -40
- package/pack/generated/omp/skills/rite-build/reference/phase-contract.md +79 -59
- package/pack/generated/omp/skills/rite-build/reference/spec-drift-guard.md +14 -15
- package/pack/generated/omp/skills/rite-build/reference/wright-dispatch.md +8 -8
- package/pack/generated/omp/skills/rite-define/SKILL.md +4 -1
- package/pack/generated/omp/skills/rite-plan/SKILL.md +4 -1
- package/pack/generated/omp/skills/rite-plan/reference/replan-and-repair.md +21 -0
- package/pack/generated/omp/skills/rite-plan/reference/slicing.md +117 -15
- package/pack/generated/omp/skills/rite-prove/SKILL.md +20 -22
- package/pack/generated/omp/skills/rite-review/SKILL.md +23 -16
- package/pack/generated/omp/skills/rite-seal/SKILL.md +8 -8
- package/pack/generated/omp/skills/rite-seal/reference/final-evidence.md +6 -5
- package/pack/generated/omp/skills/rite-seal/reference/phase-contract.md +13 -13
- package/pack/generated/omp/skills/rite-ship/SKILL.md +3 -0
- package/pack/generated/omp/skills/rite-ship/reference/close-out.md +16 -2
- package/pack/generated/omp/skills/rite-ship/reference/git-ship.md +14 -5
- package/pack/generated/omp/skills/rite-spec/SKILL.md +6 -0
- package/pack/generated/omp/skills/rite-spec/reference/state-workspace.md +6 -0
- package/pack/generated/omp/skills/rite-status/SKILL.md +4 -1
- package/pack/generated/omp/skills/rite-temper/SKILL.md +14 -11
- package/pack/generated/omp/skills/rite-temper/reference/anti-patterns.md +14 -13
- package/pack/generated/omp/skills/rite-temper/reference/review-dimensions.md +3 -4
- package/pack/generated/omp/skills/rite-upgrade/SKILL.md +11 -2
- package/pack/generated/omp/skills/rite-vet/SKILL.md +22 -15
- package/pack/generated/omp/skills/rite-vet/reference/anti-patterns.md +11 -9
- package/pack/generated/omp/skills/rite-vet/reference/depth.md +6 -7
- package/pack/generated/omp/skills/rite-vet/reference/review-axes.md +39 -14
- package/pack/generated/pi/AGENTS.md +22 -0
- package/pack/generated/pi/agents/devrites-code-reviewer.md +142 -0
- package/pack/generated/pi/agents/devrites-devex-reviewer.md +124 -0
- package/pack/generated/pi/agents/devrites-doubt-reviewer.md +88 -0
- package/pack/generated/pi/agents/devrites-evidence-scout.md +72 -0
- package/pack/generated/pi/agents/devrites-frontend-reviewer.md +116 -0
- package/pack/generated/pi/agents/devrites-performance-reviewer.md +115 -0
- package/pack/generated/pi/agents/devrites-plan-drafter.md +99 -0
- package/pack/generated/pi/agents/devrites-plan-reviewer.md +142 -0
- package/pack/generated/pi/agents/devrites-proof-runner.md +74 -0
- package/pack/generated/pi/agents/devrites-retrospector.md +61 -0
- package/pack/generated/pi/agents/devrites-security-auditor.md +109 -0
- package/pack/generated/pi/agents/devrites-simplifier-reviewer.md +94 -0
- package/pack/generated/pi/agents/devrites-slice-wright.md +204 -0
- package/pack/generated/pi/agents/devrites-spec-reviewer.md +96 -0
- package/pack/generated/pi/agents/devrites-strategy-reviewer.md +100 -0
- package/pack/generated/pi/agents/devrites-test-analyst.md +94 -0
- package/pack/generated/pi/agents/devrites-upgrade-planner.md +89 -0
- package/pack/generated/pi/prompts/rite-adopt.md +5 -0
- package/pack/generated/pi/prompts/rite-autocomplete.md +5 -0
- package/pack/generated/pi/prompts/rite-build.md +5 -0
- package/pack/generated/pi/prompts/rite-clarify.md +5 -0
- package/pack/generated/pi/prompts/rite-converge.md +5 -0
- package/pack/generated/pi/prompts/rite-customize.md +5 -0
- package/pack/generated/pi/prompts/rite-define.md +5 -0
- package/pack/generated/pi/prompts/rite-doctor.md +5 -0
- package/pack/generated/pi/prompts/rite-dogfood.md +5 -0
- package/pack/generated/pi/prompts/rite-explain.md +5 -0
- package/pack/generated/pi/prompts/rite-frame.md +5 -0
- package/pack/generated/pi/prompts/rite-handoff.md +5 -0
- package/pack/generated/pi/prompts/rite-learn.md +5 -0
- package/pack/generated/pi/prompts/rite-plan.md +5 -0
- package/pack/generated/pi/prompts/rite-polish.md +5 -0
- package/pack/generated/pi/prompts/rite-pov.md +5 -0
- package/pack/generated/pi/prompts/rite-pr-feedback.md +5 -0
- package/pack/generated/pi/prompts/rite-pressure-test.md +5 -0
- package/pack/generated/pi/prompts/rite-prototype.md +5 -0
- package/pack/generated/pi/prompts/rite-prove.md +5 -0
- package/pack/generated/pi/prompts/rite-quick.md +5 -0
- package/pack/generated/pi/prompts/rite-resolve.md +5 -0
- package/pack/generated/pi/prompts/rite-review.md +5 -0
- package/pack/generated/pi/prompts/rite-seal.md +5 -0
- package/pack/generated/pi/prompts/rite-ship.md +5 -0
- package/pack/generated/pi/prompts/rite-spec.md +5 -0
- package/pack/generated/pi/prompts/rite-status.md +5 -0
- package/pack/generated/pi/prompts/rite-temper.md +5 -0
- package/pack/generated/pi/prompts/rite-upgrade.md +5 -0
- package/pack/generated/pi/prompts/rite-vet.md +5 -0
- package/pack/generated/pi/prompts/rite-watch-pr.md +5 -0
- package/pack/generated/pi/prompts/rite-zoom-out.md +5 -0
- package/pack/generated/pi/prompts/rite.md +5 -0
- package/pack/generated/pi/skills/devrites-api-interface/SKILL.md +63 -0
- package/pack/generated/pi/skills/devrites-audit/SKILL.md +50 -0
- package/pack/generated/pi/skills/devrites-browser-proof/SKILL.md +76 -0
- package/pack/generated/pi/skills/devrites-browser-proof/reference/browser-performance.md +15 -0
- package/pack/generated/pi/skills/devrites-browser-proof/reference/visual-verdict.md +34 -0
- package/pack/generated/pi/skills/devrites-debug-recovery/SKILL.md +96 -0
- package/pack/generated/pi/skills/devrites-debug-recovery/reference/build-the-loop.md +58 -0
- package/pack/generated/pi/skills/devrites-debug-recovery/reference/cleanup-and-classify.md +34 -0
- package/pack/generated/pi/skills/devrites-debug-recovery/reference/hypotheses.md +17 -0
- package/pack/generated/pi/skills/devrites-debug-recovery/reference/instrumentation.md +21 -0
- package/pack/generated/pi/skills/devrites-debug-recovery/reference/regression-test.md +30 -0
- package/pack/generated/pi/skills/devrites-debug-recovery/reference/trace.md +25 -0
- package/pack/generated/pi/skills/devrites-doubt/SKILL.md +79 -0
- package/pack/generated/pi/skills/devrites-frontend-craft/SKILL.md +86 -0
- package/pack/generated/pi/skills/devrites-frontend-craft/reference/craft.md +63 -0
- package/pack/generated/pi/skills/devrites-frontend-craft/reference/design-references.md +116 -0
- package/pack/generated/pi/skills/devrites-frontend-craft/reference/fullstack.md +46 -0
- package/pack/generated/pi/skills/devrites-frontend-craft/reference/quality-standards.md +294 -0
- package/pack/generated/pi/skills/devrites-frontend-craft/reference/reuse-first.md +53 -0
- package/pack/generated/pi/skills/devrites-frontend-craft/reference/shape.md +56 -0
- package/pack/generated/pi/skills/devrites-interview/SKILL.md +102 -0
- package/pack/generated/pi/skills/devrites-lib/SKILL.md +58 -0
- package/pack/generated/pi/skills/devrites-lib/reference/candidate-integrity.md +42 -0
- package/pack/generated/pi/skills/devrites-lib/reference/intent-map.md +64 -0
- package/pack/generated/pi/skills/devrites-lib/reference/orchestration-profiles.md +27 -0
- package/pack/generated/pi/skills/devrites-lib/reference/parallel-dispatch.md +73 -0
- package/pack/generated/pi/skills/devrites-lib/reference/reply-contract.md +88 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/README.md +60 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/acceptance-preserving-reslice.md +30 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/afk-hitl.md +398 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/agents.md +99 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/anti-patterns.md +48 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/browser-proof-checklist.md +24 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/ci-cd.md +50 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/code-navigation.md +43 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/code-review.md +108 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/coding-style.md +48 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/context-hygiene.md +109 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/core.md +167 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/data-integrity.md +118 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/debug-recovery.md +28 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/definition-of-done.md +19 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/deprecation.md +31 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/developer-experience.md +119 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/development-workflow.md +29 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/documentation.md +43 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/edge-case-trace.md +92 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/elicitation.md +85 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/error-handling.md +47 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/git-workflow.md +49 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/hooks.md +25 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/integration-reliability.md +102 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/loop-operations.md +85 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/observability.md +88 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/one-shot-actions.md +97 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/patterns.md +68 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/performance.md +51 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/principles.md +42 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/prose-style.md +123 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/release/ship-checklist.md +8 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/repository-topology.md +80 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/review-checklist.md +12 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/security-checklist.md +25 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/security.md +202 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/skill-authoring.md +209 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/spec-grammar.md +197 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/test-proof-checklist.md +13 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/testing.md +212 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/tooling.md +92 -0
- package/pack/generated/pi/skills/devrites-lib/reference/standards/workflow-artifacts.md +427 -0
- package/pack/generated/pi/skills/devrites-lib/reference/visual-playbooks/code.md +44 -0
- package/pack/generated/pi/skills/devrites-lib/reference/visual-playbooks/comparison.md +42 -0
- package/pack/generated/pi/skills/devrites-lib/reference/visual-playbooks/diagram.md +51 -0
- package/pack/generated/pi/skills/devrites-lib/reference/visual-playbooks/index.md +66 -0
- package/pack/generated/pi/skills/devrites-lib/reference/visual-playbooks/input.md +46 -0
- package/pack/generated/pi/skills/devrites-lib/reference/visual-playbooks/outline-template.md +106 -0
- package/pack/generated/pi/skills/devrites-lib/reference/visual-playbooks/plan.md +48 -0
- package/pack/generated/pi/skills/devrites-lib/reference/visual-playbooks/slides.md +40 -0
- package/pack/generated/pi/skills/devrites-lib/reference/visual-playbooks/table.md +42 -0
- package/pack/generated/pi/skills/devrites-lib/reference/workspace-artifact-schema.md +267 -0
- package/pack/generated/pi/skills/devrites-prose-craft/SKILL.md +73 -0
- package/pack/generated/pi/skills/devrites-prose-craft/reference/banned-phrases.md +132 -0
- package/pack/generated/pi/skills/devrites-prose-craft/reference/examples.md +131 -0
- package/pack/generated/pi/skills/devrites-prose-craft/reference/structures.md +196 -0
- package/pack/generated/pi/skills/devrites-source-driven/SKILL.md +52 -0
- package/pack/generated/pi/skills/devrites-ux-shape/SKILL.md +134 -0
- package/pack/generated/pi/skills/devrites-ux-shape/reference/brief-template.md +108 -0
- package/pack/generated/pi/skills/devrites-ux-shape/reference/visual-direction-probe.md +48 -0
- package/pack/generated/pi/skills/rite/SKILL.md +148 -0
- package/pack/generated/pi/skills/rite/reference/menu.md +48 -0
- package/pack/generated/pi/skills/rite-adopt/SKILL.md +52 -0
- package/pack/generated/pi/skills/rite-adopt/reference/adoption.md +19 -0
- package/pack/generated/pi/skills/rite-adopt/reference/anti-patterns.md +19 -0
- package/pack/generated/pi/skills/rite-autocomplete/SKILL.md +132 -0
- package/pack/generated/pi/skills/rite-autocomplete/reference/decision-policy.md +41 -0
- package/pack/generated/pi/skills/rite-autocomplete/reference/loop.md +148 -0
- package/pack/generated/pi/skills/rite-autocomplete/reference/stop-conditions.md +92 -0
- package/pack/generated/pi/skills/rite-build/SKILL.md +96 -0
- package/pack/generated/pi/skills/rite-build/reference/afk-discipline.md +145 -0
- package/pack/generated/pi/skills/rite-build/reference/anti-patterns.md +23 -0
- package/pack/generated/pi/skills/rite-build/reference/checkpoint-protocol.md +120 -0
- package/pack/generated/pi/skills/rite-build/reference/checkpoint.md +44 -0
- package/pack/generated/pi/skills/rite-build/reference/frontend-trigger.md +39 -0
- package/pack/generated/pi/skills/rite-build/reference/one-slice-cycle.md +50 -0
- package/pack/generated/pi/skills/rite-build/reference/output.md +33 -0
- package/pack/generated/pi/skills/rite-build/reference/parallel-batch.md +205 -0
- package/pack/generated/pi/skills/rite-build/reference/phase-contract.md +87 -0
- package/pack/generated/pi/skills/rite-build/reference/spec-drift-guard.md +84 -0
- package/pack/generated/pi/skills/rite-build/reference/tdd.md +27 -0
- package/pack/generated/pi/skills/rite-build/reference/wright-dispatch.md +89 -0
- package/pack/generated/pi/skills/rite-clarify/SKILL.md +99 -0
- package/pack/generated/pi/skills/rite-clarify/reference/anti-patterns.md +24 -0
- package/pack/generated/pi/skills/rite-clarify/reference/decision-coverage.md +55 -0
- package/pack/generated/pi/skills/rite-converge/SKILL.md +145 -0
- package/pack/generated/pi/skills/rite-converge/reference/anti-patterns.md +35 -0
- package/pack/generated/pi/skills/rite-converge/reference/convergence-assessment.md +65 -0
- package/pack/generated/pi/skills/rite-customize/SKILL.md +60 -0
- package/pack/generated/pi/skills/rite-define/SKILL.md +169 -0
- package/pack/generated/pi/skills/rite-define/reference/anti-patterns.md +26 -0
- package/pack/generated/pi/skills/rite-define/reference/gates.md +154 -0
- package/pack/generated/pi/skills/rite-define/reference/plan-template.md +149 -0
- package/pack/generated/pi/skills/rite-doctor/SKILL.md +69 -0
- package/pack/generated/pi/skills/rite-dogfood/SKILL.md +55 -0
- package/pack/generated/pi/skills/rite-explain/SKILL.md +152 -0
- package/pack/generated/pi/skills/rite-explain/reference/intake.md +89 -0
- package/pack/generated/pi/skills/rite-frame/SKILL.md +115 -0
- package/pack/generated/pi/skills/rite-frame/reference/failure-modes.md +66 -0
- package/pack/generated/pi/skills/rite-handoff/SKILL.md +97 -0
- package/pack/generated/pi/skills/rite-handoff/reference/handoff-template.md +44 -0
- package/pack/generated/pi/skills/rite-learn/SKILL.md +72 -0
- package/pack/generated/pi/skills/rite-plan/SKILL.md +186 -0
- package/pack/generated/pi/skills/rite-plan/reference/anti-patterns.md +34 -0
- package/pack/generated/pi/skills/rite-plan/reference/dependency-graph.md +48 -0
- package/pack/generated/pi/skills/rite-plan/reference/replan-and-repair.md +105 -0
- package/pack/generated/pi/skills/rite-plan/reference/slicing.md +167 -0
- package/pack/generated/pi/skills/rite-plan/reference/task-breakdown.md +42 -0
- package/pack/generated/pi/skills/rite-polish/SKILL.md +104 -0
- package/pack/generated/pi/skills/rite-polish/reference/adr-promotion.md +11 -0
- package/pack/generated/pi/skills/rite-polish/reference/anti-ai-slop.md +187 -0
- package/pack/generated/pi/skills/rite-polish/reference/anti-patterns.md +30 -0
- package/pack/generated/pi/skills/rite-polish/reference/backend-polish.md +80 -0
- package/pack/generated/pi/skills/rite-polish/reference/browser-polish-evidence.md +33 -0
- package/pack/generated/pi/skills/rite-polish/reference/code.md +82 -0
- package/pack/generated/pi/skills/rite-polish/reference/design-memory.md +117 -0
- package/pack/generated/pi/skills/rite-polish/reference/design-system-discovery.md +8 -0
- package/pack/generated/pi/skills/rite-polish/reference/harden-checklist.md +109 -0
- package/pack/generated/pi/skills/rite-polish/reference/ledger.md +65 -0
- package/pack/generated/pi/skills/rite-polish/reference/ui.md +137 -0
- package/pack/generated/pi/skills/rite-pov/SKILL.md +58 -0
- package/pack/generated/pi/skills/rite-pr-feedback/SKILL.md +54 -0
- package/pack/generated/pi/skills/rite-pressure-test/SKILL.md +67 -0
- package/pack/generated/pi/skills/rite-prototype/SKILL.md +104 -0
- package/pack/generated/pi/skills/rite-prove/SKILL.md +120 -0
- package/pack/generated/pi/skills/rite-prove/reference/acceptance-proof.md +88 -0
- package/pack/generated/pi/skills/rite-prove/reference/anti-patterns.md +25 -0
- package/pack/generated/pi/skills/rite-prove/reference/browser-proof.md +51 -0
- package/pack/generated/pi/skills/rite-prove/reference/failure-triage.md +43 -0
- package/pack/generated/pi/skills/rite-prove/reference/proof-ladder.md +28 -0
- package/pack/generated/pi/skills/rite-prove/reference/test-command-discovery.md +30 -0
- package/pack/generated/pi/skills/rite-quick/SKILL.md +82 -0
- package/pack/generated/pi/skills/rite-resolve/SKILL.md +95 -0
- package/pack/generated/pi/skills/rite-resolve/reference/answer-protocol.md +118 -0
- package/pack/generated/pi/skills/rite-review/SKILL.md +170 -0
- package/pack/generated/pi/skills/rite-review/reference/anti-patterns.md +32 -0
- package/pack/generated/pi/skills/rite-review/reference/cognitive-load.md +90 -0
- package/pack/generated/pi/skills/rite-review/reference/feature-scoped-review.md +26 -0
- package/pack/generated/pi/skills/rite-review/reference/five-axis-review.md +66 -0
- package/pack/generated/pi/skills/rite-review/reference/nielsen-heuristics.md +126 -0
- package/pack/generated/pi/skills/rite-review/reference/performance-checklist.md +80 -0
- package/pack/generated/pi/skills/rite-review/reference/performance-review.md +14 -0
- package/pack/generated/pi/skills/rite-review/reference/security-review.md +42 -0
- package/pack/generated/pi/skills/rite-seal/SKILL.md +75 -0
- package/pack/generated/pi/skills/rite-seal/reference/anti-patterns.md +29 -0
- package/pack/generated/pi/skills/rite-seal/reference/final-evidence.md +41 -0
- package/pack/generated/pi/skills/rite-seal/reference/go-no-go.md +29 -0
- package/pack/generated/pi/skills/rite-seal/reference/output.md +5 -0
- package/pack/generated/pi/skills/rite-seal/reference/phase-contract.md +47 -0
- package/pack/generated/pi/skills/rite-seal/reference/risk-and-rollback.md +56 -0
- package/pack/generated/pi/skills/rite-seal/reference/seal-template.md +27 -0
- package/pack/generated/pi/skills/rite-ship/SKILL.md +88 -0
- package/pack/generated/pi/skills/rite-ship/reference/anti-patterns.md +28 -0
- package/pack/generated/pi/skills/rite-ship/reference/close-out.md +68 -0
- package/pack/generated/pi/skills/rite-ship/reference/git-ship.md +120 -0
- package/pack/generated/pi/skills/rite-ship/reference/rollout.md +62 -0
- package/pack/generated/pi/skills/rite-ship/reference/ship-template.md +39 -0
- package/pack/generated/pi/skills/rite-spec/SKILL.md +150 -0
- package/pack/generated/pi/skills/rite-spec/reference/acceptance-criteria.md +31 -0
- package/pack/generated/pi/skills/rite-spec/reference/ai-spec-template.md +40 -0
- package/pack/generated/pi/skills/rite-spec/reference/anti-patterns.md +27 -0
- package/pack/generated/pi/skills/rite-spec/reference/interview-patterns.md +56 -0
- package/pack/generated/pi/skills/rite-spec/reference/investigation.md +83 -0
- package/pack/generated/pi/skills/rite-spec/reference/question-protocol.md +36 -0
- package/pack/generated/pi/skills/rite-spec/reference/references-intake.md +62 -0
- package/pack/generated/pi/skills/rite-spec/reference/spec-checklists.md +89 -0
- package/pack/generated/pi/skills/rite-spec/reference/spec-template.md +154 -0
- package/pack/generated/pi/skills/rite-spec/reference/state-workspace.md +227 -0
- package/pack/generated/pi/skills/rite-status/SKILL.md +57 -0
- package/pack/generated/pi/skills/rite-temper/SKILL.md +130 -0
- package/pack/generated/pi/skills/rite-temper/reference/anti-patterns.md +30 -0
- package/pack/generated/pi/skills/rite-temper/reference/review-dimensions.md +66 -0
- package/pack/generated/pi/skills/rite-temper/reference/scope-modes.md +53 -0
- package/pack/generated/pi/skills/rite-temper/reference/significance.md +46 -0
- package/pack/generated/pi/skills/rite-temper/reference/strategy-template.md +90 -0
- package/pack/generated/pi/skills/rite-upgrade/SKILL.md +121 -0
- package/pack/generated/pi/skills/rite-vet/SKILL.md +193 -0
- package/pack/generated/pi/skills/rite-vet/reference/anti-patterns.md +43 -0
- package/pack/generated/pi/skills/rite-vet/reference/artifacts.md +202 -0
- package/pack/generated/pi/skills/rite-vet/reference/cross-model.md +19 -0
- package/pack/generated/pi/skills/rite-vet/reference/depth.md +59 -0
- package/pack/generated/pi/skills/rite-vet/reference/eng-lenses.md +48 -0
- package/pack/generated/pi/skills/rite-vet/reference/review-axes.md +201 -0
- package/pack/generated/pi/skills/rite-watch-pr/SKILL.md +85 -0
- package/pack/generated/pi/skills/rite-zoom-out/SKILL.md +69 -0
- package/package.json +3 -2
- package/scripts/build-host-artifacts.sh +54 -4
- package/scripts/codex-generate.sh +6 -0
- package/scripts/pi-generate.sh +198 -0
|
@@ -16,7 +16,10 @@ Use the supplied slug or `.devrites/ACTIVE`; require its authoritative
|
|
|
16
16
|
`state.md` and read the cursor directly. Read question, evidence, and risk
|
|
17
17
|
artifacts only as needed. Never infer lifecycle state from `README.md` or chat.
|
|
18
18
|
|
|
19
|
-
If no workspace exists
|
|
19
|
+
If no workspace exists: when archived workspaces record an unfinished
|
|
20
|
+
[continuation sequence](../rite-plan/reference/slicing.md#continuation-workspaces),
|
|
21
|
+
list each next command (`$rite-spec <parent>-<n> "<objective>"`); otherwise
|
|
22
|
+
recommend `$rite-spec <feature>`. Then stop.
|
|
20
23
|
|
|
21
24
|
If `state.md` is unreadable/malformed: report a gap with the defect and stop — never infer the phase from other files; `$rite-doctor`/`$rite-upgrade` own repair.
|
|
22
25
|
|
|
@@ -7,8 +7,7 @@ user-invocable: true
|
|
|
7
7
|
|
|
8
8
|
# $rite-temper: review scope and risk before planning
|
|
9
9
|
|
|
10
|
-
Review
|
|
11
|
-
solution surface. Fold accepted decisions into the canonical contract before
|
|
10
|
+
Review the readied spec for ambition, scope, pre-mortem risk and unnecessary surface. Fold accepted decisions into the canonical contract before
|
|
12
11
|
`$rite-define`. This step is optional for small work and skips low-stakes specs, but
|
|
13
12
|
`$rite-autocomplete` always invokes it. **Read the active workspace first**; if there
|
|
14
13
|
is no readied `spec.md`, tell the user to run `$rite-spec`. Review depth follows
|
|
@@ -58,6 +57,10 @@ the spec applicability map triggers that risk family.
|
|
|
58
57
|
First, the **one-sentence-intent test**: state the whole change's intent in a single sentence.
|
|
59
58
|
If you can't without an "and" that joins two unrelated outcomes, it is **two features**: the
|
|
60
59
|
scope-creep signal; recommend splitting or narrowing the spec before continuing.
|
|
60
|
+
Apply the same test to size: a spec whose honest decomposition would exceed the
|
|
61
|
+
[feature ceiling](../rite-plan/reference/slicing.md#feature-ceiling-split-an-epic-never-override-the-budget)
|
|
62
|
+
(roughly ten slices or more than ~20 acceptance criteria) is a feature sequence;
|
|
63
|
+
recommend the thinnest shippable subset now and name the continuations as Non-goals.
|
|
61
64
|
Then consider the 10-star outcome for the underlying problem and choose **exactly one**
|
|
62
65
|
scope mode (`expand` opt-in · `selective` · `hold-rigor` · `reduce-to-MVP`) with its
|
|
63
66
|
rationale and the condition that would change the choice. `$ARGUMENTS` `--mode` is a
|
|
@@ -106,19 +109,19 @@ the spec applicability map triggers that risk family.
|
|
|
106
109
|
and closed gates. Partial/Missing, an unowned material assumption, or an open
|
|
107
110
|
blocking/escalating question routes `$rite-clarify`/HITL. Only after the
|
|
108
111
|
matrix is re-closed may the phase advance.
|
|
109
|
-
|
|
110
|
-
|
|
111
|
-
|
|
112
|
+
Set `Phase: temper`; `Next step: $rite-define` only after verification.
|
|
113
|
+
Human-owned expansion/unapproved irreversible choices set `Awaiting human` +
|
|
114
|
+
`Status: awaiting_human`; objective below-bar findings continue correction.
|
|
112
115
|
7. **Adversarial verification loop:** ask the exact
|
|
113
116
|
[`devrites-strategy-reviewer`](.codex/agents/devrites-strategy-reviewer.toml)
|
|
114
117
|
through the native fresh-context contract in
|
|
115
118
|
[`agents.md`](../devrites-lib/reference/standards/agents.md), with **only** the hardened
|
|
116
|
-
spec + rubric
|
|
117
|
-
|
|
118
|
-
|
|
119
|
-
|
|
120
|
-
|
|
121
|
-
|
|
119
|
+
spec + rubric, no authoring reasoning. Fold technical findings into one correction;
|
|
120
|
+
exact strategy reviewer rechecks open findings and affected coverage/regressions under
|
|
121
|
+
[the canonical retry contract](../devrites-lib/reference/standards/afk-hitl.md#retry-cap-no-progress-loops-and-self-resolve):
|
|
122
|
+
Product/scope choices and unapproved irreversible risk remain human gates;
|
|
123
|
+
technical exhaustion preserves blocker/reproduction.
|
|
124
|
+
If the named agent is unavailable, stop for HITL. After an accepted edit to a
|
|
122
125
|
coverage-bound input, repeat step 6's native coverage revalidation before handoff.
|
|
123
126
|
8. **STOP.** Report the mode, the scope deltas, and the floor verdict; recommend `$rite-define`.
|
|
124
127
|
|
|
@@ -1,29 +1,30 @@
|
|
|
1
1
|
# $rite-temper: anti-patterns
|
|
2
2
|
|
|
3
|
-
|
|
4
|
-
[`../../devrites-lib/reference/standards/anti-patterns.md`](../../devrites-lib/reference/standards/anti-patterns.md): read it when the
|
|
5
|
-
reluctance is broader than this phase. Below are the temper-specific ones.
|
|
3
|
+
For cross-phase issues, read [universal anti-patterns](../../devrites-lib/reference/standards/anti-patterns.md).
|
|
6
4
|
|
|
7
5
|
## Phase rationalizations
|
|
8
6
|
|
|
9
7
|
| Excuse | Rebuttal |
|
|
10
8
|
|---|---|
|
|
11
|
-
| "I'll write all the findings into `strategy.md` and let the user read it." |
|
|
9
|
+
| "I'll write all the findings into `strategy.md` and let the user read it." | Fold and recheck objective corrections preserving scope, behavior, and risk policy. Ask human-owned strategy/acceptance choices with recommendations and await answers. Recording alone resolves nothing; never silently expand or trim the spec. |
|
|
12
10
|
| "Bigger is better: let's add the extra capability while we're thinking big." | Ambition belongs on the **outcome**, not the **solution surface**. A speculative capability/abstraction is gold plating. Expand the problem + acceptance; never the machinery. |
|
|
13
11
|
| "The user obviously wants the ambitious version. I'll add it to the spec." | Expansion is **opt-in**, recorded, and confirmed (HITL) or paused (AFK). Adding acceptance the human didn't approve is silent scope growth: route it through the Spec Drift Guard or don't add it. |
|
|
14
12
|
| "It's over-scoped, I'll just trim those criteria." | Reducing scope is **still a spec change**. Cut acceptance only as a recorded Spec-Drift-Guard decision, and park the rest in Non-goals with a revisit note: never a silent trim. |
|
|
15
|
-
| "This dimension is weak but the others are strong: net it's fine." | The gate is the **floor**, not the average
|
|
16
|
-
| "I can see it's adequate. I'll note the band, evidence is obvious." | Cite
|
|
13
|
+
| "This dimension is weak but the others are strong: net it's fine." | The gate is the **floor**, not the average; strong clarity cannot offset broken risk. |
|
|
14
|
+
| "I can see it's adequate. I'll note the band, evidence is obvious." | Cite spec evidence **before** the band; never score first and rationalize later. |
|
|
17
15
|
| "It's a strategy doc, the implementation concerns don't apply yet." | Cross-cutting concerns (security/data/observability/modifiability) are where strategy breaks down. Address each or mark it explicitly N/A: silent omission is a gap. |
|
|
18
|
-
| "This greenfield design is elegant." |
|
|
16
|
+
| "This greenfield design is elegant." | Ground ambition in live seams/blast radius; a new dependency or second design system needs an explicit decision. |
|
|
19
17
|
|
|
20
18
|
## Red flags
|
|
21
|
-
-
|
|
22
|
-
|
|
23
|
-
- An `expand` decision auto-applied in AFK
|
|
24
|
-
|
|
19
|
+
- An accepted strategy change recorded in `strategy.md` but not reflected in its
|
|
20
|
+
owning spec acceptance/Non-goals. A clean review does not require gratuitous spec edits.
|
|
21
|
+
- An `expand` decision auto-applied in AFK, an unapproved risk-policy change, or an
|
|
22
|
+
irreversible operation without its required authorization.
|
|
25
23
|
- A pre-mortem with risks listed but no mitigation + owning slice: a risk without an owner is a
|
|
26
24
|
wish.
|
|
27
|
-
-
|
|
28
|
-
|
|
25
|
+
- Repeating an exhausted causal failure under the shared no-progress rule in
|
|
26
|
+
[`afk-hitl.md`](../../devrites-lib/reference/standards/afk-hitl.md), or stopping a
|
|
27
|
+
distinct cause solely because the total review round exceeds three.
|
|
28
|
+
- The reviewer being handed the author's reasoning as independent evidence
|
|
29
|
+
(defeats the fresh-context point).
|
|
29
30
|
- The skill writing a `plan.md`, slicing, or touching code. That's `$rite-define` / `$rite-build`.
|
|
@@ -61,7 +61,6 @@ justifies it. Review a borderline dimension twice if needed and use the **lower*
|
|
|
61
61
|
irreversibility & #9 convention-fit both touch codebase realism; #1 ambition & #2 scope both
|
|
62
62
|
touch over/under-reach). Don't fail two dimensions for the *same* root cause: cite the
|
|
63
63
|
evidence once and assign one band so one problem does not create two floor failures.
|
|
64
|
-
- Below-bar
|
|
65
|
-
|
|
66
|
-
|
|
67
|
-
always pause regardless of band.
|
|
64
|
+
- Below-bar blocks readiness; objective fixes return to the caller under
|
|
65
|
+
[the canonical retry contract](../../devrites-lib/reference/standards/afk-hitl.md#retry-cap-no-progress-loops-and-self-resolve).
|
|
66
|
+
Human-owned scope/risk choices keep their gate; exhaustion blocks technically.
|
|
@@ -29,7 +29,7 @@ references, and only current phase contracts needed for the observed gap.
|
|
|
29
29
|
a current rule, exact workspace evidence, affected gate, owning rite, exact paths, and
|
|
30
30
|
the smallest behavior-neutral delta.
|
|
31
31
|
- Existing rites own semantic changes. Upgrade may sequence `$rite-clarify`,
|
|
32
|
-
`$rite-plan repair`, `$rite-converge`, `$rite-vet`, `$rite-prove`, `$rite-polish`,
|
|
32
|
+
`$rite-plan repair|revise|course-correct`, `$rite-converge`, `$rite-vet`, `$rite-prove`, `$rite-polish`,
|
|
33
33
|
`$rite-review`, and `$rite-seal`; it never reimplements them or starts Build or Ship.
|
|
34
34
|
`$rite-doctor` owns install/config diagnosis.
|
|
35
35
|
- An admitted candidate route may name only the exact current gate artifacts its owner
|
|
@@ -50,7 +50,9 @@ references, and only current phase contracts needed for the observed gap.
|
|
|
50
50
|
Archive-only is `current`; otherwise require contained regular `state.md` and read its
|
|
51
51
|
cursor. A damaged/mismatched install stops at Doctor; missing live work routes
|
|
52
52
|
`$rite-spec`; `done` is `current`. An unknown cursor is `unsupported`.
|
|
53
|
-
1. **Freeze preservation evidence.** Record `git status --short`, cursor form/fields,
|
|
53
|
+
1. **Freeze preservation evidence.** Record `git status --short`, cursor form/fields,
|
|
54
|
+
`devrites-engine orient <slug>` (cursor, `task_graph`, `artifact_budgets`,
|
|
55
|
+
`bulk_files`), and
|
|
54
56
|
hashes of completed-slice fields, candidate gate artifacts, existing answers/decisions,
|
|
55
57
|
and protected history. Inventory every path that could change; absence is evidence,
|
|
56
58
|
never permission to synthesize history. For a post-Build workspace, also retain the
|
|
@@ -69,6 +71,13 @@ references, and only current phase contracts needed for the observed gap.
|
|
|
69
71
|
one at a time:
|
|
70
72
|
- decision coverage or a material assumption → `$rite-clarify`;
|
|
71
73
|
- stale/inconsistent planning or traceability with settled intent → `$rite-plan repair`;
|
|
74
|
+
- over-budget `state.md` or planning artifacts carrying checkpoint narrative, or
|
|
75
|
+
packets/traces in the workspace root → `$rite-plan revise` (verbatim relocation to
|
|
76
|
+
`history/` / `packets/`, current view only; IDs, meaning, answers and decisions
|
|
77
|
+
unchanged; nothing deleted);
|
|
78
|
+
- unbuilt slices beyond the [feature ceiling](../rite-plan/reference/slicing.md#feature-ceiling-split-an-epic-never-override-the-budget)
|
|
79
|
+
→ `$rite-plan course-correct` (`MVP cut` plus the named continuation sequence;
|
|
80
|
+
built slices and their evidence stay);
|
|
72
81
|
- live code and recorded intent disagreement → `$rite-converge`;
|
|
73
82
|
- any changed planning input or readiness defect → `$rite-vet`;
|
|
74
83
|
- a missing/malformed strict manifest, missing/malformed/mismatched evidence binding,
|
|
@@ -7,10 +7,9 @@ user-invocable: true
|
|
|
7
7
|
|
|
8
8
|
# $rite-vet: review the plan before build
|
|
9
9
|
|
|
10
|
-
Vet every plan
|
|
11
|
-
|
|
12
|
-
|
|
13
|
-
scope, Vet owns implementation; current `$ARGUMENTS` (`--full`) feeds the depth triggers in
|
|
10
|
+
Vet every plan's scope, architecture, quality, proof, performance, failures and writer
|
|
11
|
+
safety. Fold cited technical findings; design Build tests. Temper owns product;
|
|
12
|
+
Vet owns implementation; current `$ARGUMENTS` (`--full`) feeds the depth triggers in
|
|
14
13
|
`reference/depth.md`; profiles never remove the exact plan-reviewer gate
|
|
15
14
|
([orchestration-profiles.md](../devrites-lib/reference/orchestration-profiles.md)).
|
|
16
15
|
|
|
@@ -36,8 +35,8 @@ plan declares a root-authored executable workflow file, read
|
|
|
36
35
|
|
|
37
36
|
- Review implementation, not ambition. Challenge creep, complexity, proof, and
|
|
38
37
|
risk without changing accepted product scope.
|
|
39
|
-
- Root
|
|
40
|
-
|
|
38
|
+
- Root owns decisions/writes/readiness; reviewers judge without route policy.
|
|
39
|
+
Cite findings/confidence; suppress
|
|
41
40
|
unverified or confidence ≤4 findings under `review-axes.md`.
|
|
42
41
|
Lens arrows in `eng-lenses.md` are heuristics; band findings only under the
|
|
43
42
|
four `review-axes.md` names.
|
|
@@ -47,8 +46,6 @@ plan declares a root-authored executable workflow file, read
|
|
|
47
46
|
`NOTICE.md` generator regions, CI/hook config named in repo docs) require explicit
|
|
48
47
|
human approval before plan slices may edit them. A slice touching a protected path
|
|
49
48
|
without approval → Vet **NEEDS CLARIFICATION**.
|
|
50
|
-
**Failing case:** plan edits another feature's `state.md` without recorded approval →
|
|
51
|
-
fail closed.
|
|
52
49
|
- Use the lowest axis band; never average or round thin to ready. Search before
|
|
53
50
|
asking and resolve reversible technical choices. Ask only human-owned choices.
|
|
54
51
|
- Preserve a valid technical return cursor. Agent-owned `NEEDS REPLAN` returns
|
|
@@ -91,7 +88,11 @@ plan declares a root-authored executable workflow file, read
|
|
|
91
88
|
changed clause — enumerate dependents via the dep graph and traceability
|
|
92
89
|
refs, not only patched sites. Otherwise record one no-progress outcome. A
|
|
93
90
|
different Critical/Important invariant needs exact evidence and a new
|
|
94
|
-
fingerprint; a Suggestion, Nit, or FYI cannot keep recovery open.
|
|
91
|
+
fingerprint; a Suggestion, Nit, or FYI cannot keep recovery open. Reviewer
|
|
92
|
+
`Late:` rows on unchanged clauses follow the canonical
|
|
93
|
+
[late-finding rule](../devrites-lib/reference/standards/afk-hitl.md#retry-cap-no-progress-loops-and-self-resolve):
|
|
94
|
+
Critical with a failure path → new fingerprint; otherwise `eng-review.md`
|
|
95
|
+
`## Deferred findings` (mechanism rows become one proof row at step 6). A packet
|
|
95
96
|
marked `convergence_pressure` accepts an explicit, bounded declared
|
|
96
97
|
residual/limitation folded into the contract text as closure for a finding
|
|
97
98
|
marked as a refinement of an already-pinned clause; the recheck may re-raise
|
|
@@ -101,7 +102,10 @@ plan declares a root-authored executable workflow file, read
|
|
|
101
102
|
materialization gate — anchors applied, mirrors consistent, invariants
|
|
102
103
|
pass — without a dispatched reviewer; sub-Important findings already
|
|
103
104
|
cannot keep recovery open. Reconcile
|
|
104
|
-
shared artifact/readiness gates
|
|
105
|
+
shared artifact/readiness gates, then enter step 8 or the next repair.
|
|
106
|
+
Do not fall through to steps 2–7. Retain evidenced unchanged coverage; changed
|
|
107
|
+
global contract/uncertain impact requires full applicable review. Reopen historical
|
|
108
|
+
findings only for affected invariants/dependencies.
|
|
105
109
|
2. **Challenge scope.** Apply review-axes §0 and search accepted decisions.
|
|
106
110
|
Harden to the smallest contract-complete plan, using marked topology action.
|
|
107
111
|
Then verify bidirectional ID-and-meaning traceability across spec/plan/
|
|
@@ -133,7 +137,11 @@ plan declares a root-authored executable workflow file, read
|
|
|
133
137
|
Technical gaps are `NEEDS REPLAN` and Plan repair — each finding marks
|
|
134
138
|
itself `new_failure_mode` or names the already-pinned clause/fingerprint
|
|
135
139
|
it refines, making alias-detection and `convergence_pressure` eligibility
|
|
136
|
-
mechanical
|
|
140
|
+
mechanical — and carries `kind: contract | mechanism`
|
|
141
|
+
(`review-axes.md` § Finding kind). Only `contract` findings open a Plan
|
|
142
|
+
repair; a `mechanism` finding is closed by one `test-plan.md` proof row
|
|
143
|
+
at step 6 and leaves readiness intact when nothing else is open.
|
|
144
|
+
Product/risk gaps are
|
|
137
145
|
`NEEDS CLARIFICATION` and Clarify. Neither becomes a Build qid.
|
|
138
146
|
5. **Review axes.** Apply `review-axes.md` through `eng-lenses.md`. Fold verified
|
|
139
147
|
behavior-preserving technical findings; walk only human-owned decisions.
|
|
@@ -155,12 +163,11 @@ plan declares a root-authored executable workflow file, read
|
|
|
155
163
|
that new fingerprint as progress. Then close matrix and rerun ID/meaning audit.
|
|
156
164
|
8. **Build readback and readiness.** Add a cited five-line readback to
|
|
157
165
|
`eng-review.md` (artifacts.md §7 rows 1–5): outcome/ACs; IN/OUT/must-NOT; UI direction and architecture/
|
|
158
|
-
critical flow; slice order/first slice; decisive proof/action-time gates.
|
|
159
|
-
fresh implementer must need no product, architecture, or proof invention.
|
|
166
|
+
critical flow; slice order/first slice; decisive proof/action-time gates. No implementer should need to invent product, architecture, or proof.
|
|
160
167
|
Contradiction, ownerlessness, or material ambiguity blocks via Clarify or Plan.
|
|
161
168
|
|
|
162
169
|
Write exactly one `Implementation readiness: READY`, `NEEDS CLARIFICATION`,
|
|
163
|
-
or `NEEDS REPLAN`. Root
|
|
170
|
+
or `NEEDS REPLAN`. Root sets READY after every account, checklist,
|
|
164
171
|
preflight, and sweep is green. Write phase/next step and emit one
|
|
165
172
|
`Readiness inputs SHA-256` with
|
|
166
173
|
`devrites-engine check readiness --emit-binding <slug>`; normal readiness check
|
|
@@ -177,7 +184,7 @@ plan declares a root-authored executable workflow file, read
|
|
|
177
184
|
> Do not replace interactive review with artifacts, change acceptance through
|
|
178
185
|
> hardening, score without source evidence, or ignore unexplained complexity.
|
|
179
186
|
|
|
180
|
-
## Phase exit
|
|
187
|
+
## Phase exit
|
|
181
188
|
|
|
182
189
|
**Complete when:** `eng-review.md` records exactly one readiness verdict, readiness
|
|
183
190
|
binding SHA-256 passes, and every required reviewer account is admitted.
|
|
@@ -1,8 +1,6 @@
|
|
|
1
1
|
# $rite-vet: anti-patterns
|
|
2
2
|
|
|
3
|
-
|
|
4
|
-
[`../../devrites-lib/reference/standards/anti-patterns.md`](../../devrites-lib/reference/standards/anti-patterns.md): read it when the
|
|
5
|
-
reluctance is broader than this phase. Below are the vet-specific ones.
|
|
3
|
+
Read [universal anti-patterns](../../devrites-lib/reference/standards/anti-patterns.md).
|
|
6
4
|
|
|
7
5
|
Authority: `.agents/skills/devrites-lib/reference/standards/acceptance-preserving-reslice.md`.
|
|
8
6
|
|
|
@@ -16,15 +14,15 @@ Authority: `.agents/skills/devrites-lib/reference/standards/acceptance-preservin
|
|
|
16
14
|
|
|
17
15
|
| Excuse | Rebuttal |
|
|
18
16
|
|---|---|
|
|
19
|
-
| "I'll write all the findings into `eng-review.md` and let the user read it." |
|
|
17
|
+
| "I'll write all the findings into `eng-review.md` and let the user read it." | Fold verified behavior-preserving findings together and recheck affected closure. Ask human-owned choices with recommendations and await answers. Recording alone resolves nothing; never silently change acceptance or mark unresolved choices READY. |
|
|
20
18
|
| "The plan doesn't handle X: flag it." (without checking) | Quote the line first. If you can't quote where the plan handles X, you also can't be sure it doesn't: force confidence ≤4 and suppress. The "field/case doesn't exist" finding is the most common false positive; the verification gate exists to kill it. |
|
|
21
|
-
| "It's an obvious fix. I'll just edit the plan." |
|
|
19
|
+
| "It's an obvious fix. I'll just edit the plan." | Vet hardens verified plans; topology uses the marked action. |
|
|
22
20
|
| "This dimension is thin but the others are strong: net it's fine." | The gate is the **floor**, not the average. A plan `broken` on test-coverage does not pass because it's `strong` on architecture. |
|
|
23
|
-
| "I can see it's adequate. I'll note the band, the evidence is obvious." | Cite
|
|
24
|
-
| "8+ files but it all needs to change: proceed." |
|
|
21
|
+
| "I can see it's adequate. I'll note the band, the evidence is obvious." | Cite quoted evidence **before** the band; never score first and rationalize later. |
|
|
22
|
+
| "8+ files but it all needs to change: proceed." | Apply `review-axes.md` §0: justify complexity against the smallest contract-complete alternative; fold technical reductions through the marked action. File count does not justify design or require a pause. Ask only for changed scope, behavior, or risk policy. |
|
|
25
23
|
| "There's no test for this, but the user can add one later." | Coverage is designed **now**, before the code, so the build writes tests alongside it. A deferred test is a test that misses the boundary cases writing-it-now would expose. Regressions are non-negotiable. Critical, no question. |
|
|
26
24
|
| "Performance looks fine." | "Looks fine" is not a measurement. A perf finding is "measure X against budget Y" or it's nothing: don't recommend speculative tuning, and don't wave past an N+1 you can quote. |
|
|
27
|
-
| "Cross-model agrees, so apply it." |
|
|
25
|
+
| "Cross-model agrees, so apply it." | Consensus is a signal, not proof or approval. Verify the finding against source, then use the same technical-hardening or human-owned decision route; model agreement never authorizes a scope, acceptance, or policy change. |
|
|
28
26
|
|
|
29
27
|
## Reslice classifier rationalizations
|
|
30
28
|
|
|
@@ -36,6 +34,10 @@ Authority: `.agents/skills/devrites-lib/reference/standards/acceptance-preservin
|
|
|
36
34
|
- A finding raised with confidence ≥7 but **no quoted source line**, that defeats the verification gate.
|
|
37
35
|
- Acceptance/product-behavior growth auto-applied in AFK, or an orthogonal human-owned gate that did not pause.
|
|
38
36
|
- A failure-mode table with rows but no verdict column filled: a "no test + no handling + silent" row not marked Critical.
|
|
39
|
-
-
|
|
37
|
+
- Repeating an exhausted causal failure under the shared no-progress rule in
|
|
38
|
+
[`afk-hitl.md`](../../devrites-lib/reference/standards/afk-hitl.md), or stopping a
|
|
39
|
+
distinct cause solely because the total review round exceeds three.
|
|
40
|
+
- The reviewer / cross-model being handed the author's reasoning as independent
|
|
41
|
+
evidence (defeats the fresh-context point).
|
|
40
42
|
- The skill writing code, implementing a slice, or running the build. That's `$rite-build`. Vet reviews and hardens the plan; it never implements.
|
|
41
43
|
- Re-litigating the **spec's** scope/ambition, that was `$rite-temper`. Vet challenges *implementation* scope only.
|
|
@@ -1,10 +1,8 @@
|
|
|
1
1
|
# Depth calibration: always vet, scale the rigor (never skip)
|
|
2
2
|
|
|
3
|
-
`$rite-vet` runs on **every** plan
|
|
4
|
-
|
|
5
|
-
|
|
6
|
-
no skip. This shared definition is used by both the standalone `$rite-vet` and the always-run
|
|
7
|
-
`$rite-autocomplete` step, so they agree on how deep to go.
|
|
3
|
+
`$rite-vet` runs on **every** plan. Simple reversible work gets a **light pass**;
|
|
4
|
+
big/risky work gets a **full pass**, never a skip. Standalone Vet and Autocomplete
|
|
5
|
+
use these same depth rules.
|
|
8
6
|
|
|
9
7
|
A four-section deep-dive on a one-file reversible plan is wasteful; rubber-stamping a
|
|
10
8
|
migration-touching plan is dangerous. Match the effort to the stakes, but **always** leave a
|
|
@@ -55,6 +53,7 @@ triggers above, **never skipped**. Under the AFK gate ceiling:
|
|
|
55
53
|
failure-mode coverage, tightened scope, reuse-over-rebuild, dependency-order fixes
|
|
56
54
|
(these never grow acceptance). Record the rationale in `decisions.md`.
|
|
57
55
|
- **Topology findings:** marked action; slice count alone never pauses.
|
|
58
|
-
- **
|
|
59
|
-
|
|
56
|
+
- **Stops:** human-owned irreversible-risk findings pause. Technical recovery follows
|
|
57
|
+
[the canonical retry contract](../../devrites-lib/reference/standards/afk-hitl.md#retry-cap-no-progress-loops-and-self-resolve),
|
|
58
|
+
with no depth-specific round limit; no-progress exhaustion blocks, never grants readiness.
|
|
60
59
|
- **Cross-model** is off by default; it runs only if `--cross-model` was explicitly armed.
|
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
# Vet review: scope, four axes, and outputs
|
|
2
2
|
|
|
3
|
-
Run blocking §0,
|
|
4
|
-
|
|
3
|
+
Run blocking §0, four axes, and outputs with [`eng-lenses.md`](eng-lenses.md);
|
|
4
|
+
calibrate findings before presentation.
|
|
5
5
|
|
|
6
6
|
Authority: `.agents/skills/devrites-lib/reference/standards/acceptance-preserving-reslice.md`.
|
|
7
7
|
|
|
@@ -15,25 +15,28 @@ Authority: `.agents/skills/devrites-lib/reference/standards/acceptance-preservin
|
|
|
15
15
|
|
|
16
16
|
## §0. Scope challenge (blocking gate)
|
|
17
17
|
|
|
18
|
-
Before
|
|
19
|
-
the settled spec requires.
|
|
18
|
+
Before implementation review, check for work beyond the settled spec.
|
|
20
19
|
|
|
21
|
-
1. **What exists?** Find
|
|
22
|
-
[`tooling.md`](../../devrites-lib/reference/standards/tooling.md)
|
|
23
|
-
|
|
20
|
+
1. **What exists?** Find reusable code/flows via
|
|
21
|
+
[`tooling.md`](../../devrites-lib/reference/standards/tooling.md). Reuse → extend →
|
|
22
|
+
build new; list missed reuse instead of planning parallel work.
|
|
24
23
|
2. **Minimum diff.** Find the smallest contract-complete change. Flag non-blocking work;
|
|
25
24
|
use the marked action for topology cuts.
|
|
26
25
|
3. **Complexity smell.** **>8 files** or **>2 new services/modules/classes** needs a justified
|
|
27
26
|
complexity gate; otherwise harden to the smallest contract-complete plan. Use the
|
|
28
27
|
marked action for topology reduction.
|
|
29
|
-
|
|
30
|
-
|
|
28
|
+
**Feature ceiling.** A plan over the
|
|
29
|
+
[feature ceiling](../../rite-plan/reference/slicing.md#feature-ceiling-split-an-epic-never-override-the-budget)
|
|
30
|
+
(over-budget `tasks.md`/`plan.md` from slice or AC count) is a scope finding, not a
|
|
31
|
+
`Budget override`: route to `$rite-plan course-correct` (`MVP cut`) with the
|
|
32
|
+
continuation sequence named; do not vet the whole epic.
|
|
33
|
+
4. **Built-in check.** For each new pattern/infra/concurrency approach, invoke
|
|
34
|
+
`devrites-source-driven` inline to verify current framework/runtime support and cite it. Custom
|
|
31
35
|
work where a built-in suffices is a scope-reduction finding.
|
|
32
36
|
5. **Completeness.** Find edge/error/test shortcuts; prefer the complete option when the
|
|
33
37
|
extra work is small, and flag small savings that leave known gaps.
|
|
34
|
-
6. **Distribution check.**
|
|
35
|
-
|
|
36
|
-
deferred, say so explicitly in "NOT in scope": don't let it silently drop.
|
|
38
|
+
6. **Distribution check.** New artifacts (binary/package/container/deployable) need
|
|
39
|
+
build/publish/install plans or explicit deferral in "NOT in scope".
|
|
37
40
|
7. **Applicability check.** Compare `spec.md`'s topology/data/integration/security/delivery
|
|
38
41
|
decisions with live seams. A false `not applicable` or an `applies` row without the
|
|
39
42
|
focused standard's owner, failure/recovery, deployment order, and proof output is `broken`.
|
|
@@ -49,15 +52,18 @@ the settled spec requires.
|
|
|
49
52
|
> **STOP discipline.** Fold technical reduction into the plan; ask and stop only for a
|
|
50
53
|
> human-owned choice.
|
|
51
54
|
|
|
52
|
-
|
|
55
|
+
After justifying complexity or folding the contract-preserving reduction, present
|
|
56
|
+
the §0 findings and proceed to Axis 1. A human-owned unresolved choice still pauses.
|
|
53
57
|
|
|
54
58
|
---
|
|
55
59
|
|
|
56
|
-
## Four axes (
|
|
60
|
+
## Four axes (complete inventory, bounded presentation)
|
|
57
61
|
|
|
58
62
|
Fold verified technical findings into the plan; present each human-owned decision in one
|
|
59
63
|
`AskUserQuestion` packet. Combine support only for one owner/trade-off. HITL pauses; AFK
|
|
60
64
|
uses `depth.md`. Never invent findings.
|
|
65
|
+
Report every supported Critical/Important before repair. Group duplicates; compact
|
|
66
|
+
presentation never caps the inventory or hides the ninth substantive defect.
|
|
61
67
|
|
|
62
68
|
### 1. Architecture
|
|
63
69
|
|
|
@@ -138,6 +144,25 @@ Tag each finding `[severity] (confidence: N/10) <plan/task/spec ref> — finding
|
|
|
138
144
|
Quote supporting lines. Without them confidence is ≤4 and suppressed; never inflate it.
|
|
139
145
|
`devrites-plan-reviewer` follows this rule.
|
|
140
146
|
|
|
147
|
+
## Finding kind: contract or mechanism
|
|
148
|
+
|
|
149
|
+
Tag every Critical/Important `kind: contract` or `kind: mechanism`; root confirms the tag
|
|
150
|
+
at reconciliation.
|
|
151
|
+
|
|
152
|
+
- **contract** — a *guarantee* (acceptance, interface, boundary, ownership, data shape,
|
|
153
|
+
ordering/durability, failure outcome, dependency choice) an implementer could build
|
|
154
|
+
differently and still pass the planned tests → plan text → `NEEDS REPLAN` + Plan repair.
|
|
155
|
+
- **mechanism** — *how* a pinned clause is achieved (syscall order, fsync/rename shape,
|
|
156
|
+
lock scope, retry shape, parser detail): a test discriminates the wrong implementation
|
|
157
|
+
→ root adds one named case row to `test-plan.md` (input → observable outcome + the
|
|
158
|
+
mutant that must fail) plus its `traceability.md` ref, re-emits the readiness binding,
|
|
159
|
+
rechecks mechanically (anchor, ID parity). No Plan repair, no reviewer redispatch;
|
|
160
|
+
Build's RED test proves it. Prove in code, not in prose.
|
|
161
|
+
|
|
162
|
+
Mechanism becomes `contract` only when the plan asserts the opposite mechanism or the
|
|
163
|
+
clause is a public/shared seam. **Failing case:** round after round of prose pins on
|
|
164
|
+
already-pinned clauses.
|
|
165
|
+
|
|
141
166
|
---
|
|
142
167
|
|
|
143
168
|
## Present human-owned decisions
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
---
|
|
2
2
|
name: devrites-code-reviewer
|
|
3
|
-
description: "Reviews
|
|
3
|
+
description: "Reviews a full DevRites feature diff once for /rite-review and /rite-seal. Checks tests, correctness, readability, architecture, maintainability, and standards; returns every supported finding."
|
|
4
4
|
tools: read, grep, glob, bash
|
|
5
5
|
---
|
|
6
6
|
|
|
@@ -37,9 +37,11 @@ From `spec.md`'s applicability map, load only triggered `repository-topology.md`
|
|
|
37
37
|
|
|
38
38
|
You receive a feature slug or workspace path (`.devrites/work/<slug>/`) and the
|
|
39
39
|
diff scope. Read `spec.md` for the objective and acceptance criteria, then
|
|
40
|
-
`
|
|
41
|
-
|
|
42
|
-
|
|
40
|
+
`decisions.md` and `.devrites/principles.md` if present. Read `tasks.md` and
|
|
41
|
+
`touched-files.md` by the schema's bounded rule: when `devrites-engine orient <slug>`
|
|
42
|
+
reports one over budget, index it (`grep -n`) and load only entries naming this
|
|
43
|
+
candidate's AC/slice IDs. The principles are binding project invariants. Run `git diff`
|
|
44
|
+
for the feature scope and read the touched files.
|
|
43
45
|
|
|
44
46
|
## Review (feature scope only)
|
|
45
47
|
|
|
@@ -105,12 +107,13 @@ not as a blocker on this diff.
|
|
|
105
107
|
|
|
106
108
|
## Rules
|
|
107
109
|
|
|
108
|
-
-
|
|
110
|
+
- Out-of-scope problems → FYI.
|
|
109
111
|
- Do **not** edit code. Return findings only.
|
|
110
112
|
- Read surrounding source (call sites, existing guards, nearest consumer) before assigning severity; don't rate impact from the diff hunk alone.
|
|
111
113
|
- Label each finding **Critical / Important / Suggestion / Nit / FYI** with `file:line`
|
|
112
114
|
and a concrete fix. No praise padding.
|
|
113
|
-
-
|
|
115
|
+
- Return every supported in-scope finding from the full inspected diff in this one pass, not only the first. Repeat canonical `Finding:`/`Basis:` rows; unverified → gap. Complete means evidenced coverage, not guaranteed defect-free.
|
|
116
|
+
- In a recheck (the packet names open findings and a correction diff), your verdict covers those findings, the changed hunks, and their dependents. Anything else on hunks unchanged since your previous pass goes under `Late:` with severity and `file:line`; it is recorded for `/rite-review`, not verdict-bearing.
|
|
114
117
|
- **Non-trigger (UI anti-slop):** if the diff touches no rendered UI surface, do not
|
|
115
118
|
fire UI anti-slop (Inter, lavender, gradient, emoji headers). Code anti-slop still
|
|
116
119
|
applies. The UI catalog is `devrites-frontend-reviewer`.
|
|
@@ -57,6 +57,12 @@ mirror.
|
|
|
57
57
|
|
|
58
58
|
- Don't edit anything. Return findings only.
|
|
59
59
|
- Be concrete: the exact scenario that breaks it, with `file:line` where relevant.
|
|
60
|
+
- Tag every `valid & actionable` finding `kind: contract` (the claim's guarantee is
|
|
61
|
+
wrong or unpinned) or `kind: mechanism` (the guarantee stands; a named test would
|
|
62
|
+
catch the wrong implementation — propose that case).
|
|
63
|
+
- When the packet names prior fingerprints and a correction diff, your verdict covers
|
|
64
|
+
those and the dependents of each changed clause. Other observations on unchanged
|
|
65
|
+
text go under `Late:` with severity and site; they are recorded, not verdict-bearing.
|
|
60
66
|
|
|
61
67
|
## Output
|
|
62
68
|
|
|
@@ -105,7 +105,13 @@ criterion, slice, or proof.
|
|
|
105
105
|
pad the report with praise. In a recheck, also mark each finding
|
|
106
106
|
`new_failure_mode` or name the already-pinned clause/fingerprint it refines —
|
|
107
107
|
the packet lists prior repairs; the mark makes alias-detection and
|
|
108
|
-
`convergence_pressure` eligibility mechanical.
|
|
108
|
+
`convergence_pressure` eligibility mechanical. Tag every Critical/Important
|
|
109
|
+
`kind: contract` (an implementer could build it differently and still pass the
|
|
110
|
+
planned tests) or `kind: mechanism` (a named test can discriminate the wrong
|
|
111
|
+
implementation; propose that case as the fix, not new plan prose).
|
|
112
|
+
- In a recheck, your verdict covers the listed fingerprints, the correction diff, and
|
|
113
|
+
the dependents of each changed clause. Anything else you notice on unchanged text
|
|
114
|
+
goes under `Late:` with severity and site; it is recorded, not verdict-bearing.
|
|
109
115
|
- When a dimension has no issue, say "strong: <why>" instead of inventing a
|
|
110
116
|
finding.
|
|
111
117
|
- If a claim cannot be verified, such as blast radius without an index, say so and
|