devrites 5.14.3 → 6.0.0

package/engine/testdata/visual/open-visual-smoke.outline.md

@@ -1,54 +0,0 @@
-# open-visual smoke fixture
-
-## Purpose
-
-Prove that `devrites-engine open-visual` resolves a portable HTML+outline pair under `engine/testdata/visual/`, prints agent tips, runs a non-fatal inventory↔HTML id consistency check, and honors `--no-open` without launching a browser. The HTML teaches the dual-read → opener flow for humans reviewing the smoke surface.
-
-## Playbooks used
-
-| ID | Why loaded |
-| --- | --- |
-| diagram | Small relationship diagram for the opener smoke path |
-
-## ID inventory
-
-| HTML `id` | Meaning |
-| --- | --- |
-| `viz-title` | Page header / question the fixture answers |
-| `diagram-overview` | Core relationship figure |
-| `diagram-title` | Accessible SVG title |
-| `node-html` | HTML fixture node |
-| `node-outline` | Outline companion node |
-| `node-opener` | open-visual command node |
-| `edge-html-outline` | Dual-read pairing |
-| `edge-outline-opener` | Opener tip path |
-| `diagram-detail` | Prose steps mirroring the overview |
-| `diagram-legend` | Symbol / behavior key |
-| `viz-open-questions` | Open questions with confidence |
-| `diagram-citations` | Repo path citations |
-
-## Relationships
-
-| From | To | Relationship / decision / open question |
-| --- | --- | --- |
-| `node-html` | `node-outline` | Dual-read pair; outline is SSOT on conflict |
-| `node-outline` | `node-opener` | Opener prints outline path + playbook tip |
-| `open-visual --no-open` | browser | Must not launch; tips still print |
-| `diagram-overview` | `diagram-detail` | Same three-step story: pair → SSOT → opener |
-| `#devrites-outline` | `.outline.md` | JSON is a mirror; outline.md wins on conflict |
-
-## Citations
-
-| Claim | Path |
-| --- | --- |
-| Opener implementation | `engine/internal/lib/open_visual.go` |
-| Playbook router | `pack/.claude/skills/devrites-lib/reference/visual-playbooks/index.md` |
-| Outline template | `pack/.claude/skills/devrites-lib/reference/visual-playbooks/outline-template.md` |
-| rite-explain tip hook | `pack/.claude/skills/rite-explain/SKILL.md` |
-
-## Open questions
-
-| id | question | confidence | status |
-| --- | --- | --- | --- |
-| `q-json-ssot` | Should agents ever prefer `#devrites-outline` JSON over `.outline.md` when both exist? | high | open |
-| `q-browser-ci` | Do all interactive review hosts have a usable OS opener, or is `--no-open` the default smoke path? | medium | open |

package/engine/tests/adr_0003_gate_exit_code_test.go

@@ -1,32 +0,0 @@
-package main_test
-
-// Guard test for ADR-0003 (a blocked gate is a HITL pause, never a crash).
-// Exit code 3 is a reserved, load-bearing contract the harness and hooks branch
-// on: an unmet gate exits 3 with an actionable "blocked" line, and a satisfied
-// gate exits 0. This test names the contract against its ADR so a change to the
-// reserved code fails with the decision attached. (Broader gate behavior lives
-// in gate_test.go; this pins the exit-code contract itself.)
-
-import (
-	"strings"
-	"testing"
-)
-
-func TestADR0003BlockedGateExitsThreeNotCrash(t *testing.T) {
-	root := newWorkspace(t)
-
-	// auth-tokens is in the build phase with tasks empty -> readiness blocks.
-	out, _, code := runDevrites(t, root, "check", "readiness", "auth-tokens")
-	if code != 3 {
-		t.Fatalf("blocked readiness exit = %d, want the reserved 3 (HITL pause)", code)
-	}
-	if !strings.Contains(out, "blocked") {
-		t.Errorf("a blocked gate must state it is blocked on stdout\n%s", out)
-	}
-
-	// A satisfied gate is a clean pass, never a spurious non-zero.
-	_, _, ok := runDevrites(t, root, "check", "readiness", "search-ranking") // spec phase, spec present
-	if ok != 0 {
-		t.Fatalf("satisfied readiness exit = %d, want 0", ok)
-	}
-}

package/engine/tests/adr_0004_required_by_phase_test.go

@@ -1,54 +0,0 @@
-package main_test
-
-// Guard test for ADR-0004 (phase-relative section completeness). Locks the
-// invariant that required sections are ADDITIVE down the rite-* arc: every phase
-// requires a superset of the phase before it. If someone reorders the arc or
-// drops a section from a later phase's requirements, this fails loudly with the
-// ADR number attached.
-
-import (
-	"testing"
-
-	"github.com/devrites/devrites/internal/state"
-)
-
-func TestADR0004RequiredSectionsAreAdditiveDownTheArc(t *testing.T) {
-	policies := state.PhasePolicies()
-	for _, policy := range policies {
-		lookedUp, ok := state.PolicyFor(policy.Target)
-		if !ok || lookedUp.Target != policy.Target {
-			t.Fatalf("phase %q in the arc is not a known phase", policy.Target)
-		}
-	}
-
-	// Each phase's required set must contain everything the previous phase
-	// required: completeness only accumulates, never regresses.
-	for i := 1; i < len(policies); i++ {
-		previous := asSet(policies[i-1].RequiredSections)
-		current := asSet(policies[i].RequiredSections)
-		for section := range previous {
-			if !current[section] {
-				t.Errorf("phase %q dropped section %q that %q required: arc must be additive",
-					policies[i].Target, section, policies[i-1].Target)
-			}
-		}
-	}
-
-	// Anchors: framing requires nothing; seal requires the full section set.
-	frame, _ := state.PolicyFor(state.PhaseFrame)
-	if len(frame.RequiredSections) != 0 {
-		t.Errorf("frame requires %v, want none", frame.RequiredSections)
-	}
-	seal, _ := state.PolicyFor(state.PhaseSeal)
-	if got, want := len(seal.RequiredSections), len(state.Sections); got != want {
-		t.Errorf("seal requires %d sections, want the full set of %d", got, want)
-	}
-}
-
-func asSet(ss []state.Section) map[state.Section]bool {
-	m := make(map[state.Section]bool, len(ss))
-	for _, s := range ss {
-		m[s] = true
-	}
-	return m
-}

package/engine/tests/adr_0011_define_plan_test.go

@@ -1,32 +0,0 @@
-package main_test
-
-import (
-	"testing"
-
-	"github.com/devrites/devrites/internal/state"
-)
-
-func TestADR0011DefineAndPlanHaveDistinctTransitionRights(t *testing.T) {
-	define, ok := state.PolicyFor(state.PhaseDefine)
-	if !ok || define.ResumeVerb != "define" {
-		t.Fatalf("define policy=(%+v,%v), want resume verb define", define, ok)
-	}
-	plan, ok := state.PolicyFor(state.PhasePlan)
-	if !ok || plan.ResumeVerb != "vet" {
-		t.Fatalf("plan policy=(%+v,%v), want resume verb vet", plan, ok)
-	}
-	if policy, ok := state.PolicyFor(state.Phase("planning")); ok {
-		t.Fatalf("planning alias=(%+v,true), want speculative alias rejected", policy)
-	}
-
-	rights := map[string]state.Phase{}
-	for _, policy := range state.PhasePolicies() {
-		if policy.TransitionRight == "" {
-			t.Fatalf("phase %q has no transition right", policy.Target)
-		}
-		if prior := rights[policy.TransitionRight]; prior != "" {
-			t.Fatalf("phases %q and %q share transition right %q", prior, policy.Target, policy.TransitionRight)
-		}
-		rights[policy.TransitionRight] = policy.Target
-	}
-}

package/engine/tests/adr_0027_readiness_binding_test.go

@@ -1,107 +0,0 @@
-package main_test
-
-import (
-	"os"
-	"path/filepath"
-	"strings"
-	"testing"
-
-	"github.com/devrites/devrites/internal/testutil"
-)
-
-func TestADR0027ReadinessBindingBlocksPlanDriftWithRestoredMtime(t *testing.T) {
-	project := t.TempDir()
-	root := filepath.Join(project, ".devrites")
-	workspace := filepath.Join(root, "work", "bound")
-	for name, body := range map[string]string{
-		"state.md":             "| phase | build |\n",
-		"brief.md":             "# Brief\n\nBuild the approved slice.\n",
-		"spec.md":              "# Spec\n\n## Acceptance Criteria\n- AC-001: bind readiness inputs.\n",
-		"decisions.md":         "# Decisions\n\nNone.\n",
-		"assumptions.md":       "# Assumptions\n\nNone.\n",
-		"questions.md":         "# Questions\n\nNone.\n",
-		"decision-coverage.md": "# Decision coverage\n\nCLEAR\n",
-		"architecture.md":      "# Architecture\n\nUse the deterministic gate.\n",
-		"plan.md":              "# Plan\n\nBuild slice A.\n",
-		"tasks.md":             testutil.CanonicalTasksMarkdown,
-		"traceability.md":      "# Traceability\n\nAC-001 -> slice A.\n",
-		"eng-review.md":        "# Engineering review\n\nREADY\n",
-		"test-plan.md":         "# Test plan\n\nRun focused Go tests for AC-001.\n",
-		"gates.md":             testutil.CanonicalGatesMarkdown,
-	} {
-		testutil.WriteFile(t, filepath.Join(workspace, name), body)
-	}
-
-	binding := emitReadinessBinding(t, root, "bound")
-	testutil.AppendFile(t, filepath.Join(workspace, "eng-review.md"), "\n"+binding+"\n")
-	out, errOut, code := runDevrites(t, root, "check", "readiness", "bound")
-	if code != 0 {
-		t.Fatalf("initial readiness exit=%d, want 0\nstdout:\n%s\nstderr:\n%s", code, out, errOut)
-	}
-
-	planPath := filepath.Join(workspace, "plan.md")
-	before, err := os.Stat(planPath)
-	if err != nil {
-		t.Fatal(err)
-	}
-	testutil.WriteFile(t, planPath, "# Plan\n\nBuild a different slice.\n")
-	if err := os.Chtimes(planPath, before.ModTime(), before.ModTime()); err != nil {
-		t.Fatal(err)
-	}
-	expected := emitReadinessBinding(t, root, "bound")
-
-	out, errOut, code = runDevrites(t, root, "check", "readiness", "bound")
-	if code != 3 {
-		t.Fatalf("stale readiness exit=%d, want 3\nstdout:\n%s\nstderr:\n%s", code, out, errOut)
-	}
-	for _, want := range []string{
-		"reason: DRV-GATE-READINESS-STALE",
-		"rerun /rite-vet",
-		expected,
-	} {
-		if !strings.Contains(out, want) {
-			t.Fatalf("stale readiness output missing %q:\n%s", want, out)
-		}
-	}
-}
-
-func TestADR0027SealChecksReadinessBindingBeforeEvidenceFreshness(t *testing.T) {
-	project, root := newFinalSealRepo(t)
-	planPath := filepath.Join(root, "work", "final", "plan.md")
-	before, err := os.Stat(planPath)
-	if err != nil {
-		t.Fatal(err)
-	}
-	testutil.WriteFile(t, planPath, "# Plan\n\nChanged after the final review.\n")
-	if err := os.Chtimes(planPath, before.ModTime(), before.ModTime()); err != nil {
-		t.Fatal(err)
-	}
-	expected := emitReadinessBinding(t, root, "final")
-	chdirForSeal(t, project)
-
-	out, errOut, code := runDevrites(t, root, "check", "seal", "final")
-	if code != 3 {
-		t.Fatalf("stale seal exit=%d, want 3\nstdout:\n%s\nstderr:\n%s", code, out, errOut)
-	}
-	if !strings.Contains(out, "reason: DRV-GATE-READINESS-STALE") || !strings.Contains(out, expected) {
-		t.Fatalf("stale seal output lacks reason or expected binding:\n%s", out)
-	}
-	if strings.Contains(out, "evidence-fresh:") || strings.Contains(errOut, "evidence-fresh:") {
-		t.Fatalf("seal ran evidence freshness after stale readiness\nstdout:\n%s\nstderr:\n%s", out, errOut)
-	}
-}
-
-func emitReadinessBinding(t *testing.T, root, slug string) string {
-	t.Helper()
-	out, errOut, code := runDevrites(t, root, "check", "readiness", "--emit-binding", slug)
-	if code != 0 {
-		t.Fatalf("emit readiness binding exit=%d, want 0\nstdout:\n%s\nstderr:\n%s", code, out, errOut)
-	}
-	line := strings.TrimSuffix(out, "\n")
-	const prefix = "Readiness inputs SHA-256: "
-	digest := strings.TrimPrefix(line, prefix)
-	if digest == line || len(digest) != 64 || strings.Trim(digest, "0123456789abcdef") != "" {
-		t.Fatalf("malformed readiness binding output %q", out)
-	}
-	return line
-}

package/engine/tests/cli_test.go

@@ -1,126 +0,0 @@
-package main_test
-
-// CLI black-box tests: build the real binary, run it as a subprocess against a
-// fixture .devrites/, and assert stdout + exit code. This is the primary test
-// seam: it exercises external behavior only, never internals.
-//
-// Each test runs against a fresh COPY of the fixture in a temp dir, so a test
-// may hand-edit files without disturbing the committed fixture or another test.
-
-import (
-	"bytes"
-	"errors"
-	"os"
-	"os/exec"
-	"path/filepath"
-	"runtime"
-	"strings"
-	"testing"
-
-	"github.com/devrites/devrites/internal/testutil"
-)
-
-var (
-	binPath    string
-	engineRoot string
-)
-
-func TestMain(m *testing.M) {
-	wd, err := os.Getwd()
-	if err != nil {
-		panic(err)
-	}
-	engineRoot = filepath.Clean(filepath.Join(wd, ".."))
-	dir, err := os.MkdirTemp("", "devrites-bin-*")
-	if err != nil {
-		panic(err)
-	}
-	name := "devrites"
-	if runtime.GOOS == "windows" {
-		name += ".exe"
-	}
-	binPath = filepath.Join(dir, name)
-	build := exec.Command("go", "build", "-o", binPath, ".")
-	build.Dir = engineRoot
-	build.Env = append(os.Environ(), "CGO_ENABLED=0")
-	if out, err := build.CombinedOutput(); err != nil {
-		_ = os.RemoveAll(dir)
-		panic("go build failed: " + err.Error() + "\n" + string(out))
-	}
-	code := m.Run()
-	_ = os.RemoveAll(dir)
-	os.Exit(code)
-}
-
-// newWorkspace copies the committed fixture workspace into a fresh temp dir and
-// returns the path to the copied .devrites root. (The committed fixture dir is
-// named devrites-root/ rather than .devrites/ only because the repo-root
-// .gitignore ignores every .devrites/ directory; the engine keys off the
-// DEVRITES_ROOT path, not the directory name.)
-func newWorkspace(t *testing.T) string {
-	t.Helper()
-	src, err := filepath.Abs(filepath.Join(engineRoot, "testdata", "fixtures", "basic", "devrites-root"))
-	if err != nil {
-		t.Fatal(err)
-	}
-	root := filepath.Join(t.TempDir(), ".devrites")
-	testutil.CopyTree(t, src, root)
-	return root
-}
-
-// runDevrites runs the built binary against the given .devrites root and returns
-// stdout, stderr, and the exit code.
-func runDevrites(t *testing.T, root string, args ...string) (stdout, stderr string, code int) {
-	return runDevritesIO(t, root, "", nil, args...)
-}
-
-func runDevritesIO(t *testing.T, root, stdin string, extraEnv []string, args ...string) (stdout, stderr string, code int) {
-	t.Helper()
-	cmd := exec.Command(binPath, args...)
-	cmd.Env = append(append(os.Environ(), "DEVRITES_ROOT="+root), extraEnv...)
-	cmd.Stdin = strings.NewReader(stdin)
-	var outBuf, errBuf bytes.Buffer
-	cmd.Stdout = &outBuf
-	cmd.Stderr = &errBuf
-	err := cmd.Run()
-	code = 0
-	if err != nil {
-		var ee *exec.ExitError
-		if !errors.As(err, &ee) {
-			t.Fatalf("running %v: %v", args, err)
-		}
-		code = ee.ExitCode()
-	}
-	return outBuf.String(), errBuf.String(), code
-}
-
-func TestUnknownCommandExitsNonZero(t *testing.T) {
-	root := newWorkspace(t)
-	if _, _, code := runDevrites(t, root, "frobnicate"); code == 0 {
-		t.Fatalf("exit = 0, want non-zero for an unknown command")
-	}
-}
-
-func TestCheckCandidateOutputAndMalformedFailure(t *testing.T) {
-	project := t.TempDir()
-	root := filepath.Join(project, ".devrites")
-	workspace := filepath.Join(root, "work", "feature")
-	testutil.WriteFile(t, filepath.Join(project, "source.go"), "package source\n")
-	manifest := "# Touched files\n\n## Touched files\nCandidate paths are declared below.\n\n## Candidate manifest\n| State | File | Slice | Reason |\n| --- | --- | --- | --- |\n| present | `source.go` | S-1 | Implementation. |\n"
-	testutil.WriteFile(t, filepath.Join(workspace, "touched-files.md"), manifest)
-
-	out, errOut, code := runDevrites(t, root, "check", "candidate", "feature")
-	if code != 0 || errOut != "" {
-		t.Fatalf("code=%d stdout=%q stderr=%q", code, out, errOut)
-	}
-	lines := strings.Split(strings.TrimSpace(out), "\n")
-	if len(lines) != 2 || !strings.HasPrefix(lines[0], "candidate-sha256: ") || lines[1] != "candidate-files: 1" {
-		t.Fatalf("stdout=%q", out)
-	}
-
-	testutil.WriteFile(t, filepath.Join(workspace, "touched-files.md"), "# Touched files\n\n## Touched files\n- `source.go`\n")
-	out, errOut, code = runDevrites(t, root, "check", "candidate", "feature")
-	if code != 3 || out != "" || !strings.Contains(errOut, "candidate manifest") {
-		t.Fatalf("malformed: code=%d stdout=%q stderr=%q", code, out, errOut)
-	}
-}