devrites 5.11.0 → 5.13.0

package/pack/generated/pi/skills/rite-vet/SKILL.md

@@ -5,6 +5,10 @@ argument-hint: "[slug] [--cross-model] [--full]"
 user-invocable: true
 ---
 
+<!-- loads: {"always":["devrites-lib/reference/standards/core.md","devrites-lib/reference/standards/code-navigation.md","devrites-lib/reference/orchestration-profiles.md","devrites-lib/reference/parallel-dispatch.md","devrites-lib/reference/standards/gates.md","rite-vet/reference/review-axes.md","rite-vet/reference/artifacts.md","rite-vet/reference/depth.md","rite-vet/reference/eng-lenses.md","rite-vet/reference/anti-patterns.md"],"triggers":{"afk":["devrites-lib/reference/standards/afk-hitl.md"],"applicability":["devrites-lib/reference/standards/repository-topology.md","devrites-lib/reference/standards/data-integrity.md","devrites-lib/reference/standards/integration-reliability.md"],"assumption-delta":["devrites-lib/reference/standards/assumption-checkpoints.md"],"cross-model":["rite-vet/reference/cross-model.md"],"devex":["devrites-lib/reference/standards/developer-experience.md"],"dod":["devrites-lib/reference/standards/definition-of-done.md"],"elicitation":["devrites-lib/reference/standards/elicitation.md"],"errors":["devrites-lib/reference/standards/error-handling.md"],"grammar":["devrites-lib/reference/standards/spec-grammar.md"],"one-shot":["devrites-lib/reference/standards/one-shot-actions.md"],"performance":["devrites-lib/reference/standards/performance.md"],"principles":["devrites-lib/reference/standards/principles.md"],"reslice":["devrites-lib/reference/standards/acceptance-preserving-reslice.md"],"testing":["devrites-lib/reference/standards/testing.md"],"workflow":["devrites-lib/reference/standards/development-workflow.md"],"workflow-artifacts":["devrites-lib/reference/standards/workflow-artifacts.md"],"yagni":["devrites-lib/reference/standards/patterns.md","devrites-lib/reference/standards/coding-style.md"]},"workspace":["brief.md","spec.md","state.md","decisions.md","assumptions.md","questions.md","decision-coverage.md","architecture.md","plan.md","tasks.md","traceability.md","eng-review.md","test-plan.md","gates.md"],"workspaceByRole":{"devex-reviewer":["spec.md","plan.md","tasks.md","state.md"],"plan-reviewer":["spec.md","plan.md","tasks.md","test-plan.md","decision-coverage.md","architecture.md","decisions.md","state.md"],"strategy-reviewer":["brief.md","spec.md","plan.md","decisions.md","decision-coverage.md","state.md"]}} -->
+> Read-set manifest: `devrites-engine context <slug> --phase vet` bundles every file named below into one deduplicated read. Trigger names map to the conditional rules in the sections that follow.
+
+
 # /rite-vet: review the plan before build
 
 Vet every plan's scope, architecture, quality, proof, performance, failures and writer
@@ -15,12 +19,16 @@ Vet owns implementation; current `$ARGUMENTS` (`--full`) feeds the depth trigger
 
 ## Rules
 
-Read the active standard from: [`principles.md`](../devrites-lib/reference/standards/principles.md), [`patterns.md`](../devrites-lib/reference/standards/patterns.md), [`coding-style.md`](../devrites-lib/reference/standards/coding-style.md),
+Read the active standard from: [`principles.md`](../devrites-lib/reference/standards/principles.md), [`patterns.md`](../devrites-lib/reference/standards/patterns.md) + [`coding-style.md`](../devrites-lib/reference/standards/coding-style.md) (over-engineering / YAGNI rubric, trigger `yagni`),
 [`testing.md`](../devrites-lib/reference/standards/testing.md), [`spec-grammar.md`](../devrites-lib/reference/standards/spec-grammar.md), [`performance.md`](../devrites-lib/reference/standards/performance.md), [`error-handling.md`](../devrites-lib/reference/standards/error-handling.md),
 [`development-workflow.md`](../devrites-lib/reference/standards/development-workflow.md), [`afk-hitl.md`](../devrites-lib/reference/standards/afk-hitl.md), [`one-shot-actions.md`](../devrites-lib/reference/standards/one-shot-actions.md),
 [`developer-experience.md`](../devrites-lib/reference/standards/developer-experience.md), [`elicitation.md`](../devrites-lib/reference/standards/elicitation.md), and [`definition-of-done.md`](../devrites-lib/reference/standards/definition-of-done.md). Load
 repository topology, data integrity, and integration reliability only when
-triggered. Before classifying any Reslice, read `.pi/skills/devrites-lib/reference/standards/acceptance-preserving-reslice.md`.
+triggered. When the plan's scope generalizes an existing boundary — a second
+platform/tenant/source of truth, a newly optional field, a constant turned parameter —
+confirm the [`assumption-checkpoints.md`](../devrites-lib/reference/standards/assumption-checkpoints.md) question (trigger `assumption-delta`)
+was answered and recorded, not skipped-as-negative.
+Before classifying any Reslice, read `.pi/skills/devrites-lib/reference/standards/acceptance-preserving-reslice.md`.
 When a
 plan declares a root-authored executable workflow file, read
 [`workflow-artifacts.md`](../devrites-lib/reference/standards/workflow-artifacts.md).
@@ -72,7 +80,8 @@ plan declares a root-authored executable workflow file, read
    recheck retains prior depth and enters 1b.
 1a. **Independent initial pass.** Freeze candidate and dispatch the exact fresh
    read-only plan reviewer — plus developer-experience reviewer for developer
-   surfaces and the current strategy reviewer after significant Temper — in
+   surfaces (trigger `devex`) and the current strategy reviewer after significant
+   Temper — in
    parallel under `../devrites-lib/reference/parallel-dispatch.md`; they are
    independent read-only passes on one frozen candidate. Missing
    required account blocks.
@@ -151,7 +160,18 @@ plan declares a root-authored executable workflow file, read
    assumptions, uncertainty, and gates. Keep state non-READY. Every scenario and
    criterion needs positive, discriminating proof; every slice must be one-pass
    implementable; developer plans need a predicted scorecard. Durable commands
-   are portable repository commands, not host wrappers.
+   are portable repository commands, not host wrappers — resolve them with
+   `devrites-engine detect commands` (Makefile/package.json/manifests, no
+   execution) and cite the resolved text verbatim; an `unresolved` slot means
+   name the concrete command in the plan, never guess one.
+   Once the `## Build-entry preflight` table is final, run
+   `devrites-engine gates scaffold <slug>` to seed `gates.md` (one pending gate
+   per `AC-###`; never clobber an existing ledger), then author each gate's
+   `CHECK`/`EXPECT`/`CWD` per artifacts.md §`gates.md` so every runnable oracle
+   is an approved preflight row. Run
+   `devrites-engine gates lint <slug> --strict` and resolve every finding before
+   READY; the readiness check refuses a missing or malformed ledger but does not
+   replace this oracle-quality gate.
 7. **Narrow recheck after edits.** Dispatch the exact plan reviewer once per
    fold — one dispatch covering every open fingerprint, preserving
    per correction/fingerprint accounting (each checked individually with its
@@ -171,8 +191,10 @@ plan declares a root-authored executable workflow file, read
    preflight, and sweep is green. Write phase/next step and emit one
    `Readiness inputs SHA-256` with
    `devrites-engine check readiness --emit-binding <slug>`; normal readiness check
-   must pass. Technical failure records reproduction, not qid. Human gap awaits
-   Clarify. Optional cross-model follows `reference/cross-model.md`.
+   must pass. Record the per-input drift baseline alongside it:
+   `devrites-engine check drift <slug> --record` — a later stale binding then
+   names the exact artifact that moved instead of "something changed". Technical failure records reproduction, not qid. Human gap awaits
+   Clarify. Optional cross-model follows `reference/cross-model.md` (trigger `cross-model`).
 
    With READY, no pending remediation, and a valid technical return cursor,
    restore and consume the return cursor instead of defaulting to Build. Preserve

package/pack/generated/pi/skills/rite-vet/reference/artifacts.md

@@ -146,6 +146,25 @@ For every row in `plan.md`'s `Shared contract proof`, the per-gap requirements n
 provider- and consumer-side asserting tests and state how each consumes the same canonical
 artifact. Reference the plan row; do not reproduce its contract table here.
 
+## `gates.md`: the acceptance ledger
+
+Write `.devrites/work/<slug>/gates.md` once the preflight table is final —
+`devrites-engine gates scaffold <slug>` seeds one pending gate per `AC-###` in
+`spec.md`; never clobber a ledger that already carries evidence. Grammar,
+evidence binding, and oracle rules live in
+[`gates.md`](../../devrites-lib/reference/standards/gates.md); the engine
+enforces them, so author to the contract, not around it:
+
+- One gate per required outcome; reuse `AC-###` ids so readiness coverage and
+  the ledger name the same set.
+- A runnable gate's `CHECK` must be a `## Build-entry preflight` `Command`
+  verbatim with a matching `Cwd` — a gate whose command is absent from the
+  preflight table can never execute, so add the row first.
+- `EXPECT` names a line only success can print; `gates lint <slug>` flags
+  tautological commands and weak expectations before build.
+- Manual gates (`EVIDENCE` only) are for judgment-bound outcomes; Prove
+  attests them, Seal still requires them checked.
+
 ## Parallelization table (in `eng-review.md` §5 when there's an opportunity)
 
 ```markdown

package/pack/generated/pi/skills/rite-vet/reference/review-axes.md

@@ -75,6 +75,11 @@ presentation never caps the inventory or hides the ninth substantive defect.
 - Security architecture at the seams (auth, data access, API boundaries): does the plan name
   the trust boundary for each untrusted input?
 - One realistic production failure per new codepath/integration (feeds failure-mode table).
+- **Assumption delta:** when the plan or fresh evidence changes the *kind* of a spec
+  assumption (singular→plural, required→optional, chosen→derived, or back) that is an
+  identity-model change, not a detail. It needs an explicit promote-vs-add-alongside
+  decision routed through the Guard; silently widening the model in the plan is a
+  `broken` finding.
 - Does any key flow deserve an ASCII diagram in the plan or an inline comment in the code the
   build will write? Name the files that should carry one.
 

package/pack/generated/pi/skills/rite-watch-pr/SKILL.md

@@ -4,6 +4,8 @@ description: Observe one GitHub PR and CI state without mutating code, Git, thre
 argument-hint: "[PR number|PR URL|blank for current branch]"
 user-invocable: true
 ---
+<!-- loads: {"always":["devrites-lib/reference/standards/core.md","devrites-lib/reference/standards/loop-operations.md"],"triggers":{"security":["devrites-lib/reference/standards/security.md"]},"workspace":[]} -->
+> Read-set manifest: `devrites-engine context [slug] --skill rite-watch-pr` bundles every file named below into one deduplicated read.
 
 # /rite-watch-pr: read-only PR and CI observation
 

package/pack/generated/pi/skills/rite-zoom-out/SKILL.md

@@ -5,6 +5,8 @@ argument-hint: "[symbol | file | area to map]"
 user-invocable: true
 disable-model-invocation: true
 ---
+<!-- loads: {"always":["devrites-lib/reference/standards/core.md","devrites-lib/reference/standards/tooling.md"],"workspace":["spec.md","plan.md","decisions.md","state.md"]} -->
+> Read-set manifest: `devrites-engine context [slug] --skill rite-zoom-out` bundles every file named below into one deduplicated read.
 
 # /rite-zoom-out: step up one abstraction layer
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "devrites",
-  "version": "5.11.0",
+  "version": "5.13.0",
   "description": "DevRites: a disciplined senior-engineer workflow pack for Claude Code, Codex, omp, pi, and Devin CLI",
   "license": "SEE LICENSE IN LICENSE",
   "homepage": "https://github.com/ViktorsBaikers/DevRites#readme",

package/scripts/build-host-artifacts.sh

@@ -27,6 +27,11 @@ TMP_GEN_DIR="$(mktemp -d)"
 cleanup() { rm -rf "$TMP_GEN_DIR"; }
 trap cleanup EXIT
 
+# Build into a scratch dir, then swap into place: file watchers were observed
+# deleting/recreating entries under the live output dir mid-build on macOS.
+REAL_OUT="$OUT_ROOT"
+OUT_ROOT="$TMP_GEN_DIR/out"
+
 # shellcheck source=codex-generate.sh
 . "$ROOT/scripts/codex-generate.sh"
 # shellcheck source=omp-generate.sh
@@ -140,12 +145,24 @@ render_devin_skill_tree() {
   done < <(find "$_sd" -type f)
 }
 
-rm -rf "$OUT_ROOT"
 mkdir -p "$OUT_ROOT/claude" "$OUT_ROOT/codex" "$OUT_ROOT/omp" "$OUT_ROOT/pi" "$OUT_ROOT/devin"
 
+# Canonical sources may use <!-- include:REL --> markers for shared blocks
+# (e.g. agents/_shared/). Expand them on a scratch copy so every host renders
+# identical text while the canonical pack stays deduplicated.
+EXPANDED_SRC="$TMP_GEN_DIR/canonical"
+mkdir -p "$EXPANDED_SRC"
+cp -R "$PACK_SRC/." "$EXPANDED_SRC/"
+python3 "$ROOT/scripts/expand-includes.py" "$EXPANDED_SRC"
+PACK_SRC="$EXPANDED_SRC"
+
+# `_shared` dirs exist only to feed expansion; no host ships them.
+find "$PACK_SRC" -type d -name _shared -prune -exec rm -rf {} +
+
 # Claude artifacts are host-native copies of the canonical pack.
 copy_tree "$PACK_SRC/skills" "$OUT_ROOT/claude/skills"
 copy_tree "$PACK_SRC/agents" "$OUT_ROOT/claude/agents"
+rm -rf "$OUT_ROOT/claude/agents/_shared" "$OUT_ROOT/claude/skills/devrites-lib/reference/_shared"
 copy_tree "$PACK_SRC/workflows" "$OUT_ROOT/claude/workflows"
 # Local editor caches under .impeccable/ must never ship in generated hosts.
 rm -rf "$OUT_ROOT/claude/agents/.impeccable" "$OUT_ROOT/claude/skills/.impeccable"
@@ -243,4 +260,33 @@ Do not edit these files by hand. Edit `pack/.claude/`,
 `scripts/pi-generate.sh`, or `scripts/devin-generate.sh`, then rebuild.
 EOF
 
-echo "build-host-artifacts: wrote $OUT_ROOT"
+# Swap the completed tree into place. Watchers can still re-create entries
+# mid-delete, so retry the clear until the old tree is gone, then rename. The
+# held-output security harness runs with the output root as the current
+# directory; that directory cannot be renamed away, so replace only its
+# generated children while leaving the held source tree in place.
+if [ "$REAL_OUT" = "." ]; then
+  for _name in claude codex devin omp pi README.md; do
+    rm -rf "$_name"
+  done
+  for _entry in "$OUT_ROOT"/*; do
+    [ -e "$_entry" ] || continue
+    mv "$_entry" .
+  done
+else
+  for _ in 1 2 3 4 5; do
+    rm -rf "$REAL_OUT" && break
+    sleep 1
+  done
+  [ ! -e "$REAL_OUT" ] || {
+    echo "build-host-artifacts: cannot clear $REAL_OUT" >&2
+    exit 1
+  }
+  mv "$OUT_ROOT" "$REAL_OUT"
+fi
+[ -f "$REAL_OUT/README.md" ] || {
+  echo "build-host-artifacts: swap left no tree at $REAL_OUT" >&2
+  exit 1
+}
+
+echo "build-host-artifacts: wrote $REAL_OUT"