devrites 4.6.0 → 5.0.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +23 -0
- package/NOTICE.md +6 -0
- package/README.md +36 -12
- package/SECURITY.md +3 -3
- package/bin/devrites.mjs +1 -0
- package/docs/adr/0027-content-bound-build-readiness.md +8 -0
- package/docs/adr/0029-v5-workspace-schema-and-native-migration.md +62 -0
- package/docs/adr/README.md +4 -3
- package/docs/architecture.md +8 -4
- package/docs/cli.md +2 -2
- package/docs/command-map.md +5 -4
- package/docs/engine/commands.md +19 -8
- package/docs/engine/state-schema.md +2 -2
- package/docs/engine/workspace-schema.md +9 -3
- package/docs/flow.md +1 -1
- package/docs/orchestration.md +4 -2
- package/docs/quick-reference.md +5 -0
- package/docs/release.md +55 -7
- package/docs/skills.md +3 -3
- package/docs/usage.md +2 -1
- package/engine/.golangci.yml +27 -0
- package/engine/AGENTS.md +24 -0
- package/engine/Makefile +20 -5
- package/engine/cmd/releasepack/main.go +2 -2
- package/engine/cmd/releasepack/main_test.go +4 -4
- package/engine/commands.go +27 -0
- package/engine/internal/devritespaths/paths.go +3 -0
- package/engine/internal/fsutil/copy.go +2 -0
- package/engine/internal/fsutil/copy_test.go +193 -0
- package/engine/internal/gate/gate.go +30 -0
- package/engine/internal/gate/gate_test.go +7 -7
- package/engine/internal/gate/readiness_binding.go +10 -7
- package/engine/internal/gate/readiness_binding_test.go +51 -3
- package/engine/internal/hostpack/hostpack.go +23 -5
- package/engine/internal/hostpack/hostpack_test.go +41 -5
- package/engine/internal/install/apply.go +324 -0
- package/engine/internal/install/binary.go +259 -0
- package/engine/internal/install/install.go +13 -1599
- package/engine/internal/install/install_test.go +12 -5
- package/engine/internal/install/manifest.go +112 -0
- package/engine/internal/install/merge.go +473 -0
- package/engine/internal/install/preflight.go +235 -0
- package/engine/internal/install/uninstall.go +119 -0
- package/engine/internal/install/update.go +185 -0
- package/engine/internal/lib/candidate.go +4 -2
- package/engine/internal/lib/candidate_test.go +4 -1
- package/engine/internal/lib/closeout.go +4 -0
- package/engine/internal/lib/closeout_test.go +3 -3
- package/engine/internal/lib/environment_report.go +109 -0
- package/engine/internal/lib/environment_report_test.go +54 -0
- package/engine/internal/lib/migrate.go +220 -0
- package/engine/internal/lib/migrate_test.go +154 -0
- package/engine/internal/lib/open_visual.go +5 -0
- package/engine/internal/lib/resolve.go +6 -0
- package/engine/internal/lib/resolve_remediation_test.go +1 -1
- package/engine/internal/lib/secretscan.go +1 -0
- package/engine/internal/lib/secretscan_test.go +1 -0
- package/engine/internal/lib/skilltrust.go +2 -1
- package/engine/internal/lib/taskgraph_test.go +2 -2
- package/engine/internal/lib/util.go +1 -0
- package/engine/internal/lib/workspace_read.go +1 -0
- package/engine/internal/markdowntext/markdowntext_fuzz_test.go +36 -0
- package/engine/internal/parallel/cli.go +1 -0
- package/engine/internal/parallel/git.go +1 -0
- package/engine/internal/parallel/lease.go +1 -0
- package/engine/internal/parallel/ops.go +67 -16
- package/engine/internal/parallel/ops_test.go +211 -0
- package/engine/internal/parallel/pathdisjoint.go +6 -0
- package/engine/internal/parallel/pathdisjoint_fuzz_test.go +43 -0
- package/engine/internal/parallel/pathdisjoint_test.go +4 -1
- package/engine/internal/parallel/testdata/fuzz/FuzzPathDisjoint/a449b81b4711b7b4 +3 -0
- package/engine/internal/release/release.go +8 -4
- package/engine/internal/rootfacts/facts.go +3 -0
- package/engine/internal/safepath/safepath_fuzz_test.go +21 -0
- package/engine/internal/state/acceptance.go +87 -0
- package/engine/internal/state/acceptance_test.go +57 -0
- package/engine/internal/state/cmd/workflowmanifest/main.go +24 -13
- package/engine/internal/state/cmd/workflowmanifest/main_test.go +96 -0
- package/engine/internal/state/cursor.go +129 -14
- package/engine/internal/state/cursor_fuzz_test.go +80 -0
- package/engine/internal/state/lock_unix.go +1 -0
- package/engine/internal/state/observation.go +3 -3
- package/engine/internal/state/observation_test.go +1 -1
- package/engine/internal/state/schema.go +3 -2
- package/engine/internal/state/state_test.go +2 -2
- package/engine/internal/state/taskgraph_fuzz_test.go +38 -0
- package/engine/internal/state/testdata/fuzz/FuzzCursorRoundTrip/114b28f68c1fa4db +4 -0
- package/engine/internal/state/testdata/fuzz/FuzzCursorRoundTrip/378a0f2218e812ea +4 -0
- package/engine/internal/state/testdata/fuzz/FuzzCursorRoundTrip/39eaa26fcb481e3c +4 -0
- package/engine/internal/state/testdata/fuzz/FuzzCursorRoundTrip/776ca1dc0143acf0 +4 -0
- package/engine/internal/state/testdata/fuzz/FuzzCursorRoundTrip/9295930c1ebb81df +4 -0
- package/engine/internal/state/testdata/fuzz/FuzzCursorRoundTrip/a60de309dc33be0d +4 -0
- package/engine/internal/state/testdata/fuzz/FuzzCursorRoundTrip/f04dc7b06ef7c99f +4 -0
- package/engine/internal/state/testdata/fuzz/FuzzCursorRoundTrip/f3000ac510878bd6 +4 -0
- package/engine/internal/state/testdata/fuzz/FuzzWorkspaceSchemaRow/a75aabb9f2a847d5 +2 -0
- package/engine/internal/state/workflow_manifest.json +1 -1
- package/engine/internal/state/workspaceschema.go +58 -0
- package/engine/internal/state/workspaceschema_fuzz_test.go +27 -0
- package/engine/internal/state/workspaceschema_test.go +67 -0
- package/engine/internal/state/write.go +3 -2
- package/engine/internal/testutil/testutil.go +4 -2
- package/engine/main.go +26 -32
- package/engine/observation_contract_test.go +174 -0
- package/engine/root_routing_test.go +24 -5
- package/engine/testdata/fixtures/basic/devrites-root/work/auth-tokens/state.md +1 -0
- package/engine/testdata/fixtures/basic/devrites-root/work/search-ranking/state.md +1 -0
- package/engine/testdata/golden/TestParityResolve/answer/state.md.golden +1 -0
- package/engine/testdata/golden/TestParityResolve/drop/state.md.golden +1 -0
- package/engine/tests/adr_0027_readiness_binding_test.go +1 -1
- package/engine/tests/cli_test.go +2 -2
- package/engine/tests/gate_test.go +2 -2
- package/engine/tests/parity_closeout_test.go +3 -0
- package/engine/tests/parity_resolve_test.go +1 -0
- package/pack/.claude/agents/devrites-code-reviewer.md +16 -6
- package/pack/.claude/agents/devrites-devex-reviewer.md +11 -6
- package/pack/.claude/agents/devrites-doubt-reviewer.md +7 -0
- package/pack/.claude/agents/devrites-evidence-scout.md +17 -2
- package/pack/.claude/agents/devrites-frontend-reviewer.md +43 -15
- package/pack/.claude/agents/devrites-performance-reviewer.md +11 -7
- package/pack/.claude/agents/devrites-plan-reviewer.md +13 -3
- package/pack/.claude/agents/devrites-proof-runner.md +1 -1
- package/pack/.claude/agents/devrites-retrospector.md +7 -1
- package/pack/.claude/agents/devrites-security-auditor.md +13 -5
- package/pack/.claude/agents/devrites-simplifier-reviewer.md +10 -2
- package/pack/.claude/agents/devrites-slice-wright.md +7 -11
- package/pack/.claude/agents/devrites-spec-reviewer.md +9 -1
- package/pack/.claude/agents/devrites-strategy-reviewer.md +11 -4
- package/pack/.claude/agents/devrites-test-analyst.md +9 -1
- package/pack/.claude/skills/devrites-api-interface/SKILL.md +9 -9
- package/pack/.claude/skills/devrites-audit/SKILL.md +3 -1
- package/pack/.claude/skills/devrites-debug-recovery/SKILL.md +9 -2
- package/pack/.claude/skills/devrites-debug-recovery/reference/cleanup-and-classify.md +3 -10
- package/pack/.claude/skills/devrites-debug-recovery/reference/regression-test.md +1 -1
- package/pack/.claude/skills/devrites-doubt/SKILL.md +5 -7
- package/pack/.claude/skills/devrites-frontend-craft/SKILL.md +6 -16
- package/pack/.claude/skills/devrites-frontend-craft/reference/craft.md +5 -13
- package/pack/.claude/skills/devrites-frontend-craft/reference/design-references.md +2 -3
- package/pack/.claude/skills/devrites-frontend-craft/reference/fullstack.md +4 -3
- package/pack/.claude/skills/devrites-frontend-craft/reference/quality-standards.md +82 -21
- package/pack/.claude/skills/devrites-frontend-craft/reference/reuse-first.md +4 -9
- package/pack/.claude/skills/devrites-frontend-craft/reference/shape.md +3 -7
- package/pack/.claude/skills/devrites-interview/SKILL.md +4 -3
- package/pack/.claude/skills/devrites-lib/SKILL.md +2 -1
- package/pack/.claude/skills/devrites-lib/reference/candidate-integrity.md +1 -9
- package/pack/.claude/skills/devrites-lib/reference/intent-map.md +27 -3
- package/pack/.claude/skills/devrites-lib/reference/orchestration-profiles.md +5 -0
- package/pack/.claude/skills/devrites-lib/reference/parallel-dispatch.md +34 -4
- package/pack/.claude/skills/devrites-lib/reference/reply-contract.md +10 -3
- package/pack/.claude/skills/devrites-lib/reference/standards/README.md +7 -0
- package/pack/.claude/skills/devrites-lib/reference/standards/afk-hitl.md +34 -15
- package/pack/.claude/skills/devrites-lib/reference/standards/agents.md +13 -5
- package/pack/.claude/skills/devrites-lib/reference/standards/browser-proof-checklist.md +19 -3
- package/pack/.claude/skills/devrites-lib/reference/standards/ci-cd.md +1 -1
- package/pack/.claude/skills/devrites-lib/reference/standards/code-navigation.md +43 -0
- package/pack/.claude/skills/devrites-lib/reference/standards/code-review.md +25 -2
- package/pack/.claude/skills/devrites-lib/reference/standards/coding-style.md +4 -3
- package/pack/.claude/skills/devrites-lib/reference/standards/context-hygiene.md +9 -1
- package/pack/.claude/skills/devrites-lib/reference/standards/core.md +34 -10
- package/pack/.claude/skills/devrites-lib/reference/standards/data-integrity.md +24 -1
- package/pack/.claude/skills/devrites-lib/reference/standards/debug-recovery.md +8 -1
- package/pack/.claude/skills/devrites-lib/reference/standards/definition-of-done.md +14 -11
- package/pack/.claude/skills/devrites-lib/reference/standards/documentation.md +4 -1
- package/pack/.claude/skills/devrites-lib/reference/standards/edge-case-trace.md +5 -3
- package/pack/.claude/skills/devrites-lib/reference/standards/elicitation.md +6 -1
- package/pack/.claude/skills/devrites-lib/reference/standards/error-handling.md +5 -2
- package/pack/.claude/skills/devrites-lib/reference/standards/integration-reliability.md +32 -9
- package/pack/.claude/skills/devrites-lib/reference/standards/loop-operations.md +2 -2
- package/pack/.claude/skills/devrites-lib/reference/standards/observability.md +6 -1
- package/pack/.claude/skills/devrites-lib/reference/standards/one-shot-actions.md +2 -2
- package/pack/.claude/skills/devrites-lib/reference/standards/patterns.md +16 -0
- package/pack/.claude/skills/devrites-lib/reference/standards/performance.md +20 -0
- package/pack/.claude/skills/devrites-lib/reference/standards/prose-style.md +7 -0
- package/pack/.claude/skills/devrites-lib/reference/standards/repository-topology.md +8 -1
- package/pack/.claude/skills/devrites-lib/reference/standards/review-checklist.md +7 -5
- package/pack/.claude/skills/devrites-lib/reference/standards/security-checklist.md +13 -1
- package/pack/.claude/skills/devrites-lib/reference/standards/security.md +109 -11
- package/pack/.claude/skills/devrites-lib/reference/standards/skill-authoring.md +53 -2
- package/pack/.claude/skills/devrites-lib/reference/standards/spec-grammar.md +28 -26
- package/pack/.claude/skills/devrites-lib/reference/standards/testing.md +22 -2
- package/pack/.claude/skills/devrites-lib/reference/standards/tooling.md +40 -12
- package/pack/.claude/skills/devrites-lib/reference/standards/workflow-artifacts.md +24 -8
- package/pack/.claude/skills/devrites-lib/reference/visual-playbooks/code.md +0 -2
- package/pack/.claude/skills/devrites-lib/reference/visual-playbooks/comparison.md +0 -2
- package/pack/.claude/skills/devrites-lib/reference/visual-playbooks/diagram.md +1 -3
- package/pack/.claude/skills/devrites-lib/reference/visual-playbooks/index.md +2 -4
- package/pack/.claude/skills/devrites-lib/reference/visual-playbooks/input.md +1 -2
- package/pack/.claude/skills/devrites-lib/reference/visual-playbooks/plan.md +1 -2
- package/pack/.claude/skills/devrites-lib/reference/visual-playbooks/slides.md +0 -2
- package/pack/.claude/skills/devrites-lib/reference/visual-playbooks/table.md +0 -2
- package/pack/.claude/skills/devrites-lib/reference/workspace-artifact-schema.md +7 -5
- package/pack/.claude/skills/devrites-prose-craft/SKILL.md +11 -7
- package/pack/.claude/skills/devrites-prose-craft/reference/banned-phrases.md +41 -4
- package/pack/.claude/skills/devrites-prose-craft/reference/examples.md +31 -2
- package/pack/.claude/skills/devrites-prose-craft/reference/structures.md +62 -0
- package/pack/.claude/skills/devrites-source-driven/SKILL.md +11 -12
- package/pack/.claude/skills/devrites-ux-shape/SKILL.md +5 -6
- package/pack/.claude/skills/rite/SKILL.md +3 -1
- package/pack/.claude/skills/rite-adopt/SKILL.md +9 -8
- package/pack/.claude/skills/rite-autocomplete/SKILL.md +9 -6
- package/pack/.claude/skills/rite-build/SKILL.md +6 -3
- package/pack/.claude/skills/rite-build/reference/afk-discipline.md +2 -2
- package/pack/.claude/skills/rite-build/reference/checkpoint.md +3 -1
- package/pack/.claude/skills/rite-build/reference/output.md +2 -2
- package/pack/.claude/skills/rite-build/reference/parallel-batch.md +19 -2
- package/pack/.claude/skills/rite-build/reference/phase-contract.md +5 -5
- package/pack/.claude/skills/rite-build/reference/tdd.md +3 -2
- package/pack/.claude/skills/rite-build/reference/wright-dispatch.md +7 -7
- package/pack/.claude/skills/rite-clarify/SKILL.md +6 -5
- package/pack/.claude/skills/rite-converge/SKILL.md +8 -7
- package/pack/.claude/skills/rite-converge/reference/anti-patterns.md +1 -1
- package/pack/.claude/skills/rite-customize/SKILL.md +9 -0
- package/pack/.claude/skills/rite-define/SKILL.md +4 -7
- package/pack/.claude/skills/rite-define/reference/anti-patterns.md +1 -1
- package/pack/.claude/skills/rite-define/reference/gates.md +6 -5
- package/pack/.claude/skills/rite-define/reference/plan-template.md +2 -2
- package/pack/.claude/skills/rite-dogfood/SKILL.md +10 -4
- package/pack/.claude/skills/rite-explain/SKILL.md +9 -5
- package/pack/.claude/skills/rite-explain/reference/intake.md +2 -1
- package/pack/.claude/skills/rite-frame/SKILL.md +1 -1
- package/pack/.claude/skills/rite-handoff/SKILL.md +1 -1
- package/pack/.claude/skills/rite-learn/SKILL.md +22 -4
- package/pack/.claude/skills/rite-plan/SKILL.md +4 -4
- package/pack/.claude/skills/rite-plan/reference/anti-patterns.md +2 -2
- package/pack/.claude/skills/rite-plan/reference/replan-and-repair.md +24 -0
- package/pack/.claude/skills/rite-polish/SKILL.md +13 -6
- package/pack/.claude/skills/rite-polish/reference/anti-ai-slop.md +20 -0
- package/pack/.claude/skills/rite-polish/reference/browser-polish-evidence.md +3 -1
- package/pack/.claude/skills/rite-polish/reference/code.md +1 -19
- package/pack/.claude/skills/rite-polish/reference/harden-checklist.md +1 -1
- package/pack/.claude/skills/rite-polish/reference/ledger.md +3 -0
- package/pack/.claude/skills/rite-polish/reference/ui.md +4 -3
- package/pack/.claude/skills/rite-pov/SKILL.md +16 -1
- package/pack/.claude/skills/rite-pr-feedback/SKILL.md +1 -1
- package/pack/.claude/skills/rite-pressure-test/SKILL.md +2 -1
- package/pack/.claude/skills/rite-prototype/SKILL.md +2 -2
- package/pack/.claude/skills/rite-prove/SKILL.md +6 -6
- package/pack/.claude/skills/rite-prove/reference/acceptance-proof.md +8 -9
- package/pack/.claude/skills/rite-prove/reference/browser-proof.md +5 -3
- package/pack/.claude/skills/rite-prove/reference/test-command-discovery.md +0 -1
- package/pack/.claude/skills/rite-quick/SKILL.md +6 -4
- package/pack/.claude/skills/rite-resolve/SKILL.md +5 -4
- package/pack/.claude/skills/rite-resolve/reference/answer-protocol.md +1 -1
- package/pack/.claude/skills/rite-review/SKILL.md +18 -27
- package/pack/.claude/skills/rite-review/reference/cognitive-load.md +0 -2
- package/pack/.claude/skills/rite-review/reference/five-axis-review.md +3 -3
- package/pack/.claude/skills/rite-review/reference/nielsen-heuristics.md +3 -7
- package/pack/.claude/skills/rite-seal/SKILL.md +7 -3
- package/pack/.claude/skills/rite-seal/reference/final-evidence.md +5 -6
- package/pack/.claude/skills/rite-seal/reference/risk-and-rollback.md +1 -1
- package/pack/.claude/skills/rite-seal/reference/seal-template.md +2 -0
- package/pack/.claude/skills/rite-ship/SKILL.md +3 -2
- package/pack/.claude/skills/rite-ship/reference/close-out.md +25 -5
- package/pack/.claude/skills/rite-ship/reference/rollout.md +1 -1
- package/pack/.claude/skills/rite-spec/SKILL.md +2 -1
- package/pack/.claude/skills/rite-spec/reference/anti-patterns.md +0 -1
- package/pack/.claude/skills/rite-spec/reference/investigation.md +1 -3
- package/pack/.claude/skills/rite-spec/reference/spec-checklists.md +1 -1
- package/pack/.claude/skills/rite-spec/reference/spec-template.md +1 -1
- package/pack/.claude/skills/rite-spec/reference/state-workspace.md +6 -3
- package/pack/.claude/skills/rite-status/SKILL.md +3 -1
- package/pack/.claude/skills/rite-temper/SKILL.md +9 -9
- package/pack/.claude/skills/rite-temper/reference/review-dimensions.md +2 -2
- package/pack/.claude/skills/rite-temper/reference/scope-modes.md +2 -2
- package/pack/.claude/skills/rite-temper/reference/significance.md +4 -4
- package/pack/.claude/skills/rite-temper/reference/strategy-template.md +6 -6
- package/pack/.claude/skills/rite-upgrade/SKILL.md +2 -2
- package/pack/.claude/skills/rite-vet/SKILL.md +14 -10
- package/pack/.claude/skills/rite-vet/reference/artifacts.md +9 -1
- package/pack/.claude/skills/rite-vet/reference/review-axes.md +14 -2
- package/pack/.claude/skills/rite-watch-pr/SKILL.md +2 -2
- package/pack/.claude/skills/rite-zoom-out/SKILL.md +4 -4
- package/pack/generated/README.md +4 -2
- package/pack/generated/claude/agents/devrites-code-reviewer.md +16 -6
- package/pack/generated/claude/agents/devrites-devex-reviewer.md +11 -6
- package/pack/generated/claude/agents/devrites-doubt-reviewer.md +7 -0
- package/pack/generated/claude/agents/devrites-evidence-scout.md +17 -2
- package/pack/generated/claude/agents/devrites-frontend-reviewer.md +43 -15
- package/pack/generated/claude/agents/devrites-performance-reviewer.md +11 -7
- package/pack/generated/claude/agents/devrites-plan-reviewer.md +13 -3
- package/pack/generated/claude/agents/devrites-proof-runner.md +1 -1
- package/pack/generated/claude/agents/devrites-retrospector.md +7 -1
- package/pack/generated/claude/agents/devrites-security-auditor.md +13 -5
- package/pack/generated/claude/agents/devrites-simplifier-reviewer.md +10 -2
- package/pack/generated/claude/agents/devrites-slice-wright.md +7 -11
- package/pack/generated/claude/agents/devrites-spec-reviewer.md +9 -1
- package/pack/generated/claude/agents/devrites-strategy-reviewer.md +11 -4
- package/pack/generated/claude/agents/devrites-test-analyst.md +9 -1
- package/pack/generated/claude/skills/devrites-api-interface/SKILL.md +9 -9
- package/pack/generated/claude/skills/devrites-audit/SKILL.md +3 -1
- package/pack/generated/claude/skills/devrites-debug-recovery/SKILL.md +9 -2
- package/pack/generated/claude/skills/devrites-debug-recovery/reference/cleanup-and-classify.md +3 -10
- package/pack/generated/claude/skills/devrites-debug-recovery/reference/regression-test.md +1 -1
- package/pack/generated/claude/skills/devrites-doubt/SKILL.md +5 -7
- package/pack/generated/claude/skills/devrites-frontend-craft/SKILL.md +6 -16
- package/pack/generated/claude/skills/devrites-frontend-craft/reference/craft.md +5 -13
- package/pack/generated/claude/skills/devrites-frontend-craft/reference/design-references.md +2 -3
- package/pack/generated/claude/skills/devrites-frontend-craft/reference/fullstack.md +4 -3
- package/pack/generated/claude/skills/devrites-frontend-craft/reference/quality-standards.md +82 -21
- package/pack/generated/claude/skills/devrites-frontend-craft/reference/reuse-first.md +4 -9
- package/pack/generated/claude/skills/devrites-frontend-craft/reference/shape.md +3 -7
- package/pack/generated/claude/skills/devrites-interview/SKILL.md +4 -3
- package/pack/generated/claude/skills/devrites-lib/SKILL.md +2 -1
- package/pack/generated/claude/skills/devrites-lib/reference/candidate-integrity.md +1 -9
- package/pack/generated/claude/skills/devrites-lib/reference/intent-map.md +27 -3
- package/pack/generated/claude/skills/devrites-lib/reference/orchestration-profiles.md +5 -0
- package/pack/generated/claude/skills/devrites-lib/reference/parallel-dispatch.md +34 -4
- package/pack/generated/claude/skills/devrites-lib/reference/reply-contract.md +10 -3
- package/pack/generated/claude/skills/devrites-lib/reference/standards/README.md +7 -0
- package/pack/generated/claude/skills/devrites-lib/reference/standards/afk-hitl.md +34 -15
- package/pack/generated/claude/skills/devrites-lib/reference/standards/agents.md +13 -5
- package/pack/generated/claude/skills/devrites-lib/reference/standards/browser-proof-checklist.md +19 -3
- package/pack/generated/claude/skills/devrites-lib/reference/standards/ci-cd.md +1 -1
- package/pack/generated/claude/skills/devrites-lib/reference/standards/code-navigation.md +43 -0
- package/pack/generated/claude/skills/devrites-lib/reference/standards/code-review.md +25 -2
- package/pack/generated/claude/skills/devrites-lib/reference/standards/coding-style.md +4 -3
- package/pack/generated/claude/skills/devrites-lib/reference/standards/context-hygiene.md +9 -1
- package/pack/generated/claude/skills/devrites-lib/reference/standards/core.md +34 -10
- package/pack/generated/claude/skills/devrites-lib/reference/standards/data-integrity.md +24 -1
- package/pack/generated/claude/skills/devrites-lib/reference/standards/debug-recovery.md +8 -1
- package/pack/generated/claude/skills/devrites-lib/reference/standards/definition-of-done.md +14 -11
- package/pack/generated/claude/skills/devrites-lib/reference/standards/documentation.md +4 -1
- package/pack/generated/claude/skills/devrites-lib/reference/standards/edge-case-trace.md +5 -3
- package/pack/generated/claude/skills/devrites-lib/reference/standards/elicitation.md +6 -1
- package/pack/generated/claude/skills/devrites-lib/reference/standards/error-handling.md +5 -2
- package/pack/generated/claude/skills/devrites-lib/reference/standards/integration-reliability.md +32 -9
- package/pack/generated/claude/skills/devrites-lib/reference/standards/loop-operations.md +2 -2
- package/pack/generated/claude/skills/devrites-lib/reference/standards/observability.md +6 -1
- package/pack/generated/claude/skills/devrites-lib/reference/standards/one-shot-actions.md +2 -2
- package/pack/generated/claude/skills/devrites-lib/reference/standards/patterns.md +16 -0
- package/pack/generated/claude/skills/devrites-lib/reference/standards/performance.md +20 -0
- package/pack/generated/claude/skills/devrites-lib/reference/standards/prose-style.md +7 -0
- package/pack/generated/claude/skills/devrites-lib/reference/standards/repository-topology.md +8 -1
- package/pack/generated/claude/skills/devrites-lib/reference/standards/review-checklist.md +7 -5
- package/pack/generated/claude/skills/devrites-lib/reference/standards/security-checklist.md +13 -1
- package/pack/generated/claude/skills/devrites-lib/reference/standards/security.md +109 -11
- package/pack/generated/claude/skills/devrites-lib/reference/standards/skill-authoring.md +53 -2
- package/pack/generated/claude/skills/devrites-lib/reference/standards/spec-grammar.md +28 -26
- package/pack/generated/claude/skills/devrites-lib/reference/standards/testing.md +22 -2
- package/pack/generated/claude/skills/devrites-lib/reference/standards/tooling.md +40 -12
- package/pack/generated/claude/skills/devrites-lib/reference/standards/workflow-artifacts.md +24 -8
- package/pack/generated/claude/skills/devrites-lib/reference/visual-playbooks/code.md +0 -2
- package/pack/generated/claude/skills/devrites-lib/reference/visual-playbooks/comparison.md +0 -2
- package/pack/generated/claude/skills/devrites-lib/reference/visual-playbooks/diagram.md +1 -3
- package/pack/generated/claude/skills/devrites-lib/reference/visual-playbooks/index.md +2 -4
- package/pack/generated/claude/skills/devrites-lib/reference/visual-playbooks/input.md +1 -2
- package/pack/generated/claude/skills/devrites-lib/reference/visual-playbooks/plan.md +1 -2
- package/pack/generated/claude/skills/devrites-lib/reference/visual-playbooks/slides.md +0 -2
- package/pack/generated/claude/skills/devrites-lib/reference/visual-playbooks/table.md +0 -2
- package/pack/generated/claude/skills/devrites-lib/reference/workspace-artifact-schema.md +7 -5
- package/pack/generated/claude/skills/devrites-prose-craft/SKILL.md +11 -7
- package/pack/generated/claude/skills/devrites-prose-craft/reference/banned-phrases.md +41 -4
- package/pack/generated/claude/skills/devrites-prose-craft/reference/examples.md +31 -2
- package/pack/generated/claude/skills/devrites-prose-craft/reference/structures.md +62 -0
- package/pack/generated/claude/skills/devrites-source-driven/SKILL.md +11 -12
- package/pack/generated/claude/skills/devrites-ux-shape/SKILL.md +5 -6
- package/pack/generated/claude/skills/rite/SKILL.md +3 -1
- package/pack/generated/claude/skills/rite-adopt/SKILL.md +9 -8
- package/pack/generated/claude/skills/rite-autocomplete/SKILL.md +9 -6
- package/pack/generated/claude/skills/rite-build/SKILL.md +6 -3
- package/pack/generated/claude/skills/rite-build/reference/afk-discipline.md +2 -2
- package/pack/generated/claude/skills/rite-build/reference/checkpoint.md +3 -1
- package/pack/generated/claude/skills/rite-build/reference/output.md +2 -2
- package/pack/generated/claude/skills/rite-build/reference/parallel-batch.md +19 -2
- package/pack/generated/claude/skills/rite-build/reference/phase-contract.md +5 -5
- package/pack/generated/claude/skills/rite-build/reference/tdd.md +3 -2
- package/pack/generated/claude/skills/rite-build/reference/wright-dispatch.md +7 -7
- package/pack/generated/claude/skills/rite-clarify/SKILL.md +6 -5
- package/pack/generated/claude/skills/rite-converge/SKILL.md +8 -7
- package/pack/generated/claude/skills/rite-converge/reference/anti-patterns.md +1 -1
- package/pack/generated/claude/skills/rite-customize/SKILL.md +9 -0
- package/pack/generated/claude/skills/rite-define/SKILL.md +4 -7
- package/pack/generated/claude/skills/rite-define/reference/anti-patterns.md +1 -1
- package/pack/generated/claude/skills/rite-define/reference/gates.md +6 -5
- package/pack/generated/claude/skills/rite-define/reference/plan-template.md +2 -2
- package/pack/generated/claude/skills/rite-dogfood/SKILL.md +10 -4
- package/pack/generated/claude/skills/rite-explain/SKILL.md +9 -5
- package/pack/generated/claude/skills/rite-explain/reference/intake.md +2 -1
- package/pack/generated/claude/skills/rite-frame/SKILL.md +1 -1
- package/pack/generated/claude/skills/rite-handoff/SKILL.md +1 -1
- package/pack/generated/claude/skills/rite-learn/SKILL.md +22 -4
- package/pack/generated/claude/skills/rite-plan/SKILL.md +4 -4
- package/pack/generated/claude/skills/rite-plan/reference/anti-patterns.md +2 -2
- package/pack/generated/claude/skills/rite-plan/reference/replan-and-repair.md +24 -0
- package/pack/generated/claude/skills/rite-polish/SKILL.md +13 -6
- package/pack/generated/claude/skills/rite-polish/reference/anti-ai-slop.md +20 -0
- package/pack/generated/claude/skills/rite-polish/reference/browser-polish-evidence.md +3 -1
- package/pack/generated/claude/skills/rite-polish/reference/code.md +1 -19
- package/pack/generated/claude/skills/rite-polish/reference/harden-checklist.md +1 -1
- package/pack/generated/claude/skills/rite-polish/reference/ledger.md +3 -0
- package/pack/generated/claude/skills/rite-polish/reference/ui.md +4 -3
- package/pack/generated/claude/skills/rite-pov/SKILL.md +16 -1
- package/pack/generated/claude/skills/rite-pr-feedback/SKILL.md +1 -1
- package/pack/generated/claude/skills/rite-pressure-test/SKILL.md +2 -1
- package/pack/generated/claude/skills/rite-prototype/SKILL.md +2 -2
- package/pack/generated/claude/skills/rite-prove/SKILL.md +6 -6
- package/pack/generated/claude/skills/rite-prove/reference/acceptance-proof.md +8 -9
- package/pack/generated/claude/skills/rite-prove/reference/browser-proof.md +5 -3
- package/pack/generated/claude/skills/rite-prove/reference/test-command-discovery.md +0 -1
- package/pack/generated/claude/skills/rite-quick/SKILL.md +6 -4
- package/pack/generated/claude/skills/rite-resolve/SKILL.md +5 -4
- package/pack/generated/claude/skills/rite-resolve/reference/answer-protocol.md +1 -1
- package/pack/generated/claude/skills/rite-review/SKILL.md +18 -27
- package/pack/generated/claude/skills/rite-review/reference/cognitive-load.md +0 -2
- package/pack/generated/claude/skills/rite-review/reference/five-axis-review.md +3 -3
- package/pack/generated/claude/skills/rite-review/reference/nielsen-heuristics.md +3 -7
- package/pack/generated/claude/skills/rite-seal/SKILL.md +7 -3
- package/pack/generated/claude/skills/rite-seal/reference/final-evidence.md +5 -6
- package/pack/generated/claude/skills/rite-seal/reference/risk-and-rollback.md +1 -1
- package/pack/generated/claude/skills/rite-seal/reference/seal-template.md +2 -0
- package/pack/generated/claude/skills/rite-ship/SKILL.md +3 -2
- package/pack/generated/claude/skills/rite-ship/reference/close-out.md +25 -5
- package/pack/generated/claude/skills/rite-ship/reference/rollout.md +1 -1
- package/pack/generated/claude/skills/rite-spec/SKILL.md +2 -1
- package/pack/generated/claude/skills/rite-spec/reference/anti-patterns.md +0 -1
- package/pack/generated/claude/skills/rite-spec/reference/investigation.md +1 -3
- package/pack/generated/claude/skills/rite-spec/reference/spec-checklists.md +1 -1
- package/pack/generated/claude/skills/rite-spec/reference/spec-template.md +1 -1
- package/pack/generated/claude/skills/rite-spec/reference/state-workspace.md +6 -3
- package/pack/generated/claude/skills/rite-status/SKILL.md +3 -1
- package/pack/generated/claude/skills/rite-temper/SKILL.md +9 -9
- package/pack/generated/claude/skills/rite-temper/reference/review-dimensions.md +2 -2
- package/pack/generated/claude/skills/rite-temper/reference/scope-modes.md +2 -2
- package/pack/generated/claude/skills/rite-temper/reference/significance.md +4 -4
- package/pack/generated/claude/skills/rite-temper/reference/strategy-template.md +6 -6
- package/pack/generated/claude/skills/rite-upgrade/SKILL.md +2 -2
- package/pack/generated/claude/skills/rite-vet/SKILL.md +14 -10
- package/pack/generated/claude/skills/rite-vet/reference/artifacts.md +9 -1
- package/pack/generated/claude/skills/rite-vet/reference/review-axes.md +14 -2
- package/pack/generated/claude/skills/rite-watch-pr/SKILL.md +2 -2
- package/pack/generated/claude/skills/rite-zoom-out/SKILL.md +4 -4
- package/pack/generated/codex/agents/devrites-code-reviewer.toml +16 -6
- package/pack/generated/codex/agents/devrites-devex-reviewer.toml +11 -6
- package/pack/generated/codex/agents/devrites-doubt-reviewer.toml +7 -0
- package/pack/generated/codex/agents/devrites-evidence-scout.toml +17 -2
- package/pack/generated/codex/agents/devrites-frontend-reviewer.toml +43 -15
- package/pack/generated/codex/agents/devrites-performance-reviewer.toml +11 -7
- package/pack/generated/codex/agents/devrites-plan-reviewer.toml +13 -3
- package/pack/generated/codex/agents/devrites-proof-runner.toml +1 -1
- package/pack/generated/codex/agents/devrites-retrospector.toml +7 -1
- package/pack/generated/codex/agents/devrites-security-auditor.toml +13 -5
- package/pack/generated/codex/agents/devrites-simplifier-reviewer.toml +10 -2
- package/pack/generated/codex/agents/devrites-slice-wright.toml +7 -11
- package/pack/generated/codex/agents/devrites-spec-reviewer.toml +9 -1
- package/pack/generated/codex/agents/devrites-strategy-reviewer.toml +11 -4
- package/pack/generated/codex/agents/devrites-test-analyst.toml +9 -1
- package/pack/generated/codex/skills/devrites-api-interface/SKILL.md +9 -9
- package/pack/generated/codex/skills/devrites-audit/SKILL.md +3 -1
- package/pack/generated/codex/skills/devrites-debug-recovery/SKILL.md +9 -2
- package/pack/generated/codex/skills/devrites-debug-recovery/reference/cleanup-and-classify.md +3 -10
- package/pack/generated/codex/skills/devrites-debug-recovery/reference/regression-test.md +1 -1
- package/pack/generated/codex/skills/devrites-doubt/SKILL.md +5 -7
- package/pack/generated/codex/skills/devrites-frontend-craft/SKILL.md +6 -16
- package/pack/generated/codex/skills/devrites-frontend-craft/reference/craft.md +5 -13
- package/pack/generated/codex/skills/devrites-frontend-craft/reference/design-references.md +2 -3
- package/pack/generated/codex/skills/devrites-frontend-craft/reference/fullstack.md +4 -3
- package/pack/generated/codex/skills/devrites-frontend-craft/reference/quality-standards.md +82 -21
- package/pack/generated/codex/skills/devrites-frontend-craft/reference/reuse-first.md +4 -9
- package/pack/generated/codex/skills/devrites-frontend-craft/reference/shape.md +3 -7
- package/pack/generated/codex/skills/devrites-interview/SKILL.md +4 -3
- package/pack/generated/codex/skills/devrites-lib/SKILL.md +2 -1
- package/pack/generated/codex/skills/devrites-lib/reference/candidate-integrity.md +1 -9
- package/pack/generated/codex/skills/devrites-lib/reference/intent-map.md +27 -3
- package/pack/generated/codex/skills/devrites-lib/reference/orchestration-profiles.md +5 -0
- package/pack/generated/codex/skills/devrites-lib/reference/parallel-dispatch.md +34 -4
- package/pack/generated/codex/skills/devrites-lib/reference/reply-contract.md +10 -3
- package/pack/generated/codex/skills/devrites-lib/reference/standards/README.md +7 -0
- package/pack/generated/codex/skills/devrites-lib/reference/standards/afk-hitl.md +34 -15
- package/pack/generated/codex/skills/devrites-lib/reference/standards/agents.md +13 -5
- package/pack/generated/codex/skills/devrites-lib/reference/standards/browser-proof-checklist.md +19 -3
- package/pack/generated/codex/skills/devrites-lib/reference/standards/ci-cd.md +1 -1
- package/pack/generated/codex/skills/devrites-lib/reference/standards/code-navigation.md +43 -0
- package/pack/generated/codex/skills/devrites-lib/reference/standards/code-review.md +25 -2
- package/pack/generated/codex/skills/devrites-lib/reference/standards/coding-style.md +4 -3
- package/pack/generated/codex/skills/devrites-lib/reference/standards/context-hygiene.md +9 -1
- package/pack/generated/codex/skills/devrites-lib/reference/standards/core.md +34 -10
- package/pack/generated/codex/skills/devrites-lib/reference/standards/data-integrity.md +24 -1
- package/pack/generated/codex/skills/devrites-lib/reference/standards/debug-recovery.md +8 -1
- package/pack/generated/codex/skills/devrites-lib/reference/standards/definition-of-done.md +14 -11
- package/pack/generated/codex/skills/devrites-lib/reference/standards/documentation.md +4 -1
- package/pack/generated/codex/skills/devrites-lib/reference/standards/edge-case-trace.md +5 -3
- package/pack/generated/codex/skills/devrites-lib/reference/standards/elicitation.md +6 -1
- package/pack/generated/codex/skills/devrites-lib/reference/standards/error-handling.md +5 -2
- package/pack/generated/codex/skills/devrites-lib/reference/standards/integration-reliability.md +32 -9
- package/pack/generated/codex/skills/devrites-lib/reference/standards/loop-operations.md +2 -2
- package/pack/generated/codex/skills/devrites-lib/reference/standards/observability.md +6 -1
- package/pack/generated/codex/skills/devrites-lib/reference/standards/one-shot-actions.md +2 -2
- package/pack/generated/codex/skills/devrites-lib/reference/standards/patterns.md +16 -0
- package/pack/generated/codex/skills/devrites-lib/reference/standards/performance.md +20 -0
- package/pack/generated/codex/skills/devrites-lib/reference/standards/prose-style.md +7 -0
- package/pack/generated/codex/skills/devrites-lib/reference/standards/repository-topology.md +8 -1
- package/pack/generated/codex/skills/devrites-lib/reference/standards/review-checklist.md +7 -5
- package/pack/generated/codex/skills/devrites-lib/reference/standards/security-checklist.md +13 -1
- package/pack/generated/codex/skills/devrites-lib/reference/standards/security.md +109 -11
- package/pack/generated/codex/skills/devrites-lib/reference/standards/skill-authoring.md +53 -2
- package/pack/generated/codex/skills/devrites-lib/reference/standards/spec-grammar.md +28 -26
- package/pack/generated/codex/skills/devrites-lib/reference/standards/testing.md +22 -2
- package/pack/generated/codex/skills/devrites-lib/reference/standards/tooling.md +40 -12
- package/pack/generated/codex/skills/devrites-lib/reference/standards/workflow-artifacts.md +24 -8
- package/pack/generated/codex/skills/devrites-lib/reference/visual-playbooks/code.md +0 -2
- package/pack/generated/codex/skills/devrites-lib/reference/visual-playbooks/comparison.md +0 -2
- package/pack/generated/codex/skills/devrites-lib/reference/visual-playbooks/diagram.md +1 -3
- package/pack/generated/codex/skills/devrites-lib/reference/visual-playbooks/index.md +2 -4
- package/pack/generated/codex/skills/devrites-lib/reference/visual-playbooks/input.md +1 -2
- package/pack/generated/codex/skills/devrites-lib/reference/visual-playbooks/plan.md +1 -2
- package/pack/generated/codex/skills/devrites-lib/reference/visual-playbooks/slides.md +0 -2
- package/pack/generated/codex/skills/devrites-lib/reference/visual-playbooks/table.md +0 -2
- package/pack/generated/codex/skills/devrites-lib/reference/workspace-artifact-schema.md +7 -5
- package/pack/generated/codex/skills/devrites-prose-craft/SKILL.md +11 -7
- package/pack/generated/codex/skills/devrites-prose-craft/reference/banned-phrases.md +41 -4
- package/pack/generated/codex/skills/devrites-prose-craft/reference/examples.md +31 -2
- package/pack/generated/codex/skills/devrites-prose-craft/reference/structures.md +62 -0
- package/pack/generated/codex/skills/devrites-source-driven/SKILL.md +11 -12
- package/pack/generated/codex/skills/devrites-ux-shape/SKILL.md +5 -6
- package/pack/generated/codex/skills/rite/SKILL.md +3 -1
- package/pack/generated/codex/skills/rite-adopt/SKILL.md +9 -8
- package/pack/generated/codex/skills/rite-autocomplete/SKILL.md +9 -6
- package/pack/generated/codex/skills/rite-build/SKILL.md +6 -3
- package/pack/generated/codex/skills/rite-build/reference/afk-discipline.md +2 -2
- package/pack/generated/codex/skills/rite-build/reference/checkpoint.md +3 -1
- package/pack/generated/codex/skills/rite-build/reference/output.md +2 -2
- package/pack/generated/codex/skills/rite-build/reference/parallel-batch.md +19 -2
- package/pack/generated/codex/skills/rite-build/reference/phase-contract.md +5 -5
- package/pack/generated/codex/skills/rite-build/reference/tdd.md +3 -2
- package/pack/generated/codex/skills/rite-build/reference/wright-dispatch.md +7 -7
- package/pack/generated/codex/skills/rite-clarify/SKILL.md +6 -5
- package/pack/generated/codex/skills/rite-converge/SKILL.md +8 -7
- package/pack/generated/codex/skills/rite-converge/reference/anti-patterns.md +1 -1
- package/pack/generated/codex/skills/rite-customize/SKILL.md +9 -0
- package/pack/generated/codex/skills/rite-define/SKILL.md +4 -7
- package/pack/generated/codex/skills/rite-define/reference/anti-patterns.md +1 -1
- package/pack/generated/codex/skills/rite-define/reference/gates.md +6 -5
- package/pack/generated/codex/skills/rite-define/reference/plan-template.md +2 -2
- package/pack/generated/codex/skills/rite-dogfood/SKILL.md +10 -4
- package/pack/generated/codex/skills/rite-explain/SKILL.md +9 -5
- package/pack/generated/codex/skills/rite-explain/reference/intake.md +2 -1
- package/pack/generated/codex/skills/rite-frame/SKILL.md +1 -1
- package/pack/generated/codex/skills/rite-handoff/SKILL.md +1 -1
- package/pack/generated/codex/skills/rite-learn/SKILL.md +22 -4
- package/pack/generated/codex/skills/rite-plan/SKILL.md +4 -4
- package/pack/generated/codex/skills/rite-plan/reference/anti-patterns.md +2 -2
- package/pack/generated/codex/skills/rite-plan/reference/replan-and-repair.md +24 -0
- package/pack/generated/codex/skills/rite-polish/SKILL.md +13 -6
- package/pack/generated/codex/skills/rite-polish/reference/anti-ai-slop.md +20 -0
- package/pack/generated/codex/skills/rite-polish/reference/browser-polish-evidence.md +3 -1
- package/pack/generated/codex/skills/rite-polish/reference/code.md +1 -19
- package/pack/generated/codex/skills/rite-polish/reference/harden-checklist.md +1 -1
- package/pack/generated/codex/skills/rite-polish/reference/ledger.md +3 -0
- package/pack/generated/codex/skills/rite-polish/reference/ui.md +4 -3
- package/pack/generated/codex/skills/rite-pov/SKILL.md +16 -1
- package/pack/generated/codex/skills/rite-pr-feedback/SKILL.md +1 -1
- package/pack/generated/codex/skills/rite-pressure-test/SKILL.md +2 -1
- package/pack/generated/codex/skills/rite-prototype/SKILL.md +2 -2
- package/pack/generated/codex/skills/rite-prove/SKILL.md +6 -6
- package/pack/generated/codex/skills/rite-prove/reference/acceptance-proof.md +8 -9
- package/pack/generated/codex/skills/rite-prove/reference/browser-proof.md +5 -3
- package/pack/generated/codex/skills/rite-prove/reference/test-command-discovery.md +0 -1
- package/pack/generated/codex/skills/rite-quick/SKILL.md +6 -4
- package/pack/generated/codex/skills/rite-resolve/SKILL.md +5 -4
- package/pack/generated/codex/skills/rite-resolve/reference/answer-protocol.md +1 -1
- package/pack/generated/codex/skills/rite-review/SKILL.md +18 -27
- package/pack/generated/codex/skills/rite-review/reference/cognitive-load.md +0 -2
- package/pack/generated/codex/skills/rite-review/reference/five-axis-review.md +3 -3
- package/pack/generated/codex/skills/rite-review/reference/nielsen-heuristics.md +3 -7
- package/pack/generated/codex/skills/rite-seal/SKILL.md +7 -3
- package/pack/generated/codex/skills/rite-seal/reference/final-evidence.md +5 -6
- package/pack/generated/codex/skills/rite-seal/reference/risk-and-rollback.md +1 -1
- package/pack/generated/codex/skills/rite-seal/reference/seal-template.md +2 -0
- package/pack/generated/codex/skills/rite-ship/SKILL.md +3 -2
- package/pack/generated/codex/skills/rite-ship/reference/close-out.md +25 -5
- package/pack/generated/codex/skills/rite-ship/reference/rollout.md +1 -1
- package/pack/generated/codex/skills/rite-spec/SKILL.md +2 -1
- package/pack/generated/codex/skills/rite-spec/reference/anti-patterns.md +0 -1
- package/pack/generated/codex/skills/rite-spec/reference/investigation.md +1 -3
- package/pack/generated/codex/skills/rite-spec/reference/spec-checklists.md +1 -1
- package/pack/generated/codex/skills/rite-spec/reference/spec-template.md +1 -1
- package/pack/generated/codex/skills/rite-spec/reference/state-workspace.md +6 -3
- package/pack/generated/codex/skills/rite-status/SKILL.md +3 -1
- package/pack/generated/codex/skills/rite-temper/SKILL.md +9 -9
- package/pack/generated/codex/skills/rite-temper/reference/review-dimensions.md +2 -2
- package/pack/generated/codex/skills/rite-temper/reference/scope-modes.md +2 -2
- package/pack/generated/codex/skills/rite-temper/reference/significance.md +4 -4
- package/pack/generated/codex/skills/rite-temper/reference/strategy-template.md +6 -6
- package/pack/generated/codex/skills/rite-upgrade/SKILL.md +2 -2
- package/pack/generated/codex/skills/rite-vet/SKILL.md +14 -10
- package/pack/generated/codex/skills/rite-vet/reference/artifacts.md +9 -1
- package/pack/generated/codex/skills/rite-vet/reference/review-axes.md +14 -2
- package/pack/generated/codex/skills/rite-watch-pr/SKILL.md +2 -2
- package/pack/generated/codex/skills/rite-zoom-out/SKILL.md +4 -4
- package/pack/generated/omp/.omp-plugin/plugin.json +6 -0
- package/pack/generated/omp/agents/devrites-code-reviewer.md +138 -0
- package/pack/generated/omp/agents/devrites-devex-reviewer.md +123 -0
- package/pack/generated/omp/agents/devrites-doubt-reviewer.md +81 -0
- package/pack/generated/omp/agents/devrites-evidence-scout.md +71 -0
- package/pack/generated/omp/agents/devrites-frontend-reviewer.md +114 -0
- package/pack/generated/omp/agents/devrites-performance-reviewer.md +114 -0
- package/pack/generated/omp/agents/devrites-plan-drafter.md +82 -0
- package/pack/generated/omp/agents/devrites-plan-reviewer.md +132 -0
- package/pack/generated/omp/agents/devrites-proof-runner.md +73 -0
- package/pack/generated/omp/agents/devrites-retrospector.md +60 -0
- package/pack/generated/omp/agents/devrites-security-auditor.md +108 -0
- package/pack/generated/omp/agents/devrites-simplifier-reviewer.md +93 -0
- package/pack/generated/omp/agents/devrites-slice-wright.md +203 -0
- package/pack/generated/omp/agents/devrites-spec-reviewer.md +95 -0
- package/pack/generated/omp/agents/devrites-strategy-reviewer.md +99 -0
- package/pack/generated/omp/agents/devrites-test-analyst.md +88 -0
- package/pack/generated/omp/agents/devrites-upgrade-planner.md +80 -0
- package/pack/generated/omp/skills/devrites-api-interface/SKILL.md +61 -0
- package/pack/generated/omp/skills/devrites-audit/SKILL.md +50 -0
- package/pack/generated/omp/skills/devrites-browser-proof/SKILL.md +76 -0
- package/pack/generated/omp/skills/devrites-browser-proof/reference/browser-performance.md +15 -0
- package/pack/generated/omp/skills/devrites-browser-proof/reference/visual-verdict.md +34 -0
- package/pack/generated/omp/skills/devrites-debug-recovery/SKILL.md +96 -0
- package/pack/generated/omp/skills/devrites-debug-recovery/reference/build-the-loop.md +58 -0
- package/pack/generated/omp/skills/devrites-debug-recovery/reference/cleanup-and-classify.md +34 -0
- package/pack/generated/omp/skills/devrites-debug-recovery/reference/hypotheses.md +17 -0
- package/pack/generated/omp/skills/devrites-debug-recovery/reference/instrumentation.md +21 -0
- package/pack/generated/omp/skills/devrites-debug-recovery/reference/regression-test.md +30 -0
- package/pack/generated/omp/skills/devrites-debug-recovery/reference/trace.md +25 -0
- package/pack/generated/omp/skills/devrites-doubt/SKILL.md +86 -0
- package/pack/generated/omp/skills/devrites-frontend-craft/SKILL.md +86 -0
- package/pack/generated/omp/skills/devrites-frontend-craft/reference/craft.md +63 -0
- package/pack/generated/omp/skills/devrites-frontend-craft/reference/design-references.md +116 -0
- package/pack/generated/omp/skills/devrites-frontend-craft/reference/fullstack.md +46 -0
- package/pack/generated/omp/skills/devrites-frontend-craft/reference/quality-standards.md +294 -0
- package/pack/generated/omp/skills/devrites-frontend-craft/reference/reuse-first.md +53 -0
- package/pack/generated/omp/skills/devrites-frontend-craft/reference/shape.md +56 -0
- package/pack/generated/omp/skills/devrites-interview/SKILL.md +102 -0
- package/pack/generated/omp/skills/devrites-lib/SKILL.md +58 -0
- package/pack/generated/omp/skills/devrites-lib/reference/candidate-integrity.md +43 -0
- package/pack/generated/omp/skills/devrites-lib/reference/intent-map.md +64 -0
- package/pack/generated/omp/skills/devrites-lib/reference/orchestration-profiles.md +27 -0
- package/pack/generated/omp/skills/devrites-lib/reference/parallel-dispatch.md +74 -0
- package/pack/generated/omp/skills/devrites-lib/reference/reply-contract.md +88 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/README.md +60 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/acceptance-preserving-reslice.md +30 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/afk-hitl.md +345 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/agents.md +98 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/anti-patterns.md +48 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/browser-proof-checklist.md +24 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/ci-cd.md +50 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/code-navigation.md +43 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/code-review.md +108 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/coding-style.md +48 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/context-hygiene.md +89 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/core.md +167 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/data-integrity.md +118 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/debug-recovery.md +28 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/definition-of-done.md +19 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/deprecation.md +31 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/developer-experience.md +119 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/development-workflow.md +29 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/documentation.md +43 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/edge-case-trace.md +92 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/elicitation.md +85 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/error-handling.md +47 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/git-workflow.md +49 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/hooks.md +25 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/integration-reliability.md +102 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/loop-operations.md +85 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/observability.md +88 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/one-shot-actions.md +97 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/patterns.md +68 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/performance.md +51 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/principles.md +42 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/prose-style.md +123 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/release/ship-checklist.md +8 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/repository-topology.md +80 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/review-checklist.md +12 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/security-checklist.md +25 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/security.md +202 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/skill-authoring.md +209 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/spec-grammar.md +197 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/test-proof-checklist.md +13 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/testing.md +212 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/tooling.md +92 -0
- package/pack/generated/omp/skills/devrites-lib/reference/standards/workflow-artifacts.md +427 -0
- package/pack/generated/omp/skills/devrites-lib/reference/visual-playbooks/code.md +44 -0
- package/pack/generated/omp/skills/devrites-lib/reference/visual-playbooks/comparison.md +42 -0
- package/pack/generated/omp/skills/devrites-lib/reference/visual-playbooks/diagram.md +51 -0
- package/pack/generated/omp/skills/devrites-lib/reference/visual-playbooks/index.md +66 -0
- package/pack/generated/omp/skills/devrites-lib/reference/visual-playbooks/input.md +46 -0
- package/pack/generated/omp/skills/devrites-lib/reference/visual-playbooks/outline-template.md +106 -0
- package/pack/generated/omp/skills/devrites-lib/reference/visual-playbooks/plan.md +48 -0
- package/pack/generated/omp/skills/devrites-lib/reference/visual-playbooks/slides.md +40 -0
- package/pack/generated/omp/skills/devrites-lib/reference/visual-playbooks/table.md +42 -0
- package/pack/generated/omp/skills/devrites-lib/reference/workspace-artifact-schema.md +228 -0
- package/pack/generated/omp/skills/devrites-prose-craft/SKILL.md +73 -0
- package/pack/generated/omp/skills/devrites-prose-craft/reference/banned-phrases.md +132 -0
- package/pack/generated/omp/skills/devrites-prose-craft/reference/examples.md +131 -0
- package/pack/generated/omp/skills/devrites-prose-craft/reference/structures.md +196 -0
- package/pack/generated/omp/skills/devrites-source-driven/SKILL.md +52 -0
- package/pack/generated/omp/skills/devrites-ux-shape/SKILL.md +134 -0
- package/pack/generated/omp/skills/devrites-ux-shape/reference/brief-template.md +108 -0
- package/pack/generated/omp/skills/devrites-ux-shape/reference/visual-direction-probe.md +48 -0
- package/pack/generated/omp/skills/rite/SKILL.md +148 -0
- package/pack/generated/omp/skills/rite/reference/menu.md +48 -0
- package/pack/generated/omp/skills/rite-adopt/SKILL.md +52 -0
- package/pack/generated/omp/skills/rite-adopt/reference/adoption.md +19 -0
- package/pack/generated/omp/skills/rite-adopt/reference/anti-patterns.md +19 -0
- package/pack/generated/omp/skills/rite-autocomplete/SKILL.md +122 -0
- package/pack/generated/omp/skills/rite-autocomplete/reference/decision-policy.md +41 -0
- package/pack/generated/omp/skills/rite-autocomplete/reference/loop.md +116 -0
- package/pack/generated/omp/skills/rite-autocomplete/reference/stop-conditions.md +92 -0
- package/pack/generated/omp/skills/rite-build/SKILL.md +79 -0
- package/pack/generated/omp/skills/rite-build/reference/afk-discipline.md +145 -0
- package/pack/generated/omp/skills/rite-build/reference/anti-patterns.md +23 -0
- package/pack/generated/omp/skills/rite-build/reference/checkpoint-protocol.md +120 -0
- package/pack/generated/omp/skills/rite-build/reference/checkpoint.md +46 -0
- package/pack/generated/omp/skills/rite-build/reference/frontend-trigger.md +39 -0
- package/pack/generated/omp/skills/rite-build/reference/one-slice-cycle.md +45 -0
- package/pack/generated/omp/skills/rite-build/reference/output.md +33 -0
- package/pack/generated/omp/skills/rite-build/reference/parallel-batch.md +81 -0
- package/pack/generated/omp/skills/rite-build/reference/phase-contract.md +66 -0
- package/pack/generated/omp/skills/rite-build/reference/spec-drift-guard.md +59 -0
- package/pack/generated/omp/skills/rite-build/reference/tdd.md +27 -0
- package/pack/generated/omp/skills/rite-build/reference/wright-dispatch.md +86 -0
- package/pack/generated/omp/skills/rite-clarify/SKILL.md +99 -0
- package/pack/generated/omp/skills/rite-clarify/reference/anti-patterns.md +24 -0
- package/pack/generated/omp/skills/rite-clarify/reference/decision-coverage.md +55 -0
- package/pack/generated/omp/skills/rite-converge/SKILL.md +140 -0
- package/pack/generated/omp/skills/rite-converge/reference/anti-patterns.md +35 -0
- package/pack/generated/omp/skills/rite-converge/reference/convergence-assessment.md +65 -0
- package/pack/generated/omp/skills/rite-customize/SKILL.md +60 -0
- package/pack/generated/omp/skills/rite-define/SKILL.md +166 -0
- package/pack/generated/omp/skills/rite-define/reference/anti-patterns.md +26 -0
- package/pack/generated/omp/skills/rite-define/reference/gates.md +154 -0
- package/pack/generated/omp/skills/rite-define/reference/plan-template.md +149 -0
- package/pack/generated/omp/skills/rite-doctor/SKILL.md +69 -0
- package/pack/generated/omp/skills/rite-dogfood/SKILL.md +55 -0
- package/pack/generated/omp/skills/rite-explain/SKILL.md +152 -0
- package/pack/generated/omp/skills/rite-explain/reference/intake.md +89 -0
- package/pack/generated/omp/skills/rite-frame/SKILL.md +115 -0
- package/pack/generated/omp/skills/rite-frame/reference/failure-modes.md +66 -0
- package/pack/generated/omp/skills/rite-handoff/SKILL.md +97 -0
- package/pack/generated/omp/skills/rite-handoff/reference/handoff-template.md +44 -0
- package/pack/generated/omp/skills/rite-learn/SKILL.md +72 -0
- package/pack/generated/omp/skills/rite-plan/SKILL.md +132 -0
- package/pack/generated/omp/skills/rite-plan/reference/anti-patterns.md +34 -0
- package/pack/generated/omp/skills/rite-plan/reference/dependency-graph.md +48 -0
- package/pack/generated/omp/skills/rite-plan/reference/replan-and-repair.md +73 -0
- package/pack/generated/omp/skills/rite-plan/reference/slicing.md +65 -0
- package/pack/generated/omp/skills/rite-plan/reference/task-breakdown.md +42 -0
- package/pack/generated/omp/skills/rite-polish/SKILL.md +104 -0
- package/pack/generated/omp/skills/rite-polish/reference/adr-promotion.md +11 -0
- package/pack/generated/omp/skills/rite-polish/reference/anti-ai-slop.md +187 -0
- package/pack/generated/omp/skills/rite-polish/reference/anti-patterns.md +30 -0
- package/pack/generated/omp/skills/rite-polish/reference/backend-polish.md +80 -0
- package/pack/generated/omp/skills/rite-polish/reference/browser-polish-evidence.md +33 -0
- package/pack/generated/omp/skills/rite-polish/reference/code.md +82 -0
- package/pack/generated/omp/skills/rite-polish/reference/design-memory.md +117 -0
- package/pack/generated/omp/skills/rite-polish/reference/design-system-discovery.md +8 -0
- package/pack/generated/omp/skills/rite-polish/reference/harden-checklist.md +109 -0
- package/pack/generated/omp/skills/rite-polish/reference/ledger.md +65 -0
- package/pack/generated/omp/skills/rite-polish/reference/ui.md +137 -0
- package/pack/generated/omp/skills/rite-pov/SKILL.md +58 -0
- package/pack/generated/omp/skills/rite-pr-feedback/SKILL.md +54 -0
- package/pack/generated/omp/skills/rite-pressure-test/SKILL.md +67 -0
- package/pack/generated/omp/skills/rite-prototype/SKILL.md +104 -0
- package/pack/generated/omp/skills/rite-prove/SKILL.md +122 -0
- package/pack/generated/omp/skills/rite-prove/reference/acceptance-proof.md +88 -0
- package/pack/generated/omp/skills/rite-prove/reference/anti-patterns.md +25 -0
- package/pack/generated/omp/skills/rite-prove/reference/browser-proof.md +51 -0
- package/pack/generated/omp/skills/rite-prove/reference/failure-triage.md +43 -0
- package/pack/generated/omp/skills/rite-prove/reference/proof-ladder.md +28 -0
- package/pack/generated/omp/skills/rite-prove/reference/test-command-discovery.md +30 -0
- package/pack/generated/omp/skills/rite-quick/SKILL.md +82 -0
- package/pack/generated/omp/skills/rite-resolve/SKILL.md +95 -0
- package/pack/generated/omp/skills/rite-resolve/reference/answer-protocol.md +118 -0
- package/pack/generated/omp/skills/rite-review/SKILL.md +159 -0
- package/pack/generated/omp/skills/rite-review/reference/anti-patterns.md +32 -0
- package/pack/generated/omp/skills/rite-review/reference/cognitive-load.md +90 -0
- package/pack/generated/omp/skills/rite-review/reference/feature-scoped-review.md +26 -0
- package/pack/generated/omp/skills/rite-review/reference/five-axis-review.md +66 -0
- package/pack/generated/omp/skills/rite-review/reference/nielsen-heuristics.md +126 -0
- package/pack/generated/omp/skills/rite-review/reference/performance-checklist.md +80 -0
- package/pack/generated/omp/skills/rite-review/reference/performance-review.md +14 -0
- package/pack/generated/omp/skills/rite-review/reference/security-review.md +42 -0
- package/pack/generated/omp/skills/rite-seal/SKILL.md +73 -0
- package/pack/generated/omp/skills/rite-seal/reference/anti-patterns.md +29 -0
- package/pack/generated/omp/skills/rite-seal/reference/final-evidence.md +40 -0
- package/pack/generated/omp/skills/rite-seal/reference/go-no-go.md +29 -0
- package/pack/generated/omp/skills/rite-seal/reference/output.md +5 -0
- package/pack/generated/omp/skills/rite-seal/reference/phase-contract.md +47 -0
- package/pack/generated/omp/skills/rite-seal/reference/risk-and-rollback.md +56 -0
- package/pack/generated/omp/skills/rite-seal/reference/seal-template.md +27 -0
- package/pack/generated/omp/skills/rite-ship/SKILL.md +85 -0
- package/pack/generated/omp/skills/rite-ship/reference/anti-patterns.md +28 -0
- package/pack/generated/omp/skills/rite-ship/reference/close-out.md +54 -0
- package/pack/generated/omp/skills/rite-ship/reference/git-ship.md +111 -0
- package/pack/generated/omp/skills/rite-ship/reference/rollout.md +62 -0
- package/pack/generated/omp/skills/rite-ship/reference/ship-template.md +39 -0
- package/pack/generated/omp/skills/rite-spec/SKILL.md +144 -0
- package/pack/generated/omp/skills/rite-spec/reference/acceptance-criteria.md +31 -0
- package/pack/generated/omp/skills/rite-spec/reference/ai-spec-template.md +40 -0
- package/pack/generated/omp/skills/rite-spec/reference/anti-patterns.md +27 -0
- package/pack/generated/omp/skills/rite-spec/reference/interview-patterns.md +56 -0
- package/pack/generated/omp/skills/rite-spec/reference/investigation.md +83 -0
- package/pack/generated/omp/skills/rite-spec/reference/question-protocol.md +36 -0
- package/pack/generated/omp/skills/rite-spec/reference/references-intake.md +62 -0
- package/pack/generated/omp/skills/rite-spec/reference/spec-checklists.md +89 -0
- package/pack/generated/omp/skills/rite-spec/reference/spec-template.md +154 -0
- package/pack/generated/omp/skills/rite-spec/reference/state-workspace.md +221 -0
- package/pack/generated/omp/skills/rite-status/SKILL.md +54 -0
- package/pack/generated/omp/skills/rite-temper/SKILL.md +127 -0
- package/pack/generated/omp/skills/rite-temper/reference/anti-patterns.md +29 -0
- package/pack/generated/omp/skills/rite-temper/reference/review-dimensions.md +67 -0
- package/pack/generated/omp/skills/rite-temper/reference/scope-modes.md +53 -0
- package/pack/generated/omp/skills/rite-temper/reference/significance.md +46 -0
- package/pack/generated/omp/skills/rite-temper/reference/strategy-template.md +90 -0
- package/pack/generated/omp/skills/rite-upgrade/SKILL.md +112 -0
- package/pack/generated/omp/skills/rite-vet/SKILL.md +158 -0
- package/pack/generated/omp/skills/rite-vet/reference/anti-patterns.md +41 -0
- package/pack/generated/omp/skills/rite-vet/reference/artifacts.md +202 -0
- package/pack/generated/omp/skills/rite-vet/reference/cross-model.md +19 -0
- package/pack/generated/omp/skills/rite-vet/reference/depth.md +60 -0
- package/pack/generated/omp/skills/rite-vet/reference/eng-lenses.md +48 -0
- package/pack/generated/omp/skills/rite-vet/reference/review-axes.md +176 -0
- package/pack/generated/omp/skills/rite-watch-pr/SKILL.md +85 -0
- package/pack/generated/omp/skills/rite-zoom-out/SKILL.md +69 -0
- package/package.json +12 -1
- package/scripts/build-host-artifacts.sh +48 -6
- package/scripts/omp-generate.sh +152 -0
package/pack/generated/claude/skills/devrites-lib/reference/standards/browser-proof-checklist.md
CHANGED
|
@@ -1,8 +1,24 @@
|
|
|
1
1
|
# Browser proof checklist
|
|
2
2
|
|
|
3
|
+
Compact sweep only. Numbers and failing cases live in
|
|
4
|
+
[`quality-standards.md`](../../../devrites-frontend-craft/reference/quality-standards.md)
|
|
5
|
+
§ Focus & states, § Responsive, and § Browser chrome — do not restate a shorter
|
|
6
|
+
viewport set here.
|
|
7
|
+
|
|
3
8
|
- Open the real UI (never screenshot-only); check console and network for errors.
|
|
4
|
-
-
|
|
5
|
-
|
|
6
|
-
|
|
9
|
+
- Before reading the builder's verdict, inventory the raw captures against the
|
|
10
|
+
required routes/states/viewports and candidate identity. Open each capture: a
|
|
11
|
+
wrong route, blank render, unexpected login wall, inconsistent dimensions, or
|
|
12
|
+
stale candidate is missing evidence. Recapture; until resolved, record
|
|
13
|
+
`cannot_verify` and block visual approval. A convincing narrative cannot repair it.
|
|
14
|
+
- Interactive slices capture each relevant canonical state and the canonical
|
|
15
|
+
viewport set. Omission needs a one-line `not-needed` reason; states must exist
|
|
16
|
+
in source — an unreachable state's capture proves nothing.
|
|
17
|
+
- Browser-default chrome is judged by § Browser chrome; reflow, zoom and bounded
|
|
18
|
+
two-dimensional exceptions by § Responsive. Compare to `design-brief.md` → Visual Verdict.
|
|
19
|
+
- Tooling unavailable ⇒ record fallback + limitation. Backend-only changes record
|
|
20
|
+
that disposition instead of capturing quietly; UI copy follows
|
|
21
|
+
`devrites-frontend-craft`, long-form prose follows `devrites-prose-craft`
|
|
22
|
+
([`prose-style.md`](prose-style.md)).
|
|
7
23
|
|
|
8
24
|
Detailed skill: `devrites-browser-proof`.
|
|
@@ -12,7 +12,7 @@ Read this only when creating or changing a build/deploy pipeline. [`hooks.md`](h
|
|
|
12
12
|
|
|
13
13
|
Read the specific failure, fix its root cause, verify locally, then push again. Do not blind-rerun a flaky pipeline. Use `devrites-debug-recovery` when a test or build failure needs reproduction.
|
|
14
14
|
|
|
15
|
-
A designated Build Cop owns restoring a broken trunk by fixing or reverting, whichever is faster. Restoring trunk outranks feature work.
|
|
15
|
+
A designated Build Cop (a human/team role, not a pack agent) owns restoring a broken trunk by fixing or reverting, whichever is faster. Restoring trunk outranks feature work.
|
|
16
16
|
|
|
17
17
|
## Deploy versus release
|
|
18
18
|
|
|
@@ -0,0 +1,43 @@
|
|
|
1
|
+
# Code navigation
|
|
2
|
+
|
|
3
|
+
Decision tree for structural questions. Load with [`tooling.md`](tooling.md);
|
|
4
|
+
this file is the pack-canonical routing table agents cite in Build, Vet, and
|
|
5
|
+
Review.
|
|
6
|
+
|
|
7
|
+
## Route by question
|
|
8
|
+
|
|
9
|
+
| Question | First tool | Fallback |
|
|
10
|
+
| --- | --- | --- |
|
|
11
|
+
| Explore unfamiliar area, architecture, blast radius | `codegraph_explore` or codebase-memory `search_graph` / `get_architecture` | code-review-graph `detect_changes_tool` / `get_impact_radius_tool` |
|
|
12
|
+
| Callers, callees, data flow across files | codebase-memory `trace_path` | code-review-graph `query_graph_tool` |
|
|
13
|
+
| PR/review context for a diff | code-review-graph `get_review_context_tool` | `detect_changes_tool` |
|
|
14
|
+
| Exact symbol body before edit | `read_symbol` / `module_report` (pi-lens) | `get_code_snippet` then targeted `Read` |
|
|
15
|
+
| Rename, references, diagnostics | LSP (`lsp` rename/references) when available | graph trace + grep |
|
|
16
|
+
| Known file, one-line fix | `Read` at offset/limit | — |
|
|
17
|
+
| Literal string / config value | `Grep` | — |
|
|
18
|
+
|
|
19
|
+
## Before cross-file edits
|
|
20
|
+
|
|
21
|
+
1. Run **one** primary route from the table (record tool + query in the artifact).
|
|
22
|
+
2. Read symbol bodies you will change (`read_symbol` counts as read).
|
|
23
|
+
3. After edits: LSP diagnostics + project tests.
|
|
24
|
+
|
|
25
|
+
Skipping step 1 on a multi-file slice is a Build orient gap unless recorded
|
|
26
|
+
`cannot_verify`.
|
|
27
|
+
|
|
28
|
+
## Index freshness
|
|
29
|
+
|
|
30
|
+
| Index path | Provider |
|
|
31
|
+
| --- | --- |
|
|
32
|
+
| `.codegraph/` | CodeGraph |
|
|
33
|
+
| `.code-review-graph/` | code-review-graph MCP |
|
|
34
|
+
| `.codebase-memory/` | codebase-memory MCP |
|
|
35
|
+
Run `devrites-engine check indexes` for a quick presence check. Stale or missing index:
|
|
36
|
+
build/refresh per provider docs, or fall back to LSP + grep and note the gap.
|
|
37
|
+
|
|
38
|
+
## Anti-patterns
|
|
39
|
+
|
|
40
|
+
- Duplicate graph queries for reassurance.
|
|
41
|
+
- Whole-file reads when `read_symbol` or `module_report` suffices.
|
|
42
|
+
- Grep-only blast-radius claims when an index is present.
|
|
43
|
+
- Editing without reading the enclosing symbol body.
|
|
@@ -17,13 +17,19 @@ If it does not, do not merge it.
|
|
|
17
17
|
|
|
18
18
|
## What to check (tests first)
|
|
19
19
|
1. **Tests:** do they exist and prove the behavior + failure modes (empty, error,
|
|
20
|
-
boundary, concurrency)? Would they fail if the code were wrong?
|
|
20
|
+
boundary, concurrency)? Would they fail if the code were wrong? A `skip`/`only`/
|
|
21
|
+
`TODO` placeholder or assertion-free test is a finding, not coverage.
|
|
21
22
|
2. **Correctness:** logic, edge cases, error paths, race conditions, wrong assumptions. For branching or boundary changes, run the [`edge-case trace`](edge-case-trace.md): relevant probe classes, fixed-set siblings, real wiring, negative intent, and deletion contracts with an evidence disposition.
|
|
22
23
|
3. **Readability:** names, function size, control flow, intent obvious without the author.
|
|
23
24
|
4. **Architecture:** right seam, coupling/cohesion, fits existing patterns, no premature
|
|
24
25
|
abstraction. Check how it fits the larger system as well as its local behavior.
|
|
25
26
|
5. **Security:** trust boundaries, input validation, authz, secrets.
|
|
26
27
|
6. **Risk:** migrations, destructive changes, rollback.
|
|
28
|
+
7. **Read depth matches risk:** the review's `Basis` names **full reads of the largest
|
|
29
|
+
diff files** (top three by changed lines), and any config/dependency/SQL/auth/migration
|
|
30
|
+
file is read in full — never skimmed. A review that cannot name what it fully read is
|
|
31
|
+
unproven. **Failing case:** a 600-line diff gets hunk-by-hunk commentary on the first
|
|
32
|
+
screen and silence on the migration file at the bottom.
|
|
27
33
|
|
|
28
34
|
## Give actionable feedback
|
|
29
35
|
- Read surrounding source before severity: call sites, existing guards, and the nearest consumer decide impact; a diff hunk alone is not enough.
|
|
@@ -44,6 +50,10 @@ If it does not, do not merge it.
|
|
|
44
50
|
never approval or silent demotion.
|
|
45
51
|
- **Skipped checks are recorded.** A check you couldn't run gets a
|
|
46
52
|
`Skipped: <check> — <why>` line.
|
|
53
|
+
- **Unreviewed is not clean.** A report that never names an area does not prove that area
|
|
54
|
+
was inspected; the consolidated account names what was not covered or marks `gap`.
|
|
55
|
+
**Failing case:** a findings list silent on, say, migration safety is not a clean
|
|
56
|
+
migration review — name the inspection or the gap.
|
|
47
57
|
- Let automation (linters, formatters, CI) catch the trivial stuff so review focuses on
|
|
48
58
|
design and correctness.
|
|
49
59
|
|
|
@@ -63,6 +73,15 @@ An author who is factually right wins over a reviewer's taste.
|
|
|
63
73
|
|
|
64
74
|
Root re-verifies each claimed consequence at the cited site, keeps the surviving evidence, sets final severity itself (reviewer severity advisory), records what decided ([agents.md § Independence](agents.md#independence)); unresolved conflicts stay open blockers.
|
|
65
75
|
|
|
76
|
+
## Heuristic checks: FLAG vs NOTE
|
|
77
|
+
|
|
78
|
+
A heuristic check that gates emits **FLAG** only when it can state the observed
|
|
79
|
+
consequence and where to re-verify it; when context cannot disambiguate, it emits a
|
|
80
|
+
**NOTE** that never gates. A check whose flag rate stays steady while every fix
|
|
81
|
+
reads as progress is checking the wrong layer — retune it or retire it.
|
|
82
|
+
**Failing case:** an ambiguous-identifier rule flags every pass, reviewers learn to
|
|
83
|
+
skim the list, and a real defect hides inside the noise it created.
|
|
84
|
+
|
|
66
85
|
## Scope discipline
|
|
67
86
|
Review the change, not the whole project. Out-of-scope problems become follow-ups, not
|
|
68
87
|
drive-by edits that balloon the diff.
|
|
@@ -79,7 +98,11 @@ at `/rite-review` / `/rite-seal`:
|
|
|
79
98
|
human-approved exception** is a **Critical** finding and a **NO-GO** at seal, the same standing
|
|
80
99
|
as an unproven acceptance criterion. Check the diff against each principle's scope; an absent
|
|
81
100
|
or empty file means none are declared (gate passes).
|
|
82
|
-
2. **The anti-slop charter** (`
|
|
101
|
+
2. **The anti-slop charter** ([`anti-ai-slop.md`](../../../rite-polish/reference/anti-ai-slop.md)
|
|
102
|
+
UI + code lists; [`prose-style.md`](prose-style.md) for prose). [`coding-style.md`](coding-style.md)
|
|
103
|
+
points at the code list — it is not a second catalog. **Failing case:** a backend-only
|
|
104
|
+
diff is charged UI anti-slop (Inter / lavender / gradient); those fire only when a
|
|
105
|
+
rendered UI surface is in the diff.
|
|
83
106
|
|
|
84
107
|
A principle violation is Critical. A charter violation is classified by its real
|
|
85
108
|
impact. Record each finding with `file:line`.
|
|
@@ -18,9 +18,10 @@ existing idiom first; these rules fill the gaps.
|
|
|
18
18
|
Handle unwanted cases first and return early; keep the success path flat.
|
|
19
19
|
|
|
20
20
|
## Comments explain *why*, not *what*
|
|
21
|
-
- Self-explanatory code beats a comment restating it
|
|
22
|
-
-
|
|
23
|
-
|
|
21
|
+
- Self-explanatory code beats a comment restating it; delete commented-out code. The
|
|
22
|
+
full comment do-not list (what-comments, tutorial noise, ownerless TODOs, edit-narration,
|
|
23
|
+
hedging) is owned by [`anti-ai-slop.md`](../../../rite-polish/reference/anti-ai-slop.md)
|
|
24
|
+
§ Code anti-slop — one canonical list, consumed by build, polish, and review.
|
|
24
25
|
|
|
25
26
|
## Simplicity
|
|
26
27
|
- Prefer the simplest thing that works. Don't add abstraction before you have two real
|
|
@@ -11,7 +11,15 @@ Long tool histories can displace important facts and retain failed attempts. Act
|
|
|
11
11
|
to 70% context use, keep one task's working set small, and load only what the current
|
|
12
12
|
step needs. The workspace, not a summary, is the source of truth.
|
|
13
13
|
|
|
14
|
-
|
|
14
|
+
- **Count before viewing:** on a search hit list, read match counts first (`grep -c`,
|
|
15
|
+
match summaries) and open only the files a one-line answer needs; dumping whole
|
|
16
|
+
files for a one-line question is common waste.
|
|
17
|
+
- **Cut before load, not after.** Drop low-signal files, prior-turn dumps, and
|
|
18
|
+
duplicate index queries before they enter context. Truncating a bloated window
|
|
19
|
+
after the fact is not an efficiency strategy — the cost is already paid.
|
|
20
|
+
**Failing case:** five whole-file reads, then `/compact`, treated as cost control.
|
|
21
|
+
|
|
22
|
+
**Compaction-preservation directive.** If the harness compacts mid-feature, read `.devrites/ACTIVE`, then reload the `state.md` cursor, open `questions.md` gates, durable `decisions.md`, and `test-plan.md`/`evidence.md` proof pointers. Session hooks normally restore these; this is the fallback when no hook fires.
|
|
15
23
|
|
|
16
24
|
## Authority and trust
|
|
17
25
|
|
|
@@ -9,7 +9,7 @@ Repository conventions follow [Precedence](#precedence).
|
|
|
9
9
|
1. **Right step, right time:** use the smallest workflow and load only relevant
|
|
10
10
|
files. Batch independent reads and cover the relevant code, not just the first
|
|
11
11
|
match. Prefer an available code index for structure; see
|
|
12
|
-
[`tooling.md`](tooling.md).
|
|
12
|
+
[`tooling.md`](tooling.md) and [`code-navigation.md`](code-navigation.md).
|
|
13
13
|
2. **No silent assumptions:** surface material assumptions; ask when the answer
|
|
14
14
|
changes scope, architecture, data model, UX, security, migration risk, or
|
|
15
15
|
acceptance.
|
|
@@ -17,7 +17,10 @@ Repository conventions follow [Precedence](#precedence).
|
|
|
17
17
|
conflict, stop, name the conflict, present options, wait for resolution
|
|
18
18
|
when the answer changes the product.
|
|
19
19
|
4. **Keep the spec current:** change spec / plan only through the Spec Drift Guard;
|
|
20
|
-
never code against a known-wrong plan.
|
|
20
|
+
never code against a known-wrong plan. A later phase MUST NOT rewrite a sealed
|
|
21
|
+
artifact in place so the code "matches." Append a dated delta through the
|
|
22
|
+
owning rite, or record drift. **Failing case:** Build edits `spec.md`
|
|
23
|
+
acceptance criteria to fit the implementation.
|
|
21
24
|
5. **One slice at a time:** leave one vertical slice working and proven, then
|
|
22
25
|
stop. HITL never auto-continues; AFK runs to its slice budget
|
|
23
26
|
([`afk-hitl.md`](afk-hitl.md)).
|
|
@@ -43,7 +46,27 @@ Before advancing a phase, run `devrites-engine check readiness <slug>` for struc
|
|
|
43
46
|
|
|
44
47
|
### Gate contract
|
|
45
48
|
|
|
46
|
-
Each gate is declared as **Name · Precondition · Satisfying observation (exact command/artifact state) ·
|
|
49
|
+
Each gate is declared as **Name · Precondition · Satisfying observation (exact command/artifact state) · Verdict · What failure blocks**, with one type: `preflight`, `revision`, `escalation` (human-only; distinct from the afk-hitl `escalating` severity), `abort`. Engine gates keep exit codes; semantic gates are judged by their owner against this contract. A gate whose failure consequence cannot be named is decoration — sharpen or delete it. A mechanical gate's satisfying observation is a command or artifact state a reviewer can re-run or re-read — narrative-only passes are unproven.
|
|
50
|
+
|
|
51
|
+
Verdict discipline — no vacuous verdicts:
|
|
52
|
+
|
|
53
|
+
- The precondition asserts the artifact **exists and is non-empty**, not merely that its
|
|
54
|
+
path resolves. **Failing case:** a phase passes its prerequisite gate, then dies
|
|
55
|
+
mid-analysis reading a missing spec.
|
|
56
|
+
- A verdict is **PASS**, **FAIL**, or **NOT-RUN**. A NOT-RUN carries its named marker
|
|
57
|
+
(`unavailable: <reason>`, `unproven`, `partial: <what ran>`) in the consuming artifact;
|
|
58
|
+
it never renders as clean and never goes silent. **Failing case:** a review sub-step
|
|
59
|
+
that never ran is simply omitted from the summary, which reads as a clean run.
|
|
60
|
+
- A PASS is valid only when the observation states a **positive count of items actually
|
|
61
|
+
checked**; zero checked items is FAIL. **Failing case:** an unparseable checklist yields
|
|
62
|
+
an empty result set and a green verdict over zero evidence.
|
|
63
|
+
- Scope-bearing gates name their **baseline** and fail only on issues attributable to the
|
|
64
|
+
change; "could not run" (timeout, unreachable, parse failure) is never recorded as
|
|
65
|
+
"failed". **Failing case:** a dependency gate reddens on a pre-existing advisory
|
|
66
|
+
unrelated to the diff.
|
|
67
|
+
- Failure behavior is **abort** (stop; the blocked step is named) or **record-and-continue**
|
|
68
|
+
(the FAIL/NOT-RUN is recorded with its marker and the run proceeds). Both are legal;
|
|
69
|
+
silent is not.
|
|
47
70
|
|
|
48
71
|
## Caller-owned technical backtracking
|
|
49
72
|
|
|
@@ -103,12 +126,13 @@ These universal musts link to their full rules; load depth only when needed.
|
|
|
103
126
|
## Persistence before stopping (handoff discipline)
|
|
104
127
|
|
|
105
128
|
Before any `rite-*` skill stops:
|
|
129
|
+
|
|
106
130
|
- Open question? → `questions.md` (with `status`, `gate`, `slice`, `proposed`,
|
|
107
131
|
`raised_at`). Decision discussed? → `decisions.md`.
|
|
108
132
|
- Assumption made? → `assumptions.md`. Drift raised? → `drift.md`.
|
|
109
133
|
- Approach tried that **failed**? → a `## Dead ends` section in `decisions.md` (what you
|
|
110
|
-
tried, why it failed, what it rules out). Compaction and the next agent must not repeat
|
|
111
|
-
|
|
134
|
+
tried, why it failed, what it rules out). Compaction and the next agent must not repeat an
|
|
135
|
+
invalidated approach.
|
|
112
136
|
- Next-action ambiguous? → resolve to one command in `state.md`.
|
|
113
137
|
- HITL pause? → write the `Awaiting human` block to `state.md` and set
|
|
114
138
|
`Status: awaiting_human` before stopping; resume via `/rite-resolve <qid> "<answer>"`.
|
|
@@ -118,12 +142,12 @@ A skill that stops without doing this leaves the workspace incomplete.
|
|
|
118
142
|
|
|
119
143
|
## Context hygiene (end of every phase)
|
|
120
144
|
|
|
121
|
-
Long contexts degrade reasoning quality
|
|
122
|
-
"context rot" on long inputs). Act on context at **50-70% used, not 95%**.
|
|
145
|
+
Long contexts degrade reasoning quality. Act on context at **50-70% used, not 95%**.
|
|
123
146
|
|
|
124
|
-
|
|
125
|
-
|
|
126
|
-
phase-by-phase guidance:
|
|
147
|
+
Compact utilities end with a one-line `↻ Hygiene:` advisory naming the right move
|
|
148
|
+
(`/clear` vs `/compact`) and the single resume command; other rites name the single
|
|
149
|
+
resume command in their stop output. Full phase-by-phase guidance:
|
|
150
|
+
[`context-hygiene.md`](context-hygiene.md).
|
|
127
151
|
|
|
128
152
|
## Precedence
|
|
129
153
|
|
|
@@ -1,7 +1,8 @@
|
|
|
1
1
|
# Data integrity
|
|
2
2
|
|
|
3
3
|
Load this when a change writes durable state, changes a schema, migrates or backfills
|
|
4
|
-
records, changes retention,
|
|
4
|
+
records, changes retention, can expose one tenant's data to another, or feeds a
|
|
5
|
+
model/feature pipeline (training data, features, labels, embeddings). Data work is
|
|
5
6
|
complete only when normal operation, interruption, retry, and rollback preserve the
|
|
6
7
|
declared invariants.
|
|
7
8
|
|
|
@@ -17,9 +18,29 @@ Name before planning implementation:
|
|
|
17
18
|
derived stores;
|
|
18
19
|
- old and new readers/writers that coexist during rollout.
|
|
19
20
|
|
|
21
|
+
Timestamps normalize before they persist: one storage scale (UTC instants), explicit
|
|
22
|
+
conversion only at input/display boundaries; two writers storing different scales for
|
|
23
|
+
the same fact is an invariant violation caught in review. TZ/DST behavioral coverage
|
|
24
|
+
lives in [`testing.md`](testing.md).
|
|
25
|
+
|
|
20
26
|
An invariant enforced only by prose is not a control. Prefer a database constraint or
|
|
21
27
|
atomic storage primitive, then add behavioral proof at the public surface.
|
|
22
28
|
|
|
29
|
+
## Model and feature pipelines
|
|
30
|
+
|
|
31
|
+
Durable-state rules apply to ML-adjacent writes with their own failure modes:
|
|
32
|
+
|
|
33
|
+
- **Data contract:** producers and consumers bind to a versioned schema plus quality rules
|
|
34
|
+
owned beside the pipeline. Two stages reading one field under different implicit schemas
|
|
35
|
+
is an invariant violation caught like any schema drift.
|
|
36
|
+
- **Point-in-time correctness:** a feature may use only data available at prediction time.
|
|
37
|
+
Label leakage through later-arriving data invalidates the artifact silently. **Failing
|
|
38
|
+
case:** a feature computed from post-prediction-time data passes review; a backfilled
|
|
39
|
+
label join reads as valid history.
|
|
40
|
+
- **Training/serving skew:** the same feature computed two ways is a behavioral difference
|
|
41
|
+
to test, not a deployment note; drift monitoring rides the observability owner
|
|
42
|
+
([`observability.md`](observability.md)).
|
|
43
|
+
|
|
23
44
|
## Migration and backfill path
|
|
24
45
|
|
|
25
46
|
Use **expand → migrate → contract** for compatibility across deployment units:
|
|
@@ -91,5 +112,7 @@ data scale, before/after counts, rejected rows, invariant results, and observed
|
|
|
91
112
|
forward-only recovery accepted by the human owner.
|
|
92
113
|
- No migration GO with unknown old readers/writers, unresolved invariant violations,
|
|
93
114
|
unbounded backfill, missing interruption state, or no production-scale risk estimate.
|
|
115
|
+
**Failing case:** GO with "revert if needed" and no rehearsal command or before/after
|
|
116
|
+
counts → NO-GO.
|
|
94
117
|
- No data-loss or cross-tenant risk may be dismissed as "pre-existing" without baseline
|
|
95
118
|
evidence from before the candidate.
|
|
@@ -7,7 +7,7 @@ Triggered standard for polling async readiness without blind sleep. Skill owner:
|
|
|
7
7
|
|
|
8
8
|
When waiting for async readiness (server start, job completion, browser signal):
|
|
9
9
|
|
|
10
|
-
1. Set `max_wait_ms` (default 30_000 unless artifact specifies otherwise).
|
|
10
|
+
1. Set `max_wait_ms` (default 30_000 unless the calling task or test-plan artifact specifies otherwise).
|
|
11
11
|
2. Poll with **condition check** — never fixed sleep as the primary strategy.
|
|
12
12
|
3. Capture **last signal** (last log line, HTTP status, DOM state) on timeout.
|
|
13
13
|
4. Record artifact: `{ condition, max_wait_ms, last_signal, outcome }`.
|
|
@@ -15,6 +15,13 @@ When waiting for async readiness (server start, job completion, browser signal):
|
|
|
15
15
|
**Failing case:** `sleep(5)` loop with no captured last signal → recovery incomplete;
|
|
16
16
|
treat as flaky/unproven.
|
|
17
17
|
|
|
18
|
+
## Diagnosis write freeze
|
|
19
|
+
|
|
20
|
+
During diagnosis, writable paths are the reproduction harness plus the files
|
|
21
|
+
named by the current ranked hypothesis. Other product paths are frozen until
|
|
22
|
+
the hypothesis is confirmed. **Failing case:** while debugging one test, the
|
|
23
|
+
agent "fixes" lint in an unrelated package.
|
|
24
|
+
|
|
18
25
|
## Relationship to debug-recovery skill
|
|
19
26
|
|
|
20
27
|
The seven-step recovery cycle owns reproduction and fix. This standard owns the
|
|
@@ -1,16 +1,19 @@
|
|
|
1
1
|
# Definition of Done
|
|
2
2
|
|
|
3
|
-
|
|
3
|
+
Acceptance criteria prove the requested behavior; this bar proves the change is
|
|
4
|
+
shippable. Phase owners keep the checks — this file is the index, not a second list.
|
|
4
5
|
|
|
5
|
-
A feature is done
|
|
6
|
+
A feature is not done when any required row is missing. Open the owner; do not
|
|
7
|
+
re-judge from this table alone.
|
|
6
8
|
|
|
7
|
-
|
|
8
|
-
|
|
9
|
-
|
|
10
|
-
|
|
11
|
-
|
|
12
|
-
|
|
13
|
-
|
|
14
|
-
|
|
9
|
+
| Required | Owner | Failing case |
|
|
10
|
+
| --- | --- | --- |
|
|
11
|
+
| Each AC names a stored evidence path (command or artifact) | [`testing.md`](testing.md), `rite-prove` | An AC is checked off with no path in `evidence.md` |
|
|
12
|
+
| Discriminating tests for changed behavior | [`testing.md`](testing.md) | Suite green; revert of the change would still be green |
|
|
13
|
+
| Fresh runtime/build/test/browser records | `rite-prove`, [`browser-proof-checklist.md`](browser-proof-checklist.md) | Proof claimed from stale or unrun commands |
|
|
14
|
+
| Scope-clean diff | [`code-review.md`](code-review.md) | Unscoped edits or a hidden second system remain |
|
|
15
|
+
| Open hard gates closed | [`afk-hitl.md`](afk-hitl.md), `rite-seal` | HITL, red tests, drift, or NO-GO still open |
|
|
16
|
+
| Rollback named for risky work | [`data-integrity.md`](data-integrity.md) | "revert if needed" with no trigger/procedure/proof |
|
|
17
|
+
| Docs/ADR for public behavior | [`documentation.md`](documentation.md) | Command or contract changed; docs did not |
|
|
15
18
|
|
|
16
|
-
Use
|
|
19
|
+
Use from `rite-vet`, `rite-build`, `rite-prove`, `rite-seal`, and `rite-quick`.
|
|
@@ -27,7 +27,10 @@ Promotion is maintenance of an existing authority, not a new memory system.
|
|
|
27
27
|
2. **Ground:** verify each current claim against live authoritative repository sources.
|
|
28
28
|
Report the source and currentness signal. Unverifiable means `unknown`, not false.
|
|
29
29
|
3. **Scope:** state when the guidance applies and does not apply. Reject a candidate whose
|
|
30
|
-
observable trigger cannot be named.
|
|
30
|
+
observable trigger cannot be named. If final code/tests/docs already recover the
|
|
31
|
+
reasoning, reject or consolidate the lesson; promote only the missing durable constraint.
|
|
32
|
+
**Failing case:** a regression test already explains input rejection, yet a second
|
|
33
|
+
generic "validate input" rule is added with no lost reasoning identified.
|
|
31
34
|
4. **Own and expose:** choose one existing canonical owner (`AGENTS.md`/`CLAUDE.md`, a scoped
|
|
32
35
|
standard, or an ADR) and name the phases, agents, or contributors that discover it and
|
|
33
36
|
how (direct read, index link, or existing on-demand route).
|
|
@@ -56,7 +56,9 @@ Every applicable case receives one status:
|
|
|
56
56
|
|
|
57
57
|
- `covered`: mapped to a REQ/AC and positive discriminating test or observed runtime proof;
|
|
58
58
|
- `backstop`: an independent held-out, property/metamorphic, or direct behavioral check
|
|
59
|
-
names the wrong outcome it would detect
|
|
59
|
+
names the wrong outcome it would detect — and is **exogenous**: not produced or
|
|
60
|
+
executed by the same code path it validates (a check the changed code also controls is
|
|
61
|
+
`covered` evidence, not a backstop);
|
|
60
62
|
- `dismissed`: unreachable or irrelevant with a concrete reason and supporting evidence;
|
|
61
63
|
- `unresolved`: a material case lacks a fact or proof surface and blocks the owning gate.
|
|
62
64
|
|
|
@@ -82,8 +84,8 @@ Spec records relevant cases in **Edge Coverage** and bespoke negative intent in
|
|
|
82
84
|
reports only reachable gaps:
|
|
83
85
|
|
|
84
86
|
```md
|
|
85
|
-
|
|
86
|
-
<
|
|
87
|
+
Finding: <severity> | path:line | <trigger> reaches <unhandled outcome> | <observable harm> |
|
|
88
|
+
<minimal handling>; missing proof: <test/signal>.
|
|
87
89
|
```
|
|
88
90
|
|
|
89
91
|
Use the caller's severity scale. Do not create a separate edge score, pad rows with
|
|
@@ -10,6 +10,11 @@ this is the menu you reach into: named reasoning techniques, each with the shape
|
|
|
10
10
|
2. Read its **risk**, then pull the 3-5 techniques below whose *When to reach for it* matches.
|
|
11
11
|
3. Present them as a short numbered menu; the human picks one (or `skip`).
|
|
12
12
|
4. Run that technique on that section, apply the result, move on.
|
|
13
|
+
5. **No-yield exit:** when the technique surfaces nothing that changes the section — no
|
|
14
|
+
new requirement, mitigation, estimate change, or blocking question — record
|
|
15
|
+
`elicitation: <technique> — no yield` in the phase artifact and stop offering menus
|
|
16
|
+
for that section. **Failing case:** repeated technique menus on a settled section are
|
|
17
|
+
ceremony, not diligence; a second menu without new section input is a process defect.
|
|
13
18
|
|
|
14
19
|
Selection is by the section's risk, not taste. Reach for the row that fits:
|
|
15
20
|
|
|
@@ -77,4 +82,4 @@ Run the technique on the **section in front of you**, not the whole document: a
|
|
|
77
82
|
everything is a move applied to nothing. Record what it changed in the phase artifact (a new
|
|
78
83
|
requirement, a mitigation, a blocking question), not just that you ran it.
|
|
79
84
|
|
|
80
|
-
A project can append its own house techniques to this file: same
|
|
85
|
+
A project can append its own house techniques to this file: same entry shape — **name (when to reach for it)** → the shape it produces.
|
|
@@ -22,7 +22,7 @@ Never retry blind — match the outcome first:
|
|
|
22
22
|
|
|
23
23
|
- **Rejected** (refused: validation/authz/conflict): fix input; unchanged retry fails again.
|
|
24
24
|
- **Unknown** (timed out mid-call): check state at the source before any retry.
|
|
25
|
-
- **Partial** (half-committed): [`data-integrity.md`](data-integrity.md)
|
|
25
|
+
- **Partial** (half-committed): [`data-integrity.md`](data-integrity.md) (see `Writes, retries, and concurrency`) — reconcile or roll back, never resume blind.
|
|
26
26
|
- **Clean failure** (not started / fully rolled back): safe to retry after fixing the cause.
|
|
27
27
|
|
|
28
28
|
**Failing case:** an **Unknown** outcome retried unchanged double-applies (duplicate charge). Idempotency: [`data-integrity.md`](data-integrity.md); outcome taxonomies: [`integration-reliability.md`](integration-reliability.md). Not provable → `cannot_verify` and stop.
|
|
@@ -32,6 +32,9 @@ Never retry blind — match the outcome first:
|
|
|
32
32
|
and ideally how to recover. Cryptic messages cost hours.
|
|
33
33
|
- Distinguish *expected* failures (validation, not-found) from *unexpected* (bugs);
|
|
34
34
|
handle the first as flow, surface the second.
|
|
35
|
+
- Structured error surfaces carry one consistent envelope — **severity, stable code,
|
|
36
|
+
human message, fix** — so callers and logs can act programmatically; a bare string that
|
|
37
|
+
forces callers to parse prose is a contract gap.
|
|
35
38
|
|
|
36
39
|
## Fail closed (security-relevant paths)
|
|
37
40
|
- On error in an auth/permission/transaction path, **deny and roll back**: never
|
|
@@ -39,6 +42,6 @@ Never retry blind — match the outcome first:
|
|
|
39
42
|
|
|
40
43
|
## Logging
|
|
41
44
|
- Log key events (failures, access violations, validation errors) with enough context to
|
|
42
|
-
debug. Prefer structured logs (key/value or JSON)
|
|
45
|
+
debug. Prefer structured logs (key/value or JSON).
|
|
43
46
|
- **Never log secrets, credentials, tokens, or personal data.** Show users a clear,
|
|
44
47
|
non-revealing message; keep the detail in the logs for the team.
|
package/pack/generated/claude/skills/devrites-lib/reference/standards/integration-reliability.md
CHANGED
|
@@ -11,6 +11,15 @@ schema, optional and unknown fields, ordering guarantee, rate limit, timeout bud
|
|
|
11
11
|
retry responsibility, idempotency key, and user-visible degradation. Validate an
|
|
12
12
|
external response as hostile input before trusted code consumes it.
|
|
13
13
|
|
|
14
|
+
**Uploads and paginated collections are boundary contracts, not transport details.** An
|
|
15
|
+
upload names body and expanded-size caps, chunk/resume behavior, partial-upload
|
|
16
|
+
reconciliation, and the rejection path for oversized or malformed payloads. A paginated
|
|
17
|
+
collection names cursor/offset semantics, page-size cap, the terminal “no more pages”
|
|
18
|
+
signal, and how rows written during paging surface — skipped or duplicated rows are
|
|
19
|
+
contract data, not surprises. **Failing case:** a client pages by offset while rows
|
|
20
|
+
insert ahead of it and silently misses records; a boundary contract that cannot name
|
|
21
|
+
this behavior fails Vet.
|
|
22
|
+
|
|
14
23
|
For every call or delivery, classify the observed outcome:
|
|
15
24
|
|
|
16
25
|
| Outcome | Required behavior |
|
|
@@ -27,17 +36,30 @@ For every call or delivery, classify the observed outcome:
|
|
|
27
36
|
- Retry only a named transient failure and only when the operation is idempotent or has
|
|
28
37
|
a durable deduplication key. Bound attempts, elapsed time, and exponential backoff;
|
|
29
38
|
add jitter when many workers could synchronize.
|
|
39
|
+
- Assign one retry owner across SDK, worker and queue, or explicitly share one
|
|
40
|
+
end-to-end attempt/deadline budget that redelivery cannot reset. Prove exhaustion
|
|
41
|
+
by counting physical downstream calls, including inner retries, and advancing a
|
|
42
|
+
controlled/injected clock to the deadline. Assert exhaustion, not wall-clock
|
|
43
|
+
duration ([testing.md](testing.md#determinism-no-flaky-tests)); elapsed-time logs
|
|
44
|
+
are observations, never timing assertions in tests.
|
|
45
|
+
**Failing case:** each of three layers permits four attempts, producing 64 calls;
|
|
46
|
+
three passing local retry tests do not prove the operation's budget. Budget
|
|
47
|
+
overrun blocks proof and Seal until retry ownership or shared accounting is fixed.
|
|
30
48
|
- A timeout is not proof the provider did nothing. Query by idempotency key/status or
|
|
31
49
|
reconcile before creating a second effect.
|
|
32
50
|
- Webhook/queue consumers acknowledge only after durable success or durable handoff.
|
|
33
51
|
Duplicate delivery, duplicate jobs, and out-of-order delivery are normal inputs:
|
|
34
52
|
deduplicate durably and reject, buffer, or reconcile stale sequence/version values by contract.
|
|
53
|
+
**Failing case:** the handler acks before the durable write; a duplicate delivery
|
|
54
|
+
creates a second effect.
|
|
35
55
|
- A poison message must not block the partition forever. Bound redelivery, retain the
|
|
36
56
|
failure reason without secrets, move to the project's quarantine/dead-letter path,
|
|
37
57
|
and define replay after correction.
|
|
38
|
-
- A queue
|
|
39
|
-
|
|
40
|
-
|
|
58
|
+
- A queue emits observability signals — backlog depth, poison/quarantine count,
|
|
59
|
+
reconciliation lag, saturation, ownership — with [`observability.md`](observability.md)
|
|
60
|
+
as the signal-taxonomy owner. A queue backlog still needs an accepted
|
|
61
|
+
capacity/drain/recovery action; auto-scaling without downstream capacity protection
|
|
62
|
+
only moves the outage.
|
|
41
63
|
|
|
42
64
|
## Partial failure and recovery
|
|
43
65
|
|
|
@@ -45,9 +67,9 @@ Map each multi-step effect as `not started | committed | unknown | compensating
|
|
|
45
67
|
reconciled`. If one system commits and another fails, name the durable record that
|
|
46
68
|
drives retry or compensation. Do not catch/log/continue into a false success.
|
|
47
69
|
|
|
48
|
-
For synchronous versus asynchronous design,
|
|
49
|
-
|
|
50
|
-
|
|
70
|
+
For synchronous versus asynchronous design, apply [`patterns.md`](patterns.md); async
|
|
71
|
+
processing changes the contract to accepted/pending/failed/retryable; it does not make the
|
|
72
|
+
failure disappear.
|
|
51
73
|
|
|
52
74
|
## Cache and partition behavior
|
|
53
75
|
|
|
@@ -67,9 +89,10 @@ For each boundary, `plan.md` records:
|
|
|
67
89
|
| `<provider → consumer>` | `<budgets/key>` | `<rules>` | `<user/system path>` | `<signals/owner>` | `<test/rehearsal>` |
|
|
68
90
|
|
|
69
91
|
Proof drives success, invalid shape, partial response, auth failure, rate limit, timeout,
|
|
70
|
-
duplicate, out-of-order delivery, and outage when relevant.
|
|
71
|
-
or sandbox
|
|
72
|
-
|
|
92
|
+
duplicate, out-of-order delivery, and outage when relevant. Deterministic cases use a
|
|
93
|
+
contract-capable fake or sandbox per [`testing.md`](testing.md) — never a mock that
|
|
94
|
+
simply returns the expected payload (that tests the stub, not the boundary) — plus at
|
|
95
|
+
least one real boundary check when authorized and safe.
|
|
73
96
|
|
|
74
97
|
## Stop conditions
|
|
75
98
|
|
|
@@ -74,8 +74,8 @@ armed AFK workspace whose exact scope, gates, and budgets permit it.
|
|
|
74
74
|
narration are not.
|
|
75
75
|
- Host timeout, unavailable agent, malformed result, missed event, or stale snapshot
|
|
76
76
|
is `gap`/`cannot_verify`, never success.
|
|
77
|
-
- Do not retry unchanged work merely because a timer fired. Apply the
|
|
78
|
-
causal-fingerprint recovery cap.
|
|
77
|
+
- Do not retry unchanged work merely because a timer fired. Apply the exact
|
|
78
|
+
causal-fingerprint recovery cap ([`afk-hitl.md`](afk-hitl.md)).
|
|
79
79
|
- A cold resume continues durable slice/recovery state and absolute expiry. Fresh
|
|
80
80
|
native activation counters follow `afk-hitl.md`; no durable bound is reinitialized.
|
|
81
81
|
- Native notifications fire only after evidence and stop state are written.
|
|
@@ -26,6 +26,11 @@ answers one of them. A signal that maps to no question is noise you pay to store
|
|
|
26
26
|
external-call outcomes, validation rejections, and authz denials.
|
|
27
27
|
- Structured (key/value or JSON), not string soup: a log you can't query is a log you won't
|
|
28
28
|
read. Carry a correlation id (request / trace / job id) so one incident's lines join up.
|
|
29
|
+
- When several entry points share a path, carry a bounded **origin** (scheduler,
|
|
30
|
+
CLI, replay, request) set at entry and propagated across async boundaries.
|
|
31
|
+
Correlation joins one execution; origin identifies what started it. Trigger failures
|
|
32
|
+
through two distinct entries and prove each is attributed correctly. **Failing case:**
|
|
33
|
+
a CLI replay has a trace ID but is reported as a scheduled run.
|
|
29
34
|
- **Never log secrets, tokens, or PII** ([`security.md`](security.md),
|
|
30
35
|
[`error-handling.md`](error-handling.md)). Levels mean something: `error` is a page-worthy
|
|
31
36
|
claim, not routine flow.
|
|
@@ -64,7 +69,7 @@ hours). A third tier is the noise everyone learns to mute: collapse it into one
|
|
|
64
69
|
|
|
65
70
|
## Verify the telemetry fires (evidence, not assumption)
|
|
66
71
|
Instrumentation you added but never watched emit is unproven: the same standing as a test you
|
|
67
|
-
never saw fail ([`testing.md`](testing.md) "
|
|
72
|
+
never saw fail ([`testing.md`](testing.md) "Prove it can fail"). Trigger the path, confirm the
|
|
68
73
|
log line / metric / span appears, and record the observation in `evidence.md`. "I
|
|
69
74
|
added logging" with no observed emission is not done.
|
|
70
75
|
|
|
@@ -66,8 +66,8 @@ Keep two budgets separate:
|
|
|
66
66
|
Cold resume does not make that fingerprint old or exhausted. Derive its offline
|
|
67
67
|
no-progress count from `drift.md` and `evidence.md`; while the count is below the
|
|
68
68
|
cap, resume recovery even if a prior writer stored `blocked` / `Next step: none`.
|
|
69
|
-
That terminal cursor is valid only for
|
|
70
|
-
|
|
69
|
+
That terminal cursor is valid only for a human/safety gate, an actually exhausted
|
|
70
|
+
fingerprint, or a proven absence of any safe retention/amplification design.
|
|
71
71
|
|
|
72
72
|
A new real attempt is normally admissible only after the affected plan and fixtures
|
|
73
73
|
are re-vetted, the failure condition is shown changed, and any required fresh
|
|
@@ -46,6 +46,22 @@ Use a pattern only when it makes the design easier to understand and reduces cou
|
|
|
46
46
|
abstraction over two things that aren't really the same).
|
|
47
47
|
- Speculative generality: config, hooks, and extension points with no current user.
|
|
48
48
|
|
|
49
|
+
## Symptom → suspect pattern
|
|
50
|
+
|
|
51
|
+
Route an observed code symptom to the review it should trigger; the symptom is the
|
|
52
|
+
evidence, not the diagnosis:
|
|
53
|
+
|
|
54
|
+
| Observable symptom | Suspect | First check |
|
|
55
|
+
| --- | --- | --- |
|
|
56
|
+
| Every change funnels through one file/module | God object / missing seam | ownership map (§ Boundaries and state ownership) |
|
|
57
|
+
| Tests stub half the module to exercise one function | I/O and logic entangled | separate I/O, domain logic, presentation |
|
|
58
|
+
| Adding one field requires editing many unrelated files | Shotgun coupling | coupling direction; [`repository-topology.md`](repository-topology.md) |
|
|
59
|
+
| Two components write the same mutable state | Authority conflict | one authoritative owner per fact |
|
|
60
|
+
| Config/flag exists with no current consumer | Speculative generality | delete or name the current user (anti-patterns above) |
|
|
61
|
+
|
|
62
|
+
**Failing case:** a review that names a pattern without pointing at the observed symptom
|
|
63
|
+
that motivated it is architecture preference, not finding.
|
|
64
|
+
|
|
49
65
|
## In a codebase
|
|
50
66
|
Match the patterns the project already uses before introducing a new one. A consistent
|
|
51
67
|
"good enough" pattern beats a locally-superior but foreign one. Document the *why* of any
|