devrites 3.2.3 → 3.2.5

package/CHANGELOG.md

@@ -2,6 +2,18 @@
 
 All notable changes to DevRites are documented here. The format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/) and DevRites adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). Releases are generated automatically by [semantic-release](https://semantic-release.gitbook.io/) from Conventional Commits on `main`.
 
+## [3.2.5](https://github.com/ViktorsBaikers/DevRites/compare/v3.2.4...v3.2.5) (2026-07-25)
+
+### Fixed
+
+* **agents:** retain v2 wright dispatch receipt ([84f0c05](https://github.com/ViktorsBaikers/DevRites/commit/84f0c05c9d91d85194dfd4c97593ca1c07183282))
+
+## [3.2.4](https://github.com/ViktorsBaikers/DevRites/compare/v3.2.3...v3.2.4) (2026-07-25)
+
+### Fixed
+
+* **agents:** handle hidden v2 agent_type schema ([31ece9a](https://github.com/ViktorsBaikers/DevRites/commit/31ece9aad686fa3a3fa0308d5a3ede11f5b58c07))
+
 ## [3.2.3](https://github.com/ViktorsBaikers/DevRites/compare/v3.2.2...v3.2.3) (2026-07-25)
 
 ### Fixed

package/README.md

@@ -25,7 +25,7 @@ final commit, push, and tag, and it requires a typed `GO` confirmation.
 Unattended runs may create local WIP checkpoint commits along the way, but only
 Ship collapses and pushes them.
 
-**Status:** [`v3.2.3`](https://github.com/ViktorsBaikers/DevRites/releases/tag/v3.2.3): see [`CHANGELOG.md`](CHANGELOG.md) for release notes.
+**Status:** [`v3.2.5`](https://github.com/ViktorsBaikers/DevRites/releases/tag/v3.2.5): see [`CHANGELOG.md`](CHANGELOG.md) for release notes.
 
 ## Quick start
 

package/engine/hooks_agent_dispatch.go

@@ -457,6 +457,17 @@ func dispatchTurnState(events []agentDispatchEvent, turnID string) (map[string]s
 				attempt.Stopped = true
 				attempt.ResultSHA256 = event.ResultSHA256
 			}
+		case "verified":
+			attempts = append(attempts, &agentDispatchAttempt{
+				Role:         event.Role,
+				AgentType:    event.AgentType,
+				AgentID:      event.AgentID,
+				WindowID:     event.WindowID,
+				Started:      true,
+				Stopped:      true,
+				Waited:       true,
+				ResultSHA256: event.ResultSHA256,
+			})
 		}
 	}
 	return armed, attempts
@@ -771,7 +782,7 @@ func reconcileWindowPredates(at time.Time) bool {
 }
 
 func dispatchAttemptComplete(attempt *agentDispatchAttempt) bool {
-	return attempt.Started && attempt.Stopped && attempt.ResultSHA256 != ""
+	return attempt.Started && attempt.Stopped && attempt.Waited && attempt.ResultSHA256 != ""
 }
 
 func roleSatisfied(role, windowID string, attempts []*agentDispatchAttempt) bool {
@@ -802,7 +813,7 @@ func incompleteDispatchReason(armed map[string]struct{}, attempts []*agentDispat
 		return "DevRites could not determine this skill's required agents because its installed required-agent-roles contract is invalid. Reinstall or repair the DevRites skill pack before continuing."
 	}
 	return fmt.Sprintf(
-		"DevRites dispatch for %s is not complete. On MultiAgent V2 call spawn_agent with agent_type=%s, a unique task_name, and fork_turns=\"none\" so Codex loads .codex/agents/%s.toml natively. On V1 use agent_type=%s with fork_turns=\"none\" and name that role TOML in the message. Wait for the returned child and use its non-empty result. Do not call wait before spawn_agent and do not synthesize the agent result.",
+		"DevRites dispatch for %s is not complete. On MultiAgent V2 call spawn_agent with agent_type=%s, a unique task_name, and fork_turns=\"none\" so Codex loads .codex/agents/%s.toml natively. GPT-5.6 V2 may omit agent_type from the visible tool schema even though the runtime accepts it; send agent_type anyway rather than using a default child. On V1 use agent_type=%s with fork_turns=\"none\" and name that role TOML in the message. Wait for the returned child and use its non-empty result. Do not call wait before spawn_agent and do not synthesize the agent result.",
 		role, role, role, expectedAgentType(role),
 	)
 }
@@ -1092,15 +1103,34 @@ func hookAgentDispatchPreTool(h harness.Harness, root string, in agentDispatchHo
 		if windowID == "" {
 			return exitOK
 		}
-		durable, durableErr := durableCodexV2DispatchAttempts(
-			root, in.SessionID, in.TurnID, armed,
-		)
-		if durableErr != nil {
-			return preToolDeny(h, "DevRites could not verify the Codex V2 wright result: "+durableErr.Error(), stdout, stderr)
-		}
-		attempts = append(attempts, durable...)
 		if !roleSatisfied("devrites-slice-wright", windowID, attempts) {
-			return preToolDeny(h, "DevRites reconcile check/close requires a confirmed, awaited devrites-slice-wright result bound to the active reconcile snapshot.", stdout, stderr)
+			durable, durableErr := durableCodexV2DispatchAttempts(
+				root, in.SessionID, in.TurnID, armed,
+			)
+			if durableErr != nil {
+				return preToolDeny(h, "DevRites could not verify the Codex V2 wright result: "+durableErr.Error(), stdout, stderr)
+			}
+			attempts = append(attempts, durable...)
+			if !roleSatisfied("devrites-slice-wright", windowID, attempts) {
+				return preToolDeny(h, "DevRites reconcile check/close requires a confirmed, awaited devrites-slice-wright result bound to the active reconcile snapshot.", stdout, stderr)
+			}
+			for _, attempt := range durable {
+				if attempt.Role != "devrites-slice-wright" || attempt.WindowID != windowID ||
+					!dispatchAttemptComplete(attempt) {
+					continue
+				}
+				if err := appendAgentDispatchEvent(root, in.SessionID, agentDispatchEvent{
+					Event:        "verified",
+					TurnID:       in.TurnID,
+					AgentID:      attempt.AgentID,
+					AgentType:    attempt.AgentType,
+					Role:         attempt.Role,
+					WindowID:     attempt.WindowID,
+					ResultSHA256: attempt.ResultSHA256,
+				}); err != nil {
+					return preToolDeny(h, "DevRites could not persist the verified Codex V2 wright result: "+err.Error(), stdout, stderr)
+				}
+			}
 		}
 	}
 	return exitOK

package/engine/tests/hook_test.go

@@ -1218,7 +1218,10 @@ func TestCodexAgentDispatchBlocksFalseWaitAndStop(t *testing.T) {
 	if err := json.Unmarshal([]byte(strings.TrimSpace(out)), &stopDecision); err != nil {
 		t.Fatalf("invalid Stop response: %v\n%s", err, out)
 	}
-	if stopDecision.Decision != "block" || !strings.Contains(stopDecision.Reason, "spawn_agent") {
+	if stopDecision.Decision != "block" ||
+		!strings.Contains(stopDecision.Reason, "spawn_agent") ||
+		!strings.Contains(stopDecision.Reason, "visible tool schema") ||
+		!strings.Contains(stopDecision.Reason, "send agent_type anyway") {
 		t.Fatalf("false completion not blocked: %#v", stopDecision)
 	}
 
@@ -1338,6 +1341,33 @@ func TestCodexAgentDispatchConfirmsGenericRoleAndResult(t *testing.T) {
 		"turn_id":          turnID,
 		"stop_hook_active": false,
 	})
+	out, stderr, code = runDevritesIO(t, root, stop, nil,
+		"hook", "agent-dispatch", "--harness=codex")
+	if code != 0 {
+		t.Fatalf("unawaited stop exit=%d stderr=%s", code, stderr)
+	}
+	var blocked struct {
+		Decision string `json:"decision"`
+	}
+	if err := json.Unmarshal([]byte(strings.TrimSpace(out)), &blocked); err != nil {
+		t.Fatalf("invalid unawaited Stop response: %v\n%s", err, out)
+	}
+	if blocked.Decision != "block" {
+		t.Fatalf("unawaited child result passed Stop: %s", out)
+	}
+
+	wait := hookPayload(t, map[string]any{
+		"hook_event_name": "PreToolUse",
+		"session_id":      sessionID,
+		"turn_id":         turnID,
+		"tool_name":       "wait",
+		"tool_input":      map[string]any{"ids": []string{"agent-1"}},
+	})
+	if out, stderr, code := runDevritesIO(t, root, wait, nil,
+		"hook", "agent-dispatch", "--harness=codex"); code != 0 || strings.TrimSpace(out) != "" {
+		t.Fatalf("wait exit=%d out=%s stderr=%s", code, out, stderr)
+	}
+
 	if out, stderr, code := runDevritesIO(t, root, stop, nil,
 		"hook", "agent-dispatch", "--harness=codex"); code != 0 || strings.TrimSpace(out) != "" {
 		t.Fatalf("resolved stop exit=%d out=%s stderr=%s", code, out, stderr)
@@ -1576,6 +1606,21 @@ func TestCodexAgentDispatchBindsDurableV2WrightToReconcileWindow(t *testing.T) {
 				if decision, _ := parsePermissionDecision(t, out); decision != "deny" {
 					t.Fatalf("changed-window V2 wright was accepted: %s", out)
 				}
+				return
+			}
+			for _, name := range []string{".reconcile-base", ".reconcile-allowlist", ".reconcile-devrites"} {
+				if err := os.Remove(filepath.Join(workspace, name)); err != nil {
+					t.Fatal(err)
+				}
+			}
+			stop := hookPayload(t, map[string]any{
+				"hook_event_name": "Stop",
+				"session_id":      sessionID,
+				"turn_id":         turnID,
+			})
+			if out, stderr, code := runDevritesIO(t, root, stop, nil,
+				"hook", "agent-dispatch", "--harness=codex"); code != 0 || strings.TrimSpace(out) != "" {
+				t.Fatalf("persisted V2 wright receipt was lost after close: exit=%d out=%s stderr=%s", code, out, stderr)
 			}
 		})
 	}

package/pack/.claude/skills/devrites-lib/reference/standards/agents.md

@@ -67,11 +67,12 @@ field from the installed skill at `UserPromptSubmit` and arms a fail-closed comp
 receipt for every listed role; the engine derives roles from skill metadata.
 Conditional scouts and reviewers remain owned by their explicit phase triggers.
 
-Claude uses `Agent` (`Task` alias); Codex uses `spawn_agent`. V2 sends the exact named
-role, a unique `task_name`, and `fork_turns="none"`; Codex loads its TOML natively.
-Because V2 lifecycle calls bypass hooks, Stop/reconcile verify the durable rollout's
-role, instructions, wait, completion, and delivered result. V1 uses guarded
-`explorer`/`worker` with injected rules and a lifecycle receipt. Prose isn't evidence.
+Claude: `Agent`; Codex: `spawn_agent`. V2 calls the named `agent_type` with
+unique `task_name` and `fork_turns="none"`. GPT-5.6 may hide `agent_type` from the
+schema, but runtime accepts it and loads the TOML; never use `default`. V2 bypasses
+hooks, so Stop/reconcile verify role, native instructions, wait, completion, and result.
+V1 uses guarded `explorer`/`worker` with injected rules and receipt. Prose
+isn't evidence.
 
 ## File-backed dispatch contract
 

package/pack/generated/claude/skills/devrites-lib/reference/standards/agents.md

@@ -67,11 +67,12 @@ field from the installed skill at `UserPromptSubmit` and arms a fail-closed comp
 receipt for every listed role; the engine derives roles from skill metadata.
 Conditional scouts and reviewers remain owned by their explicit phase triggers.
 
-Claude uses `Agent` (`Task` alias); Codex uses `spawn_agent`. V2 sends the exact named
-role, a unique `task_name`, and `fork_turns="none"`; Codex loads its TOML natively.
-Because V2 lifecycle calls bypass hooks, Stop/reconcile verify the durable rollout's
-role, instructions, wait, completion, and delivered result. V1 uses guarded
-`explorer`/`worker` with injected rules and a lifecycle receipt. Prose isn't evidence.
+Claude: `Agent`; Codex: `spawn_agent`. V2 calls the named `agent_type` with
+unique `task_name` and `fork_turns="none"`. GPT-5.6 may hide `agent_type` from the
+schema, but runtime accepts it and loads the TOML; never use `default`. V2 bypasses
+hooks, so Stop/reconcile verify role, native instructions, wait, completion, and result.
+V1 uses guarded `explorer`/`worker` with injected rules and receipt. Prose
+isn't evidence.
 
 ## File-backed dispatch contract
 

package/pack/generated/codex/skills/devrites-lib/reference/standards/agents.md

@@ -67,11 +67,12 @@ field from the installed skill at `UserPromptSubmit` and arms a fail-closed comp
 receipt for every listed role; the engine derives roles from skill metadata.
 Conditional scouts and reviewers remain owned by their explicit phase triggers.
 
-Claude uses `Agent` (`spawn_agent` alias); Codex uses `spawn_agent`. V2 sends the exact named
-role, a unique `task_name`, and `fork_turns="none"`; Codex loads its TOML natively.
-Because V2 lifecycle calls bypass hooks, Stop/reconcile verify the durable rollout's
-role, instructions, wait, completion, and delivered result. V1 uses guarded
-`explorer`/`worker` with injected rules and a lifecycle receipt. Prose isn't evidence.
+Claude: `Agent`; Codex: `spawn_agent`. V2 calls the named `agent_type` with
+unique `task_name` and `fork_turns="none"`. GPT-5.6 may hide `agent_type` from the
+schema, but runtime accepts it and loads the TOML; never use `default`. V2 bypasses
+hooks, so Stop/reconcile verify role, native instructions, wait, completion, and result.
+V1 uses guarded `explorer`/`worker` with injected rules and receipt. Prose
+isn't evidence.
 
 ## File-backed dispatch contract
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "devrites",
-  "version": "3.2.3",
+  "version": "3.2.5",
   "description": "DevRites: a disciplined senior-engineer workflow pack for Claude Code and Codex",
   "license": "SEE LICENSE IN LICENSE",
   "homepage": "https://github.com/ViktorsBaikers/DevRites#readme",