devrites 3.2.28 → 4.0.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +16 -144
- package/NOTICE.md +6 -5
- package/README.md +187 -95
- package/SECURITY.md +103 -79
- package/bin/devrites.mjs +140 -24
- package/docs/adr/0003-gate-model-hitl-pause.md +1 -1
- package/docs/adr/0013-native-codex-agent-orchestration.md +74 -0
- package/docs/adr/0014-native-host-hook-boundary.md +64 -0
- package/docs/adr/0015-read-only-root-native-orchestration.md +96 -0
- package/docs/adr/0016-codex-writer-fail-closed.md +53 -0
- package/docs/adr/0017-native-codex-writer-agent.md +63 -0
- package/docs/adr/0018-native-sandbox-instruction-writer-boundary.md +66 -0
- package/docs/adr/0019-native-boundary-with-deterministic-gates.md +48 -0
- package/docs/adr/0020-thin-engine-native-orchestration-boundary.md +54 -0
- package/docs/adr/0021-observable-workspace-compatibility.md +49 -0
- package/docs/adr/0022-native-orchestration-thin-engine.md +90 -0
- package/docs/adr/0023-native-workspace-reads-line-output.md +71 -0
- package/docs/adr/0024-native-policy-offline-installer-boundary.md +111 -0
- package/docs/adr/0025-evidence-gated-workspace-upgrades.md +64 -0
- package/docs/adr/0026-content-bound-proof-and-bounded-inputs.md +169 -0
- package/docs/adr/0027-content-bound-build-readiness.md +77 -0
- package/docs/adr/README.md +26 -11
- package/docs/agents/domain.md +2 -1
- package/docs/agents/issue-driven-rites.md +1 -1
- package/docs/architecture.md +191 -103
- package/docs/candidate-integrity.md +138 -0
- package/docs/capability-surface-selection.md +15 -5
- package/docs/cli.md +139 -92
- package/docs/command-map.md +88 -63
- package/docs/engine/commands.md +115 -507
- package/docs/engine/state-schema.md +94 -113
- package/docs/engine/workspace-schema.md +169 -229
- package/docs/flow.md +113 -68
- package/docs/harness-compliance.md +29 -56
- package/docs/markdown-instruction-upgrade-2026-08-02.md +302 -0
- package/docs/orchestration.md +136 -149
- package/docs/porting-to-a-new-harness.md +22 -7
- package/docs/quick-reference.md +21 -8
- package/docs/release.md +47 -4
- package/docs/skills.md +111 -72
- package/docs/templates/CRITIC_REVIEW_PACKET_TEMPLATE.md +2 -0
- package/docs/upstream-workflow-benchmark-2026-08-01.md +655 -0
- package/docs/usage.md +99 -65
- package/engine/Makefile +1 -2
- package/engine/cmd/releasepack/main.go +45 -25
- package/engine/cmd/releasepack/main_test.go +69 -0
- package/engine/commands.go +8 -258
- package/engine/harnessmatrix_test.go +28 -41
- package/engine/internal/devritespaths/paths.go +12 -28
- package/engine/internal/fsutil/copy.go +8 -0
- package/engine/internal/gate/gate.go +104 -105
- package/engine/internal/gate/gate_test.go +94 -84
- package/engine/internal/gate/readiness_binding.go +203 -0
- package/engine/internal/gate/readiness_binding_test.go +271 -0
- package/engine/internal/gitenv/env.go +46 -0
- package/engine/internal/gitenv/env_test.go +48 -0
- package/engine/internal/hostpack/hostpack.go +16 -20
- package/engine/internal/hostpack/hostpack_test.go +6 -6
- package/engine/internal/install/install.go +289 -511
- package/engine/internal/install/install_test.go +218 -306
- package/engine/internal/lib/candidate.go +475 -0
- package/engine/internal/lib/candidate_test.go +503 -0
- package/engine/internal/lib/closeout.go +17 -21
- package/engine/internal/lib/closeout_test.go +23 -0
- package/engine/internal/lib/cursor_compat_test.go +12 -75
- package/engine/internal/lib/evidencefresh.go +58 -47
- package/engine/internal/lib/evidencefresh_test.go +120 -0
- package/engine/internal/lib/resolve.go +13 -35
- package/engine/internal/lib/resolve_remediation_test.go +5 -17
- package/engine/internal/lib/secretscan.go +432 -0
- package/engine/internal/lib/secretscan_test.go +555 -0
- package/engine/internal/lib/util.go +24 -65
- package/engine/internal/lib/util_test.go +44 -0
- package/engine/internal/markdowntext/markdowntext.go +108 -0
- package/engine/internal/markdowntext/markdowntext_test.go +58 -0
- package/engine/internal/markdowntext/testdata/structural.json +27 -0
- package/engine/internal/reason/reason.go +2 -123
- package/engine/internal/reason/reason_test.go +4 -2
- package/engine/internal/rootfacts/facts.go +6 -8
- package/engine/internal/rootfacts/facts_test.go +20 -0
- package/engine/internal/state/cmd/workflowmanifest/main.go +10 -12
- package/engine/internal/state/cursor.go +53 -14
- package/engine/internal/state/cursor_test.go +57 -0
- package/engine/internal/state/feature.go +64 -154
- package/engine/internal/state/schema.go +24 -50
- package/engine/internal/state/state_test.go +151 -140
- package/engine/internal/state/status.go +4 -17
- package/engine/internal/state/workflow_manifest.json +9 -89
- package/engine/main.go +73 -502
- package/engine/root_routing_test.go +183 -212
- package/engine/testdata/fixtures/basic/devrites-root/{features/auth-tokens/feature.md → work/auth-tokens/README.md} +0 -1
- package/engine/testdata/fixtures/basic/devrites-root/work/auth-tokens/architecture.md +3 -0
- package/engine/testdata/fixtures/basic/devrites-root/work/auth-tokens/assumptions.md +3 -0
- package/engine/testdata/fixtures/basic/devrites-root/work/auth-tokens/brief.md +3 -0
- package/engine/testdata/fixtures/basic/devrites-root/work/auth-tokens/decision-coverage.md +3 -0
- package/engine/testdata/fixtures/basic/devrites-root/work/auth-tokens/eng-review.md +3 -0
- package/engine/testdata/fixtures/basic/devrites-root/work/auth-tokens/questions.md +3 -0
- package/engine/testdata/fixtures/basic/devrites-root/{features/auth-tokens/status.md → work/auth-tokens/state.md} +3 -0
- package/engine/testdata/fixtures/basic/devrites-root/work/auth-tokens/test-plan.md +3 -0
- package/engine/testdata/fixtures/basic/devrites-root/work/auth-tokens/traceability.md +3 -0
- package/engine/testdata/fixtures/basic/devrites-root/{features/search-ranking/feature.md → work/search-ranking/README.md} +0 -1
- package/engine/testdata/fixtures/basic/devrites-root/work/search-ranking/assumptions.md +3 -0
- package/engine/testdata/fixtures/basic/devrites-root/work/search-ranking/brief.md +3 -0
- package/engine/testdata/fixtures/basic/devrites-root/work/search-ranking/decisions.md +3 -0
- package/engine/testdata/fixtures/basic/devrites-root/work/search-ranking/questions.md +3 -0
- package/engine/testdata/fixtures/basic/devrites-root/work/search-ranking/state.md +2 -0
- package/engine/testdata/golden/TestParityCloseOut/active_pointed_elsewhere.golden +1 -1
- package/engine/testdata/golden/TestParityCloseOut/active_slug_cleared.golden +1 -1
- package/engine/tests/adr_0003_gate_exit_code_test.go +2 -2
- package/engine/tests/adr_0011_define_plan_test.go +2 -2
- package/engine/tests/adr_0027_readiness_binding_test.go +106 -0
- package/engine/tests/cli_test.go +24 -107
- package/engine/tests/gate_test.go +177 -200
- package/engine/tests/meta_test.go +5 -35
- package/engine/tests/parity_closeout_test.go +12 -12
- package/engine/tests/parity_resolve_test.go +6 -16
- package/engine/tests/parity_test.go +8 -302
- package/install.sh +201 -34
- package/pack/.claude/agents/devrites-code-reviewer.md +9 -18
- package/pack/.claude/agents/devrites-devex-reviewer.md +10 -18
- package/pack/.claude/agents/devrites-doubt-reviewer.md +10 -20
- package/pack/.claude/agents/devrites-evidence-scout.md +14 -26
- package/pack/.claude/agents/devrites-frontend-reviewer.md +9 -15
- package/pack/.claude/agents/devrites-performance-reviewer.md +13 -21
- package/pack/.claude/agents/devrites-plan-drafter.md +24 -28
- package/pack/.claude/agents/devrites-plan-reviewer.md +30 -47
- package/pack/.claude/agents/devrites-proof-runner.md +41 -47
- package/pack/.claude/agents/devrites-retrospector.md +34 -79
- package/pack/.claude/agents/devrites-security-auditor.md +9 -17
- package/pack/.claude/agents/devrites-simplifier-reviewer.md +9 -18
- package/pack/.claude/agents/devrites-slice-wright.md +44 -62
- package/pack/.claude/agents/devrites-spec-reviewer.md +38 -50
- package/pack/.claude/agents/devrites-strategy-reviewer.md +10 -19
- package/pack/.claude/agents/devrites-test-analyst.md +22 -21
- package/pack/.claude/agents/devrites-upgrade-planner.md +52 -71
- package/pack/.claude/settings.json +12 -100
- package/pack/.claude/skills/devrites-api-interface/SKILL.md +1 -2
- package/pack/.claude/skills/devrites-audit/SKILL.md +6 -9
- package/pack/.claude/skills/devrites-browser-proof/SKILL.md +0 -1
- package/pack/.claude/skills/devrites-debug-recovery/SKILL.md +21 -27
- package/pack/.claude/skills/devrites-debug-recovery/reference/cleanup-and-classify.md +22 -33
- package/pack/.claude/skills/devrites-doubt/SKILL.md +4 -6
- package/pack/.claude/skills/devrites-frontend-craft/SKILL.md +1 -2
- package/pack/.claude/skills/devrites-frontend-craft/reference/design-references.md +2 -1
- package/pack/.claude/skills/devrites-interview/SKILL.md +31 -36
- package/pack/.claude/skills/devrites-lib/SKILL.md +37 -66
- package/pack/.claude/skills/devrites-lib/reference/candidate-integrity.md +51 -0
- package/pack/.claude/skills/devrites-lib/reference/intent-map.md +20 -12
- package/pack/.claude/skills/devrites-lib/reference/orchestration-profiles.md +22 -0
- package/pack/.claude/skills/devrites-lib/reference/parallel-dispatch.md +35 -110
- package/pack/.claude/skills/devrites-lib/reference/reply-contract.md +26 -93
- package/pack/.claude/skills/devrites-lib/reference/standards/README.md +6 -3
- package/pack/.claude/skills/devrites-lib/reference/standards/afk-hitl.md +43 -34
- package/pack/.claude/skills/devrites-lib/reference/standards/agents.md +90 -216
- package/pack/.claude/skills/devrites-lib/reference/standards/anti-patterns.md +1 -1
- package/pack/.claude/skills/devrites-lib/reference/standards/code-review.md +9 -28
- package/pack/.claude/skills/devrites-lib/reference/standards/context-hygiene.md +13 -11
- package/pack/.claude/skills/devrites-lib/reference/standards/core.md +59 -54
- package/pack/.claude/skills/devrites-lib/reference/standards/hooks.md +3 -5
- package/pack/.claude/skills/devrites-lib/reference/standards/principles.md +29 -143
- package/pack/.claude/skills/devrites-lib/reference/standards/release/ship-checklist.md +5 -6
- package/pack/.claude/skills/devrites-lib/reference/standards/security.md +13 -31
- package/pack/.claude/skills/devrites-lib/reference/standards/skill-authoring.md +112 -82
- package/pack/.claude/skills/devrites-lib/reference/standards/spec-grammar.md +71 -45
- package/pack/.claude/skills/devrites-lib/reference/standards/testing.md +22 -11
- package/pack/.claude/skills/devrites-lib/reference/standards/tooling.md +15 -24
- package/pack/.claude/skills/devrites-lib/reference/workspace-artifact-schema.md +106 -37
- package/pack/.claude/skills/devrites-prose-craft/SKILL.md +3 -4
- package/pack/.claude/skills/devrites-source-driven/SKILL.md +3 -4
- package/pack/.claude/skills/devrites-ux-shape/SKILL.md +3 -3
- package/pack/.claude/skills/rite/SKILL.md +12 -13
- package/pack/.claude/skills/rite/reference/menu.md +11 -11
- package/pack/.claude/skills/rite-adopt/SKILL.md +29 -84
- package/pack/.claude/skills/rite-adopt/reference/adoption.md +16 -50
- package/pack/.claude/skills/rite-autocomplete/SKILL.md +65 -54
- package/pack/.claude/skills/rite-autocomplete/reference/loop.md +24 -17
- package/pack/.claude/skills/rite-autocomplete/reference/stop-conditions.md +18 -21
- package/pack/.claude/skills/rite-build/SKILL.md +28 -34
- package/pack/.claude/skills/rite-build/reference/afk-discipline.md +36 -34
- package/pack/.claude/skills/rite-build/reference/anti-patterns.md +5 -19
- package/pack/.claude/skills/rite-build/reference/checkpoint-protocol.md +10 -9
- package/pack/.claude/skills/rite-build/reference/checkpoint.md +17 -17
- package/pack/.claude/skills/rite-build/reference/frontend-trigger.md +3 -3
- package/pack/.claude/skills/rite-build/reference/one-slice-cycle.md +11 -14
- package/pack/.claude/skills/rite-build/reference/output.md +14 -24
- package/pack/.claude/skills/rite-build/reference/phase-contract.md +49 -188
- package/pack/.claude/skills/rite-build/reference/spec-drift-guard.md +1 -1
- package/pack/.claude/skills/rite-build/reference/wright-dispatch.md +43 -133
- package/pack/.claude/skills/rite-clarify/SKILL.md +46 -40
- package/pack/.claude/skills/rite-clarify/reference/decision-coverage.md +4 -10
- package/pack/.claude/skills/rite-converge/SKILL.md +9 -33
- package/pack/.claude/skills/rite-converge/reference/convergence-assessment.md +2 -2
- package/pack/.claude/skills/rite-customize/SKILL.md +34 -50
- package/pack/.claude/skills/rite-define/SKILL.md +34 -58
- package/pack/.claude/skills/rite-define/reference/plan-template.md +15 -0
- package/pack/.claude/skills/rite-doctor/SKILL.md +52 -64
- package/pack/.claude/skills/rite-dogfood/SKILL.md +1 -2
- package/pack/.claude/skills/rite-explain/SKILL.md +1 -20
- package/pack/.claude/skills/rite-frame/SKILL.md +1 -7
- package/pack/.claude/skills/rite-frame/reference/failure-modes.md +1 -1
- package/pack/.claude/skills/rite-handoff/SKILL.md +1 -2
- package/pack/.claude/skills/rite-handoff/reference/handoff-template.md +1 -1
- package/pack/.claude/skills/rite-learn/SKILL.md +44 -104
- package/pack/.claude/skills/rite-plan/SKILL.md +14 -26
- package/pack/.claude/skills/rite-plan/reference/task-breakdown.md +4 -1
- package/pack/.claude/skills/rite-polish/SKILL.md +20 -28
- package/pack/.claude/skills/rite-polish/reference/adr-promotion.md +11 -0
- package/pack/{generated/claude/skills/rite-ship → .claude/skills/rite-polish}/reference/design-memory.md +23 -21
- package/pack/.claude/skills/rite-polish/reference/ledger.md +62 -0
- package/pack/.claude/skills/rite-pov/SKILL.md +28 -32
- package/pack/.claude/skills/rite-pr-feedback/SKILL.md +0 -1
- package/pack/.claude/skills/rite-pressure-test/SKILL.md +6 -13
- package/pack/.claude/skills/rite-prototype/SKILL.md +0 -6
- package/pack/.claude/skills/rite-prove/SKILL.md +73 -68
- package/pack/.claude/skills/rite-prove/reference/acceptance-proof.md +34 -30
- package/pack/.claude/skills/rite-prove/reference/test-command-discovery.md +15 -14
- package/pack/.claude/skills/rite-quick/SKILL.md +5 -19
- package/pack/.claude/skills/rite-resolve/SKILL.md +4 -21
- package/pack/.claude/skills/rite-resolve/reference/answer-protocol.md +2 -2
- package/pack/.claude/skills/rite-review/SKILL.md +34 -57
- package/pack/.claude/skills/rite-seal/SKILL.md +54 -87
- package/pack/.claude/skills/rite-seal/reference/anti-patterns.md +2 -2
- package/pack/.claude/skills/rite-seal/reference/final-evidence.md +31 -56
- package/pack/.claude/skills/rite-seal/reference/go-no-go.md +27 -51
- package/pack/.claude/skills/rite-seal/reference/output.md +2 -4
- package/pack/.claude/skills/rite-seal/reference/phase-contract.md +42 -140
- package/pack/.claude/skills/rite-seal/reference/risk-and-rollback.md +2 -2
- package/pack/.claude/skills/rite-seal/reference/seal-template.md +17 -28
- package/pack/.claude/skills/rite-ship/SKILL.md +65 -93
- package/pack/.claude/skills/rite-ship/reference/anti-patterns.md +4 -1
- package/pack/.claude/skills/rite-ship/reference/close-out.md +4 -12
- package/pack/.claude/skills/rite-ship/reference/git-ship.md +86 -48
- package/pack/.claude/skills/rite-ship/reference/ship-template.md +22 -16
- package/pack/.claude/skills/rite-spec/SKILL.md +62 -95
- package/pack/.claude/skills/rite-spec/reference/investigation.md +1 -4
- package/pack/.claude/skills/rite-spec/reference/question-protocol.md +21 -20
- package/pack/.claude/skills/rite-spec/reference/spec-checklists.md +16 -17
- package/pack/.claude/skills/rite-spec/reference/spec-template.md +47 -49
- package/pack/.claude/skills/rite-spec/reference/state-workspace.md +28 -13
- package/pack/.claude/skills/rite-status/SKILL.md +30 -88
- package/pack/.claude/skills/rite-temper/SKILL.md +12 -31
- package/pack/.claude/skills/rite-upgrade/SKILL.md +86 -101
- package/pack/.claude/skills/rite-vet/SKILL.md +88 -117
- package/pack/.claude/skills/rite-vet/reference/artifacts.md +56 -50
- package/pack/.claude/skills/rite-vet/reference/cross-model.md +15 -39
- package/pack/.claude/skills/rite-vet/reference/depth.md +2 -2
- package/pack/.claude/skills/rite-vet/reference/review-axes.md +3 -6
- package/pack/.claude/skills/rite-zoom-out/SKILL.md +0 -6
- package/pack/generated/README.md +2 -2
- package/pack/generated/claude/agents/devrites-code-reviewer.md +9 -18
- package/pack/generated/claude/agents/devrites-devex-reviewer.md +10 -18
- package/pack/generated/claude/agents/devrites-doubt-reviewer.md +10 -20
- package/pack/generated/claude/agents/devrites-evidence-scout.md +14 -26
- package/pack/generated/claude/agents/devrites-frontend-reviewer.md +9 -15
- package/pack/generated/claude/agents/devrites-performance-reviewer.md +13 -21
- package/pack/generated/claude/agents/devrites-plan-drafter.md +24 -28
- package/pack/generated/claude/agents/devrites-plan-reviewer.md +30 -47
- package/pack/generated/claude/agents/devrites-proof-runner.md +41 -47
- package/pack/generated/claude/agents/devrites-retrospector.md +34 -79
- package/pack/generated/claude/agents/devrites-security-auditor.md +9 -17
- package/pack/generated/claude/agents/devrites-simplifier-reviewer.md +9 -18
- package/pack/generated/claude/agents/devrites-slice-wright.md +44 -62
- package/pack/generated/claude/agents/devrites-spec-reviewer.md +38 -50
- package/pack/generated/claude/agents/devrites-strategy-reviewer.md +10 -19
- package/pack/generated/claude/agents/devrites-test-analyst.md +22 -21
- package/pack/generated/claude/agents/devrites-upgrade-planner.md +52 -71
- package/pack/generated/claude/settings.json +12 -100
- package/pack/generated/claude/skills/devrites-api-interface/SKILL.md +1 -2
- package/pack/generated/claude/skills/devrites-audit/SKILL.md +6 -9
- package/pack/generated/claude/skills/devrites-browser-proof/SKILL.md +0 -1
- package/pack/generated/claude/skills/devrites-debug-recovery/SKILL.md +21 -27
- package/pack/generated/claude/skills/devrites-debug-recovery/reference/cleanup-and-classify.md +22 -33
- package/pack/generated/claude/skills/devrites-doubt/SKILL.md +4 -6
- package/pack/generated/claude/skills/devrites-frontend-craft/SKILL.md +1 -2
- package/pack/generated/claude/skills/devrites-frontend-craft/reference/design-references.md +2 -1
- package/pack/generated/claude/skills/devrites-interview/SKILL.md +31 -36
- package/pack/generated/claude/skills/devrites-lib/SKILL.md +37 -66
- package/pack/generated/claude/skills/devrites-lib/reference/candidate-integrity.md +51 -0
- package/pack/generated/claude/skills/devrites-lib/reference/intent-map.md +20 -12
- package/pack/generated/claude/skills/devrites-lib/reference/orchestration-profiles.md +22 -0
- package/pack/generated/claude/skills/devrites-lib/reference/parallel-dispatch.md +35 -110
- package/pack/generated/claude/skills/devrites-lib/reference/reply-contract.md +26 -93
- package/pack/generated/claude/skills/devrites-lib/reference/standards/README.md +6 -3
- package/pack/generated/claude/skills/devrites-lib/reference/standards/afk-hitl.md +43 -34
- package/pack/generated/claude/skills/devrites-lib/reference/standards/agents.md +90 -216
- package/pack/generated/claude/skills/devrites-lib/reference/standards/anti-patterns.md +1 -1
- package/pack/generated/claude/skills/devrites-lib/reference/standards/code-review.md +9 -28
- package/pack/generated/claude/skills/devrites-lib/reference/standards/context-hygiene.md +13 -11
- package/pack/generated/claude/skills/devrites-lib/reference/standards/core.md +59 -54
- package/pack/generated/claude/skills/devrites-lib/reference/standards/hooks.md +3 -5
- package/pack/generated/claude/skills/devrites-lib/reference/standards/principles.md +29 -143
- package/pack/generated/claude/skills/devrites-lib/reference/standards/release/ship-checklist.md +5 -6
- package/pack/generated/claude/skills/devrites-lib/reference/standards/security.md +13 -31
- package/pack/generated/claude/skills/devrites-lib/reference/standards/skill-authoring.md +112 -82
- package/pack/generated/claude/skills/devrites-lib/reference/standards/spec-grammar.md +71 -45
- package/pack/generated/claude/skills/devrites-lib/reference/standards/testing.md +22 -11
- package/pack/generated/claude/skills/devrites-lib/reference/standards/tooling.md +15 -24
- package/pack/generated/claude/skills/devrites-lib/reference/workspace-artifact-schema.md +106 -37
- package/pack/generated/claude/skills/devrites-prose-craft/SKILL.md +3 -4
- package/pack/generated/claude/skills/devrites-source-driven/SKILL.md +3 -4
- package/pack/generated/claude/skills/devrites-ux-shape/SKILL.md +3 -3
- package/pack/generated/claude/skills/rite/SKILL.md +12 -13
- package/pack/generated/claude/skills/rite/reference/menu.md +11 -11
- package/pack/generated/claude/skills/rite-adopt/SKILL.md +29 -84
- package/pack/generated/claude/skills/rite-adopt/reference/adoption.md +16 -50
- package/pack/generated/claude/skills/rite-autocomplete/SKILL.md +65 -54
- package/pack/generated/claude/skills/rite-autocomplete/reference/loop.md +24 -17
- package/pack/generated/claude/skills/rite-autocomplete/reference/stop-conditions.md +18 -21
- package/pack/generated/claude/skills/rite-build/SKILL.md +28 -34
- package/pack/generated/claude/skills/rite-build/reference/afk-discipline.md +36 -34
- package/pack/generated/claude/skills/rite-build/reference/anti-patterns.md +5 -19
- package/pack/generated/claude/skills/rite-build/reference/checkpoint-protocol.md +10 -9
- package/pack/generated/claude/skills/rite-build/reference/checkpoint.md +17 -17
- package/pack/generated/claude/skills/rite-build/reference/frontend-trigger.md +3 -3
- package/pack/generated/claude/skills/rite-build/reference/one-slice-cycle.md +11 -14
- package/pack/generated/claude/skills/rite-build/reference/output.md +14 -24
- package/pack/generated/claude/skills/rite-build/reference/phase-contract.md +49 -188
- package/pack/generated/claude/skills/rite-build/reference/spec-drift-guard.md +1 -1
- package/pack/generated/claude/skills/rite-build/reference/wright-dispatch.md +43 -133
- package/pack/generated/claude/skills/rite-clarify/SKILL.md +46 -40
- package/pack/generated/claude/skills/rite-clarify/reference/decision-coverage.md +4 -10
- package/pack/generated/claude/skills/rite-converge/SKILL.md +9 -33
- package/pack/generated/claude/skills/rite-converge/reference/convergence-assessment.md +2 -2
- package/pack/generated/claude/skills/rite-customize/SKILL.md +34 -50
- package/pack/generated/claude/skills/rite-define/SKILL.md +34 -58
- package/pack/generated/claude/skills/rite-define/reference/plan-template.md +15 -0
- package/pack/generated/claude/skills/rite-doctor/SKILL.md +52 -64
- package/pack/generated/claude/skills/rite-dogfood/SKILL.md +1 -2
- package/pack/generated/claude/skills/rite-explain/SKILL.md +1 -20
- package/pack/generated/claude/skills/rite-frame/SKILL.md +1 -7
- package/pack/generated/claude/skills/rite-frame/reference/failure-modes.md +1 -1
- package/pack/generated/claude/skills/rite-handoff/SKILL.md +1 -2
- package/pack/generated/claude/skills/rite-handoff/reference/handoff-template.md +1 -1
- package/pack/generated/claude/skills/rite-learn/SKILL.md +44 -104
- package/pack/generated/claude/skills/rite-plan/SKILL.md +14 -26
- package/pack/generated/claude/skills/rite-plan/reference/task-breakdown.md +4 -1
- package/pack/generated/claude/skills/rite-polish/SKILL.md +20 -28
- package/pack/generated/claude/skills/rite-polish/reference/adr-promotion.md +11 -0
- package/pack/generated/{codex/skills/rite-ship → claude/skills/rite-polish}/reference/design-memory.md +23 -21
- package/pack/generated/claude/skills/rite-polish/reference/ledger.md +62 -0
- package/pack/generated/claude/skills/rite-pov/SKILL.md +28 -32
- package/pack/generated/claude/skills/rite-pr-feedback/SKILL.md +0 -1
- package/pack/generated/claude/skills/rite-pressure-test/SKILL.md +6 -13
- package/pack/generated/claude/skills/rite-prototype/SKILL.md +0 -6
- package/pack/generated/claude/skills/rite-prove/SKILL.md +73 -68
- package/pack/generated/claude/skills/rite-prove/reference/acceptance-proof.md +34 -30
- package/pack/generated/claude/skills/rite-prove/reference/test-command-discovery.md +15 -14
- package/pack/generated/claude/skills/rite-quick/SKILL.md +5 -19
- package/pack/generated/claude/skills/rite-resolve/SKILL.md +4 -21
- package/pack/generated/claude/skills/rite-resolve/reference/answer-protocol.md +2 -2
- package/pack/generated/claude/skills/rite-review/SKILL.md +34 -57
- package/pack/generated/claude/skills/rite-seal/SKILL.md +54 -87
- package/pack/generated/claude/skills/rite-seal/reference/anti-patterns.md +2 -2
- package/pack/generated/claude/skills/rite-seal/reference/final-evidence.md +31 -56
- package/pack/generated/claude/skills/rite-seal/reference/go-no-go.md +27 -51
- package/pack/generated/claude/skills/rite-seal/reference/output.md +2 -4
- package/pack/generated/claude/skills/rite-seal/reference/phase-contract.md +42 -140
- package/pack/generated/claude/skills/rite-seal/reference/risk-and-rollback.md +2 -2
- package/pack/generated/claude/skills/rite-seal/reference/seal-template.md +17 -28
- package/pack/generated/claude/skills/rite-ship/SKILL.md +65 -93
- package/pack/generated/claude/skills/rite-ship/reference/anti-patterns.md +4 -1
- package/pack/generated/claude/skills/rite-ship/reference/close-out.md +4 -12
- package/pack/generated/claude/skills/rite-ship/reference/git-ship.md +86 -48
- package/pack/generated/claude/skills/rite-ship/reference/ship-template.md +22 -16
- package/pack/generated/claude/skills/rite-spec/SKILL.md +62 -95
- package/pack/generated/claude/skills/rite-spec/reference/investigation.md +1 -4
- package/pack/generated/claude/skills/rite-spec/reference/question-protocol.md +21 -20
- package/pack/generated/claude/skills/rite-spec/reference/spec-checklists.md +16 -17
- package/pack/generated/claude/skills/rite-spec/reference/spec-template.md +47 -49
- package/pack/generated/claude/skills/rite-spec/reference/state-workspace.md +28 -13
- package/pack/generated/claude/skills/rite-status/SKILL.md +30 -88
- package/pack/generated/claude/skills/rite-temper/SKILL.md +12 -31
- package/pack/generated/claude/skills/rite-upgrade/SKILL.md +86 -101
- package/pack/generated/claude/skills/rite-vet/SKILL.md +88 -117
- package/pack/generated/claude/skills/rite-vet/reference/artifacts.md +56 -50
- package/pack/generated/claude/skills/rite-vet/reference/cross-model.md +15 -39
- package/pack/generated/claude/skills/rite-vet/reference/depth.md +2 -2
- package/pack/generated/claude/skills/rite-vet/reference/review-axes.md +3 -6
- package/pack/generated/claude/skills/rite-zoom-out/SKILL.md +0 -6
- package/pack/generated/codex/AGENTS.md +5 -4
- package/pack/generated/codex/agents/devrites-code-reviewer.toml +8 -27
- package/pack/generated/codex/agents/devrites-devex-reviewer.toml +9 -27
- package/pack/generated/codex/agents/devrites-doubt-reviewer.toml +9 -29
- package/pack/generated/codex/agents/devrites-evidence-scout.toml +14 -36
- package/pack/generated/codex/agents/devrites-frontend-reviewer.toml +8 -24
- package/pack/generated/codex/agents/devrites-performance-reviewer.toml +12 -30
- package/pack/generated/codex/agents/devrites-plan-drafter.toml +24 -38
- package/pack/generated/codex/agents/devrites-plan-reviewer.toml +30 -57
- package/pack/generated/codex/agents/devrites-proof-runner.toml +41 -57
- package/pack/generated/codex/agents/devrites-retrospector.toml +34 -89
- package/pack/generated/codex/agents/devrites-security-auditor.toml +8 -26
- package/pack/generated/codex/agents/devrites-simplifier-reviewer.toml +8 -27
- package/pack/generated/codex/agents/devrites-slice-wright.toml +44 -71
- package/pack/generated/codex/agents/devrites-spec-reviewer.toml +38 -60
- package/pack/generated/codex/agents/devrites-strategy-reviewer.toml +9 -28
- package/pack/generated/codex/agents/devrites-test-analyst.toml +21 -30
- package/pack/generated/codex/agents/devrites-upgrade-planner.toml +52 -81
- package/pack/generated/codex/config.toml +7 -0
- package/pack/generated/codex/skills/devrites-api-interface/SKILL.md +1 -21
- package/pack/generated/codex/skills/devrites-audit/SKILL.md +6 -28
- package/pack/generated/codex/skills/devrites-browser-proof/SKILL.md +1 -21
- package/pack/generated/codex/skills/devrites-debug-recovery/SKILL.md +21 -46
- package/pack/generated/codex/skills/devrites-debug-recovery/reference/cleanup-and-classify.md +22 -33
- package/pack/generated/codex/skills/devrites-doubt/SKILL.md +4 -25
- package/pack/generated/codex/skills/devrites-frontend-craft/SKILL.md +1 -21
- package/pack/generated/codex/skills/devrites-frontend-craft/reference/design-references.md +2 -1
- package/pack/generated/codex/skills/devrites-interview/SKILL.md +32 -56
- package/pack/generated/codex/skills/devrites-lib/SKILL.md +38 -86
- package/pack/generated/codex/skills/devrites-lib/reference/candidate-integrity.md +51 -0
- package/pack/generated/codex/skills/devrites-lib/reference/intent-map.md +20 -12
- package/pack/generated/codex/skills/devrites-lib/reference/orchestration-profiles.md +22 -0
- package/pack/generated/codex/skills/devrites-lib/reference/parallel-dispatch.md +35 -110
- package/pack/generated/codex/skills/devrites-lib/reference/reply-contract.md +26 -93
- package/pack/generated/codex/skills/devrites-lib/reference/standards/README.md +6 -3
- package/pack/generated/codex/skills/devrites-lib/reference/standards/afk-hitl.md +43 -34
- package/pack/generated/codex/skills/devrites-lib/reference/standards/agents.md +90 -216
- package/pack/generated/codex/skills/devrites-lib/reference/standards/anti-patterns.md +1 -1
- package/pack/generated/codex/skills/devrites-lib/reference/standards/code-review.md +9 -28
- package/pack/generated/codex/skills/devrites-lib/reference/standards/context-hygiene.md +13 -11
- package/pack/generated/codex/skills/devrites-lib/reference/standards/core.md +59 -54
- package/pack/generated/codex/skills/devrites-lib/reference/standards/hooks.md +3 -5
- package/pack/generated/codex/skills/devrites-lib/reference/standards/principles.md +29 -143
- package/pack/generated/codex/skills/devrites-lib/reference/standards/release/ship-checklist.md +5 -6
- package/pack/generated/codex/skills/devrites-lib/reference/standards/security.md +13 -31
- package/pack/generated/codex/skills/devrites-lib/reference/standards/skill-authoring.md +112 -82
- package/pack/generated/codex/skills/devrites-lib/reference/standards/spec-grammar.md +71 -45
- package/pack/generated/codex/skills/devrites-lib/reference/standards/testing.md +22 -11
- package/pack/generated/codex/skills/devrites-lib/reference/standards/tooling.md +15 -24
- package/pack/generated/codex/skills/devrites-lib/reference/workspace-artifact-schema.md +106 -37
- package/pack/generated/codex/skills/devrites-prose-craft/SKILL.md +3 -23
- package/pack/generated/codex/skills/devrites-source-driven/SKILL.md +3 -23
- package/pack/generated/codex/skills/devrites-ux-shape/SKILL.md +3 -22
- package/pack/generated/codex/skills/rite/SKILL.md +12 -32
- package/pack/generated/codex/skills/rite/reference/menu.md +11 -11
- package/pack/generated/codex/skills/rite-adopt/SKILL.md +29 -103
- package/pack/generated/codex/skills/rite-adopt/reference/adoption.md +16 -50
- package/pack/generated/codex/skills/rite-autocomplete/SKILL.md +65 -73
- package/pack/generated/codex/skills/rite-autocomplete/reference/loop.md +24 -17
- package/pack/generated/codex/skills/rite-autocomplete/reference/stop-conditions.md +18 -21
- package/pack/generated/codex/skills/rite-build/SKILL.md +28 -53
- package/pack/generated/codex/skills/rite-build/reference/afk-discipline.md +36 -34
- package/pack/generated/codex/skills/rite-build/reference/anti-patterns.md +5 -19
- package/pack/generated/codex/skills/rite-build/reference/checkpoint-protocol.md +10 -9
- package/pack/generated/codex/skills/rite-build/reference/checkpoint.md +17 -17
- package/pack/generated/codex/skills/rite-build/reference/frontend-trigger.md +3 -3
- package/pack/generated/codex/skills/rite-build/reference/one-slice-cycle.md +11 -14
- package/pack/generated/codex/skills/rite-build/reference/output.md +14 -24
- package/pack/generated/codex/skills/rite-build/reference/phase-contract.md +49 -188
- package/pack/generated/codex/skills/rite-build/reference/spec-drift-guard.md +1 -1
- package/pack/generated/codex/skills/rite-build/reference/wright-dispatch.md +43 -133
- package/pack/generated/codex/skills/rite-clarify/SKILL.md +46 -59
- package/pack/generated/codex/skills/rite-clarify/reference/decision-coverage.md +4 -10
- package/pack/generated/codex/skills/rite-converge/SKILL.md +9 -52
- package/pack/generated/codex/skills/rite-converge/reference/convergence-assessment.md +2 -2
- package/pack/generated/codex/skills/rite-customize/SKILL.md +32 -67
- package/pack/generated/codex/skills/rite-define/SKILL.md +34 -77
- package/pack/generated/codex/skills/rite-define/reference/plan-template.md +15 -0
- package/pack/generated/codex/skills/rite-doctor/SKILL.md +52 -83
- package/pack/generated/codex/skills/rite-dogfood/SKILL.md +1 -21
- package/pack/generated/codex/skills/rite-explain/SKILL.md +1 -39
- package/pack/generated/codex/skills/rite-frame/SKILL.md +1 -26
- package/pack/generated/codex/skills/rite-frame/reference/failure-modes.md +1 -1
- package/pack/generated/codex/skills/rite-handoff/SKILL.md +1 -21
- package/pack/generated/codex/skills/rite-handoff/reference/handoff-template.md +1 -1
- package/pack/generated/codex/skills/rite-learn/SKILL.md +44 -123
- package/pack/generated/codex/skills/rite-plan/SKILL.md +14 -45
- package/pack/generated/codex/skills/rite-plan/reference/task-breakdown.md +4 -1
- package/pack/generated/codex/skills/rite-polish/SKILL.md +20 -47
- package/pack/generated/codex/skills/rite-polish/reference/adr-promotion.md +11 -0
- package/pack/{.claude/skills/rite-ship → generated/codex/skills/rite-polish}/reference/design-memory.md +23 -21
- package/pack/generated/codex/skills/rite-polish/reference/ledger.md +62 -0
- package/pack/generated/codex/skills/rite-pov/SKILL.md +28 -51
- package/pack/generated/codex/skills/rite-pr-feedback/SKILL.md +0 -20
- package/pack/generated/codex/skills/rite-pressure-test/SKILL.md +6 -32
- package/pack/generated/codex/skills/rite-prototype/SKILL.md +0 -25
- package/pack/generated/codex/skills/rite-prove/SKILL.md +73 -87
- package/pack/generated/codex/skills/rite-prove/reference/acceptance-proof.md +34 -30
- package/pack/generated/codex/skills/rite-prove/reference/test-command-discovery.md +15 -14
- package/pack/generated/codex/skills/rite-quick/SKILL.md +5 -38
- package/pack/generated/codex/skills/rite-resolve/SKILL.md +4 -40
- package/pack/generated/codex/skills/rite-resolve/reference/answer-protocol.md +2 -2
- package/pack/generated/codex/skills/rite-review/SKILL.md +34 -76
- package/pack/generated/codex/skills/rite-seal/SKILL.md +51 -103
- package/pack/generated/codex/skills/rite-seal/reference/anti-patterns.md +2 -2
- package/pack/generated/codex/skills/rite-seal/reference/final-evidence.md +31 -56
- package/pack/generated/codex/skills/rite-seal/reference/go-no-go.md +27 -51
- package/pack/generated/codex/skills/rite-seal/reference/output.md +2 -4
- package/pack/generated/codex/skills/rite-seal/reference/phase-contract.md +42 -140
- package/pack/generated/codex/skills/rite-seal/reference/risk-and-rollback.md +2 -2
- package/pack/generated/codex/skills/rite-seal/reference/seal-template.md +17 -28
- package/pack/generated/codex/skills/rite-ship/SKILL.md +65 -112
- package/pack/generated/codex/skills/rite-ship/reference/anti-patterns.md +4 -1
- package/pack/generated/codex/skills/rite-ship/reference/close-out.md +4 -12
- package/pack/generated/codex/skills/rite-ship/reference/git-ship.md +86 -48
- package/pack/generated/codex/skills/rite-ship/reference/ship-template.md +22 -16
- package/pack/generated/codex/skills/rite-spec/SKILL.md +62 -114
- package/pack/generated/codex/skills/rite-spec/reference/investigation.md +1 -4
- package/pack/generated/codex/skills/rite-spec/reference/question-protocol.md +21 -20
- package/pack/generated/codex/skills/rite-spec/reference/spec-checklists.md +16 -17
- package/pack/generated/codex/skills/rite-spec/reference/spec-template.md +47 -49
- package/pack/generated/codex/skills/rite-spec/reference/state-workspace.md +28 -13
- package/pack/generated/codex/skills/rite-status/SKILL.md +30 -107
- package/pack/generated/codex/skills/rite-temper/SKILL.md +12 -50
- package/pack/generated/codex/skills/rite-upgrade/SKILL.md +86 -120
- package/pack/generated/codex/skills/rite-vet/SKILL.md +88 -136
- package/pack/generated/codex/skills/rite-vet/reference/artifacts.md +56 -50
- package/pack/generated/codex/skills/rite-vet/reference/cross-model.md +15 -39
- package/pack/generated/codex/skills/rite-vet/reference/depth.md +2 -2
- package/pack/generated/codex/skills/rite-vet/reference/review-axes.md +3 -6
- package/pack/generated/codex/skills/rite-zoom-out/SKILL.md +0 -25
- package/package.json +6 -5
- package/scripts/build-host-artifacts.sh +5 -9
- package/scripts/codex-generate.sh +18 -278
- package/scripts/install-lib.sh +121 -34
- package/uninstall.sh +19 -17
- package/update.sh +26 -18
- package/docs/engine/agent-contract.md +0 -172
- package/docs/extensions.md +0 -178
- package/engine/git_guard.go +0 -187
- package/engine/git_guard_test.go +0 -283
- package/engine/harnessmatrix.go +0 -60
- package/engine/hookpolicy.go +0 -113
- package/engine/hookpolicy_test.go +0 -160
- package/engine/hooks.go +0 -677
- package/engine/hooks_agent_dispatch.go +0 -1726
- package/engine/hooks_events_test.go +0 -431
- package/engine/hooks_workspace.go +0 -1196
- package/engine/internal/doctor/doctor.go +0 -306
- package/engine/internal/doctor/doctor_test.go +0 -252
- package/engine/internal/forge/forge.go +0 -938
- package/engine/internal/forge/forge_test.go +0 -576
- package/engine/internal/forge/git.go +0 -245
- package/engine/internal/forge/liveness_unix.go +0 -48
- package/engine/internal/forge/liveness_windows.go +0 -67
- package/engine/internal/forge/manifest.go +0 -402
- package/engine/internal/harness/compliance.go +0 -96
- package/engine/internal/harness/harness.go +0 -301
- package/engine/internal/harness/harness_test.go +0 -124
- package/engine/internal/iohooks/detach_other.go +0 -11
- package/engine/internal/iohooks/detach_unix.go +0 -11
- package/engine/internal/iohooks/iohooks.go +0 -839
- package/engine/internal/iohooks/iohooks_test.go +0 -561
- package/engine/internal/lib/adoption.go +0 -659
- package/engine/internal/lib/adoption_test.go +0 -121
- package/engine/internal/lib/analyze.go +0 -232
- package/engine/internal/lib/archivesearch.go +0 -125
- package/engine/internal/lib/archivesearch_test.go +0 -138
- package/engine/internal/lib/budget.go +0 -172
- package/engine/internal/lib/buildreadiness.go +0 -111
- package/engine/internal/lib/checkacceptance.go +0 -176
- package/engine/internal/lib/clarifyreturn.go +0 -91
- package/engine/internal/lib/clarifyreturn_test.go +0 -123
- package/engine/internal/lib/command_other.go +0 -7
- package/engine/internal/lib/command_unix.go +0 -24
- package/engine/internal/lib/context.go +0 -280
- package/engine/internal/lib/conventions.go +0 -449
- package/engine/internal/lib/coverage.go +0 -145
- package/engine/internal/lib/dispatchwaive.go +0 -31
- package/engine/internal/lib/dispatchwaive_test.go +0 -23
- package/engine/internal/lib/doubtcoverage.go +0 -78
- package/engine/internal/lib/extensions.go +0 -622
- package/engine/internal/lib/extensions_test.go +0 -305
- package/engine/internal/lib/footprint.go +0 -239
- package/engine/internal/lib/gitauthority.go +0 -601
- package/engine/internal/lib/gitauthority_test.go +0 -346
- package/engine/internal/lib/jsonout.go +0 -129
- package/engine/internal/lib/jsonout_test.go +0 -73
- package/engine/internal/lib/lanes.go +0 -112
- package/engine/internal/lib/learnings.go +0 -397
- package/engine/internal/lib/learnings_inject_test.go +0 -77
- package/engine/internal/lib/learnings_remediation_test.go +0 -24
- package/engine/internal/lib/ledger.go +0 -311
- package/engine/internal/lib/ledger_test.go +0 -186
- package/engine/internal/lib/mutationgate.go +0 -89
- package/engine/internal/lib/observability_test.go +0 -358
- package/engine/internal/lib/overrides.go +0 -164
- package/engine/internal/lib/overrides_test.go +0 -112
- package/engine/internal/lib/preamble.go +0 -159
- package/engine/internal/lib/preamble_questions_test.go +0 -10
- package/engine/internal/lib/progress.go +0 -210
- package/engine/internal/lib/provenance.go +0 -462
- package/engine/internal/lib/provenance_test.go +0 -154
- package/engine/internal/lib/readiness_contract.json +0 -118
- package/engine/internal/lib/readinessartifact.go +0 -533
- package/engine/internal/lib/readinessartifact_test.go +0 -422
- package/engine/internal/lib/reconcile.go +0 -1496
- package/engine/internal/lib/reconcile_test.go +0 -1071
- package/engine/internal/lib/recoveryattempts.go +0 -298
- package/engine/internal/lib/recoveryattempts_test.go +0 -215
- package/engine/internal/lib/reviewers.go +0 -143
- package/engine/internal/lib/reviewers_test.go +0 -45
- package/engine/internal/lib/reviewerstats.go +0 -199
- package/engine/internal/lib/reviewerstats_test.go +0 -104
- package/engine/internal/lib/reviewintegrity.go +0 -143
- package/engine/internal/lib/reviewintegrity_test.go +0 -103
- package/engine/internal/lib/runbook.go +0 -295
- package/engine/internal/lib/runbook_context_test.go +0 -182
- package/engine/internal/lib/session.go +0 -1020
- package/engine/internal/lib/session_test.go +0 -177
- package/engine/internal/lib/specparse.go +0 -125
- package/engine/internal/lib/specskeleton.go +0 -79
- package/engine/internal/lib/specvalidate.go +0 -391
- package/engine/internal/lib/specvalidate_test.go +0 -185
- package/engine/internal/lib/stuck.go +0 -206
- package/engine/internal/lib/templates/conventions_drift.tmpl +0 -6
- package/engine/internal/lib/templates/conventions_ledger_header.md +0 -6
- package/engine/internal/lib/templates/conventions_orient_header.txt +0 -1
- package/engine/internal/lib/testintegrity.go +0 -199
- package/engine/internal/lib/testintegrity_test.go +0 -149
- package/engine/internal/lib/tickafk.go +0 -86
- package/engine/internal/migrate/migrate.go +0 -279
- package/engine/internal/migrate/migrate_test.go +0 -157
- package/engine/internal/orient/firstrun.go +0 -50
- package/engine/internal/orient/firstrun_test.go +0 -72
- package/engine/internal/orient/orient.go +0 -69
- package/engine/internal/orient/orient_test.go +0 -25
- package/engine/internal/profile/profile.go +0 -284
- package/engine/internal/profile/profile_test.go +0 -13
- package/engine/internal/state/clarify_transition.go +0 -165
- package/engine/internal/state/clarify_transition_test.go +0 -130
- package/engine/internal/state/snapshot.go +0 -457
- package/engine/internal/toolpolicy/classifier.go +0 -533
- package/engine/internal/toolpolicy/classifier_test.go +0 -424
- package/engine/internal/toolpolicy/git.go +0 -616
- package/engine/internal/toolpolicy/scanner.go +0 -382
- package/engine/observability_cli_test.go +0 -52
- package/engine/profile_test.go +0 -76
- package/engine/subagent_orient_context.txt +0 -8
- package/engine/testdata/golden/TestParityA1Guard/devrites-edit-allowed.golden +0 -1
- package/engine/testdata/golden/TestParityA1Guard/no-window-silent.golden +0 -1
- package/engine/testdata/golden/TestParityA1Guard/non-edit-tool.golden +0 -1
- package/engine/testdata/golden/TestParityA1Guard/observe-mode-silent.golden +0 -1
- package/engine/testdata/golden/TestParityA1Guard/source-edit-enforce-denies.golden +0 -2
- package/engine/testdata/golden/TestParityA1Guard/subagent-allowed.golden +0 -1
- package/engine/testdata/golden/TestParityAnalyze/noactive.golden +0 -1
- package/engine/testdata/golden/TestParityAnalyze/slug=covered.golden +0 -15
- package/engine/testdata/golden/TestParityAnalyze/slug=dangling.golden +0 -16
- package/engine/testdata/golden/TestParityAnalyze/slug=ghost.golden +0 -1
- package/engine/testdata/golden/TestParityAnalyze/slug=noac.golden +0 -15
- package/engine/testdata/golden/TestParityAnalyze/slug=order.golden +0 -17
- package/engine/testdata/golden/TestParityAnalyze/slug=orphan.golden +0 -16
- package/engine/testdata/golden/TestParityAnalyze/slug=uncovered.golden +0 -16
- package/engine/testdata/golden/TestParityBudget/default-active.golden +0 -4
- package/engine/testdata/golden/TestParityBudget/extra-md.golden +0 -5
- package/engine/testdata/golden/TestParityBudget/no-active.golden +0 -1
- package/engine/testdata/golden/TestParityBudget/no-feature.golden +0 -1
- package/engine/testdata/golden/TestParityBudget/over-advisory.golden +0 -6
- package/engine/testdata/golden/TestParityBudget/over-strict.golden +0 -6
- package/engine/testdata/golden/TestParityBudget/within.golden +0 -6
- package/engine/testdata/golden/TestParityBuildReadiness/arg=approved.golden +0 -2
- package/engine/testdata/golden/TestParityBuildReadiness/arg=approvenone.golden +0 -1
- package/engine/testdata/golden/TestParityBuildReadiness/arg=await.golden +0 -1
- package/engine/testdata/golden/TestParityBuildReadiness/arg=blocked.golden +0 -1
- package/engine/testdata/golden/TestParityBuildReadiness/arg=clarifyopen.golden +0 -1
- package/engine/testdata/golden/TestParityBuildReadiness/arg=emptystatus.golden +0 -2
- package/engine/testdata/golden/TestParityBuildReadiness/arg=ghost.golden +0 -1
- package/engine/testdata/golden/TestParityBuildReadiness/arg=legacycontract.golden +0 -1
- package/engine/testdata/golden/TestParityBuildReadiness/arg=noapprove.golden +0 -1
- package/engine/testdata/golden/TestParityBuildReadiness/arg=noclarify.golden +0 -1
- package/engine/testdata/golden/TestParityBuildReadiness/arg=novet.golden +0 -1
- package/engine/testdata/golden/TestParityBuildReadiness/arg=stalevet.golden +0 -1
- package/engine/testdata/golden/TestParityBuildReadiness/arg=trailhash.golden +0 -2
- package/engine/testdata/golden/TestParityBuildReadiness/arg=trailpipe.golden +0 -2
- package/engine/testdata/golden/TestParityBuildReadiness/arg=vetnotready.golden +0 -1
- package/engine/testdata/golden/TestParityCheckAcceptance/arg=blank-section.golden +0 -1
- package/engine/testdata/golden/TestParityCheckAcceptance/arg=empty.golden +0 -1
- package/engine/testdata/golden/TestParityCheckAcceptance/arg=flat-dropped.golden +0 -1
- package/engine/testdata/golden/TestParityCheckAcceptance/arg=flat-ok.golden +0 -2
- package/engine/testdata/golden/TestParityCheckAcceptance/arg=flat-unchecked.golden +0 -1
- package/engine/testdata/golden/TestParityCheckAcceptance/arg=id-gap.golden +0 -1
- package/engine/testdata/golden/TestParityCheckAcceptance/arg=id-ok.golden +0 -2
- package/engine/testdata/golden/TestParityCheckAcceptance/arg=no-seal.golden +0 -1
- package/engine/testdata/golden/TestParityCheckAcceptance/arg=no-section.golden +0 -1
- package/engine/testdata/golden/TestParityCheckAcceptance/arg=nonexistent.golden +0 -1
- package/engine/testdata/golden/TestParityCheckAcceptance.golden +0 -1
- package/engine/testdata/golden/TestParityCoverage/arg=flat.golden +0 -7
- package/engine/testdata/golden/TestParityCoverage/arg=full.golden +0 -10
- package/engine/testdata/golden/TestParityCoverage/arg=nonexistent.golden +0 -1
- package/engine/testdata/golden/TestParityCoverage/arg=nospec.golden +0 -1
- package/engine/testdata/golden/TestParityCoverage/arg=speconly.golden +0 -9
- package/engine/testdata/golden/TestParityCoverage.golden +0 -1
- package/engine/testdata/golden/TestParityCursor/bare.golden +0 -3
- package/engine/testdata/golden/TestParityCursor/full-afk.golden +0 -6
- package/engine/testdata/golden/TestParityCursor/full-hitl.golden +0 -5
- package/engine/testdata/golden/TestParityCursor/no-active.golden +0 -1
- package/engine/testdata/golden/TestParityCursor/red.golden +0 -5
- package/engine/testdata/golden/TestParityCursor/zerogates.golden +0 -5
- package/engine/testdata/golden/TestParityDoubtCoverage/arg=doubted.golden +0 -2
- package/engine/testdata/golden/TestParityDoubtCoverage/arg=ghost.golden +0 -2
- package/engine/testdata/golden/TestParityDoubtCoverage/arg=missing.golden +0 -3
- package/engine/testdata/golden/TestParityDoubtCoverage/arg=nodoubt.golden +0 -4
- package/engine/testdata/golden/TestParityDoubtCoverage/arg=nolog.golden +0 -2
- package/engine/testdata/golden/TestParityDoubtCoverage/arg=nowright.golden +0 -2
- package/engine/testdata/golden/TestParityDoubtCoverage.golden +0 -1
- package/engine/testdata/golden/TestParityMutationGate/active-slug.golden +0 -3
- package/engine/testdata/golden/TestParityMutationGate/explicit-slug.golden +0 -3
- package/engine/testdata/golden/TestParityMutationGate/ghost.golden +0 -1
- package/engine/testdata/golden/TestParityOrientSilentPath.golden +0 -1
- package/engine/testdata/golden/TestParityReconcile/bad-mode.golden +0 -1
- package/engine/testdata/golden/TestParityReconcile/check-clean/snapshot.golden +0 -2
- package/engine/testdata/golden/TestParityReconcile/check-clean.golden +0 -2
- package/engine/testdata/golden/TestParityReconcile/check-no-base.golden +0 -1
- package/engine/testdata/golden/TestParityReconcile/check-no-claimed/snapshot.golden +0 -2
- package/engine/testdata/golden/TestParityReconcile/check-violation/snapshot.golden +0 -2
- package/engine/testdata/golden/TestParityReconcile/check-violation.golden +0 -1
- package/engine/testdata/golden/TestParityReconcile/close-window/snapshot.golden +0 -2
- package/engine/testdata/golden/TestParityReconcile/close-window.golden +0 -3
- package/engine/testdata/golden/TestParityReconcile/not-git.golden +0 -1
- package/engine/testdata/golden/TestParityReconcile/snapshot/snapshot.golden +0 -2
- package/engine/testdata/golden/TestParityReconcile/snapshot-no-allowlist.golden +0 -1
- package/engine/testdata/golden/TestParityReconcile/snapshot.golden +0 -2
- package/engine/testdata/golden/TestParityRedwatch/fail-writes-red.golden +0 -2
- package/engine/testdata/golden/TestParityRedwatch/non-bash-tool.golden +0 -1
- package/engine/testdata/golden/TestParityRedwatch/non-test-command.golden +0 -1
- package/engine/testdata/golden/TestParityRedwatch/pass-clears-red.golden +0 -1
- package/engine/testdata/golden/TestParityResolve/next-qid.golden +0 -2
- package/engine/testdata/golden/TestParityReviewerReadonly/agent-required-devrites-agent-denies.golden +0 -2
- package/engine/testdata/golden/TestParityReviewerReadonly/agent-required-non-devrites-allows.golden +0 -1
- package/engine/testdata/golden/TestParityReviewerReadonly/agent-required-subagent-type-only-allows.golden +0 -1
- package/engine/testdata/golden/TestParityReviewerReadonly/enforce-deny-git-commit.golden +0 -2
- package/engine/testdata/golden/TestParityReviewerReadonly/enforce-deny-mutating.golden +0 -2
- package/engine/testdata/golden/TestParityReviewerReadonly/non-bash-tool.golden +0 -1
- package/engine/testdata/golden/TestParityReviewerReadonly/non-tool-input.golden +0 -1
- package/engine/testdata/golden/TestParityReviewerReadonly/observe-mutating-silent.golden +0 -1
- package/engine/testdata/golden/TestParityReviewerReadonly/safe-bash-command.golden +0 -1
- package/engine/testdata/golden/TestParitySpecValidate/arg=dup.golden +0 -1
- package/engine/testdata/golden/TestParitySpecValidate/arg=empty.golden +0 -1
- package/engine/testdata/golden/TestParitySpecValidate/arg=flat.golden +0 -2
- package/engine/testdata/golden/TestParitySpecValidate/arg=nonexistent.golden +0 -1
- package/engine/testdata/golden/TestParitySpecValidate/arg=noscenario.golden +0 -1
- package/engine/testdata/golden/TestParitySpecValidate/arg=noshall.golden +0 -1
- package/engine/testdata/golden/TestParitySpecValidate/arg=nothen.golden +0 -1
- package/engine/testdata/golden/TestParitySpecValidate/arg=valid/spec.md.golden +0 -2
- package/engine/testdata/golden/TestParitySpecValidate/arg=valid.golden +0 -2
- package/engine/testdata/golden/TestParitySpecValidate.golden +0 -1
- package/engine/testdata/golden/TestParityStatusline/full-afk.golden +0 -2
- package/engine/testdata/golden/TestParityStatusline/full-hitl.golden +0 -2
- package/engine/testdata/golden/TestParityStatusline/no-active.golden +0 -1
- package/engine/testdata/golden/TestParityStatusline/nophase.golden +0 -2
- package/engine/testdata/golden/TestParityStatusline/red.golden +0 -2
- package/engine/testdata/golden/TestParityStuckCheck/bad-cmd.golden +0 -1
- package/engine/testdata/golden/TestParityStuckCheck/custom-window-2.golden +0 -2
- package/engine/testdata/golden/TestParityStuckCheck/dominant.golden +0 -2
- package/engine/testdata/golden/TestParityStuckCheck/few.golden +0 -2
- package/engine/testdata/golden/TestParityStuckCheck/ghost.golden +0 -2
- package/engine/testdata/golden/TestParityStuckCheck/identical.golden +0 -2
- package/engine/testdata/golden/TestParityStuckCheck/no-cmd.golden +0 -1
- package/engine/testdata/golden/TestParityStuckCheck/no-slug.golden +0 -1
- package/engine/testdata/golden/TestParityStuckCheck/nolog.golden +0 -2
- package/engine/testdata/golden/TestParityStuckCheck/pingpong.golden +0 -2
- package/engine/testdata/golden/TestParityStuckCheck/varied.golden +0 -2
- package/engine/testdata/golden/TestParityStuckCheck/window-04-identical.golden +0 -2
- package/engine/testdata/golden/TestParityStuckCheck/window-2.5-varied4.golden +0 -2
- package/engine/testdata/golden/TestParityStuckCheck/window-4x-varied4.golden +0 -2
- package/engine/testdata/golden/TestParityStuckCheck/window-leadspace-varied4.golden +0 -2
- package/engine/testdata/golden/TestParityStuckCheck/window-plus4-identical.golden +0 -2
- package/engine/testdata/golden/TestParitySubagentOrient/devrites-agent-subagent-type-key.golden +0 -2
- package/engine/testdata/golden/TestParitySubagentOrient/devrites-agent.golden +0 -2
- package/engine/testdata/golden/TestParitySubagentOrient/garbage-input.golden +0 -1
- package/engine/testdata/golden/TestParitySubagentOrient/non-devrites-agent.golden +0 -1
- package/engine/testdata/golden/TestParityTestIntegrity/assertion-dropped.golden +0 -1
- package/engine/testdata/golden/TestParityTestIntegrity/clean.golden +0 -2
- package/engine/testdata/golden/TestParityTestIntegrity/deleted.golden +0 -1
- package/engine/testdata/golden/TestParityTestIntegrity/ghost-workspace.golden +0 -1
- package/engine/testdata/golden/TestParityTestIntegrity/not-git.golden +0 -1
- package/engine/testdata/golden/TestParityTestIntegrity/skip-added.golden +0 -1
- package/engine/testdata/golden/TestParityTickAfk/budget1/state.md.golden +0 -1
- package/engine/testdata/golden/TestParityTickAfk/budget1.golden +0 -2
- package/engine/testdata/golden/TestParityTickAfk/budget3/state.md.golden +0 -5
- package/engine/testdata/golden/TestParityTickAfk/budget3.golden +0 -2
- package/engine/testdata/golden/TestParityTickAfk/bulletPipe/state.md.golden +0 -1
- package/engine/testdata/golden/TestParityTickAfk/bulletPipe.golden +0 -2
- package/engine/testdata/golden/TestParityTickAfk/missingField/state.md.golden +0 -3
- package/engine/testdata/golden/TestParityTickAfk/missingField.golden +0 -2
- package/engine/testdata/golden/TestParityTickAfk/missingFile.golden +0 -1
- package/engine/testdata/golden/TestParityTickAfk/nonNumeric/state.md.golden +0 -1
- package/engine/testdata/golden/TestParityTickAfk/nonNumeric.golden +0 -1
- package/engine/testdata/golden/TestParityTickAfk/none/state.md.golden +0 -1
- package/engine/testdata/golden/TestParityTickAfk/none.golden +0 -2
- package/engine/testdata/golden/TestParityWrightScope/agent-required-non-wright.golden +0 -1
- package/engine/testdata/golden/TestParityWrightScope/devrites-edit-denied.golden +0 -2
- package/engine/testdata/golden/TestParityWrightScope/in-scope-allowed.golden +0 -1
- package/engine/testdata/golden/TestParityWrightScope/non-edit-tool.golden +0 -1
- package/engine/testdata/golden/TestParityWrightScope/out-of-scope-enforce-denies.golden +0 -2
- package/engine/testdata/golden/TestParityWrightScope/out-of-scope-observe-silent.golden +0 -1
- package/engine/testdata/golden/TestSpecSkeleton/missing-some.golden +0 -2
- package/engine/testdata/golden/TestSpecSkeleton/present-all.golden +0 -2
- package/engine/testdata/golden/TestStuckLogHashParity.golden +0 -1
- package/engine/tests/adr_0006_clock_seam_test.go +0 -36
- package/engine/tests/budget_test.go +0 -88
- package/engine/tests/canonical_ac_ids_test.go +0 -44
- package/engine/tests/concurrency_cli_test.go +0 -131
- package/engine/tests/conventions_test.go +0 -106
- package/engine/tests/doctor_cli_test.go +0 -223
- package/engine/tests/forge_cli_test.go +0 -463
- package/engine/tests/hook_test.go +0 -2778
- package/engine/tests/hooks_io_test.go +0 -309
- package/engine/tests/json_contract_test.go +0 -224
- package/engine/tests/lib_parity_test.go +0 -930
- package/engine/tests/migrate_cli_test.go +0 -195
- package/engine/tests/parity_analyze_test.go +0 -55
- package/engine/tests/parity_buildreadiness_test.go +0 -199
- package/engine/tests/parity_learnings_test.go +0 -89
- package/engine/tests/parity_mutationgate_test.go +0 -36
- package/engine/tests/parity_reconcile_test.go +0 -94
- package/engine/tests/parity_testintegrity_test.go +0 -65
- package/engine/tests/parity_tickafk_test.go +0 -83
- package/engine/validatepack.go +0 -192
- package/engine/validatepack_test.go +0 -79
- package/engine/validatepackskills.go +0 -181
- package/engine/validatepackskills_test.go +0 -171
- package/pack/.claude/agents/devrites-forge-judge.md +0 -118
- package/pack/.claude/skills/devrites-lib/reference/model-tiers.md +0 -44
- package/pack/.claude/skills/devrites-refresh-indexes/SKILL.md +0 -52
- package/pack/.claude/skills/rite-build/reference/evidence-standard.md +0 -45
- package/pack/.claude/skills/rite-build/reference/forge.md +0 -210
- package/pack/.claude/skills/rite-seal/reference/conventions-ledger.md +0 -60
- package/pack/.claude/skills/rite-ship/reference/adr-promotion.md +0 -9
- package/pack/.claude/skills/rite-ship/reference/ledger.md +0 -56
- package/pack/generated/claude/agents/devrites-forge-judge.md +0 -118
- package/pack/generated/claude/skills/devrites-lib/reference/model-tiers.md +0 -44
- package/pack/generated/claude/skills/devrites-refresh-indexes/SKILL.md +0 -52
- package/pack/generated/claude/skills/rite-build/reference/evidence-standard.md +0 -45
- package/pack/generated/claude/skills/rite-build/reference/forge.md +0 -210
- package/pack/generated/claude/skills/rite-seal/reference/conventions-ledger.md +0 -60
- package/pack/generated/claude/skills/rite-ship/reference/adr-promotion.md +0 -9
- package/pack/generated/claude/skills/rite-ship/reference/ledger.md +0 -56
- package/pack/generated/codex/agents/devrites-forge-judge.toml +0 -128
- package/pack/generated/codex/hooks.json +0 -185
- package/pack/generated/codex/skills/devrites-api-interface/agents/openai.yaml +0 -2
- package/pack/generated/codex/skills/devrites-audit/agents/openai.yaml +0 -2
- package/pack/generated/codex/skills/devrites-browser-proof/agents/openai.yaml +0 -2
- package/pack/generated/codex/skills/devrites-debug-recovery/agents/openai.yaml +0 -2
- package/pack/generated/codex/skills/devrites-doubt/agents/openai.yaml +0 -2
- package/pack/generated/codex/skills/devrites-frontend-craft/agents/openai.yaml +0 -2
- package/pack/generated/codex/skills/devrites-interview/agents/openai.yaml +0 -2
- package/pack/generated/codex/skills/devrites-lib/reference/model-tiers.md +0 -44
- package/pack/generated/codex/skills/devrites-prose-craft/agents/openai.yaml +0 -2
- package/pack/generated/codex/skills/devrites-refresh-indexes/SKILL.md +0 -71
- package/pack/generated/codex/skills/devrites-refresh-indexes/agents/openai.yaml +0 -2
- package/pack/generated/codex/skills/devrites-source-driven/agents/openai.yaml +0 -2
- package/pack/generated/codex/skills/devrites-ux-shape/agents/openai.yaml +0 -2
- package/pack/generated/codex/skills/rite-build/reference/evidence-standard.md +0 -45
- package/pack/generated/codex/skills/rite-build/reference/forge.md +0 -210
- package/pack/generated/codex/skills/rite-seal/reference/conventions-ledger.md +0 -60
- package/pack/generated/codex/skills/rite-ship/reference/adr-promotion.md +0 -9
- package/pack/generated/codex/skills/rite-ship/reference/ledger.md +0 -56
- package/scripts/build-binaries.sh +0 -75
- package/scripts/build-release-tarball.sh +0 -105
- package/scripts/check-authority-drift.py +0 -125
- package/scripts/check-cross-refs.py +0 -139
- package/scripts/check-generated-skill-budget.mjs +0 -42
- package/scripts/check-instruction-size-baseline.mjs +0 -88
- package/scripts/check-invocation-integrity.py +0 -115
- package/scripts/check-no-global-writes.sh +0 -66
- package/scripts/check-no-personal-paths.py +0 -50
- package/scripts/check-npm-audit.mjs +0 -110
- package/scripts/check-reference-governance.mjs +0 -83
- package/scripts/check-reply-contract.sh +0 -64
- package/scripts/check-rule-uniqueness.sh +0 -45
- package/scripts/devrites-detect.sh +0 -176
- package/scripts/grade-feature.sh +0 -204
- package/scripts/live-hosts/agent-result.schema.json +0 -231
- package/scripts/live-hosts/claude.sh +0 -87
- package/scripts/live-hosts/codex.sh +0 -85
- package/scripts/live-hosts/common.sh +0 -113
- package/scripts/live-hosts/fake-host.py +0 -257
- package/scripts/live-hosts/host-transport.py +0 -286
- package/scripts/npm-audit-exceptions.json +0 -26
- package/scripts/pin.sh +0 -249
- package/scripts/release-check.sh +0 -75
- package/scripts/run-agent-contract-evals.py +0 -1380
- package/scripts/run-behavioral-evals.sh +0 -196
- package/scripts/run-evals.sh +0 -132
- package/scripts/run-live-behavioral-evals.py +0 -1310
- package/scripts/run-outcome-evals.sh +0 -454
- package/scripts/run-routing-evals.py +0 -342
- package/scripts/run-tests.mjs +0 -232
- package/scripts/scan-pack-security.py +0 -209
- package/scripts/scan-supply-chain-iocs.py +0 -127
- package/scripts/skill-pruning-audit.mjs +0 -121
- package/scripts/skills-inventory.mjs +0 -125
- package/scripts/supply-chain-iocs.json +0 -11
- package/scripts/sync-version.sh +0 -54
- package/scripts/validate-agent-composition.py +0 -57
- package/scripts/validate-command-parity.py +0 -70
- package/scripts/validate-frontmatter.py +0 -218
- package/scripts/validate-skill-anatomy.py +0 -139
- package/scripts/validate-workflow-security.py +0 -184
- package/scripts/validate-workspace-schema.py +0 -800
- package/scripts/validate.sh +0 -354
- package/scripts/workflow_schema.py +0 -69
- /package/engine/testdata/fixtures/basic/devrites-root/{features → work}/auth-tokens/decisions.md +0 -0
- /package/engine/testdata/fixtures/basic/devrites-root/{features → work}/auth-tokens/plan.md +0 -0
- /package/engine/testdata/fixtures/basic/devrites-root/{features → work}/auth-tokens/spec.md +0 -0
- /package/engine/testdata/fixtures/basic/devrites-root/{features → work}/auth-tokens/tasks.md +0 -0
- /package/engine/testdata/fixtures/basic/devrites-root/{features → work}/search-ranking/spec.md +0 -0
|
@@ -1,2778 +0,0 @@
|
|
|
1
|
-
package main_test
|
|
2
|
-
|
|
3
|
-
// CLI coverage for Issue 03's dual-harness `hook orient` behavior and Issue 04's
|
|
4
|
-
// `hook stop-gate`. These tests run the binary against a fixture workspace and
|
|
5
|
-
// check stdout and exit status. parity_test.go owns the parity oracle.
|
|
6
|
-
|
|
7
|
-
import (
|
|
8
|
-
"bytes"
|
|
9
|
-
"crypto/sha256"
|
|
10
|
-
"encoding/hex"
|
|
11
|
-
"encoding/json"
|
|
12
|
-
"fmt"
|
|
13
|
-
"os"
|
|
14
|
-
"path/filepath"
|
|
15
|
-
"strconv"
|
|
16
|
-
"strings"
|
|
17
|
-
"testing"
|
|
18
|
-
"time"
|
|
19
|
-
)
|
|
20
|
-
|
|
21
|
-
// writeActive points the workspace's ACTIVE pointer at slug.
|
|
22
|
-
func writeActive(t *testing.T, root, slug string) {
|
|
23
|
-
t.Helper()
|
|
24
|
-
if err := os.WriteFile(filepath.Join(root, "ACTIVE"), []byte(slug+"\n"), 0o644); err != nil {
|
|
25
|
-
t.Fatal(err)
|
|
26
|
-
}
|
|
27
|
-
}
|
|
28
|
-
|
|
29
|
-
// parseAdditionalContext decodes a SessionStart hook envelope and returns the
|
|
30
|
-
// injected additionalContext, failing the test if the shape is wrong.
|
|
31
|
-
func parseAdditionalContext(t *testing.T, stdout string) string {
|
|
32
|
-
t.Helper()
|
|
33
|
-
var env struct {
|
|
34
|
-
HookSpecificOutput struct {
|
|
35
|
-
HookEventName string `json:"hookEventName"`
|
|
36
|
-
AdditionalContext string `json:"additionalContext"`
|
|
37
|
-
} `json:"hookSpecificOutput"`
|
|
38
|
-
}
|
|
39
|
-
if err := json.Unmarshal([]byte(strings.TrimSpace(stdout)), &env); err != nil {
|
|
40
|
-
t.Fatalf("stdout is not a valid hook envelope: %v\n%s", err, stdout)
|
|
41
|
-
}
|
|
42
|
-
if env.HookSpecificOutput.HookEventName != "SessionStart" {
|
|
43
|
-
t.Errorf("hookEventName = %q, want SessionStart", env.HookSpecificOutput.HookEventName)
|
|
44
|
-
}
|
|
45
|
-
return env.HookSpecificOutput.AdditionalContext
|
|
46
|
-
}
|
|
47
|
-
|
|
48
|
-
func TestHookOrientActiveFeatureEmitsDigest(t *testing.T) {
|
|
49
|
-
for _, h := range []string{"claude", "codex"} {
|
|
50
|
-
h := h
|
|
51
|
-
t.Run(h, func(t *testing.T) {
|
|
52
|
-
root := newWorkspace(t)
|
|
53
|
-
writeActive(t, root, "auth-tokens")
|
|
54
|
-
out, errOut, code := runDevrites(t, root, "hook", "orient", "--harness="+h)
|
|
55
|
-
if code != 0 {
|
|
56
|
-
t.Fatalf("exit = %d, want 0 (stderr: %s)", code, errOut)
|
|
57
|
-
}
|
|
58
|
-
ctx := parseAdditionalContext(t, out)
|
|
59
|
-
for _, want := range []string{
|
|
60
|
-
`feature "auth-tokens"`,
|
|
61
|
-
"phase: build",
|
|
62
|
-
"result: incomplete (missing: tasks)",
|
|
63
|
-
"host-specific DevRites command",
|
|
64
|
-
} {
|
|
65
|
-
if !strings.Contains(ctx, want) {
|
|
66
|
-
t.Errorf("additionalContext missing %q\n--- got ---\n%s", want, ctx)
|
|
67
|
-
}
|
|
68
|
-
}
|
|
69
|
-
})
|
|
70
|
-
}
|
|
71
|
-
}
|
|
72
|
-
|
|
73
|
-
func TestHookOrientNoActiveFeatureNudgesOnceThenSilent(t *testing.T) {
|
|
74
|
-
root := newWorkspace(t) // fixture has no ACTIVE pointer
|
|
75
|
-
out, errOut, code := runDevrites(t, root, "hook", "orient", "--harness=claude")
|
|
76
|
-
if code != 0 {
|
|
77
|
-
t.Fatalf("exit = %d, want 0 (stderr: %s)", code, errOut)
|
|
78
|
-
}
|
|
79
|
-
ctx := parseAdditionalContext(t, out)
|
|
80
|
-
if !strings.Contains(ctx, "no feature is active") || !strings.Contains(ctx, "/rite") {
|
|
81
|
-
t.Errorf("first blank-slate session should nudge a starting rite, got %q", ctx)
|
|
82
|
-
}
|
|
83
|
-
if _, err := os.Stat(filepath.Join(root, ".first-run-shown")); err != nil {
|
|
84
|
-
t.Fatalf("first-run marker not written: %v", err)
|
|
85
|
-
}
|
|
86
|
-
out, errOut, code = runDevrites(t, root, "hook", "orient", "--harness=claude")
|
|
87
|
-
if code != 0 {
|
|
88
|
-
t.Fatalf("second run exit = %d, want 0 (stderr: %s)", code, errOut)
|
|
89
|
-
}
|
|
90
|
-
if strings.TrimSpace(out) != "" {
|
|
91
|
-
t.Errorf("second run stdout = %q, want silent once the marker exists", out)
|
|
92
|
-
}
|
|
93
|
-
}
|
|
94
|
-
|
|
95
|
-
func TestHookOrientStaleActivePointerIsSilent(t *testing.T) {
|
|
96
|
-
root := newWorkspace(t)
|
|
97
|
-
writeActive(t, root, "does-not-exist")
|
|
98
|
-
out, _, code := runDevrites(t, root, "hook", "orient", "--harness=claude")
|
|
99
|
-
if code != 0 {
|
|
100
|
-
t.Fatalf("exit = %d, want 0 (a stale pointer must not wedge the session)", code)
|
|
101
|
-
}
|
|
102
|
-
if strings.TrimSpace(out) != "" {
|
|
103
|
-
t.Errorf("stdout = %q, want silent for a stale ACTIVE pointer", out)
|
|
104
|
-
}
|
|
105
|
-
}
|
|
106
|
-
|
|
107
|
-
func TestHookOrientNonDevRitesDirIsSilent(t *testing.T) {
|
|
108
|
-
// Point at a directory with no .devrites: fail-open: silent, exit 0.
|
|
109
|
-
empty := t.TempDir()
|
|
110
|
-
out, _, code := runDevrites(t, empty, "hook", "orient", "--harness=claude")
|
|
111
|
-
if code != 0 {
|
|
112
|
-
t.Fatalf("exit = %d, want 0 outside a DevRites workspace", code)
|
|
113
|
-
}
|
|
114
|
-
if strings.TrimSpace(out) != "" {
|
|
115
|
-
t.Errorf("stdout = %q, want silent outside a workspace", out)
|
|
116
|
-
}
|
|
117
|
-
}
|
|
118
|
-
|
|
119
|
-
func TestHookUnknownHarnessExitsUsage(t *testing.T) {
|
|
120
|
-
root := newWorkspace(t)
|
|
121
|
-
_, errOut, code := runDevrites(t, root, "hook", "orient", "--harness=bogus")
|
|
122
|
-
if code != 2 {
|
|
123
|
-
t.Fatalf("exit = %d, want 2 for an unknown harness", code)
|
|
124
|
-
}
|
|
125
|
-
if !strings.Contains(errOut, "unknown harness") {
|
|
126
|
-
t.Errorf("stderr = %q, want it to name the unknown harness", errOut)
|
|
127
|
-
}
|
|
128
|
-
}
|
|
129
|
-
|
|
130
|
-
func TestHookMissingHarnessExitsUsage(t *testing.T) {
|
|
131
|
-
root := newWorkspace(t)
|
|
132
|
-
if _, _, code := runDevrites(t, root, "hook", "orient"); code != 2 {
|
|
133
|
-
t.Fatalf("exit = %d, want 2 when --harness is absent", code)
|
|
134
|
-
}
|
|
135
|
-
}
|
|
136
|
-
|
|
137
|
-
// --- Issue 09: allow ---
|
|
138
|
-
|
|
139
|
-
func TestHookAllowApprovesReadonlySubcommand(t *testing.T) {
|
|
140
|
-
root := newWorkspace(t)
|
|
141
|
-
for _, cmd := range []string{
|
|
142
|
-
"devrites-engine preamble auth-tokens",
|
|
143
|
-
"devrites-engine progress",
|
|
144
|
-
"devrites-engine readiness auth-tokens",
|
|
145
|
-
"devrites-engine evidence-fresh",
|
|
146
|
-
"devrites-engine check-acceptance .devrites/work/auth-tokens",
|
|
147
|
-
"devrites-engine doubt-coverage auth-tokens",
|
|
148
|
-
"devrites-engine footprint roster auth-tokens",
|
|
149
|
-
"devrites-engine footprint render auth-tokens",
|
|
150
|
-
"devrites-engine ledger diff .devrites/work/auth-tokens",
|
|
151
|
-
"devrites-engine ledger list",
|
|
152
|
-
"devrites-engine ledger show auth",
|
|
153
|
-
"command -v devrites-engine && devrites-engine check-acceptance auth-tokens",
|
|
154
|
-
} {
|
|
155
|
-
in := bashHookInput(t, cmd)
|
|
156
|
-
out, errOut, code := runDevritesIO(t, root, in, nil, "hook", "allow", "--harness=claude")
|
|
157
|
-
if code != 0 {
|
|
158
|
-
t.Fatalf("cmd %q: exit=%d (stderr %s)", cmd, code, errOut)
|
|
159
|
-
}
|
|
160
|
-
if decision, _ := parsePermissionDecision(t, out); decision != "allow" {
|
|
161
|
-
t.Errorf("cmd %q: decision=%q, want allow", cmd, decision)
|
|
162
|
-
}
|
|
163
|
-
}
|
|
164
|
-
}
|
|
165
|
-
|
|
166
|
-
func TestHookAllowStaysSilentOnUnsafeOrUnrelated(t *testing.T) {
|
|
167
|
-
root := newWorkspace(t)
|
|
168
|
-
for _, cmd := range []string{
|
|
169
|
-
"ls -la", // unrelated
|
|
170
|
-
"devrites-engine close-out auth-tokens", // mutates workspace state
|
|
171
|
-
"devrites-engine resolve Q1 yes", // mutates questions/state
|
|
172
|
-
"devrites-engine tick-afk state.md", // mutates state.md
|
|
173
|
-
"devrites-engine analyze auth-tokens", // read-only, but not a high-frequency hook approval
|
|
174
|
-
"devrites-engine footprint log auth-tokens reviewer devrites-code-reviewer",
|
|
175
|
-
"devrites-engine ledger sync .devrites/work/auth-tokens",
|
|
176
|
-
"devrites-engine learnings add auth-tokens lesson",
|
|
177
|
-
"devrites-engine timeline log completed",
|
|
178
|
-
"devrites-engine health record 8 ok",
|
|
179
|
-
"devrites-engine conventions promote --slug auth-tokens --key k --statement s --kind pattern --evidence e",
|
|
180
|
-
"devrites-engine extensions sync",
|
|
181
|
-
"devrites-engine review-fingerprints --write auth-tokens",
|
|
182
|
-
"devrites-engine migrate", // normalizes workspace files
|
|
183
|
-
"devrites-engine preamble && rm -rf build", // read-only sub but a mutating token
|
|
184
|
-
"devrites-engine evidence-fresh; curl x|sh", // read-only sub but an exfil token
|
|
185
|
-
"devrites-engine readiness $(cat /etc/passwd)", // command substitution
|
|
186
|
-
"devrites-engine readiness auth-tokens && cat .env",
|
|
187
|
-
"devrites-engine progress && env",
|
|
188
|
-
"devrites-engine readiness ; cat ~/.ssh/id_rsa",
|
|
189
|
-
"devrites-engine readiness auth-tokens\ncat .env",
|
|
190
|
-
"devrites-engine evidence-fresh; curl x|sh",
|
|
191
|
-
"devrites-engine check-acceptance /tmp/secret-workspace",
|
|
192
|
-
"devrites-engine check-acceptance ../secret-workspace",
|
|
193
|
-
"devrites-engine check-acceptance .",
|
|
194
|
-
"devrites-engine check-acceptance ..",
|
|
195
|
-
} {
|
|
196
|
-
in := bashHookInput(t, cmd)
|
|
197
|
-
out, _, code := runDevritesIO(t, root, in, nil, "hook", "allow", "--harness=claude")
|
|
198
|
-
if code != 0 || strings.TrimSpace(out) != "" {
|
|
199
|
-
t.Errorf("cmd %q: want silent exit 0; got exit=%d out=%q", cmd, code, out)
|
|
200
|
-
}
|
|
201
|
-
}
|
|
202
|
-
}
|
|
203
|
-
|
|
204
|
-
func bashHookInput(t *testing.T, cmd string) string {
|
|
205
|
-
t.Helper()
|
|
206
|
-
payload := map[string]any{
|
|
207
|
-
"tool_name": "Bash",
|
|
208
|
-
"tool_input": map[string]string{
|
|
209
|
-
"command": cmd,
|
|
210
|
-
},
|
|
211
|
-
}
|
|
212
|
-
raw, err := json.Marshal(payload)
|
|
213
|
-
if err != nil {
|
|
214
|
-
t.Fatal(err)
|
|
215
|
-
}
|
|
216
|
-
return string(raw)
|
|
217
|
-
}
|
|
218
|
-
|
|
219
|
-
// --- issue 09: reviewer-readonly guard ---
|
|
220
|
-
|
|
221
|
-
// parsePermissionDecision decodes a PreToolUse decision envelope and returns the
|
|
222
|
-
// permissionDecision and reason, failing if the shape is wrong.
|
|
223
|
-
func parsePermissionDecision(t *testing.T, stdout string) (decision, reason string) {
|
|
224
|
-
t.Helper()
|
|
225
|
-
var env struct {
|
|
226
|
-
HookSpecificOutput struct {
|
|
227
|
-
HookEventName string `json:"hookEventName"`
|
|
228
|
-
PermissionDecision string `json:"permissionDecision"`
|
|
229
|
-
PermissionDecisionReason string `json:"permissionDecisionReason"`
|
|
230
|
-
} `json:"hookSpecificOutput"`
|
|
231
|
-
}
|
|
232
|
-
if err := json.Unmarshal([]byte(strings.TrimSpace(stdout)), &env); err != nil {
|
|
233
|
-
t.Fatalf("stdout is not a valid PreToolUse decision: %v\n%s", err, stdout)
|
|
234
|
-
}
|
|
235
|
-
if env.HookSpecificOutput.HookEventName != "PreToolUse" {
|
|
236
|
-
t.Errorf("hookEventName = %q, want PreToolUse", env.HookSpecificOutput.HookEventName)
|
|
237
|
-
}
|
|
238
|
-
return env.HookSpecificOutput.PermissionDecision, env.HookSpecificOutput.PermissionDecisionReason
|
|
239
|
-
}
|
|
240
|
-
|
|
241
|
-
func parseStopDecision(t *testing.T, stdout string) (decision, reason string) {
|
|
242
|
-
t.Helper()
|
|
243
|
-
var env struct {
|
|
244
|
-
Decision string `json:"decision"`
|
|
245
|
-
Reason string `json:"reason"`
|
|
246
|
-
}
|
|
247
|
-
if err := json.Unmarshal([]byte(strings.TrimSpace(stdout)), &env); err != nil {
|
|
248
|
-
t.Fatalf("stdout is not a valid Stop decision: %v\n%s", err, stdout)
|
|
249
|
-
}
|
|
250
|
-
return env.Decision, env.Reason
|
|
251
|
-
}
|
|
252
|
-
|
|
253
|
-
func TestHookReviewerReadonlyEnforceDeniesMutatingBash(t *testing.T) {
|
|
254
|
-
for _, h := range []string{"claude", "codex"} {
|
|
255
|
-
h := h
|
|
256
|
-
t.Run(h, func(t *testing.T) {
|
|
257
|
-
root := newWorkspace(t)
|
|
258
|
-
in := `{"tool_name":"Bash","tool_input":{"command":"rm -rf build"}}`
|
|
259
|
-
out, errOut, code := runDevritesIO(t, root, in, []string{"DEVRITES_REVIEWER_RO=enforce"},
|
|
260
|
-
"hook", "reviewer-readonly", "--harness="+h)
|
|
261
|
-
if code != 0 {
|
|
262
|
-
t.Fatalf("exit = %d, want 0 (stderr: %s)", code, errOut)
|
|
263
|
-
}
|
|
264
|
-
decision, reason := parsePermissionDecision(t, out)
|
|
265
|
-
if decision != "deny" {
|
|
266
|
-
t.Errorf("permissionDecision = %q, want deny", decision)
|
|
267
|
-
}
|
|
268
|
-
if !strings.Contains(reason, "reviewers are read-only") {
|
|
269
|
-
t.Errorf("reason %q missing the read-only explanation", reason)
|
|
270
|
-
}
|
|
271
|
-
})
|
|
272
|
-
}
|
|
273
|
-
}
|
|
274
|
-
|
|
275
|
-
func TestHookReviewerReadonlyAllowsSafeBash(t *testing.T) {
|
|
276
|
-
root := newWorkspace(t)
|
|
277
|
-
for _, command := range []string{
|
|
278
|
-
"grep -rn foo .",
|
|
279
|
-
`cd "` + filepath.Dir(root) + `" && git diff --binary --full-index --no-renames HEAD HEAD --`,
|
|
280
|
-
} {
|
|
281
|
-
in := hookPayload(t, map[string]any{
|
|
282
|
-
"tool_name": "Bash",
|
|
283
|
-
"tool_input": map[string]any{"command": command},
|
|
284
|
-
})
|
|
285
|
-
out, _, code := runDevritesIO(t, root, in, []string{"DEVRITES_REVIEWER_RO=enforce"},
|
|
286
|
-
"hook", "reviewer-readonly", "--harness=claude")
|
|
287
|
-
if code != 0 {
|
|
288
|
-
t.Fatalf("%q exit = %d, want 0", command, code)
|
|
289
|
-
}
|
|
290
|
-
if strings.TrimSpace(out) != "" {
|
|
291
|
-
t.Errorf("%q stdout = %q, want silent for a read-only command", command, out)
|
|
292
|
-
}
|
|
293
|
-
}
|
|
294
|
-
}
|
|
295
|
-
|
|
296
|
-
func TestHookReviewerReadonlyRejectsWriteCapableInspectionFlags(t *testing.T) {
|
|
297
|
-
root := newWorkspace(t)
|
|
298
|
-
env := []string{
|
|
299
|
-
"DEVRITES_AGENT_RUN=1",
|
|
300
|
-
"DEVRITES_ACTIVE_AGENT=devrites-code-reviewer",
|
|
301
|
-
}
|
|
302
|
-
for _, command := range []string{
|
|
303
|
-
"sed --in-place=.bak s/a/b/ src/app.go",
|
|
304
|
-
"sort -o src/app.go input.txt",
|
|
305
|
-
"find . -fls src/index.txt",
|
|
306
|
-
"git diff --output=src/diff.txt",
|
|
307
|
-
} {
|
|
308
|
-
in := hookPayload(t, map[string]any{
|
|
309
|
-
"tool_name": "Bash",
|
|
310
|
-
"tool_input": map[string]any{"command": command},
|
|
311
|
-
})
|
|
312
|
-
out, errOut, code := runDevritesIO(t, root, in, env,
|
|
313
|
-
"hook", "reviewer-readonly", "--harness=codex")
|
|
314
|
-
if code != 0 {
|
|
315
|
-
t.Fatalf("%q exit=%d stderr=%q", command, code, errOut)
|
|
316
|
-
}
|
|
317
|
-
if decision, _ := parsePermissionDecision(t, out); decision != "deny" {
|
|
318
|
-
t.Errorf("write-capable inspection command was not denied: %q", command)
|
|
319
|
-
}
|
|
320
|
-
}
|
|
321
|
-
}
|
|
322
|
-
|
|
323
|
-
func TestHookReviewerReadonlyNonBashIsSilent(t *testing.T) {
|
|
324
|
-
root := newWorkspace(t)
|
|
325
|
-
in := `{"tool_name":"Read","tool_input":{"file_path":"secret.txt"}}`
|
|
326
|
-
out, _, code := runDevritesIO(t, root, in, []string{"DEVRITES_REVIEWER_RO=enforce"},
|
|
327
|
-
"hook", "reviewer-readonly", "--harness=claude")
|
|
328
|
-
if code != 0 || strings.TrimSpace(out) != "" {
|
|
329
|
-
t.Errorf("want silent exit 0 for a non-Bash tool; got exit=%d out=%q", code, out)
|
|
330
|
-
}
|
|
331
|
-
}
|
|
332
|
-
|
|
333
|
-
// In observe mode (the default) a mutating command is allowed but recorded, so the
|
|
334
|
-
// invariant is visible without gating in-progress work.
|
|
335
|
-
func TestHookReviewerReadonlyObserveLogsWouldBlock(t *testing.T) {
|
|
336
|
-
root := newWorkspace(t)
|
|
337
|
-
writeActive(t, root, "auth-tokens")
|
|
338
|
-
in := `{"tool_name":"Bash","tool_input":{"command":"git push origin main"}}`
|
|
339
|
-
out, _, code := runDevritesIO(t, root, in, nil, // no enforce env → observe
|
|
340
|
-
"hook", "reviewer-readonly", "--harness=claude")
|
|
341
|
-
if code != 0 {
|
|
342
|
-
t.Fatalf("exit = %d, want 0", code)
|
|
343
|
-
}
|
|
344
|
-
if strings.TrimSpace(out) != "" {
|
|
345
|
-
t.Errorf("stdout = %q, want silent in observe mode", out)
|
|
346
|
-
}
|
|
347
|
-
logPath := filepath.Join(root, "features", "auth-tokens", ".reviewer-ro.log")
|
|
348
|
-
raw, err := os.ReadFile(logPath)
|
|
349
|
-
if err != nil {
|
|
350
|
-
t.Fatalf("observe mode did not write the would-block log: %v", err)
|
|
351
|
-
}
|
|
352
|
-
if !strings.Contains(string(raw), "WOULD-BLOCK") || !strings.Contains(string(raw), "git push") {
|
|
353
|
-
t.Errorf("log = %q, want a WOULD-BLOCK record naming the command", raw)
|
|
354
|
-
}
|
|
355
|
-
}
|
|
356
|
-
|
|
357
|
-
// The bash hook's `read -r tool cmd agent_type` truncates the command at its
|
|
358
|
-
// first newline, so it only ever scans line 1: a latent bug. The Go port scans
|
|
359
|
-
// the whole command, so a mutating LATER line is denied. This asserts the
|
|
360
|
-
// deliberate hardening (documented on reviewerMutateRe); it is a Go-only test, not
|
|
361
|
-
// a parity case, because it is where the two are meant to diverge.
|
|
362
|
-
func TestHookReviewerReadonlyScansWholeMultilineCommand(t *testing.T) {
|
|
363
|
-
root := newWorkspace(t)
|
|
364
|
-
in := "{\"tool_name\":\"Bash\",\"tool_input\":{\"command\":\"cat notes.txt\\nsed -i s/a/b/ f\"}}"
|
|
365
|
-
out, errOut, code := runDevritesIO(t, root, in, []string{"DEVRITES_REVIEWER_RO=enforce"},
|
|
366
|
-
"hook", "reviewer-readonly", "--harness=claude")
|
|
367
|
-
if code != 0 {
|
|
368
|
-
t.Fatalf("exit = %d, want 0 (stderr: %s)", code, errOut)
|
|
369
|
-
}
|
|
370
|
-
if decision, _ := parsePermissionDecision(t, out); decision != "deny" {
|
|
371
|
-
t.Errorf("a multi-line command whose 2nd line mutates was not denied; decision = %q", decision)
|
|
372
|
-
}
|
|
373
|
-
}
|
|
374
|
-
|
|
375
|
-
// The agent-required gate reads only agent_type, matching the Bash hook's Node
|
|
376
|
-
// parser. A payload that carries the subagent name under subagent_type but not
|
|
377
|
-
// agent_type has no identity and is allowed, avoiding a false deny from aliases.
|
|
378
|
-
func TestHookReviewerReadonlyAgentRequiredIgnoresSubagentTypeAlias(t *testing.T) {
|
|
379
|
-
root := newWorkspace(t)
|
|
380
|
-
in := `{"tool_name":"Bash","tool_input":{"command":"rm -rf x"},"subagent_type":"devrites-code-reviewer"}`
|
|
381
|
-
out, _, code := runDevritesIO(t, root, in,
|
|
382
|
-
[]string{"DEVRITES_REVIEWER_RO=enforce", "DEVRITES_REVIEWER_AGENT_REQUIRED=1"},
|
|
383
|
-
"hook", "reviewer-readonly", "--harness=claude")
|
|
384
|
-
if code != 0 || strings.TrimSpace(out) != "" {
|
|
385
|
-
t.Errorf("want silent allow (no agent_type identity); got exit=%d out=%q", code, out)
|
|
386
|
-
}
|
|
387
|
-
}
|
|
388
|
-
|
|
389
|
-
func TestHookReviewerReadonlyAgentRequiredSkipsNonDevrites(t *testing.T) {
|
|
390
|
-
root := newWorkspace(t)
|
|
391
|
-
// A mutating command from a non-devrites agent is not the reviewer hook's
|
|
392
|
-
// concern when agent identity is required.
|
|
393
|
-
in := `{"tool_name":"Bash","tool_input":{"command":"rm -rf x"},"agent_type":"Explore"}`
|
|
394
|
-
out, _, code := runDevritesIO(t, root, in,
|
|
395
|
-
[]string{"DEVRITES_REVIEWER_RO=enforce", "DEVRITES_REVIEWER_AGENT_REQUIRED=1"},
|
|
396
|
-
"hook", "reviewer-readonly", "--harness=claude")
|
|
397
|
-
if code != 0 || strings.TrimSpace(out) != "" {
|
|
398
|
-
t.Errorf("want silent exit 0 for a non-devrites agent; got exit=%d out=%q", code, out)
|
|
399
|
-
}
|
|
400
|
-
}
|
|
401
|
-
|
|
402
|
-
func TestHookReviewerReadonlyBindsCodexExplorerCompatibility(t *testing.T) {
|
|
403
|
-
root := newWorkspace(t)
|
|
404
|
-
in := `{"tool_name":"Edit","tool_input":{"file_path":"src/app.go"},"agent_type":"explorer"}`
|
|
405
|
-
out, errOut, code := runDevritesIO(t, root, in,
|
|
406
|
-
[]string{"DEVRITES_CODEX_GENERIC_AGENT_COMPAT=1"},
|
|
407
|
-
"hook", "reviewer-readonly", "--harness=codex")
|
|
408
|
-
if code != 0 {
|
|
409
|
-
t.Fatalf("exit=%d stderr=%q", code, errOut)
|
|
410
|
-
}
|
|
411
|
-
if decision, _ := parsePermissionDecision(t, out); decision != "deny" {
|
|
412
|
-
t.Fatalf("generic explorer mutation was not denied: %q", out)
|
|
413
|
-
}
|
|
414
|
-
}
|
|
415
|
-
|
|
416
|
-
func TestCodexGenericCompatibilityDoesNotShadowRoot(t *testing.T) {
|
|
417
|
-
root := newWorkspace(t)
|
|
418
|
-
in := `{"tool_name":"Edit","tool_input":{"file_path":"src/app.go"}}`
|
|
419
|
-
env := []string{
|
|
420
|
-
"DEVRITES_CODEX_GENERIC_AGENT_COMPAT=1",
|
|
421
|
-
"DEVRITES_HOOK_PROFILE=strict",
|
|
422
|
-
}
|
|
423
|
-
for _, guard := range []string{"reviewer-readonly", "wright-scope"} {
|
|
424
|
-
out, errOut, code := runDevritesIO(t, root, in, env,
|
|
425
|
-
"hook", guard, "--harness=codex")
|
|
426
|
-
if code != 0 || strings.TrimSpace(out) != "" {
|
|
427
|
-
t.Fatalf("%s shadowed root: exit=%d out=%q stderr=%q", guard, code, out, errOut)
|
|
428
|
-
}
|
|
429
|
-
}
|
|
430
|
-
}
|
|
431
|
-
|
|
432
|
-
func TestCodexRootRunsArtifactGatesInsideActiveWindow(t *testing.T) {
|
|
433
|
-
root := newWorkspace(t)
|
|
434
|
-
writeActive(t, root, "auth-tokens")
|
|
435
|
-
workspace := filepath.Join(root, "features", "auth-tokens")
|
|
436
|
-
if err := os.WriteFile(filepath.Join(workspace, ".reconcile-base"), []byte("snapshot\n"), 0o600); err != nil {
|
|
437
|
-
t.Fatal(err)
|
|
438
|
-
}
|
|
439
|
-
env := []string{
|
|
440
|
-
"DEVRITES_CODEX_GENERIC_AGENT_COMPAT=1",
|
|
441
|
-
"DEVRITES_HOOK_PROFILE=strict",
|
|
442
|
-
}
|
|
443
|
-
for _, command := range []string{
|
|
444
|
-
"npm run build",
|
|
445
|
-
"npm run test:e2e -- tests/admin-locations.e2e.spec.ts",
|
|
446
|
-
} {
|
|
447
|
-
in := fmt.Sprintf(`{"tool_name":"Bash","tool_input":{"command":%q}}`, command)
|
|
448
|
-
out, errOut, code := runDevritesIO(t, root, in, env,
|
|
449
|
-
"hook", "wright-scope", "--harness=codex")
|
|
450
|
-
if code != 0 || strings.TrimSpace(out) != "" {
|
|
451
|
-
t.Fatalf("%q should be root-owned: exit=%d out=%q stderr=%q", command, code, out, errOut)
|
|
452
|
-
}
|
|
453
|
-
}
|
|
454
|
-
|
|
455
|
-
in := `{"tool_name":"Bash","tool_input":{"command":"printf x > src/app.go"}}`
|
|
456
|
-
out, errOut, code := runDevritesIO(t, root, in, env,
|
|
457
|
-
"hook", "wright-scope", "--harness=codex")
|
|
458
|
-
if code != 0 {
|
|
459
|
-
t.Fatalf("source write guard exit=%d stderr=%q", code, errOut)
|
|
460
|
-
}
|
|
461
|
-
if decision, _ := parsePermissionDecision(t, out); decision != "deny" {
|
|
462
|
-
t.Fatalf("root source mutation was not denied: %q", out)
|
|
463
|
-
}
|
|
464
|
-
}
|
|
465
|
-
|
|
466
|
-
func TestHookReviewerReadonlyActiveLeafDeniesEveryMutationSurface(t *testing.T) {
|
|
467
|
-
root := newWorkspace(t)
|
|
468
|
-
env := []string{
|
|
469
|
-
"DEVRITES_AGENT_RUN=1",
|
|
470
|
-
"DEVRITES_ACTIVE_AGENT=devrites-code-reviewer",
|
|
471
|
-
}
|
|
472
|
-
for _, input := range []string{
|
|
473
|
-
`{"tool_name":"Edit","tool_input":{"file_path":"src/app.go"}}`,
|
|
474
|
-
`{"tool_name":"apply_patch","tool_input":{"command":"*** Begin Patch\n*** Add File: src/app.go\n+x\n*** End Patch"}}`,
|
|
475
|
-
`{"tool_name":"Bash","tool_input":{"command":"printf x > src/app.go"}}`,
|
|
476
|
-
`{"tool_name":"spawn_agent","tool_input":{"message":"do work"}}`,
|
|
477
|
-
`{"tool_name":"exec","tool_input":{"code":"writeFile()"}}`,
|
|
478
|
-
} {
|
|
479
|
-
out, errOut, code := runDevritesIO(t, root, input, env,
|
|
480
|
-
"hook", "reviewer-readonly", "--harness=codex")
|
|
481
|
-
if code != 0 {
|
|
482
|
-
t.Fatalf("exit=%d stderr=%q for %s", code, errOut, input)
|
|
483
|
-
}
|
|
484
|
-
if decision, _ := parsePermissionDecision(t, out); decision != "deny" {
|
|
485
|
-
t.Errorf("mutation surface was not denied: %s", input)
|
|
486
|
-
}
|
|
487
|
-
}
|
|
488
|
-
}
|
|
489
|
-
|
|
490
|
-
func TestHookReviewerReadonlyActiveLeafAllowsBoundedProof(t *testing.T) {
|
|
491
|
-
root := newWorkspace(t)
|
|
492
|
-
env := []string{
|
|
493
|
-
"DEVRITES_AGENT_RUN=1",
|
|
494
|
-
"DEVRITES_ACTIVE_AGENT=devrites-proof-runner",
|
|
495
|
-
}
|
|
496
|
-
for _, command := range []string{
|
|
497
|
-
"go test ./... -count=1",
|
|
498
|
-
"command -v devrites-engine",
|
|
499
|
-
"devrites-engine conventions orient",
|
|
500
|
-
"devrites-engine learnings mine",
|
|
501
|
-
} {
|
|
502
|
-
in := fmt.Sprintf(`{"tool_name":"Bash","tool_input":{"command":%q}}`, command)
|
|
503
|
-
out, _, code := runDevritesIO(t, root, in, env,
|
|
504
|
-
"hook", "reviewer-readonly", "--harness=claude")
|
|
505
|
-
if code != 0 || strings.TrimSpace(out) != "" {
|
|
506
|
-
t.Fatalf("%q should be allowed: exit=%d out=%q", command, code, out)
|
|
507
|
-
}
|
|
508
|
-
}
|
|
509
|
-
in := `{"tool_name":"Bash","tool_input":{"command":"go test ./... -count=1"}}`
|
|
510
|
-
out, _, code := runDevritesIO(t, root, in, env,
|
|
511
|
-
"hook", "wright-scope", "--harness=claude")
|
|
512
|
-
if code != 0 || strings.TrimSpace(out) != "" {
|
|
513
|
-
t.Fatalf("wright hook must not shadow reviewer policy: exit=%d out=%q", code, out)
|
|
514
|
-
}
|
|
515
|
-
}
|
|
516
|
-
|
|
517
|
-
func TestHookReviewerReadonlyProofRunnerKeepsArtifactProofRootOwned(t *testing.T) {
|
|
518
|
-
root := newWorkspace(t)
|
|
519
|
-
env := []string{
|
|
520
|
-
"DEVRITES_AGENT_RUN=1",
|
|
521
|
-
"DEVRITES_ACTIVE_AGENT=devrites-proof-runner",
|
|
522
|
-
}
|
|
523
|
-
for _, command := range []string{
|
|
524
|
-
"npm run build",
|
|
525
|
-
"npm run test:e2e -- tests/admin-locations.e2e.spec.ts",
|
|
526
|
-
"go build ./...",
|
|
527
|
-
"bash scripts/mutate-repository.sh",
|
|
528
|
-
"npm run deploy",
|
|
529
|
-
"make deploy",
|
|
530
|
-
"docker compose up -d",
|
|
531
|
-
"printf x > src/app.go",
|
|
532
|
-
"npm install left-pad",
|
|
533
|
-
"python -c 'open(\"src/app.go\", \"w\").write(\"x\")'",
|
|
534
|
-
} {
|
|
535
|
-
in := fmt.Sprintf(`{"tool_name":"Bash","tool_input":{"command":%q}}`, command)
|
|
536
|
-
out, errOut, code := runDevritesIO(t, root, in, env,
|
|
537
|
-
"hook", "reviewer-readonly", "--harness=claude")
|
|
538
|
-
if code != 0 {
|
|
539
|
-
t.Fatalf("root-owned proof command guard exit=%d stderr=%q", code, errOut)
|
|
540
|
-
}
|
|
541
|
-
if decision, _ := parsePermissionDecision(t, out); decision != "deny" {
|
|
542
|
-
t.Fatalf("proof leaf command was not denied: command=%q out=%q", command, out)
|
|
543
|
-
}
|
|
544
|
-
}
|
|
545
|
-
}
|
|
546
|
-
|
|
547
|
-
func TestHookRedwatchRecognizesCodexShellAliases(t *testing.T) {
|
|
548
|
-
root := newWorkspace(t)
|
|
549
|
-
writeActive(t, root, "auth-tokens")
|
|
550
|
-
red := filepath.Join(root, "features", "auth-tokens", ".red")
|
|
551
|
-
|
|
552
|
-
fail := `{"tool_name":"functions.exec_command","tool_input":{"cmd":"npm test"},"tool_response":"Tests: 1 failed, 3 passed"}`
|
|
553
|
-
out, errOut, code := runDevritesIO(t, root, fail, nil,
|
|
554
|
-
"hook", "redwatch", "--harness=codex")
|
|
555
|
-
if code != 0 {
|
|
556
|
-
t.Fatalf("failing exec_command exit=%d stderr=%q", code, errOut)
|
|
557
|
-
}
|
|
558
|
-
if !strings.Contains(out, "tests/build are RED") {
|
|
559
|
-
t.Fatalf("failing exec_command omitted RED context: %q", out)
|
|
560
|
-
}
|
|
561
|
-
if _, err := os.Stat(red); err != nil {
|
|
562
|
-
t.Fatalf("failing exec_command did not create .red: %v", err)
|
|
563
|
-
}
|
|
564
|
-
|
|
565
|
-
pass := `{"tool_name":"exec_command","tool_input":{"cmd":"npm test"},"tool_response":"PASS: all tests passed"}`
|
|
566
|
-
out, errOut, code = runDevritesIO(t, root, pass, nil,
|
|
567
|
-
"hook", "redwatch", "--harness=codex")
|
|
568
|
-
if code != 0 || strings.TrimSpace(out) != "" {
|
|
569
|
-
t.Fatalf("passing exec_command exit=%d out=%q stderr=%q", code, out, errOut)
|
|
570
|
-
}
|
|
571
|
-
if _, err := os.Stat(red); !os.IsNotExist(err) {
|
|
572
|
-
t.Fatalf("passing exec_command retained .red: %v", err)
|
|
573
|
-
}
|
|
574
|
-
}
|
|
575
|
-
|
|
576
|
-
func TestHookWrightScopeUsesExactOrchestratorAllowlist(t *testing.T) {
|
|
577
|
-
root := newWorkspace(t)
|
|
578
|
-
writeActive(t, root, "auth-tokens")
|
|
579
|
-
workspace := filepath.Join(root, "features", "auth-tokens")
|
|
580
|
-
if err := os.WriteFile(filepath.Join(workspace, ".wright-allowlist"), []byte("src/app.go\n"), 0o600); err != nil {
|
|
581
|
-
t.Fatal(err)
|
|
582
|
-
}
|
|
583
|
-
env := []string{
|
|
584
|
-
"DEVRITES_AGENT_RUN=1",
|
|
585
|
-
"DEVRITES_ACTIVE_AGENT=devrites-slice-wright",
|
|
586
|
-
}
|
|
587
|
-
tests := []struct {
|
|
588
|
-
name string
|
|
589
|
-
input string
|
|
590
|
-
deny bool
|
|
591
|
-
}{
|
|
592
|
-
{"listed edit", `{"tool_name":"Edit","tool_input":{"file_path":"src/app.go"}}`, false},
|
|
593
|
-
{"listed freeform patch", `{"tool_name":"apply_patch","tool_input":"*** Begin Patch\n*** Update File: src/app.go\n@@\n-old\n+new\n*** End Patch\n"}`, false},
|
|
594
|
-
{"listed redirect", `{"tool_name":"Bash","tool_input":{"command":"printf x > src/app.go"}}`, false},
|
|
595
|
-
{"unlisted edit", `{"tool_name":"Write","tool_input":{"file_path":"src/other.go"}}`, true},
|
|
596
|
-
{"substring is not scope", `{"tool_name":"Edit","tool_input":{"file_path":"src/app.go.bak"}}`, true},
|
|
597
|
-
{"workspace state forbidden", `{"tool_name":"Edit","tool_input":{"file_path":".devrites/features/auth-tokens/state.md"}}`, true},
|
|
598
|
-
{"nested dispatch forbidden", `{"tool_name":"spawn_agent","tool_input":{"message":"do work"}}`, true},
|
|
599
|
-
{"dependency install forbidden", `{"tool_name":"Bash","tool_input":{"command":"npm install left-pad"}}`, true},
|
|
600
|
-
{"cp target directory forbidden", `{"tool_name":"Bash","tool_input":{"command":"cp --target-directory=/tmp src/app.go"}}`, true},
|
|
601
|
-
{"mv target directory forbidden", `{"tool_name":"Bash","tool_input":{"command":"mv --target-directory=/tmp src/app.go"}}`, true},
|
|
602
|
-
}
|
|
603
|
-
for _, test := range tests {
|
|
604
|
-
t.Run(test.name, func(t *testing.T) {
|
|
605
|
-
out, errOut, code := runDevritesIO(t, root, test.input, env,
|
|
606
|
-
"hook", "wright-scope", "--harness=codex")
|
|
607
|
-
if code != 0 {
|
|
608
|
-
t.Fatalf("exit=%d stderr=%q", code, errOut)
|
|
609
|
-
}
|
|
610
|
-
if test.deny {
|
|
611
|
-
if decision, _ := parsePermissionDecision(t, out); decision != "deny" {
|
|
612
|
-
t.Fatalf("expected deny, got %q", out)
|
|
613
|
-
}
|
|
614
|
-
} else if strings.TrimSpace(out) != "" {
|
|
615
|
-
t.Fatalf("expected allow, got %q", out)
|
|
616
|
-
}
|
|
617
|
-
})
|
|
618
|
-
}
|
|
619
|
-
}
|
|
620
|
-
|
|
621
|
-
func TestHookWrightScopeRequiresBoundCodexWorkerDuringReconcileWindow(t *testing.T) {
|
|
622
|
-
root := newWorkspace(t)
|
|
623
|
-
writeActive(t, root, "auth-tokens")
|
|
624
|
-
workspace := filepath.Join(root, "features", "auth-tokens")
|
|
625
|
-
if err := os.WriteFile(filepath.Join(workspace, ".wright-allowlist"), []byte("src/app.go\n"), 0o600); err != nil {
|
|
626
|
-
t.Fatal(err)
|
|
627
|
-
}
|
|
628
|
-
if err := os.WriteFile(filepath.Join(workspace, ".reconcile-base"), []byte("snapshot\n"), 0o600); err != nil {
|
|
629
|
-
t.Fatal(err)
|
|
630
|
-
}
|
|
631
|
-
env := []string{"DEVRITES_CODEX_GENERIC_AGENT_COMPAT=1", "DEVRITES_HOOK_PROFILE=strict"}
|
|
632
|
-
|
|
633
|
-
for _, test := range []struct {
|
|
634
|
-
name string
|
|
635
|
-
input string
|
|
636
|
-
deny bool
|
|
637
|
-
}{
|
|
638
|
-
{"unbound listed edit", `{"tool_name":"Edit","tool_input":{"file_path":"src/app.go"},"agent_type":"worker"}`, true},
|
|
639
|
-
{"unlisted edit", `{"tool_name":"Edit","tool_input":{"file_path":"src/other.go"},"agent_type":"worker"}`, true},
|
|
640
|
-
} {
|
|
641
|
-
t.Run(test.name, func(t *testing.T) {
|
|
642
|
-
out, errOut, code := runDevritesIO(t, root, test.input, env,
|
|
643
|
-
"hook", "wright-scope", "--harness=codex")
|
|
644
|
-
if code != 0 {
|
|
645
|
-
t.Fatalf("exit=%d stderr=%q", code, errOut)
|
|
646
|
-
}
|
|
647
|
-
if test.deny {
|
|
648
|
-
if decision, _ := parsePermissionDecision(t, out); decision != "deny" {
|
|
649
|
-
t.Fatalf("expected deny, got %q", out)
|
|
650
|
-
}
|
|
651
|
-
} else if strings.TrimSpace(out) != "" {
|
|
652
|
-
t.Fatalf("expected allow, got %q", out)
|
|
653
|
-
}
|
|
654
|
-
})
|
|
655
|
-
}
|
|
656
|
-
|
|
657
|
-
if err := os.Remove(filepath.Join(workspace, ".reconcile-base")); err != nil {
|
|
658
|
-
t.Fatal(err)
|
|
659
|
-
}
|
|
660
|
-
out, _, code := runDevritesIO(t, root,
|
|
661
|
-
`{"tool_name":"Edit","tool_input":{"file_path":"src/other.go"},"agent_type":"worker"}`,
|
|
662
|
-
env, "hook", "wright-scope", "--harness=codex")
|
|
663
|
-
if code != 0 || strings.TrimSpace(out) != "" {
|
|
664
|
-
t.Fatalf("generic worker outside a reconcile window was shadowed: exit=%d out=%q", code, out)
|
|
665
|
-
}
|
|
666
|
-
}
|
|
667
|
-
|
|
668
|
-
func TestHookWrightScopeAllowsOnlyBoundCodexV1WorkerPaths(t *testing.T) {
|
|
669
|
-
root := newWorkspace(t)
|
|
670
|
-
writeActive(t, root, "auth-tokens")
|
|
671
|
-
workspace := filepath.Join(root, "features", "auth-tokens")
|
|
672
|
-
for name, body := range map[string]string{
|
|
673
|
-
".wright-allowlist": "src/app.go\n",
|
|
674
|
-
".reconcile-base": "snapshot\n",
|
|
675
|
-
".reconcile-allowlist": "src/app.go\n",
|
|
676
|
-
".reconcile-devrites": "[]\n",
|
|
677
|
-
} {
|
|
678
|
-
if err := os.WriteFile(filepath.Join(workspace, name), []byte(body), 0o600); err != nil {
|
|
679
|
-
t.Fatal(err)
|
|
680
|
-
}
|
|
681
|
-
}
|
|
682
|
-
if err := os.MkdirAll(filepath.Join(workspace, ".reconcile-objects"), 0o700); err != nil {
|
|
683
|
-
t.Fatal(err)
|
|
684
|
-
}
|
|
685
|
-
sessionID, turnID := "session-bound-worker", "turn-bound-worker"
|
|
686
|
-
writeCodexAgentContract(t, root, "devrites-slice-wright")
|
|
687
|
-
writeCodexSkillContract(t, root, "rite-build", "devrites-slice-wright")
|
|
688
|
-
runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
689
|
-
"hook_event_name": "UserPromptSubmit",
|
|
690
|
-
"session_id": sessionID,
|
|
691
|
-
"turn_id": turnID,
|
|
692
|
-
"prompt": "$rite-build",
|
|
693
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
694
|
-
if out, stderr, code := runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
695
|
-
"hook_event_name": "PreToolUse",
|
|
696
|
-
"session_id": sessionID,
|
|
697
|
-
"turn_id": turnID,
|
|
698
|
-
"tool_name": "spawn_agent",
|
|
699
|
-
"tool_use_id": "spawn-bound-worker",
|
|
700
|
-
"tool_input": map[string]any{
|
|
701
|
-
"agent_type": "worker",
|
|
702
|
-
"fork_turns": "none",
|
|
703
|
-
"message": "Read .codex/agents/devrites-slice-wright.toml.",
|
|
704
|
-
},
|
|
705
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex"); code != 0 {
|
|
706
|
-
t.Fatalf("spawn exit=%d out=%s stderr=%s", code, out, stderr)
|
|
707
|
-
} else if decision, reason := parsePermissionDecision(t, out); decision != "allow" {
|
|
708
|
-
t.Fatalf("spawn denied: %s (%s)", decision, reason)
|
|
709
|
-
}
|
|
710
|
-
if out, stderr, code := runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
711
|
-
"hook_event_name": "SubagentStart",
|
|
712
|
-
"session_id": sessionID,
|
|
713
|
-
"turn_id": "child-turn",
|
|
714
|
-
"agent_id": "bound-worker",
|
|
715
|
-
"agent_type": "worker",
|
|
716
|
-
}), nil, "hook", "subagent-orient", "--harness=codex"); code != 0 ||
|
|
717
|
-
!strings.Contains(out, "Confirmed role") {
|
|
718
|
-
t.Fatalf("start exit=%d out=%s stderr=%s", code, out, stderr)
|
|
719
|
-
}
|
|
720
|
-
|
|
721
|
-
env := []string{"DEVRITES_CODEX_GENERIC_AGENT_COMPAT=1", "DEVRITES_HOOK_PROFILE=strict"}
|
|
722
|
-
for _, test := range []struct {
|
|
723
|
-
path string
|
|
724
|
-
deny bool
|
|
725
|
-
}{
|
|
726
|
-
{"src/app.go", false},
|
|
727
|
-
{"src/other.go", true},
|
|
728
|
-
} {
|
|
729
|
-
input := hookPayload(t, map[string]any{
|
|
730
|
-
"hook_event_name": "PreToolUse",
|
|
731
|
-
"session_id": sessionID,
|
|
732
|
-
"agent_id": "bound-worker",
|
|
733
|
-
"agent_type": "worker",
|
|
734
|
-
"tool_name": "Edit",
|
|
735
|
-
"tool_input": map[string]any{"file_path": test.path},
|
|
736
|
-
})
|
|
737
|
-
out, stderr, code := runDevritesIO(t, root, input, env,
|
|
738
|
-
"hook", "wright-scope", "--harness=codex")
|
|
739
|
-
if code != 0 {
|
|
740
|
-
t.Fatalf("%s exit=%d stderr=%s", test.path, code, stderr)
|
|
741
|
-
}
|
|
742
|
-
if test.deny {
|
|
743
|
-
if decision, _ := parsePermissionDecision(t, out); decision != "deny" {
|
|
744
|
-
t.Fatalf("%s should be denied: %s", test.path, out)
|
|
745
|
-
}
|
|
746
|
-
} else if strings.TrimSpace(out) != "" {
|
|
747
|
-
t.Fatalf("%s should be allowed: %s", test.path, out)
|
|
748
|
-
}
|
|
749
|
-
}
|
|
750
|
-
}
|
|
751
|
-
|
|
752
|
-
func TestHookWrightScopeAcceptsCodexV2NamedRole(t *testing.T) {
|
|
753
|
-
root := newWorkspace(t)
|
|
754
|
-
writeActive(t, root, "auth-tokens")
|
|
755
|
-
workspace := filepath.Join(root, "features", "auth-tokens")
|
|
756
|
-
if err := os.WriteFile(filepath.Join(workspace, ".wright-allowlist"), []byte("src/app.go\n"), 0o600); err != nil {
|
|
757
|
-
t.Fatal(err)
|
|
758
|
-
}
|
|
759
|
-
for _, name := range []string{".reconcile-base", ".reconcile-allowlist", ".reconcile-devrites"} {
|
|
760
|
-
if err := os.WriteFile(filepath.Join(workspace, name), []byte(name+"\n"), 0o600); err != nil {
|
|
761
|
-
t.Fatal(err)
|
|
762
|
-
}
|
|
763
|
-
}
|
|
764
|
-
|
|
765
|
-
env := []string{"DEVRITES_HOOK_PROFILE=strict"}
|
|
766
|
-
for _, test := range []struct {
|
|
767
|
-
path string
|
|
768
|
-
deny bool
|
|
769
|
-
}{
|
|
770
|
-
{"src/app.go", false},
|
|
771
|
-
{"src/other.go", true},
|
|
772
|
-
} {
|
|
773
|
-
payload := hookPayload(t, map[string]any{
|
|
774
|
-
"hook_event_name": "PreToolUse",
|
|
775
|
-
"agent_type": "devrites-slice-wright",
|
|
776
|
-
"tool_name": "Edit",
|
|
777
|
-
"tool_input": map[string]any{"file_path": test.path},
|
|
778
|
-
})
|
|
779
|
-
out, stderr, code := runDevritesIO(t, root, payload, env,
|
|
780
|
-
"hook", "wright-scope", "--harness=codex")
|
|
781
|
-
if code != 0 {
|
|
782
|
-
t.Fatalf("%s exit=%d stderr=%s", test.path, code, stderr)
|
|
783
|
-
}
|
|
784
|
-
if test.deny {
|
|
785
|
-
if decision, _ := parsePermissionDecision(t, out); decision != "deny" {
|
|
786
|
-
t.Fatalf("%s should be denied: %s", test.path, out)
|
|
787
|
-
}
|
|
788
|
-
} else if strings.TrimSpace(out) != "" {
|
|
789
|
-
t.Fatalf("%s should be allowed: %s", test.path, out)
|
|
790
|
-
}
|
|
791
|
-
}
|
|
792
|
-
}
|
|
793
|
-
|
|
794
|
-
func TestHookWrightScopeRequiresSpawnedCodexWorkerForSourceWrites(t *testing.T) {
|
|
795
|
-
root := newWorkspace(t)
|
|
796
|
-
writeActive(t, root, "auth-tokens")
|
|
797
|
-
workspace := filepath.Join(root, "features", "auth-tokens")
|
|
798
|
-
if err := os.WriteFile(filepath.Join(workspace, ".reconcile-base"), []byte("snapshot\n"), 0o600); err != nil {
|
|
799
|
-
t.Fatal(err)
|
|
800
|
-
}
|
|
801
|
-
env := []string{"DEVRITES_CODEX_GENERIC_AGENT_COMPAT=1"}
|
|
802
|
-
|
|
803
|
-
runGuard := func(input string, deny bool) {
|
|
804
|
-
t.Helper()
|
|
805
|
-
out, errOut, code := runDevritesIO(t, root, input, env,
|
|
806
|
-
"hook", "wright-scope", "--harness=codex")
|
|
807
|
-
if code != 0 {
|
|
808
|
-
t.Fatalf("exit=%d out=%q stderr=%q", code, out, errOut)
|
|
809
|
-
}
|
|
810
|
-
if deny {
|
|
811
|
-
if decision, _ := parsePermissionDecision(t, out); decision != "deny" {
|
|
812
|
-
t.Fatalf("expected deny, got %q", out)
|
|
813
|
-
}
|
|
814
|
-
} else if strings.TrimSpace(out) != "" {
|
|
815
|
-
t.Fatalf("expected allow, got %q", out)
|
|
816
|
-
}
|
|
817
|
-
}
|
|
818
|
-
|
|
819
|
-
runGuard(`{"tool_name":"spawn_agent","tool_input":{"agent_type":"worker"}}`, false)
|
|
820
|
-
runGuard(`{"tool_name":"spawn_agent","tool_input":{"agent_type":"explorer"}}`, false)
|
|
821
|
-
runGuard(`{"tool_name":"Write","tool_input":{"file_path":".devrites/features/auth-tokens/state.md"}}`, false)
|
|
822
|
-
scratch := t.TempDir()
|
|
823
|
-
packet := filepath.Join(scratch, "agent-packet.yaml")
|
|
824
|
-
runGuard(hookPayload(t, map[string]any{
|
|
825
|
-
"tool_name": "Write",
|
|
826
|
-
"tool_input": map[string]any{"file_path": packet},
|
|
827
|
-
}), false)
|
|
828
|
-
runGuard(`{"tool_name":"Write","tool_input":{"file_path":"../outside.txt"}}`, true)
|
|
829
|
-
runGuard(`{"tool_name":"Write","tool_input":{"file_path":"src/app.go"}}`, true)
|
|
830
|
-
runGuard(`{"tool_name":"Bash","tool_input":{"command":"printf x > src/app.go"}}`, true)
|
|
831
|
-
runGuard(`{"tool_name":"js","tool_input":{"code":"writeFile()"}}`, true)
|
|
832
|
-
runGuard(`{"tool_name":"Bash","tool_input":{"command":"devrites-engine reconcile restore-check auth-tokens"}}`, false)
|
|
833
|
-
runGuard(`{"tool_name":"Bash","tool_input":{"command":"devrites-engine reconcile restore-check auth-tokens && printf x > src/app.go"}}`, true)
|
|
834
|
-
runGuard(`{"tool_name":"Bash","tool_input":{"command":"rtk devrites-engine reconcile abort auth-tokens"}}`, false)
|
|
835
|
-
runGuard(`{"tool_name":"Bash","tool_input":{"command":"devrites-engine reconcile abort auth-tokens"}}`, false)
|
|
836
|
-
runGuard(`{"tool_name":"Bash","tool_input":{"command":"devrites-engine reconcile abort auth-tokens && printf x > src/app.go"}}`, true)
|
|
837
|
-
out, errOut, code := runDevritesIO(t, root,
|
|
838
|
-
`{"tool_name":"Bash","tool_input":{"command":"printf x > src/app.go"}}`,
|
|
839
|
-
nil, "hook", "wright-scope", "--harness=claude")
|
|
840
|
-
if code != 0 {
|
|
841
|
-
t.Fatalf("Claude root guard: exit=%d stderr=%q", code, errOut)
|
|
842
|
-
}
|
|
843
|
-
if decision, _ := parsePermissionDecision(t, out); decision != "deny" {
|
|
844
|
-
t.Fatalf("Claude root source write was not denied: %q", out)
|
|
845
|
-
}
|
|
846
|
-
|
|
847
|
-
// A legacy marker is inert: it cannot authorize root source writes.
|
|
848
|
-
if err := os.WriteFile(filepath.Join(workspace, ".reconcile-inline"), nil, 0o600); err != nil {
|
|
849
|
-
t.Fatal(err)
|
|
850
|
-
}
|
|
851
|
-
runGuard(`{"tool_name":"Bash","tool_input":{"command":"printf x > src/app.go"}}`, true)
|
|
852
|
-
runGuard(`{"tool_name":"js","tool_input":{"code":"writeFile()"}}`, true)
|
|
853
|
-
|
|
854
|
-
projectDir := filepath.Dir(root)
|
|
855
|
-
if err := os.MkdirAll(filepath.Join(projectDir, "src"), 0o755); err != nil {
|
|
856
|
-
t.Fatal(err)
|
|
857
|
-
}
|
|
858
|
-
source := filepath.Join(projectDir, "src", "app.go")
|
|
859
|
-
if err := os.WriteFile(source, []byte("package src\n"), 0o600); err != nil {
|
|
860
|
-
t.Fatal(err)
|
|
861
|
-
}
|
|
862
|
-
alias := filepath.Join(workspace, "source-alias")
|
|
863
|
-
if err := os.Symlink(source, alias); err != nil {
|
|
864
|
-
t.Skipf("symlinks unavailable: %v", err)
|
|
865
|
-
}
|
|
866
|
-
runGuard(`{"tool_name":"Write","tool_input":{"file_path":".devrites/features/auth-tokens/source-alias"}}`, true)
|
|
867
|
-
}
|
|
868
|
-
|
|
869
|
-
func TestHookA1GuardIgnoresLegacyInlineMarker(t *testing.T) {
|
|
870
|
-
root := newWorkspace(t)
|
|
871
|
-
writeActive(t, root, "auth-tokens")
|
|
872
|
-
workspace := filepath.Join(root, "features", "auth-tokens")
|
|
873
|
-
for _, name := range []string{".reconcile-base", ".reconcile-inline"} {
|
|
874
|
-
if err := os.WriteFile(filepath.Join(workspace, name), nil, 0o600); err != nil {
|
|
875
|
-
t.Fatal(err)
|
|
876
|
-
}
|
|
877
|
-
}
|
|
878
|
-
input := `{"tool_name":"Edit","tool_input":{"file_path":"src/app.go"}}`
|
|
879
|
-
env := []string{"DEVRITES_A1_HOOK=enforce"}
|
|
880
|
-
|
|
881
|
-
for _, host := range []string{"codex", "claude"} {
|
|
882
|
-
t.Run(host, func(t *testing.T) {
|
|
883
|
-
out, errOut, code := runDevritesIO(t, root, input, env,
|
|
884
|
-
"hook", "a1-guard", "--harness="+host)
|
|
885
|
-
if code != 0 {
|
|
886
|
-
t.Fatalf("exit=%d stderr=%q", code, errOut)
|
|
887
|
-
}
|
|
888
|
-
if decision, _ := parsePermissionDecision(t, out); decision != "deny" {
|
|
889
|
-
t.Fatalf("legacy inline marker authorized root source write: %q", out)
|
|
890
|
-
}
|
|
891
|
-
})
|
|
892
|
-
}
|
|
893
|
-
}
|
|
894
|
-
|
|
895
|
-
func TestHookA1GuardAllowsExternalDispatchScratchOnly(t *testing.T) {
|
|
896
|
-
root := newWorkspace(t)
|
|
897
|
-
writeActive(t, root, "auth-tokens")
|
|
898
|
-
workspace := filepath.Join(root, "features", "auth-tokens")
|
|
899
|
-
if err := os.WriteFile(filepath.Join(workspace, ".reconcile-base"), []byte("snapshot\n"), 0o600); err != nil {
|
|
900
|
-
t.Fatal(err)
|
|
901
|
-
}
|
|
902
|
-
scratch := t.TempDir()
|
|
903
|
-
packet := filepath.Join(scratch, "agent-packet.yaml")
|
|
904
|
-
env := []string{"DEVRITES_A1_HOOK=enforce"}
|
|
905
|
-
patch := func(tool, path string, freeform bool) string {
|
|
906
|
-
body := "*** Begin Patch\n*** Add File: " + path + "\n+x\n*** End Patch\n"
|
|
907
|
-
if freeform {
|
|
908
|
-
return hookPayload(t, map[string]any{"tool_name": tool, "tool_input": body})
|
|
909
|
-
}
|
|
910
|
-
return hookPayload(t, map[string]any{"tool_name": tool, "tool_input": map[string]any{"patch": body}})
|
|
911
|
-
}
|
|
912
|
-
shell := func(command string) string {
|
|
913
|
-
return hookPayload(t, map[string]any{
|
|
914
|
-
"tool_name": "functions.exec_command",
|
|
915
|
-
"tool_input": map[string]any{"cmd": command},
|
|
916
|
-
})
|
|
917
|
-
}
|
|
918
|
-
|
|
919
|
-
runGuard := func(input string, deny bool) {
|
|
920
|
-
t.Helper()
|
|
921
|
-
out, errOut, code := runDevritesIO(t, root, input, env,
|
|
922
|
-
"hook", "a1-guard", "--harness=codex")
|
|
923
|
-
if code != 0 {
|
|
924
|
-
t.Fatalf("exit=%d out=%q stderr=%q", code, out, errOut)
|
|
925
|
-
}
|
|
926
|
-
if deny {
|
|
927
|
-
if decision, _ := parsePermissionDecision(t, out); decision != "deny" {
|
|
928
|
-
t.Fatalf("expected deny, got %q", out)
|
|
929
|
-
}
|
|
930
|
-
} else if strings.TrimSpace(out) != "" {
|
|
931
|
-
t.Fatalf("expected allow, got %q", out)
|
|
932
|
-
}
|
|
933
|
-
}
|
|
934
|
-
|
|
935
|
-
runGuard(patch("apply_patch", packet, false), false)
|
|
936
|
-
runGuard(patch("functions.apply_patch", packet, true), false)
|
|
937
|
-
runGuard(shell("cat <<'EOF' > "+packet+"\npacket_version: agent-packet/v1\nEOF"), false)
|
|
938
|
-
runGuard(shell("sha256sum "+packet), false)
|
|
939
|
-
runGuard(shell("cp "+packet+" "+filepath.Join(scratch, "agent-packet.copy.yaml")), false)
|
|
940
|
-
runGuard(patch("apply_patch", "src/app.go", false), true)
|
|
941
|
-
runGuard(patch("functions.apply_patch", "src/app.go", true), true)
|
|
942
|
-
runGuard(shell("cat <<'EOF' > src/app.go\npackage src\nEOF"), true)
|
|
943
|
-
runGuard(shell("cat <<'EOF' > "+packet+"\nunterminated"), true)
|
|
944
|
-
runGuard(shell("cat <<EOF > "+packet+"\n$(cp "+packet+" src/app.go)\nEOF"), true)
|
|
945
|
-
runGuard(shell("cp "+packet+" src/app.go"), true)
|
|
946
|
-
}
|
|
947
|
-
|
|
948
|
-
func TestHookWrightScopeFailsClosedWhenWorkspaceResolutionFails(t *testing.T) {
|
|
949
|
-
root := newWorkspace(t)
|
|
950
|
-
if err := os.Remove(filepath.Join(root, "ACTIVE")); err != nil && !os.IsNotExist(err) {
|
|
951
|
-
t.Fatal(err)
|
|
952
|
-
}
|
|
953
|
-
|
|
954
|
-
wrightEnv := []string{
|
|
955
|
-
"DEVRITES_AGENT_RUN=1",
|
|
956
|
-
"DEVRITES_ACTIVE_AGENT=devrites-slice-wright",
|
|
957
|
-
}
|
|
958
|
-
for _, test := range []struct {
|
|
959
|
-
name string
|
|
960
|
-
input string
|
|
961
|
-
env []string
|
|
962
|
-
deny bool
|
|
963
|
-
}{
|
|
964
|
-
{"declared wright edit", `{"tool_name":"Edit","tool_input":{"file_path":"src/app.go"}}`, wrightEnv, true},
|
|
965
|
-
{"declared wright opaque execution", `{"tool_name":"exec","tool_input":{"code":"writeFile()"}}`, wrightEnv, true},
|
|
966
|
-
{"declared wright nested dispatch", `{"tool_name":"spawn_agent","tool_input":{"message":"do work"}}`, wrightEnv, true},
|
|
967
|
-
{"invalid declared identity", `{"tool_name":"Edit","tool_input":{"file_path":"src/app.go"}}`,
|
|
968
|
-
[]string{"DEVRITES_AGENT_RUN=1", "DEVRITES_ACTIVE_AGENT=invalid"}, true},
|
|
969
|
-
{"undeclared root observation", `{"tool_name":"Edit","tool_input":{"file_path":"src/app.go"}}`,
|
|
970
|
-
[]string{"DEVRITES_AGENT_RUN=0", "DEVRITES_ACTIVE_AGENT=", "DEVRITES_WRIGHT_SCOPE="}, false},
|
|
971
|
-
} {
|
|
972
|
-
t.Run(test.name, func(t *testing.T) {
|
|
973
|
-
out, errOut, code := runDevritesIO(t, root, test.input, test.env,
|
|
974
|
-
"hook", "wright-scope", "--harness=codex")
|
|
975
|
-
if code != 0 {
|
|
976
|
-
t.Fatalf("exit=%d stderr=%q", code, errOut)
|
|
977
|
-
}
|
|
978
|
-
if test.deny {
|
|
979
|
-
if decision, _ := parsePermissionDecision(t, out); decision != "deny" {
|
|
980
|
-
t.Fatalf("expected deny, got %q", out)
|
|
981
|
-
}
|
|
982
|
-
} else if strings.TrimSpace(out) != "" {
|
|
983
|
-
t.Fatalf("expected non-shadowing allow, got %q", out)
|
|
984
|
-
}
|
|
985
|
-
})
|
|
986
|
-
}
|
|
987
|
-
}
|
|
988
|
-
|
|
989
|
-
func TestHookWrightScopeFailsClosedOnMissingOrInvalidAllowlist(t *testing.T) {
|
|
990
|
-
root := newWorkspace(t)
|
|
991
|
-
writeActive(t, root, "auth-tokens")
|
|
992
|
-
workspace := filepath.Join(root, "features", "auth-tokens")
|
|
993
|
-
env := []string{
|
|
994
|
-
"DEVRITES_AGENT_RUN=1",
|
|
995
|
-
"DEVRITES_ACTIVE_AGENT=devrites-slice-wright",
|
|
996
|
-
}
|
|
997
|
-
in := `{"tool_name":"Edit","tool_input":{"file_path":"src/app.go"}}`
|
|
998
|
-
|
|
999
|
-
out, _, _ := runDevritesIO(t, root, in, env, "hook", "wright-scope", "--harness=claude")
|
|
1000
|
-
if decision, _ := parsePermissionDecision(t, out); decision != "deny" {
|
|
1001
|
-
t.Fatal("missing allowlist did not fail closed")
|
|
1002
|
-
}
|
|
1003
|
-
|
|
1004
|
-
if err := os.WriteFile(filepath.Join(workspace, ".wright-allowlist"), []byte("src/app.go\nsrc/app.go\n"), 0o600); err != nil {
|
|
1005
|
-
t.Fatal(err)
|
|
1006
|
-
}
|
|
1007
|
-
out, _, _ = runDevritesIO(t, root, in, env, "hook", "wright-scope", "--harness=claude")
|
|
1008
|
-
if decision, _ := parsePermissionDecision(t, out); decision != "deny" {
|
|
1009
|
-
t.Fatal("duplicate allowlist entry did not fail closed")
|
|
1010
|
-
}
|
|
1011
|
-
}
|
|
1012
|
-
|
|
1013
|
-
func TestHookWrightScopeBindsForgeCandidateManifestIdentity(t *testing.T) {
|
|
1014
|
-
repo := newForgeCLIRepo(t)
|
|
1015
|
-
manifest := planForgeCLI(t, repo)
|
|
1016
|
-
candidate, err := manifest.Candidate("A")
|
|
1017
|
-
if err != nil {
|
|
1018
|
-
t.Fatal(err)
|
|
1019
|
-
}
|
|
1020
|
-
worker := startForgeCLIWorker(t, repo, manifest.RunID, "A", "worker-a")
|
|
1021
|
-
baseEnv := []string{
|
|
1022
|
-
"DEVRITES_AGENT_RUN=1",
|
|
1023
|
-
"DEVRITES_ACTIVE_AGENT=devrites-slice-wright",
|
|
1024
|
-
"DEVRITES_FORGE_RUN_ID=" + manifest.RunID,
|
|
1025
|
-
"DEVRITES_FORGE_CANDIDATE=A",
|
|
1026
|
-
"DEVRITES_FORGE_WORKER_ID=" + worker.id,
|
|
1027
|
-
"DEVRITES_FORGE_WORKER_PID=" + strconv.Itoa(worker.cmd.Process.Pid),
|
|
1028
|
-
"DEVRITES_FORGE_PROCESS_START=" + worker.token,
|
|
1029
|
-
}
|
|
1030
|
-
input := `{"tool_name":"Edit","agent_id":"worker-a","tool_input":{"file_path":"tracked.txt"}}`
|
|
1031
|
-
out, stderr, code := runDevritesAt(t, repo, candidate.Worktree, input, baseEnv,
|
|
1032
|
-
"hook", "wright-scope", "--harness=codex")
|
|
1033
|
-
if code != 0 || strings.TrimSpace(out) != "" {
|
|
1034
|
-
t.Fatalf("valid Forge candidate was denied: exit=%d stdout=%s stderr=%s", code, out, stderr)
|
|
1035
|
-
}
|
|
1036
|
-
genericEnv := append([]string{"DEVRITES_CODEX_GENERIC_AGENT_COMPAT=1"}, baseEnv[2:]...)
|
|
1037
|
-
genericInput := `{"tool_name":"Edit","agent_id":"worker-a","agent_type":"worker","tool_input":{"file_path":"tracked.txt"}}`
|
|
1038
|
-
out, stderr, code = runDevritesAt(t, repo, candidate.Worktree, genericInput, genericEnv,
|
|
1039
|
-
"hook", "wright-scope", "--harness=codex")
|
|
1040
|
-
if code != 0 || strings.TrimSpace(out) != "" {
|
|
1041
|
-
t.Fatalf("valid generic Forge worker was denied: exit=%d stdout=%s stderr=%s", code, out, stderr)
|
|
1042
|
-
}
|
|
1043
|
-
out, _, code = runDevritesAt(t, repo, candidate.Worktree,
|
|
1044
|
-
`{"tool_name":"Edit","agent_id":"worker-a","agent_type":"worker","tool_input":{"file_path":"outside.txt"}}`,
|
|
1045
|
-
genericEnv, "hook", "wright-scope", "--harness=codex")
|
|
1046
|
-
if code != 0 {
|
|
1047
|
-
t.Fatalf("generic Forge worker hook exit=%d", code)
|
|
1048
|
-
}
|
|
1049
|
-
if decision, _ := parsePermissionDecision(t, out); decision != "deny" {
|
|
1050
|
-
t.Fatalf("generic Forge worker escaped its allowlist: %s", out)
|
|
1051
|
-
}
|
|
1052
|
-
|
|
1053
|
-
replaceEnv := func(name, value string) []string {
|
|
1054
|
-
env := append([]string(nil), baseEnv...)
|
|
1055
|
-
prefix := name + "="
|
|
1056
|
-
for i := range env {
|
|
1057
|
-
if strings.HasPrefix(env[i], prefix) {
|
|
1058
|
-
env[i] = prefix + value
|
|
1059
|
-
}
|
|
1060
|
-
}
|
|
1061
|
-
return env
|
|
1062
|
-
}
|
|
1063
|
-
foreign := newForgeCLIRepo(t)
|
|
1064
|
-
for _, test := range []struct {
|
|
1065
|
-
name string
|
|
1066
|
-
cwd string
|
|
1067
|
-
input string
|
|
1068
|
-
env []string
|
|
1069
|
-
}{
|
|
1070
|
-
{"primary root", repo, input, baseEnv},
|
|
1071
|
-
{"sibling candidate", manifest.Candidates[1].Worktree, input, baseEnv},
|
|
1072
|
-
{"foreign repository", foreign, input, baseEnv},
|
|
1073
|
-
{"wrong candidate", candidate.Worktree, input, replaceEnv("DEVRITES_FORGE_CANDIDATE", "B")},
|
|
1074
|
-
{"wrong worker", candidate.Worktree, input, replaceEnv("DEVRITES_FORGE_WORKER_ID", "worker-x")},
|
|
1075
|
-
{"wrong pid", candidate.Worktree, input, replaceEnv("DEVRITES_FORGE_WORKER_PID", "1")},
|
|
1076
|
-
{"wrong token", candidate.Worktree, input, replaceEnv("DEVRITES_FORGE_PROCESS_START", strings.Repeat("0", 64))},
|
|
1077
|
-
{"partial binding", candidate.Worktree, input, replaceEnv("DEVRITES_FORGE_PROCESS_START", "")},
|
|
1078
|
-
{"missing binding", candidate.Worktree, input, baseEnv[:2]},
|
|
1079
|
-
{"wrong hook agent", candidate.Worktree,
|
|
1080
|
-
`{"tool_name":"Edit","agent_id":"worker-x","tool_input":{"file_path":"tracked.txt"}}`, baseEnv},
|
|
1081
|
-
} {
|
|
1082
|
-
t.Run(test.name, func(t *testing.T) {
|
|
1083
|
-
out, stderr, code := runDevritesAt(t, repo, test.cwd, test.input, test.env,
|
|
1084
|
-
"hook", "wright-scope", "--harness=codex")
|
|
1085
|
-
if code != 0 {
|
|
1086
|
-
t.Fatalf("exit=%d stderr=%s", code, stderr)
|
|
1087
|
-
}
|
|
1088
|
-
if decision, _ := parsePermissionDecision(t, out); decision != "deny" {
|
|
1089
|
-
t.Fatalf("invalid Forge binding was not denied: %s", out)
|
|
1090
|
-
}
|
|
1091
|
-
})
|
|
1092
|
-
}
|
|
1093
|
-
|
|
1094
|
-
forgeGit(t, candidate.Worktree, "switch", "-c", "wrong-forge-branch")
|
|
1095
|
-
out, _, _ = runDevritesAt(t, repo, candidate.Worktree, input, baseEnv,
|
|
1096
|
-
"hook", "wright-scope", "--harness=codex")
|
|
1097
|
-
if decision, _ := parsePermissionDecision(t, out); decision != "deny" {
|
|
1098
|
-
t.Fatal("wrong candidate branch was not denied")
|
|
1099
|
-
}
|
|
1100
|
-
forgeGit(t, candidate.Worktree, "switch", candidate.Branch)
|
|
1101
|
-
|
|
1102
|
-
manifestPath := filepath.Join(repo, ".devrites", "work", "alpha", ".forge", manifest.RunID, "manifest.json")
|
|
1103
|
-
raw, err := os.ReadFile(manifestPath)
|
|
1104
|
-
if err != nil {
|
|
1105
|
-
t.Fatal(err)
|
|
1106
|
-
}
|
|
1107
|
-
var tampered map[string]any
|
|
1108
|
-
if err := json.Unmarshal(raw, &tampered); err != nil {
|
|
1109
|
-
t.Fatal(err)
|
|
1110
|
-
}
|
|
1111
|
-
candidates := tampered["candidates"].([]any)
|
|
1112
|
-
candidates[0].(map[string]any)["worktree"] = foreign
|
|
1113
|
-
raw, err = json.MarshalIndent(tampered, "", " ")
|
|
1114
|
-
if err != nil {
|
|
1115
|
-
t.Fatal(err)
|
|
1116
|
-
}
|
|
1117
|
-
if err := os.WriteFile(manifestPath, append(raw, '\n'), 0o600); err != nil {
|
|
1118
|
-
t.Fatal(err)
|
|
1119
|
-
}
|
|
1120
|
-
out, _, _ = runDevritesAt(t, repo, candidate.Worktree, input, baseEnv,
|
|
1121
|
-
"hook", "wright-scope", "--harness=codex")
|
|
1122
|
-
if decision, _ := parsePermissionDecision(t, out); decision != "deny" {
|
|
1123
|
-
t.Fatal("tampered Forge manifest was not denied")
|
|
1124
|
-
}
|
|
1125
|
-
}
|
|
1126
|
-
|
|
1127
|
-
// --- issue 09: subagent-orient ---
|
|
1128
|
-
|
|
1129
|
-
func TestHookSubagentOrientInjectsDisciplineForDevritesAgent(t *testing.T) {
|
|
1130
|
-
for _, h := range []string{"claude", "codex"} {
|
|
1131
|
-
h := h
|
|
1132
|
-
t.Run(h, func(t *testing.T) {
|
|
1133
|
-
root := newWorkspace(t)
|
|
1134
|
-
in := `{"agent_type":"devrites-code-reviewer"}`
|
|
1135
|
-
out, errOut, code := runDevritesIO(t, root, in, nil, "hook", "subagent-orient", "--harness="+h)
|
|
1136
|
-
if code != 0 {
|
|
1137
|
-
t.Fatalf("exit = %d, want 0 (stderr: %s)", code, errOut)
|
|
1138
|
-
}
|
|
1139
|
-
var env struct {
|
|
1140
|
-
HookSpecificOutput struct {
|
|
1141
|
-
HookEventName string `json:"hookEventName"`
|
|
1142
|
-
AdditionalContext string `json:"additionalContext"`
|
|
1143
|
-
} `json:"hookSpecificOutput"`
|
|
1144
|
-
}
|
|
1145
|
-
if err := json.Unmarshal([]byte(strings.TrimSpace(out)), &env); err != nil {
|
|
1146
|
-
t.Fatalf("stdout is not a valid SubagentStart envelope: %v\n%s", err, out)
|
|
1147
|
-
}
|
|
1148
|
-
if env.HookSpecificOutput.HookEventName != "SubagentStart" {
|
|
1149
|
-
t.Errorf("hookEventName = %q, want SubagentStart", env.HookSpecificOutput.HookEventName)
|
|
1150
|
-
}
|
|
1151
|
-
for _, want := range []string{"DevRites subagent", "Operating rules", "ignored path", "native filesystem", "Engram arguments", "session_id", "task_name", "orchestration depth"} {
|
|
1152
|
-
if !strings.Contains(env.HookSpecificOutput.AdditionalContext, want) {
|
|
1153
|
-
t.Errorf("additionalContext missing %q", want)
|
|
1154
|
-
}
|
|
1155
|
-
}
|
|
1156
|
-
})
|
|
1157
|
-
}
|
|
1158
|
-
}
|
|
1159
|
-
|
|
1160
|
-
func TestHookSubagentOrientSilentForNonDevritesAgent(t *testing.T) {
|
|
1161
|
-
root := newWorkspace(t)
|
|
1162
|
-
for _, in := range []string{`{"agent_type":"Explore"}`, `{"agent_type":""}`, `not json`, ``} {
|
|
1163
|
-
out, _, code := runDevritesIO(t, root, in, nil, "hook", "subagent-orient", "--harness=claude")
|
|
1164
|
-
if code != 0 || strings.TrimSpace(out) != "" {
|
|
1165
|
-
t.Errorf("want silent exit 0 for payload %q; got exit=%d out=%q", in, code, out)
|
|
1166
|
-
}
|
|
1167
|
-
}
|
|
1168
|
-
}
|
|
1169
|
-
|
|
1170
|
-
func TestHookSubagentOrientCapturesWrightCanonicalBoundary(t *testing.T) {
|
|
1171
|
-
root := newWorkspace(t)
|
|
1172
|
-
writeActive(t, root, "auth-tokens")
|
|
1173
|
-
workspace := filepath.Join(root, "features", "auth-tokens")
|
|
1174
|
-
if err := os.MkdirAll(filepath.Join(workspace, ".reconcile-objects"), 0o700); err != nil {
|
|
1175
|
-
t.Fatal(err)
|
|
1176
|
-
}
|
|
1177
|
-
for name, body := range map[string]string{
|
|
1178
|
-
".reconcile-base": "base\n",
|
|
1179
|
-
".reconcile-allowlist": "",
|
|
1180
|
-
".reconcile-devrites": "[]\n",
|
|
1181
|
-
"state.md": "Phase: build\n",
|
|
1182
|
-
"browser-evidence.md": "Prior root evidence\n",
|
|
1183
|
-
} {
|
|
1184
|
-
if err := os.WriteFile(filepath.Join(workspace, name), []byte(body), 0o600); err != nil {
|
|
1185
|
-
t.Fatal(err)
|
|
1186
|
-
}
|
|
1187
|
-
}
|
|
1188
|
-
|
|
1189
|
-
in := `{"agent_type":"devrites-slice-wright"}`
|
|
1190
|
-
out, errOut, code := runDevritesIO(t, root, in, nil, "hook", "subagent-orient", "--harness=claude")
|
|
1191
|
-
if code != 0 {
|
|
1192
|
-
t.Fatalf("exit = %d, want 0 (stderr: %s)", code, errOut)
|
|
1193
|
-
}
|
|
1194
|
-
if strings.Contains(out, "Wright boundary unavailable") {
|
|
1195
|
-
t.Fatalf("wright start was blocked: %s", out)
|
|
1196
|
-
}
|
|
1197
|
-
raw, err := os.ReadFile(filepath.Join(workspace, ".reconcile-wright-devrites"))
|
|
1198
|
-
if err != nil {
|
|
1199
|
-
t.Fatalf("read wright boundary: %v", err)
|
|
1200
|
-
}
|
|
1201
|
-
for _, path := range []string{"features/auth-tokens/state.md", "features/auth-tokens/browser-evidence.md"} {
|
|
1202
|
-
if !strings.Contains(string(raw), path) {
|
|
1203
|
-
t.Errorf("wright boundary omitted %s: %s", path, raw)
|
|
1204
|
-
}
|
|
1205
|
-
}
|
|
1206
|
-
}
|
|
1207
|
-
|
|
1208
|
-
func hookPayload(t *testing.T, value map[string]any) string {
|
|
1209
|
-
t.Helper()
|
|
1210
|
-
raw, err := json.Marshal(value)
|
|
1211
|
-
if err != nil {
|
|
1212
|
-
t.Fatal(err)
|
|
1213
|
-
}
|
|
1214
|
-
return string(raw)
|
|
1215
|
-
}
|
|
1216
|
-
|
|
1217
|
-
func writeCodexAgentContract(t *testing.T, root, role string) {
|
|
1218
|
-
t.Helper()
|
|
1219
|
-
dir := filepath.Join(filepath.Dir(root), ".codex", "agents")
|
|
1220
|
-
if err := os.MkdirAll(dir, 0o755); err != nil {
|
|
1221
|
-
t.Fatal(err)
|
|
1222
|
-
}
|
|
1223
|
-
contract := "name = \"" + role + "\"\ndeveloper_instructions = '''\nROLE-CONTRACT:" + role + "\n'''\n"
|
|
1224
|
-
if err := os.WriteFile(filepath.Join(dir, role+".toml"), []byte(contract), 0o600); err != nil {
|
|
1225
|
-
t.Fatal(err)
|
|
1226
|
-
}
|
|
1227
|
-
}
|
|
1228
|
-
|
|
1229
|
-
func writeCodexSkillContract(t *testing.T, root, skill, roles string) {
|
|
1230
|
-
t.Helper()
|
|
1231
|
-
dir := filepath.Join(filepath.Dir(root), ".agents", "skills", skill)
|
|
1232
|
-
if err := os.MkdirAll(dir, 0o755); err != nil {
|
|
1233
|
-
t.Fatal(err)
|
|
1234
|
-
}
|
|
1235
|
-
contract := "---\nname: " + skill + "\ndescription: Test skill.\nrequired-agent-roles: " + roles + "\n---\n"
|
|
1236
|
-
if err := os.WriteFile(filepath.Join(dir, "SKILL.md"), []byte(contract), 0o600); err != nil {
|
|
1237
|
-
t.Fatal(err)
|
|
1238
|
-
}
|
|
1239
|
-
}
|
|
1240
|
-
|
|
1241
|
-
func writeCodexConditionalSkillContract(t *testing.T, root, skill, role string) {
|
|
1242
|
-
t.Helper()
|
|
1243
|
-
dir := filepath.Join(filepath.Dir(root), ".agents", "skills", skill)
|
|
1244
|
-
if err := os.MkdirAll(dir, 0o755); err != nil {
|
|
1245
|
-
t.Fatal(err)
|
|
1246
|
-
}
|
|
1247
|
-
contract := "---\nname: " + skill + "\ndescription: Test skill.\nrequired-agent-roles: none\n---\n\nConditionally dispatch `" + role + "` when needed.\n"
|
|
1248
|
-
if err := os.WriteFile(filepath.Join(dir, "SKILL.md"), []byte(contract), 0o600); err != nil {
|
|
1249
|
-
t.Fatal(err)
|
|
1250
|
-
}
|
|
1251
|
-
}
|
|
1252
|
-
|
|
1253
|
-
func writeCodexV2Rollouts(
|
|
1254
|
-
t *testing.T,
|
|
1255
|
-
codeHome, projectRoot, sessionID, turnID, role, taskName string,
|
|
1256
|
-
includeWait, includeInstructions, includeResult bool,
|
|
1257
|
-
) {
|
|
1258
|
-
t.Helper()
|
|
1259
|
-
dir := filepath.Join(codeHome, "sessions", "2026", "07", "25")
|
|
1260
|
-
if err := os.MkdirAll(dir, 0o700); err != nil {
|
|
1261
|
-
t.Fatal(err)
|
|
1262
|
-
}
|
|
1263
|
-
at := time.Now().UTC()
|
|
1264
|
-
parent := []map[string]any{
|
|
1265
|
-
{
|
|
1266
|
-
"timestamp": at.Format(time.RFC3339Nano),
|
|
1267
|
-
"type": "session_meta",
|
|
1268
|
-
"payload": map[string]any{
|
|
1269
|
-
"session_id": sessionID,
|
|
1270
|
-
"id": sessionID,
|
|
1271
|
-
"cwd": projectRoot,
|
|
1272
|
-
},
|
|
1273
|
-
},
|
|
1274
|
-
{
|
|
1275
|
-
"timestamp": at.Add(time.Millisecond).Format(time.RFC3339Nano),
|
|
1276
|
-
"type": "response_item",
|
|
1277
|
-
"payload": map[string]any{
|
|
1278
|
-
"type": "function_call",
|
|
1279
|
-
"name": "spawn_agent",
|
|
1280
|
-
"arguments": `{"agent_type":"` + role + `","task_name":"` + taskName + `","fork_turns":"none","message":"encrypted"}`,
|
|
1281
|
-
"internal_chat_message_metadata_passthrough": map[string]any{
|
|
1282
|
-
"turn_id": turnID,
|
|
1283
|
-
},
|
|
1284
|
-
},
|
|
1285
|
-
},
|
|
1286
|
-
}
|
|
1287
|
-
if includeWait {
|
|
1288
|
-
parent = append(parent, map[string]any{
|
|
1289
|
-
"timestamp": at.Add(2 * time.Millisecond).Format(time.RFC3339Nano),
|
|
1290
|
-
"type": "response_item",
|
|
1291
|
-
"payload": map[string]any{
|
|
1292
|
-
"type": "function_call",
|
|
1293
|
-
"name": "wait_agent",
|
|
1294
|
-
"arguments": `{"timeout_ms":3600000}`,
|
|
1295
|
-
"internal_chat_message_metadata_passthrough": map[string]any{
|
|
1296
|
-
"turn_id": turnID,
|
|
1297
|
-
},
|
|
1298
|
-
},
|
|
1299
|
-
})
|
|
1300
|
-
}
|
|
1301
|
-
if includeResult {
|
|
1302
|
-
parent = append(parent, map[string]any{
|
|
1303
|
-
"timestamp": at.Add(3 * time.Millisecond).Format(time.RFC3339Nano),
|
|
1304
|
-
"type": "response_item",
|
|
1305
|
-
"payload": map[string]any{
|
|
1306
|
-
"type": "agent_message",
|
|
1307
|
-
"author": "/root/" + taskName,
|
|
1308
|
-
"recipient": "/root",
|
|
1309
|
-
"content": []map[string]any{{
|
|
1310
|
-
"type": "input_text",
|
|
1311
|
-
"text": "Message Type: FINAL_ANSWER\nPayload:\nagent-result/v1 complete",
|
|
1312
|
-
}},
|
|
1313
|
-
"internal_chat_message_metadata_passthrough": map[string]any{
|
|
1314
|
-
"turn_id": turnID,
|
|
1315
|
-
},
|
|
1316
|
-
},
|
|
1317
|
-
})
|
|
1318
|
-
}
|
|
1319
|
-
writeJSONLines(t, filepath.Join(dir, "rollout-parent-"+sessionID+".jsonl"), parent)
|
|
1320
|
-
|
|
1321
|
-
child := []map[string]any{
|
|
1322
|
-
{
|
|
1323
|
-
"timestamp": at.Add(time.Millisecond).Format(time.RFC3339Nano),
|
|
1324
|
-
"type": "session_meta",
|
|
1325
|
-
"payload": map[string]any{
|
|
1326
|
-
"session_id": sessionID,
|
|
1327
|
-
"id": "child-" + taskName,
|
|
1328
|
-
"parent_thread_id": sessionID,
|
|
1329
|
-
"cwd": projectRoot,
|
|
1330
|
-
"agent_path": "/root/" + taskName,
|
|
1331
|
-
"agent_role": role,
|
|
1332
|
-
},
|
|
1333
|
-
},
|
|
1334
|
-
}
|
|
1335
|
-
if includeInstructions {
|
|
1336
|
-
child = append(child, map[string]any{
|
|
1337
|
-
"timestamp": at.Add(2 * time.Millisecond).Format(time.RFC3339Nano),
|
|
1338
|
-
"type": "response_item",
|
|
1339
|
-
"payload": map[string]any{
|
|
1340
|
-
"type": "message",
|
|
1341
|
-
"role": "developer",
|
|
1342
|
-
"content": []map[string]any{{
|
|
1343
|
-
"type": "input_text",
|
|
1344
|
-
"text": "ROLE-CONTRACT:" + role,
|
|
1345
|
-
}},
|
|
1346
|
-
},
|
|
1347
|
-
})
|
|
1348
|
-
}
|
|
1349
|
-
if includeResult {
|
|
1350
|
-
child = append(child, map[string]any{
|
|
1351
|
-
"timestamp": at.Add(3 * time.Millisecond).Format(time.RFC3339Nano),
|
|
1352
|
-
"type": "event_msg",
|
|
1353
|
-
"payload": map[string]any{
|
|
1354
|
-
"type": "task_complete",
|
|
1355
|
-
"last_agent_message": "agent-result/v1 complete",
|
|
1356
|
-
},
|
|
1357
|
-
})
|
|
1358
|
-
}
|
|
1359
|
-
writeJSONLines(t, filepath.Join(dir, "rollout-child-"+taskName+".jsonl"), child)
|
|
1360
|
-
}
|
|
1361
|
-
|
|
1362
|
-
func writeJSONLines(t *testing.T, path string, records []map[string]any) {
|
|
1363
|
-
t.Helper()
|
|
1364
|
-
var lines []string
|
|
1365
|
-
for _, record := range records {
|
|
1366
|
-
raw, err := json.Marshal(record)
|
|
1367
|
-
if err != nil {
|
|
1368
|
-
t.Fatal(err)
|
|
1369
|
-
}
|
|
1370
|
-
lines = append(lines, string(raw))
|
|
1371
|
-
}
|
|
1372
|
-
if err := os.WriteFile(path, []byte(strings.Join(lines, "\n")+"\n"), 0o600); err != nil {
|
|
1373
|
-
t.Fatal(err)
|
|
1374
|
-
}
|
|
1375
|
-
}
|
|
1376
|
-
|
|
1377
|
-
func TestCodexAgentDispatchArmsInstalledSkillRequirements(t *testing.T) {
|
|
1378
|
-
for _, tc := range []struct {
|
|
1379
|
-
name string
|
|
1380
|
-
invocation string
|
|
1381
|
-
roles string
|
|
1382
|
-
wantRoles []string
|
|
1383
|
-
}{
|
|
1384
|
-
{
|
|
1385
|
-
name: "single-role-dollar-invocation",
|
|
1386
|
-
invocation: "$rite-vet",
|
|
1387
|
-
roles: "devrites-plan-reviewer",
|
|
1388
|
-
wantRoles: []string{"devrites-plan-reviewer"},
|
|
1389
|
-
},
|
|
1390
|
-
{
|
|
1391
|
-
name: "multi-role-slash-invocation",
|
|
1392
|
-
invocation: "/rite-review",
|
|
1393
|
-
roles: "devrites-spec-reviewer, devrites-code-reviewer",
|
|
1394
|
-
wantRoles: []string{"devrites-code-reviewer", "devrites-spec-reviewer"},
|
|
1395
|
-
},
|
|
1396
|
-
{
|
|
1397
|
-
name: "declared-no-agent",
|
|
1398
|
-
invocation: "$rite-status",
|
|
1399
|
-
roles: "none",
|
|
1400
|
-
},
|
|
1401
|
-
} {
|
|
1402
|
-
t.Run(tc.name, func(t *testing.T) {
|
|
1403
|
-
root := newWorkspace(t)
|
|
1404
|
-
skill := strings.TrimLeft(tc.invocation, "$/")
|
|
1405
|
-
writeCodexSkillContract(t, root, skill, tc.roles)
|
|
1406
|
-
for _, role := range tc.wantRoles {
|
|
1407
|
-
writeCodexAgentContract(t, root, role)
|
|
1408
|
-
}
|
|
1409
|
-
sessionID, turnID := "session-"+tc.name, "turn-"+tc.name
|
|
1410
|
-
out, stderr, code := runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
1411
|
-
"hook_event_name": "UserPromptSubmit",
|
|
1412
|
-
"session_id": sessionID,
|
|
1413
|
-
"turn_id": turnID,
|
|
1414
|
-
"prompt": tc.invocation,
|
|
1415
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
1416
|
-
if code != 0 {
|
|
1417
|
-
t.Fatalf("arm exit=%d stderr=%s", code, stderr)
|
|
1418
|
-
}
|
|
1419
|
-
for _, role := range tc.wantRoles {
|
|
1420
|
-
if !strings.Contains(out, role) {
|
|
1421
|
-
t.Fatalf("arm output omitted %s: %s", role, out)
|
|
1422
|
-
}
|
|
1423
|
-
}
|
|
1424
|
-
|
|
1425
|
-
stopOut, stopErr, stopCode := runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
1426
|
-
"hook_event_name": "Stop",
|
|
1427
|
-
"session_id": sessionID,
|
|
1428
|
-
"turn_id": turnID,
|
|
1429
|
-
"stop_hook_active": false,
|
|
1430
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
1431
|
-
if stopCode != 0 {
|
|
1432
|
-
t.Fatalf("stop exit=%d stderr=%s", stopCode, stopErr)
|
|
1433
|
-
}
|
|
1434
|
-
if len(tc.wantRoles) == 0 {
|
|
1435
|
-
if strings.TrimSpace(stopOut) != "" {
|
|
1436
|
-
t.Fatalf("no-agent skill was blocked: %s", stopOut)
|
|
1437
|
-
}
|
|
1438
|
-
return
|
|
1439
|
-
}
|
|
1440
|
-
for _, role := range tc.wantRoles {
|
|
1441
|
-
if strings.Contains(stopOut, role) {
|
|
1442
|
-
return
|
|
1443
|
-
}
|
|
1444
|
-
}
|
|
1445
|
-
t.Fatalf("required skill roles did not block Stop: %s", stopOut)
|
|
1446
|
-
})
|
|
1447
|
-
}
|
|
1448
|
-
}
|
|
1449
|
-
|
|
1450
|
-
func TestCodexAgentDispatchPromptGivesExactNamedCallBeforeCompletion(t *testing.T) {
|
|
1451
|
-
root := newWorkspace(t)
|
|
1452
|
-
role := "devrites-plan-drafter"
|
|
1453
|
-
writeCodexAgentContract(t, root, role)
|
|
1454
|
-
writeCodexSkillContract(t, root, "rite-plan", role)
|
|
1455
|
-
|
|
1456
|
-
out, stderr, code := runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
1457
|
-
"hook_event_name": "UserPromptSubmit",
|
|
1458
|
-
"session_id": "session-plan-drafter-guidance",
|
|
1459
|
-
"turn_id": "turn-plan-drafter-guidance",
|
|
1460
|
-
"prompt": "$rite-plan repair",
|
|
1461
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
1462
|
-
if code != 0 {
|
|
1463
|
-
t.Fatalf("arm exit=%d stderr=%s", code, stderr)
|
|
1464
|
-
}
|
|
1465
|
-
for _, want := range []string{
|
|
1466
|
-
"MANDATORY DISPATCH THIS TURN",
|
|
1467
|
-
"spawn_agent",
|
|
1468
|
-
"agent_type=" + role,
|
|
1469
|
-
"unique task_name",
|
|
1470
|
-
`fork_turns="none"`,
|
|
1471
|
-
".codex/agents/" + role + ".toml",
|
|
1472
|
-
"send agent_type anyway",
|
|
1473
|
-
"Schema omission alone is not capability loss",
|
|
1474
|
-
"only after the runtime explicitly identifies MultiAgent V1",
|
|
1475
|
-
"stop before any generic/default spawn",
|
|
1476
|
-
"Wait for the returned child",
|
|
1477
|
-
"PRE-DISPATCH STOP RULE",
|
|
1478
|
-
"do not spawn only to satisfy this receipt",
|
|
1479
|
-
"devrites-engine dispatch-waive <reason>",
|
|
1480
|
-
"readiness-failed",
|
|
1481
|
-
"human-gate-before-dispatch",
|
|
1482
|
-
"never waive after a spawn attempt",
|
|
1483
|
-
} {
|
|
1484
|
-
if !strings.Contains(out, want) {
|
|
1485
|
-
t.Fatalf("initial dispatch guidance omitted %q:\n%s", want, out)
|
|
1486
|
-
}
|
|
1487
|
-
}
|
|
1488
|
-
}
|
|
1489
|
-
|
|
1490
|
-
func TestCodexConditionalAgentDispatchRejectsDefaultAndArmsNamedRole(t *testing.T) {
|
|
1491
|
-
root := newWorkspace(t)
|
|
1492
|
-
role := "devrites-proof-runner"
|
|
1493
|
-
writeCodexAgentContract(t, root, role)
|
|
1494
|
-
writeCodexConditionalSkillContract(t, root, "rite-polish", role)
|
|
1495
|
-
sessionID, turnID := "session-conditional-role", "turn-conditional-role"
|
|
1496
|
-
|
|
1497
|
-
out, stderr, code := runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
1498
|
-
"hook_event_name": "UserPromptSubmit",
|
|
1499
|
-
"session_id": sessionID,
|
|
1500
|
-
"turn_id": turnID,
|
|
1501
|
-
"prompt": "$rite-polish",
|
|
1502
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
1503
|
-
if code != 0 {
|
|
1504
|
-
t.Fatalf("arm exit=%d stderr=%s", code, stderr)
|
|
1505
|
-
}
|
|
1506
|
-
for _, want := range []string{
|
|
1507
|
-
"CONDITIONAL DISPATCH RULE",
|
|
1508
|
-
"exact named agent_type=devrites-<role>",
|
|
1509
|
-
`fork_turns="none"`,
|
|
1510
|
-
"send agent_type anyway",
|
|
1511
|
-
"Schema omission alone is not capability loss",
|
|
1512
|
-
"only after the runtime explicitly identifies MultiAgent V1",
|
|
1513
|
-
"stop before any generic/default spawn",
|
|
1514
|
-
"never use a default child",
|
|
1515
|
-
} {
|
|
1516
|
-
if !strings.Contains(out, want) {
|
|
1517
|
-
t.Fatalf("conditional dispatch guidance omitted %q:\n%s", want, out)
|
|
1518
|
-
}
|
|
1519
|
-
}
|
|
1520
|
-
|
|
1521
|
-
for _, agentType := range []string{"", "default"} {
|
|
1522
|
-
out, stderr, code = runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
1523
|
-
"hook_event_name": "PreToolUse",
|
|
1524
|
-
"session_id": sessionID,
|
|
1525
|
-
"turn_id": turnID,
|
|
1526
|
-
"tool_name": "spawn_agent",
|
|
1527
|
-
"tool_use_id": "default-" + agentType,
|
|
1528
|
-
"tool_input": map[string]any{
|
|
1529
|
-
"agent_type": agentType,
|
|
1530
|
-
"task_name": "conditional_default",
|
|
1531
|
-
"fork_turns": "none",
|
|
1532
|
-
"message": "Run the conditional DevRites check.",
|
|
1533
|
-
},
|
|
1534
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
1535
|
-
if code != 0 {
|
|
1536
|
-
t.Fatalf("default spawn exit=%d stderr=%s", code, stderr)
|
|
1537
|
-
}
|
|
1538
|
-
if decision, reason := parsePermissionDecision(t, out); decision != "deny" ||
|
|
1539
|
-
!strings.Contains(reason, "exact named agent_type=devrites-<role>") {
|
|
1540
|
-
t.Fatalf("conditional default child not denied: decision=%q reason=%q out=%s", decision, reason, out)
|
|
1541
|
-
}
|
|
1542
|
-
}
|
|
1543
|
-
|
|
1544
|
-
out, stderr, code = runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
1545
|
-
"hook_event_name": "PreToolUse",
|
|
1546
|
-
"session_id": sessionID,
|
|
1547
|
-
"turn_id": turnID,
|
|
1548
|
-
"tool_name": "spawn_agent",
|
|
1549
|
-
"tool_use_id": "missing-named-type",
|
|
1550
|
-
"tool_input": map[string]any{
|
|
1551
|
-
"task_name": "conditional_missing_type",
|
|
1552
|
-
"fork_turns": "none",
|
|
1553
|
-
"message": "Read .codex/agents/" + role + ".toml and run the check.",
|
|
1554
|
-
},
|
|
1555
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
1556
|
-
if code != 0 {
|
|
1557
|
-
t.Fatalf("missing type spawn exit=%d stderr=%s", code, stderr)
|
|
1558
|
-
}
|
|
1559
|
-
if decision, reason := parsePermissionDecision(t, out); decision != "deny" ||
|
|
1560
|
-
!strings.Contains(reason, "agent_type="+role) ||
|
|
1561
|
-
!strings.Contains(reason, "send agent_type anyway") {
|
|
1562
|
-
t.Fatalf("missing named type did not get exact retry: decision=%q reason=%q out=%s", decision, reason, out)
|
|
1563
|
-
}
|
|
1564
|
-
|
|
1565
|
-
out, stderr, code = runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
1566
|
-
"hook_event_name": "PreToolUse",
|
|
1567
|
-
"session_id": sessionID,
|
|
1568
|
-
"turn_id": turnID,
|
|
1569
|
-
"tool_name": "spawn_agent",
|
|
1570
|
-
"tool_use_id": "named-conditional",
|
|
1571
|
-
"tool_input": map[string]any{
|
|
1572
|
-
"agent_type": role,
|
|
1573
|
-
"task_name": "conditional_proof",
|
|
1574
|
-
"fork_turns": "none",
|
|
1575
|
-
"message": "Run the conditional DevRites check.",
|
|
1576
|
-
},
|
|
1577
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
1578
|
-
if code != 0 || strings.TrimSpace(out) != "" {
|
|
1579
|
-
t.Fatalf("named conditional spawn rejected: exit=%d out=%s stderr=%s", code, out, stderr)
|
|
1580
|
-
}
|
|
1581
|
-
|
|
1582
|
-
out, stderr, code = runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
1583
|
-
"hook_event_name": "Stop",
|
|
1584
|
-
"session_id": sessionID,
|
|
1585
|
-
"turn_id": turnID,
|
|
1586
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
1587
|
-
if code != 0 || !strings.Contains(out, "DevRites dispatch for "+role+" is not complete") {
|
|
1588
|
-
t.Fatalf("named conditional spawn was not armed: exit=%d out=%s stderr=%s", code, out, stderr)
|
|
1589
|
-
}
|
|
1590
|
-
}
|
|
1591
|
-
|
|
1592
|
-
func TestCodexAgentDispatchAllowsDefaultChildOutsideSkillTurn(t *testing.T) {
|
|
1593
|
-
root := newWorkspace(t)
|
|
1594
|
-
out, stderr, code := runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
1595
|
-
"hook_event_name": "PreToolUse",
|
|
1596
|
-
"session_id": "session-unrelated-default",
|
|
1597
|
-
"turn_id": "turn-unrelated-default",
|
|
1598
|
-
"tool_name": "spawn_agent",
|
|
1599
|
-
"tool_use_id": "unrelated-default",
|
|
1600
|
-
"tool_input": map[string]any{
|
|
1601
|
-
"agent_type": "default",
|
|
1602
|
-
"task_name": "unrelated",
|
|
1603
|
-
"fork_turns": "all",
|
|
1604
|
-
"message": "Handle an unrelated bounded task.",
|
|
1605
|
-
},
|
|
1606
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
1607
|
-
if code != 0 || strings.TrimSpace(out) != "" {
|
|
1608
|
-
t.Fatalf("unrelated default child was rejected: exit=%d out=%s stderr=%s", code, out, stderr)
|
|
1609
|
-
}
|
|
1610
|
-
}
|
|
1611
|
-
|
|
1612
|
-
func TestCodexAgentDispatchRejectsInvalidInstalledSkillRequirements(t *testing.T) {
|
|
1613
|
-
root := newWorkspace(t)
|
|
1614
|
-
writeCodexSkillContract(t, root, "rite-vet", "root-inline-reviewer")
|
|
1615
|
-
out, stderr, code := runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
1616
|
-
"hook_event_name": "UserPromptSubmit",
|
|
1617
|
-
"session_id": "session-invalid-skill",
|
|
1618
|
-
"turn_id": "turn-invalid-skill",
|
|
1619
|
-
"prompt": "$rite-vet",
|
|
1620
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
1621
|
-
if code != 0 {
|
|
1622
|
-
t.Fatalf("invalid metadata exit=%d stderr=%s", code, stderr)
|
|
1623
|
-
}
|
|
1624
|
-
var decision struct {
|
|
1625
|
-
Decision string `json:"decision"`
|
|
1626
|
-
Reason string `json:"reason"`
|
|
1627
|
-
}
|
|
1628
|
-
if err := json.Unmarshal([]byte(strings.TrimSpace(out)), &decision); err != nil {
|
|
1629
|
-
t.Fatalf("invalid metadata response: %v\n%s", err, out)
|
|
1630
|
-
}
|
|
1631
|
-
if decision.Decision != "block" || !strings.Contains(decision.Reason, "invalid required agent role") {
|
|
1632
|
-
t.Fatalf("invalid skill metadata did not fail closed: %#v", decision)
|
|
1633
|
-
}
|
|
1634
|
-
stopOut, stopErr, stopCode := runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
1635
|
-
"hook_event_name": "Stop",
|
|
1636
|
-
"session_id": "session-invalid-skill",
|
|
1637
|
-
"turn_id": "turn-invalid-skill",
|
|
1638
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
1639
|
-
if stopCode != 0 || !strings.Contains(stopOut, "required-agent-roles contract is invalid") {
|
|
1640
|
-
t.Fatalf("invalid skill metadata did not remain fail closed at Stop: exit=%d out=%s stderr=%s", stopCode, stopOut, stopErr)
|
|
1641
|
-
}
|
|
1642
|
-
}
|
|
1643
|
-
|
|
1644
|
-
func TestCodexAgentDispatchDoesNotArmSkillNamesInsideURLs(t *testing.T) {
|
|
1645
|
-
root := newWorkspace(t)
|
|
1646
|
-
writeCodexSkillContract(t, root, "rite-vet", "devrites-plan-reviewer")
|
|
1647
|
-
sessionID, turnID := "session-skill-url", "turn-skill-url"
|
|
1648
|
-
runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
1649
|
-
"hook_event_name": "UserPromptSubmit",
|
|
1650
|
-
"session_id": sessionID,
|
|
1651
|
-
"turn_id": turnID,
|
|
1652
|
-
"prompt": "Read https://example.test/rite-vet before answering.",
|
|
1653
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
1654
|
-
out, stderr, code := runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
1655
|
-
"hook_event_name": "Stop",
|
|
1656
|
-
"session_id": sessionID,
|
|
1657
|
-
"turn_id": turnID,
|
|
1658
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
1659
|
-
if code != 0 || strings.TrimSpace(out) != "" {
|
|
1660
|
-
t.Fatalf("URL path armed a skill: exit=%d out=%s stderr=%s", code, out, stderr)
|
|
1661
|
-
}
|
|
1662
|
-
}
|
|
1663
|
-
|
|
1664
|
-
func TestCodexAgentDispatchDoesNotArmBareAgentContractReference(t *testing.T) {
|
|
1665
|
-
root := newWorkspace(t)
|
|
1666
|
-
writeCodexAgentContract(t, root, "devrites-security-auditor")
|
|
1667
|
-
sessionID, turnID := "session-agent-reference", "turn-agent-reference"
|
|
1668
|
-
runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
1669
|
-
"hook_event_name": "UserPromptSubmit",
|
|
1670
|
-
"session_id": sessionID,
|
|
1671
|
-
"turn_id": turnID,
|
|
1672
|
-
"prompt": "Explain .codex/agents/devrites-security-auditor.toml without running it.",
|
|
1673
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
1674
|
-
out, stderr, code := runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
1675
|
-
"hook_event_name": "Stop",
|
|
1676
|
-
"session_id": sessionID,
|
|
1677
|
-
"turn_id": turnID,
|
|
1678
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
1679
|
-
if code != 0 || strings.TrimSpace(out) != "" {
|
|
1680
|
-
t.Fatalf("bare agent reference armed dispatch: exit=%d out=%s stderr=%s", code, out, stderr)
|
|
1681
|
-
}
|
|
1682
|
-
}
|
|
1683
|
-
|
|
1684
|
-
func TestCodexAgentDispatchBlocksFalseWaitAndStop(t *testing.T) {
|
|
1685
|
-
root := newWorkspace(t)
|
|
1686
|
-
writeCodexSkillContract(t, root, "devrites-audit", "devrites-security-auditor")
|
|
1687
|
-
sessionID, turnID := "session-false-wait", "turn-false-wait"
|
|
1688
|
-
prompt := hookPayload(t, map[string]any{
|
|
1689
|
-
"hook_event_name": "UserPromptSubmit",
|
|
1690
|
-
"session_id": sessionID,
|
|
1691
|
-
"turn_id": turnID,
|
|
1692
|
-
"prompt": "$devrites-audit Call spawn_agent and tell it to read .codex/agents/devrites-security-auditor.toml.",
|
|
1693
|
-
})
|
|
1694
|
-
if _, stderr, code := runDevritesIO(t, root, prompt, nil,
|
|
1695
|
-
"hook", "agent-dispatch", "--harness=codex"); code != 0 {
|
|
1696
|
-
t.Fatalf("arm exit=%d stderr=%s", code, stderr)
|
|
1697
|
-
}
|
|
1698
|
-
|
|
1699
|
-
wait := hookPayload(t, map[string]any{
|
|
1700
|
-
"hook_event_name": "PreToolUse",
|
|
1701
|
-
"session_id": sessionID,
|
|
1702
|
-
"turn_id": turnID,
|
|
1703
|
-
"tool_name": "wait",
|
|
1704
|
-
"tool_input": map[string]any{"receiver_thread_ids": []string{}},
|
|
1705
|
-
})
|
|
1706
|
-
out, stderr, code := runDevritesIO(t, root, wait, nil,
|
|
1707
|
-
"hook", "agent-dispatch", "--harness=codex")
|
|
1708
|
-
if code != 0 {
|
|
1709
|
-
t.Fatalf("wait exit=%d stderr=%s", code, stderr)
|
|
1710
|
-
}
|
|
1711
|
-
if decision, reason := parsePermissionDecision(t, out); decision != "deny" ||
|
|
1712
|
-
!strings.Contains(reason, "spawn_agent") {
|
|
1713
|
-
t.Fatalf("false wait not denied: decision=%q reason=%q out=%s", decision, reason, out)
|
|
1714
|
-
}
|
|
1715
|
-
|
|
1716
|
-
stop := hookPayload(t, map[string]any{
|
|
1717
|
-
"hook_event_name": "Stop",
|
|
1718
|
-
"session_id": sessionID,
|
|
1719
|
-
"turn_id": turnID,
|
|
1720
|
-
"stop_hook_active": false,
|
|
1721
|
-
})
|
|
1722
|
-
out, stderr, code = runDevritesIO(t, root, stop, nil,
|
|
1723
|
-
"hook", "agent-dispatch", "--harness=codex")
|
|
1724
|
-
if code != 0 {
|
|
1725
|
-
t.Fatalf("stop exit=%d stderr=%s", code, stderr)
|
|
1726
|
-
}
|
|
1727
|
-
var stopDecision struct {
|
|
1728
|
-
Decision string `json:"decision"`
|
|
1729
|
-
Reason string `json:"reason"`
|
|
1730
|
-
}
|
|
1731
|
-
if err := json.Unmarshal([]byte(strings.TrimSpace(out)), &stopDecision); err != nil {
|
|
1732
|
-
t.Fatalf("invalid Stop response: %v\n%s", err, out)
|
|
1733
|
-
}
|
|
1734
|
-
if stopDecision.Decision != "block" ||
|
|
1735
|
-
!strings.Contains(stopDecision.Reason, "spawn_agent") ||
|
|
1736
|
-
!strings.Contains(stopDecision.Reason, "visible tool schema") ||
|
|
1737
|
-
!strings.Contains(stopDecision.Reason, "send agent_type anyway") ||
|
|
1738
|
-
!strings.Contains(stopDecision.Reason, "Schema omission alone is not capability loss") ||
|
|
1739
|
-
!strings.Contains(stopDecision.Reason, "stop before any generic/default spawn") ||
|
|
1740
|
-
!strings.Contains(stopDecision.Reason, "do not spawn only to satisfy this receipt") ||
|
|
1741
|
-
!strings.Contains(stopDecision.Reason, "dispatch-waive <reason>") {
|
|
1742
|
-
t.Fatalf("false completion not blocked: %#v", stopDecision)
|
|
1743
|
-
}
|
|
1744
|
-
|
|
1745
|
-
stop = hookPayload(t, map[string]any{
|
|
1746
|
-
"hook_event_name": "Stop",
|
|
1747
|
-
"session_id": sessionID,
|
|
1748
|
-
"turn_id": turnID,
|
|
1749
|
-
"stop_hook_active": true,
|
|
1750
|
-
})
|
|
1751
|
-
out, stderr, code = runDevritesIO(t, root, stop, nil,
|
|
1752
|
-
"hook", "agent-dispatch", "--harness=codex")
|
|
1753
|
-
if code != 0 {
|
|
1754
|
-
t.Fatalf("second stop exit=%d stderr=%s", code, stderr)
|
|
1755
|
-
}
|
|
1756
|
-
var terminal struct {
|
|
1757
|
-
Continue bool `json:"continue"`
|
|
1758
|
-
StopReason string `json:"stopReason"`
|
|
1759
|
-
}
|
|
1760
|
-
if err := json.Unmarshal([]byte(strings.TrimSpace(out)), &terminal); err != nil {
|
|
1761
|
-
t.Fatalf("invalid terminal Stop response: %v\n%s", err, out)
|
|
1762
|
-
}
|
|
1763
|
-
if terminal.Continue || !strings.Contains(terminal.StopReason, "spawn_agent") {
|
|
1764
|
-
t.Fatalf("second false completion was not stopped: %#v", terminal)
|
|
1765
|
-
}
|
|
1766
|
-
}
|
|
1767
|
-
|
|
1768
|
-
func TestCodexAgentDispatchRequiresSuccessfulReasonBoundWaiver(t *testing.T) {
|
|
1769
|
-
root := newWorkspace(t)
|
|
1770
|
-
role := "devrites-plan-reviewer"
|
|
1771
|
-
writeCodexAgentContract(t, root, role)
|
|
1772
|
-
writeCodexSkillContract(t, root, "rite-vet", role)
|
|
1773
|
-
sessionID, turnID := "session-waiver", "turn-waiver"
|
|
1774
|
-
runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
1775
|
-
"hook_event_name": "UserPromptSubmit",
|
|
1776
|
-
"session_id": sessionID,
|
|
1777
|
-
"turn_id": turnID,
|
|
1778
|
-
"prompt": "$rite-vet",
|
|
1779
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
1780
|
-
|
|
1781
|
-
invalid := hookPayload(t, map[string]any{
|
|
1782
|
-
"hook_event_name": "PreToolUse",
|
|
1783
|
-
"session_id": sessionID,
|
|
1784
|
-
"turn_id": turnID,
|
|
1785
|
-
"tool_name": "functions.exec_command",
|
|
1786
|
-
"tool_input": map[string]any{"cmd": "devrites-engine dispatch-waive wrong-phase && true"},
|
|
1787
|
-
})
|
|
1788
|
-
out, _, _ := runDevritesIO(t, root, invalid, nil,
|
|
1789
|
-
"hook", "agent-dispatch", "--harness=codex")
|
|
1790
|
-
if decision, _ := parsePermissionDecision(t, out); decision != "deny" {
|
|
1791
|
-
t.Fatalf("chained waiver was not denied: %s", out)
|
|
1792
|
-
}
|
|
1793
|
-
|
|
1794
|
-
command := "devrites-engine dispatch-waive readiness-failed"
|
|
1795
|
-
pre := hookPayload(t, map[string]any{
|
|
1796
|
-
"hook_event_name": "PreToolUse",
|
|
1797
|
-
"session_id": sessionID,
|
|
1798
|
-
"turn_id": turnID,
|
|
1799
|
-
"tool_name": "functions.exec_command",
|
|
1800
|
-
"tool_input": map[string]any{"cmd": command},
|
|
1801
|
-
})
|
|
1802
|
-
if out, stderr, code := runDevritesIO(t, root, pre, nil,
|
|
1803
|
-
"hook", "agent-dispatch", "--harness=codex"); code != 0 || strings.TrimSpace(out) != "" {
|
|
1804
|
-
t.Fatalf("waiver pre exit=%d out=%s stderr=%s", code, out, stderr)
|
|
1805
|
-
}
|
|
1806
|
-
|
|
1807
|
-
stop := hookPayload(t, map[string]any{
|
|
1808
|
-
"hook_event_name": "Stop",
|
|
1809
|
-
"session_id": sessionID,
|
|
1810
|
-
"turn_id": turnID,
|
|
1811
|
-
})
|
|
1812
|
-
out, _, _ = runDevritesIO(t, root, stop, nil,
|
|
1813
|
-
"hook", "agent-dispatch", "--harness=codex")
|
|
1814
|
-
if decision, _ := parseStopDecision(t, out); decision != "block" {
|
|
1815
|
-
t.Fatalf("PreToolUse waiver falsely satisfied dispatch: %s", out)
|
|
1816
|
-
}
|
|
1817
|
-
|
|
1818
|
-
post := hookPayload(t, map[string]any{
|
|
1819
|
-
"hook_event_name": "PostToolUse",
|
|
1820
|
-
"session_id": sessionID,
|
|
1821
|
-
"turn_id": turnID,
|
|
1822
|
-
"tool_name": "functions.exec_command",
|
|
1823
|
-
"tool_input": map[string]any{"cmd": command},
|
|
1824
|
-
"tool_response": "dispatch-waive: accepted readiness-failed",
|
|
1825
|
-
})
|
|
1826
|
-
if out, stderr, code := runDevritesIO(t, root, post, nil,
|
|
1827
|
-
"hook", "agent-dispatch", "--harness=codex"); code != 0 || strings.TrimSpace(out) != "" {
|
|
1828
|
-
t.Fatalf("waiver post exit=%d out=%s stderr=%s", code, out, stderr)
|
|
1829
|
-
}
|
|
1830
|
-
if out, stderr, code := runDevritesIO(t, root, stop, nil,
|
|
1831
|
-
"hook", "agent-dispatch", "--harness=codex"); code != 0 || strings.TrimSpace(out) != "" {
|
|
1832
|
-
t.Fatalf("waived stop exit=%d out=%s stderr=%s", code, out, stderr)
|
|
1833
|
-
}
|
|
1834
|
-
}
|
|
1835
|
-
|
|
1836
|
-
func TestCodexAgentDispatchConfirmsGenericRoleAndResult(t *testing.T) {
|
|
1837
|
-
root := newWorkspace(t)
|
|
1838
|
-
sessionID, turnID := "session-complete", "turn-complete"
|
|
1839
|
-
role := "devrites-security-auditor"
|
|
1840
|
-
writeCodexAgentContract(t, root, role)
|
|
1841
|
-
writeCodexSkillContract(t, root, "devrites-audit", role)
|
|
1842
|
-
|
|
1843
|
-
prompt := hookPayload(t, map[string]any{
|
|
1844
|
-
"hook_event_name": "UserPromptSubmit",
|
|
1845
|
-
"session_id": sessionID,
|
|
1846
|
-
"turn_id": turnID,
|
|
1847
|
-
"prompt": "$devrites-audit Call spawn_agent and tell it to read .codex/agents/" + role + ".toml.",
|
|
1848
|
-
})
|
|
1849
|
-
runDevritesIO(t, root, prompt, nil, "hook", "agent-dispatch", "--harness=codex")
|
|
1850
|
-
|
|
1851
|
-
spawn := hookPayload(t, map[string]any{
|
|
1852
|
-
"hook_event_name": "PreToolUse",
|
|
1853
|
-
"session_id": sessionID,
|
|
1854
|
-
"turn_id": turnID,
|
|
1855
|
-
"tool_name": "spawn_agent",
|
|
1856
|
-
"tool_use_id": "spawn-1",
|
|
1857
|
-
"tool_input": map[string]any{
|
|
1858
|
-
"agent_type": "explorer",
|
|
1859
|
-
"fork_turns": "none",
|
|
1860
|
-
"message": "Read .codex/agents/" + role + ".toml and return the requested report.",
|
|
1861
|
-
},
|
|
1862
|
-
})
|
|
1863
|
-
out, stderr, code := runDevritesIO(t, root, spawn, nil,
|
|
1864
|
-
"hook", "agent-dispatch", "--harness=codex")
|
|
1865
|
-
if code != 0 {
|
|
1866
|
-
t.Fatalf("spawn exit=%d out=%s stderr=%s", code, out, stderr)
|
|
1867
|
-
}
|
|
1868
|
-
var rewrite struct {
|
|
1869
|
-
HookSpecificOutput struct {
|
|
1870
|
-
PermissionDecision string `json:"permissionDecision"`
|
|
1871
|
-
UpdatedInput struct {
|
|
1872
|
-
Message string `json:"message"`
|
|
1873
|
-
} `json:"updatedInput"`
|
|
1874
|
-
} `json:"hookSpecificOutput"`
|
|
1875
|
-
}
|
|
1876
|
-
if err := json.Unmarshal([]byte(strings.TrimSpace(out)), &rewrite); err != nil {
|
|
1877
|
-
t.Fatalf("invalid spawn rewrite: %v\n%s", err, out)
|
|
1878
|
-
}
|
|
1879
|
-
if rewrite.HookSpecificOutput.PermissionDecision != "allow" ||
|
|
1880
|
-
!strings.Contains(rewrite.HookSpecificOutput.UpdatedInput.Message, "ROLE-CONTRACT:"+role) ||
|
|
1881
|
-
!strings.Contains(rewrite.HookSpecificOutput.UpdatedInput.Message, "return the requested report") {
|
|
1882
|
-
t.Fatalf("generic spawn did not receive developer_instructions: %#v", rewrite)
|
|
1883
|
-
}
|
|
1884
|
-
|
|
1885
|
-
start := hookPayload(t, map[string]any{
|
|
1886
|
-
"hook_event_name": "SubagentStart",
|
|
1887
|
-
"session_id": sessionID,
|
|
1888
|
-
"turn_id": "child-turn",
|
|
1889
|
-
"agent_id": "agent-1",
|
|
1890
|
-
"agent_type": "explorer",
|
|
1891
|
-
})
|
|
1892
|
-
out, stderr, code = runDevritesIO(t, root, start, nil,
|
|
1893
|
-
"hook", "subagent-orient", "--harness=codex")
|
|
1894
|
-
if code != 0 {
|
|
1895
|
-
t.Fatalf("start exit=%d stderr=%s", code, stderr)
|
|
1896
|
-
}
|
|
1897
|
-
var startEnvelope struct {
|
|
1898
|
-
HookSpecificOutput struct {
|
|
1899
|
-
AdditionalContext string `json:"additionalContext"`
|
|
1900
|
-
} `json:"hookSpecificOutput"`
|
|
1901
|
-
}
|
|
1902
|
-
if err := json.Unmarshal([]byte(strings.TrimSpace(out)), &startEnvelope); err != nil {
|
|
1903
|
-
t.Fatalf("invalid start response: %v\n%s", err, out)
|
|
1904
|
-
}
|
|
1905
|
-
if !strings.Contains(startEnvelope.HookSpecificOutput.AdditionalContext,
|
|
1906
|
-
".codex/agents/"+role+".toml") {
|
|
1907
|
-
t.Fatalf("generic child did not receive role contract: %s", out)
|
|
1908
|
-
}
|
|
1909
|
-
|
|
1910
|
-
stopAgent := hookPayload(t, map[string]any{
|
|
1911
|
-
"hook_event_name": "SubagentStop",
|
|
1912
|
-
"session_id": sessionID,
|
|
1913
|
-
"turn_id": "child-turn",
|
|
1914
|
-
"agent_id": "agent-1",
|
|
1915
|
-
"agent_type": "explorer",
|
|
1916
|
-
"last_assistant_message": "agent-result/v1 complete",
|
|
1917
|
-
})
|
|
1918
|
-
if out, stderr, code := runDevritesIO(t, root, stopAgent, nil,
|
|
1919
|
-
"hook", "agent-dispatch", "--harness=codex"); code != 0 || strings.TrimSpace(out) != "" {
|
|
1920
|
-
t.Fatalf("subagent stop exit=%d out=%s stderr=%s", code, out, stderr)
|
|
1921
|
-
}
|
|
1922
|
-
|
|
1923
|
-
stop := hookPayload(t, map[string]any{
|
|
1924
|
-
"hook_event_name": "Stop",
|
|
1925
|
-
"session_id": sessionID,
|
|
1926
|
-
"turn_id": turnID,
|
|
1927
|
-
"stop_hook_active": false,
|
|
1928
|
-
})
|
|
1929
|
-
out, stderr, code = runDevritesIO(t, root, stop, nil,
|
|
1930
|
-
"hook", "agent-dispatch", "--harness=codex")
|
|
1931
|
-
if code != 0 {
|
|
1932
|
-
t.Fatalf("unawaited stop exit=%d stderr=%s", code, stderr)
|
|
1933
|
-
}
|
|
1934
|
-
var blocked struct {
|
|
1935
|
-
Decision string `json:"decision"`
|
|
1936
|
-
Reason string `json:"reason"`
|
|
1937
|
-
}
|
|
1938
|
-
if err := json.Unmarshal([]byte(strings.TrimSpace(out)), &blocked); err != nil {
|
|
1939
|
-
t.Fatalf("invalid unawaited Stop response: %v\n%s", err, out)
|
|
1940
|
-
}
|
|
1941
|
-
if blocked.Decision != "block" {
|
|
1942
|
-
t.Fatalf("unawaited child result passed Stop: %s", out)
|
|
1943
|
-
}
|
|
1944
|
-
if strings.Contains(blocked.Reason, "dispatch-waive") {
|
|
1945
|
-
t.Fatalf("unavailable post-spawn waiver was suggested: %s", out)
|
|
1946
|
-
}
|
|
1947
|
-
|
|
1948
|
-
wait := hookPayload(t, map[string]any{
|
|
1949
|
-
"hook_event_name": "PreToolUse",
|
|
1950
|
-
"session_id": sessionID,
|
|
1951
|
-
"turn_id": turnID,
|
|
1952
|
-
"tool_name": "wait",
|
|
1953
|
-
"tool_input": map[string]any{"ids": []string{"agent-1"}},
|
|
1954
|
-
})
|
|
1955
|
-
if out, stderr, code := runDevritesIO(t, root, wait, nil,
|
|
1956
|
-
"hook", "agent-dispatch", "--harness=codex"); code != 0 || strings.TrimSpace(out) != "" {
|
|
1957
|
-
t.Fatalf("wait exit=%d out=%s stderr=%s", code, out, stderr)
|
|
1958
|
-
}
|
|
1959
|
-
|
|
1960
|
-
if out, stderr, code := runDevritesIO(t, root, stop, nil,
|
|
1961
|
-
"hook", "agent-dispatch", "--harness=codex"); code != 0 {
|
|
1962
|
-
t.Fatalf("pre-wait stop exit=%d out=%s stderr=%s", code, out, stderr)
|
|
1963
|
-
} else if decision, _ := parseStopDecision(t, out); decision != "block" {
|
|
1964
|
-
t.Fatalf("PreToolUse wait falsely satisfied dispatch: %s", out)
|
|
1965
|
-
}
|
|
1966
|
-
|
|
1967
|
-
waitTimeout := hookPayload(t, map[string]any{
|
|
1968
|
-
"hook_event_name": "PostToolUse",
|
|
1969
|
-
"session_id": sessionID,
|
|
1970
|
-
"turn_id": turnID,
|
|
1971
|
-
"tool_name": "wait",
|
|
1972
|
-
"tool_input": map[string]any{"ids": []string{"agent-1"}},
|
|
1973
|
-
"tool_response": map[string]any{"timed_out": true},
|
|
1974
|
-
})
|
|
1975
|
-
if out, stderr, code := runDevritesIO(t, root, waitTimeout, nil,
|
|
1976
|
-
"hook", "agent-dispatch", "--harness=codex"); code != 0 || strings.TrimSpace(out) != "" {
|
|
1977
|
-
t.Fatalf("timed-out wait post exit=%d out=%s stderr=%s", code, out, stderr)
|
|
1978
|
-
}
|
|
1979
|
-
if out, stderr, code := runDevritesIO(t, root, stop, nil,
|
|
1980
|
-
"hook", "agent-dispatch", "--harness=codex"); code != 0 {
|
|
1981
|
-
t.Fatalf("post-timeout stop exit=%d out=%s stderr=%s", code, out, stderr)
|
|
1982
|
-
} else if decision, _ := parseStopDecision(t, out); decision != "block" {
|
|
1983
|
-
t.Fatalf("timed-out wait falsely satisfied dispatch: %s", out)
|
|
1984
|
-
}
|
|
1985
|
-
|
|
1986
|
-
waitDone := hookPayload(t, map[string]any{
|
|
1987
|
-
"hook_event_name": "PostToolUse",
|
|
1988
|
-
"session_id": sessionID,
|
|
1989
|
-
"turn_id": turnID,
|
|
1990
|
-
"tool_name": "wait",
|
|
1991
|
-
"tool_input": map[string]any{"ids": []string{"agent-1"}},
|
|
1992
|
-
"tool_response": map[string]any{"status": "completed"},
|
|
1993
|
-
})
|
|
1994
|
-
if out, stderr, code := runDevritesIO(t, root, waitDone, nil,
|
|
1995
|
-
"hook", "agent-dispatch", "--harness=codex"); code != 0 || strings.TrimSpace(out) != "" {
|
|
1996
|
-
t.Fatalf("wait post exit=%d out=%s stderr=%s", code, out, stderr)
|
|
1997
|
-
}
|
|
1998
|
-
|
|
1999
|
-
if out, stderr, code := runDevritesIO(t, root, stop, nil,
|
|
2000
|
-
"hook", "agent-dispatch", "--harness=codex"); code != 0 || strings.TrimSpace(out) != "" {
|
|
2001
|
-
t.Fatalf("resolved stop exit=%d out=%s stderr=%s", code, out, stderr)
|
|
2002
|
-
}
|
|
2003
|
-
}
|
|
2004
|
-
|
|
2005
|
-
func TestCodexAgentDispatchRefusesAmbiguousGenericStart(t *testing.T) {
|
|
2006
|
-
root := newWorkspace(t)
|
|
2007
|
-
sessionID, turnID := "session-ambiguous-start", "turn-ambiguous-start"
|
|
2008
|
-
roles := []string{"devrites-security-auditor", "devrites-plan-reviewer"}
|
|
2009
|
-
for _, role := range roles {
|
|
2010
|
-
writeCodexAgentContract(t, root, role)
|
|
2011
|
-
}
|
|
2012
|
-
writeCodexSkillContract(t, root, "devrites-audit", strings.Join(roles, ","))
|
|
2013
|
-
runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
2014
|
-
"hook_event_name": "UserPromptSubmit",
|
|
2015
|
-
"session_id": sessionID,
|
|
2016
|
-
"turn_id": turnID,
|
|
2017
|
-
"prompt": "$devrites-audit",
|
|
2018
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
2019
|
-
|
|
2020
|
-
for i, role := range roles {
|
|
2021
|
-
out, stderr, code := runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
2022
|
-
"hook_event_name": "PreToolUse",
|
|
2023
|
-
"session_id": sessionID,
|
|
2024
|
-
"turn_id": turnID,
|
|
2025
|
-
"tool_name": "spawn_agent",
|
|
2026
|
-
"tool_use_id": fmt.Sprintf("spawn-%d", i),
|
|
2027
|
-
"tool_input": map[string]any{
|
|
2028
|
-
"agent_type": "explorer",
|
|
2029
|
-
"fork_turns": "none",
|
|
2030
|
-
"message": "Read .codex/agents/" + role + ".toml.",
|
|
2031
|
-
},
|
|
2032
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
2033
|
-
if code != 0 {
|
|
2034
|
-
t.Fatalf("spawn %s exit=%d out=%s stderr=%s", role, code, out, stderr)
|
|
2035
|
-
}
|
|
2036
|
-
}
|
|
2037
|
-
|
|
2038
|
-
out, stderr, code := runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
2039
|
-
"hook_event_name": "SubagentStart",
|
|
2040
|
-
"session_id": sessionID,
|
|
2041
|
-
"turn_id": "child-turn",
|
|
2042
|
-
"agent_id": "ambiguous-agent",
|
|
2043
|
-
"agent_type": "explorer",
|
|
2044
|
-
}), nil, "hook", "subagent-orient", "--harness=codex")
|
|
2045
|
-
if code != 0 {
|
|
2046
|
-
t.Fatalf("start exit=%d stderr=%s", code, stderr)
|
|
2047
|
-
}
|
|
2048
|
-
if !strings.Contains(out, "Dispatch binding failed") {
|
|
2049
|
-
t.Fatalf("ambiguous generic start was bound to an arbitrary role: %s", out)
|
|
2050
|
-
}
|
|
2051
|
-
}
|
|
2052
|
-
|
|
2053
|
-
func TestCodexAgentDispatchConfirmsDurableV2NamedRole(t *testing.T) {
|
|
2054
|
-
root := newWorkspace(t)
|
|
2055
|
-
codeHome := t.TempDir()
|
|
2056
|
-
sessionID, turnID := "session-v2-named", "turn-v2-named"
|
|
2057
|
-
role := "devrites-security-auditor"
|
|
2058
|
-
writeCodexAgentContract(t, root, role)
|
|
2059
|
-
writeCodexSkillContract(t, root, "devrites-audit", role)
|
|
2060
|
-
|
|
2061
|
-
runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
2062
|
-
"hook_event_name": "UserPromptSubmit",
|
|
2063
|
-
"session_id": sessionID,
|
|
2064
|
-
"turn_id": turnID,
|
|
2065
|
-
"prompt": "$devrites-audit Call spawn_agent and tell it to read .codex/agents/" + role + ".toml.",
|
|
2066
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
2067
|
-
|
|
2068
|
-
writeCodexV2Rollouts(
|
|
2069
|
-
t, codeHome, filepath.Dir(root), sessionID, turnID, role,
|
|
2070
|
-
"devrites_security_auditor_named", true, true, true,
|
|
2071
|
-
)
|
|
2072
|
-
stop := hookPayload(t, map[string]any{
|
|
2073
|
-
"hook_event_name": "Stop",
|
|
2074
|
-
"session_id": sessionID,
|
|
2075
|
-
"turn_id": turnID,
|
|
2076
|
-
"stop_hook_active": false,
|
|
2077
|
-
})
|
|
2078
|
-
if out, stderr, code := runDevritesIO(t, root, stop,
|
|
2079
|
-
[]string{"CODEX_HOME=" + codeHome},
|
|
2080
|
-
"hook", "agent-dispatch", "--harness=codex"); code != 0 || strings.TrimSpace(out) != "" {
|
|
2081
|
-
t.Fatalf("durable v2 stop exit=%d out=%s stderr=%s", code, out, stderr)
|
|
2082
|
-
}
|
|
2083
|
-
}
|
|
2084
|
-
|
|
2085
|
-
func TestCodexAgentDispatchBindsDurableV2NamedStartWithoutPreToolReceipt(t *testing.T) {
|
|
2086
|
-
root := newWorkspace(t)
|
|
2087
|
-
codeHome := t.TempDir()
|
|
2088
|
-
sessionID, turnID := "session-v2-start", "turn-v2-start"
|
|
2089
|
-
role := "devrites-plan-reviewer"
|
|
2090
|
-
taskName := "devrites_plan_reviewer_named"
|
|
2091
|
-
writeCodexAgentContract(t, root, role)
|
|
2092
|
-
writeCodexSkillContract(t, root, "rite-vet", role)
|
|
2093
|
-
|
|
2094
|
-
runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
2095
|
-
"hook_event_name": "UserPromptSubmit",
|
|
2096
|
-
"session_id": sessionID,
|
|
2097
|
-
"turn_id": turnID,
|
|
2098
|
-
"prompt": "$rite-vet",
|
|
2099
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
2100
|
-
writeCodexV2Rollouts(
|
|
2101
|
-
t, codeHome, filepath.Dir(root), sessionID, turnID, role,
|
|
2102
|
-
taskName, false, false, false,
|
|
2103
|
-
)
|
|
2104
|
-
|
|
2105
|
-
mismatched, _, _ := runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
2106
|
-
"hook_event_name": "SubagentStart",
|
|
2107
|
-
"session_id": sessionID,
|
|
2108
|
-
"turn_id": "child-turn",
|
|
2109
|
-
"agent_id": "child-" + taskName,
|
|
2110
|
-
"agent_type": "devrites-plan-drafter",
|
|
2111
|
-
}), []string{"CODEX_HOME=" + codeHome}, "hook", "subagent-orient", "--harness=codex")
|
|
2112
|
-
if !strings.Contains(mismatched, "Unbound named start") {
|
|
2113
|
-
t.Fatalf("mismatched named role was bound: %s", mismatched)
|
|
2114
|
-
}
|
|
2115
|
-
|
|
2116
|
-
out, stderr, code := runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
2117
|
-
"hook_event_name": "SubagentStart",
|
|
2118
|
-
"session_id": sessionID,
|
|
2119
|
-
"turn_id": "child-turn",
|
|
2120
|
-
"agent_id": "child-" + taskName,
|
|
2121
|
-
"agent_type": role,
|
|
2122
|
-
}), []string{"CODEX_HOME=" + codeHome}, "hook", "subagent-orient", "--harness=codex")
|
|
2123
|
-
if code != 0 {
|
|
2124
|
-
t.Fatalf("start exit=%d stderr=%s", code, stderr)
|
|
2125
|
-
}
|
|
2126
|
-
if !strings.Contains(out, "Confirmed role") || strings.Contains(out, "Unbound named start") {
|
|
2127
|
-
t.Fatalf("durable named start was not bound: %s", out)
|
|
2128
|
-
}
|
|
2129
|
-
}
|
|
2130
|
-
|
|
2131
|
-
func TestCodexAgentDispatchConfirmsDurableV2ChildRoleWhenParentOmitsAgentType(t *testing.T) {
|
|
2132
|
-
root := newWorkspace(t)
|
|
2133
|
-
codeHome := t.TempDir()
|
|
2134
|
-
sessionID, turnID := "session-v2-hidden-role", "turn-v2-hidden-role"
|
|
2135
|
-
role := "devrites-plan-drafter"
|
|
2136
|
-
writeCodexAgentContract(t, root, role)
|
|
2137
|
-
writeCodexSkillContract(t, root, "rite-plan", role)
|
|
2138
|
-
|
|
2139
|
-
runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
2140
|
-
"hook_event_name": "UserPromptSubmit",
|
|
2141
|
-
"session_id": sessionID,
|
|
2142
|
-
"turn_id": turnID,
|
|
2143
|
-
"prompt": "$rite-plan unblock",
|
|
2144
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
2145
|
-
|
|
2146
|
-
taskName := "devrites_plan_drafter_hidden_role"
|
|
2147
|
-
writeCodexV2Rollouts(
|
|
2148
|
-
t, codeHome, filepath.Dir(root), sessionID, turnID, role,
|
|
2149
|
-
taskName, true, true, true,
|
|
2150
|
-
)
|
|
2151
|
-
parentPath := filepath.Join(codeHome, "sessions", "2026", "07", "25", "rollout-parent-"+sessionID+".jsonl")
|
|
2152
|
-
parent, err := os.ReadFile(parentPath)
|
|
2153
|
-
if err != nil {
|
|
2154
|
-
t.Fatal(err)
|
|
2155
|
-
}
|
|
2156
|
-
hiddenParentRole := bytes.ReplaceAll(parent, []byte(`\"agent_type\":\"`+role+`\"`), []byte(`\"agent_type\":\"\"`))
|
|
2157
|
-
if bytes.Equal(parent, hiddenParentRole) {
|
|
2158
|
-
t.Fatal("fixture did not hide the parent agent_type")
|
|
2159
|
-
}
|
|
2160
|
-
if err := os.WriteFile(parentPath, hiddenParentRole, 0o600); err != nil {
|
|
2161
|
-
t.Fatal(err)
|
|
2162
|
-
}
|
|
2163
|
-
stop := hookPayload(t, map[string]any{
|
|
2164
|
-
"hook_event_name": "Stop",
|
|
2165
|
-
"session_id": sessionID,
|
|
2166
|
-
"turn_id": turnID,
|
|
2167
|
-
})
|
|
2168
|
-
if out, stderr, code := runDevritesIO(t, root, stop,
|
|
2169
|
-
[]string{"CODEX_HOME=" + codeHome},
|
|
2170
|
-
"hook", "agent-dispatch", "--harness=codex"); code != 0 || strings.TrimSpace(out) != "" {
|
|
2171
|
-
t.Fatalf("hidden parent role stop exit=%d out=%s stderr=%s", code, out, stderr)
|
|
2172
|
-
}
|
|
2173
|
-
}
|
|
2174
|
-
|
|
2175
|
-
func TestCodexAgentDispatchConfirmsConditionalDurableV2NamedRole(t *testing.T) {
|
|
2176
|
-
root := newWorkspace(t)
|
|
2177
|
-
codeHome := t.TempDir()
|
|
2178
|
-
sessionID, turnID := "session-v2-conditional", "turn-v2-conditional"
|
|
2179
|
-
role := "devrites-security-auditor"
|
|
2180
|
-
writeCodexAgentContract(t, root, role)
|
|
2181
|
-
writeCodexConditionalSkillContract(t, root, "devrites-audit", role)
|
|
2182
|
-
|
|
2183
|
-
runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
2184
|
-
"hook_event_name": "UserPromptSubmit",
|
|
2185
|
-
"session_id": sessionID,
|
|
2186
|
-
"turn_id": turnID,
|
|
2187
|
-
"prompt": "$devrites-audit security",
|
|
2188
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
2189
|
-
|
|
2190
|
-
writeCodexV2Rollouts(
|
|
2191
|
-
t, codeHome, filepath.Dir(root), sessionID, turnID, role,
|
|
2192
|
-
"devrites_security_auditor_conditional", true, true, true,
|
|
2193
|
-
)
|
|
2194
|
-
stop := hookPayload(t, map[string]any{
|
|
2195
|
-
"hook_event_name": "Stop",
|
|
2196
|
-
"session_id": sessionID,
|
|
2197
|
-
"turn_id": turnID,
|
|
2198
|
-
})
|
|
2199
|
-
if out, stderr, code := runDevritesIO(t, root, stop,
|
|
2200
|
-
[]string{"CODEX_HOME=" + codeHome},
|
|
2201
|
-
"hook", "agent-dispatch", "--harness=codex"); code != 0 || strings.TrimSpace(out) != "" {
|
|
2202
|
-
t.Fatalf("conditional durable v2 stop exit=%d out=%s stderr=%s", code, out, stderr)
|
|
2203
|
-
}
|
|
2204
|
-
}
|
|
2205
|
-
|
|
2206
|
-
func TestCodexAgentDispatchRejectsConditionalDurableV2DefaultChild(t *testing.T) {
|
|
2207
|
-
root := newWorkspace(t)
|
|
2208
|
-
codeHome := t.TempDir()
|
|
2209
|
-
sessionID, turnID := "session-v2-default", "turn-v2-default"
|
|
2210
|
-
writeCodexConditionalSkillContract(t, root, "devrites-audit", "devrites-security-auditor")
|
|
2211
|
-
|
|
2212
|
-
runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
2213
|
-
"hook_event_name": "UserPromptSubmit",
|
|
2214
|
-
"session_id": sessionID,
|
|
2215
|
-
"turn_id": turnID,
|
|
2216
|
-
"prompt": "$devrites-audit security",
|
|
2217
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
2218
|
-
|
|
2219
|
-
writeCodexV2Rollouts(
|
|
2220
|
-
t, codeHome, filepath.Dir(root), sessionID, turnID, "default",
|
|
2221
|
-
"default_conditional_child", true, true, true,
|
|
2222
|
-
)
|
|
2223
|
-
stop := hookPayload(t, map[string]any{
|
|
2224
|
-
"hook_event_name": "Stop",
|
|
2225
|
-
"session_id": sessionID,
|
|
2226
|
-
"turn_id": turnID,
|
|
2227
|
-
})
|
|
2228
|
-
out, stderr, code := runDevritesIO(t, root, stop,
|
|
2229
|
-
[]string{"CODEX_HOME=" + codeHome},
|
|
2230
|
-
"hook", "agent-dispatch", "--harness=codex")
|
|
2231
|
-
if code != 0 {
|
|
2232
|
-
t.Fatalf("conditional default stop exit=%d stderr=%s", code, stderr)
|
|
2233
|
-
}
|
|
2234
|
-
var decision struct {
|
|
2235
|
-
Decision string `json:"decision"`
|
|
2236
|
-
Reason string `json:"reason"`
|
|
2237
|
-
}
|
|
2238
|
-
if err := json.Unmarshal([]byte(strings.TrimSpace(out)), &decision); err != nil {
|
|
2239
|
-
t.Fatalf("invalid conditional default response: %v\n%s", err, out)
|
|
2240
|
-
}
|
|
2241
|
-
if decision.Decision != "block" ||
|
|
2242
|
-
!strings.Contains(decision.Reason, "default or non-DevRites child") ||
|
|
2243
|
-
!strings.Contains(decision.Reason, "cannot be repaired by another dispatch") ||
|
|
2244
|
-
!strings.Contains(decision.Reason, "retry the skill in a fresh turn") ||
|
|
2245
|
-
!strings.Contains(decision.Reason, "never use a default child") {
|
|
2246
|
-
t.Fatalf("conditional V2 default child passed: %#v", decision)
|
|
2247
|
-
}
|
|
2248
|
-
|
|
2249
|
-
stop = hookPayload(t, map[string]any{
|
|
2250
|
-
"hook_event_name": "Stop",
|
|
2251
|
-
"session_id": sessionID,
|
|
2252
|
-
"turn_id": turnID,
|
|
2253
|
-
"stop_hook_active": true,
|
|
2254
|
-
})
|
|
2255
|
-
out, stderr, code = runDevritesIO(t, root, stop,
|
|
2256
|
-
[]string{"CODEX_HOME=" + codeHome},
|
|
2257
|
-
"hook", "agent-dispatch", "--harness=codex")
|
|
2258
|
-
if code != 0 {
|
|
2259
|
-
t.Fatalf("conditional default reentry exit=%d stderr=%s", code, stderr)
|
|
2260
|
-
}
|
|
2261
|
-
var terminal struct {
|
|
2262
|
-
Continue bool `json:"continue"`
|
|
2263
|
-
StopReason string `json:"stopReason"`
|
|
2264
|
-
}
|
|
2265
|
-
if err := json.Unmarshal([]byte(strings.TrimSpace(out)), &terminal); err != nil {
|
|
2266
|
-
t.Fatalf("invalid conditional default reentry response: %v\n%s", err, out)
|
|
2267
|
-
}
|
|
2268
|
-
if terminal.Continue ||
|
|
2269
|
-
!strings.Contains(terminal.StopReason, "default or non-DevRites child") ||
|
|
2270
|
-
!strings.Contains(terminal.StopReason, "retry the skill in a fresh turn") {
|
|
2271
|
-
t.Fatalf("conditional V2 default child reentry did not stop: %#v", terminal)
|
|
2272
|
-
}
|
|
2273
|
-
}
|
|
2274
|
-
|
|
2275
|
-
func TestCodexAgentDispatchTerminatesCorruptStateReentry(t *testing.T) {
|
|
2276
|
-
root := newWorkspace(t)
|
|
2277
|
-
sessionID, turnID := "session-corrupt-state", "turn-corrupt-state"
|
|
2278
|
-
|
|
2279
|
-
runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
2280
|
-
"hook_event_name": "UserPromptSubmit",
|
|
2281
|
-
"session_id": sessionID,
|
|
2282
|
-
"turn_id": turnID,
|
|
2283
|
-
"prompt": "$rite-status",
|
|
2284
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
2285
|
-
|
|
2286
|
-
resolvedRoot, err := filepath.EvalSymlinks(root)
|
|
2287
|
-
if err != nil {
|
|
2288
|
-
t.Fatal(err)
|
|
2289
|
-
}
|
|
2290
|
-
rootSum := sha256.Sum256([]byte(filepath.Clean(resolvedRoot)))
|
|
2291
|
-
sessionSum := sha256.Sum256([]byte(sessionID))
|
|
2292
|
-
statePath := filepath.Join(
|
|
2293
|
-
os.TempDir(),
|
|
2294
|
-
"devrites-agent-dispatch-v1",
|
|
2295
|
-
hex.EncodeToString(rootSum[:]),
|
|
2296
|
-
hex.EncodeToString(sessionSum[:])+".jsonl",
|
|
2297
|
-
)
|
|
2298
|
-
if err := os.MkdirAll(filepath.Dir(statePath), 0o700); err != nil {
|
|
2299
|
-
t.Fatal(err)
|
|
2300
|
-
}
|
|
2301
|
-
if err := os.WriteFile(statePath, []byte("not-json\n"), 0o600); err != nil {
|
|
2302
|
-
t.Fatal(err)
|
|
2303
|
-
}
|
|
2304
|
-
|
|
2305
|
-
stop := func(active bool) string {
|
|
2306
|
-
out, stderr, code := runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
2307
|
-
"hook_event_name": "Stop",
|
|
2308
|
-
"session_id": sessionID,
|
|
2309
|
-
"turn_id": turnID,
|
|
2310
|
-
"stop_hook_active": active,
|
|
2311
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
2312
|
-
if code != 0 {
|
|
2313
|
-
t.Fatalf("corrupt state stop active=%t exit=%d stderr=%s", active, code, stderr)
|
|
2314
|
-
}
|
|
2315
|
-
return out
|
|
2316
|
-
}
|
|
2317
|
-
|
|
2318
|
-
var blocked struct {
|
|
2319
|
-
Decision string `json:"decision"`
|
|
2320
|
-
}
|
|
2321
|
-
if out := stop(false); json.Unmarshal([]byte(strings.TrimSpace(out)), &blocked) != nil ||
|
|
2322
|
-
blocked.Decision != "block" {
|
|
2323
|
-
t.Fatalf("corrupt state first Stop did not block: %s", out)
|
|
2324
|
-
}
|
|
2325
|
-
|
|
2326
|
-
var terminal struct {
|
|
2327
|
-
Continue bool `json:"continue"`
|
|
2328
|
-
StopReason string `json:"stopReason"`
|
|
2329
|
-
}
|
|
2330
|
-
if out := stop(true); json.Unmarshal([]byte(strings.TrimSpace(out)), &terminal) != nil ||
|
|
2331
|
-
terminal.Continue ||
|
|
2332
|
-
!strings.Contains(terminal.StopReason, "invalid agent dispatch state") {
|
|
2333
|
-
t.Fatalf("corrupt state reentry did not stop: %s", out)
|
|
2334
|
-
}
|
|
2335
|
-
}
|
|
2336
|
-
|
|
2337
|
-
func TestCodexAgentDispatchRejectsIncompleteDurableV2(t *testing.T) {
|
|
2338
|
-
for _, tc := range []struct {
|
|
2339
|
-
name string
|
|
2340
|
-
role string
|
|
2341
|
-
includeWait bool
|
|
2342
|
-
includeRules bool
|
|
2343
|
-
includeResult bool
|
|
2344
|
-
}{
|
|
2345
|
-
{name: "generic-role", role: "explorer", includeWait: true, includeRules: true, includeResult: true},
|
|
2346
|
-
{name: "missing-wait", role: "devrites-security-auditor", includeRules: true, includeResult: true},
|
|
2347
|
-
{name: "missing-rules", role: "devrites-security-auditor", includeWait: true, includeResult: true},
|
|
2348
|
-
{name: "missing-result", role: "devrites-security-auditor", includeWait: true, includeRules: true},
|
|
2349
|
-
} {
|
|
2350
|
-
t.Run(tc.name, func(t *testing.T) {
|
|
2351
|
-
root := newWorkspace(t)
|
|
2352
|
-
codeHome := t.TempDir()
|
|
2353
|
-
sessionID, turnID := "session-"+tc.name, "turn-"+tc.name
|
|
2354
|
-
role := "devrites-security-auditor"
|
|
2355
|
-
writeCodexAgentContract(t, root, role)
|
|
2356
|
-
writeCodexSkillContract(t, root, "devrites-audit", role)
|
|
2357
|
-
runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
2358
|
-
"hook_event_name": "UserPromptSubmit",
|
|
2359
|
-
"session_id": sessionID,
|
|
2360
|
-
"turn_id": turnID,
|
|
2361
|
-
"prompt": "$devrites-audit Read .codex/agents/" + role + ".toml.",
|
|
2362
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
2363
|
-
writeCodexV2Rollouts(
|
|
2364
|
-
t, codeHome, filepath.Dir(root), sessionID, turnID, tc.role,
|
|
2365
|
-
"devrites_security_auditor_named", tc.includeWait, tc.includeRules, tc.includeResult,
|
|
2366
|
-
)
|
|
2367
|
-
stop := hookPayload(t, map[string]any{
|
|
2368
|
-
"hook_event_name": "Stop",
|
|
2369
|
-
"session_id": sessionID,
|
|
2370
|
-
"turn_id": turnID,
|
|
2371
|
-
})
|
|
2372
|
-
out, stderr, code := runDevritesIO(t, root, stop,
|
|
2373
|
-
[]string{"CODEX_HOME=" + codeHome},
|
|
2374
|
-
"hook", "agent-dispatch", "--harness=codex")
|
|
2375
|
-
if code != 0 {
|
|
2376
|
-
t.Fatalf("stop exit=%d stderr=%s", code, stderr)
|
|
2377
|
-
}
|
|
2378
|
-
var decision struct {
|
|
2379
|
-
Decision string `json:"decision"`
|
|
2380
|
-
}
|
|
2381
|
-
if err := json.Unmarshal([]byte(strings.TrimSpace(out)), &decision); err != nil {
|
|
2382
|
-
t.Fatalf("invalid Stop response: %v\n%s", err, out)
|
|
2383
|
-
}
|
|
2384
|
-
if decision.Decision != "block" {
|
|
2385
|
-
t.Fatalf("incomplete durable V2 dispatch passed: %s", out)
|
|
2386
|
-
}
|
|
2387
|
-
})
|
|
2388
|
-
}
|
|
2389
|
-
}
|
|
2390
|
-
|
|
2391
|
-
func TestCodexAgentDispatchGatesReconcileCloseOnBoundWrightResult(t *testing.T) {
|
|
2392
|
-
root := newWorkspace(t)
|
|
2393
|
-
writeActive(t, root, "auth-tokens")
|
|
2394
|
-
workspace := filepath.Join(root, "features", "auth-tokens")
|
|
2395
|
-
for name, body := range map[string]string{
|
|
2396
|
-
".reconcile-base": ".reconcile-base\n",
|
|
2397
|
-
".reconcile-allowlist": ".reconcile-allowlist\n",
|
|
2398
|
-
".reconcile-devrites": "[]\n",
|
|
2399
|
-
} {
|
|
2400
|
-
if err := os.WriteFile(filepath.Join(workspace, name), []byte(body), 0o600); err != nil {
|
|
2401
|
-
t.Fatal(err)
|
|
2402
|
-
}
|
|
2403
|
-
}
|
|
2404
|
-
if err := os.MkdirAll(filepath.Join(workspace, ".reconcile-objects"), 0o700); err != nil {
|
|
2405
|
-
t.Fatal(err)
|
|
2406
|
-
}
|
|
2407
|
-
sessionID, turnID := "session-wright", "turn-wright"
|
|
2408
|
-
writeCodexAgentContract(t, root, "devrites-slice-wright")
|
|
2409
|
-
writeCodexSkillContract(t, root, "rite-build", "devrites-slice-wright")
|
|
2410
|
-
runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
2411
|
-
"hook_event_name": "UserPromptSubmit",
|
|
2412
|
-
"session_id": sessionID,
|
|
2413
|
-
"turn_id": turnID,
|
|
2414
|
-
"prompt": "$rite-build",
|
|
2415
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
2416
|
-
|
|
2417
|
-
check := hookPayload(t, map[string]any{
|
|
2418
|
-
"hook_event_name": "PreToolUse",
|
|
2419
|
-
"session_id": sessionID,
|
|
2420
|
-
"turn_id": turnID,
|
|
2421
|
-
"tool_name": "Bash",
|
|
2422
|
-
"tool_input": map[string]any{"command": "rtk devrites-engine reconcile check"},
|
|
2423
|
-
})
|
|
2424
|
-
if out, stderr, code := runDevritesIO(t, root, check, nil,
|
|
2425
|
-
"hook", "agent-dispatch", "--harness=codex"); code != 0 || strings.TrimSpace(out) != "" {
|
|
2426
|
-
t.Fatalf("ordinary reconcile check exit=%d out=%s stderr=%s", code, out, stderr)
|
|
2427
|
-
}
|
|
2428
|
-
|
|
2429
|
-
closeWindow := hookPayload(t, map[string]any{
|
|
2430
|
-
"hook_event_name": "PreToolUse",
|
|
2431
|
-
"session_id": sessionID,
|
|
2432
|
-
"turn_id": turnID,
|
|
2433
|
-
"tool_name": "Bash",
|
|
2434
|
-
"tool_input": map[string]any{"command": "rtk devrites-engine reconcile close"},
|
|
2435
|
-
})
|
|
2436
|
-
out, _, _ := runDevritesIO(t, root, closeWindow, nil,
|
|
2437
|
-
"hook", "agent-dispatch", "--harness=codex")
|
|
2438
|
-
if decision, reason := parsePermissionDecision(t, out); decision != "deny" ||
|
|
2439
|
-
!strings.Contains(reason, "confirmed") {
|
|
2440
|
-
t.Fatalf("premature reconcile not denied: decision=%q reason=%q", decision, reason)
|
|
2441
|
-
}
|
|
2442
|
-
|
|
2443
|
-
for _, payload := range []map[string]any{
|
|
2444
|
-
{
|
|
2445
|
-
"hook_event_name": "PreToolUse",
|
|
2446
|
-
"session_id": sessionID,
|
|
2447
|
-
"turn_id": turnID,
|
|
2448
|
-
"tool_name": "spawn_agent",
|
|
2449
|
-
"tool_use_id": "spawn-wright",
|
|
2450
|
-
"tool_input": map[string]any{
|
|
2451
|
-
"agent_type": "devrites-slice-wright",
|
|
2452
|
-
"fork_turns": "none",
|
|
2453
|
-
"message": "Read .codex/agents/devrites-slice-wright.toml.",
|
|
2454
|
-
},
|
|
2455
|
-
},
|
|
2456
|
-
{
|
|
2457
|
-
"hook_event_name": "SubagentStart",
|
|
2458
|
-
"session_id": sessionID,
|
|
2459
|
-
"turn_id": "child-wright",
|
|
2460
|
-
"agent_id": "agent-wright",
|
|
2461
|
-
"agent_type": "devrites-slice-wright",
|
|
2462
|
-
},
|
|
2463
|
-
{
|
|
2464
|
-
"hook_event_name": "SubagentStop",
|
|
2465
|
-
"session_id": sessionID,
|
|
2466
|
-
"turn_id": "child-wright",
|
|
2467
|
-
"agent_id": "agent-wright",
|
|
2468
|
-
"agent_type": "devrites-slice-wright",
|
|
2469
|
-
"last_assistant_message": "agent-result/v1 complete",
|
|
2470
|
-
},
|
|
2471
|
-
{
|
|
2472
|
-
"hook_event_name": "PreToolUse",
|
|
2473
|
-
"session_id": sessionID,
|
|
2474
|
-
"turn_id": turnID,
|
|
2475
|
-
"tool_name": "wait",
|
|
2476
|
-
"tool_input": map[string]any{"ids": []string{"agent-wright"}},
|
|
2477
|
-
},
|
|
2478
|
-
{
|
|
2479
|
-
"hook_event_name": "PostToolUse",
|
|
2480
|
-
"session_id": sessionID,
|
|
2481
|
-
"turn_id": turnID,
|
|
2482
|
-
"tool_name": "wait",
|
|
2483
|
-
"tool_input": map[string]any{"ids": []string{"agent-wright"}},
|
|
2484
|
-
"tool_response": map[string]any{"status": "completed"},
|
|
2485
|
-
},
|
|
2486
|
-
} {
|
|
2487
|
-
hook := "agent-dispatch"
|
|
2488
|
-
if payload["hook_event_name"] == "SubagentStart" {
|
|
2489
|
-
hook = "subagent-orient"
|
|
2490
|
-
}
|
|
2491
|
-
if _, stderr, code := runDevritesIO(t, root, hookPayload(t, payload), nil,
|
|
2492
|
-
"hook", hook, "--harness=codex"); code != 0 {
|
|
2493
|
-
t.Fatalf("%s exit=%d stderr=%s", hook, code, stderr)
|
|
2494
|
-
}
|
|
2495
|
-
}
|
|
2496
|
-
if _, err := os.Stat(filepath.Join(workspace, ".reconcile-wright-devrites")); err != nil {
|
|
2497
|
-
t.Fatalf("wright start did not capture canonical boundary: %v", err)
|
|
2498
|
-
}
|
|
2499
|
-
|
|
2500
|
-
if out, stderr, code := runDevritesIO(t, root, closeWindow, nil,
|
|
2501
|
-
"hook", "agent-dispatch", "--harness=codex"); code != 0 || strings.TrimSpace(out) != "" {
|
|
2502
|
-
t.Fatalf("completed wright reconcile exit=%d out=%s stderr=%s", code, out, stderr)
|
|
2503
|
-
}
|
|
2504
|
-
}
|
|
2505
|
-
|
|
2506
|
-
func TestCodexAgentDispatchCapturesWrightBoundaryBeforeSpawn(t *testing.T) {
|
|
2507
|
-
root := newWorkspace(t)
|
|
2508
|
-
writeActive(t, root, "auth-tokens")
|
|
2509
|
-
workspace := filepath.Join(root, "features", "auth-tokens")
|
|
2510
|
-
for name, body := range map[string]string{
|
|
2511
|
-
".reconcile-base": ".reconcile-base\n",
|
|
2512
|
-
".reconcile-allowlist": ".reconcile-allowlist\n",
|
|
2513
|
-
".reconcile-devrites": "[]\n",
|
|
2514
|
-
"action.log": "Prior root action\n",
|
|
2515
|
-
"browser-evidence.md": "Prior root evidence\n",
|
|
2516
|
-
"decisions.md": "Prior root decision\n",
|
|
2517
|
-
"evidence.md": "Prior root evidence\n",
|
|
2518
|
-
"footprint.log": "Prior root footprint\n",
|
|
2519
|
-
"state.md": "Phase: build\n",
|
|
2520
|
-
"touched-files.md": "Prior root manifest\n",
|
|
2521
|
-
} {
|
|
2522
|
-
if err := os.WriteFile(filepath.Join(workspace, name), []byte(body), 0o600); err != nil {
|
|
2523
|
-
t.Fatal(err)
|
|
2524
|
-
}
|
|
2525
|
-
}
|
|
2526
|
-
if err := os.MkdirAll(filepath.Join(workspace, ".reconcile-objects"), 0o700); err != nil {
|
|
2527
|
-
t.Fatal(err)
|
|
2528
|
-
}
|
|
2529
|
-
|
|
2530
|
-
sessionID, turnID := "session-wright-spawn", "turn-wright-spawn"
|
|
2531
|
-
writeCodexAgentContract(t, root, "devrites-slice-wright")
|
|
2532
|
-
writeCodexSkillContract(t, root, "rite-build", "devrites-slice-wright")
|
|
2533
|
-
runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
2534
|
-
"hook_event_name": "UserPromptSubmit",
|
|
2535
|
-
"session_id": sessionID,
|
|
2536
|
-
"turn_id": turnID,
|
|
2537
|
-
"prompt": "$rite-build",
|
|
2538
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
2539
|
-
|
|
2540
|
-
spawn := hookPayload(t, map[string]any{
|
|
2541
|
-
"hook_event_name": "PreToolUse",
|
|
2542
|
-
"session_id": sessionID,
|
|
2543
|
-
"turn_id": turnID,
|
|
2544
|
-
"tool_name": "spawn_agent",
|
|
2545
|
-
"tool_use_id": "spawn-wright",
|
|
2546
|
-
"tool_input": map[string]any{
|
|
2547
|
-
"agent_type": "devrites-slice-wright",
|
|
2548
|
-
"fork_turns": "none",
|
|
2549
|
-
"message": "Read .codex/agents/devrites-slice-wright.toml.",
|
|
2550
|
-
},
|
|
2551
|
-
})
|
|
2552
|
-
if out, stderr, code := runDevritesIO(t, root, spawn, nil,
|
|
2553
|
-
"hook", "agent-dispatch", "--harness=codex"); code != 0 || strings.TrimSpace(out) != "" {
|
|
2554
|
-
t.Fatalf("spawn exit=%d out=%s stderr=%s", code, out, stderr)
|
|
2555
|
-
}
|
|
2556
|
-
|
|
2557
|
-
raw, err := os.ReadFile(filepath.Join(workspace, ".reconcile-wright-devrites"))
|
|
2558
|
-
if err != nil {
|
|
2559
|
-
t.Fatalf("read wright boundary: %v", err)
|
|
2560
|
-
}
|
|
2561
|
-
for _, path := range []string{
|
|
2562
|
-
"features/auth-tokens/action.log",
|
|
2563
|
-
"features/auth-tokens/browser-evidence.md",
|
|
2564
|
-
"features/auth-tokens/decisions.md",
|
|
2565
|
-
"features/auth-tokens/evidence.md",
|
|
2566
|
-
"features/auth-tokens/footprint.log",
|
|
2567
|
-
"features/auth-tokens/state.md",
|
|
2568
|
-
"features/auth-tokens/touched-files.md",
|
|
2569
|
-
} {
|
|
2570
|
-
if !strings.Contains(string(raw), path) {
|
|
2571
|
-
t.Errorf("wright boundary omitted %s: %s", path, raw)
|
|
2572
|
-
}
|
|
2573
|
-
}
|
|
2574
|
-
}
|
|
2575
|
-
|
|
2576
|
-
func TestCodexAgentDispatchRefreshesUnarmedWrightBoundaryUntilDurableSpawn(t *testing.T) {
|
|
2577
|
-
root := newWorkspace(t)
|
|
2578
|
-
codeHome := t.TempDir()
|
|
2579
|
-
writeActive(t, root, "auth-tokens")
|
|
2580
|
-
workspace := filepath.Join(root, "features", "auth-tokens")
|
|
2581
|
-
for name, body := range map[string]string{
|
|
2582
|
-
".reconcile-base": ".reconcile-base\n",
|
|
2583
|
-
".reconcile-allowlist": ".reconcile-allowlist\n",
|
|
2584
|
-
".reconcile-devrites": "[]\n",
|
|
2585
|
-
"action.log": "Prior root action\n",
|
|
2586
|
-
"browser-evidence.md": "Prior root evidence\n",
|
|
2587
|
-
"decisions.md": "Prior root decision\n",
|
|
2588
|
-
"evidence.md": "Prior root evidence\n",
|
|
2589
|
-
"footprint.log": "Prior root footprint\n",
|
|
2590
|
-
"state.md": "Phase: ready\n",
|
|
2591
|
-
"touched-files.md": "Prior root manifest\n",
|
|
2592
|
-
} {
|
|
2593
|
-
if err := os.WriteFile(filepath.Join(workspace, name), []byte(body), 0o600); err != nil {
|
|
2594
|
-
t.Fatal(err)
|
|
2595
|
-
}
|
|
2596
|
-
}
|
|
2597
|
-
if err := os.MkdirAll(filepath.Join(workspace, ".reconcile-objects"), 0o700); err != nil {
|
|
2598
|
-
t.Fatal(err)
|
|
2599
|
-
}
|
|
2600
|
-
|
|
2601
|
-
sessionID, turnID := "session-wright-durable", "turn-wright-durable"
|
|
2602
|
-
role := "devrites-slice-wright"
|
|
2603
|
-
writeCodexAgentContract(t, root, role)
|
|
2604
|
-
env := []string{"CODEX_HOME=" + codeHome}
|
|
2605
|
-
runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
2606
|
-
"hook_event_name": "UserPromptSubmit",
|
|
2607
|
-
"session_id": sessionID,
|
|
2608
|
-
"turn_id": turnID,
|
|
2609
|
-
"prompt": "Retry the retained reconciliation check.",
|
|
2610
|
-
}), env, "hook", "agent-dispatch", "--harness=codex")
|
|
2611
|
-
|
|
2612
|
-
wrightState := filepath.Join(workspace, ".reconcile-wright-devrites")
|
|
2613
|
-
initial, err := os.ReadFile(wrightState)
|
|
2614
|
-
if err != nil {
|
|
2615
|
-
t.Fatalf("read initial wright boundary: %v", err)
|
|
2616
|
-
}
|
|
2617
|
-
for _, path := range []string{
|
|
2618
|
-
"features/auth-tokens/action.log",
|
|
2619
|
-
"features/auth-tokens/browser-evidence.md",
|
|
2620
|
-
"features/auth-tokens/decisions.md",
|
|
2621
|
-
"features/auth-tokens/evidence.md",
|
|
2622
|
-
"features/auth-tokens/footprint.log",
|
|
2623
|
-
"features/auth-tokens/state.md",
|
|
2624
|
-
"features/auth-tokens/touched-files.md",
|
|
2625
|
-
} {
|
|
2626
|
-
if !strings.Contains(string(initial), path) {
|
|
2627
|
-
t.Errorf("pending wright boundary omitted %s: %s", path, initial)
|
|
2628
|
-
}
|
|
2629
|
-
}
|
|
2630
|
-
if err := os.WriteFile(filepath.Join(workspace, "state.md"), []byte("Phase: build\n"), 0o600); err != nil {
|
|
2631
|
-
t.Fatal(err)
|
|
2632
|
-
}
|
|
2633
|
-
postTool := hookPayload(t, map[string]any{
|
|
2634
|
-
"hook_event_name": "PostToolUse",
|
|
2635
|
-
"session_id": sessionID,
|
|
2636
|
-
"turn_id": turnID,
|
|
2637
|
-
"tool_name": "apply_patch",
|
|
2638
|
-
"tool_use_id": "root-state-edit",
|
|
2639
|
-
"tool_input": map[string]any{"file_path": "state.md"},
|
|
2640
|
-
})
|
|
2641
|
-
if out, stderr, code := runDevritesIO(t, root, postTool, env,
|
|
2642
|
-
"hook", "agent-dispatch", "--harness=codex"); code != 0 || strings.TrimSpace(out) != "" {
|
|
2643
|
-
t.Fatalf("root post-tool refresh exit=%d out=%s stderr=%s", code, out, stderr)
|
|
2644
|
-
}
|
|
2645
|
-
beforeSpawn, err := os.ReadFile(wrightState)
|
|
2646
|
-
if err != nil {
|
|
2647
|
-
t.Fatalf("read refreshed wright boundary: %v", err)
|
|
2648
|
-
}
|
|
2649
|
-
if bytes.Equal(initial, beforeSpawn) {
|
|
2650
|
-
t.Fatal("root PostToolUse did not refresh the pending wright boundary")
|
|
2651
|
-
}
|
|
2652
|
-
|
|
2653
|
-
writeCodexV2Rollouts(
|
|
2654
|
-
t, codeHome, filepath.Dir(root), sessionID, turnID, role,
|
|
2655
|
-
"devrites_slice_wright_unhooked", true, true, true,
|
|
2656
|
-
)
|
|
2657
|
-
if err := os.WriteFile(filepath.Join(workspace, "state.md"), []byte("Writer mutation\n"), 0o600); err != nil {
|
|
2658
|
-
t.Fatal(err)
|
|
2659
|
-
}
|
|
2660
|
-
if out, stderr, code := runDevritesIO(t, root, postTool, env,
|
|
2661
|
-
"hook", "agent-dispatch", "--harness=codex"); code != 0 || strings.TrimSpace(out) != "" {
|
|
2662
|
-
t.Fatalf("post-spawn PostToolUse exit=%d out=%s stderr=%s", code, out, stderr)
|
|
2663
|
-
}
|
|
2664
|
-
afterSpawn, err := os.ReadFile(wrightState)
|
|
2665
|
-
if err != nil {
|
|
2666
|
-
t.Fatalf("read frozen wright boundary: %v", err)
|
|
2667
|
-
}
|
|
2668
|
-
if !bytes.Equal(beforeSpawn, afterSpawn) {
|
|
2669
|
-
t.Fatal("durable V2 spawn did not freeze the pre-writer canonical boundary")
|
|
2670
|
-
}
|
|
2671
|
-
}
|
|
2672
|
-
|
|
2673
|
-
func TestCodexAgentDispatchBindsDurableV2WrightToReconcileWindow(t *testing.T) {
|
|
2674
|
-
for _, tc := range []struct {
|
|
2675
|
-
name string
|
|
2676
|
-
changeWindow bool
|
|
2677
|
-
wantPermitted bool
|
|
2678
|
-
}{
|
|
2679
|
-
{name: "same-window", wantPermitted: true},
|
|
2680
|
-
{name: "changed-window", changeWindow: true},
|
|
2681
|
-
} {
|
|
2682
|
-
t.Run(tc.name, func(t *testing.T) {
|
|
2683
|
-
root := newWorkspace(t)
|
|
2684
|
-
codeHome := t.TempDir()
|
|
2685
|
-
writeActive(t, root, "auth-tokens")
|
|
2686
|
-
workspace := filepath.Join(root, "features", "auth-tokens")
|
|
2687
|
-
for _, name := range []string{".reconcile-base", ".reconcile-allowlist", ".reconcile-devrites"} {
|
|
2688
|
-
if err := os.WriteFile(filepath.Join(workspace, name), []byte(name+"\n"), 0o600); err != nil {
|
|
2689
|
-
t.Fatal(err)
|
|
2690
|
-
}
|
|
2691
|
-
}
|
|
2692
|
-
sessionID, turnID := "session-v2-wright-"+tc.name, "turn-v2-wright-"+tc.name
|
|
2693
|
-
role := "devrites-slice-wright"
|
|
2694
|
-
writeCodexAgentContract(t, root, role)
|
|
2695
|
-
writeCodexSkillContract(t, root, "rite-build", role)
|
|
2696
|
-
runDevritesIO(t, root, hookPayload(t, map[string]any{
|
|
2697
|
-
"hook_event_name": "UserPromptSubmit",
|
|
2698
|
-
"session_id": sessionID,
|
|
2699
|
-
"turn_id": turnID,
|
|
2700
|
-
"prompt": "$rite-build",
|
|
2701
|
-
}), nil, "hook", "agent-dispatch", "--harness=codex")
|
|
2702
|
-
writeCodexV2Rollouts(
|
|
2703
|
-
t, codeHome, filepath.Dir(root), sessionID, turnID, role,
|
|
2704
|
-
"devrites_slice_wright_named", true, true, true,
|
|
2705
|
-
)
|
|
2706
|
-
if tc.changeWindow {
|
|
2707
|
-
future := time.Now().Add(time.Minute)
|
|
2708
|
-
if err := os.Chtimes(
|
|
2709
|
-
filepath.Join(workspace, ".reconcile-devrites"), future, future,
|
|
2710
|
-
); err != nil {
|
|
2711
|
-
t.Fatal(err)
|
|
2712
|
-
}
|
|
2713
|
-
}
|
|
2714
|
-
reconcile := hookPayload(t, map[string]any{
|
|
2715
|
-
"hook_event_name": "PreToolUse",
|
|
2716
|
-
"session_id": sessionID,
|
|
2717
|
-
"turn_id": turnID,
|
|
2718
|
-
"tool_name": "Bash",
|
|
2719
|
-
"tool_input": map[string]any{"command": "rtk devrites-engine reconcile close"},
|
|
2720
|
-
})
|
|
2721
|
-
out, stderr, code := runDevritesIO(t, root, reconcile,
|
|
2722
|
-
[]string{"CODEX_HOME=" + codeHome},
|
|
2723
|
-
"hook", "agent-dispatch", "--harness=codex")
|
|
2724
|
-
if code != 0 {
|
|
2725
|
-
t.Fatalf("reconcile exit=%d stderr=%s", code, stderr)
|
|
2726
|
-
}
|
|
2727
|
-
if tc.wantPermitted && strings.TrimSpace(out) != "" {
|
|
2728
|
-
t.Fatalf("same-window V2 wright was rejected: %s", out)
|
|
2729
|
-
}
|
|
2730
|
-
if !tc.wantPermitted {
|
|
2731
|
-
if decision, _ := parsePermissionDecision(t, out); decision != "deny" {
|
|
2732
|
-
t.Fatalf("changed-window V2 wright was accepted: %s", out)
|
|
2733
|
-
}
|
|
2734
|
-
return
|
|
2735
|
-
}
|
|
2736
|
-
for _, name := range []string{".reconcile-base", ".reconcile-allowlist", ".reconcile-devrites"} {
|
|
2737
|
-
if err := os.Remove(filepath.Join(workspace, name)); err != nil {
|
|
2738
|
-
t.Fatal(err)
|
|
2739
|
-
}
|
|
2740
|
-
}
|
|
2741
|
-
stop := hookPayload(t, map[string]any{
|
|
2742
|
-
"hook_event_name": "Stop",
|
|
2743
|
-
"session_id": sessionID,
|
|
2744
|
-
"turn_id": turnID,
|
|
2745
|
-
})
|
|
2746
|
-
if out, stderr, code := runDevritesIO(t, root, stop, nil,
|
|
2747
|
-
"hook", "agent-dispatch", "--harness=codex"); code != 0 || strings.TrimSpace(out) != "" {
|
|
2748
|
-
t.Fatalf("persisted V2 wright receipt was lost after close: exit=%d out=%s stderr=%s", code, out, stderr)
|
|
2749
|
-
}
|
|
2750
|
-
})
|
|
2751
|
-
}
|
|
2752
|
-
}
|
|
2753
|
-
|
|
2754
|
-
func TestCodexAgentDispatchRejectsWrongGenericRole(t *testing.T) {
|
|
2755
|
-
root := newWorkspace(t)
|
|
2756
|
-
writeCodexAgentContract(t, root, "devrites-security-auditor")
|
|
2757
|
-
spawn := hookPayload(t, map[string]any{
|
|
2758
|
-
"hook_event_name": "PreToolUse",
|
|
2759
|
-
"session_id": "session-role",
|
|
2760
|
-
"turn_id": "turn-role",
|
|
2761
|
-
"tool_name": "spawn_agent",
|
|
2762
|
-
"tool_use_id": "spawn-role",
|
|
2763
|
-
"tool_input": map[string]any{
|
|
2764
|
-
"agent_type": "worker",
|
|
2765
|
-
"fork_turns": "none",
|
|
2766
|
-
"message": "Read .codex/agents/devrites-security-auditor.toml.",
|
|
2767
|
-
},
|
|
2768
|
-
})
|
|
2769
|
-
out, stderr, code := runDevritesIO(t, root, spawn, nil,
|
|
2770
|
-
"hook", "agent-dispatch", "--harness=codex")
|
|
2771
|
-
if code != 0 {
|
|
2772
|
-
t.Fatalf("exit=%d stderr=%s", code, stderr)
|
|
2773
|
-
}
|
|
2774
|
-
if decision, reason := parsePermissionDecision(t, out); decision != "deny" ||
|
|
2775
|
-
!strings.Contains(reason, "devrites-slice-wright") {
|
|
2776
|
-
t.Fatalf("worker role mismatch not denied: decision=%q reason=%q", decision, reason)
|
|
2777
|
-
}
|
|
2778
|
-
}
|