devrites 3.2.24 → 3.2.25

package/CHANGELOG.md

@@ -2,6 +2,12 @@
 
 All notable changes to DevRites are documented here. The format follows [Keep a Changelog](https://keepachangelog.com/en/1.1.0/) and DevRites adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). Releases are generated automatically by [semantic-release](https://semantic-release.gitbook.io/) from Conventional Commits on `main`.
 
+## [3.2.25](https://github.com/ViktorsBaikers/DevRites/compare/v3.2.24...v3.2.25) (2026-07-28)
+
+### Fixed
+
+* **devrites:** close review safety gaps ([178a43e](https://github.com/ViktorsBaikers/DevRites/commit/178a43e5a25a7b0825c0e16aa76c402e6b48a3aa))
+
 ## [3.2.24](https://github.com/ViktorsBaikers/DevRites/compare/v3.2.23...v3.2.24) (2026-07-28)
 
 ### Fixed

package/README.md

@@ -25,7 +25,7 @@ final commit, push, and tag, and it requires a typed `GO` confirmation.
 Unattended runs may create local WIP checkpoint commits along the way, but only
 Ship collapses and pushes them.
 
-**Status:** [`v3.2.24`](https://github.com/ViktorsBaikers/DevRites/releases/tag/v3.2.24): see [`CHANGELOG.md`](CHANGELOG.md) for release notes.
+**Status:** [`v3.2.25`](https://github.com/ViktorsBaikers/DevRites/releases/tag/v3.2.25): see [`CHANGELOG.md`](CHANGELOG.md) for release notes.
 
 ## Quick start
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "devrites",
-  "version": "3.2.24",
+  "version": "3.2.25",
   "description": "DevRites: a disciplined senior-engineer workflow pack for Claude Code and Codex",
   "license": "SEE LICENSE IN LICENSE",
   "homepage": "https://github.com/ViktorsBaikers/DevRites#readme",
@@ -32,10 +32,14 @@
     "engine/",
     "pack/",
     "scripts/",
+    "!scripts/__pycache__/",
+    "!scripts/*.pyc",
+    "!scripts/.cache/",
     "install.sh",
     "uninstall.sh",
     "update.sh",
     "docs/",
+    "!docs/internal/",
     "README.md",
     "LICENSE",
     "SECURITY.md",
@@ -47,7 +51,7 @@
   },
   "scripts": {
     "prepare": "husky || true",
-    "prepack": "bash scripts/build-host-artifacts.sh && rm -rf scripts/__pycache__ scripts/.cache docs/internal",
+    "prepack": "bash scripts/build-host-artifacts.sh",
     "commitlint": "commitlint --edit",
     "validate": "bash scripts/validate.sh",
     "test": "node scripts/run-tests.mjs",

package/scripts/build-host-artifacts.sh

@@ -4,7 +4,7 @@
 #
 # Default output is pack/generated/ so npm pack can ship prebuilt surfaces.
 # Tests may set DEVRITES_HOST_ARTIFACT_DIR to a temporary directory.
-set -u
+set -euo pipefail
 
 ROOT="$(cd "$(dirname "$0")/.." && pwd -P)"
 PACK_SRC="$ROOT/pack/.claude"
@@ -13,7 +13,7 @@ OUT_ROOT="${DEVRITES_HOST_ARTIFACT_DIR:-$ROOT/pack/generated}"
 [ -d "$PACK_SRC/skills" ] || { echo "build-host-artifacts: missing $PACK_SRC/skills" >&2; exit 1; }
 [ -d "$PACK_SRC/agents" ] || { echo "build-host-artifacts: missing $PACK_SRC/agents" >&2; exit 1; }
 
-TMP_GEN_DIR="$(mktemp -d 2>/dev/null || echo "${TMPDIR:-/tmp}/devrites-host-artifacts.$$")"
+TMP_GEN_DIR="$(mktemp -d)"
 cleanup() { rm -rf "$TMP_GEN_DIR"; }
 trap cleanup EXIT
 

package/scripts/build-release-tarball.sh

@@ -57,14 +57,14 @@ PAYLOAD=(
 
 for item in "${PAYLOAD[@]}"; do
   if [[ -e "$item" ]]; then
-    if [[ "$item" == "engine" ]] && git rev-parse --is-inside-work-tree >/dev/null 2>&1; then
+    if git rev-parse --is-inside-work-tree >/dev/null 2>&1; then
       while IFS= read -r -d '' path; do
-        [[ -e "$path" ]] || continue
+        [[ -e "$path" || -L "$path" ]] || continue
         if [[ "$path" == engine/testdata/golden/* ]]; then
           continue
         fi
         mkdir -p "$STAGE/$(dirname "$path")"
-        cp "$path" "$STAGE/$path"
+        cp -P "$path" "$STAGE/$path"
       done < <(git ls-files -z -- "$item")
     else
       cp -R "$item" "$STAGE/"
@@ -73,7 +73,7 @@ for item in "${PAYLOAD[@]}"; do
 done
 
 # Include the same prebuilt host artifacts as the npm package.
-DEVRITES_HOST_ARTIFACT_DIR="$STAGE/pack/generated" bash "$ROOT/scripts/build-host-artifacts.sh" >/dev/null
+DEVRITES_HOST_ARTIFACT_DIR="$STAGE/pack/generated" bash "$STAGE/scripts/build-host-artifacts.sh" >/dev/null
 
 # Remove development files copied with the payload.
 rm -rf "$STAGE/docs/internal" "$STAGE/scripts/.cache" 2>/dev/null || true

package/scripts/check-generated-skill-budget.mjs

@@ -2,8 +2,9 @@
 // Guard generated host skill payloads against accidental context bloat.
 import { existsSync, readFileSync, readdirSync } from 'node:fs';
 import { join, relative } from 'node:path';
+import { fileURLToPath } from 'node:url';
 
-const root = new URL('..', import.meta.url).pathname.replace(/\/$/, '');
+const root = fileURLToPath(new URL('..', import.meta.url));
 const base = process.argv[2] || join(root, 'pack', '.claude', 'skills');
 const totalLimit = Number(process.env.DEVRITES_SKILL_TOTAL_BUDGET || 900_000);
 const fileLimit = Number(process.env.DEVRITES_SKILL_FILE_BUDGET || 64_000);

package/scripts/check-instruction-size-baseline.mjs

@@ -2,8 +2,9 @@
 // Track canonical instruction files individually and skills as a group.
 import { existsSync, mkdirSync, readFileSync, readdirSync, writeFileSync } from 'node:fs';
 import { dirname, join, relative, resolve } from 'node:path';
+import { fileURLToPath } from 'node:url';
 
-const defaultRoot = new URL('..', import.meta.url).pathname.replace(/\/$/, '');
+const defaultRoot = fileURLToPath(new URL('..', import.meta.url));
 const argv = process.argv.slice(2);
 function option(name, fallback) {
   const i = argv.indexOf(name);

package/scripts/check-reference-governance.mjs

@@ -2,8 +2,9 @@
 // Ensure supporting skill references are reachable or explicitly time-bounded.
 import { existsSync, readFileSync, readdirSync } from 'node:fs';
 import { basename, dirname, join, normalize, relative, resolve, sep } from 'node:path';
+import { fileURLToPath } from 'node:url';
 
-const defaultRoot = new URL('..', import.meta.url).pathname.replace(/\/$/, '');
+const defaultRoot = fileURLToPath(new URL('..', import.meta.url));
 const argv = process.argv.slice(2);
 function option(name, fallback) {
   const i = argv.indexOf(name);

package/scripts/pin.sh

@@ -29,7 +29,7 @@
 #   - Manifest-managed: pinned wrappers are recorded in .claude/devrites.manifest
 #     so the standard uninstall.sh cleans them up automatically.
 
-set -u
+set -euo pipefail
 
 # ---- locate install-lib + load helpers ----------------------------------
 SELF_DIR="$( cd "$(dirname "$0")" && pwd -P )"
@@ -77,6 +77,16 @@ MF="$TARGET/$DR_MANIFEST_NAME"
 [ -f "$MF" ]         || dr_die "no manifest at $MF: run install.sh first?"
 
 # ---- helpers -------------------------------------------------------------
+PIN_TMP=""
+cleanup_pin_tmp() {
+  [ -z "$PIN_TMP" ] || rm -rf "$PIN_TMP"
+}
+trap cleanup_pin_tmp EXIT
+
+path_exists() {
+  [ -e "$1" ] || [ -L "$1" ]
+}
+
 valid_alias_name() {
   # lowercase ASCII, digits, hyphens. No /, ., spaces. Not "rite" or "rite-*".
   case "$1" in
@@ -105,6 +115,20 @@ is_pinned_alias_file() {
   grep -q 'description: Alias of DevRites /' "$1"
 }
 
+preflight_alias_destination() {
+  _dir="$1"
+  _file="$2"
+  if [ -L "$_dir" ] || { path_exists "$_dir" && [ ! -d "$_dir" ]; }; then
+    dr_die "$_dir exists and is not a managed alias directory: refusing to overwrite"
+  fi
+  if path_exists "$_file"; then
+    [ ! -L "$_file" ] && is_pinned_alias_file "$_file" \
+      || dr_die "$_file exists and is NOT a pinned alias: refusing to overwrite"
+  elif [ -d "$_dir" ]; then
+    dr_die "$_dir exists without a pinned alias: refusing to overwrite"
+  fi
+}
+
 # ---- subcommands ---------------------------------------------------------
 do_add() {
   valid_alias_name "$ALIAS"    || dr_die "invalid alias name '$ALIAS' (lowercase / digits / hyphens; not 'rite' or 'rite-*')"
@@ -118,34 +142,47 @@ do_add() {
   CODEX_ALIAS_FILE="$CODEX_ALIAS_DIR/SKILL.md"
   CODEX_ALIAS_REL=".agents/skills/$ALIAS/SKILL.md"
 
-  if [ -e "$ALIAS_FILE" ]; then
-    if is_pinned_alias "$ALIAS"; then
-      dr_warn "already pinned: /$ALIAS: overwriting"
-    else
-      dr_die "$ALIAS_FILE exists and is NOT a pinned alias: refusing to overwrite"
-    fi
+  preflight_alias_destination "$ALIAS_DIR" "$ALIAS_FILE"
+  if path_exists "$ALIAS_FILE"; then
+    dr_warn "already pinned: /$ALIAS: overwriting"
   fi
-  if [ -d "$CODEX_SKILLS_DIR" ] && [ -e "$CODEX_ALIAS_FILE" ]; then
-    if is_pinned_alias_file "$CODEX_ALIAS_FILE"; then
+  if [ -d "$CODEX_SKILLS_DIR" ]; then
+    preflight_alias_destination "$CODEX_ALIAS_DIR" "$CODEX_ALIAS_FILE"
+    if path_exists "$CODEX_ALIAS_FILE"; then
       dr_warn "already pinned for Codex: /$ALIAS: overwriting"
-    else
-      dr_die "$CODEX_ALIAS_FILE exists and is NOT a pinned alias: refusing to overwrite"
     fi
   fi
 
+  PIN_TMP="$(mktemp -d "$SKILLS_DIR/.devrites-pin.XXXXXX")"
+  dr_gen_alias_wrapper "$ALIAS" "$DEST" "$PIN_TMP/claude"
+  if [ -d "$CODEX_SKILLS_DIR" ]; then
+    dr_gen_alias_wrapper "$ALIAS" "$DEST" "$PIN_TMP/codex"
+  fi
+  cp -p "$MF" "$PIN_TMP/manifest"
+  if ! dr_manifest_contains "$PIN_TMP/manifest" "$ALIAS_REL"; then
+    printf '%s\n' "$ALIAS_REL" >> "$PIN_TMP/manifest"
+  fi
+  if [ -d "$CODEX_SKILLS_DIR" ] && ! dr_manifest_contains "$PIN_TMP/manifest" "$CODEX_ALIAS_REL"; then
+    printf '%s\n' "$CODEX_ALIAS_REL" >> "$PIN_TMP/manifest"
+  fi
+
   mkdir -p "$ALIAS_DIR"
-  dr_gen_alias_wrapper "$ALIAS" "$DEST" "$ALIAS_FILE"
   if [ -d "$CODEX_SKILLS_DIR" ]; then
     mkdir -p "$CODEX_ALIAS_DIR"
-    dr_gen_alias_wrapper "$ALIAS" "$DEST" "$CODEX_ALIAS_FILE"
   fi
-
-  if ! dr_manifest_contains "$MF" "$ALIAS_REL"; then
-    printf '%s\n' "$ALIAS_REL" >> "$MF"
+  [ -w "$ALIAS_DIR" ] || dr_die "$ALIAS_DIR is not writable"
+  [ -w "$(dirname "$MF")" ] || dr_die "$(dirname "$MF") is not writable"
+  if [ -d "$CODEX_SKILLS_DIR" ]; then
+    [ -w "$CODEX_ALIAS_DIR" ] || dr_die "$CODEX_ALIAS_DIR is not writable"
   fi
-  if [ -d "$CODEX_SKILLS_DIR" ] && ! dr_manifest_contains "$MF" "$CODEX_ALIAS_REL"; then
-    printf '%s\n' "$CODEX_ALIAS_REL" >> "$MF"
+
+  mv "$PIN_TMP/claude" "$ALIAS_FILE"
+  if [ -d "$CODEX_SKILLS_DIR" ]; then
+    mv "$PIN_TMP/codex" "$CODEX_ALIAS_FILE"
   fi
+  mv "$PIN_TMP/manifest" "$MF"
+  rm -rf "$PIN_TMP"
+  PIN_TMP=""
 
   if [ -d "$CODEX_SKILLS_DIR" ]; then
     dr_ok "pinned: /$ALIAS → /$DEST   ($ALIAS_FILE, $CODEX_ALIAS_FILE)"
@@ -166,17 +203,24 @@ do_remove() {
   [ -f "$ALIAS_FILE" ]      || dr_die "no pinned alias at $ALIAS_FILE"
   is_pinned_alias "$ALIAS"  || dr_die "$ALIAS_FILE exists but is not a pinned alias: refusing to remove"
 
+  if path_exists "$CODEX_ALIAS_FILE"; then
+    is_pinned_alias_file "$CODEX_ALIAS_FILE" || dr_die "$CODEX_ALIAS_FILE exists but is not a pinned alias: refusing to remove"
+  fi
+
+  PIN_TMP="$(mktemp -d "$SKILLS_DIR/.devrites-pin.XXXXXX")"
+  awk -v claude="$ALIAS_REL" -v codex="$CODEX_ALIAS_REL" \
+    '$0 != claude && $0 != codex' "$MF" > "$PIN_TMP/manifest"
+
   rm -f "$ALIAS_FILE"
   rmdir "$ALIAS_DIR" 2>/dev/null || true
-  if [ -f "$CODEX_ALIAS_FILE" ]; then
-    is_pinned_alias_file "$CODEX_ALIAS_FILE" || dr_die "$CODEX_ALIAS_FILE exists but is not a pinned alias: refusing to remove"
+  if path_exists "$CODEX_ALIAS_FILE"; then
     rm -f "$CODEX_ALIAS_FILE"
     rmdir "$CODEX_ALIAS_DIR" 2>/dev/null || true
   fi
 
-  # Drop the alias line from the manifest (preserve header + the rest)
-  TMP="$(mktemp)"
-  grep -Fvx "$ALIAS_REL" "$MF" | grep -Fvx "$CODEX_ALIAS_REL" > "$TMP" && mv "$TMP" "$MF"
+  mv "$PIN_TMP/manifest" "$MF"
+  rm -rf "$PIN_TMP"
+  PIN_TMP=""
 
   dr_ok "unpinned: /$ALIAS"
 }
@@ -192,7 +236,9 @@ do_list() {
       found=1
     fi
   done
-  [ "$found" -eq 0 ] && dr_say "(no pinned aliases at $TARGET)"
+  if [ "$found" -eq 0 ]; then
+    dr_say "(no pinned aliases at $TARGET)"
+  fi
 }
 
 case "$SUBCMD" in

package/scripts/run-tests.mjs

@@ -3,8 +3,9 @@ import { spawn } from 'node:child_process';
 import { existsSync, mkdtempSync, readFileSync, readdirSync, rmSync } from 'node:fs';
 import { tmpdir } from 'node:os';
 import { basename, join } from 'node:path';
+import { fileURLToPath } from 'node:url';
 
-const root = new URL('..', import.meta.url).pathname.replace(/\/$/, '');
+const root = fileURLToPath(new URL('..', import.meta.url));
 const testsDir = join(root, 'tests');
 const args = process.argv.slice(2);
 let jobs = Math.max(1, Math.min(5, Math.floor(Number(process.env.DEVRITES_TEST_JOBS || 4)) || 4));

package/scripts/scan-pack-security.py

@@ -151,7 +151,7 @@ def _file_suppressions(text):
 
 # --- driver ---------------------------------------------------------------
 
-TEXT_EXTS = {".md", ".sh", ".json", ".txt", ".py", ".js", ".yaml", ".yml", ""}
+TEXT_EXTS = {".md", ".sh", ".json", ".toml", ".txt", ".py", ".js", ".yaml", ".yml", ""}
 
 
 def iter_files(paths):

package/scripts/skill-pruning-audit.mjs

@@ -2,8 +2,9 @@
 // Advisory pruning audit plus blocking ordered-step completion contracts.
 import { readdirSync, readFileSync, statSync } from 'node:fs';
 import { join, relative } from 'node:path';
+import { fileURLToPath } from 'node:url';
 
-const root = new URL('..', import.meta.url).pathname.replace(/\/$/, '');
+const root = fileURLToPath(new URL('..', import.meta.url));
 const skillsArg = process.argv.indexOf('--skills-dir');
 const skillsDir = skillsArg >= 0 ? process.argv[skillsArg + 1] : join(root, 'pack', '.claude', 'skills');
 const quiet = process.argv.includes('--quiet');

package/scripts/skills-inventory.mjs

@@ -2,8 +2,9 @@
 // Verify the authored DevRites skill inventory and documentation counts.
 import { readdirSync, readFileSync, statSync } from 'node:fs';
 import { join, relative } from 'node:path';
+import { fileURLToPath } from 'node:url';
 
-const root = new URL('..', import.meta.url).pathname.replace(/\/$/, '');
+const root = fileURLToPath(new URL('..', import.meta.url));
 const skillsDir = join(root, 'pack', '.claude', 'skills');
 const docsSkills = join(root, 'docs', 'skills.md');
 const docsCommandMap = join(root, 'docs', 'command-map.md');

package/scripts/validate-workflow-security.py

@@ -20,25 +20,82 @@ import re
 import sys
 
 SHA_RE = re.compile(r"^[0-9a-f]{40}$")
-USES_RE = re.compile(r"^\s*-?\s*uses:\s*([^\s#]+)")
+USES_RE = re.compile(r"^\s*-?\s*uses\s*:\s*([^\s#]+)")
 DEPENDABOT_ONLY_RE = re.compile(
-    r"^\s*if:\s*(?:\$\{\{\s*)?"
+    r"^\s*if\s*:\s*(?:\$\{\{\s*)?"
     r"(?:github\.actor|github\.event\.pull_request\.user\.login)\s*==\s*"
     r"['\"]dependabot\[bot\]['\"]",
     re.MULTILINE,
 )
 UNQUOTED_NAME_COLON_RE = re.compile(r"^\s*(?:-\s*)?name:\s+[^'\"].*:\s+\S")
-RUN_RE = re.compile(r"^(\s*)(?:-\s*)?run:\s*(.*)$")
+RUN_RE = re.compile(r"^(\s*)(?:-\s*)?run\s*:\s*(.*)$")
 DISPATCH_EXPRESSION_RE = re.compile(r"\$\{\{[^}]*\binputs\b", re.IGNORECASE)
+KEY_RE = re.compile(r"^(\s*)([A-Za-z_][A-Za-z0-9_-]*)\s*:\s*(.*)$")
+
+
+def jobs_without_permissions(lines):
+    """Return job IDs missing direct permissions, or None with a global scope."""
+    for line in lines:
+        match = KEY_RE.match(line)
+        if match and not match.group(1) and match.group(2) == "permissions":
+            return None
+
+    jobs_line = None
+    for i, line in enumerate(lines):
+        match = KEY_RE.match(line)
+        if match and not match.group(1) and match.group(2) == "jobs":
+            jobs_line = i
+            break
+    if jobs_line is None:
+        return ["<workflow>"]
+
+    job_indent = None
+    job_starts = []
+    for i in range(jobs_line + 1, len(lines)):
+        line = lines[i]
+        if not line.strip() or line.lstrip().startswith("#"):
+            continue
+        match = KEY_RE.match(line)
+        if not match:
+            continue
+        indent = len(match.group(1))
+        if indent == 0:
+            break
+        if job_indent is None:
+            job_indent = indent
+        if indent == job_indent:
+            job_starts.append((i, match.group(2)))
+    if not job_starts:
+        return ["<workflow>"]
+
+    missing = []
+    for position, (start, job_id) in enumerate(job_starts):
+        end = job_starts[position + 1][0] if position + 1 < len(job_starts) else len(lines)
+        property_indents = []
+        properties = []
+        for line in lines[start + 1:end]:
+            match = KEY_RE.match(line)
+            if not match:
+                continue
+            indent = len(match.group(1))
+            if indent > job_indent:
+                property_indents.append(indent)
+                properties.append((indent, match.group(2)))
+        direct_indent = min(property_indents) if property_indents else None
+        if direct_indent is None or not any(
+                indent == direct_indent and key == "permissions"
+                for indent, key in properties):
+            missing.append(job_id)
+    return missing
 
 
 def safe_dependabot_target(text):
-    if re.search(r"^\s*-?\s*uses:\s*actions/checkout@", text, re.MULTILINE):
+    if re.search(r"^\s*-?\s*uses\s*:\s*actions/checkout@", text, re.MULTILINE):
         return False
-    jobs = text.split("\njobs:", 1)
+    jobs = re.split(r"(?m)^jobs\s*:\s*(?:#.*)?$", text, maxsplit=1)
     if len(jobs) != 2:
         return False
-    blocks = re.split(r"(?m)^  [A-Za-z0-9_-]+:\s*(?:#.*)?$", jobs[1])[1:]
+    blocks = re.split(r"(?m)^  [A-Za-z0-9_-]+\s*:\s*(?:#.*)?$", jobs[1])[1:]
     return bool(blocks) and all(DEPENDABOT_ONLY_RE.search(block) for block in blocks)
 
 
@@ -46,9 +103,11 @@ def scan_text(path, text):
     findings = []
     lines = text.splitlines()
     dependabot_target_is_safe = safe_dependabot_target(text)
-    if not re.search(r"^\s*permissions:", text, re.MULTILINE):
-        findings.append("%s: no permissions block. The default GITHUB_TOKEN is broad; "
-                        "add an explicit least-privilege block" % path)
+    unscoped_jobs = jobs_without_permissions(lines)
+    if unscoped_jobs:
+        findings.append("%s: jobs without explicit permissions: %s. Add a global "
+                        "least-privilege block or scope every job"
+                        % (path, ", ".join(unscoped_jobs)))
     for i, line in enumerate(lines, 1):
         if UNQUOTED_NAME_COLON_RE.match(line):
             findings.append("%s:%d: name has an unquoted colon. Quote the complete "

package/scripts/validate.sh

@@ -15,9 +15,11 @@ good() { printf 'ok: %s\n' "$*"; }
 
 # ---- 1. bash -n on every shell script ------------------------------------
 section "bash syntax (bash -n)"
-SH_LIST="$ROOT/install.sh $ROOT/uninstall.sh $ROOT/update.sh"
-for f in "$ROOT"/scripts/*.sh "$ROOT"/tests/*.sh "$ROOT"/pack/.claude/hooks/*.sh "$ROOT"/pack/.claude/skills/*/scripts/*.sh; do [ -f "$f" ] && SH_LIST="$SH_LIST $f"; done
-for f in $SH_LIST; do
+SH_LIST=("$ROOT/install.sh" "$ROOT/uninstall.sh" "$ROOT/update.sh")
+for f in "$ROOT"/scripts/*.sh "$ROOT"/tests/*.sh "$ROOT"/pack/.claude/hooks/*.sh "$ROOT"/pack/.claude/skills/*/scripts/*.sh; do
+  [ -f "$f" ] && SH_LIST+=("$f")
+done
+for f in "${SH_LIST[@]}"; do
   if bash -n "$f" 2>/tmp/dr_synerr; then good "syntax ${f#$ROOT/}"; else bad "syntax ${f#$ROOT/}: $(cat /tmp/dr_synerr)"; fi
 done
 
@@ -67,10 +69,10 @@ done
 # ---- 5. frontmatter validation ------------------------------------------
 section "frontmatter"
 if command -v python3 >/dev/null 2>&1; then
-  FM_FILES=""
-  for d in "$SKILLS"/*/; do FM_FILES="$FM_FILES ${d}SKILL.md"; done
-  for a in "$AGENTS"/*.md; do FM_FILES="$FM_FILES $a"; done
-  if python3 "$ROOT/scripts/validate-frontmatter.py" $FM_FILES; then good "frontmatter parses"; else bad "frontmatter validation failed"; fi
+  FM_FILES=()
+  for d in "$SKILLS"/*/; do [ -f "${d}SKILL.md" ] && FM_FILES+=("${d}SKILL.md"); done
+  for a in "$AGENTS"/*.md; do [ -f "$a" ] && FM_FILES+=("$a"); done
+  if python3 "$ROOT/scripts/validate-frontmatter.py" "${FM_FILES[@]}"; then good "frontmatter parses"; else bad "frontmatter validation failed"; fi
 else
   echo "skip: python3 not found"
 fi
@@ -335,11 +337,11 @@ fi
 # Local validation skips this gate only when shellcheck is not installed.
 section "shellcheck (-S error blocking · -S warning advisory)"
 if command -v shellcheck >/dev/null 2>&1; then
-  for f in $SH_LIST; do
+  for f in "${SH_LIST[@]}"; do
     if shellcheck -S error "$f"; then good "shellcheck ${f#"$ROOT"/}"; else bad "shellcheck (error) ${f#"$ROOT"/}"; fi
   done
   # Warnings are advisory. Print them per file without failing the build.
-  for f in $SH_LIST; do
+  for f in "${SH_LIST[@]}"; do
     shellcheck -S warning "$f" >/dev/null 2>&1 || echo "  advisory (warning-level): ${f#"$ROOT"/}"
   done
 else