devrites 3.0.2 → 3.0.3

package/scripts/validate-workspace-schema.py

@@ -12,6 +12,8 @@ import re
 import sys
 from pathlib import Path
 
+from workflow_schema import PHASES, cursor_field
+
 
 ID_PATTERNS = {
     "AC": re.compile(r"\bAC-\d{3}\b"),
@@ -112,68 +114,6 @@ SLICE_REQUIRED_FIELDS = (
     "Done condition",
 )
 
-PHASE_REQUIRED = {
-    "frame": ["state.md"],
-    "spec": ["brief.md", "spec.md", "state.md", "decisions.md", "assumptions.md", "questions.md"],
-    "temper": ["brief.md", "spec.md", "state.md", "decisions.md", "assumptions.md", "questions.md"],
-    "plan": [
-        "brief.md",
-        "spec.md",
-        "architecture.md",
-        "plan.md",
-        "tasks.md",
-        "traceability.md",
-        "state.md",
-        "decisions.md",
-        "assumptions.md",
-        "questions.md",
-    ],
-    "vet": [
-        "brief.md",
-        "spec.md",
-        "architecture.md",
-        "plan.md",
-        "tasks.md",
-        "traceability.md",
-        "state.md",
-        "decisions.md",
-        "assumptions.md",
-        "questions.md",
-    ],
-    "build": [
-        "brief.md",
-        "spec.md",
-        "architecture.md",
-        "plan.md",
-        "tasks.md",
-        "traceability.md",
-        "state.md",
-        "decisions.md",
-        "assumptions.md",
-        "questions.md",
-    ],
-    "prove": [
-        "brief.md",
-        "spec.md",
-        "architecture.md",
-        "plan.md",
-        "tasks.md",
-        "traceability.md",
-        "state.md",
-        "decisions.md",
-        "assumptions.md",
-        "questions.md",
-    ],
-    "polish": [],
-    "review": [],
-    "seal": [],
-    "ship": [],
-    "done": [],
-}
-for phase in ("polish", "review", "seal", "ship", "done"):
-    PHASE_REQUIRED[phase] = PHASE_REQUIRED["prove"]
-
-
 def read(path: Path) -> str:
     return path.read_text(encoding="utf-8")
 
@@ -198,12 +138,9 @@ def has_budget_override(text: str) -> bool:
 def phase_for(workspace: Path) -> str:
     for name in ("state.md", "status.md", "README.md", "index.md", "feature.md"):
         p = workspace / name
-        if not p.exists():
-            continue
-        text = read(p)
-        m = re.search(r"(?im)^\s*-?\s*phase\s*:\s*([a-z-]+)", text)
-        if m:
-            return m.group(1).lower()
+        value = cursor_field(p, "phase")
+        if value:
+            return value.split()[0].lower()
     return "spec"
 
 
@@ -374,9 +311,8 @@ def validate_workspace(workspace: Path) -> list[str]:
     if not workspace_index_present(workspace):
         errors.append(f"{workspace}: missing README.md/index.md/feature.md workspace map")
 
-    required = PHASE_REQUIRED.get(phase, PHASE_REQUIRED["spec"])
-    if phase in {"prove", "polish", "review", "seal", "ship", "done"}:
-        required = [*required, "evidence.md", "touched-files.md"]
+    metadata = PHASES.get(phase, PHASES["spec"])
+    required = list(metadata["workspaceRequired"])
     for name in required:
         if not existing_or_alias(workspace, name):
             errors.append(f"{workspace}: phase {phase} requires {name}")
@@ -456,7 +392,7 @@ def validate_workspace(workspace: Path) -> list[str]:
         for ac in sorted(ac_ids):
             if ac not in rows:
                 errors.append(f"{workspace / 'traceability.md'}: {ac} absent from coverage matrix")
-        if phase in {"prove", "polish", "review", "seal", "ship", "done"}:
+        if bool(metadata.get("proofRequired")):
             for eid in sorted(evid_ids):
                 if eid not in trace:
                     errors.append(f"{workspace / 'traceability.md'}: evidence ID {eid} from evidence/browser proof is not mapped")
@@ -467,7 +403,7 @@ def validate_workspace(workspace: Path) -> list[str]:
         elif slice_id not in evidence:
             errors.append(f"{evidence_path}: completed {slice_id} is not referenced by evidence")
 
-    if phase in {"plan", "vet", "build", "prove", "polish", "review", "seal", "ship", "done"}:
+    if bool(metadata.get("blocksOpenQuestions")):
         qfile = workspace / "questions.md"
         if qfile.exists():
             for qid in blocking_questions(read(qfile)):

package/scripts/validate.sh

@@ -219,6 +219,16 @@ fi
 
 # ---- 11b. generated workspace schema fixtures ----------------------------
 section "workspace artifact schema"
+if command -v go >/dev/null 2>&1; then
+  if (cd "$ROOT/engine" && go run ./internal/state/cmd/workflowmanifest -check -out internal/state/workflow_manifest.json) >/tmp/dr_workflow_manifest 2>&1; then
+    good "workflow manifest is fresh"
+  else
+    cat /tmp/dr_workflow_manifest
+    bad "workflow manifest drifted from the typed state registry"
+  fi
+else
+  echo "skip: go not found; workflow manifest freshness not checked"
+fi
 if command -v python3 >/dev/null 2>&1; then
   if python3 "$ROOT/scripts/validate-workspace-schema.py" "$ROOT/tests/fixtures/workspace-schema" >/tmp/dr_workspace_schema 2>&1; then
     cat /tmp/dr_workspace_schema

package/scripts/workflow_schema.py

@@ -0,0 +1,69 @@
+#!/usr/bin/env python3
+"""Read generated workflow metadata and canonical/legacy cursor fields."""
+
+from __future__ import annotations
+
+import json
+import re
+import sys
+from pathlib import Path
+
+
+MANIFEST = Path(__file__).resolve().parents[1] / "engine" / "internal" / "state" / "workflow_manifest.json"
+
+
+DOCUMENT = json.loads(MANIFEST.read_text(encoding="utf-8"))
+
+
+PHASES = {str(phase["id"]): phase for phase in DOCUMENT["phases"]}
+CURSOR_KEY_ALIASES = {
+    str(entry["alias"]): str(entry["canonical"])
+    for entry in DOCUMENT["cursorKeyAliases"]
+}
+
+
+def normalize_cursor_key(key: str) -> str:
+    normalized = "".join(char for char in key.lower() if char.isalnum())
+    canonical = CURSOR_KEY_ALIASES.get(normalized, normalized)
+    return "".join(char for char in canonical.lower() if char.isalnum())
+
+
+def cursor_field_text(text: str, key: str) -> str | None:
+    wanted = normalize_cursor_key(key)
+    for line in text.splitlines():
+        stripped = line.strip()
+        if stripped.startswith("|") and stripped.endswith("|"):
+            cells = [cell.strip() for cell in stripped[1:-1].split("|")]
+            if len(cells) >= 2 and normalize_cursor_key(cells[0]) == wanted:
+                return cells[1]
+        legacy = re.match(r"^\s*[-*+]?\s*([^:]+):\s*(.*?)\s*$", line)
+        if legacy and normalize_cursor_key(legacy.group(1)) == wanted:
+            return re.sub(r"\s*(?:#|\|).*?$", "", legacy.group(2)).rstrip()
+    return None
+
+
+def cursor_field(path: Path, key: str) -> str | None:
+    if not path.is_file():
+        return None
+    return cursor_field_text(path.read_text(encoding="utf-8"), key)
+
+
+def phase_property(phase: str, name: str) -> bool:
+    return bool(PHASES.get(phase.lower(), {}).get(name, False))
+
+
+def main(argv: list[str]) -> int:
+    if len(argv) == 4 and argv[1] == "field":
+        value = cursor_field(Path(argv[2]), argv[3])
+        if value is None:
+            return 1
+        print(value)
+        return 0
+    if len(argv) == 4 and argv[1] == "phase-property":
+        return 0 if phase_property(argv[2], argv[3]) else 1
+    print("usage: workflow_schema.py field <state.md> <key> | phase-property <phase> <property>", file=sys.stderr)
+    return 2
+
+
+if __name__ == "__main__":
+    raise SystemExit(main(sys.argv))