devlyn-cli 4.2.12 → 4.2.14

package/bin/instruction-templates.json

@@ -82,6 +82,7 @@
   "paragraphs": {
     "AGENTS.md": [
       "00044037bbe954aacee48c5edbe01b53aabef90fbe3f0c28c9136dc428fdd7df",
+      "0031285b60a5cf5e965df50482969315e5e62b163bb706695622fb4ed63f3dda",
       "0042d7a45818c8e1c451ac255502ee014fda81a2dbd2a4c04e75a66bc3493940",
       "0144d44eb6a0537211159e5f15baf2cacf11cc3275490ac5d295917df22cff27",
       "01e073f6a5722534affe03ab334fe4a394347f13de5ce191b757a0b7c6f51904",
@@ -91,6 +92,7 @@
       "03d85ed66f64ea52f2f96d9fb203b05ac6afc0ba634a4dfb3585429ce1531c44",
       "0467080d13d933b663362006ae5f5a0ad73baaed51ad50faf3f0d3d9f92244a3",
       "0634a245075d1a5aac4e58c1345f40f5f4c3b4909315f86aacd7ab239ea3ce61",
+      "072b63f736ee80f28550aec03277f033268a232e349ac86c3f1cab4bad9006c0",
       "0869633a322da8f8d800b1d2c23becc52f5ff592f0823533ea24f09de465c53a",
       "090f003bb30b98e6979865f3eb9bbc66eaa8f0cd74a89ff2eea5ef38cbee13b5",
       "0926622dde30d21c6cafe6b69b0bb0608b31e2528655615c7edbdedc6ae43d7c",
@@ -163,6 +165,7 @@
       "3e87f3023f1ee4810c769a27f63244a4c4825fa3c78417abd8a1a4bfb6350134",
       "3efd55e3caac3e3488b81921446bc9ca4ec92ac766abbcfefafeb183b21464a1",
       "3f05e197006cf9715612c67cb8709690e053262e9a0702723e69798ad29a2c08",
+      "3fde1f80f1d0e17ba79a674cb1124b8034df92801e9615c8fa443ce7c7a7672b",
       "41323b1c12be256f604edf8c49ff505acbaa75b6a1b938b76286d5eebec1ce95",
       "41660630582e14f984686f201e6af130e29bbd3fadc3c76a3c6055a7a8f78c4f",
       "41d2ff119ff97961c64e5eb57632c2d04b22794b50eb9227506c4ed763ebca3f",
@@ -374,6 +377,7 @@
       "e237f12ed08800ccc4c6eb4ae57cdd59d61198711f6a3b02dcb668aa08fddb93",
       "e289dbab99dadb30d8315b32b8243154148c82955f238936bce4c1fe1c3ae525",
       "e2bac40f3ff0b39726f95caaa9b19aa3b21596f165ac7a9dc68ebf42681d58cb",
+      "e389e1e77cc2da32214e95451b25b45402b1b586b26f5688bb373c492db3fcfb",
       "e3ee2da50e961046da3f5b68b0c328570307fb21a93424ae22536b8f216b55a3",
       "e43e4b5b86044fbf7be8d7fd1e3e27cd2089bfc8243e07dc2c3fc034c19794ea",
       "e44015948c7d04e60f3fed7e348c2052538e7784d8fe7ea3edf9f52de07448dd",
@@ -652,6 +656,7 @@
       "6170d780ab4f3cb5e2ea7d2757f9239d35dbbc1f9398e73877a95d5ef4c582ee",
       "624becc31a3b8619bab2b863a469b8bc6b19fc48acaa7d59a455057ff8d7cce1",
       "635097bbe52855009ba78ab992a905aad63b755a4b5c688179d8d597d5c9da01",
+      "65997521bd2bee492eeadc8570bf71f374cf1a05856d4acca499350b3db0dc7c",
       "65b903f779d8879f04e427a400a04bd29ab982ab28a62c2c172620773518242b",
       "6639e9e9622eca3d978923f26bf6f6ba1a95be4059206cc27c62e9deb026146a",
       "6693baa07666a5853ea606c25812f70550d28f6182d9c9dbfc1421270f1ec544",
@@ -665,6 +670,7 @@
       "6a08a11aea6a1dfaa99823a73bc8730e8fff9c483ec8989aaeca669cfc7b3ed6",
       "6a27907ba14fae9ddcacd551007b783b2f813c51c118828c74fd2174e09a7d41",
       "6a5ea10aa15a05ac992bd118adc3c0de48c85cea504aef655065d9678f93717c",
+      "6b098e67dbcdbec4569fb950f2067e4c4843a3b5f26a4e8886820102542eddee",
       "6b26d02b3f87d53a964b6fe405992104dd2ee85f8c1b3048951ece574d9005a8",
       "6b65f3883cfca3d531ab716c069c88f3a7d964657c5e026bda25eacdb37f16c5",
       "6b726d35cdc0851401769b6de9c422cfa475dbe7c0d036726706439a2cdbb02a",
@@ -699,6 +705,7 @@
       "7b47b07e3062f3dc839f11397bc3265120e01a35b0fda094d738e28a6729e6c3",
       "7bb5c341115c56592c0d1b5903d01321ce9c324136bc53babf9d438389796d94",
       "7c0dacd603b4381539d6d3cf21f5fe625cf54b05eb4aa750fce658529b11d81d",
+      "7c6c98c3dc37aa0760796051b0b81ac10b9ebad7c9d7da3615b3fd764e589766",
       "7c79750557c7d7156df6f135fb582ec09cc5f4987ac8e2af0f5113e42c117224",
       "7d083db061c678113c12453eb73299caa9e207dd6418ad63406154fd330f3309",
       "7d2239e2cd4893c57ac0bf1373a2ef46419f614d0ce18a12df51222bc7795327",
@@ -916,6 +923,7 @@
       "e2070548ec9a6244c569ef0b9a43c2e5dd99cf9c0fa4540a21fd0595b291e444",
       "e29fec7d54a144ea4867a3764fccdee6849d58d0f32eacdd56b2c317863fa1c6",
       "e2e0fc585321ee2013cccaed95d47c49fbca71b54c67abad9080d19d70e3c1a5",
+      "e389e1e77cc2da32214e95451b25b45402b1b586b26f5688bb373c492db3fcfb",
       "e3b2f7be15a793f07cbe8e51aa2feeac51d4c67077b94e5e20bad2e14be07fc5",
       "e468c242cc38c390f9679fca61f355848f58d51570249dfbb65b4f2e26a9dfb1",
       "e4bafa0f553e899b65f05feabf4cbe86d8246c57cbba745eb79e6aa858f40a6b",

package/bin/skill-history.json

@@ -334,6 +334,7 @@
       "a3b852c30898b572021b32721638f67d9f44cae98653da3362456a7b88208de7",
       "a7d7d65fd5f672cb404e6069fdc42ad7077deaa80ed8500cfa8b382dab2e3e29",
       "aba66b674683935e4c28c93333896dc116ffe67e7a35fe30b3599a8be507e94e",
+      "b2e4437fa981317362d03ee032e1cfd8b686316e966c6ba12ecd619a009c80a6",
       "c1b8e3ebf38e2be8972aa003e9614a782cb4f195c69d20b95a475ebf9aaaab9e",
       "ce282a55328c2d071cacc377670fbebea4da4b9a7fee81b25293fb26763f17c9",
       "cf61a917a804503ef1e26fbb1cf498181e843a0758ec001f84edb7bcac837448",

package/config/skills/devlyn-ideate/scripts/acceptance.py

@@ -267,18 +267,32 @@ def guard_results(packet, expected, source):
         results.append({"rule": "forbidden_files", "subject": path, "passed": path not in changed, "blocking": True})
     limit = expected.get("max_deps_added", 0)
     try:
-        added = len(dependency_names(work, source) - dependency_names(work, inputs))
-        subject, passed = f"{added} added, limit {limit}", added <= limit
+        before = dependency_names(work, inputs)
     except ValueError as exc:
-        subject, passed = str(exc), False
+        subject, passed = (f"inputs package.json at {inputs} unreadable; limit cannot apply. "
+                           f"Fix base: regular npm-valid file; start a new loop. {exc}"), False
+    else:
+        try:
+            added = len(dependency_names(work, source) - before)
+            subject, passed = f"{added} added, limit {limit}", added <= limit
+        except ValueError as exc:
+            subject, passed = f"candidate package.json at {source} is invalid; fix it in the candidate. {exc}", False
     results.append({"rule": "max_deps_added", "subject": subject, "passed": passed, "blocking": True})
     return results
 
 
 def dependency_names(work, commit):
     """Package names under dependencies and devDependencies of the root package.json at `commit`; a missing file has none."""
-    if not git(work, "ls-tree", commit, "--", "package.json").stdout:
+    entry = git(work, "ls-tree", commit, "--", "package.json").stdout
+    if not entry:
         return set()
+    mode, kind, _ = entry.split(maxsplit=2)
+    if mode not in (b"100644", b"100755") or kind != b"blob":
+        kind = "symlink" if mode == b"120000" else "gitlink" if mode == b"160000" else kind.decode("ascii")
+        if mode == b"120000":
+            target = git(work, "show", f"{commit}:package.json").stdout.decode("utf-8", "backslashreplace")
+            kind += f" to {target!r}"
+        raise ValueError(f"{kind} (mode {mode.decode('ascii')}); expected a regular file")
     try:
         # Read as npm reads it: a leading BOM is ignored, a duplicate key's last value wins, a null section is empty and
         # NaN or Infinity is invalid.
@@ -718,7 +732,9 @@ class AcceptanceTests(unittest.TestCase):
         moved from dependencies to devDependencies counts 0 and is accepted; an invalid package.json fails the guard,
         naming it. A leading UTF-8 BOM, which npm and Node accept, is ignored: with one at both commits, one added
         counts 1. A duplicate key (its last value wins) and a null dependencies section, which npm also reads, count 0
-        and are accepted; NaN, which npm rejects, fails the guard."""
+        and are accepted; NaN, which npm rejects, fails the guard. Invalid inputs fail before an invalid candidate,
+        naming inputs and the base repair/new loop action; invalid candidates name the candidate and its repair.
+        The action survives the queue's 200-character first-reason collapse, with parser detail after it."""
         passing = {"verification_commands": [{"argv": [sys.executable, "-c", "pass"], "contract_refs": ["R1"]}]}
 
         def guard(inputs, source):
@@ -743,7 +759,7 @@ class AcceptanceTests(unittest.TestCase):
         with self.subTest("invalid"):
             commit, result, deps = guard({"dependencies": {"a": "1"}}, '{"dependencies": {"a": "1",}}\n')
             self.assertEqual((deps["passed"], result["verdict"]), (False, "FAILED"))
-            self.assertIn(f"package.json at {commit} is invalid", deps["subject"])
+            self.assertTrue(deps["subject"].startswith(f"candidate package.json at {commit} is invalid; fix it in the candidate."))
         with self.subTest("BOM"):
             self.write("package.json", "\ufeff" + json.dumps({"dependencies": {"a": "1"}}))
             _, _, deps = guard(None, "\ufeff" + json.dumps({"dependencies": {"a": "1", "b": "1"}}))
@@ -755,7 +771,72 @@ class AcceptanceTests(unittest.TestCase):
         with self.subTest("NaN"):
             commit, result, deps = guard({"dependencies": {"a": "1"}}, '{"config": {"threshold": NaN}}')
             self.assertEqual((deps["passed"], result["verdict"]), (False, "FAILED"))
-            self.assertIn(f"package.json at {commit} is invalid", deps["subject"])
+            self.assertTrue(deps["subject"].startswith(f"candidate package.json at {commit} is invalid; fix it in the candidate."))
+        with self.subTest("invalid inputs precede invalid candidate"):
+            self.write("package.json", "{")
+            _, result, deps = guard(None, "[")
+            self.assertEqual((deps["passed"], result["verdict"]), (False, "FAILED"))
+            self.assertTrue(deps["subject"].startswith(f"inputs package.json at {self.packet['inputs_sha']} unreadable; limit cannot apply."))
+            one_line = runpy.run_path(str(Path(__file__).with_name("queue.py")))["one_line"]
+            for size in (40, 64):
+                reason = result["reasons"][0].replace(self.packet["inputs_sha"], "a" * size)
+                self.assertIn("Fix base: regular npm-valid file; start a new loop", one_line(reason))
+
+    @unittest.skipIf(os.name == "nt", "a symbolic link needs a privilege on Windows")
+    def test_max_deps_added_rejects_symlinks(self):
+        """Prediction: a candidate package.json symlink to a file named '{}' containing a dependency fails the guard,
+        naming the candidate, symlink and target; before, the target text parsed as an empty object and passed limit 0.
+        An ordinary candidate symlink also names its target and candidate repair. An inputs symlink fails first even
+        when the candidate is invalid JSON, naming inputs and the base repair/new loop action."""
+        passing = {"verification_commands": [{"argv": [sys.executable, "-c", "pass"], "contract_refs": ["R1"]}]}
+        package = self.work / "package.json"
+        one_line = runpy.run_path(str(Path(__file__).with_name("queue.py")))["one_line"]
+        for side, target in (("candidate", "{}"), ("inputs", "deps.json"), ("candidate", "deps.json")):
+            with self.subTest(side=side, target=target):
+                package.unlink(missing_ok=True)
+                self.write(target, json.dumps({"dependencies": {"hidden": "1"}}))
+                if side == "inputs":
+                    package.symlink_to(target)
+                else:
+                    self.write("package.json", "{}")
+                self.inputs(passing)
+                package.unlink()
+                if side == "candidate":
+                    package.symlink_to(target)
+                else:
+                    self.write("package.json", "[")
+                source = self.commit("product")
+                result = self.submit(source)
+                deps = next(g for g in result["guards"] if g["rule"] == "max_deps_added")
+                self.assertEqual((deps["passed"], result["verdict"]), (False, "FAILED"))
+                commit = self.packet["inputs_sha"] if side == "inputs" else source
+                self.assertTrue(deps["subject"].startswith(f"{side} package.json at {commit}"))
+                self.assertIn(f"symlink to {target!r}", deps["subject"])
+                action = "Fix base: regular npm-valid file; start a new loop" if side == "inputs" else "fix it in the candidate."
+                self.assertIn(action, one_line(result["reasons"][0]))
+
+    def test_max_deps_added_requires_regular_blobs(self):
+        """Prediction: both regular blob modes count names; a tree or gitlink at package.json fails the guard with
+        its kind and candidate repair, rather than escaping as an AcceptanceError without a guard subject."""
+        self.write("package.json", '{"dependencies": {"a": "1"}}')
+        self.inputs()
+        inputs = self.packet["inputs_sha"]
+        blob = self.g("rev-parse", f"{inputs}:package.json")
+        tree = self.g("rev-parse", f"{inputs}^{{tree}}")
+        for mode, kind, oid in (("100644", "blob", blob), ("100755", "blob", blob),
+                                ("040000", "tree", tree), ("160000", "commit", inputs)):
+            with self.subTest(mode=mode):
+                made = subprocess.run(["git", "-C", str(self.work), "mktree"],
+                                      input=f"{mode} {kind} {oid}\tpackage.json\n".encode(), capture_output=True, check=True)
+                source = self.g("commit-tree", made.stdout.decode().strip(), "-p", inputs, "-m", "package kind")
+                deps = next(g for g in guard_results(self.packet, {}, source) if g["rule"] == "max_deps_added")
+                if kind == "blob":
+                    self.assertEqual(dependency_names(self.work, source), {"a"})
+                    self.assertEqual((deps["passed"], deps["subject"]), (True, "0 added, limit 0"))
+                else:
+                    self.assertFalse(deps["passed"])
+                    self.assertTrue(deps["subject"].startswith(f"candidate package.json at {source} is invalid; fix it in the candidate."))
+                    self.assertIn("gitlink" if kind == "commit" else kind, deps["subject"])
 
 
 def main():

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "devlyn-cli",
-  "version": "4.2.12",
+  "version": "4.2.14",
   "description": "Loop & harness engineering for AI coding agents (Claude Code, Codex, and any AGENTS.md-driven agent) — core engineering principles for CLAUDE.md/AGENTS.md and a loop designer that splits one intent into tasks agents drain hands-free",
   "homepage": "https://github.com/fysoul17/devlyn-cli#readme",
   "bin": {