devlyn-cli 0.1.1 → 0.1.2
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
|
@@ -5,8 +5,9 @@ Perform a comprehensive post-implementation review. After receiving tool results
|
|
|
5
5
|
2. Read all changed files in parallel (use parallel tool calls)
|
|
6
6
|
3. Check each file against the review checklist below
|
|
7
7
|
4. Fix issues directly—do not just suggest fixes
|
|
8
|
-
5. Run
|
|
9
|
-
6.
|
|
8
|
+
5. Run linter (`npm run lint` or equivalent) and fix all reported lint issues
|
|
9
|
+
6. Run test suite to verify changes don't break existing functionality
|
|
10
|
+
7. If lint or tests fail → use devlyn.resolve workflow to fix, then re-run
|
|
10
11
|
7. Generate summary report with file:line references
|
|
11
12
|
8. Block approval if any CRITICAL or HIGH issues remain unfixed OR tests fail
|
|
12
13
|
</procedure>
|
|
@@ -79,7 +80,10 @@ Be persistent. Complete the full review before stopping.
|
|
|
79
80
|
|
|
80
81
|
**Approval**: [BLOCKED / APPROVED]
|
|
81
82
|
|
|
82
|
-
- BLOCKED if any CRITICAL or HIGH issues remain unfixed OR tests fail
|
|
83
|
+
- BLOCKED if any CRITICAL or HIGH issues remain unfixed OR lint/tests fail
|
|
84
|
+
|
|
85
|
+
**Lint**: [PASS / FAIL]
|
|
86
|
+
- [lint summary or issue details]
|
|
83
87
|
|
|
84
88
|
**Tests**: [PASS / FAIL]
|
|
85
89
|
- [test summary or failure details]
|
|
@@ -155,14 +155,16 @@ You are the **Test Analyst** on an Agent Team performing a code review.
|
|
|
155
155
|
2. Find existing test files for the changed code
|
|
156
156
|
3. Assess test coverage for the changes
|
|
157
157
|
4. Run the full test suite and report results
|
|
158
|
-
5.
|
|
158
|
+
5. Run the project linter (`npm run lint` or equivalent) and report any lint errors/warnings on changed files
|
|
159
|
+
6. Identify missing test scenarios and edge cases
|
|
159
160
|
|
|
160
161
|
**Your deliverable**: Send a message to the team lead with:
|
|
161
162
|
1. Test suite results: PASS or FAIL (with failure details)
|
|
162
|
-
2.
|
|
163
|
-
3.
|
|
164
|
-
4.
|
|
165
|
-
5.
|
|
163
|
+
2. Lint results: PASS or FAIL (with issue details on changed files)
|
|
164
|
+
3. Coverage gaps: what changed code lacks tests
|
|
165
|
+
4. Missing edge cases that should be tested
|
|
166
|
+
5. Test quality assessment
|
|
167
|
+
6. Recommended tests to add
|
|
166
168
|
|
|
167
169
|
Read the team config at ~/.claude/teams/{team-name}/config.json to discover teammates. Share test results with other reviewers via SendMessage.
|
|
168
170
|
</test_analyst_prompt>
|
|
@@ -278,14 +280,17 @@ Present the final review in this format:
|
|
|
278
280
|
### Review Complete
|
|
279
281
|
|
|
280
282
|
**Approval**: [BLOCKED / APPROVED]
|
|
281
|
-
- BLOCKED if any CRITICAL or HIGH issues remain unfixed OR tests fail
|
|
283
|
+
- BLOCKED if any CRITICAL or HIGH issues remain unfixed OR lint/tests fail
|
|
282
284
|
|
|
283
285
|
**Team Composition**: [N] reviewers
|
|
284
286
|
- **Security Reviewer**: [N issues found / Clean]
|
|
285
287
|
- **Quality Reviewer**: [N issues found / Clean]
|
|
286
|
-
- **Test Analyst**: [PASS/FAIL, N coverage gaps]
|
|
288
|
+
- **Test Analyst**: [Tests PASS/FAIL, Lint PASS/FAIL, N coverage gaps]
|
|
287
289
|
- **[Conditional reviewers]**: [findings summary]
|
|
288
290
|
|
|
291
|
+
**Lint**: [PASS / FAIL]
|
|
292
|
+
- [lint summary or issue details]
|
|
293
|
+
|
|
289
294
|
**Tests**: [PASS / FAIL]
|
|
290
295
|
- [test summary or failure details]
|
|
291
296
|
|
|
@@ -49,11 +49,13 @@ Severity framework and quality bar for reviewing code changes. Apply this framew
|
|
|
49
49
|
**BLOCKED** if any of:
|
|
50
50
|
- CRITICAL issues remain unfixed
|
|
51
51
|
- HIGH issues remain unfixed
|
|
52
|
+
- Lint fails
|
|
52
53
|
- Tests fail
|
|
53
54
|
|
|
54
55
|
**APPROVED** when:
|
|
55
56
|
- All CRITICAL and HIGH issues are fixed
|
|
56
57
|
- MEDIUM issues are fixed or have concrete justification for deferral
|
|
58
|
+
- Lint passes
|
|
57
59
|
- Test suite passes
|
|
58
60
|
|
|
59
61
|
## Review Process
|
|
@@ -62,8 +64,9 @@ Severity framework and quality bar for reviewing code changes. Apply this framew
|
|
|
62
64
|
2. Check each file against the severity framework
|
|
63
65
|
3. For each issue: state severity, file:line, what it is, why it matters
|
|
64
66
|
4. Fix issues directly — don't just list them
|
|
65
|
-
5. Run
|
|
66
|
-
6.
|
|
67
|
+
5. Run linter (`npm run lint` or equivalent) and fix all reported issues
|
|
68
|
+
6. Run the test suite after all fixes
|
|
69
|
+
7. If lint or tests fail → use `/devlyn.resolve` or `/devlyn.team-resolve` to fix
|
|
67
70
|
|
|
68
71
|
## Routing
|
|
69
72
|
|