devflow-kit 3.9.0 → 3.11.0

package/src/assets/scripts/hooks/preamble

@@ -3,11 +3,16 @@
 # Devflow Preamble: UserPromptSubmit Hook
 # Three behaviors (git repos only — silent outside a git tree):
 #   1. Plan-handoff fast-path: if prompt begins `Implement the following plan:` (Claude Code's
-#      native plan-mode handoff), inject a directive to invoke devflow:implement immediately.
-#      NOTE: the literal prefix is duplicated in orchestrator-charter.md (fallback bullet)
-#      and src/assets/scripts/hooks/preamble — update both together if Claude Code changes the handoff format.
+#      native plan-mode handoff) AND devflow:implement is installed, inject a directive to invoke
+#      devflow:implement immediately. devflow writes the file hooks/assets/implement-installed
+#      while implement is installed and removes it otherwise; the hook only tests that the file
+#      exists. Without it a handoff prompt falls through to the reminder (behavior 3).
+#      NOTE: the literal prefix is duplicated in orchestrator-charter.md (plan-handoff bullet,
+#      which the installed render drops when implement is absent) and in the dispatch below —
+#      update both together if Claude Code changes the handoff format.
 #   2. Slash skip: no reminder for slash commands (/...).
-#   3. Orchestrator reminder (2 lines): all other prompts get a delegation reminder.
+#   3. Orchestrator reminder (2 lines): all other prompts, and a handoff prompt when implement
+#      is not installed, get a generic delegation reminder.
 
 # Safe no-op fallback: must exist before hook-bootstrap is sourced.
 dbg() { :; }
@@ -52,7 +57,12 @@ if ! df_has_git_marker "$CWD" 2>/dev/null; then dbg "EXIT: not a git repo"; exit
 # --- Prompt dispatch (pure bash 3.2; no subprocess in this block) ---
 # The plan-handoff prefix is a Claude Code protocol marker (native "execute plan
 # in new session" handoff), matched literally — plumbing, not semantic detection.
-# Duplicated in orchestrator-charter.md (fallback bullet); update both together.
+# Duplicated in orchestrator-charter.md (plan-handoff bullet); update both together.
+# The handoff branch also needs the implement sentinel file: the directive names
+# devflow:implement, so it fires only while that command is installed. The sentinel
+# check is a builtin file test (no fork) and runs only after the prefix matched.
+# Its path equals HANDOFF_SENTINEL_RELPATH in src/targets/claude-code/charter-render.ts
+# (the hooks directory is SCRIPT_DIR); tests/shell-hooks.test.ts pins the match.
 # Known bound: prefix must appear within the first 256 bytes after whitespace
 # strip (native handoffs have zero leading whitespace).
 HEAD="${PROMPT:0:256}"
@@ -60,7 +70,7 @@ HEAD="${HEAD#"${HEAD%%[![:space:]]*}"}"   # strip leading whitespace/newlines
 
 if [ -z "$HEAD" ]; then
   dbg "EXIT: empty prompt"
-elif [[ "$HEAD" == "Implement the following plan:"* ]]; then
+elif [[ "$HEAD" == "Implement the following plan:"* ]] && [ -f "$SCRIPT_DIR/assets/implement-installed" ]; then
   dbg "PLAN_HANDOFF detected — injecting devflow:implement directive"
   # D-ARGS-ONCE: the directive passes the Skill call NO arguments. The handoff
   # prompt IS the plan, so it is already in the conversation; handing it to the
@@ -75,8 +85,8 @@ elif [[ "$HEAD" == "/"* ]]; then
   dbg "EXIT: slash command — no reminder"
 else
   dbg "ORCHESTRATOR_REMINDER injected"
-  json_prompt_output "Orchestrator reminder: coordinate, don't produce — delegate edits, builds and multi-file reads to the fitting roster agent (Agent tool) or the matching devflow workflow skill. Send debug work to the devflow:debug skill, never to the Debug agent.
-Keep only judgment work mainline: conversation, decisions, routing, synthesis of agent reports."
+  json_prompt_output "Orchestrator reminder: coordinate, don't produce — delegate edits, builds and multi-file reads to the fitting roster agent (Agent tool) or the matching devflow workflow skill.
+Keep only judgment work mainline: conversation, decisions, routing, combining a few agent reports."
 fi
 
 dbg "=== HOOK COMPLETE ==="

package/src/assets/scripts/hooks/session-start-orchestrator

@@ -3,8 +3,10 @@
 # SessionStart Hook: Orchestrator Charter Injection
 # Presence-gated: registered/removed by `devflow ambient --enable/--disable`.
 # Git repos only: silent outside a git repo (df_has_git_marker bounded walk).
-# Charter includes the plan-handoff fallback bullet — SessionStart provably fires
-# (SessionStart:clear) in plan-handoff sessions even if UserPromptSubmit does not.
+# The installed charter carries the plan-handoff fallback bullet only while
+# devflow:implement is installed (init renders the charter for the installed plugin set) —
+# SessionStart provably fires (SessionStart:clear) in plan-handoff sessions even if
+# UserPromptSubmit does not.
 # NOTE: the literal prefix `Implement the following plan:` is duplicated in
 # src/assets/scripts/hooks/preamble — update both if Claude Code changes the handoff format.
 

package/src/assets/scripts/pr-evidence.cjs

@@ -250,7 +250,11 @@ const WAVE_VERDICTS = Object.freeze(/** @type {WaveVerdict[]} */ (['PASS', 'UNVE
 /** The verdicts of a ticket that merged — the only rows a `Closes` line may name. */
 const WAVE_MERGED_VERDICTS = Object.freeze(/** @type {WaveVerdict[]} */ (['PASS', 'UNVERIFIED']));
 
-/** An Evaluate or Test cell: a Gate 2 verdict, or `—` where the gate never ran. */
+/**
+ * An Evaluate or Test cell: a Gate 2 verdict, or `—` where the gate never ran or a Test run gave no result.
+ * `BLOCKED` is never a cell here, and it has two meanings in the table: a row Verdict `BLOCKED` is a ticket that
+ * never ran, and a Test result `BLOCKED` is a run that gave no result, shown as `—`.
+ */
 const WAVE_GATE_VALUES = Object.freeze(['PASS', 'FAIL', 'FAIL-FIXED', 'SKIPPED', EM_DASH]);
 
 /** A Coverage cell: whether the review pass covered every focus. */
@@ -1816,6 +1820,26 @@ function parseWaveRow(line) {
   };
 }
 
+/**
+ * D-WAVE-LINKS-ONLY: the links-only block, for related lines that ran to the end of the
+ * text. Only `Refs #<n>` and `Refs <KEY-N>` lines make a block of their own (RELATED_LINE_RE
+ * has already shaped each ref), and a ref may not repeat. Null when the lines are not all
+ * `Refs` lines: the caller refuses the block as before.
+ *
+ * @param {readonly WaveRelated[]} related
+ * @returns {Result<WaveBlock> | null}
+ */
+function parseLinksOnlyBlock(related) {
+  if (related.length === 0 || !related.every(rel => rel.keyword === 'Refs')) return null;
+  /** @type {Set<string>} */
+  const seen = new Set();
+  for (const rel of related) {
+    if (seen.has(rel.ref)) return fail('duplicate', rel.line);
+    seen.add(rel.ref);
+  }
+  return ok(Object.freeze({ tracking: null, related: Object.freeze(related), rows: Object.freeze([]) }));
+}
+
 /**
  * D-WAVE: parse a wave block (LF or CRLF, at most WAVE_BLOCK_CHARS). It holds
  * exactly, in order: `## Related Issues`; 0–WAVE_ROWS + 1 related lines; one
@@ -1838,13 +1862,23 @@ function parseWaveRow(line) {
  * like every related line, so it adds no free text to the body. A leading `Refs`
  * that names a row is that row's line, never a tracking line.
  *
+ * D-WAVE-LINKS-ONLY: with `options.linksOnly === true` (the opt-in, spelled
+ * `check wave --links-only` on the command line), a block may also be the
+ * `## Related Issues` heading and 1–WAVE_ROWS + 1 `Refs #<n>` or `Refs <KEY-N>` lines and
+ * nothing after them (blank lines aside): no evidence section, no rows. It parses to no
+ * tracking line and no rows. A ref may not repeat (`duplicate`). `Closes` is never
+ * admitted there: with no row, nothing has merged, so nothing may close an issue.
+ * Without the opt-in, and for any other block that stops after its related lines, a lone
+ * `Closes #<n>` included, the block is `malformed`, as the grammar stood before the opt-in.
+ *
  * Structure is checked before the cross rules, so the first failure found is the
  * one reported. An error carries a code and a line number, never input bytes.
  *
  * @param {unknown} text
+ * @param {{ linksOnly?: boolean }} [options]
  * @returns {Result<WaveBlock>}
  */
-function parseWaveBlock(text) {
+function parseWaveBlock(text, options) {
   if (typeof text !== 'string') return fail('invalid');
   if (text.length > LIMITS.WAVE_BLOCK_CHARS) return fail('oversize');
   const rows = textLines(text);
@@ -1867,6 +1901,11 @@ function parseWaveBlock(text) {
       line: i + 1,
     }));
   }
+  // D-WAVE-LINKS-ONLY: the opt-in is set and the related lines ran to the end of the text.
+  if (isObject(options) && options.linksOnly === true && i >= end) {
+    const linksOnly = parseLinksOnlyBlock(related);
+    if (linksOnly !== null) return linksOnly;
+  }
   // rows[i] is the one blank line; indices past `end` hold only blanks, so a
   // missing section fails the first comparison that expects a non-blank line.
   if (rows[i + 1] !== WAVE_HEADINGS[1]) return fail('malformed', i + 2);