devflow-kit 2.5.0 → 3.0.0

package/src/assets/scripts/verify-evidence.cjs

@@ -517,7 +517,7 @@ function gh(io, args, maxBuffer) {
 
 /**
  * Every git call: `-c core.fsmonitor=false` first, so no repository-configured
- * hook runs, and bounded by the deadline.
+ * hook runs (D-NO-FSMONITOR), and bounded by the deadline.
  *
  * @param {Io} io
  * @param {readonly string[]} args

package/src/assets/skills/compliance/SKILL.md

@@ -99,13 +99,13 @@ resource "aws_s3_bucket_logging" "data" { target_bucket = var.audit_bucket_id }
 | **CRITICAL** | Plaintext regulated data exposed; public IaC exposure of regulated stores |
 | **HIGH** | Missing audit trail on regulated mutations; PII in logs or errors |
 | **MEDIUM** | Missing retention/erasure paths; weak traceability (no actor/purpose) |
-| **LOW** | No active framework reference files installed; documentation/annotation gaps |
+| **LOW** | Documentation/annotation gaps |
 
 ${DEVFLOW_COMPLIANCE_MAPPING}
 
 ## Checklist
 
-- [ ] Active frameworks identified from installed `references/{id}.md` files; controls applied
+- [ ] Frameworks in force are the ids given (`COMPLIANCE_FRAMEWORKS`); their controls applied
 - [ ] No PII/PHI/payment data in logs, errors, or analytics events
 - [ ] Regulated data encrypted in transit (TLS 1.2+) and at rest
 - [ ] Every regulated mutation has an append-only audit entry (actor, purpose, timestamp)

package/src/assets/skills/docs-framework/SKILL.md

@@ -117,15 +117,14 @@ TOPIC_SLUG=$(echo "$TOPIC" | tr '[:upper:]' '[:lower:]' | tr ' ' '-' | sed 's/[^
 
 ## Helper Functions
 
-Source helpers for consistent naming:
+Define these inline, in the Bash call that needs them, for consistent naming. `.devflow/docs/` lives at the checkout's toplevel, never under a subdirectory the session started in:
 
 ```bash
-source .devflow/scripts/docs-helpers.sh 2>/dev/null || {
-    get_timestamp() { date +%Y-%m-%d_%H%M; }
-    get_branch_slug() { git branch --show-current 2>/dev/null | sed 's/\//-/g' || echo "standalone"; }
-    get_topic_slug() { echo "$1" | tr '[:upper:]' '[:lower:]' | tr ' ' '-' | sed 's/[^a-z0-9-]//g' | cut -c1-50; }
-    ensure_docs_dir() { mkdir -p ".devflow/docs/$1"; }
-}
+get_timestamp() { date +%Y-%m-%d_%H%M; }
+get_branch_slug() { git branch --show-current 2>/dev/null | sed 's/\//-/g' || echo "standalone"; }
+get_topic_slug() { echo "$1" | tr '[:upper:]' '[:lower:]' | tr ' ' '-' | sed 's/[^a-z0-9-]//g' | cut -c1-50; }
+get_docs_root() { git rev-parse --show-toplevel 2>/dev/null || pwd; }
+ensure_docs_dir() { mkdir -p "$(get_docs_root)/.devflow/docs/$1"; }
 ```
 
 ---

package/src/assets/skills/docs-framework/references/patterns.md

@@ -150,12 +150,9 @@ Always lowercase:
 
 ## Helper Functions
 
-Full implementation for `.devflow/scripts/docs-helpers.sh`:
+Full implementations, defined inline in the Bash call that needs them. `.devflow/docs/` lives at the checkout's toplevel, never under a subdirectory the session started in:
 
 ```bash
-#!/bin/bash
-# .devflow/scripts/docs-helpers.sh
-
 # Get current timestamp in standard format
 get_timestamp() {
     date +%Y-%m-%d_%H%M
@@ -182,10 +179,15 @@ get_topic_slug() {
         cut -c1-50
 }
 
+# The checkout's toplevel, else the working directory outside git
+get_docs_root() {
+    git rev-parse --show-toplevel 2>/dev/null || pwd
+}
+
 # Ensure docs directory exists
 ensure_docs_dir() {
     local subdir="$1"
-    mkdir -p ".devflow/docs/$subdir"
+    mkdir -p "$(get_docs_root)/.devflow/docs/$subdir"
 }
 
 # Get full output path for a document
@@ -193,7 +195,7 @@ get_doc_path() {
     local subdir="$1"
     local filename="$2"
     ensure_docs_dir "$subdir"
-    echo ".devflow/docs/$subdir/$filename"
+    echo "$(get_docs_root)/.devflow/docs/$subdir/$filename"
 }
 
 # Create timestamped status log path
@@ -211,23 +213,14 @@ get_review_path() {
     branch_slug=$(get_branch_slug)
     timestamp=$(get_timestamp)
     ensure_docs_dir "reviews/$branch_slug/$timestamp"
-    echo ".devflow/docs/reviews/$branch_slug/$timestamp/${focus}.md"
+    echo "$(get_docs_root)/.devflow/docs/reviews/$branch_slug/$timestamp/${focus}.md"
 }
 ```
 
 ### Usage Example
 
 ```bash
-# Source helpers
-source .devflow/scripts/docs-helpers.sh 2>/dev/null || {
-    # Inline fallback if script not found
-    get_timestamp() { date +%Y-%m-%d_%H%M; }
-    get_branch_slug() { git branch --show-current 2>/dev/null | sed 's/\//-/g' || echo "standalone"; }
-    get_topic_slug() { echo "$1" | tr '[:upper:]' '[:lower:]' | tr ' ' '-' | sed 's/[^a-z0-9-]//g' | cut -c1-50; }
-    ensure_docs_dir() { mkdir -p ".devflow/docs/$1"; }
-}
-
-# Use helpers
+# Define the helpers above in the same Bash call, then use them
 TIMESTAMP=$(get_timestamp)
 BRANCH_SLUG=$(get_branch_slug)
 ensure_docs_dir "reviews/$BRANCH_SLUG"

package/src/assets/skills/gap-analysis/SKILL.md

@@ -103,9 +103,9 @@ Detect ordering constraints and shared resource conflicts across issues.
 
 **Evidence trigger:** Any issue that references state, contracts, or resources that may be in flux due to another issue in the batch.
 
-### 7. Compliance (when compliance skill installed)
+### 7. Compliance (when the compliance lens is on)
 
-Detect regulatory gaps that security doesn't cover. Active frameworks = the `references/{id}.md` files present in the installed skill. Load `devflow:compliance` before analyzing.
+Detect regulatory gaps that security doesn't cover. Load `devflow:compliance` before analyzing, then `references/{id}.md` only for the ids in `COMPLIANCE_FRAMEWORKS` (`none`: generic controls only).
 
 **Detection patterns:**
 - Missing audit trails on regulated mutations — writes to financial records, PHI, PCI-scoped data without durable logging

package/src/assets/skills/git/references/github-api.md

@@ -164,7 +164,7 @@ REPO=$(echo "$REPO_INFO" | cut -d'/' -f2)
 HEAD_SHA=$(gh pr view "$PR_NUMBER" --json headRefOid -q '.headRefOid')
 
 printf '%s\n' "$COMMENT_BODY" > "$DEVFLOW_BODY_RAW" \
-  && node "${DEVFLOW_DIR:-$HOME/.devflow}/scripts/redact-secrets.cjs" \
+  && node "$HOME/.devflow/scripts/redact-secrets.cjs" \
     "$DEVFLOW_BODY_RAW" "$DEVFLOW_BODY" \
   && gh api \
     -X POST \
@@ -224,7 +224,7 @@ fi
 git tag -a "v${VERSION}" -m "Version ${VERSION}" && git push origin "v${VERSION}"
 
 printf '%s\n' "$NOTES" > "$DEVFLOW_NOTES_RAW" \
-  && node "${DEVFLOW_DIR:-$HOME/.devflow}/scripts/redact-secrets.cjs" \
+  && node "$HOME/.devflow/scripts/redact-secrets.cjs" \
     "$DEVFLOW_NOTES_RAW" "$DEVFLOW_NOTES" \
   && gh release create "v${VERSION}" --title "v${VERSION}" --notes-file "$DEVFLOW_NOTES"
 ```
@@ -265,7 +265,7 @@ ${changelog}"
     # The composed notes are written to the RAW file here — the scrub is what produces
     # "$DEVFLOW_NOTES", so chaining with && is what stops a scrubber failure publishing.
     printf '%s\n' "$changelog" > "$DEVFLOW_NOTES_RAW" \
-      && node "${DEVFLOW_DIR:-$HOME/.devflow}/scripts/redact-secrets.cjs" \
+      && node "$HOME/.devflow/scripts/redact-secrets.cjs" \
         "$DEVFLOW_NOTES_RAW" "$DEVFLOW_NOTES" \
       && gh release create "v${version}" \
         --title "v${version}" \
@@ -278,7 +278,7 @@ ${changelog}"
 ```bash
 # CHANGELOG.md is the RAW input here: redact-secrets.cjs takes any input path, and
 # release notes publish like any other body, so the file that ships is the scrubbed one.
-node "${DEVFLOW_DIR:-$HOME/.devflow}/scripts/redact-secrets.cjs" \
+node "$HOME/.devflow/scripts/redact-secrets.cjs" \
     CHANGELOG.md "$DEVFLOW_NOTES" \
   && gh release create "v${VERSION}" \
     --title "v${VERSION} - ${RELEASE_TITLE}" \
@@ -320,7 +320,7 @@ generate_release_notes() {
 - [ ] Test login with valid credentials
 - [ ] Test token expiration
 EOF
-} && node "${DEVFLOW_DIR:-$HOME/.devflow}/scripts/redact-secrets.cjs" \
+} && node "$HOME/.devflow/scripts/redact-secrets.cjs" \
     "$DEVFLOW_BODY_RAW" "$DEVFLOW_BODY" \
   && gh pr create --title "Add user authentication" --body-file "$DEVFLOW_BODY"
 ```
@@ -332,7 +332,7 @@ write must stop the post, not hand the scrubber whatever the RAW file last held.
 
 ```bash
 printf '%s\n' "Work in progress, not ready for review" > "$DEVFLOW_BODY_RAW" \
-  && node "${DEVFLOW_DIR:-$HOME/.devflow}/scripts/redact-secrets.cjs" \
+  && node "$HOME/.devflow/scripts/redact-secrets.cjs" \
     "$DEVFLOW_BODY_RAW" "$DEVFLOW_BODY" \
   && gh pr create --draft --title "WIP: Feature X" --body-file "$DEVFLOW_BODY"
 ```
@@ -344,7 +344,7 @@ link of its own chain — `$DEVFLOW_BODY` is the scrubber's output, not a shared
 
 ```bash
 printf '%s\n' "LGTM! Tested locally and all checks pass." > "$DEVFLOW_BODY_RAW" \
-  && node "${DEVFLOW_DIR:-$HOME/.devflow}/scripts/redact-secrets.cjs" \
+  && node "$HOME/.devflow/scripts/redact-secrets.cjs" \
     "$DEVFLOW_BODY_RAW" "$DEVFLOW_BODY" \
   && gh pr review "$PR_NUMBER" --approve --body-file "$DEVFLOW_BODY"
 
@@ -353,7 +353,7 @@ printf '%s\n' "LGTM! Tested locally and all checks pass." > "$DEVFLOW_BODY_RAW"
 1. **Security**: Input validation missing in `handleLogin`
 2. **Performance**: N+1 query in user list endpoint
 EOF
-} && node "${DEVFLOW_DIR:-$HOME/.devflow}/scripts/redact-secrets.cjs" \
+} && node "$HOME/.devflow/scripts/redact-secrets.cjs" \
     "$DEVFLOW_BODY_RAW" "$DEVFLOW_BODY" \
   && gh pr review "$PR_NUMBER" --request-changes --body-file "$DEVFLOW_BODY"
 ```
@@ -659,7 +659,7 @@ fetch_review_threads() {
 
 ```bash
 printf '%s\n' "$REPLY_BODY" > "$DEVFLOW_BODY_RAW" \
-  && node "${DEVFLOW_DIR:-$HOME/.devflow}/scripts/redact-secrets.cjs" \
+  && node "$HOME/.devflow/scripts/redact-secrets.cjs" \
     "$DEVFLOW_BODY_RAW" "$DEVFLOW_BODY" \
   && gh api graphql -f query='
   mutation($threadId: ID!, $body: String!) {

package/src/assets/skills/git/references/patterns.md

@@ -252,7 +252,7 @@ Implements JWT-based authentication...
 
 [Full description content]
 EOF
-} && node "${DEVFLOW_DIR:-$HOME/.devflow}/scripts/redact-secrets.cjs" \
+} && node "$HOME/.devflow/scripts/redact-secrets.cjs" \
     "$DEVFLOW_BODY_RAW" "$DEVFLOW_BODY" \
   && gh pr create \
     --base main \

package/src/assets/skills/worktree-support/SKILL.md

@@ -49,7 +49,7 @@ Extract: `worktree {path}`, `HEAD {sha}`, `branch refs/heads/{name}`
 
 Exclude:
 - **Bare worktrees** (no branch)
-- **Detached HEAD** (no named branch)
+- **Detached HEAD** (no named branch; roots and detached HEAD: `references/roots.md`)
 - **Protected branches**: `main`, `master`, `develop`, `integration`, `trunk`, `release/*`, `staging`, `production`
 - **Mid-rebase or mid-merge**: check `git -C {path} status` for "rebase in progress" or "merging"
 

package/src/assets/skills/worktree-support/references/roots.md

@@ -0,0 +1,29 @@
+# Project Roots and Detached HEAD
+
+Where devflow keeps per-project data across checkouts, and what it does on a detached HEAD. Companion to the worktree discovery algorithm in `SKILL.md`.
+
+## Which Root Holds What
+
+Devflow's per-project data does not all live in the same checkout.
+
+| Data | Root | Why |
+|------|------|-----|
+| Learning ledger and queue (`.devflow/learning/`) | The main worktree, when its `.devflow/` exists and the main worktree is not HOME; else this checkout's toplevel | One ledger per repository, so ADR/PF numbers never restart or collide in a linked worktree (D-LEDGER-MAIN-WORKTREE) |
+| Working memory (`.devflow/memory/`) | This checkout's toplevel | Memory describes the branch in front of you |
+| Feature knowledge bases (`.devflow/features/`) | This checkout's toplevel | They are committed per branch (D-PROMPT-ROOT) |
+| Personal `.devflow/config.json` | This checkout's toplevel | Per-worktree by decision: a new worktree does not inherit the source checkout's personal settings |
+
+Hooks, loaders, the `devflow learning` CLI and the HUD resolve the root from git, never from cwd, so a session started in a subdirectory uses the repository root. Outside a git repository, and in a repository rooted at HOME, no hook creates `.devflow/` or a `.gitignore` (D-HOOKS-GIT-ONLY). A worktree that grew its own ledger before the main-worktree rule keeps it on disk; sessions there stop appending to it.
+
+---
+
+## Detached HEAD
+
+A detached HEAD is a commit checked out without a branch (`git checkout <sha>`, `git bisect`, a rebase stop, `git worktree add --detach`, a CI checkout). Devflow treats it as follows (D-DETACHED-HEAD):
+
+| Surface | Behaviour |
+|---------|-----------|
+| Knowledge commit | Skipped: a commit there becomes unreachable once HEAD moves. The Knowledge agent reports `KB_COMMIT: skipped (detached HEAD) — uncommitted: <paths>`, and the calling workflow names those paths to the user |
+| Worktree discovery | Excluded from auto-review (discovery Step 3 in `SKILL.md`): there is no branch to review, compare or push |
+| Memory bootstrap | The first compaction bootstraps `WORKING-MEMORY.md` stamped `branch: (detached)`, keyed on the HEAD commit; an unborn branch has no commit and still skips |
+| Memory header | Renders `detached @ <short-sha>` instead of `on unknown` |

package/src/targets/claude-code/templates/managed-settings.json

@@ -24,15 +24,16 @@
       "Bash(> /dev/nvme*)",
       "Bash(sh -c *)",
       "Bash(bash -c *)",
-      "Bash(curl * | bash*)",
-      "Bash(curl * | sh*)",
-      "Bash(wget * | bash*)",
-      "Bash(wget * | sh*)",
-      "Bash(fetch | sh*)",
-      "Bash(lynx -source | bash*)",
-      "Bash(base64 -d | bash*)",
-      "Bash(base64 -d | sh*)",
-      "Bash(base64 --decode | bash*)",
+      "Bash(zsh -c *)",
+      "Bash(bash)",
+      "Bash(sh)",
+      "Bash(zsh)",
+      "Bash(bash - *)",
+      "Bash(sh - *)",
+      "Bash(zsh - *)",
+      "Bash(bash -s *)",
+      "Bash(sh -s *)",
+      "Bash(zsh -s *)",
       "Bash(eval *)",
       "Bash(exec *)",
       "Bash(sudo *)",
@@ -90,6 +91,21 @@
       "Bash(docker run -v /:/host*)",
       "Bash(docker run --pid=host*)",
       "Bash(docker run --net=host*)",
+      "Bash(docker run*--privileged*)",
+      "Bash(docker run*-v /:*)",
+      "Bash(docker run*--volume /:*)",
+      "Bash(docker run*--volume=/:*)",
+      "Bash(docker pull *)",
+      "Bash(docker image pull *)",
+      "Bash(docker rm *)",
+      "Bash(docker container rm *)",
+      "Bash(docker rmi *)",
+      "Bash(docker image rm *)",
+      "Bash(docker volume rm *)",
+      "Bash(docker*prune*)",
+      "Bash(orb *)",
+      "Bash(orbctl *)",
+      "Bash(open *OrbStack*)",
       "Bash(nsenter*)",
       "Bash(crontab*)",
       "Bash(rm /var/log*)",