devflow-kit 2.4.0 → 3.0.0

package/dist/cli/commands/init-seed.js

@@ -3,7 +3,6 @@
  *
  * Computes the initial state (seed) for init prompts from:
  * - The existing manifest (from a prior install)
- * - The project feature config (.devflow/config.json)
  * - The current settings.json snapshot (for view-mode resolution)
  * - The plugin registry
  *
@@ -15,6 +14,7 @@
  */
 import { resolveExistingViewMode, settingHoldsManagedShape, FLAG_REGISTRY, defaultValueOf, readViewMode, } from '../../core/flags.js';
 import { partitionSelectablePlugins } from '../../core/plugins.js';
+import { DEFAULT_TRACKER_PROVIDER } from '../../core/tracker.js';
 /** Registry defaults — all features enabled except proxy (advanced-only, off by default). */
 export const FEATURE_DEFAULTS = {
     ambient: true,
@@ -25,24 +25,21 @@ export const FEATURE_DEFAULTS = {
     rules: true,
     proxy: false,
     compliance: { enabled: false, frameworks: [] },
+    tracker: { provider: DEFAULT_TRACKER_PROVIDER },
 };
 // ── Helpers ───────────────────────────────────────────────────────────────────
 /**
- * Resolve feature booleans for the init seed.
+ * Resolve feature booleans for the init seed: every feature comes from
+ * manifest.features, with registry defaults when the manifest is absent.
  *
- * - memory / learning / knowledge come from projectConfig WHENEVER present,
- *   independent of whether a manifest exists (covers config-present /
- *   manifest-missing cases such as a fresh project with a prior learning run).
- * - ambient / hud / rules come from manifest.features; registry defaults
- *   (all true) are used when the manifest is absent.
- *
- * Applies ADR-001: .devflow/config.json is the source of truth for
- * memory/learning/knowledge; manifest reflects the last install choices for
- * the remaining toggles.
+ * D-FEATURES-NARROW-ONLY (src/core/feature-switch.ts): the machine switches for
+ * memory, learning and knowledge are recorded in the manifest alone (a repository
+ * only narrows them at read time), so the seed takes no per-repo input at all. Seeding from whatever repo init happens to run in
+ * would flip the switch for EVERY repo as a side effect — a stale per-repo
+ * `true` would silently re-enable a feature the user turned off. ADR-014's
+ * state-aware re-init preserves the prior machine-wide choice, the manifest's.
  */
-export function resolveSeedFeatures(manifest, projectConfig) {
-    // ambient/hud/rules/proxy/compliance: manifest is the source; fall back to registry defaults.
-    // proxy and compliance follow the manifest group (like ambient) per ADR-001 — NOT config.json-gated.
+export function resolveSeedFeatures(manifest) {
     const ambient = manifest?.features.ambient ?? FEATURE_DEFAULTS.ambient;
     const hud = manifest?.features.hud ?? FEATURE_DEFAULTS.hud;
     const rules = manifest?.features.rules ?? FEATURE_DEFAULTS.rules;
@@ -52,15 +49,15 @@ export function resolveSeedFeatures(manifest, projectConfig) {
     // the module-level default by reference — downstream mutation would corrupt it process-wide.
     const rawCompliance = manifest?.features.compliance ?? FEATURE_DEFAULTS.compliance;
     const compliance = { ...rawCompliance, frameworks: [...rawCompliance.frameworks] };
-    // memory/learning/knowledge: projectConfig wins whenever present (ADR-001).
-    // Helper eliminates the repeated projectConfig !== null ternary pattern.
-    const fromConfig = (key) => projectConfig !== null
-        ? projectConfig[key]
-        : (manifest?.features[key] ?? FEATURE_DEFAULTS[key]);
-    const memory = fromConfig('memory');
-    const knowledge = fromConfig('knowledge');
-    const learning = fromConfig('learning');
-    return { ambient, memory, hud, knowledge, learning, rules, proxy, compliance };
+    // Same defensive spread, same reason: `?? FEATURE_DEFAULTS.tracker` alone would
+    // return the module-level default BY REFERENCE and downstream mutation would
+    // corrupt it process-wide.
+    const rawTracker = manifest?.features.tracker ?? FEATURE_DEFAULTS.tracker;
+    const tracker = { ...rawTracker };
+    const memory = manifest?.features.memory ?? FEATURE_DEFAULTS.memory;
+    const knowledge = manifest?.features.knowledge ?? FEATURE_DEFAULTS.knowledge;
+    const learning = manifest?.features.learning ?? FEATURE_DEFAULTS.learning;
+    return { ambient, memory, hud, knowledge, learning, rules, proxy, compliance, tracker };
 }
 /**
  * Resolve the flag record for the init seed.
@@ -119,7 +116,7 @@ export function resolveSeedFlags(manifestFlags, registry = FLAG_REGISTRY) {
  *   - Otherwise → split + adopt newly-added non-optional selectable plugins
  *     whose name is ∉ knownPlugins and ∉ manifestPlugins
  *
- * Always-installed plugins (devflow-core-skills, devflow-ambient) are filtered
+ * The plugins init adds itself (devflow-core-skills, devflow-ambient) are filtered
  * out by partitionSelectablePlugins and never appear in the returned buckets.
  */
 export function resolveSeedPlugins(manifestPlugins, knownPlugins, allPlugins) {
@@ -160,6 +157,42 @@ export function resolveSeedPlugins(manifestPlugins, knownPlugins, allPlugins) {
     }
     return { workflowPlugins, languagePlugins };
 }
+/**
+ * The plugins an init run installs, from the selection and the ambient switch.
+ *
+ * `selectedPlugins` is empty when nothing picked a selection (a fresh
+ * non-interactive install), and then every non-optional plugin is installed.
+ * `devflow-core-skills` is always added; `devflow-ambient` is added exactly
+ * when ambient mode is on.
+ *
+ * D-AMBIENT-FOLLOWS-SWITCH: `devflow-ambient` is installed iff ambient mode is
+ * on, on EVERY path. It is not a selectable plugin (`EXCLUDED` keeps it out of
+ * both multiselect buckets and out of the re-init seed, see
+ * {@link resolveSeedPlugins}); since #150 the ambient switch is what includes
+ * it, and #150's own test plan reads "`init --no-ambient` — confirm ambient
+ * plugin NOT installed". The fresh default branch used to take every
+ * non-optional plugin, ambient included, so a first `init --no-ambient`
+ * recorded `devflow-ambient` in the manifest and the re-init — seeded without
+ * it — dropped it: the first install was the wrong one, not the re-init
+ * (#388 AC-3). The default branch therefore leaves ambient out and lets the
+ * switch below add it, exactly as it does for an explicit selection.
+ *
+ * Pure function — no I/O; returns a new array, never mutates its inputs.
+ */
+export function resolvePluginsToInstall(selectedPlugins, ambientEnabled, allPlugins) {
+    let pluginsToInstall = selectedPlugins.length > 0
+        ? allPlugins.filter(p => selectedPlugins.includes(p.name))
+        : allPlugins.filter(p => !p.optional && p.name !== 'devflow-ambient');
+    const coreSkillsPlugin = allPlugins.find(p => p.name === 'devflow-core-skills');
+    if (pluginsToInstall.length > 0 && coreSkillsPlugin && !pluginsToInstall.includes(coreSkillsPlugin)) {
+        pluginsToInstall = [coreSkillsPlugin, ...pluginsToInstall];
+    }
+    const ambientPlugin = allPlugins.find(p => p.name === 'devflow-ambient');
+    if (ambientEnabled && ambientPlugin && !pluginsToInstall.includes(ambientPlugin)) {
+        pluginsToInstall = [...pluginsToInstall, ambientPlugin];
+    }
+    return pluginsToInstall;
+}
 /**
  * Extract the attribution suppression state from a settings JSON string.
  *
@@ -184,7 +217,7 @@ export function resolveExistingAttributionSuppression(settingsJson) {
     return settingHoldsManagedShape(settingsJson, 'suppress-attribution') ? true : undefined;
 }
 /**
- * Compose the full init seed from manifest, project config, settings, and registry.
+ * Compose the full init seed from manifest, settings, and registry.
  *
  * view-mode priority: existing settings.json (non-default) → manifest → 'default'.
  * suppress-attribution priority: settings.json exact devflow shape → manifest → false.
@@ -194,8 +227,8 @@ export function resolveExistingAttributionSuppression(settingsJson) {
  * This is the single composition point; callers (init.ts hoist block) call this
  * once and pass `seed` down to prompt wiring.
  */
-export function resolveInitSeed(seedManifest, seedConfig, settingsSnapshot, plugins) {
-    const features = resolveSeedFeatures(seedManifest, seedConfig);
+export function resolveInitSeed(seedManifest, settingsSnapshot, plugins) {
+    const features = resolveSeedFeatures(seedManifest);
     // features.flags is FlagsRecord; null for fresh install (no manifest).
     // seedManifest?.features.flags may be absent at runtime on very old manifests not yet
     // healed — ?? null collapses to fresh-install behavior (all flags at registry defaults).
@@ -280,6 +313,7 @@ export function applyCliToggles(base, toggles) {
         rules: toggles.rules ?? base.rules,
         proxy: toggles.proxy ?? base.proxy,
         compliance: toggles.compliance ?? base.compliance,
+        tracker: toggles.tracker ?? base.tracker,
     };
 }
 //# sourceMappingURL=init-seed.js.map