devflow-kit 2.0.1 → 2.1.0

package/CHANGELOG.md

@@ -5,6 +5,27 @@ All notable changes to Devflow will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.1.0] - 2026-08-25
+
+### Added
+- **Typed flag registry**: the flag surface is now a discriminated-union registry of 28 Claude Code flags — `boolean`, `enum`, `number`, and `string` kinds with per-flag validation, defaults, and display metadata. Eight new upstream-verified flags including `max-concurrent-subagents` (devflow default 40; upstream 20), `subagent-spawn-depth`, `workflow-size-guideline`, `goal-checkin-minutes`, `default-model`, `spellcheck`, and `enable-todo-tools`.
+- **Flags editor TUI**: bare `devflow flags` on a TTY opens a full-keyboard settings-page editor rendering inline in the scroll buffer (no alt-screen), with effective-value display and per-flag hint blurbs. The agents view now runs on the same generic TUI shell.
+- **Typed flags CLI**: `devflow flags --list/--status/--enable/--disable/--set/--unset` with input validation; `--enable/--disable` are boolean-only — non-boolean flags route through `--set`.
+
+### Changed
+- **Init seeding**: both init paths apply seeded flag values non-interactively — fresh installs get registry defaults; re-inits preserve existing values and adopt defaults only for newly added flags. The flags editor step was removed from the Advanced wizard.
+- **`viewMode` folded into the registry** as the `view-mode` enum flag (`default|verbose|focus`); the `viewMode` settings key is written only when non-default. Old `flags: string[]` manifests heal in-reader on first read — no migration entry needed.
+
+### Fixed
+- **viewMode silently lost on re-init**: `resolveExistingViewMode` now runs before `stripFlags` in the settings apply block; the prior order stripped `viewMode` from settings before reading it (PF-015).
+- **Published bin not executable**: `prepublishOnly` now sets the execute bit on `dist/cli.js` — the bin shipped as 0644, breaking npm 6 and constrained environments (Docker non-root users, some CI runners) that do not auto-chmod on install.
+
+### Breaking Changes
+- **Bare `devflow flags` on non-TTY** now prints a status table and exits 1 (was: usage line, exit 0). Scripts should call `devflow flags --status`.
+- **Seven settings.json/env keys become Devflow-managed**: `ANTHROPIC_DEFAULT_MODEL`, `CLAUDE_CODE_MAX_CONCURRENT_SUBAGENTS`, `CLAUDE_CODE_MAX_SUBAGENT_SPAWN_DEPTH`, `CLAUDE_CODE_GOAL_CHECKIN_MINUTES`, `CLAUDE_CODE_ENABLE_TODO_TOOLS` (env); `workflowSizeGuideline`, `spellcheck` (settings). Hand-set values are preserved — adopted into the manifest on the next `devflow init` or flags mutation; `max-concurrent-subagents` adopts the devflow default of 40 only when the key is absent. All keys are removed on `devflow uninstall`.
+
+---
+
 ## [2.0.1] - 2026-08-23
 
 ### Changed
@@ -1163,6 +1184,7 @@ devflow init
 ---
 
 [Unreleased]: https://github.com/dean0x/devflow/compare/v2.0.0...HEAD
+[2.1.0]: https://github.com/dean0x/devflow/compare/v2.0.1...v2.1.0
 [2.0.1]: https://github.com/dean0x/devflow/compare/v2.0.0...v2.0.1
 [2.0.0]: https://github.com/dean0x/devflow/compare/v1.8.3...v2.0.0
 [1.8.3]: https://github.com/dean0x/devflow/compare/v1.8.2...v1.8.3

package/dist/cli/agents-view/render.js

@@ -22,7 +22,8 @@
  *   EFFORT  : 13
  *   STATE   : 14
  */
-import { bold, dim, green, yellow, cyan, gray, truncate, stripAnsi, } from '../../hud/colors.js';
+import { bold, dim, green, yellow, cyan, gray, stripAnsi, } from '../../core/ansi.js';
+import { padToVisible, truncateVisible, sanitizeCell } from '../tui/cells.js';
 import { isDirtyModel, isDirtyEffort, unsavedCount, isOffCycle, rowState, } from './state.js';
 import { AGENT_STATE_LABELS } from '../../core/agent-state.js';
 // ---------------------------------------------------------------------------
@@ -43,7 +44,7 @@ const COL_MODEL = 32;
 const COL_EFFORT = 13;
 const COL_STATE = 14;
 // ---------------------------------------------------------------------------
-// Name formatter — TUI only (Fix 4)
+// Name formatter — TUI only
 // ---------------------------------------------------------------------------
 /**
  * Title-case each hyphen-separated segment of the agent name for TUI display.
@@ -63,49 +64,13 @@ export function formatAgentName(name) {
         .map(seg => (seg.length === 0 ? seg : seg[0].toUpperCase() + seg.slice(1)))
         .join('-');
 }
-// ---------------------------------------------------------------------------
-// Cell renderers (pure, return styled string)
-// ---------------------------------------------------------------------------
-function padToVisible(s, width) {
-    // Pad by visible length (strip ANSI, then pad with spaces).
-    const visible = stripAnsi(s);
-    const padding = Math.max(0, width - visible.length);
-    return s + ' '.repeat(padding);
-}
-function truncateVisible(s, maxWidth) {
-    const raw = stripAnsi(s);
-    if (raw.length <= maxWidth)
-        return s;
-    // Re-truncate the unstyled version and rebuild — simpler than ANSI-aware slice.
-    return truncate(raw, maxWidth);
-}
-/** Layout-breaking whitespace that stripAnsi deliberately preserves. */
-const LAYOUT_BREAKING_WS = /[\t\n]/g;
-/**
- * Sanitize an untrusted string for a fixed-width TUI cell.
- *
- * stripAnsi strips escape sequences and C0 controls but, by contract, KEEPS
- * TAB (\x09) and LF (\x0a) — correct for its own callers, wrong for a cell in
- * a fixed-width frame. Orphan row names are arbitrary JSON keys read from
- * agent-models.json, so neither is hypothetical:
- *   - LF  emits a newline inside a frame line, breaking renderFrame's
- *     one-string-per-terminal-line contract and desyncing terminal.ts's
- *     cursor arithmetic (it writes ERASE_EOL + '\n' per returned line).
- *   - TAB measures as one character in padToVisible but occupies up to eight
- *     terminal columns, so every column to its right is misaligned.
- * Both collapse to a single space; the raw key is untouched, so the save-path
- * merge still targets the real mapping key.
- */
-function sanitizeCell(s) {
-    return stripAnsi(s).replace(LAYOUT_BREAKING_WS, ' ');
-}
 /**
  * Render the model cell for a given row, considering cursor/active/dirty state.
  *
- * Three branches (Fix 1 — alias annotation removed):
+ * Three branches:
  *   1. configuredModel === 'default' → "default (shippedDefault)" [+ dormant hint]
  *   2. off-cycle pin → "model (unavailable)"
- *   3. in-cycle model → bare name (aliases already rendered as picker names by buildRow)
+ *   3. in-cycle model → bare name (aliases stored as picker names by buildRow)
  *
  * Off-cycle pin (AC-F4): when configuredModel is absent from modelCycle
  * (retired/unavailable model), show "model (unavailable)".
@@ -208,7 +173,9 @@ function renderStateCell(row, proxyEnabled, maxWidth) {
  */
 export function renderFrame(state, dims) {
     const { rows, cursor, activeField, viewportOffset, proxyEnabled, modelCycle, } = state;
-    const viewportHeight = Math.max(MIN_VIEWPORT, dims.rows - FIXED_ROWS);
+    // state.viewportHeight is the single owner — clamped to a MIN so tests that
+    // set viewportHeight explicitly render exactly that many data rows.
+    const viewportHeight = Math.max(MIN_VIEWPORT, state.viewportHeight);
     // Column widths — shrink gracefully at narrow terminals.
     const totalContent = 2 + COL_AGENT + COL_MODEL + COL_EFFORT + COL_STATE; // prefix + 4 cols
     const scale = Math.min(1, dims.cols / Math.max(totalContent, 1));
@@ -253,7 +220,7 @@ export function renderFrame(state, dims) {
         // Sanitize the name — mandatory for orphan rows (arbitrary JSON keys from
         // agent-models.json may contain escape sequences, newlines or tabs injected
         // by a hostile file).
-        // Exactly ONE call site for formatAgentName (Fix 4): TUI only; --list is lowercase.
+        // formatAgentName is TUI-only; --list uses the raw lowercase name.
         const safeName = formatAgentName(sanitizeCell(row.name));
         const nameCell = padToVisible(isCursor ? bold(truncateVisible(safeName, agentW)) : truncateVisible(safeName, agentW), agentW);
         const modelCell = padToVisible(renderModelCell({

package/dist/cli/agents-view/terminal.js

@@ -1,74 +1,24 @@
 /**
- * Thin impure shell for the devflow agents TUI.
+ * Thin adapter — devflow agents TUI shell over the generic runTui driver.
  *
  * applies ADR-013: impure I/O shell in CLI layer; pure logic lives in state.ts/render.ts.
  * avoids PF-014: all cleanup wired via Promise resolve — never process.exit() inside
  *   a finally-guarded scope. Cleanup is idempotent and runs on save, cancel,
  *   SIGINT, SIGTERM, and keypress limit exhaustion.
+ * avoids PF-017: this is the thin adapter, not a copy of the generic shell.
  *
- * Bounded: MAX_KEYPRESSES = 50_000 hard limit (reliability rule — every loop bounded).
+ * Public API (frozen — agents-terminal.test.ts is the acceptance gate):
+ *   - runAgentsTui(initialState, io?) → Promise<TuiResult>
+ *   - MAX_KEYPRESSES (re-exported from shared shell)
+ *   - TuiIO (re-exported from shared shell)
+ *   - TuiResult
  *
- * Returns a Promise resolving to { action: 'save'|'cancel', state } on any
- * terminal event that terminates the TUI.
+ * Bounded: MAX_KEYPRESSES = 50_000 hard limit (re-exported from src/cli/tui/terminal.ts).
  */
-import * as readline from 'readline';
 import { reduce } from './state.js';
 import { renderFrame, computeViewportHeight } from './render.js';
-// ---------------------------------------------------------------------------
-// Constants
-// ---------------------------------------------------------------------------
-/** Hard upper bound on keypress events — resolves with 'cancel' on exhaustion. */
-export const MAX_KEYPRESSES = 50_000;
-// ---------------------------------------------------------------------------
-// Terminal escape sequences
-// ---------------------------------------------------------------------------
-const ESC = '\x1b';
-const ENTER_ALT = `${ESC}[?1049h`;
-const LEAVE_ALT = `${ESC}[?1049l`;
-const HIDE_CURSOR = `${ESC}[?25l`;
-const SHOW_CURSOR = `${ESC}[?25h`;
-/** Move cursor to top-left without clearing (less flicker than full clear). */
-const HOME = `${ESC}[H`;
-/** Erase from cursor to end of line. */
-const ERASE_EOL = `${ESC}[K`;
-function normalizeKey(str, key) {
-    if (key?.ctrl && key.name === 'c')
-        return 'ctrl-c';
-    const name = key?.name ?? '';
-    switch (name) {
-        case 'up': return 'up';
-        case 'down': return 'down';
-        case 'left': return 'left';
-        case 'right': return 'right';
-        case 'tab': return 'tab';
-        case 'return': return 'enter';
-        case 'escape': return 'escape';
-        case 'space': return 'space';
-        default:
-            return str ?? name;
-    }
-}
-// ---------------------------------------------------------------------------
-// Dims / viewport
-// ---------------------------------------------------------------------------
-function getDims(stdout) {
-    return {
-        rows: stdout.rows ?? 24,
-        cols: stdout.columns ?? 80,
-    };
-}
-// ---------------------------------------------------------------------------
-// Redraw
-// ---------------------------------------------------------------------------
-function redraw(state, stdout) {
-    const dims = getDims(stdout);
-    const lines = renderFrame(state, dims);
-    let out = HOME;
-    for (const line of lines) {
-        out += line + ERASE_EOL + '\n';
-    }
-    stdout.write(out);
-}
+import { runTui } from '../tui/terminal.js';
+export { MAX_KEYPRESSES } from '../tui/terminal.js';
 // ---------------------------------------------------------------------------
 // runAgentsTui
 // ---------------------------------------------------------------------------
@@ -81,99 +31,25 @@ function redraw(state, stdout) {
  * @returns Promise resolving to { action, state } when the user saves or cancels.
  */
 export async function runAgentsTui(initialState, io) {
-    // D-SEAM: default to process.stdin/stdout; callers (tests) may inject fakes.
-    const stdin = (io?.stdin ?? process.stdin);
-    const stdout = (io?.stdout ?? process.stdout);
-    // ── Enable readline keypress events ─────────────────────────────────────
-    // TuiIO.stdin is NodeJS.ReadableStream, which readline.emitKeypressEvents expects
-    // directly. PassThrough (tests) and process.stdin (production) both satisfy it.
-    readline.emitKeypressEvents(stdin);
-    // ── Enter alt-screen, hide cursor ───────────────────────────────────────
-    stdout.write(ENTER_ALT + HIDE_CURSOR);
-    // ── Raw mode ─────────────────────────────────────────────────────────────
-    if (stdin.isTTY && typeof stdin.setRawMode === 'function') {
-        stdin.setRawMode(true);
-    }
-    stdin.resume();
-    return new Promise((resolve) => {
-        let state = initialState;
-        let cleaned = false;
-        let keypressCount = 0;
-        // Initial viewport size
-        const dims = getDims(stdout);
-        state = { ...state, viewportHeight: computeViewportHeight(dims.rows) };
-        redraw(state, stdout);
-        // ── Cleanup (idempotent) ───────────────────────────────────────────────
-        function cleanup() {
-            if (cleaned)
-                return;
-            cleaned = true;
-            stdin.removeListener('keypress', onKeypress);
-            process.removeListener('SIGINT', onSigint);
-            process.removeListener('SIGTERM', onSigterm);
-            stdout.removeListener('resize', onResize);
-            if (stdin.isTTY && typeof stdin.setRawMode === 'function') {
-                try {
-                    stdin.setRawMode(false);
-                }
-                catch { /* ignore */ }
-            }
-            // Pause stdin to release the ref'd TTY handle — mirrors the stdin.resume()
-            // at startup. Without this the resumed stdin keeps the event loop alive and
-            // the CLI (which has no forced process.exit) hangs after the TUI resolves.
-            stdin.pause();
-            stdout.write(LEAVE_ALT + SHOW_CURSOR);
-        }
-        function settle(result) {
-            cleanup();
-            resolve(result);
-        }
-        // ── Resize handler ─────────────────────────────────────────────────────
-        function onResize() {
-            const d = getDims(stdout);
-            state = { ...state, viewportHeight: computeViewportHeight(d.rows) };
-            redraw(state, stdout);
-        }
-        // ── Keypress handler ───────────────────────────────────────────────────
-        function onKeypress(str, key) {
-            keypressCount++;
-            if (keypressCount > MAX_KEYPRESSES) {
-                // Hard safety bound — cancel on exhaustion (avoids unbounded event loop)
-                settle({ action: 'cancel', state });
-                return;
-            }
-            const normalized = normalizeKey(str, key);
-            const { state: next, intent } = reduce(state, normalized);
-            state = next;
-            switch (intent) {
-                case 'save':
-                    settle({ action: 'save', state });
-                    return;
-                case 'cancel':
-                    settle({ action: 'cancel', state });
-                    return;
-                case 'none':
-                    redraw(state, stdout);
-                    return;
-                default: {
-                    const _ = intent;
-                    void _;
-                    redraw(state, stdout);
-                }
-            }
-        }
-        // ── Signal handlers ────────────────────────────────────────────────────
-        function onSigint() {
-            settle({ action: 'cancel', state });
-        }
-        function onSigterm() {
-            settle({ action: 'cancel', state });
-        }
-        // Register all listeners
-        stdin.on('keypress', onKeypress);
-        process.on('SIGINT', onSigint);
-        process.on('SIGTERM', onSigterm);
-        stdout.on('resize', onResize);
+    // C='none' makes runTui return Promise<{ intent: Exclude<Intent,'none'>; state }>.
+    // Exclude<Intent,'none'> = 'save' | 'cancel', which matches TuiResult.action exactly —
+    // no casts needed, and adding a new Intent member is a compile error here
+    // (exhaustiveness enforced at the type level).
+    const result = await runTui({
+        initialState,
+        reduce,
+        renderFrame,
+        onResize: (state, dims) => ({
+            ...state,
+            viewportHeight: computeViewportHeight(dims.rows),
+        }),
+        signalAction: 'cancel',
+        continueIntent: 'none',
+        io,
     });
+    return {
+        action: result.intent,
+        state: result.state,
+    };
 }
 //# sourceMappingURL=terminal.js.map

package/dist/cli/commands/agents.js

@@ -563,7 +563,17 @@ export const agentsCommand = new Command('agents')
     const tuiState = await buildTuiState(agentNames, mapping, shippedDefaults, proxyEnabled, catalog, installDir);
     // Lazy-import terminal to avoid loading readline/tty in non-TTY paths
     const { runAgentsTui } = await import('../agents-view/terminal.js');
-    const result = await runAgentsTui(tuiState);
+    // Wrap: runTui rejects on initial-render failure or handler throw.
+    // On rejection: log and bail — no partial write (avoids PF-014 process.exit).
+    let result;
+    try {
+        result = await runAgentsTui(tuiState);
+    }
+    catch (err) {
+        p.log.error(`Agent editor failed: ${err instanceof Error ? err.message : String(err)}`);
+        process.exitCode = 1;
+        return;
+    }
     if (result.action === 'cancel') {
         p.outro(color.dim('No changes made.'));
         return;